Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

> -Original Message- > From: Fam Zheng [mailto:f...@redhat.com] > Sent: Friday, September 23, 2016 5:59 PM > To: Gonglei (Arei) > Cc: John Snow; pbonz...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel > > On Fri, 09/23 09:39,

Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and little inprovement

> -Original Message- > From: no-re...@patchew.org [mailto:no-re...@patchew.org] > Sent: Saturday, September 24, 2016 10:22 AM > To: Gonglei (Arei) > Cc: f...@redhat.com; qemu-devel@nongnu.org; Gonglei (Arei); Wubin (H) > Subject: Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode

Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and little inprovement

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1474683000-346560-1-git-send-email-arei.gong...@huawei.com Subject: [Qemu-devel] [PATCH v2 0/3]

[Qemu-devel] [PATCH v2 2/3] crypto: extend mode as a parameter in qcrypto_cipher_supports()

It can't guarantee all cipher modes are supported if one cipher algorithm is supported by a backend. Let's extend qcrypto_cipher_supports() to take both the algorithm and mode as parameters. Signed-off-by: Gonglei --- block/qcow.c | 3 ++- block/qcow2.c

[Qemu-devel] [PATCH v2 1/3] crypto: add CTR mode support

Introduce CTR mode support for the cipher APIs. CTR mode uses a counter rather than a traditional IV. The counter has additional properties, including a nonce and initial counter block. We reuse the ctx->iv as the counter for conveniences. Both libgcrypt and nettle are support CTR mode, the

[Qemu-devel] [PATCH v2 3/3] crypto: add mode check in qcrypto_cipher_new() for cipher-builtin

Signed-off-by: Gonglei --- crypto/cipher-builtin.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index fd59a9e..d710608 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-builtin.c @@ -433,6

[Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and little inprovement

Please see the detailed description in each patch. v2: - fix qtest complaint in cipher-builtin backend. - introduce patch 2 and patch 3. Gonglei (3): crypto: add CTR mode support crypto: extend mode as a parameter in qcrypto_cipher_supports() crypto: add mode check in

Re: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

On Fri, Sep 23, 2016 at 08:42:22AM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Thu, Sep 22, 2016 at 03:03:50PM +0100, Peter Maydell wrote: > >> On 22 September 2016 at 07:36, David Gibson > >> wrote: > >> > The

Re: [Qemu-devel] QEMU dtc submodule

On Fri, Sep 23, 2016 at 03:23:26PM +0100, Paul Burton wrote: > On Friday, 23 September 2016 09:13:51 BST Jeff Cody wrote: > > > Leon: Please give the git URL and branch that should be mirrored. It > > > cannot be a tag since that is immutable. Instead it should be the > > > dtc

Re: [Qemu-devel] [PATCH v2] qtest: fix make check complaint in crypto module

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Friday, September 23, 2016 6:21 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Wubin (H) > Subject: Re: [PATCH v2] qtest: fix make check complaint in crypto module > > On Thu, Sep 22, 2016 at

[Qemu-devel] [PATCH v3] qtest: fix make check complaint in crypto module

CCtests/test-crypto-tlscredsx509.o CCtests/crypto-tls-x509-helpers.o CCtests/pkix_asn1_tab.o tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or directory tests/pkix_asn1_tab.c:9: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘pkix_asn1_tab’ make:

Re: [Qemu-devel] [PULL v2 00/19] virtio, pc: fixes and features

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474668213-15643-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL v2 00/19] virtio, pc: fixes and features === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

On Fri, Sep 23, 2016 at 01:35:11PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Type:

[Qemu-devel] [PULL v2 16/19] hw/pci: Prepare for AMD IOMMU

From: David Kiarie Introduce PCI macros from for use by AMD IOMMU Signed-off-by: David Kiarie Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h | 3 +++ 1 file changed,

[Qemu-devel] [PULL v2 11/19] virtio: handle virtqueue_get_avail_bytes() errors

From: Stefan Hajnoczi If the vring is invalid, tell the caller no bytes are available and mark the device broken. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 10/19] virtio: handle virtqueue_map_desc() errors

From: Stefan Hajnoczi Errors can occur during virtqueue_pop(), especially in virtqueue_map_desc(). In order to handle this we must unmap iov[] before returning NULL. The caller will consider the virtqueue empty and the virtio_error() call will have marked the device

[Qemu-devel] [PULL v2 18/19] hw/i386: Introduce AMD IOMMU

From: David Kiarie Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts

[Qemu-devel] [PULL v2 19/19] hw/i386: AMD IOMMU IVRS table

From: David Kiarie Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU. Signed-off-by: David Kiarie Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL v2 09/19] virtio: migrate vdev->broken flag

From: Stefan Hajnoczi Send a subsection if the vdev->broken flag is set. This allows live migration of broken virtio devices. The subsection is only sent if vdev->broken has been set. In most cases the flag will be clear and no subsection will be sent. Signed-off-by:

[Qemu-devel] [PULL v2 15/19] virtio: handle virtqueue_get_head() errors

From: Stefan Hajnoczi Stop processing the vring if virtqueue_get_head() fetches an out-of-bounds head index. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 07/19] virtio: fix stray tab character

From: Stefan Hajnoczi Fix a single occurrence of a tab character in a file that otherwise uses spaces for indentation. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Acked-by: Cornelia Huck

Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

On Fri, Sep 23, 2016 at 01:35:32PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1474658051-18617-1-git-send-email-...@redhat.com > Subject:

[Qemu-devel] [PULL v2 14/19] virtio: handle virtqueue_num_heads() errors

From: Stefan Hajnoczi If the avail ring index is bogus virtqueue_num_heads() must return -EINVAL. The only caller is virtqueue_get_avail_bytes(). Return saying no bytes are available when virtqueue_num_heads() fails. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL v2 17/19] hw/i386/trace-events: Add AMD IOMMU trace events

From: David Kiarie Signed-off-by: David Kiarie Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/trace-events | 29 + 1 file changed, 29 insertions(+)

[Qemu-devel] [PULL v2 05/19] pc: clean up COMPAT macro chaining

From: Igor Mammedov Since commit bacc344c ("machine: add properties to compat_props incrementaly") there is no need to chain per machine type compat macro. Clean up places where it was done anyway so it will be consistent and won't confuse contributors during addtion of

[Qemu-devel] [PULL v2 08/19] virtio: stop virtqueue processing if device is broken

From: Stefan Hajnoczi QEMU prints an error message and exits when the device enters an invalid state. Terminating the process is heavy-handed. The guest may still be able to function even if there is a bug in a virtio guest driver. Moreover, exiting is a bug in nested

[Qemu-devel] [PULL v2 12/19] virtio: use unsigned int for virtqueue_get_avail_bytes() index

From: Stefan Hajnoczi The virtio code uses int, unsigned int, and uint16_t for virtqueue indices. The uint16_t is used for the low-level descriptor layout in virtio_ring.h while code that isn't concerned with descriptor layout can use unsigned int. Use of int is

[Qemu-devel] [PULL v2 13/19] virtio: handle virtqueue_read_next_desc() errors

From: Stefan Hajnoczi Stop processing the vring if an avail ring index is invalid. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 03/19] tests: add /vhost-user/flags-mismatch test

From: Marc-André Lureau Check that qemu disconnects the backend that doesn't have the previously acked features. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 04/19] virtio: add check for descriptor's mapped address

From: Prasad J Pandit virtio back end uses set of buffers to facilitate I/O operations. If its size is too large, 'cpu_physical_memory_map' could return a null address. This would result in a null dereference while un-mapping descriptors. Add check to avoid it.

[Qemu-devel] [PULL v2 00/19] virtio, pc: fixes and features

The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into staging (2016-09-23 15:28:07 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

[Qemu-devel] [PULL v2 02/19] tests: add a simple /vhost-user/multiqueue test

From: Marc-André Lureau This test just checks that 2 virtio-net queues can be setup over vhost-user and waits for them to be started. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v2 06/19] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

From: Igor Mammedov commit (14c985cff target-i386: present virtual L3 cache info for vcpus) misplaced compat property putting it in new 2.8 machine type which would effectively to disable feature until 2.9 is released. Intent of commit probably should be to disable feature

[Qemu-devel] [PULL v2 01/19] tests: add /vhost-user/connect-fail test

From: Marc-André Lureau Check early connection failure and resume. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 39

Re: [Qemu-devel] [PATCH] tcg: increase MAX_OP_PER_INSTR to 395

On Fri, 23 Sep 2016, Richard Henderson wrote: > While increasing the max per insn is indeed one way to approach this, aarch64 > is being remarkably inefficient in this case. With the following, I see a > reduction from 387 ops to 261 ops; for a 64-bit host, the reduction is from > 258 ops to 195

Re: [Qemu-devel] [PATCH 0/3] RDMA error handling

Reviewed-by: Michael R. Hines (By the way, I no longer work for IBM and no longer have direct access to RDMA hardware. If someone is willing to let me login to something that does in the future, I don't mind debugging things. I just don't have any hardware of my own

Re: [Qemu-devel] write_zeroes/trim on the whole disk

On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: > My preference would be a new flag to the existing commands, with > explicit documentation that 0 offset and 0 length must be used with that > flag, when requesting a full-device wipe. Alternatively, what about a flag that says "if you

Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1474658051-18617-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 00/19] virtio, pc:

Re: [Qemu-devel] [PATCH 6/7] target-i386: xsave: Calculate set of xsave components on realize

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: Instead of doing complex calculations and calling kvm_arch_get_supported_cpuid() inside cpu_x86_cpuid(), calculate the set of required XSAVE components earlier, at realize time. Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [PATCH 7/7] target-i386: Move xsave component mask to features array

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: This will reuse the existing check/enforce logic in x86_cpu_filter_features() to check the xsave component bits against GET_SUPPORTED_CPUID. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 42

Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474658051-18617-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] qapi: make the json schema files more regular.

On Thu, Sep 22, 2016 at 6:07 AM, Eric Blake wrote: > On 09/21/2016 11:00 PM, David Anderson wrote: > > This makes it easier to parse the schema file for tool generation: > > each paragraph is either a non-docstring comment, or a docstring > > immediately followed by a Python

Re: [Qemu-devel] [PATCH 4/7] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: Instead of assigning individual bits in a loop, just copy the values from ena_mask. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Richard

Re: [Qemu-devel] [PATCH 1/7] target-i386: Move feature name arrays inside FeatureWordInfo

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: It makes it easier to guarantee the arrays are the right size, and to find information when looking at the code. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 370

[Qemu-devel] [PULL 18/19] hw/i386: Introduce AMD IOMMU

From: David Kiarie Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts

[Qemu-devel] [PULL 19/19] hw/i386: AMD IOMMU IVRS table

From: David Kiarie Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU. Signed-off-by: David Kiarie Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 13/19] virtio: handle virtqueue_read_next_desc() errors

From: Stefan Hajnoczi Stop processing the vring if an avail ring index is invalid. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 12/19] virtio: use unsigned int for virtqueue_get_avail_bytes() index

From: Stefan Hajnoczi The virtio code uses int, unsigned int, and uint16_t for virtqueue indices. The uint16_t is used for the low-level descriptor layout in virtio_ring.h while code that isn't concerned with descriptor layout can use unsigned int. Use of int is

[Qemu-devel] [PULL 17/19] hw/i386/trace-events: Add AMD IOMMU trace events

From: David Kiarie Signed-off-by: David Kiarie Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/trace-events | 29 + 1 file changed, 29 insertions(+)

Re: [Qemu-devel] [PATCH] qapi: make the json schema files more regular.

Hi - Original Message - > On Thu, Sep 22, 2016 at 6:07 AM, Eric Blake wrote: > > > On 09/21/2016 11:00 PM, David Anderson wrote: > > > This makes it easier to parse the schema file for tool generation: > > > each paragraph is either a non-docstring comment, or a

[Qemu-devel] [PULL 11/19] virtio: handle virtqueue_get_avail_bytes() errors

From: Stefan Hajnoczi If the vring is invalid, tell the caller no bytes are available and mark the device broken. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 16/19] hw/pci: Prepare for AMD IOMMU

From: David Kiarie Introduce PCI macros from for use by AMD IOMMU Signed-off-by: David Kiarie Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h | 3 +++ 1 file changed,

Re: [Qemu-devel] [PATCH] qapi: make the json schema files more regular.

On 09/23/2016 03:04 PM, David Anderson wrote: > On Thu, Sep 22, 2016 at 6:07 AM, Eric Blake wrote: > >> On 09/21/2016 11:00 PM, David Anderson wrote: >>> This makes it easier to parse the schema file for tool generation: >>> each paragraph is either a non-docstring comment, or

Re: [Qemu-devel] [PATCH 5/7] target-i386: xsave: Helper function to calculate xsave area size

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: Move the xsave area size calculation from cpu_x86_cpuid() inside its own function. While doing it, change it to use the XSAVE area struct sizes for the initial size, instead of the magic 0x240 number. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 10/19] virtio: handle virtqueue_map_desc() errors

From: Stefan Hajnoczi Errors can occur during virtqueue_pop(), especially in virtqueue_map_desc(). In order to handle this we must unmap iov[] before returning NULL. The caller will consider the virtqueue empty and the virtio_error() call will have marked the device

[Qemu-devel] [PULL 08/19] virtio: stop virtqueue processing if device is broken

From: Stefan Hajnoczi QEMU prints an error message and exits when the device enters an invalid state. Terminating the process is heavy-handed. The guest may still be able to function even if there is a bug in a virtio guest driver. Moreover, exiting is a bug in nested

Re: [Qemu-devel] [PATCH 2/7] target-i386: Don't try to enable PT State xsave component

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: The code that calculates the set of supported XSAVE components on CPUID looks at ext_save_areas to find out which components should be enabled. However, if there are zeroed entries in the ext_save_areas array, the ((env->features[esa->feature] &

[Qemu-devel] [PULL 09/19] virtio: migrate vdev->broken flag

From: Stefan Hajnoczi Send a subsection if the vdev->broken flag is set. This allows live migration of broken virtio devices. The subsection is only sent if vdev->broken has been set. In most cases the flag will be clear and no subsection will be sent. Signed-off-by:

[Qemu-devel] [PULL 05/19] pc: clean up COMPAT macro chaining

From: Igor Mammedov Since commit bacc344c ("machine: add properties to compat_props incrementaly") there is no need to chain per machine type compat macro. Clean up places where it was done anyway so it will be consistent and won't confuse contributors during addtion of

[Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into staging (2016-09-23 15:28:07 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

[Qemu-devel] [PULL 06/19] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

From: Igor Mammedov commit (14c985cff target-i386: present virtual L3 cache info for vcpus) misplaced compat property putting it in new 2.8 machine type which would effectively to disable feature until 2.9 is released. Intent of commit probably should be to disable feature

[Qemu-devel] [PULL 15/19] virtio: handle virtqueue_get_head() errors

From: Stefan Hajnoczi Stop processing the vring if virtqueue_get_head() fetches an out-of-bounds head index. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 3/7] target-i386: xsave: Calculate enabled components only once

On 09/23/2016 12:45 PM, Eduardo Habkost wrote: Instead of checking both env->features and ena_mask at two different places in the CPUID code, initialize ena_mask based on the features that are enabled for the CPU, and then clear unsupported bits based on kvm_arch_get_supported_cpuid(). The

[Qemu-devel] [PULL 04/19] virtio: add check for descriptor's mapped address

From: Prasad J Pandit virtio back end uses set of buffers to facilitate I/O operations. If its size is too large, 'cpu_physical_memory_map' could return a null address. This would result in a null dereference while un-mapping descriptors. Add check to avoid it.

[Qemu-devel] [PULL 07/19] virtio: fix stray tab character

From: Stefan Hajnoczi Fix a single occurrence of a tab character in a file that otherwise uses spaces for indentation. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Acked-by: Cornelia Huck

[Qemu-devel] [PULL 02/19] tests: add a simple /vhost-user/multiqueue test

From: Marc-André Lureau This test just checks that 2 virtio-net queues can be setup over vhost-user and waits for them to be started. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 14/19] virtio: handle virtqueue_num_heads() errors

From: Stefan Hajnoczi If the avail ring index is bogus virtqueue_num_heads() must return -EINVAL. The only caller is virtqueue_get_avail_bytes(). Return saying no bytes are available when virtqueue_num_heads() fails. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 03/19] tests: add /vhost-user/flags-mismatch test

From: Marc-André Lureau Check that qemu disconnects the backend that doesn't have the previously acked features. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 01/19] tests: add /vhost-user/connect-fail test

From: Marc-André Lureau Check early connection failure and resume. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 39

Re: [Qemu-devel] [PATCH] tcg: increase MAX_OP_PER_INSTR to 395

On 09/22/2016 04:53 PM, Joseph Myers wrote: MAX_OP_PER_INSTR is currently 266, reported in commit 14dcdac82f398cbac874c8579b9583fab31c67bf to be the worst case for the ARM A64 decoder. Whether or not it was in fact the worst case at that time in 2014, I'm observing the instruction 0x4c006020

[Qemu-devel] [PATCH 6/7] target-i386: xsave: Calculate set of xsave components on realize

Instead of doing complex calculations and calling kvm_arch_get_supported_cpuid() inside cpu_x86_cpuid(), calculate the set of required XSAVE components earlier, at realize time. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 51

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: > On 09/22/2016 01:42 PM, Eduardo Habkost wrote: [...] > > In the case of the inject-nmi QMP command, I need to understand > > what "default CPU" is supposed to mean in the inject-nmi > > documentation. Maybe it can be changed to use

[Qemu-devel] [PATCH 2/7] target-i386: Don't try to enable PT State xsave component

The code that calculates the set of supported XSAVE components on CPUID looks at ext_save_areas to find out which components should be enabled. However, if there are zeroed entries in the ext_save_areas array, the ((env->features[esa->feature] & esa->bits) == esa->bits) check will always succeed

[Qemu-devel] [PATCH 7/7] target-i386: Move xsave component mask to features array

This will reuse the existing check/enforce logic in x86_cpu_filter_features() to check the xsave component bits against GET_SUPPORTED_CPUID. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 42 -- target-i386/cpu.h | 3 ++- 2

[Qemu-devel] [PATCH 5/7] target-i386: xsave: Helper function to calculate xsave area size

Move the xsave area size calculation from cpu_x86_cpuid() inside its own function. While doing it, change it to use the XSAVE area struct sizes for the initial size, instead of the magic 0x240 number. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22

[Qemu-devel] [PATCH 3/7] target-i386: xsave: Calculate enabled components only once

Instead of checking both env->features and ena_mask at two different places in the CPUID code, initialize ena_mask based on the features that are enabled for the CPU, and then clear unsupported bits based on kvm_arch_get_supported_cpuid(). The results should be exactly the same, but it will make

[Qemu-devel] [PATCH 1/7] target-i386: Move feature name arrays inside FeatureWordInfo

It makes it easier to guarantee the arrays are the right size, and to find information when looking at the code. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 370 +- 1 file changed, 170 insertions(+), 200

[Qemu-devel] [PATCH 4/7] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation

Instead of assigning individual bits in a loop, just copy the values from ena_mask. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9968581..7e66003

[Qemu-devel] [PATCH 0/7] target-i386: xsave CPUID handling refactor

This series refactor the xsave CPUID handling so it won't silently disable any XSAVE components on CPUID[0xD] in case the host doesn't support it. It will instead use the exisitng check/enforce logic for filtering the CPUID bits and checking for host-side support. This series is available on git

Re: [Qemu-devel] 9p as rootfs

And most important, while mounting as roots, error is: [1.086235] device: '9p-1': device_add [1.087859] 9pnet_virtio: no channels available [1.091619] device: '9p-1': device_unregister [1.092783] device: '9p-1': device_create_release [1.093534] VFS: Cannot open root device

[Qemu-devel] 9p as rootfs

Hello, I have a problem in my custom arm machine to use 9p fs as a rootfs. 9p command line i qemu: /-device virtio-9p-device,fsdev=host_fs,mount_tag=hostfs -fsdev local,id=host_fs,security_model=none,path=/work/rootfs/ Kernel cmd line: /--append "root=hostfs rootfstype=9p

Re: [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray

On 09/23/2016 11:35 AM, Max Reitz wrote: On 23.09.2016 03:45, John Snow wrote: When I said "Final re-send," I was lying. Here's a v5. The title is also a misnomer by now :) The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but

[Qemu-devel] [PATCH 3/3] migration/rdma: Don't flag an error when we've been told about one

From: "Dr. David Alan Gilbert" If the other side tells us there's been an error and we fail the migration, we don't need to signal that failure to the other side because it already knew. Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 6

[Qemu-devel] [PATCH 1/3] migration/rdma: Pass qemu_file errors across link

From: "Dr. David Alan Gilbert" If we fail for some reason (e.g. a mismatched RAMBlock) and it's set the qemu_file error flag, pass that error back to the peer so it can clean up rather than waiting for some higher level progress. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH 2/3] migration: Make failed migration load set file error

From: "Dr. David Alan Gilbert" If an error occurs in a section load, set the file error flag so that the transport can get notified to do a cleanup. Signed-off-by: Dr. David Alan Gilbert --- migration/savevm.c | 19 --- 1 file changed,

[Qemu-devel] [PATCH 0/3] RDMA error handling

From: "Dr. David Alan Gilbert" lp: https://bugs.launchpad.net/qemu/+bug/1545052 The RDMA code tends to hang if the destination dies in the wrong place; this series doesn't completely fix that, but in cases where the destination knows there's been an error, it makes sure it

Re: [Qemu-devel] [PATCH 0/3] vhost-user tests

On Fri, Sep 23, 2016 at 07:10:02PM +, Marc-André Lureau wrote: > > Hi > > On Fri, Sep 9, 2016 at 3:36 PM Marc-André Lureau > wrote: > > Hi, > > The following tests have been post-poned for after 2.7 from the > vhost-user-reconnect series. > > >

Re: [Qemu-devel] [PATCH 0/3] vhost-user tests

Hi On Fri, Sep 9, 2016 at 3:36 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi, > > The following tests have been post-poned for after 2.7 from the > vhost-user-reconnect series. > ping > > They have been rebased and fixed to work with last changes. > > Marc-André Lureau (3):

Re: [Qemu-devel] write_zeroes/trim on the whole disk

On 09/23/2016 01:32 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is a following problem. When we need to write_zeroes or trim the > whole disk, we have to do it iteratively, because of 32-bit restriction > on request length. > For example, current implementation of mirror (see

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

On 9/23/2016 12:55 AM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, September 21, 2016 12:23 AM >>> > I have > a hard time believing that a given vendor can even allocate unique type > ids for their own devices. Unique type id across

[Qemu-devel] write_zeroes/trim on the whole disk

Hi all! There is a following problem. When we need to write_zeroes or trim the whole disk, we have to do it iteratively, because of 32-bit restriction on request length. For example, current implementation of mirror (see mirror_dirty_init()) do this by chunks of 2147418112 bytes (with default

Re: [Qemu-devel] [PATCH 4/7] m25p80: add a m25p80_set_rom_storage() routine

Hi Cedric, W dniu 23.09.2016 o 10:28, Cédric Le Goater pisze: On 09/23/2016 10:17 AM, Peter Maydell wrote: On 23 September 2016 at 08:19, Cédric Le Goater wrote: But the goal is to boot from the device, so I added a memory region alias at 0 to trigger the flash module mmios at

Re: [Qemu-devel] [PATCH 5/6] tests/tcg: Add and update Makefiles

Hello, On Sat, Sep 17, 2016 at 7:03 AM, Pranith Kumar wrote: [...] > diff --git a/tests/tcg/xtensa/Makefile b/tests/tcg/xtensa/Makefile > index 522a63e..e3269ed 100644 > --- a/tests/tcg/xtensa/Makefile > +++ b/tests/tcg/xtensa/Makefile > @@ -1,10 +1,23 @@ > --include

Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

On 09/23/2016 12:31 AM, Paolo Bonzini wrote: +if (atomic_read(_cpu->running)) { ... +atomic_set(>running, true); ... +cpu->running = false; ... +cpu->running = true; Inconsistent use of atomics. I don't see that the cpu_list_lock protects the last

Re: [Qemu-devel] [PATCH 15/16] tcg: Make tb_flush() thread safe

On 09/23/2016 12:31 AM, Paolo Bonzini wrote: +unsigned tb_flush_req = (unsigned) (uintptr_t) data; Extra cast? -tcg_ctx.tb_ctx.tb_flush_count++; +atomic_inc(_ctx.tb_ctx.tb_flush_count); Since this is the only place this value is incremented, and we're under a lock, it should

[Qemu-devel] [PATCH] Add more APIC state to dump

From: "Dr. David Alan Gilbert" Add the rest of the APIC state to the 'info lapic' dump, since it is of course state that wasn't printed that I'd messed up. You now have output like: (qemu) info lapic dumping local APIC state for CPU 1 apicbase 0xfee00c00 ID 1 Version 20

Re: [Qemu-devel] vhost-user-test failure

On 09/23/2016 05:41 PM, Michael S. Tsirkin wrote: On Fri, Sep 23, 2016 at 12:36:12PM -0300, Eduardo Habkost wrote: Hi, I hit a weird vhost-user-test failure on travis-ci recently, on a branch where I didn't touch any vhost-related code. From a quick look at the code, it looks like the

Re: [Qemu-devel] [PATCH v2 1/3] block: Add '-blockdev' command line option

On 23.09.2016 18:06, Kevin Wolf wrote: > This is an option that is directly mapped to the blockdev-add QMP > command. It works more or less like -drive, except that it doesn't > create a BlockBackend and doesn't support legacy options. > > This patch adds minimal documentation, the next patches

Re: [Qemu-devel] [PATCH v2 3/3] doc: Document driver-specific -blockdev options

On 23.09.2016 18:06, Kevin Wolf wrote: > This documents the driver-specific options for the raw, qcow2 and file > block drivers for the man page. For everything else, we refer to the > QAPI documentation. > > Signed-off-by: Kevin Wolf > --- > qemu-options.hx | 104 >

Re: [Qemu-devel] [PATCH 14/16] cpus-common: Introduce async_safe_run_on_cpu()

On 09/23/2016 12:31 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- cpus-common.c | 33 +++-- include/qom/cpu.h | 14 ++ 2 files changed, 45 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson

  1   2   3   4   >