Re: [Qemu-devel] [PATCH v2 2/8] spapr: move the IRQ server number mapping under the machine

On Thu, Mar 16, 2017 at 03:35:06PM +0100, Cédric Le Goater wrote: > This is the second step to abstract the IRQ 'server' number of the > XICS layer. Now that the prereq cleanups have been done in the > previous patch, we can move down the 'cpu_dt_id' to 'cpu_index' > mapping in the sPAPR machine

Re: [Qemu-devel] [PATCH v2 5/8] ppc/pnv: create the ICP and ICS objects under the machine

On Thu, Mar 16, 2017 at 03:35:09PM +0100, Cédric Le Goater wrote: > Like this is done for the sPAPR machine, we use a simple array under > the PowerNV machine to store the Interrupt Control Presenters (ICP) > objects, one for each vCPU. This array is indexed by 'cpu_index' of > the CPUState but

Re: [Qemu-devel] [PATCH v2 8/8] ppc/pnv: add memory regions for the ICP registers

On Thu, Mar 16, 2017 at 03:35:12PM +0100, Cédric Le Goater wrote: > This provides to a PowerNV chip (POWER8) access to the Interrupt > Management area, which contains the registers of the Interrupt Control > Presenters of each thread. These are used to accept, return, forward > interrupts in the

Re: [Qemu-devel] [PATCH v2 7/8] ppc/pnv: link the CPUs to the machine XICSFabric

On Thu, Mar 16, 2017 at 03:35:11PM +0100, Cédric Le Goater wrote: > This assigns the ICPState object to the CPU using the PIR number for > lookups before calling the XICS layer to finish the job. > > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH v2 6/8] ppc/pnv: add a helper to calculate MMIO addresses registers

On Thu, Mar 16, 2017 at 03:35:10PM +0100, Cédric Le Goater wrote: > Some controllers (ICP, PSI) have a base register address which is > calculated using the chip id. > > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson > --- >

Re: [Qemu-devel] [PATCH v2 3/8] ppc/xics: add a realize() handler to ICPStateClass

On Thu, Mar 16, 2017 at 03:35:07PM +0100, Cédric Le Goater wrote: > It will be used by derived classes in PowerNV for customization. > > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson > --- > hw/intc/xics.c| 5 + >

Re: [Qemu-devel] [PATCH v2 4/8] ppc/pnv: add a PnvICPState object

On Thu, Mar 16, 2017 at 03:35:08PM +0100, Cédric Le Goater wrote: > This provides a new ICPState object for the PowerNV machine (POWER8). > Access to the Interrupt Management area is done though a memory > region. It contains the registers of the Interrupt Control Presenters > of each thread which

Re: [Qemu-devel] [PATCH v2 3/3] vfio-pci: process non fatal error of AER

On 03/22/2017 09:27 PM, Michael S. Tsirkin wrote: > On Wed, Mar 22, 2017 at 06:36:52PM +0800, Cao jin wrote: >> Make use of the non fatal error eventfd that the kernel module provide >> to process the AER non fatal error. Fatal error still goes into the >> legacy way which results in VM stop. >>

[Qemu-devel] [Resend PATCH] migration: Fix colo hang in socket_accept_incoming_migration

Due to the feature of accept channel does not support QIO_CHANNEL_FEATURE_SHUTDOWN. when failover,channel_shutdown could not shut down the channel. So the colo_process_incoming_thread will hang at recvmsg. This patch just call qio_channel_socket_new to get channel, Which set

Re: [Qemu-devel] [PATCH] Fix colo hang in socket_accept_incoming_migration

Hi, This series failed build test on s390x host. Please find the details below. Message-id: 1490236226-30248-1-git-send-email-wang.guan...@zte.com.cn Type: series Subject: [Qemu-devel] [PATCH] Fix colo hang in socket_accept_incoming_migration === TEST SCRIPT BEGIN === #!/bin/bash # Testing

[Qemu-devel] [PATCH] Fix colo hang in socket_accept_incoming_migration

Due to the feature of accept channel does not support QIO_CHANNEL_FEATURE_SHUTDOWN. when failover,channel_shutdown could not shut down the channel. So the colo_process_incoming_thread will hang at recvmsg. This patch just call qio_channel_socket_new to get channel, Which set

Re: [Qemu-devel] [PATCH v5] vfio error recovery: kernel support

On 03/22/2017 09:10 PM, Michael S. Tsirkin wrote: > Minor comments on commit log below. > > On Wed, Mar 22, 2017 at 06:34:23PM +0800, Cao jin wrote: >> From: "Michael S. Tsirkin" >> > >> Signed-off-by: Michael S. Tsirkin >> Signed-off-by: Cao jin

[Qemu-devel] [Bug 1675108] [NEW] Cocoa UI always crashes on startup

Public bug reported: Commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5 ("ui/console: ensure graphic updates don't race with TCG vCPUs") causes the graphic update to run on a non-main thread, which Cocoa is not happy with. It crashes immediately after startup. $ i386-softmmu/qemu-system-i386

[Qemu-devel] help please how to use qemu.

step by step instructions please

Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

> > > On 03/22/2017 01:36 PM, Halil Pasic wrote: > > We already check for queues == 1 in cryptodev_builtin_init and when that > > is not true raise an error. But before that error is reported the > > assertion in cryptodev_builtin_cleanup kicks in (because object is being > > finalized and

Re: [Qemu-devel] [PATCH for-2.9?] file-posix: Make bdrv_flush() failure permanent without O_DIRECT

On 03/22/2017 04:00 PM, Kevin Wolf wrote: > Success for bdrv_flush() means that all previously written data is safe > on disk. For fdatasync(), the best semantics we can hope for on Linux > (without O_DIRECT) is that all data that was written since the last call > was successfully written back.

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange wrote: > On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >> On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: >> > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange

Re: [Qemu-devel] [PATCH for-2.9?] file-posix: Make bdrv_flush() failure permanent without O_DIRECT

On Wed, 03/22 22:00, Kevin Wolf wrote: > Success for bdrv_flush() means that all previously written data is safe > on disk. For fdatasync(), the best semantics we can hope for on Linux > (without O_DIRECT) is that all data that was written since the last call > was successfully written back.

Re: [Qemu-devel] [PATCH RESEND 2/3] device_tree: fix compiler warnings (clang 5)

On Thu, Mar 23, 2017 at 12:49 AM Philippe Mathieu-Daudé wrote: > static code analyzer complain: > > device_tree.c:155:18: warning: Null pointer passed as an argument to a > 'nonnull' parameter > while ((de = readdir(d)) != NULL) { > ^~ > >

Re: [Qemu-devel] rawhide gcc failures [was: Proposal for deprecating unsupported host OSes & architecutures]

On 22 March 2017 at 19:07, Eric Blake wrote: > Tangentially-related: do we officially support bleeding-edge OS builds? > For example, current rawhide has a new-enough gcc that gives some > (possibly-useful) new warnings (-Werror=format-truncation) Depends what you mean by

Re: [Qemu-devel] [PATCH RESEND 3/3] qga: fix compiler warnings (clang 5)

Quoting Philippe Mathieu-Daudé (2017-03-22 15:48:44) > static code analyzer complain: > > qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a > 'nonnull' parameter > closedir(dp); > ^~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by:

[Qemu-devel] [PATCH for-2.9?] file-posix: Make bdrv_flush() failure permanent without O_DIRECT

Success for bdrv_flush() means that all previously written data is safe on disk. For fdatasync(), the best semantics we can hope for on Linux (without O_DIRECT) is that all data that was written since the last call was successfully written back. Therefore, and because we can't redo all writes

[Qemu-devel] [PATCH RESEND 3/3] qga: fix compiler warnings (clang 5)

static code analyzer complain: qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a 'nonnull' parameter closedir(dp); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH RESEND 2/3] device_tree: fix compiler warnings (clang 5)

static code analyzer complain: device_tree.c:155:18: warning: Null pointer passed as an argument to a 'nonnull' parameter while ((de = readdir(d)) != NULL) { ^~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH RESEND 0/3] easy-to-fix clang warnings

This patchset fixes three easy-to-fix clang warnings. Resent adding Marc-André Lureau's Reviewed-by and CC'ing qemu-trivial as suggested by Markus Armbruster. Philippe Mathieu-Daudé (3): usb-ccid: make ccid_write_data_block() cope with null buffers device_tree: fix compiler warnings (clang

Re: [Qemu-devel] q35 and sysbus devices

On 03/22/17 21:31, Eduardo Habkost wrote: > Hi, > > I am investigating the current status of has_dynamic_sysbus and > sysbus device support on each of QEMU's machine types. The good > news is that almost all has_dynamic_sysbus=1 machines have their > own internal (often short) whitelist of

[Qemu-devel] q35 and sysbus devices

Hi, I am investigating the current status of has_dynamic_sysbus and sysbus device support on each of QEMU's machine types. The good news is that almost all has_dynamic_sysbus=1 machines have their own internal (often short) whitelist of supported sysbus device types, and automatically reject

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On 03/23/2017 02:29 AM, Pranith Kumar wrote: On Wed, Mar 22, 2017 at 11:21 AM, Peter Maydell wrote: On 22 March 2017 at 15:14, Pranith Kumar wrote: On Wed, Mar 22, 2017 at 11:04 AM, Peter Maydell wrote: This

Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

On Wed, 2017-03-22 at 15:36 +0100, Laszlo Ersek wrote: >  > To my knowledge, currently the bootindex properties cannot be changed > dynamically (for example with monitor commands) after they have been > specified on the QEMU command line. Yes they can, via QMP: {'execute': 'qom-get',

Re: [Qemu-devel] rawhide gcc failures [was: Proposal for deprecating unsupported host OSes & architecutures]

so lovely... as a start point for bleeding edge stuff this can go in CI as a complement of debian images in tests/docker/... using the official fedora:rawhide base image. On 03/22/2017 04:07 PM, Eric Blake wrote: On 03/16/2017 10:23 AM, Peter Maydell wrote: OK, here's a concrete proposal

Re: [Qemu-devel] [PATCH v3 0/8] qemu-img: add measure sub-command

On Wed, Mar 22, 2017 at 2:28 PM Stefan Hajnoczi wrote: > v3: > * Drop RFC, this is ready to go for QEMU 2.10 > * Use "required size" instead of "required bytes" in qemu-img output for >consistency [Nir] > * Clarify BlockMeasureInfo semantics [Max] > * Clarify

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

Hello Cédric, with your last message you made me think about and make more test. >The default machine for qemu-system-ppc64 is pseries. yes usually with 2.8 i boot the VM without issue on G5 Quad with the option -M pseries from 2.1 to 2.5 with kvm-pr enabled. i did the tests and with all

Re: [Qemu-devel] [PATCH 0/3] script for crash-testing -device

On Wed, Mar 22, 2017 at 01:00:49PM -0300, Eduardo Habkost wrote: > This series adds scripts/device-crashtest.py, that can be used to > crash-test -device with multiple machine/accel/device > combinations. > > The script found a few crashes on some machines/devices. A dump > of existing cases can

[Qemu-devel] rawhide gcc failures [was: Proposal for deprecating unsupported host OSes & architecutures]

On 03/16/2017 10:23 AM, Peter Maydell wrote: > OK, here's a concrete proposal for deprecating/dropping out of > date host OS and architecture support. > > We'll put this in the ChangeLog 'Future incompatible changes' > section: > - > * Removal of support for untested host OS and

Re: [Qemu-devel] [PATCH v3] qemu/thread: Add support for error reporting in qemu_thread_create

Thank you for the detailed review. The indentation errors mentioned were pure carelesness on my part, sorry about that. On 3/22/17 2:20 PM, Eric Blake wrote: >> @@ -342,13 +343,19 @@ static void pci_edu_realize(PCIDevice *pdev, Error >> **errp) >> { >> EduState *edu = DO_UPCAST(EduState,

Re: [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input

Eric Blake writes: > On 03/22/2017 12:48 PM, Markus Armbruster wrote: >> From: Eric Blake >> >> An off-by-one in commit 15c2f669e meant that we were failing to >> check for unparsed input in all QemuOpts visitors. Recent testsuite >> additions show that

Re: [Qemu-devel] [PATCH v4] xen: use libxendevice model to restrict operations

On Wed, 22 Mar 2017, Paul Durrant wrote: > This patch adds a command-line option (-xen-domid-restrict) which will > use the new libxendevicemodel API to restrict devicemodel [1] operations > to the specified domid. (Such operations are not applicable to the xenpv > machine type). > > This patch

[Qemu-devel] [PULL v3 for-2.9 02/17] keyval: Improve some comments

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- util/keyval.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PULL v3 for-2.9 06/17] qapi: Drop excessive Make dependencies on qapi2texi.py

When qapi2texi.py changes, we regenerate everything QAPI. Screwed up in commit 56e8bdd. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-2-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- Makefile | 7 --- 1

[Qemu-devel] [PULL v3 for-2.9 09/17] tests/qapi-schema: Make test-qapi.py print docs again

test-qapi.py used to print the internal representation of doc comments (commit 3313b61). This went away when we dropped the doc comments in positive tests (commit 87c16dc). Bring it back, because I'm going to add real positive doc comment tests. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL v3 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input

From: Eric Blake An off-by-one in commit 15c2f669e meant that we were failing to check for unparsed input in all QemuOpts visitors. Recent testsuite additions show that fixing the obvious bug with bogus fields will also fix the case of an incomplete list visit; update the

[Qemu-devel] [PULL v3 for-2.9 10/17] tests/qapi-schema: Systematic positive doc comment tests

We have a number of negative tests, but we don't have systematic positive coverage. Fix that. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-6-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau ---

[Qemu-devel] [PULL v3 for-2.9 14/17] test-qobject-input-visitor: Cover visit_type_uint64()

The new test demonstrates known bugs: integers between INT64_MAX+1 and UINT64_MAX rejected, and integers between INT64_MIN and -1 are accepted modulo 2^64. Signed-off-by: Markus Armbruster Message-Id: <1490118290-6133-1-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake

[Qemu-devel] [PULL v3 for-2.9 00/17] QAPI patches for 2017-03-22

v3 (third time's a charm) * Actually squash it into 16/17, not 17/17 v2: * Leak fix squashed into 16/17 The following changes since commit 940a8ce075e3408742a4edcabfd6c2a15e2539eb: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-03-20 16:34:26 +) are

[Qemu-devel] [PULL v3 for-2.9 11/17] qapi2texi: Fix translation of *strong* and _emphasized_

Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-7-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi2texi.py| 4 ++-- tests/qapi-schema/doc-good.texi | 8 2 files changed, 6

[Qemu-devel] [PULL v3 for-2.9 16/17] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

From: Eric Blake A regression in commit 15c2f669e caused us to silently ignore excess input to the QemuOpts visitor. Later, commit ea4641 accidentally abused that situation, by removing "qom-type" and "id" from the corresponding QDict but leaving them defined in the QemuOpts,

[Qemu-devel] [PULL v3 for-2.9 05/17] MAINTAINERS: Add myself for files I touched recently

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-6-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 779c429..c60235e

[Qemu-devel] [PULL v3 for-2.9 08/17] qapi: Drop unused QAPIDoc member optional

Unused since commit aa964b7 "qapi2texi: Convert to QAPISchemaVisitor" Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-4-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi.py | 1 - 1 file changed, 1

[Qemu-devel] [PULL v3 for-2.9 15/17] tests: Expose regression in QemuOpts visitor

From: Eric Blake Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression went unnoticed because of missing testsuite coverage. Add a test to cover this; take the approach already used in 9cb8ef3 of adding a test that

[Qemu-devel] [PULL v3 for-2.9 13/17] Revert "hostmem: fix QEMU crash by 'info memdev'"

This reverts commit 1454d33f0507cb54d62ed80f494884157c9e7130. The string input visitor regression fixed in the previous commit made visit_type_uint16List() fail on empty input. query_memdev() calls it via object_property_get_uint16List(). Because it doesn't expect it to fail, it passes _abort,

[Qemu-devel] [PULL v3 for-2.9 03/17] test-keyval: Cover alternate and 'any' type

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- tests/Makefile.include | 2 +- tests/test-keyval.c| 53 ++ 2 files changed,

[Qemu-devel] [PULL v3 for-2.9 01/17] test-keyval: Tweaks to improve list coverage

We have a negative test case for a list index with leading zero. Add positive ones. Tweak the test case for list index greater or equal the number of elements: test "equal" instead of "greater" to guard against off-by-one mistakes. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL v3 for-2.9 12/17] qapi: Fix string input visitor regression for empty lists

Visiting a list when input is the empty string should result in an empty list, not an error. Noticed when commit 3d089ce belatedly added tests, but simply accepted as weird then. It's actually a regression: broken in commit 74f24cb, v2.7.0. Fix it, and throw in another test case for empty

[Qemu-devel] [PULL v3 for-2.9 04/17] keyval: Document issues with 'any' and alternate types

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-5-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- util/keyval.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/util/keyval.c b/util/keyval.c index 46cd540..93d5db6

[Qemu-devel] [PULL v3 for-2.9 07/17] qapi2texi: Fix to actually fail when 'doc-required' is false

Messed up in commit bc52d03. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-3-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi2texi.py | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [Xen-devel] [PATCH v4 0/8] xen/9pfs: introduce the Xen 9pfs backend

On Wed, 22 Mar 2017, Greg Kurz wrote: > On Tue, 21 Mar 2017 13:14:02 -0700 (PDT) > Stefano Stabellini wrote: > > > On Tue, 21 Mar 2017, Greg Kurz wrote: > > > On Mon, 20 Mar 2017 11:18:46 -0700 (PDT) > > > Stefano Stabellini wrote: > > > > > >

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

Hello Luigi, On 03/22/2017 06:49 PM, luigi burdo wrote: > i have the 4.11rc1 . onfedora 25 ppc 64 on both machine Qoriq and on G5Quad. > > On the 2.8 this issue isnt presentbut > I did the test o Qoriq e5500 a book3e processor and on 2.8 if i made: > > qemu-system-ppc64 --enable-kvm the true

Re: [Qemu-devel] [PATCH v1 2/2] reduce qemu's heap Rss size from 12252kB to 2752KB

> So please send it to the list with Signed-off-by line. Thanks, > > DPRINTF("handle_mmio\n"); > /* Called outside BQL */ > address_space_rw(_space_memory, > run->mmio.phys_addr, attrs, >

Re: [Qemu-devel] [PATCH v2 for-2.9] block: Declare blockdev-add and blockdev-del supported

Max Reitz writes: > On 22.03.2017 17:20, Markus Armbruster wrote: >> It's been a long journey, but here we are. >> >> The supported blockdev-add is not compatible to its experimental >> predecessors; bump all Since: tags to 2.9. >> >> x-blockdev-remove-medium,

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

On Wed, 22 Mar 2017, Juergen Gross wrote: > On 21/03/17 19:54, Stefano Stabellini wrote: > > On Tue, 21 Mar 2017, Juergen Gross wrote: > >> On 17/03/17 19:33, Stefano Stabellini wrote: > >>> On Fri, 17 Mar 2017, Juergen Gross wrote: > On 16/03/17 21:20, Stefano Stabellini wrote: > > On

Re: [Qemu-devel] [PATCH v2 for-2.9] block: Declare blockdev-add and blockdev-del supported

On 03/22/2017 12:13 PM, Max Reitz wrote: > On 22.03.2017 17:20, Markus Armbruster wrote: >> It's been a long journey, but here we are. >> >> The supported blockdev-add is not compatible to its experimental >> predecessors; bump all Since: tags to 2.9. >> >> x-blockdev-remove-medium,

[Qemu-devel] [PULL v2 for-2.9 10/17] tests/qapi-schema: Systematic positive doc comment tests

We have a number of negative tests, but we don't have systematic positive coverage. Fix that. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-6-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau ---

[Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input

From: Eric Blake An off-by-one in commit 15c2f669e meant that we were failing to check for unparsed input in all QemuOpts visitors. Recent testsuite additions show that fixing the obvious bug with bogus fields will also fix the case of an incomplete list visit; update the

[Qemu-devel] [PULL v2 for-2.9 15/17] tests: Expose regression in QemuOpts visitor

From: Eric Blake Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression went unnoticed because of missing testsuite coverage. Add a test to cover this; take the approach already used in 9cb8ef3 of adding a test that

Re: [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input

On 03/22/2017 12:48 PM, Markus Armbruster wrote: > From: Eric Blake > > An off-by-one in commit 15c2f669e meant that we were failing to > check for unparsed input in all QemuOpts visitors. Recent testsuite > additions show that fixing the obvious bug with bogus fields will >

[Qemu-devel] [PULL v2 for-2.9 16/17] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

From: Eric Blake A regression in commit 15c2f669e caused us to silently ignore excess input to the QemuOpts visitor. Later, commit ea4641 accidentally abused that situation, by removing "qom-type" and "id" from the corresponding QDict but leaving them defined in the QemuOpts,

[Qemu-devel] [PULL v2 for-2.9 13/17] Revert "hostmem: fix QEMU crash by 'info memdev'"

This reverts commit 1454d33f0507cb54d62ed80f494884157c9e7130. The string input visitor regression fixed in the previous commit made visit_type_uint16List() fail on empty input. query_memdev() calls it via object_property_get_uint16List(). Because it doesn't expect it to fail, it passes _abort,

[Qemu-devel] [PULL v2 for-2.9 05/17] MAINTAINERS: Add myself for files I touched recently

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-6-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 779c429..c60235e

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

Hi Cédric, i have the 4.11 rc1 . on fedora 25 ppc 64 on both machine Qoriq and on G5 Quad. On the 2.8 this issue isnt present but I did the test o Qoriq e5500 a book3e processor and on 2.8 if i made: qemu-system-ppc64 --enable-kvm the true result is: qemu-system-ppc64: Unable to find CPU

[Qemu-devel] [PULL v2 for-2.9 02/17] keyval: Improve some comments

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- util/keyval.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH] clear pending status before calling memory commit

clear pending status before calling memory commit. Otherwise when memory_region_finalize is called, memory_region_transaction_depth is 0 and memory_region_update_pending is true. That's wrong. Signed-off -by: Anthony Xu diff --git a/memory.c b/memory.c index

[Qemu-devel] [PULL v2 for-2.9 04/17] keyval: Document issues with 'any' and alternate types

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-5-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- util/keyval.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/util/keyval.c b/util/keyval.c index 46cd540..93d5db6

[Qemu-devel] [PULL v2 for-2.9 01/17] test-keyval: Tweaks to improve list coverage

We have a negative test case for a list index with leading zero. Add positive ones. Tweak the test case for list index greater or equal the number of elements: test "equal" instead of "greater" to guard against off-by-one mistakes. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL v2 for-2.9 03/17] test-keyval: Cover alternate and 'any' type

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- tests/Makefile.include | 2 +- tests/test-keyval.c| 53 ++ 2 files changed,

[Qemu-devel] [PULL v2 for-2.9 12/17] qapi: Fix string input visitor regression for empty lists

Visiting a list when input is the empty string should result in an empty list, not an error. Noticed when commit 3d089ce belatedly added tests, but simply accepted as weird then. It's actually a regression: broken in commit 74f24cb, v2.7.0. Fix it, and throw in another test case for empty

[Qemu-devel] [PULL v2 for-2.9 08/17] qapi: Drop unused QAPIDoc member optional

Unused since commit aa964b7 "qapi2texi: Convert to QAPISchemaVisitor" Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-4-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi.py | 1 - 1 file changed, 1

[Qemu-devel] [PULL v2 for-2.9 06/17] qapi: Drop excessive Make dependencies on qapi2texi.py

When qapi2texi.py changes, we regenerate everything QAPI. Screwed up in commit 56e8bdd. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-2-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- Makefile | 7 --- 1

[Qemu-devel] [PULL v2 for-2.9 00/17] QAPI patches for 2017-03-22

v2: * Leak fix squashed into 16/17 The following changes since commit 940a8ce075e3408742a4edcabfd6c2a15e2539eb: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-03-20 16:34:26 +) are available in the git repository at:

[Qemu-devel] [PULL v2 for-2.9 14/17] test-qobject-input-visitor: Cover visit_type_uint64()

The new test demonstrates known bugs: integers between INT64_MAX+1 and UINT64_MAX rejected, and integers between INT64_MIN and -1 are accepted modulo 2^64. Signed-off-by: Markus Armbruster Message-Id: <1490118290-6133-1-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake

[Qemu-devel] [PULL v2 for-2.9 09/17] tests/qapi-schema: Make test-qapi.py print docs again

test-qapi.py used to print the internal representation of doc comments (commit 3313b61). This went away when we dropped the doc comments in positive tests (commit 87c16dc). Bring it back, because I'm going to add real positive doc comment tests. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL v2 for-2.9 11/17] qapi2texi: Fix translation of *strong* and _emphasized_

Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-7-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi2texi.py| 4 ++-- tests/qapi-schema/doc-good.texi | 8 2 files changed, 6

[Qemu-devel] [PULL v2 for-2.9 07/17] qapi2texi: Fix to actually fail when 'doc-required' is false

Messed up in commit bc52d03. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-3-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi2texi.py | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

On 03/22/2017 12:35 PM, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Type: series > Subject: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in > user_creatable_add_opts > Message-id:

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

On Wed, Mar 22, 2017 at 2:19 AM, Fam Zheng wrote: > On Tue, 03/21 06:05, Ed Swierk wrote: >> Actually running snapshot_blkdev command in the text monitor doesn't >> trigger this assertion (I mixed up my notes). Instead it's triggered >> by the following sequence in qmp-shell: >>

Re: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts Message-id: 20170322173023.22654-1-ebl...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing

[Qemu-devel] [PULL for-2.9 0/4] Block patches

The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch changes up to

[Qemu-devel] [PULL for-2.9 3/4] block-backend: add drained_begin / drained_end ops

From: John Snow Allow block backends to forward drain requests to their devices/users. The initial intended purpose for this patch is to allow BBs to forward requests along to BlockJobs, which will want to pause if their associated BB has entered a drained region.

[Qemu-devel] [PULL for-2.9 4/4] blockjob: add devops to blockjob backends

From: John Snow This lets us hook into drained_begin and drained_end requests from the backend level, which is particularly useful for making sure that all jobs associated with a particular node (whether the source or the target) receive a drain request. Suggested-by: Kevin

[Qemu-devel] [PULL for-2.9 2/4] blockjob: add block_job_start_shim

From: John Snow The purpose of this shim is to allow us to pause pre-started jobs. The purpose of *that* is to allow us to buffer a pause request that will be able to take effect before the job ever does any work, allowing us to create jobs during a quiescent state (under which

[Qemu-devel] [PULL for-2.9 1/4] blockjob: avoid recursive AioContext locking

From: Paolo Bonzini Streaming or any other block job hangs when performed on a block device that has a non-default iothread. This happens because the AioContext is acquired twice by block_job_defer_to_main_loop_bh and then released only once by BDRV_POLL_WHILE. (Insert

[Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

CC: qemu-sta...@nongnu.org Signed-off-by: Eric Blake --- Markus already issued the pull request, so if that goes in before he can squash this for a v2, then I'll have to turn this into a full-blown patch. v3.5: avoid memory leak when id is not present v3: enhance commit

Re: [Qemu-devel] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

On 03/22/2017 03:15 PM, Thomas Huth wrote: > On 22.03.2017 14:35, luigiburdo wrote: >> Hi Thomas with 2.9 rc1 i have this with --enable-kvm >> >> emu-system-ppc64 --enable-kvm >> qemu-system-ppc64: KVM and IRQ_XICS capability must be present for in-kernel >> XICS >> >> and the qemu dont run. > >

Re: [Qemu-devel] [PULL for-2.9 16/17] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

On 03/22/2017 11:05 AM, Markus Armbruster wrote: > From: Eric Blake > > A regression in commit 15c2f669e caused us to silently ignore > excess input to the QemuOpts visitor. Later, commit ea4641 > accidentally abused that situation, by removing "qom-type" and > "id" from the

Re: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for bdrv_drain_begin/end

On Thu, Mar 16, 2017 at 02:28:47PM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for > bdrv_drain_begin/end > Message-id:

Re: [Qemu-devel] [PATCH v2 for-2.9] block: Declare blockdev-add and blockdev-del supported

On 22.03.2017 17:20, Markus Armbruster wrote: > It's been a long journey, but here we are. > > The supported blockdev-add is not compatible to its experimental > predecessors; bump all Since: tags to 2.9. > > x-blockdev-remove-medium, x-blockdev-insert-medium and > x-blockdev-change need a bit

Re: [Qemu-devel] qemu-ga static compilation

On Tue, Mar 21, 2017 at 11:23:39AM +0200, Sameeh Jubran wrote: > Just to make it clear, > > Stefan you are going to send a patch right? I see you've sent a patch. Please go ahead with it. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

On 20.03.2017 19:33, Peter Maydell wrote: > On OpenBSD none of the ioctls probe_logical_blocksize() tries > exist, so the variable sector_size is unused. Refactor the > code to avoid this (and reduce the duplicated code). > > Signed-off-by: Peter Maydell > --- > The

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 14/16] block/qcow2: falloc/full preallocating growth

On Mon, Mar 20, 2017 at 04:15:59PM +0100, Max Reitz wrote: > On 20.03.2017 12:29, Stefan Hajnoczi wrote: > > On Mon, Mar 13, 2017 at 10:41:15PM +0100, Max Reitz wrote: > >> Implement the preallocation modes falloc and full for growing qcow2 > >> images. > >> > >> Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH] pc: q35: bump max_cpus to INT32_MAX

2017-03-22 18:06+0200, Michael S. Tsirkin: > On Wed, Mar 22, 2017 at 04:59:06PM +0100, Radim Krčmář wrote: >> QEMU does not allocate based on machine's max_cpus, but only uses it to >> limit the maximum selected by user and the actual limit of VCPUs is >> enfoced by other components: >> - machine

  1   2   3   4   >