Re: [Qemu-devel] [PATCH 3/3] numa: silence incomplete mapping warning under qtest

On Thu, May 18, 2017 at 7:20 PM, Eduardo Habkost wrote: > On Thu, May 18, 2017 at 10:09:31AM +0200, Igor Mammedov wrote: >> Suggested-by: Markus Armbruster >> Signed-off-by: Igor Mammedov > > Where exactly is the test code that

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

On Fri, May 19, 2017 at 09:30:10AM +0100, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > > We don't really have a return path for the other types yet. Let's check > > > this when

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

On 2017年05月19日 17:00, Wei Wang wrote: On 05/19/2017 11:10 AM, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On 05/17/2017 02:22 PM, Jason Wang wrote: On 2017年05月17日 14:16, Jason Wang wrote: On 2017年05月16日 15:12, Wei Wang wrote: Hi: Care to post the driver codes too?

Re: [Qemu-devel] [RFC PATCH 09/20] Memory: introduce iommu_ops->record_device

On Fri, May 19, 2017 at 09:07:49AM +, Tian, Kevin wrote: > > From: Liu, Yi L [mailto:yi.l@linux.intel.com] > > Sent: Friday, May 19, 2017 1:24 PM > > > > Hi Alex, > > > > What's your opinion with Tianyu's question? Is it accepatable > > to use VFIO API in intel_iommu emulator? > > Did

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > We don't really have a return path for the other types yet. Let's check > > this when .get_return_path() is called. > > > > For this, we introduce a new feature bit,

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

On 05/18/2017 05:24 PM, Michael S. Tsirkin wrote: On Thu, May 18, 2017 at 04:45:23PM +0200, Maxime Coquelin wrote: Hi Michael, On 05/18/2017 09:35 AM, Maxime Coquelin wrote: On 05/17/2017 06:41 PM, Michael S. Tsirkin wrote: On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote:

[Qemu-devel] [PATCH] i386: fix read/write cr with icount option

Running Windows with icount causes a crash in instruction of write cr. This patch fixes it. Reading and writing cr cause an icount read because there are called cpu_get_apic_tpr and cpu_set_apic_tpr functions. So, there is need gen_io_start()/gen_io_end() calls. --- target/i386/translate.c

[Qemu-devel] [PATCH v1 10/13] qcow2-cluster: slightly refactor handle_dependencies()

- assert the alignment on return if the allocation has to stop (at the start of a running allocation) - make use of const specifiers for local variables Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c |

[Qemu-devel] [PATCH v1 08/13] qcow2: handle_prealloc(): find out if area zeroed by earlier preallocation

Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 2 ++ block/qcow2.c | 8 +++- block/qcow2.h | 4 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/block/qcow2-cluster.c

[Qemu-devel] [PATCH v1 06/13] qcow2: truncate preallocated space

From: "Denis V. Lunev" This could be done after calculation of the end of data and metadata in the qcow2 image. Signed-off-by: Denis V. Lunev Signed-off-by: Anton Nefedov --- block/qcow2-cluster.c | 9 +

[Qemu-devel] [PATCH v1 12/13] qcow2: allow concurrent unaligned writes to the same clusters

If COW area of a write request to unallocated cluster is empty, concurrent write requests can be allowed with a little bit of extra synchronization; so they don't have to wait until L2 is filled. Let qcow2_cluster.c::handle_dependencies() do the most of the job: if there is an in-flight request

[Qemu-devel] [PATCH v1 13/13] iotest 046: test simultaneous cluster write error case

Signed-off-by: Anton Nefedov --- tests/qemu-iotests/046 | 38 +- tests/qemu-iotests/046.out | 23 +++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/046

[Qemu-devel] [PATCH v1 02/13] qcow2: is_zero_sectors(): return true if area is outside of backing file

in such case, bdrv_get_block_status() shall return 0, *nr == 0 iotest 154 updated accordingly: write-zeroes tail alignment can be detected as zeroes now, so pwrite_zeroes succeeds Signed-off-by: Anton Nefedov --- block/qcow2.c | 6 --

[Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow

Avoid complicated nested conditions; return or continue asap instead. The logic is not changed. Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 45 ++--- 1 file changed,

[Qemu-devel] [PATCH v1 05/13] qcow2: set inactive flag

Qcow2State and BlockDriverState flags have to be in sync Signed-off-by: Anton Nefedov --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 6e7ce96..07c1706 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1939,6

[Qemu-devel] [PATCH v1 07/13] qcow2: check space leak at the end of the image

From: Pavel Butsykin Preallocating memory in the image may remain unused after the fall, for the qcow2_check adds the ability to identify and fix it, so as not to store extra memory on the host. Signed-off-by: Pavel Butsykin Signed-off-by:

[Qemu-devel] [PATCH v1 01/13] qcow2: alloc space for COW in one chunk

From: "Denis V. Lunev" Currently each single write operation can result in 3 write operations if guest offsets are not cluster aligned. One write is performed for the real payload and two for COW-ed areas. Thus the data possibly lays non-contiguously on the host filesystem. This

[Qemu-devel] [PATCH v1 09/13] qcow2: fix misleading comment about L2 linking

Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 25210cd..4204db9 100644 ---

[Qemu-devel] [PATCH v1 04/13] qcow2: preallocation at image expand

From: "Denis V. Lunev" This patch adds image preallocation at expand to provide better locality of QCOW2 image file and optimize this procedure for some distributed storages where this procedure is slow. Image expand requests have to be suspended until the allocation is

[Qemu-devel] [PATCH v1 03/13] qcow2: do not COW the empty areas

If COW area of the newly allocated cluster is zeroes, there is no reason to write zero sectors in perform_cow() again now as whole clusters are zeroed out in single chunks by handle_alloc_space(). Introduce QCowL2Meta field "reduced", since the existing fields (offset and nb_bytes) still has to

[Qemu-devel] [PATCH v1 00/13] qcow2: space preallocation and COW improvements

This pull request is to address a few performance problems of qcow2 format: 1. non cluster-aligned write requests (to unallocated clusters) explicitly pad data with zeroes if there is no backing data. This can be avoided and the whole clusters are preallocated and zeroed in a single

Re: [Qemu-devel] [PATCH] Memory: use memory address space for cpu-memory

On 19/05/2017 01:28, Xu, Anthony wrote: >> On 18/05/2017 23:48, Xu, Anthony wrote: It should be called. Alternatively you could try adding a new function to mark address_space_memory as a never-destroyed AddressSpace: >>> This patch would do it, could you please submit this

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

Hi Xiao, On 2017/5/19 16:32, Xiao Guangrong wrote: I do not know why i was removed from the list. I was CCed to you... Your comments are very valuable to us, and thank for your quick response. On 05/19/2017 04:09 PM, Jay Zhou wrote: Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li

Re: [Qemu-devel] specify memory in QEMU with Virtio

On Do, 2017-05-18 at 22:43 -0400, jenia mtl wrote: > Hello. > > > How do I specify how much graphics memory the Windows client should have in > QEMU. I have successfully installed Virtio and can launch the VM (Windows) > with it. This doubles the memory form 8MB to 16MB. But I need 512. How can

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Juan Quintela writes: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela [...] > diff --git a/include/migration/block.h b/include/migration/block.h > index 41a1ac8..5225af9

[Qemu-devel] [PATCH] target/i386: use multiple CPU AddressSpaces

This speeds up SMM switches. Later on it may remove the need to take the BQL, and it may also allow to reuse code between TCG and KVM. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c| 15 +- target/i386/cpu.h| 11 +-

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] migration: avoid recursive AioContext locking in save_vmstate()

On Thu, May 18, 2017 at 10:18:46AM +0200, Kevin Wolf wrote: > Am 17.05.2017 um 19:09 hat Stefan Hajnoczi geschrieben: > > diff --git a/migration/savevm.c b/migration/savevm.c > > index 7f66d58..a70ba20 100644 > > --- a/migration/savevm.c > > +++ b/migration/savevm.c > > @@ -2153,6 +2153,14 @@ int

Re: [Qemu-devel] [RFC PATCH 09/20] Memory: introduce iommu_ops->record_device

> From: Liu, Yi L [mailto:yi.l@linux.intel.com] > Sent: Friday, May 19, 2017 1:24 PM > > Hi Alex, > > What's your opinion with Tianyu's question? Is it accepatable > to use VFIO API in intel_iommu emulator? Did you actually need such translation at all? SID should be filled by kernel IOMMU

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

On 05/19/2017 11:10 AM, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On 05/17/2017 02:22 PM, Jason Wang wrote: On 2017年05月17日 14:16, Jason Wang wrote: On 2017年05月16日 15:12, Wei Wang wrote: Hi: Care to post the driver codes too? OK. It may take some time to clean up the

[Qemu-devel] [PULL 1/1] ui: egl-headless requires dmabuf support

Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170517122744.3541-1-kra...@redhat.com --- vl.c | 4 ++-- ui/Makefile.objs | 2 +- 2 files changed, 3 insertions(+), 3

[Qemu-devel] [PULL 0/1] ui: egl-headless requires dmabuf support

repository at: git://git.kraxel.org/qemu tags/pull-ui-20170519-1 for you to fetch changes up to 371ec54e9f8415cd74af45acdcf67b413f50cce5: ui: egl-headless requires dmabuf support (2017-05-19 10:46:00 +0200) ui: egl-headless

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

On 05/19/2017 08:48 AM, Jason Wang wrote: On 2017年05月17日 22:10, Maxime Coquelin wrote: On 05/17/2017 04:53 AM, Jason Wang wrote: On 2017年05月16日 23:16, Michael S. Tsirkin wrote: On Mon, May 15, 2017 at 01:45:28PM +0800, Jason Wang wrote: On 2017年05月13日 08:02, Michael S. Tsirkin

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

I do not know why i was removed from the list. On 05/19/2017 04:09 PM, Jay Zhou wrote: Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wrote: 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : Recently, I have tested the performance before migration and after migration

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > We don't really have a return path for the other types yet. Let's check > > this when .get_return_path() is called. > > > > For this, we introduce a new feature bit,

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > We don't really have a return path for the other types yet. Let's check > this when .get_return_path() is called. > > For this, we introduce a new feature bit, and set it up only for socket > typed IO channels. > > This will help detect

Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

* Thomas Huth (th...@redhat.com) wrote: > The commands 'device_add' and 'device_del' should be used > nowadays instead. > > Signed-off-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 6 -- > vl.c| 6 ++ >

Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

On 19/05/2017 08:36, Thomas Huth wrote: > The commands 'device_add' and 'device_del' should be used > nowadays instead. > > Signed-off-by: Thomas Huth > --- > hmp-commands.hx | 6 -- > vl.c| 6 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH] usb: Simplify the parameter parsing of the legacy usb serial device

On 19/05/2017 09:00, Thomas Huth wrote: > Coverity complains about the current code, so let's get rid of > the now unneeded while loop and simply always emit "unrecognized > serial USB option" for all unsupported options. > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-devel] [PATCH] usb: Deprecate the legacy -usbdevice option

On 19/05/2017 08:35, Thomas Huth wrote: > The '-usbdevice' option is considered as deprecated nowadays and > we might want to remove these options in a future version of QEMU. > So mark this options as deprecated in the documenation and print out > a warning if it is used to tell the user what

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wrote: 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : Recently, I have tested the performance before migration and after migration failure using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard performance

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

On 2017年05月18日 16:43, Maxime Coquelin wrote: +When the VHOST_USER_PROTOCOL_F_SLAVE_REQ is supported by the slave, and the +master initiated the slave to master communication channel using the +VHOST_USER_SET_SLAVE_REQ_FD request, the slave can send IOTLB miss and access +failure events by

Re: [Qemu-devel] [RFC PATCH v2 1/4] migration: Introduce unregister_savevm_live()

On Fri, May 19, 2017 at 11:10:36AM +0530, Bharata B Rao wrote: > Introduce a new function unregister_savevm_live() to unregister the vmstate > handlers registered via register_savevm_live(). > > register_savevm() allocates SaveVMHandlers while register_savevm_live() > gets passed with

[Qemu-devel] [PATCH v0 6/6] change tcg relative file's compile definition

move tcg relative compile definitions form Makefile.target to tcg/Makefile.objs Signed-off-by: Yang Zhong --- Makefile.target | 7 +-- tcg/Makefile.objs | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) create mode 100644 tcg/Makefile.objs diff --git

[Qemu-devel] [PATCH v0 5/6] move tcg relative files into tcg directory

move tci.c to ./tcg Signed-off-by: Yang Zhong --- Makefile.target| 2 +- tci.c => tcg/tci.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tci.c => tcg/tci.c (100%) diff --git a/Makefile.target b/Makefile.target index 7ee6cb3..489a325 100644 ---

[Qemu-devel] [PATCH v0 2/6] move tcg relative files into tcg directory

move translate-all.c file into tcg directory and update trace-events file Signed-off-by: Yang Zhong --- Makefile.objs | 1 + Makefile.target| 3 ++- tcg/trace-events | 6 ++ translate-all.c =>

[Qemu-devel] [PATCH v0 3/6] move tcg header file

move translate-all.h to ./tcg Signed-off-by: Yang Zhong --- translate-all.h => tcg/translate-all.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename translate-all.h => tcg/translate-all.h (100%) diff --git a/translate-all.h b/tcg/translate-all.h similarity

[Qemu-devel] [PATCH v0 1/6] move tcg relative files into tcg directory

move tcg-runtime.c to ./tcg directory Signed-off-by: Yang Zhong --- Makefile.target| 2 +- tcg-runtime.c => tcg/tcg-runtime.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tcg-runtime.c => tcg/tcg-runtime.c (100%) diff --git

[Qemu-devel] [PATCH v0 4/6] move tcg relative files into tcg directory

move translate-common.c to ./tcg Signed-off-by: Yang Zhong --- Makefile.target | 2 +- translate-common.c => tcg/translate-common.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename translate-common.c => tcg/translate-common.c (100%)

[Qemu-devel] [PATCH v0 0/6] move the tcg files into tcg directory.

Move the tcg relative files into tcg directory, which will make the code more clean in qemu. Yang Zhong (6): move tcg relative files into tcg directory move tcg relative files into tcg directory move tcg header file move tcg relative files into tcg directory move tcg relative files into

[Qemu-devel] [Bug 1180924] Re: fails to handle a usb serial port with a specific vendorid

The crash has now been fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=aa612b364ecbe1dc Please also note that the "-usbdevice serial" syntax is considered as deprecated nowadays - use "-device usb-serial" instead. ** Changed in: qemu Status: New => Fix Committed -- You

Re: [Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

Mao Zhongyi writes: > The rocker device still implements the old PCIDeviceClass .init() > instead of the new .realize(). All devices need to be converted to > .realize(). > > .init() reports errors with fprintf() and return 0 on success, negative > number on failure.

[Qemu-devel] [PATCH] usb: Simplify the parameter parsing of the legacy usb serial device

Coverity complains about the current code, so let's get rid of the now unneeded while loop and simply always emit "unrecognized serial USB option" for all unsupported options. Signed-off-by: Thomas Huth --- hw/usb/dev-serial.c | 21 + 1 file changed, 5

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

On 2017年05月17日 22:10, Maxime Coquelin wrote: On 05/17/2017 04:53 AM, Jason Wang wrote: On 2017年05月16日 23:16, Michael S. Tsirkin wrote: On Mon, May 15, 2017 at 01:45:28PM +0800, Jason Wang wrote: On 2017年05月13日 08:02, Michael S. Tsirkin wrote: On Fri, May 12, 2017 at 04:21:58PM +0200,

Re: [Qemu-devel] [PATCH RFC 0/6] migration: enable return-path for precopy

On Fri, May 19, 2017 at 02:43:26PM +0800, Peter Xu wrote: > This idea derives from the bug reported: > > https://bugzilla.redhat.com/show_bug.cgi?id=1439147 > > It is not a extremely critical bug, since as long as the user uses > libvirt to migrate, we won't have such an issue at all (we'll

[Qemu-devel] [PATCH RFC 6/6] migration: enable return path for precopy

Let this be a flag, default to on. Turn it off for <=2.9 versions. After this patch, return path will be on even for pre-copy migration as long as the transport support, e.g., for socket typed transport including "tcp|udp|unix" typed. This will naturally fix the bug mentioned below, when

[Qemu-devel] [PATCH RFC 4/6] migration: shut src return path unconditionally

We were do the shutting off only for postcopy. Now we do this as long as the source return path is there. Moving the cleanup of from_src_file there too. Signed-off-by: Peter Xu --- migration/migration.c| 8 +++- migration/postcopy-ram.c | 1 - 2 files changed, 7

[Qemu-devel] [PATCH RFC 5/6] migration: let MigrationState be an QObject

Let the old man "MigrationState" join the object family. Direct benefit is that we can start to use all the property features derived from current QObject, like: HW_COMPAT_* bits, command line setup for migration parameters (so will never need to set them up each time using HMP/QMP, this is

[Qemu-devel] [PATCH RFC 0/6] migration: enable return-path for precopy

This idea derives from the bug reported: https://bugzilla.redhat.com/show_bug.cgi?id=1439147 It is not a extremely critical bug, since as long as the user uses libvirt to migrate, we won't have such an issue at all (we'll have identical command line parameters for QEMU). However it can be an

[Qemu-devel] [PATCH RFC 2/6] migration: isolate return path on src

There are some places that binded "return path" with postcopy. Let's be prepared for its usage even without postcopy. This patch mainly did this on source side. This has no functional change. But it'll simplify further patches. Signed-off-by: Peter Xu ---

[Qemu-devel] [PATCH RFC 3/6] migration: fix leak of src file on dst

The return path channel is possibly leaked. Fix it. Signed-off-by: Peter Xu --- migration/migration.c | 5 + 1 file changed, 5 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index e4f4c8c..92617fc 100644 --- a/migration/migration.c +++

[Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

We don't really have a return path for the other types yet. Let's check this when .get_return_path() is called. For this, we introduce a new feature bit, and set it up only for socket typed IO channels. This will help detect earlier failure for postcopy, e.g., logically speaking postcopy cannot

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

On Wed, May 17, 2017 at 10:33:44PM +0200, Greg Kurz wrote: > On Wed, 17 May 2017 14:18:16 +1000 > David Gibson wrote: > > > On Mon, May 15, 2017 at 06:11:27PM +0200, Cédric Le Goater wrote: > > > >>> +int smt = kvmppc_smt_threads(); > > > >>> +int

Re: [Qemu-devel] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

On Fri, May 19, 2017 at 11:10:39AM +0530, Bharata B Rao wrote: > Fix migration of radix guests by ensuring that we issue > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > Reported-by: Nageswara R Sastry > Signed-off-by: Bharata B Rao

[Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

The commands 'device_add' and 'device_del' should be used nowadays instead. Signed-off-by: Thomas Huth --- hmp-commands.hx | 6 -- vl.c| 6 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index

[Qemu-devel] [PATCH] usb: Deprecate the legacy -usbdevice option

The '-usbdevice' option is considered as deprecated nowadays and we might want to remove these options in a future version of QEMU. So mark this options as deprecated in the documenation and print out a warning if it is used to tell the user what to use instead. While we're at it, improve also

Re: [Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

Mao Zhongyi writes: > pci_rocker_init() leaks a World when the name more than 9 chars, > then return a negative value directly, doesn't make a correct > cleanup. So add a new goto label to fix it. > > Cc: jasow...@redhat.com > Cc: j...@resnulli.us > Cc: f4...@amsat.org

Re: [Qemu-devel] [PATCH] e1000e: Fix a bug where guest hangs upon migration

On 2017年05月17日 19:46, Sameeh Jubran wrote: The bug was caused by the "receive overrun" (bit #6 of the ICR register) interrupt which would be triggered post migration in a heavy traffic environment. Even though the "receive overrun" bit (#6) is masked out by the IMS register (refer to the log

Re: [Qemu-devel] [PATCH v4 1/3] net/rocker: Remove the dead error handling

Mao Zhongyi writes: > The function of_dpa_world_alloc is a wrapper around world_alloc(), which > returns null only when g_malloc0(size_t size) does. But g_malloc0() also > is a wrapper around g_malloc0_n(1, size) that ignore the fact that > g_malloc0() of 0 bytes, it

Re: [Qemu-devel] [RESEND PATCH v10 2/5] hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque

On Thu, May 18, 2017 at 06:54:13PM -0300, Daniel Henrique Barboza wrote: > The pointer drc->detach_cb is being used as a way of informing > the detach() function inside spapr_drc.c which cb to execute. This > information can also be retrieved simply by checking drc->type and > choosing the right

Re: [Qemu-devel] [RESEND PATCH v10 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

On Thu, May 18, 2017 at 06:54:12PM -0300, Daniel Henrique Barboza wrote: > The LMB DRC release callback, spapr_lmb_release(), uses an opaque > parameter, a sPAPRDIMMState struct that stores the current LMBs that > are allocated to a DIMM (nr_lmbs). After each call to this callback, > the nr_lmbs

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

On 19.05.2017 07:54, Markus Armbruster wrote: > Thomas Huth writes: > >> On 18.05.2017 15:35, Paolo Bonzini wrote: >>> >>> >>> On 18/05/2017 15:22, Thomas Huth wrote: On 18.05.2017 14:00, Paolo Bonzini wrote: > > > On 12/05/2017 14:21, Gerd Hoffmann wrote:

<    1   2   3