Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-17 Thread Stefan Weil
Am 18.01.2018 um 00:41 schrieb Justin Terry (VM) via Qemu-devel: > Hey Paolo, [...] > 4. This will be supported on Windows 10 hosts (I don’t have the insider build > number yet) and it will require an Intel processor with VT-x and Unrestricted > Guest support. Will update the qemu-devel list

Re: [Qemu-devel] [PATCH v2 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Thomas Huth
On 17.01.2018 22:12, David Hildenbrand wrote: > On 17.01.2018 20:37, Christian Borntraeger wrote: >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor activity). To prevent any issues we require full

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-17 Thread David Gibson
On Thu, Jan 18, 2018 at 04:44:28PM +1100, Alexey Kardashevskiy wrote: > On 18/01/18 16:20, David Gibson wrote: > > On Mon, Jan 15, 2018 at 05:32:35PM +1100, Suraj Jitindar Singh wrote: > >> The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query > >> behaviours and available

Re: [Qemu-devel] [PATCH qemu 0/3] spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2018-01-17 Thread David Gibson
On Tue, Jan 16, 2018 at 01:46:14PM -0700, Alex Williamson wrote: > On Mon, 15 Jan 2018 15:12:07 +1100 > Alexey Kardashevskiy wrote: > > > On 03/01/18 04:51, Paolo Bonzini wrote: > > > On 02/01/2018 06:28, Alexey Kardashevskiy wrote: > > >> This is my current queue of the

Re: [Qemu-devel] [PATCH v1 1/1] linux-user: Fix webkitgtk hangs on 32-bit x86 target

2018-01-17 Thread Alistair Francis
On Wed, Jan 17, 2018 at 4:57 PM, Richard Henderson wrote: > On 01/17/2018 12:39 PM, Alistair Francis wrote: >> Since commit "linux-user: Tidy and enforce reserved_va initialization" >> (18e80c55bb6ec17c05ec0ba717ec83933c2bfc07) the Yocto webkitgtk build >> hangs when cross

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-17 Thread Alexey Kardashevskiy
On 18/01/18 16:20, David Gibson wrote: > On Mon, Jan 15, 2018 at 05:32:35PM +1100, Suraj Jitindar Singh wrote: >> The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query >> behaviours and available characteristics of the cpu. >> >> Implement the handler for this new H-Call which

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-17 Thread Kang, Luwei
> > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > > CCing libvirt developers. > > > > > > ... > > > > > > > This case is slightly more problematic, however: the new > > > > > > > feature is actually migratable (under very controlled > > > > > > > circumstances)

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Alias MMIO windows to PHB address space

2018-01-17 Thread Alexey Kardashevskiy
On 18/01/18 14:47, Alexey Kardashevskiy wrote: > At the moment the sPAPR PHB MMIO space does not have an address space > object as it does not really need one - guest accesses it via virtual > addresses (and we provide mappings to the CPU space), the device drivers > in QEMU access MMIO directly

Re: [Qemu-devel] [QEMU-PPC] [PATCH V4 1/6] target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch]

2018-01-17 Thread David Gibson
On Mon, Jan 15, 2018 at 05:58:37PM +1100, Suraj Jitindar Singh wrote: > Add three new kvm capabilities used to represent the level of host support > for three corresponding workarounds. > > Host support for each of the capabilities is queried through the > new ioctl KVM_PPC_GET_CPU_CHAR which

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 5/6] target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch

2018-01-17 Thread David Gibson
On Mon, Jan 15, 2018 at 05:32:34PM +1100, Suraj Jitindar Singh wrote: > Add new tristate cap cap-ibs to represent the indirect branch > serialisation capability. > > Signed-off-by: Suraj Jitindar Singh Reviewed-by: David Gibson > --- >

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-17 Thread David Gibson
On Mon, Jan 15, 2018 at 05:32:35PM +1100, Suraj Jitindar Singh wrote: > The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query > behaviours and available characteristics of the cpu. > > Implement the handler for this new H-Call which formulates its response > based on the setting

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 3/6] target/ppc/spapr_caps: Add new tristate cap safe_cache

2018-01-17 Thread David Gibson
On Mon, Jan 15, 2018 at 05:32:32PM +1100, Suraj Jitindar Singh wrote: > Add new tristate cap cap-cfpc to represent the cache flush on privilege > change capability. > > Signed-off-by: Suraj Jitindar Singh Reviewed-by: David Gibson > --- >

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 4/6] target/ppc/spapr_caps: Add new tristate cap safe_bounds_check

2018-01-17 Thread David Gibson
On Mon, Jan 15, 2018 at 05:32:33PM +1100, Suraj Jitindar Singh wrote: > Add new tristate cap cap-sbbc to represent the speculation barrier > bounds checking capability. > > Signed-off-by: Suraj Jitindar Singh Reviewed-by: David Gibson >

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 2/6] target/ppc/spapr_caps: Add support for tristate spapr_capabilities

2018-01-17 Thread David Gibson
On Mon, Jan 15, 2018 at 05:32:31PM +1100, Suraj Jitindar Singh wrote: > spapr_caps are used to represent the level of support for various > capabilities related to the spapr machine type. Currently there is > only support for boolean capabilities. > > Add support for tristate capabilities by

[Qemu-devel] [PATCH] chardev: fix incorrect unref of source

2018-01-17 Thread Peter Xu
glib reported error when pty chardev used: $ ./qemu-system-x86_64 -chardev pty,id=foo -device isa-serial,chardev=foo qemu-system-x86_64: -chardev pty,id=foo: char device redirected to /dev/pts/2 (label foo) (qemu-system-x86_64:27885): GLib-CRITICAL **: g_source_unref: assertion 'source != NULL'

Re: [Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-17 Thread Peter Xu
On Wed, Jan 17, 2018 at 05:21:40PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Jan 16, 2018 at 3:16 PM, Paolo Bonzini wrote: > > From: Peter Xu > > > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > > now can have dedicated

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 0/6] target/ppc: Rework spapr_caps

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 09:54:57AM +0100, Andrea Bolognani wrote: > On Wed, 2018-01-17 at 10:26 +1100, Alexey Kardashevskiy wrote: > > On 17/01/18 09:34, David Gibson wrote: > > > On Tue, Jan 16, 2018 at 03:46:20PM +0100, Andrea Bolognani wrote: > > > > On Wed, 2018-01-17 at 00:54 +1100, David

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 11:52 PM, Fam Zheng wrote: > Coverity doesn't like the ignored return value introduced in > 9d3b155186c278 (hw/block: Fix the return type), and other callers are > converted already in ceff3e1f01. > > This one was added lately in d9bcd6f7f23a and missed the train. Do it > now. > >

Re: [Qemu-devel] [PATCH 3/3] target/ppc: add support for hypervisor doorbells on book3s CPUs

2018-01-17 Thread David Gibson
On Tue, Jan 16, 2018 at 08:41:57AM +0100, Cédric Le Goater wrote: > The hypervisor doorbells are used by skiboot and Linux on POWER9 > processors to wake up secondaries. > > This adds processor control support to the Server architecture by > reusing the Embedded support. They are very similar,

Re: [Qemu-devel] [PATCH 3/3] spapr: fix device tree properties when using compatibility mode

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 10:20:42AM +0100, Greg Kurz wrote: > Commit 51f84465dd98 changed the compatility mode setting logic: > - machine reset only sets compatibility mode for the boot CPU > - compatibility mode is set for other CPUs when they are put online > by the guest with the "start-cpu"

Re: [Qemu-devel] [PATCH 2/3] spapr_cpu_core: don't reset CPUs during realization

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 10:20:35AM +0100, Greg Kurz wrote: > When QEMU is started, all cold-plugged CPUs are reset twice: first > during initialization and then during machine reset. This is sub- > optimal. > > The first reset is only needed for hot-plugged CPUs because the CPU > hotplug code

[Qemu-devel] [PATCH qemu] spapr_pci: Alias MMIO windows to PHB address space

2018-01-17 Thread Alexey Kardashevskiy
At the moment the sPAPR PHB MMIO space does not have an address space object as it does not really need one - guest accesses it via virtual addresses (and we provide mappings to the CPU space), the device drivers in QEMU access MMIO directly (as they own MRs). The only case when a driver in QEMU

[Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-17 Thread Fam Zheng
Coverity doesn't like the ignored return value introduced in 9d3b155186c278 (hw/block: Fix the return type), and other callers are converted already in ceff3e1f01. This one was added lately in d9bcd6f7f23a and missed the train. Do it now. Signed-off-by: Fam Zheng ---

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-17 Thread Eduardo Habkost
On Wed, Jan 17, 2018 at 10:32:56AM +, Kang, Luwei wrote: > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > CCing libvirt developers. > > > > > ... > > > > > > This case is slightly more problematic, however: the new feature > > > > > > is actually migratable

[Qemu-devel] [PULL 6/6] nbd/server: structurize option reply sending

2018-01-17 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20171122101958.17065-6-vsement...@virtuozzo.com> Signed-off-by: Eric Blake ---

[Qemu-devel] [PULL 4/6] nbd/server: Add va_list form of nbd_negotiate_send_rep_err()

2018-01-17 Thread Eric Blake
This will be useful for the next patch. Based on a patch by Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180110230825.18321-5-ebl...@redhat.com> --- nbd/server.c | 24

[Qemu-devel] [PULL 1/6] nbd/server: Hoist nbd_reject_length() earlier

2018-01-17 Thread Eric Blake
No semantic change, but will make it easier for an upcoming patch to refactor code without having to add forward declarations. Fix a poor comment while at it. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id:

[Qemu-devel] [PULL 5/6] nbd/server: Add helper functions for parsing option payload

2018-01-17 Thread Eric Blake
Rather than making every callsite perform length sanity checks and error reporting, add the helper functions nbd_opt_read() and nbd_opt_drop() that use the length stored in the client struct; also add an assertion that optlen is 0 before any option (ie. any previous option was fully handled),

[Qemu-devel] [PULL 15/19] hostmem-file: add "align" option

2018-01-17 Thread Eduardo Habkost
From: Haozhong Zhang When mmap(2) the backend files, QEMU uses the host page size (getpagesize(2)) by default as the alignment of mapping address. However, some backends may require alignments different than the page size. For example, mmap a device DAX (e.g.,

[Qemu-devel] [PULL 12/19] qdev_monitor: Simplify error handling in qdev_device_add()

2018-01-17 Thread Eduardo Habkost
From: Thomas Huth Instead of doing the clean-ups on errors multiple times, introduce a jump label at the end of the function that can be used by all error paths that need this cleanup. Suggested-by: Igor Mammedov Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 3/6] nbd/server: Better error for NBD_OPT_EXPORT_NAME failure

2018-01-17 Thread Eric Blake
When a client abruptly disconnects before we've finished reading the name sent with NBD_OPT_EXPORT_NAME, we are better off logging the failure as EIO (we can't communicate with the client), rather than EINVAL (the client sent bogus data). Signed-off-by: Eric Blake Reviewed-by:

[Qemu-devel] [PULL 13/19] qdev: Check for the availability of a hotplug controller before adding a device

2018-01-17 Thread Eduardo Habkost
From: Thomas Huth The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, so QEMU crashes when the user tries to device_add + device_del a device that does not have a corresponding hotplug controller. This could be provoked for a couple of devices in the past

[Qemu-devel] [PULL 2/6] nbd/server: refactor negotiation functions parameters

2018-01-17 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Instead of passing currently negotiating option and its length to many of negotiation functions let's just store them on NBDClient struct to be state-variables of negotiation phase. This unifies semantics of negotiation functions and

[Qemu-devel] [PULL 0/6] NBD patches through 17 Jan

2018-01-17 Thread Eric Blake
The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into staging (2018-01-16 17:36:39 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-01-17 for you

[Qemu-devel] [PULL 18/19] possible_cpus: add CPUArchId::type field

2018-01-17 Thread Eduardo Habkost
From: Igor Mammedov Remove dependency of possible_cpus on 1st CPU instance, which decouples configuration data from CPU instances that are created using that data. Also later it would be used for enabling early cpu to numa node configuration at runtime

[Qemu-devel] [PULL 06/19] machine: Replace has_dynamic_sysbus with list of allowed devices

2018-01-17 Thread Eduardo Habkost
The existing has_dynamic_sysbus flag makes the machine accept every user-creatable sysbus device type on the command-line. Replace it with a list of allowed device types, so machines can easily accept some sysbus devices while rejecting others. To keep exactly the same behavior as before, the

[Qemu-devel] [PULL 14/19] scripts: Remove fixed entries from the device-crash-test

2018-01-17 Thread Eduardo Habkost
From: Thomas Huth These are crashes / errors which have been fixed already in the past months. We can remove these from the device-crash-test script now. Signed-off-by: Thomas Huth Message-Id: <1513613438-11017-1-git-send-email-th...@redhat.com>

[Qemu-devel] [PULL 19/19] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-17 Thread Eduardo Habkost
From: Marcel Apfelbaum When all the fw_cfg slots are used, a write is made outside the bounds of the fw_cfg files array as part of the sort algorithm. Fix it by avoiding an unnecessary array element move. Fix also an assert while at it. Signed-off-by: Marcel Apfelbaum

[Qemu-devel] [PULL 04/19] qemu-options: document memory-backend-ram

2018-01-17 Thread Eduardo Habkost
From: Stefan Hajnoczi The documentation should mention -object memory-backend-ram. Suggested-by: Yumei Huang Signed-off-by: Stefan Hajnoczi Message-Id: <20171128161529.3025-3-stefa...@redhat.com> Reviewed-by: Eric Blake

[Qemu-devel] [PULL 10/19] xen: Add only xen-sysdev to dynamic sysbus device list

2018-01-17 Thread Eduardo Habkost
There's no need to make the machine allow every possible sysbus device. We can now just add xen-sysdev to the allowed list. Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xenproject.org Cc: Juergen Gross

[Qemu-devel] [PULL 16/19] nvdimm: add a macro for property "label-size"

2018-01-17 Thread Eduardo Habkost
From: Haozhong Zhang Signed-off-by: Haozhong Zhang Reviewed-by: Stefan Hajnoczi Message-Id: <20171211072806.2812-3-haozhong.zh...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 01/19] memfd: split qemu_memfd_alloc()

2018-01-17 Thread Eduardo Habkost
From: Marc-André Lureau Add a function to only create a memfd, without mmap. The function is used in the following memory backend. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PULL 17/19] nvdimm: add 'unarmed' option

2018-01-17 Thread Eduardo Habkost
From: Haozhong Zhang Currently the only vNVDIMM backend can guarantee the guest write persistence is device DAX on Linux, because no host-side kernel cache is involved in the guest access to it. The approach to detect whether the backend is device DAX needs to access

[Qemu-devel] [PULL 09/19] spapr: Allow only supported dynamic sysbus devices

2018-01-17 Thread Eduardo Habkost
TYPE_SPAPR_PCI_HOST_BRIDGE is the only dynamic sysbus device not rejected by ppc_spapr_reset(), so it can be the only entry on the allowed list. Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 00/19] machine queue, 2018-01-18

2018-01-17 Thread Eduardo Habkost
The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into staging (2018-01-16 17:36:39 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pull-request

[Qemu-devel] [PULL 03/19] qemu-options: document missing memory-backend-file options

2018-01-17 Thread Eduardo Habkost
From: Stefan Hajnoczi This patch adds undocumented memory-backend-file options to the documentation. Signed-off-by: Stefan Hajnoczi Message-Id: <20171128161529.3025-2-stefa...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Eduardo

[Qemu-devel] [PULL 11/19] q35: Allow only supported dynamic sysbus devices

2018-01-17 Thread Eduardo Habkost
The only user-creatable sysbus devices in qemu-system-x86_64 are amd-iommu, intel-iommu, and xen-backend. xen-backend is handled by xen_set_dynamic_sysbus(), so we only need to add amd-iommu and intel-iommu. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum

[Qemu-devel] [PULL 08/19] ppc: e500: Allow only supported dynamic sysbus devices

2018-01-17 Thread Eduardo Habkost
platform_bus_create_devtree() already rejects all dynamic sysbus devices except TYPE_ETSEC_COMMON, so register it as the only allowed dynamic sysbus device for the ppce500 machine-type. Cc: Alexander Graf Cc: David Gibson Cc: qemu-...@nongnu.org

[Qemu-devel] [PULL 02/19] memfd: remove needless include

2018-01-17 Thread Eduardo Habkost
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20171023141815.17709-3-marcandre.lur...@redhat.com> Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL 07/19] hw/arm/virt: Allow only supported dynamic sysbus devices

2018-01-17 Thread Eduardo Habkost
Replace the TYPE_SYS_BUS_DEVICE entry in the allowed sysbus device list with the two device types that are really supported by the virt machine: vfio-amd-xgbe and vfio-calxeda-xgmac. Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 05/19] numa: fix missing '-numa cpu' in '-help' output

2018-01-17 Thread Eduardo Habkost
From: Igor Mammedov commit 419fcdec3c (numa: add '-numa cpu,...' option for property based node mapping) added '-numa cpu' option but forgot to update appropriate section for '--help'. Add '-numa cpu' description to '-help' output Reported-by: Markus Armbruster

[Qemu-devel] [PULL 7/8] i386: Add new -IBRS versions of Intel CPU models

2018-01-17 Thread Eduardo Habkost
The new MSR IA32_SPEC_CTRL MSR was introduced by a recent Intel microcode updated and can be used by OSes to mitigate CVE-2017-5715. Unfortunately we can't change the existing CPU models without breaking existing setups, so users need to explicitly update their VM configuration to use the new

[Qemu-devel] [PULL 4/8] i386: Add support for SPEC_CTRL MSR

2018-01-17 Thread Eduardo Habkost
From: Paolo Bonzini Signed-off-by: Eduardo Habkost Message-Id: <20180109154519.25634-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 3 +++ target/i386/kvm.c | 14 ++

[Qemu-devel] [PULL 6/8] i386: Add FEAT_8000_0008_EBX CPUID feature word

2018-01-17 Thread Eduardo Habkost
Add the new feature word and the "ibpb" feature flag. Based on a patch by Paolo Bonzini. Signed-off-by: Eduardo Habkost Message-Id: <20180109154519.25634-5-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 3 +++

[Qemu-devel] [PULL 5/8] i386: Add spec-ctrl CPUID bit

2018-01-17 Thread Eduardo Habkost
Add the feature name and a CPUID_7_0_EDX_SPEC_CTRL macro. Signed-off-by: Eduardo Habkost Message-Id: <20180109154519.25634-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 1 + target/i386/cpu.c | 2 +- 2 files changed, 2

[Qemu-devel] [PULL 3/8] i386: Change X86CPUDefinition::model_id to const char*

2018-01-17 Thread Eduardo Habkost
It is valid to have a 48-character model ID on CPUID, however the definition of X86CPUDefinition::model_id is char[48], which can make the compiler drop the null terminator from the string. If a CPU model happens to have 48 bytes on model_id, "-cpu help" will print garbage and the

[Qemu-devel] [PULL 8/8] i386: Add EPYC-IBPB CPU model

2018-01-17 Thread Eduardo Habkost
EPYC-IBPB is a copy of the EPYC CPU model with just CPUID_8000_0008_EBX_IBPB added. Cc: Jiri Denemark Cc: Tom Lendacky Cc: Brijesh Singh Signed-off-by: Eduardo Habkost Message-Id:

[Qemu-devel] [PULL 0/8] x86 queue, 2018-01-17

2018-01-17 Thread Eduardo Habkost
The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into staging (2018-01-16 17:36:39 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for you

[Qemu-devel] [PULL 1/8] pc: add 2.12 machine types

2018-01-17 Thread Eduardo Habkost
From: Haozhong Zhang Signed-off-by: Haozhong Zhang Message-Id: <20171219033730.12748-2-haozhong.zh...@intel.com> Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 3 +++ hw/i386/pc_piix.c| 15 ---

[Qemu-devel] [PULL 2/8] target/i386: add clflushopt to "Skylake-Server" cpu model

2018-01-17 Thread Eduardo Habkost
From: Haozhong Zhang CPUID_7_0_EBX_CLFLUSHOPT is missed in current "Skylake-Server" cpu model. Add it to "Skylake-Server" cpu model on pc-i440fx-2.12 and pc-q35-2.12. Keep it disabled in "Skylake-Server" cpu model on older machine types. Signed-off-by: Haozhong Zhang

Re: [Qemu-devel] [PATCH 22/24] cpu: get rid of unused cpu_init() defines

2018-01-17 Thread Eduardo Habkost
On Wed, Jan 17, 2018 at 04:43:34PM +0100, Igor Mammedov wrote: > cpu_init(cpu_model) were replaced by cpu_create(cpu_type) so > no users are left, remove it. > > Signed-off-by: Igor Mammedov Wonderful. Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-17 Thread Eduardo Habkost
On Wed, Jan 17, 2018 at 04:43:32PM +0100, Igor Mammedov wrote: > The last user of it was machine type 'none', which used field > to create CPU id user requested it on CLI with -cpu option. > > We could compare pointers of MachineState::cpu_type and > MachineClass::default_cpu_type to check for

Re: [Qemu-devel] [PATCH 11/24] ppc: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 04:43:23PM +0100, Igor Mammedov wrote: > it will be used for for 2 purposes, 1st is to > provide to cpu name resolving class for machine 'none' > cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) > and later to drop a bunch of ifdefs *-user/main.c that > set

Re: [Qemu-devel] [PATCH 1/3] spapr: drop duplicate variable in spapr_core_plug()

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 10:20:27AM +0100, Greg Kurz wrote: > A variable is already defined at the begining of the function to > hold a pointer to the CPU core object: > > sPAPRCPUCore *core = SPAPR_CPU_CORE(OBJECT(dev)); > > No need to define it again in the pre-2.10 compatibility code

Re: [Qemu-devel] [PATCH v1 1/1] linux-user: Fix webkitgtk hangs on 32-bit x86 target

2018-01-17 Thread Richard Henderson
On 01/17/2018 12:39 PM, Alistair Francis wrote: > Since commit "linux-user: Tidy and enforce reserved_va initialization" > (18e80c55bb6ec17c05ec0ba717ec83933c2bfc07) the Yocto webkitgtk build > hangs when cross compiling for 32-bit x86 on a 64-bit x86 machine using > musl. > > To fix the issue

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-01-17 Thread Cleber Rosa
On 01/17/2018 06:41 PM, Alistair Francis wrote: > On Wed, Jan 17, 2018 at 12:05 AM, Cleber Rosa wrote: >> TL;DR >> = >> >> This is about how QEMU developers can get started with functional >> tests that are built on top of the Avocado libraries (and meant to be >> run with

Re: [Qemu-devel] [PATCH 22/24] cpu: get rid of unused cpu_init() defines

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 04:43:34PM +0100, Igor Mammedov wrote: > cpu_init(cpu_model) were replaced by cpu_create(cpu_type) so > no users are left, remove it. > > Signed-off-by: Igor Mammedov ppc part Acked-by: David Gibson > --- > CC: Richard

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-17 Thread Justin Terry (VM) via Qemu-devel
Hey Paolo, Thanks for all the feedback. After talking with various members of the team around these scenarios I think its best we add the migration blockers for all of your comments unfortunately. The answers to your question are below: 1. For CPUID. The API has support for an

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-01-17 Thread Alistair Francis
On Wed, Jan 17, 2018 at 12:05 AM, Cleber Rosa wrote: > TL;DR > = > > This is about how QEMU developers can get started with functional > tests that are built on top of the Avocado libraries (and meant to be > run with the Avocado test runner). > > The past > > > The

Re: [Qemu-devel] [PATCH v3] file-posix: specify expected filetypes

2018-01-17 Thread John Snow
On 01/17/2018 05:18 PM, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > @)(#_%(@)#_ I forgot to check in some changes in my local branch that keep the texi from breaking. Sorry for the noise...

Re: [Qemu-devel] [PATCH v3] file-posix: specify expected filetypes

2018-01-17 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180117221210.28575-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v3] file-posix: specify expected filetypes === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under

[Qemu-devel] [PATCH v3] file-posix: specify expected filetypes

2018-01-17 Thread John Snow
Adjust each caller of raw_open_common to specify if they are expecting host and character devices or not. Tighten expectations of file types upon open in the common code and refuse types that are not expected. This has two effects: (1) Character and block devices are now considered deprecated

Re: [Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

2018-01-17 Thread David Hildenbrand
On 17.01.2018 22:37, Christian Borntraeger wrote: > > > On 01/17/2018 10:13 PM, David Hildenbrand wrote: >> On 17.01.2018 20:37, Christian Borntraeger wrote: >>> stfle.81 (ppa15) is a transparent facility that can be passed to the >>> guest without the need to implement hypervisor support. As

Re: [Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 10:13 PM, David Hildenbrand wrote: > On 17.01.2018 20:37, Christian Borntraeger wrote: >> stfle.81 (ppa15) is a transparent facility that can be passed to the >> guest without the need to implement hypervisor support. As this feature >> can be provided by firmware we add it to all

[Qemu-devel] [PATCH v2] xilinx_spips: Correct usage of an uninitialized local variable

2018-01-17 Thread Francisco Iglesias
Coverity found that the variable tx_rx in the function xilinx_spips_flush_txfifo was being used uninitialized (CID 1383841). This patch corrects this by always initializing tx_rx to zeros. Signed-off-by: Francisco Iglesias --- v2. Add a sanity check on the num_busses

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-01-17 Thread Benjamin Herrenschmidt
On Wed, 2018-01-17 at 15:39 +0100, Cédric Le Goater wrote: > Migration is a problem. We will need both backend QEMU objects to be > available anyhow if we want to migrate. So we are back to the current > solution creating both QEMU objects but we can try to defer some of the > KVM inits and

Re: [Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

2018-01-17 Thread David Hildenbrand
On 17.01.2018 20:37, Christian Borntraeger wrote: > stfle.81 (ppa15) is a transparent facility that can be passed to the > guest without the need to implement hypervisor support. As this feature > can be provided by firmware we add it to all full models. > > Signed-off-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread David Hildenbrand
On 17.01.2018 20:37, Christian Borntraeger wrote: > We need to handle the bpb control on reset and migration. Normally > stfle.82 is transparent (and the normal guest part works without > hypervisor activity). To prevent any issues we require full > host kernel support for this feature. > >

Re: [Qemu-devel] [PATCH v2 1/3] header sync

2018-01-17 Thread David Hildenbrand
On 17.01.2018 20:37, Christian Borntraeger wrote: > replace with proper header sync > > Signed-off-by: Christian Borntraeger > --- > linux-headers/asm-s390/kvm.h | 9 - > linux-headers/linux/kvm.h| 5 +++-- > 2 files changed, 7 insertions(+), 7 deletions(-) >

Re: [Qemu-devel] [PATCH v1 1/1] linux-user: Fix webkitgtk hangs on 32-bit x86 target

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 05:39 PM, Alistair Francis wrote: > Since commit "linux-user: Tidy and enforce reserved_va initialization" > (18e80c55bb6ec17c05ec0ba717ec83933c2bfc07) the Yocto webkitgtk build > hangs when cross compiling for 32-bit x86 on a 64-bit x86 machine using > musl. > > To fix the issue

Re: [Qemu-devel] [PATCH v3 1/3] xlnx-zynqmp-rtc: Initial commit

2018-01-17 Thread Alistair Francis
On Wed, Jan 17, 2018 at 12:39 PM, Philippe Mathieu-Daudé wrote: > On 01/17/2018 02:27 PM, Alistair Francis wrote: >> Initial commit of the ZynqMP RTC device. >> >> Signed-off-by: Alistair Francis >> --- >> V2: >> - Delete unused realise function >>

Re: [Qemu-devel] [PATCH v3 3/3] xlnx-zynqmp: Connect the RTC device

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 02:27 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > > hw/arm/xlnx-zynqmp.c | 14 ++ >

Re: [Qemu-devel] [PATCH v3 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 02:27 PM, Alistair Francis wrote: > Allow the guest to determine the time set from the QEMU command line. > > This includes adding a trace event to debug the new time. > > The migration logic was copied from the PL031 migration logic. > > Signed-off-by: Alistair Francis

[Qemu-devel] [PATCH v1 1/1] linux-user: Fix webkitgtk hangs on 32-bit x86 target

2018-01-17 Thread Alistair Francis
Since commit "linux-user: Tidy and enforce reserved_va initialization" (18e80c55bb6ec17c05ec0ba717ec83933c2bfc07) the Yocto webkitgtk build hangs when cross compiling for 32-bit x86 on a 64-bit x86 machine using musl. To fix the issue reduce the MAX_RESERVED_VA macro to be a closer match to what

Re: [Qemu-devel] [PATCH v3 1/3] xlnx-zynqmp-rtc: Initial commit

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 02:27 PM, Alistair Francis wrote: > Initial commit of the ZynqMP RTC device. > > Signed-off-by: Alistair Francis > --- > V2: > - Delete unused realise function > - Remove DB_PRINT() > > hw/timer/Makefile.objs | 1 + >

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Peter Maydell
On 17 January 2018 at 19:15, Igor Mammedov wrote: > On Wed, 17 Jan 2018 16:12:09 + > Peter Maydell wrote: >> I like moving this from being an ifdef ladder into per-cpu >> code, but I don't think the definition belongs in target/$ARCH. >> It's

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-17 Thread Jack Schwartz
Hi Kevin and Anatol. Kevin, thanks for your review. More inline below... On 01/15/18 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: Properly account for the possibility of multiboot kernels with a zero bss_end_addr. The Multiboot Specification, section 3.1.3

Re: [Qemu-devel] [PATCH v2 1/3] header sync

2018-01-17 Thread Christian Borntraeger
It is just a header sync and mimics the kernel. The previous header sync added the the commit that added the SPDX tag and this header sync added the commit that removed the now redundant licence text. On 01/17/2018 08:46 PM, Eric Blake wrote: > On 01/17/2018 01:37 PM, Christian Borntraeger wrote:

Re: [Qemu-devel] [PATCH v2 1/3] header sync

2018-01-17 Thread Eric Blake
On 01/17/2018 01:37 PM, Christian Borntraeger wrote: > replace with proper header sync > > Signed-off-by: Christian Borntraeger > --- > linux-headers/asm-s390/kvm.h | 9 - > linux-headers/linux/kvm.h| 5 +++-- > 2 files changed, 7 insertions(+), 7

Re: [Qemu-devel] [PATCH 0/2] iotests compat=0.10 fixes

2018-01-17 Thread Max Reitz
On 2018-01-17 17:54, Eric Blake wrote: > As requested here: > https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03984.html > > Eric Blake (1): > iotests: Split 177 into two parts for compat=0.10 > > Max Reitz (1): > iotests: Disable some tests for compat=0.10 Thanks! Applied to my

[Qemu-devel] [PATCH v2 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger ---

[Qemu-devel] [PATCH v2 1/3] header sync

2018-01-17 Thread Christian Borntraeger
replace with proper header sync Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h

[Qemu-devel] [PATCH v2 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-17 Thread Christian Borntraeger
We want to provide more hw features to guests, namely the new bpb control as well as other transparent facilities that might be introduced by firmware updates (e.g. the stfle facility 81). See the kernel discussion for the KVM side https://www.spinics.net/lists/kernel/msg2700551.html v1->v2: -

[Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

2018-01-17 Thread Christian Borntraeger
stfle.81 (ppa15) is a transparent facility that can be passed to the guest without the need to implement hypervisor support. As this feature can be provided by firmware we add it to all full models. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c

Re: [Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-17 Thread Michael S. Tsirkin
On Wed, Jan 17, 2018 at 01:02:07PM -0600, Eric Blake wrote: > On 01/17/2018 10:41 AM, Daniel P. Berrange wrote: > > Replace the keymap_qcode table with automatically generated > > tables. > > > > Missing entries in keymap_qcode now fixed: > > > > > > > When a keycode is removed from the list

Re: [Qemu-devel] [qemu-s390x] [PATCH 12/24] s390x: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
On Wed, 17 Jan 2018 17:04:31 +0100 David Hildenbrand wrote: > On 17.01.2018 16:43, Igor Mammedov wrote: > > it will be used for for 2 purposes, 1st is to > > provide to cpu name resolving class for machine 'none' > > cpu_parse_cpu_model(machine_class->default_cpu_type,

[Qemu-devel] [PATCH] hw/pci-bridge: fix pcie root port's IO hints capability

2018-01-17 Thread Marcel Apfelbaum
The gen_pcie_root_port mem-reserve and pref32-reserve properties are defined as size (so uint64_t), but passed as uint32_t when building the 'IO hints' vendor specific capability. Passing 4G (or more) gets truncated and passed as a zero reservation. Is not a huge issue since the guest firmware

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Igor Mammedov
On Wed, 17 Jan 2018 16:12:09 + Peter Maydell wrote: > On 17 January 2018 at 15:43, Igor Mammedov wrote: > > Series is finishing work on generalizing cpu_model parsing > > and limiting parts that deal with inconsistent cpu_model > > naming to

Re: [Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-17 Thread Eric Blake
On 01/17/2018 10:41 AM, Daniel P. Berrange wrote: > Replace the keymap_qcode table with automatically generated > tables. > > Missing entries in keymap_qcode now fixed: > > > When a keycode is removed from the list of possible keycodes that host can > send to the guest, it means that the guest

Re: [Qemu-devel] QEMU virt board: extending various limits

2018-01-17 Thread Igor Mammedov
On Wed, 17 Jan 2018 17:53:48 +0100 Andrew Jones wrote: > On Wed, Jan 17, 2018 at 04:18:30PM +, Peter Maydell wrote: > > On 17 January 2018 at 16:15, Igor Mammedov wrote: > > > my idea was to drop fixed RAM base for virt board (at least for > > >

  1   2   3   4   >