Re: [Qemu-devel] [Qemu-arm] [prefix=PATCH for-2.12?] linux-user: check that all of AArch64 SVE extended sigframe is writable

On 16 April 2018 at 16:19, Peter Maydell wrote: > In commit 8c5931de0ac7738809 we added support for SVE extended > sigframe records. These mean that the signal frame might now be > larger than the size of the target_rt_sigframe record, so make sure > we call lock_user

[Qemu-devel] [prefix=PATCH for-2.12?] linux-user: check that all of AArch64 SVE extended sigframe is writable

In commit 8c5931de0ac7738809 we added support for SVE extended sigframe records. These mean that the signal frame might now be larger than the size of the target_rt_sigframe record, so make sure we call lock_user on the entire frame size when we're creating it. (The code for restoring the signal

Re: [Qemu-devel] [RFC] Intermediate block mirroring

On 2018-04-16 16:59, Alberto Garcia wrote: > On Fri 13 Apr 2018 04:23:07 PM CEST, Max Reitz wrote: >> On 2018-04-12 19:07, Alberto Garcia wrote: >>> Hello, >>> >>> I mentioned this some time ago, but I'd like to retake it now: I'm >>> checking how to copy arbitrary nodes on a backing chain, so if

[Qemu-devel] [PATCH V5] migration: add capability to bypass the shared memory

1) What's this When the migration capability 'bypass-shared-memory' is set, the shared memory will be bypassed when migration. It is the key feature to enable several excellent features for the qemu, such as qemu-local-migration, qemu-live-update, extremely-fast-save-restore, vm-template,

Re: [Qemu-devel] [RFC] Intermediate block mirroring

On Fri 13 Apr 2018 04:23:07 PM CEST, Max Reitz wrote: > On 2018-04-12 19:07, Alberto Garcia wrote: >> Hello, >> >> I mentioned this some time ago, but I'd like to retake it now: I'm >> checking how to copy arbitrary nodes on a backing chain, so if I have >> e.g. >> >>[A] <- [B] <- [C] <- [D]

Re: [Qemu-devel] [PATCH v4 1/2] Implement .hex file loader

Sorry I didn't reply in detai on last weekend. Here are some points I want to discuss. > parse_hex_blob() must handle input files that touch large ranges of > memory. At the moment it assumes bin_buf will be large enough for the > memory regions described by the input file. Since Intel HEX

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

On 16 April 2018 at 15:42, Alex Bennée wrote: > > Bastian Koppelmann writes: > >> On 04/16/2018 03:54 PM, Alex Bennée wrote: >>> The re-factoring of div_floats changed the order of checking meaning >>> an operation like -inf/0 erroneously

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

On 4/10/2018 11:33 AM, Yulei Zhang wrote: > Instead of using vm state description, add SaveVMHandlers for VFIO > device to support live migration. > > Introduce new Ioctl VFIO_DEVICE_GET_DIRTY_BITMAP to fetch the memory > bitmap that dirtied by vfio device during the iterative precopy stage >

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

On 4/10/2018 11:32 AM, Yulei Zhang wrote: > VM status change handler is added to change the vfio pci device > status during the migration, write the demanded device status > to the DEVICE STATUS subregion to stop the device on the source side > before fetch its status and start the deivce on the

Re: [Qemu-devel] [RFC PATCH V4 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

On 4/10/2018 11:32 AM, Yulei Zhang wrote: > New VFIO sub region VFIO_REGION_SUBTYPE_DEVICE_STATE is added > to fetch and restore the status of mdev device vGPU during the > live migration. > > Signed-off-by: Yulei Zhang > --- > hw/vfio/pci.c | 25

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

Bastian Koppelmann writes: > On 04/16/2018 03:54 PM, Alex Bennée wrote: >> The re-factoring of div_floats changed the order of checking meaning >> an operation like -inf/0 erroneously raises the divbyzero flag. >> IEEE-754 (2008) specifies this should only occur

Re: [Qemu-devel] [PATCH] vhost: do not verify ring mappings when IOMMU is enabled

On Fri, 13 Apr 2018 11:01:49 +0800 Jason Wang wrote: > When IOMMU is enabled, we store virtqueue metadata as iova (though it > may has _phys suffix) and access them through dma helpers. Any > translation failures could be reported by IOMMU. > > In this case, trying to

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

On Mon 16 Apr 2018 04:05:21 PM CEST, Max Reitz wrote: >> Refcount entries are used to reference host clusters, and host >> clusters are always(*) allocated sequentially, so caching refcount >> blocks doesn't do much. You're always loading the same refcount block >> until it's full, then you move

Re: [Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

On 13 April 2018 at 20:09, Richard Henderson wrote: > On 04/13/2018 04:23 AM, Peter Maydell wrote: >> The MIPS TCG target makes the assumption that the offset from the >> target env pointer to the tlb_table is less than about 64K. This >> used to be true, but gradual addition of

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

On 04/16/2018 08:27 AM, Thomas Huth wrote: > On 14.04.2018 00:08, Collin Walling wrote: >> Rename the loadparm char array in main.c to loadparm_str and >> increased the size by one byte to account for a null termination >> when converting the loadparm string to an int via atoui. We >> also allow

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

On 04/16/2018 03:45 AM, Thomas Huth wrote: > "size_t" should be an unsigned type according to the C standard. > Thus we should also use this convention in the s390-ccw firmware to avoid > confusion. I checked the sources, and apart from one spot in libc.c, the > code should all be fine with this

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

On 13 April 2018 at 05:46, Richard Henderson wrote: > On 04/12/2018 04:02 AM, Peter Maydell wrote: >> AArch64 stack frames include a 'frame record' which holds a pointer >> to the next frame record in the chain and the LR on entry to the >> function. The procedure

Re: [Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

On 16 April 2018 at 15:03, Alex Bennée wrote: > Since kernel commit a86bd139f2 (arm64: arch_timer: Enable CNTVCT_EL0 > trap..) user-space has been able to read this system register. This > patch enables access to that register although currently it always > returns 0 as we

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

On 16 April 2018 at 15:11, Markus Armbruster wrote: > Peter Maydell writes: > >> On 12 March 2018 at 13:18, Stefan Hajnoczi wrote: >>> Warn if files are added/renamed/deleted without MAINTAINERS file >>> changes. This has helped

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On Mon, 16 Apr 2018 15:30:39 +0200 Paolo Bonzini wrote: > On 16/04/2018 15:20, Igor Mammedov wrote: > > Generally object doesn't need to know its own name, > > we use it only for debugging and nice error reporting so far. > > I'd rather have 'id' property at Object level so

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

On 04/16/2018 03:54 PM, Alex Bennée wrote: > The re-factoring of div_floats changed the order of checking meaning > an operation like -inf/0 erroneously raises the divbyzero flag. > IEEE-754 (2008) specifies this should only occur for operations on > finite operands. > > We fix this by moving the

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

Peter Maydell writes: > On 12 March 2018 at 13:18, Stefan Hajnoczi wrote: >> Warn if files are added/renamed/deleted without MAINTAINERS file >> changes. This has helped me in Linux and we could benefit from this >> check in QEMU. >> >> This patch

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

Thomas Huth writes: > On 12.03.2018 14:18, Stefan Hajnoczi wrote: >> Warn if files are added/renamed/deleted without MAINTAINERS file >> changes. This has helped me in Linux and we could benefit from this >> check in QEMU. >> >> This patch is a manual cherry-pick of Linux

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

Thanks for the review. Taking your comments out of order slightly: Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility"): > [change_process_uid] is the only user of @user_pwd, @user_uid, @user_gid. > > Have you considered replacing global @user_pwd

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

On 2018-04-16 15:56, Alberto Garcia wrote: > On Fri 13 Apr 2018 05:00:48 PM CEST, Max Reitz wrote: >> On 2018-03-14 09:29, Alberto Garcia wrote: >>> The L2 and refcount caches have default sizes that can be overridden >>> using the l2-cache-size and refcount-cache-size (an additional >>> parameter

[Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

Since kernel commit a86bd139f2 (arm64: arch_timer: Enable CNTVCT_EL0 trap..) user-space has been able to read this system register. This patch enables access to that register although currently it always returns 0 as we don't yet have a mechanism for managing timers in linux-user mode.

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

On Fri 13 Apr 2018 05:00:48 PM CEST, Max Reitz wrote: > On 2018-03-14 09:29, Alberto Garcia wrote: >> The L2 and refcount caches have default sizes that can be overridden >> using the l2-cache-size and refcount-cache-size (an additional >> parameter named cache-size sets the combined size of both

[Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

The re-factoring of div_floats changed the order of checking meaning an operation like -inf/0 erroneously raises the divbyzero flag. IEEE-754 (2008) specifies this should only occur for operations on finite operands. We fix this by moving the check on the dividend being Inf/0 to before the

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On 16/04/2018 15:20, Igor Mammedov wrote: > Generally object doesn't need to know its own name, > we use it only for debugging and nice error reporting so far. > I'd rather have 'id' property at Object level so we won't have > to fish out ID from parent /which we aren't supposed to do and > which

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On Thu, 12 Apr 2018 11:15:04 +0200 Paolo Bonzini wrote: > On 29/03/2018 05:21, Alexey Kardashevskiy wrote: > > +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, > > TYPE_DEVICE); > > +const char *id = object_property_print(obj, "id", true, NULL); > > I

Re: [Qemu-devel] [PATCH v11 05/17] hw/arm/smmuv3: Wired IRQ and GERROR helpers

On 12 April 2018 at 08:37, Eric Auger wrote: > We introduce some helpers to handle wired IRQs and especially > GERROR interrupt. SMMU writes GERROR register on GERROR event > and SW acks GERROR interrupts by setting GERRORn. > > The Wired interrupts are edge sensitive hence

Re: [Qemu-devel] [PATCH v11 04/17] hw/arm/smmuv3: Skeleton

On 12 April 2018 at 08:37, Eric Auger wrote: > From: Prem Mallappa > > This patch implements a skeleton for the smmuv3 device. > Datatypes and register definitions are introduced. The MMIO > region, the interrupts and the queue are initialized.

Re: [Qemu-devel] [PATCH v11 03/17] hw/arm/smmu-common: VMSAv8-64 page table walk

On 12 April 2018 at 08:37, Eric Auger wrote: > This patch implements the page table walk for VMSAv8-64. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mallappa > diff --git a/hw/arm/smmu-common.c

Re: [Qemu-devel] [PATCH v2 0/4] Small fixes for s390x QEMU boot menu

On 14.04.2018 00:08, Collin Walling wrote: > Change Log: > > v2 > > - added r-b's > - s/zipl_println/zipl_print_entry > - prints entry and returns entry number > - while loop now handles valid_entries Series reviewed-by: Janosch Frank

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

Steps to reproduce: # on ubuntu bionic amd64 host sudo apt-add-repository ppa:ev3dev/tools # assuming apt-add-repository does apt update now sudo apt install pbuilder-ev3dev git git clone --depth=1 https://github.com/ev3dev/opencv cd opencv OS=debian ARCH=armhf DIST=stretch pbuilder-ev3dev base

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

I am seeing the same symptoms as the original poster. I'm building the opencv package in a debian stretch armfh chroot on a ubuntu bionic amd64 host. So, I'm guessing that the race condition wasn't entirely fixed or there has been some sort of regression. -- You received this bug notification

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

On 04/13/2018 05:29 PM, Peter Maydell wrote: > On 13 April 2018 at 16:24, Bastian Koppelmann > wrote: >> However, my risu-like tests found another flag raising problem with >> float32_div. I'll investigate it on Monday. I found the problem. With float32_div(a, b),

[Qemu-devel] [PULL 2/2] iotests: fix 169

From: Vladimir Sementsov-Ogievskiy Improve and fix 169: - use MIGRATION events instead of RESUME - make a TODO: enable dirty-bitmaps capability for offline case - recreate vm_b without -incoming near test end This (likely) fixes racy faults at least of the

[Qemu-devel] [PULL 0/2] Block patches for 2.12.0-rc4

The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16 10:11:17 +0100) are available in the Git repository at: git://github.com/XanClic/qemu.git

[Qemu-devel] [PULL 1/2] qcow2: try load bitmaps only once

From: Vladimir Sementsov-Ogievskiy Checking reopen by existence of some bitmaps is wrong, as it may be some other bitmaps, or on the other hand, user may remove bitmaps. This criteria is bad. To simplify things and make behavior more predictable let's just add a flag to

Re: [Qemu-devel] [PATCH v11 02/17] hw/arm/smmu-common: IOMMU memory region and address space setup

On 12 April 2018 at 08:37, Eric Auger wrote: > We set up the infrastructure to enumerate all the PCI devices > attached to the SMMU and create an associated IOMMU memory > region and address space. > > Those info are stored in SMMUDevice objects. The devices are > grouped

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

On 14.04.2018 00:08, Collin Walling wrote: > Rename the loadparm char array in main.c to loadparm_str and > increased the size by one byte to account for a null termination > when converting the loadparm string to an int via atoui. We > also allow the boot menu to be enabled when loadparm is set

Re: [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB

On 12 April 2018 at 14:55, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > Hence

Re: [Qemu-devel] [PATCH] Implement query-usbhost QMP command

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1523675125-14022-1-git-send-email-...@godking.net Subject: [Qemu-devel] [PATCH] Implement

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

Ok, confusion around backend is I think cleared up. The other confusion seems to be around dma-buf: dma-buf is the cross subsystem zerocopy abstraction. PRIME is the drm-specific support for it, 100% based on top of the generic struct dma_buf. You need a dma_buf exporter to convert a xen grant

Re: [Qemu-devel] [PATCH] Show values and description when using "qom-list"

Hi, A new patch (to be rebase on top of my previous one). From 77f7217c07d5e3892f26082f220954678eb375b3 Mon Sep 17 00:00:00 2001 From: Ricardo Perez Blanco Date: Mon, 16 Apr 2018 13:51:42 +0200 Subject: [PATCH] [PATCHv2] Show values and description when using

Re: [Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd

On 2018-04-06 17:17, Max Reitz wrote: > My non-Fedora testing system does not have a kernel with userfaultfd > support which causes 181 and 201 to fail. That is annoying. This > series makes those tests recognize the issue and convert it into a > _notrun. > > > Max Reitz (2): > iotests: Add

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

On 16/04/2018 13:17, Daniel P. Berrangé wrote: > A user trying out SMBIOS "OEM strings" feature reported that the data > they are exposing to the guest was truncated at 1023 bytes, which breaks > the app consuming in the guest. After searching for the cause I > eventually found that the QemuOpts

[Qemu-devel] [PATCH v2 7/7] blockdev: unify block-dirty-bitmap-clear command and transaction action

- use error messages from qmp command, as they are more descriptive - we need not check bs, as block_dirty_bitmap_lookup never returns bs = NULL on success (and if user set bs to be not NULL pointer), so, let's just assert it. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction commit, avoiding any rollback. After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 1 -

[Qemu-devel] [PATCH v2 4/7] dirty-bitmap: separate unused meta-bitmap related functions

Separate them in the header and clarify needed locking in comments. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 14 +- block/dirty-bitmap.c | 5 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v2 6/7] block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter

Drop parameter "HBitmap **out" which is unused now, all callers set it to NULL. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 2 +- block/dirty-bitmap.c | 14 +- blockdev.c| 4 ++-- 3 files changed, 8

[Qemu-devel] [PATCH v2 2/7] dirty-bitmaps: fix comment about dirty_bitmap_mutex

Clarify first two cases and fix Modify -> Any access in third case. Also, drop 'only' from third case, as it a bit confuses, when thinking about case where we modify BdrvDirtyBitmap and access HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH v2 3/7] dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header

Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h index 1ff8949b1b..c7e910016d 100644 --- a/include/block/dirty-bitmap.h +++

[Qemu-devel] [PATCH v2 for-2.13 0/7] Dirty bitmaps fixing and refactoring

v2: 05: drop bdrv_undo_clear_dirty_bitmap(), which becomes unused. Vladimir Sementsov-Ogievskiy (7): block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap dirty-bitmaps: fix comment about dirty_bitmap_mutex dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header

[Qemu-devel] [PATCH v2 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

Functions write to BdrvDirtyBitmap field, so the should take the lock. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 4 1 file changed, 4 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 967159479d..6c00288fd7

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper

14.04.2018 00:06, John Snow wrote: On 04/13/2018 01:44 PM, Vladimir Sementsov-Ogievskiy wrote: will add, as always, thank you for natural rewording) Hm, I have a question: why do you often use double white-space "  " between sentences? Is it something meaningful? There is some GREAT DEBATE in

Re: [Qemu-devel] [PATCH 1/3] accel: use g_strsplit for parsing accelerator names

On 04/16/2018 08:17 AM, Daniel P. Berrangé wrote: > Instead of re-using the get_opt_name() method from QemuOpts to split a > string on ':', just use g_strsplit(). > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé > --- >

[Qemu-devel] [PATCH 3/3] opts: don't silently truncate long option values

The existing QemuOpts parsing code uses a fixed size 1024 byte buffer for storing the option values. If a value exceeded this size it was silently truncated and no error reported to the user. Long option values is not a common scenario, but it is conceivable that they will happen. eg if the user

[Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

A user trying out SMBIOS "OEM strings" feature reported that the data they are exposing to the guest was truncated at 1023 bytes, which breaks the app consuming in the guest. After searching for the cause I eventually found that the QemuOpts parsing is using fixed length 1024 byte array for option

[Qemu-devel] [PATCH 1/3] accel: use g_strsplit for parsing accelerator names

Instead of re-using the get_opt_name() method from QemuOpts to split a string on ':', just use g_strsplit(). Signed-off-by: Daniel P. Berrangé --- accel/accel.c | 16 +++- include/qemu/option.h | 1 - util/qemu-option.c| 3 ++- 3 files changed, 9

[Qemu-devel] [PATCH 2/3] opts: don't silently truncate long parameter keys

The existing QemuOpts parsing code uses a fixed size 128 byte buffer for storing the parameter keys. If a key exceeded this size it was silently truncate and no error reported to the user. This behaviour was reasonable & harmless because traditionally the key names are all statically declared, and

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

On Mon, Apr 16, 2018 at 11:53:41AM +0100, Richard W.M. Jones wrote: > On Mon, Apr 16, 2018 at 11:31:18AM +0100, Daniel P. Berrangé wrote: > > Essentially this is abusing the export name as a crude authentication > > token. There are NBD servers that expect NBD_OPT_LIST to always succeeed > > I

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

On 16 April 2018 at 10:19, Andrew Jones wrote: > This is the cleaner choice, but I wasn't opposed to the max-vcpus > query getting double-duty though. While the backporting argument is > a good point, I'm not sure we've ever really cared about what > issues backporters have

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

On Mon, Apr 16, 2018 at 11:31:18AM +0100, Daniel P. Berrangé wrote: > Essentially this is abusing the export name as a crude authentication > token. There are NBD servers that expect NBD_OPT_LIST to always succeeed I guess you mean "NBD clients" ... > when they detect that the new style protocol

Re: [Qemu-devel] [PULL 0/1] m68k fixes for 2.12-rc4

On 15 April 2018 at 10:46, Laurent Vivier wrote: > The following changes since commit 38e83a71d02e026d4a6d0ab1ef9855c4924c2c68: > > Update version for v2.12.0-rc3 release (2018-04-11 19:03:24 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

On 04/16/2018 09:45 AM, Thomas Huth wrote: > "size_t" should be an unsigned type according to the C standard. > Thus we should also use this convention in the s390-ccw firmware to avoid > confusion. I checked the sources, and apart from one spot in libc.c, the > code should all be fine with this

Re: [Qemu-devel] [PATCH 2/4] configure: Display if libfdt is from system or git

Hi Thomas, On 04/16/2018 02:16 AM, Thomas Huth wrote: > On 16.04.2018 01:05, Philippe Mathieu-Daudé wrote: >> The configure script outputs "yes" regardless which libfdt is used: >> >> ./configure >> [...] >> fdt support yes >> >> Sometimes you can have both system and local git

Re: [Qemu-devel] [PATCH v1 00/24] fix building of tests/tcg

On 04/10/2018 04:38 PM, Alex Bennée wrote: > Hi, > > We've talked about fixing this up for a long time and there have been > several RFC patches sent attempting to do that. This is yet another > RFC but hopefully shows a way forward which can build on our docker > support but also allow users to

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

On Fri, Apr 13, 2018 at 10:26:03PM +0300, Nir Soffer wrote: > When a management application expose images using qemu-nbd, it needs a > secure way to allow temporary access to the disk. Using a random export > name can solve this problem: > >

Re: [Qemu-devel] [PATCH v1 03/24] configure: move i386_cc to cross_cc_i386

On 04/16/2018 06:02 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Hi Alex, >> >> On 04/10/2018 04:38 PM, Alex Bennée wrote: >>> We should still be able to use the system cross compiler with the >>> appropriate flags on x86_64 hosts. >>> >>> Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

On 04/16/2018 05:53 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> Now all the build infrastructure is in place we can build tests for >>> each guest that we support. That support mainly depends on having >>> cross

Re: [Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

On 04/16/2018 05:56 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> These only need to be built for MIPS guests. >>> >>> Signed-off-by: Alex Bennée >>> --- >>> tests/tcg/README

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

On 04/16/2018 12:32 PM, Daniel Vetter wrote: On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko wrote: On 04/16/2018 10:43 AM, Daniel Vetter wrote: On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: On 04/13/2018 06:37 PM, Daniel Vetter wrote:

Re: [Qemu-devel] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes

Hi Thomas, On 04/16/2018 01:53 AM, Thomas Huth wrote: > On 16.04.2018 01:42, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/devices.h | 7 ++- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

On 04/16/2018 06:37 AM, Michael Tokarev wrote: > Fixes 722cd7496474cebb2218f21e038592fad8603365 > > Signed-off-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > Makefile | 2 +- > 1 file

Re: [Qemu-devel] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly

On 16/04/2018 2:43, Philippe Mathieu-Daudé wrote: > All files using "qemu/units.h" definitions already include it directly, > we can now remove it from "qemu/cutils.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/cutils.h | 1 - > hw/core/machine.c | 2 +-

Re: [Qemu-devel] [PATCH v3 32/41] hw/i386: Use the BYTE-based definitions

On 16/04/2018 2:42, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH v4 4/4] qobject: modify qobject_ref() to assert on NULL and return obj

Markus Armbruster writes: > Marc-André Lureau writes: > >> Following a discussion on the mailing list: > > If a reader of this commit message could profit from reading the > discussion, refer to it by URL and/or Message-Id. If not, don't mention

Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

16.04.2018 12:26, Peter Maydell wrote: > On 14 April 2018 at 15:27, Michael Tokarev wrote: >> -ifeq ($(CONFIG_GTK),m) >> +ifneq ($(filter $(CONFIG_GTK),y m),) >> $(MAKE) -C po $@ >> endif > "trivial" and "for 2.12" don't make much sense together at this point in > the

[Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

Fixes 722cd7496474cebb2218f21e038592fad8603365 Signed-off-by: Michael Tokarev --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 727ef118f3..d71dd5bea4 100644 --- a/Makefile +++ b/Makefile @@ -856,7 +856,7 @@ ifneq

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko wrote: > On 04/16/2018 10:43 AM, Daniel Vetter wrote: >> >> On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: >>> >>> On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at

Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

On 14 April 2018 at 15:27, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 727ef118f3..8644c2e918 100644 > --- a/Makefile > +++

Re: [Qemu-devel] [PATCH] linux-user: Add ARM get_tls syscall support

On 16 April 2018 at 10:18, Christophe Lyon wrote: > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon I think it's worth mentioning in the commit message that this is a new Arm-specific syscall added in kernel

Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries

On 16 April 2018 at 08:57, Christophe Lyon wrote: > On 13/04/2018 17:04, Peter Maydell wrote: >> I think we should just have support for these binaries enabled >> always. Otherwise it will bitrot because nobody compiles it. >> > We are relying on a pre-existing

[Qemu-devel] [PATCH] linux-user: Add ARM get_tls syscall support

Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h index 94e2a42..afc0772 100644 --- a/linux-user/arm/target_syscall.h +++ b/linux-user/arm/target_syscall.h @@

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

On Fri, Apr 13, 2018 at 04:11:24PM +0200, Auger Eric wrote: > Hi Peter, > > On 13/04/18 16:06, Peter Maydell wrote: > > On 13 April 2018 at 15:01, Auger Eric wrote: > >> On 13/04/18 15:41, Peter Maydell wrote: > >>> I think it would be better to explicitly check "do we

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > > In the future the monitor iothread may be accessing the cur_mon as > > well (via monitor_qmp_dispatch_one()). Before we introduce a real > > Out-Of-Band command, let's

Re: [Qemu-devel] [PATCH v2 0/2] Softfloat Fixes for 2.12

On 13 April 2018 at 15:03, Alex Bennée wrote: > Hi, > > The float_invalid patch now handles the Inf case as well and includes > the fix to round_to_uint_and_pack. > > Alex Bennée (1): > fpu/softfloat: raise float_invalid for NaN/Inf in > round_to_int_and_pack > >

Re: [Qemu-devel] [PATCH v1 03/24] configure: move i386_cc to cross_cc_i386

Philippe Mathieu-Daudé writes: > Hi Alex, > > On 04/10/2018 04:38 PM, Alex Bennée wrote: >> We should still be able to use the system cross compiler with the >> appropriate flags on x86_64 hosts. >> >> Signed-off-by: Alex Bennée >> --- >> configure |

Re: [Qemu-devel] [PATCH v1 09/24] tests/tcg: move architecture independent tests into subdir

Philippe Mathieu-Daudé writes: > Hi Alex, > > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> We will want to build these for all supported guest architectures so >> lets move them all into one place. We also drop test_path at this >> point because it needs qemu utils and glib

Re: [Qemu-devel] [PATCH v1 12/24] tests/tcg/i386: Build fix for hello-i386

Philippe Mathieu-Daudé writes: > Hi Fam, Alex, > > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> From: Fam Zheng >> >> We have -Werror=missing-prototype, add a dummy prototype to avoid that >> warning. >> >> Signed-off-by: Fam Zheng >> ---

Re: [Qemu-devel] [PATCH v4 3/4] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF

Marc-André Lureau writes: > Now that we can safely call QOBJECT() on QObject * and children types, > we can have a single macro to ref/unref the object. > > Change the incref/decref prefix name for the more common ref/unref. > > Note that before the patch,

[Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v2 - https://lists.nongnu.org/archive/html/qemu-ppc/2018-04/msg00052.html Changes in v3: - Addressed David Gibson's review

Re: [Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

Philippe Mathieu-Daudé writes: > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> These only need to be built for MIPS guests. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/README | 11 --- >> tests/tcg/mips/README

Re: [Qemu-devel] [PATCH v1 21/24] tests/tcg: enable building for ppc64

Philippe Mathieu-Daudé writes: > Hi Alex, > > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> Currently this just enables building the multiarch tests. >> >> Signed-off-by: Alex Bennée > > "make tcg-tests-ppc64-linux-user" works indeed. > > Reviewed-by:

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

Philippe Mathieu-Daudé writes: > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> Now all the build infrastructure is in place we can build tests for >> each guest that we support. That support mainly depends on having >> cross compilers installed or docker setup. To keep all the

[Qemu-devel] Let event loop use non-default GMainContext

Hello, It seems that AIO use global default GMainContext by *g_main_context_default()*. I want to replace all default GMainContext into another GMainContext by *g_main_context_new()*, but I have no idea when and where to add *g_main_context_new()*. It should be only created new GMainContext

Re: [Qemu-devel] [PATCH v1 10/24] tests/tcg/multiarch: Build fix for linux-test

Philippe Mathieu-Daudé writes: > On 04/15/2018 09:07 PM, Philippe Mathieu-Daudé wrote: >> Hi Fam, Alex, >> >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> From: Fam Zheng >>> >>> To keep the compiler happy, and to fit in our buildsys flags: >>> >>> - Make

Re: [Qemu-devel] [PATCH v1 02/24] configure: add support for --cross-cc-FOO

Philippe Mathieu-Daudé writes: > On 04/10/2018 04:38 PM, Alex Bennée wrote: >> This allows us to specify cross compilers for our guests. This is >> useful for building test images/programs. Currently we re-run the >> compile test for each target. I couldn't think of a way to

<    1   2   3   >