Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Thomas Huth
On 11.07.2018 22:15, Paolo Bonzini wrote: [...] > I think you're on the right track, after object_property_add_child you > need to drop the reference to the object. Yes, that's the issue indeed! The child objects get properly cleaned up once I add the object_unref() after the

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-11 Thread Thomas Huth
On 12.07.2018 07:14, Alexey Kardashevskiy wrote: > On Thu, 12 Jul 2018 07:01:34 +0200 > Thomas Huth wrote: > >> On 12.07.2018 03:01, David Gibson wrote: >>> On Wed, Jul 11, 2018 at 08:53:05PM +1000, Alexey Kardashevskiy wrote: On Wed, 11 Jul 2018 16:26:19 +1000 David Gibson wrote:

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-11 Thread Alexey Kardashevskiy
On Thu, 12 Jul 2018 07:01:34 +0200 Thomas Huth wrote: > On 12.07.2018 03:01, David Gibson wrote: > > On Wed, Jul 11, 2018 at 08:53:05PM +1000, Alexey Kardashevskiy wrote: > >> On Wed, 11 Jul 2018 16:26:19 +1000 > >> David Gibson wrote: > >> > >>> On Tue, Jul 10, 2018 at 05:14:53PM +1000,

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-11 Thread Thomas Huth
On 12.07.2018 03:01, David Gibson wrote: > On Wed, Jul 11, 2018 at 08:53:05PM +1000, Alexey Kardashevskiy wrote: >> On Wed, 11 Jul 2018 16:26:19 +1000 >> David Gibson wrote: >> >>> On Tue, Jul 10, 2018 at 05:14:53PM +1000, Alexey Kardashevskiy wrote: On Tue, 10 Jul 2018 16:42:48 +1000

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Thomas Huth
On 11.07.2018 20:43, Eduardo Habkost wrote: > On Wed, Jul 11, 2018 at 07:00:54PM +0200, Sebastian Bauer wrote: >> Am 2018-07-11 17:48, schrieb Eduardo Habkost: >>> "none" looked like a false positive when I first looked, but now >>> I think it's not. Shouldn't it set default_display="none"? >> >>

Re: [Qemu-devel] [PATCH] ppc/xics: split ICP into icp-base and icp class

2018-07-11 Thread David Gibson
On Wed, Jul 11, 2018 at 11:26:41AM +0200, Greg Kurz wrote: > On Wed, 11 Jul 2018 11:28:02 +1000 > David Gibson wrote: > > > On Tue, Jul 10, 2018 at 05:55:14PM +0200, Greg Kurz wrote: > > > Recent cleanup in commit a028dd423ee6 causes QEMU to crash during CPU > > > hotplug: > > > > > > (qemu)

Re: [Qemu-devel] [PATCH] migration: release MigrationIncomingState in migration_object_finalize

2018-07-11 Thread 858585 jemmy
On Fri, Jul 6, 2018 at 6:41 PM, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >> > Qemu initialize the MigrationIncomingState structure in >> > migration_object_init, >> > but not release it. this patch

[Qemu-devel] [PATCH v2] nvme: Fix nvme_init error handling

2018-07-11 Thread Fam Zheng
It is wrong to leave this field as 1, as nvme_close() called in the error handling code in nvme_file_open() will use it and try to free s->queues again. Another problem is the cleaning ups are duplicated between the fail* labels of nvme_init() and nvme_file_open(), which calls nvme_close(). A

[Qemu-devel] [PATCH v2] target-i386: coalesced PIO support for RTC

2018-07-11 Thread Wanpeng Li
From: Peng Hao Windows I/O, such as the real-time clock. The address register (port 0x70 in the RTC case) can use coalesced I/O, cutting the number of userspace exits by half when reading or writing the RTC. Guest access rtc like this: write register index to 0x70, then write or read data from

[Qemu-devel] [Bug 1777969] Re: Crash with UEFI, q35, AHCI, and <= SystemRescueCD 4.3.0

2018-07-11 Thread Matthew Stapleton
It looks like this crash is fixed with git commit: bed9bcfa3275a9cfee82846a9f521c4858a9739a -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777969 Title: Crash with UEFI, q35, AHCI, and <=

[Qemu-devel] [PATCH v3 4/4] tests: Add centos VM testing

2018-07-11 Thread Fam Zheng
This one does docker testing in the VM. It is intended to replace the native docker testing on patchew testers. Signed-off-by: Fam Zheng --- tests/vm/Makefile.include | 3 +- tests/vm/centos | 84 +++ 2 files changed, 86 insertions(+), 1

[Qemu-devel] [PATCH v3 2/4] tests/vm: Pass verbose flag into VM make commands

2018-07-11 Thread Fam Zheng
Our Makefile has: vm-build-%: tests/vm/%.img $(call quiet-command, \ $(SRC_PATH)/tests/vm/$* \ $(if $(V)$(DEBUG), --debug) \ $(if $(DEBUG), --interactive) \ the intention of which is to let the make command in VM have V=1 if V=1 is set. We

[Qemu-devel] [PATCH v3 1/4] tests: Add an option for snapshot (default: off)

2018-07-11 Thread Fam Zheng
Not using snapshot has the benefit of automatically persisting useful test harnesses, such as docker images and ccache database. Although it will lose some cleanness, it is imaginably useful for patchew. Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 7 ++- 1 file changed, 6

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-11 Thread David Gibson
On Wed, Jul 11, 2018 at 08:53:05PM +1000, Alexey Kardashevskiy wrote: > On Wed, 11 Jul 2018 16:26:19 +1000 > David Gibson wrote: > > > On Tue, Jul 10, 2018 at 05:14:53PM +1000, Alexey Kardashevskiy wrote: > > > On Tue, 10 Jul 2018 16:42:48 +1000 > > > David Gibson wrote: > > > > > > > On

[Qemu-devel] [PATCH v3 0/4] Add a CentOS test image to run docker tests

2018-07-11 Thread Fam Zheng
v3: Add 'make vm-test' document. [Phil] v2: Drop archive-source.sh changes. The new test depends on the iotests nbd fix I posted today to pass. Docker testing on patchew has long suffered from 'make check' hangings. The cleanness of VM testing is the cure. Now let's add a CentOS 7 image to

[Qemu-devel] [PATCH v3 3/4] tests: Allow overriding archive path with SRC_ARCHIVE

2018-07-11 Thread Fam Zheng
In VM based tests, the source archive is created in host, we don't have to run archive-source.sh again, as it complicates the Makefile and scripts. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [Bug 1719339] Re: serial8250: too much work for irq3

2018-07-11 Thread Paul Gear
Further update: AWS kernel experienced the same error messages after just over 3 hours of runtime. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719339 Title: serial8250: too much work for irq3

[Qemu-devel] [PATCH v2] Zero out the host's `msg_control` buffer

2018-07-11 Thread Jonas Schievink
If this is not done, qemu would drop any control message after the first one. This is because glibc's `CMSG_NXTHDR` macro accesses the uninitialized cmsghdr's length field in order to find out if the message fits into the `msg_control` buffer, wrongly assuming that it doesn't because the length

[Qemu-devel] [Bug 1781281] Re: qemu-ppc64le uncaught target signal 4 (Illegal instruction)

2018-07-11 Thread Laurent Vivier
If it works fine on a POWER9 machine, you should try to run qemu-ppc64le with "-cpu power9". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1781281 Title: qemu-ppc64le uncaught target signal 4

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: replace scrollingDeltaY with deltaY

2018-07-11 Thread Peter Maydell
On 9 July 2018 at 16:02, John Arbuckle wrote: > The NSEvent class method scrollingDeltaY is available > for Mac OS 10.7 and newer. Since QEMU supports Mac OS > 10.5 and up, we need to be using a method that is > available on these version of Mac OS X. The deltaY > method is a method that does the

[Qemu-devel] [Bug 1781281] [NEW] qemu-ppc64le uncaught target signal 4 (Illegal instruction)

2018-07-11 Thread Luc
Public bug reported: qemu-ppc64le version 2.12.0 host machine: x86_64 Arch Linux I'm currently working on VSX support in libVPX, I'm using qemu to test, on line 723 of vpx_dsp/ppc/loopfilter_vsx.c, when I change the vec_sub to vec_subs I get: qemu: uncaught target signal 4 (Illegal

[Qemu-devel] [PATCH v1 1/1] scsi-disk: Block Device Characteristics emulation fix

2018-07-11 Thread Daniel Henrique Barboza
The current BDC VPD page (page 0xb1) is too short. This can be seen running sg_utils: $ sg_vpd --page=bdc /dev/sda Block device characteristics VPD page (SBC): Block device characteristics VPD page length too short=8 By the SCSI spec, the expected size of the SBC page is 0x40. There is no

Re: [Qemu-devel] [PATCH] Zero out the host's `msg_control` buffer

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Jonas, You forgot to notify the maintainers, see https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer : ./scripts/get_maintainer.pl -f linux-user/syscall.c Riku Voipio (maintainer:Linux user) Laurent Vivier (reviewer:Linux user) qemu-devel@nongnu.org (open list:All

Re: [Qemu-devel] [PATCH] linux-user: ppc64: use the correct values for F_*LK64s

2018-07-11 Thread Laurent Vivier
Le 11/07/2018 à 15:04, Laurent Vivier a écrit : > Le 11/07/2018 à 12:55, Shivaprasad G Bhat a écrit : >> Qemu includes the glibc headers for the host defines and target headers are >> part of the qemu source themselves. The glibc has the F_GETLK64, F_SETLK64 >> and F_SETLKW64 defined to 12, 13 and

Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()

2018-07-11 Thread Richard Henderson
On 07/11/2018 01:27 PM, Laurent Vivier wrote: > Richard, > > I think this fix could be merged into your "linux-user: Fix shmat > emulation by honoring host SHMLBA" patch, by adding something like this > instead: Well, not "instead", but "in addition". Nothing works right when the guest

Re: [Qemu-devel] [PATCH 3/7] tests/qgraph: sdhci driver and interface nodes

2018-07-11 Thread Emanuele
Hi Philippe, On 07/11/2018 10:13 PM, Philippe Mathieu-Daudé wrote: Hi Emanuele, On 07/09/2018 06:11 AM, Emanuele Giuseppe Esposito wrote: Add qgraph nodes for sdhci-pci and generic-sdhci (memory mapped) drivers. Both drivers implement (produce) the same interface sdhci, that provides the

Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()

2018-07-11 Thread Richard Henderson
On 07/11/2018 09:40 AM, Laurent Vivier wrote: > The value given by mmap_find_vma_reserved() is used with mmap(), > so it is needed to be aligned with the host page size. > > Since commit 18e80c55bb, reserved_va is only aligned to TARGET_PAGE_SIZE, > and it works well if this size is greater or

[Qemu-devel] [Bug 1781280] [NEW] QEMU ignores all but the first control message sent over a Unix socket

2018-07-11 Thread Jonas Schievink
Public bug reported: I've written a test program that sends both an SCM_CREDENTIALS and an SCM_RIGHTS cmsg in the same sendmsg call. On native x86-64, armv6 and armv7 Linux, this works as expected (the recvmsg receives both control messages). On QEMU (both qemu-x86_64 and qemu-arm), only the

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 10:16:42PM +0200, Paolo Bonzini wrote: > On 11/07/2018 20:30, Eduardo Habkost wrote: > >> The theoretical behavior should be: > > It's not clear below where you expect > > qdev_set_parent_bus(..., sysbus_get_default()) > > to be called (if it should be called at all). > >

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 12:30 PM, Paolo Bonzini wrote: > On 11/07/2018 16:59, Stefan Hajnoczi wrote: >>> +machine->obj.get_device = raspi2_get_device; >>> +machine->obj.destructor = raspi2_destroy; >>> +qos_create_sdhci_mm(>sdhci, 0x3f30, &(QSDHCIProperties) { >>> +.version = 3, >>>

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 20:30, Eduardo Habkost wrote: >> The theoretical behavior should be: > It's not clear below where you expect > qdev_set_parent_bus(..., sysbus_get_default()) > to be called (if it should be called at all). > > I don't know where it should be called, but I'm absolutely sure >

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 20:43, Thomas Huth wrote: >> >> - realize fails > In this case, the failure is before realize is attempted, > qdev_device_add() already stop with "Device '%s' can not be hotplugged > on this machine". Still, object_unparent is called by qdev_device_add in the error path, and it

Re: [Qemu-devel] [PATCH 3/7] tests/qgraph: sdhci driver and interface nodes

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Emanuele, On 07/09/2018 06:11 AM, Emanuele Giuseppe Esposito wrote: > Add qgraph nodes for sdhci-pci and generic-sdhci (memory mapped) drivers. > Both drivers implement (produce) the same interface sdhci, that provides the > readw - readq - writeq functions. > > Signed-off-by: Emanuele

Re: [Qemu-devel] [PATCH for-3.0] target/arm: Fix LD1W and LDFF1W (scalar plus vector)

2018-07-11 Thread Richard Henderson
On 07/11/2018 04:04 AM, Laurent Desnogues wrote: > Hello, > > On Wed, Jul 11, 2018 at 12:39 PM, Richard Henderson > wrote: >> 'I' was being double-incremented; correctly within the inner loop >> and incorrectly within the outer loop. >> >> Signed-off-by: Richard Henderson > > I didn't try to

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Emanuele, On 07/09/2018 06:11 AM, Emanuele Giuseppe Esposito wrote: > Add pci-bus-pc node and pci-bus interface, moved QPCIBusPC struct "move" > declaration in its header (since it will be needed by other drivers) > and introduced a setter method for drivers that do not need to allocate

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 09:04:35PM +0200, Thomas Huth wrote: > On 11.07.2018 19:21, Paolo Bonzini wrote: > > On 10/07/2018 08:50, Peter Maydell wrote: > Yuck. The real problem here is that we're still requiring the > code that creates these QOM devices to manually set the parent >

[Qemu-devel] [PULL 1/1] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-11 Thread Alex Williamson
From: Cédric Le Goater PCI devices needing a ROM allocate an optional MemoryRegion with pci_add_option_rom(). pci_del_option_rom() does the cleanup when the device is destroyed. The only action taken by this routine is to call vmstate_unregister_ram() which clears the id string of the optional

[Qemu-devel] [PULL 0/1] VFIO fixes for qemu-3.0-rc1

2018-07-11 Thread Alex Williamson
The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc: Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20180711.1 for you to fetch changes up to

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 06:19:33PM +0200, Paolo Bonzini wrote: > On 11/07/2018 18:00, Eduardo Habkost wrote: > >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, > >> CPUState *cs, > >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of > >> *

[Qemu-devel] [PULL 0/1] Monitor patches for 2018-07-11

2018-07-11 Thread Markus Armbruster
The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc: Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-07-11 for you to fetch changes up to

[Qemu-devel] [PULL 1/1] monitor: fix double-free of request error

2018-07-11 Thread Markus Armbruster
From: Marc-André Lureau qmp_error_response() will free the given error. Fix double-free in later qmp_request_free(). Signed-off-by: Marc-André Lureau Message-Id: <20180705164201.9853-1-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Thomas Huth
On 11.07.2018 19:21, Paolo Bonzini wrote: > On 10/07/2018 08:50, Peter Maydell wrote: Yuck. The real problem here is that we're still requiring the code that creates these QOM devices to manually set the parent in the first place. It's not surprising that we don't get it right

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Thomas Huth
On 11.07.2018 19:20, Paolo Bonzini wrote: > On 09/07/2018 23:03, Thomas Huth wrote: >> >> The problem is that qdev_set_parent_bus() from instance_init adds a link >> to the child devices which is not valid anymore after the device init >> failed. Thus the qdev_set_parent_bus() must rather be done

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 07:00:54PM +0200, Sebastian Bauer wrote: > Am 2018-07-11 17:48, schrieb Eduardo Habkost: > > "none" looked like a false positive when I first looked, but now > > I think it's not. Shouldn't it set default_display="none"? > > I think that there is some other logic burried

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 07:20:42PM +0200, Paolo Bonzini wrote: > On 09/07/2018 23:03, Thomas Huth wrote: > > > > The problem is that qdev_set_parent_bus() from instance_init adds a link > > to the child devices which is not valid anymore after the device init > > failed. Thus the

Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()

2018-07-11 Thread Laurent Vivier
Le 11/07/2018 à 18:40, Laurent Vivier a écrit : > The value given by mmap_find_vma_reserved() is used with mmap(), > so it is needed to be aligned with the host page size. > > Since commit 18e80c55bb, reserved_va is only aligned to TARGET_PAGE_SIZE, > and it works well if this size is greater or

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Emanuele
On 07/11/2018 05:15 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: +/** + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. Paolo

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Emanuele
On 07/11/2018 04:49 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:31AM +0200, Emanuele Giuseppe Esposito wrote: -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc) +static void *qpci_get_driver(void *obj, const char *interface) { -QPCIBusPC *ret = g_new0(QPCIBusPC,

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Paolo Bonzini
On 10/07/2018 08:50, Peter Maydell wrote: >>> Yuck. The real problem here is that we're still requiring the >>> code that creates these QOM devices to manually set the parent >>> in the first place. It's not surprising that we don't get it right >>> (either parenting in the wrong place or not at

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Paolo Bonzini
On 09/07/2018 23:03, Thomas Huth wrote: > > The problem is that qdev_set_parent_bus() from instance_init adds a link > to the child devices which is not valid anymore after the device init > failed. Thus the qdev_set_parent_bus() must rather be done in the realize > function instead. The

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Peter Maydell
On 11 July 2018 at 17:12, Eduardo Habkost wrote: > On Wed, Jul 11, 2018 at 09:21:48AM +0200, Thomas Huth wrote: >> On 10.07.2018 08:50, Peter Maydell wrote: >> > On 9 July 2018 at 23:03, Thomas Huth wrote: >> >> On 09.07.2018 23:42, Peter Maydell wrote: >> >>> On 9 July 2018 at 22:03, Thomas

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Sebastian Bauer
Am 2018-07-11 17:48, schrieb Eduardo Habkost: "none" looked like a false positive when I first looked, but now I think it's not. Shouldn't it set default_display="none"? I think that there is some other logic burried that these machine doesn't get a graphics display. But overall it is indeed

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 17:22, Igor Mammedov wrote: > It also seems wrong to call _plug handler on maybe partially > initialized device so perhaps we should first finish devices/children > realization then do reset and only after that call _plug() handler I agree but this is too dangerous until we look at

[Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()

2018-07-11 Thread Laurent Vivier
The value given by mmap_find_vma_reserved() is used with mmap(), so it is needed to be aligned with the host page size. Since commit 18e80c55bb, reserved_va is only aligned to TARGET_PAGE_SIZE, and it works well if this size is greater or equal to the host page size. But ppc64 hosts have 64kB

[Qemu-devel] [PATCH] linux-user: fix mmap_find_vma_reserved()

2018-07-11 Thread Laurent Vivier
The value given by mmap_find_vma_reserved() is used with mmap(), so it is needed to be aligned with the host page size. Since commit 18e80c55bb, reserved_va is only aligned to TARGET_PAGE_SIZE, and it works well if this size is greater or equal to the host page size. But ppc64 hosts have 64kB

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 18:26, Viktor Prutyanov wrote: >> Where are the tools using this information, that need to be >> updated? Won't this break existing versions of those tools? >> >> Is the dump format and pointers to available tools documented >> somewhere? > I hope that someone from community knows

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Viktor Prutyanov
On Wed, 11 Jul 2018 13:00:25 -0300 Eduardo Habkost wrote: > On Tue, Jul 10, 2018 at 06:21:09PM +0300, Viktor Prutyanov wrote: > > This patch adds field with content of KERNEL_GS_BASE MSR to QEMU > > note in ELF dump. > > > > On Windows, if all vCPUs are running usermode tasks at the time the >

Re: [Qemu-devel] [PATCH v6 4/4] acpi: build TPM Physical Presence interface

2018-07-11 Thread Igor Mammedov
On Wed, 4 Jul 2018 18:00:41 +0200 Marc-André Lureau wrote: > HI > > On Wed, Jul 4, 2018 at 5:39 PM, Igor Mammedov wrote: > > On Thu, 28 Jun 2018 19:26:57 +0200 > > Marc-André Lureau wrote: > > > >> From: Stefan Berger > >> > >> The TPM Physical Presence interface consists of an ACPI part,

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2018-07-11 Thread Peter Maydell
As I said, I don't want to have to deal with image generation tools and extracting initrds from disk images. The easiest thing for me is if you can just provide all the files and the command line I can use to reproduce. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 18:00, Eduardo Habkost wrote: >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, >> CPUState *cs, >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of >> * QEMUCPUState, and modify the tools using this information accordingly. >

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 09:21:48AM +0200, Thomas Huth wrote: > On 10.07.2018 08:50, Peter Maydell wrote: > > On 9 July 2018 at 23:03, Thomas Huth wrote: > >> On 09.07.2018 23:42, Peter Maydell wrote: > >>> On 9 July 2018 at 22:03, Thomas Huth wrote: > When trying to "device_add bcm2837" on

Re: [Qemu-devel] [PATCH v2 2/2] memory: fix possible NULL pointer dereference

2018-07-11 Thread Dima Stepanov
On Wed, Jul 11, 2018 at 03:09:13PM +0100, Peter Maydell wrote: > On 11 July 2018 at 14:47, Philippe Mathieu-Daudé wrote: > > Hi Dima, > > > > On 07/11/2018 05:34 AM, Dima Stepanov wrote: > >> Gentle ping. CCing Paolo Bonzini. > >> > >> Regards, Dima. > >> > >> On Tue, Jun 19, 2018 at 05:12:16PM

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 06:21:09PM +0300, Viktor Prutyanov wrote: > This patch adds field with content of KERNEL_GS_BASE MSR to QEMU note in > ELF dump. > > On Windows, if all vCPUs are running usermode tasks at the time the dump is > created, this can be helpful in the discovery of guest system

Re: [Qemu-devel] [PATCH v2 2/2] memory: fix possible NULL pointer dereference

2018-07-11 Thread Dima Stepanov
Hi Phil, On Wed, Jul 11, 2018 at 10:47:18AM -0300, Philippe Mathieu-Daudé wrote: > Hi Dima, > > On 07/11/2018 05:34 AM, Dima Stepanov wrote: > > Gentle ping. CCing Paolo Bonzini. > > > > Regards, Dima. > > > > On Tue, Jun 19, 2018 at 05:12:16PM +0300, Dima Stepanov wrote: > >> Ping. > >> > >>

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 12:26:52AM +0200, Sebastian Bauer wrote: > Hi, > > Am 2018-07-09 23:23, schrieb Eduardo Habkost: > > List of machines with default_display==NULL on those > > architectures: > > > > alpha: > > none empty machine > > > > mips: > > mipssim MIPS

[Qemu-devel] [Bug 1781211] Re: HAXM acceleration does not work at all.

2018-07-11 Thread Dmitriy via Qemu-devel
After some time I decided it is haxm bug - so i created the same issue on haxm project too https://github.com/intel/haxm/issues/74 ** Bug watch added: github.com/intel/haxm/issues #74 https://github.com/intel/haxm/issues/74 -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 10:07:31AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > > Every time we create new PC machine-types in QEMU, the defaults > > for SMBIOS fields change unnecessarily because the version field > > defaults to

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:59, Stefan Hajnoczi wrote: >> +machine->obj.get_device = raspi2_get_device; >> +machine->obj.destructor = raspi2_destroy; >> +qos_create_sdhci_mm(>sdhci, 0x3f30, &(QSDHCIProperties) { >> +.version = 3, >> +.baseclock = 52, >> +.capab.sdma =

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:29AM +0200, Emanuele Giuseppe Esposito wrote: > This work is being done as Google Summer of Code 2018 project for QEMU, > my mentors are Paolo Bonzini and Laurent Vivier. > Additional infos on the project can be found at: >

Re: [Qemu-devel] [PATCH v2 4/4] tests: Add centos VM testing

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Fam, On 07/11/2018 11:18 AM, Fam Zheng wrote: > This one does docker testing in the VM. It is intended to replace the > native docker testing on patchew testers. > > Signed-off-by: Fam Zheng > --- > tests/vm/Makefile.include | 2 +- > tests/vm/centos | 84

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Igor Mammedov
On Tue, 10 Jul 2018 16:50:36 +0100 Stefan Hajnoczi wrote: > The ->pre_plug() callback is invoked before the device is realized. The > ->plug() callback is invoked when the device is being realized but > before it is reset. > > This patch adds a ->post_plug() callback which is invoked after

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2018-07-11 Thread M0Rf30
In order not to upload a big image I can say that you can generate the image with this tool https://github.com/M0Rf30/simonpi the initrd used is in the arch linux arm boot partition generated by the previous referenced tool. -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:49, Stefan Hajnoczi wrote: > On Mon, Jul 09, 2018 at 11:11:31AM +0200, Emanuele Giuseppe Esposito wrote: >> -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc) >> +static void *qpci_get_driver(void *obj, const char *interface) >> { >> -QPCIBusPC *ret =

Re: [Qemu-devel] [PATCH v2 2/4] tests/vm: Pass verbose flag into VM make commands

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 11:18 AM, Fam Zheng wrote: > Our Makefile has: > > vm-build-%: tests/vm/%.img > $(call quiet-command, \ > $(SRC_PATH)/tests/vm/$* \ > $(if $(V)$(DEBUG), --debug) \ > $(if $(DEBUG), --interactive) \ > > the intention of which is to let

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: > +/** > + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. > +qos_add_test("sdhci-test", "sdhci", test_machine);

Re: [Qemu-devel] [Qemu-arm] [PATCH 6/6] target/arm: Allow execution from small regions

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/10/2018 01:00 PM, Peter Maydell wrote: > Now that we have full support for small regions, including execution, > we can remove the workarounds where we marked all small regions as > non-executable for the M-profile MPU and SAU. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH 6/7] tests/qgraph: gtest integration

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:35AM +0200, Emanuele Giuseppe Esposito wrote: > Add main executable that takes care of starting the framework, create the > nodes, set the available drivers/machines, discover the path and run tests. This is elegant, I like it. > Signed-off-by: Emanuele Giuseppe

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:33AM +0200, Emanuele Giuseppe Esposito wrote: > Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so > its constructor must take care of setting it properly when called. > > Signed-off-by: Emanuele Giuseppe Esposito > --- >

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:28, Stefan Hajnoczi wrote: >> + * build_driver_cmd_line(): builds the command line for the driver >> + * @node. The node name must be a valid qemu identifier, since it >> + * will be used to build the command line. >> + * >> + * It is also possible to pass an optional @args that

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:31AM +0200, Emanuele Giuseppe Esposito wrote: > -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc) > +static void *qpci_get_driver(void *obj, const char *interface) > { > -QPCIBusPC *ret = g_new0(QPCIBusPC, 1); > +QPCIBusPC *qpci = obj; > +if

Re: [Qemu-devel] [PATCH] seccomp: allow sched_setscheduler() with SCHED_IDLE policy

2018-07-11 Thread Eduardo Otubo
On 10/07/2018 - 16:55:57, Marc-André Lureau wrote: > Current and upcoming mesa releases rely on a shader disk cash. It uses > a thread job queue with low priority, set with > sched_setscheduler(SCHED_IDLE). However, that syscall is rejected by > the "resourcecontrol" seccomp qemu filter. > >

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/6] accel/tcg: Return -1 for execution from MMIO regions in get_page_addr_code()

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/10/2018 01:00 PM, Peter Maydell wrote: > Now that all the callers can handle get_page_addr_code() returning -1, > remove all the code which tries to handle execution from MMIO regions > or small-MMU-region RAM areas. This will mean that we can correctly > execute from these areas, rather

Re: [Qemu-devel] [PATCH] docker: Install more packages in centos7

2018-07-11 Thread Fam Zheng
On Wed, 07/11 14:58, Fam Zheng wrote: > This makes test-block work. > > Signed-off-by: Fam Zheng Queued, thanks.

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:30AM +0200, Emanuele Giuseppe Esposito wrote: > +/* Graph Edge.*/ > +struct QOSGraphEdge { > +QOSEdgeType type; > +char *dest; > +char *arg; /* just for CONTAIS and CONSUMED_BY */ CONTAINS? > +/** > + * remove_node(): removes a node @val from the nodes

[Qemu-devel] [PATCH v2 4/4] tests: Add centos VM testing

2018-07-11 Thread Fam Zheng
This one does docker testing in the VM. It is intended to replace the native docker testing on patchew testers. Signed-off-by: Fam Zheng --- tests/vm/Makefile.include | 2 +- tests/vm/centos | 84 +++ 2 files changed, 85 insertions(+), 1

[Qemu-devel] [PATCH v2 2/4] tests/vm: Pass verbose flag into VM make commands

2018-07-11 Thread Fam Zheng
Our Makefile has: vm-build-%: tests/vm/%.img $(call quiet-command, \ $(SRC_PATH)/tests/vm/$* \ $(if $(V)$(DEBUG), --debug) \ $(if $(DEBUG), --interactive) \ the intention of which is to let the make command in VM have V=1 if V=1 is set. We

[Qemu-devel] [PATCH v2 3/4] tests: Allow overriding archive path with SRC_ARCHIVE

2018-07-11 Thread Fam Zheng
In VM based tests, the source archive is created in host, we don't have to run archive-source.sh again, as it complicates the Makefile and scripts. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/4] Add a CentOS test image to run docker tests

2018-07-11 Thread Fam Zheng
v2: Drop archive-source.sh changes. The new test depends on the iotests nbd fix I posted today to pass. Docker testing on patchew has long suffered from 'make check' hangings. The cleanness of VM testing is the cure. Now let's add a CentOS 7 image to run the tests. It's purely ad-hoc, but

[Qemu-devel] [PATCH v2 1/4] tests: Add an option for snapshot (default: off)

2018-07-11 Thread Fam Zheng
Not using snapshot has the benefit of automatically persisting useful test harnesses, such as docker images and ccache database. Although it will lose some cleanness, it is imaginably useful for patchew. Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 7 ++- 1 file changed, 6

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-11 Thread Emanuele
On 07/11/2018 04:00 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:29AM +0200, Emanuele Giuseppe Esposito wrote: Basic framework steps are the following: - All nodes and edges are created in their respective machine/driver/test files - The framework starts QEMU and asks for a list of

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Igor Mammedov
On Wed, 11 Jul 2018 15:32:12 +0200 Paolo Bonzini wrote: > On 11/07/2018 15:29, Stefan Hajnoczi wrote: > >> if (dev->hotplugged) { > >> device_reset(dev); > >> + > >> +if (hotplug_ctrl) { > > In the final patch I will move this out of if (dev->hotplugged) since

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

2018-07-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.07.2018 um 16:02 hat Marc-André Lureau geschrieben: >> Hi >> >> On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: >> > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: >> >> handle_qmp_command() reports JSON syntax errors right away. This is >> >> wrong

Re: [Qemu-devel] [PATCH v2 2/2] memory: fix possible NULL pointer dereference

2018-07-11 Thread Peter Maydell
On 11 July 2018 at 14:47, Philippe Mathieu-Daudé wrote: > Hi Dima, > > On 07/11/2018 05:34 AM, Dima Stepanov wrote: >> Gentle ping. CCing Paolo Bonzini. >> >> Regards, Dima. >> >> On Tue, Jun 19, 2018 at 05:12:16PM +0300, Dima Stepanov wrote: >>> Ping. >>> >>> Regards, Dima. >>> >>> On Wed, Jun

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/6] accel/tcg: Pass read access type through to io_readx()

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/10/2018 01:00 PM, Peter Maydell wrote: > The io_readx() function needs to know whether the load it is > doing is an MMU_DATA_LOAD or an MMU_INST_FETCH, so that it > can pass the right value to the cpu_transaction_failed() > function. Plumb this information through from the softmmu > code. >

Re: [Qemu-devel] [PATCH] docker: Install more packages in centos7

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 03:58 AM, Fam Zheng wrote: > This makes test-block work. > > Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/centos7.docker | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/docker/dockerfiles/centos7.docker >

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:29AM +0200, Emanuele Giuseppe Esposito wrote: > Basic framework steps are the following: > - All nodes and edges are created in their respective machine/driver/test > files > - The framework starts QEMU and asks for a list of available drivers > and machines QEMU

[Qemu-devel] [Bug 1781211] [NEW] HAXM acceleration does not work at all.

2018-07-11 Thread Dmitriy via Qemu-devel
Public bug reported: I have qemu windows build 2.12.90, haxm 7.2.0. Ubuntu, nor arch linux does not works when i turn on hax acceleration. Permanent kernel panics, black screen freezing and other crashes happens when i run qemu. Qemu crashed with hax - when i ran it from iso. It crashed on

Re: [Qemu-devel] [PATCH] fix gdbserver_state pointer validation

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Stephane, On 07/11/2018 04:52 AM, stephane duverger wrote: > To reach gdb_set_stop_cpu() with gdbserver_state == NULL, you previously >> entered gdb_vm_state_change() with and use CPUState *cpu = >> gdbserver_state->c_cpu = NULL deref, which shouldn't happen. >> Also in gdb_set_stop_cpu() you

[Qemu-devel] [Bug 1719339] Re: serial8250: too much work for irq3

2018-07-11 Thread Paul Gear
** Tags added: canonical-is -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719339 Title: serial8250: too much work for irq3 Status in QEMU: New Bug description: It's know issue and sometimes

[Qemu-devel] [Bug 1719339] Re: serial8250: too much work for irq3

2018-07-11 Thread Paul Gear
I'm seeing this on AWS EC2 when there's (apparently) high logging volume to the console, very similarly to https://www.reddit.com/r/sysadmin/comments/6zuqad/mongodb_aws_ec2_serial8250_too_much_work_for_irq4/ -- You received this bug notification because you are a member of qemu- devel-ml, which

  1   2   >