[Qemu-devel] [PULL 2/3] .gitignore: ignore docs/built created for in-tree builds

2019-03-14 Thread Laurent Vivier
From: Stefano Garzarella Commit 1290e6711 creates 'docs/built' for in-tree builds of Sphinx manuals but did not ignore it. Signed-off-by: Stefano Garzarella Reviewed-by: Eric Blake Message-Id: <20190314104622.101715-2-sgarz...@redhat.com> Signed-off-by: Laurent Vivier --- .gitignore | 1 + 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-4.0 0/2] Update .gitignore and tests/.gitignore for in-tree builds

2019-03-14 Thread Laurent Vivier
On 14/03/2019 13:27, Eric Blake wrote: On 3/14/19 5:46 AM, Stefano Garzarella wrote: This series could be useless when we will no longer support in-tree builds, but for 4.0 I think it's useful to ignore these files. series: Reviewed-by: Eric Blake Stefano Garzarella (2): .gitignore: ign

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-4.0] maint: Ignore built elf2dmp

2019-03-14 Thread Laurent Vivier
On 13/03/2019 15:45, Eric Blake wrote: Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it during an in-tree build. Signed-off-by: Eric Blake --- Yes, I know we want to get rid of in-tree builds for 4.1; but for 4.0, this patch may still make sense. .gitignore | 1 + 1 file chan

Re: [Qemu-devel] [PATCH v13 19/25] replay: add BH oneshot event for block layer

2019-03-14 Thread Kevin Wolf
Am 13.03.2019 um 06:57 hat Pavel Dovgalyuk geschrieben: > Kevin, what about this one? I made some benchmark on my system, too, and included some cases with your series. I agree that there is no significant difference, so that's fine. Kevin > > -Original Message- > > From: Pavel Dovgalyuk

Re: [Qemu-devel] [RFC] arm/cpu: fix soft lockup panic after resuming from stop

2019-03-14 Thread Heyi Guo
Hi Peter and Steven, On 2019/3/13 18:11, Steven Price wrote: On 12/03/2019 14:12, Marc Zyngier wrote: Hi Peter, On 12/03/2019 10:08, Peter Maydell wrote: On Tue, 12 Mar 2019 at 06:10, Heyi Guo wrote: When we stop a VM for more than 30 seconds and then resume it, by qemu monitor command "st

Re: [Qemu-devel] [PATCH v5 2/2] Add Nios II semihosting support.

2019-03-14 Thread Peter Maydell
On Wed, 13 Feb 2019 at 04:02, Sandra Loosemore wrote: > > This patch adds support for libgloss semihosting to Nios II bare-metal > emulation. > > Signed-off-by: Sandra Loosemore > Signed-off-by: Julian Brown Hi; here are some more detailed code review comments based on your spec document. They'

Re: [Qemu-devel] [libvirt] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-14 Thread Igor Mammedov
On Sun, 10 Mar 2019 11:16:33 +0100 Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Mar 06, 2019 at 08:03:48PM +0100, Igor Mammedov wrote: > >> On Mon, 4 Mar 2019 16:35:16 + > >> Daniel P. Berrangé wrote: > >> > >> > On Mon, Mar 04, 2019 at 05:20:13PM +0100, Michal

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-03-14 Thread Jason Wang
On 2019/2/25 下午8:33, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at 03:47:48PM +0800, Jason Wang wrote: On 2019/2/22 下午12:22, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 10:10:08PM -0500, Michael S. Tsirkin wrote: On Fri, Feb 22, 2019 at 11:04:05AM +0800, Jason Wang wrote: On 2019/

[Qemu-devel] [PATCH V2 0/3] Fixes for PulseAudio driver

2019-03-14 Thread Martin Schrodt
Version 2 of the series, adds proper commit messages and fixes a typo. Martin Schrodt (3): audio/paaudio: fix ignored buffer_length setting audio/paaudio: prolong and make latency configurable audio/paaudio: fix microphone input being unusable audio/paaudio.c | 45

[Qemu-devel] [PATCH V2 2/3] audio/paaudio: prolong and make latency configurable

2019-03-14 Thread Martin Schrodt
The latency of a connection to the PulseAudio server is determined by the tlength parameter. This was hardcoded to 10ms, which is a bit too tight on my machine, causing audio on host and guest to malfunction. A setting of 15ms works fine here. To allow tweaking, I also made the setting configura

[Qemu-devel] [PATCH V2 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-14 Thread Martin Schrodt
Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 21 ++--- 1 file changed, 18 insertions(+),

[Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

2019-03-14 Thread Paolo Bonzini
RISC-V targets did not include PCIe ports before the Kconfig transition, and grew them afterwards, but they are nonfunctional because the interrupt controller does not support MSI. This patch restores the situation prior to the introduction of Kconfig; in fact, it will automatically drop devices t

[Qemu-devel] [PATCH V2 3/3] audio/paaudio: fix microphone input being unusable

2019-03-14 Thread Martin Schrodt
The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin S

[Qemu-devel] [PATCH 1/2] kconfig: add CONFIG_MSI

2019-03-14 Thread Paolo Bonzini
Not all interrupt controllers support message-signalled interrupts, and some devices *only* support message-signalled interrupts. In QEMU this is represented by the "msi_nonbroken" variable. This patch adds a new configuration symbol enabled whenever the binary contains an interrupt controller th

Re: [Qemu-devel] [Qemu-block] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

2019-03-14 Thread Kevin Wolf
Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/qobject.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir hw/block --in-place > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] vmdk: Support version=3 in VMDK descriptor files

2019-03-14 Thread Kevin Wolf
Am 14.03.2019 um 15:14 hat Sam Eiderman geschrieben: > Commit 509d39aa22909c0ed1aabf896865f19c81fb38a1 added support for read > only VMDKs of version 3. > > This commit fixes the probe function to correctly handle descriptors of > version 3. > > This commit has two effects: > 1. We no longer

[Qemu-devel] [PATCH 2/2] kconfig: add dependencies on CONFIG_MSI

2019-03-14 Thread Paolo Bonzini
For devices that require msi_init/msix_init to succeed, add a dependency on CONFIG_MSI. This will prevent those devices from appearing in a binary that cannot instantiate them. Signed-off-by: Paolo Bonzini --- Kconfig.host | 3 +++ Makefile | 3 ++- hw/Kconfig|

[Qemu-devel] [PATCH] vmdk: Support version=3 in VMDK descriptor files

2019-03-14 Thread Sam Eiderman
Commit 509d39aa22909c0ed1aabf896865f19c81fb38a1 added support for read only VMDKs of version 3. This commit fixes the probe function to correctly handle descriptors of version 3. This commit has two effects: 1. We no longer need to supply '-f vmdk' when pointing to descriptor files of

Re: [Qemu-devel] [PATCH 2/6] xen: Move xenstore initialization to common location

2019-03-14 Thread Paul Durrant
> -Original Message- > From: Jason Andryuk [mailto:jandr...@gmail.com] > Sent: 13 March 2019 18:12 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; > marma...@invisiblethingslab.com; Stefano > Stabellini ; Anthony Perard > ; Paolo Bonzini > ; Richard Hender

Re: [Qemu-devel] [PATCH v2 12/12] MAINTAINERS: add the "EDK2 Firmware" subsystem

2019-03-14 Thread Michal Privoznik
On 3/13/19 10:00 PM, Laszlo Ersek wrote: We now have the edk2 submodule, somewhat elaborate build helpers for it, and even a UEFI application written against edk2 whose genuine home is the QEMU repository. Add the "EDK2 Firmware" subsystem such that all relevant pathnames be covered. Suggested-b

Re: [Qemu-devel] [PULL 0/5] gitdm updates for 4.0

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 19:34, Alex Bennée wrote: > > The following changes since commit 2cb73afa6a2408b397a5af1427d120b8aa04997a: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-03-12 > 15:25:46 +) > > are available in the Git reposit

Re: [Qemu-devel] [PATCH 3/3] fix input lag

2019-03-14 Thread Eric Blake
On 3/14/19 8:38 AM, Martin Schrodt wrote: > Signed-off-by: Martin Schrodt Again, the commit message body needs to give details, such as your cover letter mentioning that without this patch that the default was a 30 second lag. Especially since reading this patch alone does not provide any clue a

Re: [Qemu-devel] [PATCH v2 11/12] Makefile: install the edk2 firmware images and their descriptors

2019-03-14 Thread Michal Privoznik
On 3/13/19 10:00 PM, Laszlo Ersek wrote: Decompress and install the edk2 firmware blobs as part of "make install", unless blob installation was disabled with configure's "--disable-blobs" option. Additionally, decompress the blobs as a pre-requisite for building softmmu binaries -- this is helpf

Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-14 Thread Eric Blake
On 3/14/19 8:38 AM, Martin Schrodt wrote: > Signed-off-by: Martin Schrodt The subject line says "what" (good) but doesn't state everything the patch is doing (you are not only making it configurable, but you are changing the default). The commit body should say "why" (missing), and mention all t

Re: [Qemu-devel] [PATCH v2 10/12] tests: add missing dependency to build QTEST_QEMU_BINARY, round 2

2019-03-14 Thread Michal Privoznik
On 3/13/19 10:00 PM, Laszlo Ersek wrote: In commit b94b330e2333 ("tests: add missing dependency to build QTEST_QEMU_BINARY", 2017-07-31), Phil fixed the dependency list of make target "check-qtest-%". Namely, the recipe would set QTEST_QEMU_BINARY to the softmmu emulator for the emulation target,

Re: [Qemu-devel] [PATCH v2 07/12] roms: build edk2 firmware binaries and variable store templates

2019-03-14 Thread Michal Privoznik
On 3/13/19 10:00 PM, Laszlo Ersek wrote: Add the "efi" target to "Makefile". Introduce "Makefile.edk2" for building and cleaning the firmware images and varstore templates. Collect the common bits from the recipes in the helper script "edk2-build.sh". Signed-off-by: Laszlo Ersek --- Notes:

Re: [Qemu-devel] [PATCH v2 08/12] pc-bios: add edk2 firmware binaries and variable store templates

2019-03-14 Thread Michal Privoznik
On 3/13/19 10:00 PM, Laszlo Ersek wrote: Add the files built by the last patch: (compressed) binaries, and the cumulative license text that covers them. Signed-off-by: Laszlo Ersek --- Notes: v2: - capture the compressed build outputs of the last patch; slightly update

Re: [Qemu-devel] [PATCH v3 7/8] slirp: remove reference to COPYRIGHT file

2019-03-14 Thread Eric Blake
On 3/14/19 8:10 AM, Marc-André Lureau wrote: > The slirp COPYRIGHT file is a BSD-3 license. Instead of referring to > another project file, the SPDX license notice present in all source > files states that unequivocally. > > Signed-off-by: Marc-André Lureau > --- Perhaps parts could be squashed

[Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 18 +++--- qapi/audio.json | 5 - 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 1a799ca3e7..c9007fdb01 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -500,16 +500

Re: [Qemu-devel] [PATCH v3 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License

2019-03-14 Thread Eric Blake
On 3/14/19 8:10 AM, Marc-André Lureau wrote: > According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove > the advertising clause from the slirp license"), Danny Gasparovski > gave permission to license slirp code under 3-clause BSD license: > > Subject: RE: Slirp license > Dat

[Qemu-devel] [PATCH 3/3] fix input lag

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index c9007fdb01..e4370c3113 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -600,6 +600,7 @@ static int qpa_init_in(HWVoiceIn *hw,

[Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 5d410ed73f..1a799ca3e7 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -577,7 +577,7 @@ static int qpa_init_ou

Re: [Qemu-devel] [PULL 00/26] final testing updates for 4.0

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 17:09, Alex Bennée wrote: > > The following changes since commit 46316f1dfffc6be72e94e89f7b0e9162e7dcdcf1: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-updates-20190311.0' into staging (2019-03-12 > 13:37:29 +) > > are available in the Git repositor

Re: [Qemu-devel] [PATCH V3] target/arm: change arch timer registers access permission

2019-03-14 Thread Peter Maydell
On Wed, 13 Mar 2019 at 02:42, gengdongjiu wrote: > > Add "Reviewed-by" from Richard because Richard has reviewed it in patch > v2[1], thanks. > > Reviewed-by: Richard Henderson > > [1]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg604509.html > > On 2019/3/12 20:52, Dongjiu Geng wrote:

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-14 Thread Eric Blake
On 3/14/19 8:19 AM, Samuel Thibault wrote: > Hello, > > Should this go through my tree, or perhaps it can be directly pushed to > master by Peter since it's no-code-only-copyright changes? I think this definitely qualifies as 4.0 material. However, while it does not affect compilation, it DOES h

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 07:51, Wei Yang wrote: > > This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number. > > Signed-off-by: Wei Yang > --- > hw/arm/virt-acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt

[Qemu-devel] [PATCH 0/3] Fixes for PulseAudio driver

2019-03-14 Thread Martin Schrodt
This series scratches small itches with the pa audio driver. First patch is probably a bug introduced in last weeks -audiodev merge. The configured buffer length was ignored by the code, and a constant value was used instead. Second patch makes the latency configurable: The 10ms constant value di

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-14 Thread Eric Blake
On 3/14/19 8:10 AM, Marc-André Lureau wrote: > Hi, > > In order to make slirp a standalone project, the project must have a > clear license, and be compatible with the GPL or LGPL. > > Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the > advertising clause from the slirp license")

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Paolo Bonzini
On 14/03/19 14:00, Michael S. Tsirkin wrote: >> >> I haven't spent time digging further - and I'm not familiar enough >> with the QEMU build system anyway O:-) - but I wouldn't be surprised >> if the same happened for other architectures, too. > I'd say just disable it at build time by default. > H

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread David Abdurachmanov
On Thu, Mar 14, 2019 at 2:00 PM Michael S. Tsirkin wrote: > > On Thu, Mar 14, 2019 at 01:53:48PM +0100, Andrea Bolognani wrote: > > On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > > > Instead of including the same list of devices for each target, > > > set CONFIG_PCI to true, and make th

Re: [Qemu-devel] [PULL 0/4] ASAN/UBSAN fixes

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 14:38, Paolo Bonzini wrote: > > The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-03-11 18:26:37 +) > > are available in the Git repository at: > > g

[Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-14 Thread Marc-André Lureau
Hi, In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 01:53:48PM +0100, Andrea Bolognani wrote: > On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > > Instead of including the same list of devices for each target, > > set CONFIG_PCI to true, and make the devices default to present > > whenever PCI is available. However,

[Qemu-devel] [PATCH v3 5/8] slirp: clarify license of slirp files using SPDX

2019-03-14 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with reference to BSD license from slirp COPYRIGHT file. Signed-off-by: Marc-André Lureau --- slirp/src/debug.h | 1 + slirp/src/if.h | 1 + slirp/src/main.h | 1 + slirp/src/misc.h | 1 + slirp/src/sbuf.h | 1 + slirp/src/so

[Qemu-devel] [PATCH v3 2/8] slirp: relicense GPL files to BSD-3

2019-03-14 Thread Marc-André Lureau
In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp/ wit

[Qemu-devel] [PATCH v3 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License

2019-03-14 Thread Marc-André Lureau
According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), Danny Gasparovski gave permission to license slirp code under 3-clause BSD license: Subject: RE: Slirp license Date: Thu, 8 Jan 2009 10:51:00 +1100 From: "Gasparovski,

[Qemu-devel] [PATCH v3 3/8] slirp: clarify license of slirp files using SPDX

2019-03-14 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit 3-clause BSD license header. Signed-off-by: Marc-André Lureau --- slirp/src/dhcpv6.h | 1 + slirp/src/ip.h | 1 + slirp/src/ip_icmp.h| 1 + slirp/src/mbuf.h | 1 + slirp/src/ncsi-pkt.h | 1 + slirp/

[Qemu-devel] [PATCH v3 4/8] slirp: clarify license of slirp files using SPDX

2019-03-14 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit MIT license header. Signed-off-by: Marc-André Lureau --- slirp/src/util.h | 1 + slirp/src/arp_table.c | 1 + slirp/src/bootp.c | 1 + slirp/src/dnssearch.c | 1 + slirp/src/slirp.c | 1 + slirp/src/state.c

[Qemu-devel] [PATCH v3 6/8] slirp: clarify license of slirp files using SPDX

2019-03-14 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files without explicit license header. Signed-off-by: Marc-André Lureau --- slirp/src/bootp.h | 1 + slirp/src/ip6.h| 1 + slirp/src/ip6_icmp.h | 1 + slirp/src/libslirp.h | 1 + slirp/src/slirp.h | 1 + slirp/src/stream

[Qemu-devel] [PATCH v3 8/8] slirp: is not maintained by Kelly Price for a long time

2019-03-14 Thread Marc-André Lureau
slirp has been maintained by the QEMU maintainers and will be maintained under an independent project soon. Reviewed-by: Eric Blake Signed-off-by: Kelly Price Signed-off-by: Marc-André Lureau --- slirp/COPYRIGHT | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/COPYRIGHT b/slirp/COPYR

[Qemu-devel] [PATCH v3 7/8] slirp: remove reference to COPYRIGHT file

2019-03-14 Thread Marc-André Lureau
The slirp COPYRIGHT file is a BSD-3 license. Instead of referring to another project file, the SPDX license notice present in all source files states that unequivocally. Signed-off-by: Marc-André Lureau --- slirp/src/debug.h | 3 --- slirp/src/if.h | 3 --- slirp/src/main.h |

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix SMMUv3 GSIV values

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 09:10, Eric Auger wrote: > > The GSIV numbers of the SPI based interrupts is not correct as > ARM_SPI_BASE was not added to the irqmap[VIRT_SMMU] value. So > this may collide with VIRTIO_MMIO irq window. > > Signed-off-by: Eric Auger > --- > hw/arm/virt-acpi-build.c | 2 +-

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Paolo Bonzini
On 14/03/19 13:53, Andrea Bolognani wrote: > > $ ./riscv64-softmmu/qemu-system-riscv64 \ > -M virt \ > -device pcie-root-port > qemu-system-riscv64: -device pcie-root-port: MSI-X is not >supported by interrupt controller > > This is a limitation we have been aw

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-14 Thread Samuel Thibault
Hello, Should this go through my tree, or perhaps it can be directly pushed to master by Peter since it's no-code-only-copyright changes? Samuel Marc-André Lureau, le jeu. 14 mars 2019 14:10:41 +0100, a ecrit: > In order to make slirp a standalone project, the project must have a > clear license

Re: [Qemu-devel] Several questions about " [PATCH v3 0/5] virtio-9p: hotplug and migration support"

2019-03-14 Thread wangyan
On 2019/3/11 17:33, Greg Kurz wrote: > On Tue, 5 Mar 2019 19:28:37 +0800 > wangyan wrote: > >> I am very happy for your reply. >> >> I am very interested in your old WIP and want to take a look. >> >> Our project still use 9pfs, and it needs to live migrate the >> device while it is being used

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Andrea Bolognani
On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > Instead of including the same list of devices for each target, > set CONFIG_PCI to true, and make the devices default to present > whenever PCI is available. However, s390x does not want all the > PCI devices, so there is a separate symbol

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Christian Svensson via Qemu-devel
Hi all, I have a new patch but I'm not sure how you want me to post it. Should I do a "PATCH v2" with a single patch and this thread as the thread ID? Thanks, - Chris On Thu, Mar 14, 2019 at 10:05 AM Cédric Le Goater wrote: > Christian, > > Could you please provide a fix for this patch ? patc

Re: [Qemu-devel] [PATCH 0/5] aspeed/timer: Fix slowdowns in recent Linux

2019-03-14 Thread Christian Svensson via Qemu-devel
Hi, My apologies, I don't know how I missed those warnings. I'll create a new patch. - Chris On Thu, Mar 14, 2019 at 10:06 AM Cédric Le Goater wrote: > Hello, > > For the time being, we can drop patch 5 from this series. > > Thanks, > > C. > > On 3/14/19 9:59 AM, no-re...@patchew.org wrote: >

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Christian Svensson via Qemu-devel
Thanks for the feedback, On Thu, Mar 14, 2019, 11:57 Peter Maydell wrote: > But overall I'm a little sceptical that the aspeed timer is > really a special case that needs a signed version of this > when no other timer in the system does... I agree, and the v2 of the patch doesn't require it. H

Re: [Qemu-devel] [PATCH RFC] seccomp: don't kill process for resource control syscalls

2019-03-14 Thread Mathias Fröhlich
Hi, Thanks for not just killing processes anymore! See the mesa thread https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg214474.html for some background. Thanks a lot and best Mathias On Wednesday, 13 March 2019 10:49:03 CET Daniel P. Berrangé wrote: > The Mesa library tries to set

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread gengdongjiu
On 2019/3/14 20:43, Peter Maydell wrote: >> If you think this patch will introduce some issue, we can add one function >> write_part_cpustate_to_list()[2] to change the specified >> register instead of all the registers[1]. > It definitely does introduce an issue, but we need to address > it by wo

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 12:24, gengdongjiu wrote: > > If you think this patch will introduce some issue, we can add one function > write_part_cpustate_to_list()[2] to change the specified > register instead of all the registers[1]. It definitely does introduce an issue, but we need to address it

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 12:16:06PM +, Peter Maydell wrote: > On Thu, 14 Mar 2019 at 11:23, Paolo Bonzini wrote: > > > > On 14/03/19 11:51, Peter Maydell wrote: > > > Our coverity model of g_strdup() includes: > > > __coverity_string_size_sink__(s); > > > > > > This seems to be causing Coveri

Re: [Qemu-devel] [PATCH] block/io: fix bdrv_co_do_copy_on_readv error handling

2019-03-14 Thread Vladimir Sementsov-Ogievskiy
14.03.2019 13:14, Vladimir Sementsov-Ogievskiy wrote: > It's not safe to treat bdrv_is_allocated error as unallocated: if we > mistake we may rewrite guest data. ... with same data, which is not so bad. So, it's ok, I'm wrong, drop it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Yury Kotov
Hi, 14.03.2019, 14:44, "Daniel P. Berrangé" : > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: >>  On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: >>  > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: >>  > > On Thu, Feb 28, 2019 at 04:5

Re: [Qemu-devel] [PATCH for-4.0 0/2] Update .gitignore and tests/.gitignore for in-tree builds

2019-03-14 Thread Eric Blake
On 3/14/19 5:46 AM, Stefano Garzarella wrote: > This series could be useless when we will no longer support in-tree builds, > but for 4.0 I think it's useful to ignore these files. series: Reviewed-by: Eric Blake > > Stefano Garzarella (2): > .gitignore: ignore docs/built created for in-tree

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Paolo Bonzini
On 14/03/19 13:16, Peter Maydell wrote: > Mmm, that makes sense. So in this particular case, do we > want to try to avoid doing an unbounded allocation based > on whatever rubbish the user passed us in the environment, > or do we say "this particular case is OK" and mark it > as a false-positive ?

Re: [Qemu-devel] [PULL 03/28] qapi: move to QOM path for x-block-latency-histogram-set

2019-03-14 Thread Kevin Wolf
Am 14.03.2019 um 09:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > 12.03.2019 20:30, Kevin Wolf wrote: > > From: Vladimir Sementsov-Ogievskiy > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Kevin Wolf > > Not critical, but it is v4, when in v5 description and example

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread gengdongjiu
If you think this patch will introduce some issue, we can add one function write_part_cpustate_to_list()[2] to change the specified register instead of all the registers[1]. Below function that you added will modified all the register if new value is different with old value. [1]: bool write_cpu

Re: [Qemu-devel] [PATCH] qapi: fix block-latency-histogram-set description and examples

2019-03-14 Thread Kevin Wolf
Am 14.03.2019 um 09:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > There no @device parameter, only the @id one. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH for-4.0] qapi: fix block-latency-histogram-set description and examples

2019-03-14 Thread Eric Blake
On 3/14/19 3:52 AM, Vladimir Sementsov-Ogievskiy wrote: > There no @device parameter, only the @id one. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Documentation fixes are appropriate during free

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 11:23, Paolo Bonzini wrote: > > On 14/03/19 11:51, Peter Maydell wrote: > > Our coverity model of g_strdup() includes: > > __coverity_string_size_sink__(s); > > > > This seems to be causing Coverity to report false positives like > > CID1399705 and 1399699 where we take a

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 11:43:26AM +, Daniel P. Berrangé wrote: > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > > > On Thu,

Re: [Qemu-devel] [PATCH v2 2/2] virtio-gpu: clear command and fence queues on reset

2019-03-14 Thread Marc-André Lureau
Hi On Thu, Mar 14, 2019 at 12:54 PM Gerd Hoffmann wrote: > > It was never correct to not clear them. Due to commit "3912e66a3feb > virtio-vga: fix reset." this became more obvious though. The virtio > rings get properly reset now, and trying to process the stale commands > will trigger an asser

Re: [Qemu-devel] [build-error] possible build error at the tip of the trunk? (dtc-related?)

2019-03-14 Thread Peter Maydell
On Mon, 11 Mar 2019 at 16:59, Aleksandar Markovic wrote: > > Hello, all > > All of the sudden, the latest code doesn't build on my host: (the code from > several days ago builds fine) > > Do you know what would be the culprit? Is it my environment, or a genuine > build error? Hi -- we've now co

Re: [Qemu-devel] [PULL 00/10] Migration patches

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 11:48, Peter Maydell wrote: > > On Wed, 13 Mar 2019 at 12:14, Juan Quintela wrote: > > > > The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: > > > > Merge remote-tracking branch > > 'remotes/huth-gitlab/tags/pull-request-2019-03-12' into stagin

Re: [Qemu-devel] [PATCH v2] hw/acpi: extract acpi_add_rom_blob()

2019-03-14 Thread Wei Yang
On Thu, Mar 14, 2019 at 10:25:14AM +0100, Igor Mammedov wrote: >On Thu, 14 Mar 2019 15:38:36 +0800 >Wei Yang wrote: > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch extract acpi_add_rom_blob() to aml-build.c by

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu: clear command queue on reset

2019-03-14 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 12:01:27PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Mar 14, 2019 at 7:17 AM Gerd Hoffmann wrote: > > > > It was never correct to not clear them. Due to commit "3912e66a3feb > > virtio-vga: fix reset." this became more obvious though. The virtio > > rings get prop

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-14 Thread Wei Yang
On Thu, Mar 14, 2019 at 10:18:30AM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 21:31:37 + >Wei Yang wrote: > >> On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >> >On Wed, 13 Mar 2019 13:33:59 + >> >Wei Yang wrote: >> > >> >> On Wed, Mar 13, 2019 at 01:23:00PM +0100,

[Qemu-devel] [PATCH v2 0/2] virtio-gpu: more reset fixes.

2019-03-14 Thread Gerd Hoffmann
Gerd Hoffmann (2): virtio-gpu: delay virglrenderer reset when blocked. virtio-gpu: clear command and fence queues on reset include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu.c| 26 +- 2 files changed, 26 insertions(+), 1 deletion(-) -- 2.18.1

[Qemu-devel] [PATCH v2 2/2] virtio-gpu: clear command and fence queues on reset

2019-03-14 Thread Gerd Hoffmann
It was never correct to not clear them. Due to commit "3912e66a3feb virtio-vga: fix reset." this became more obvious though. The virtio rings get properly reset now, and trying to process the stale commands will trigger an assert in the virtio core. Signed-off-by: Gerd Hoffmann --- hw/display/

[Qemu-devel] [PATCH v2 1/2] virtio-gpu: delay virglrenderer reset when blocked.

2019-03-14 Thread Gerd Hoffmann
If renderer_blocked is set do not call virtio_gpu_virgl_reset(). Instead set a flag indicating that virglrenderer needs a reset. When renderer_blocked gets cleared do the actual reset call. Without this we can trigger an assert in spice due to calling spice_qxl_gl_scanout() while another operation

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 11:31, gengdongjiu wrote: > > Hi Peter/Eric, >I think we should fix the regression issue instead of revert this patch, > I think the reason of >this issue is that QEMU modified some unexpected resisters, we should find > out. Yes, I agree that we need to actua

Re: [Qemu-devel] [PULL 00/10] Migration patches

2019-03-14 Thread Peter Maydell
On Wed, 13 Mar 2019 at 12:14, Juan Quintela wrote: > > The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-03-12' into staging (2019-03-12 > 21:06:26 +) > > are available in the Git repo

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > > From: X

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > > > Since we now support the message VHOST_USER_GET_INFL

Re: [Qemu-devel] [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support

2019-03-14 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 11 March 2019 20:24 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com; se

[Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread gengdongjiu
Hi Peter/Eric, I think we should fix the regression issue instead of revert this patch, I think the reason of this issue is that QEMU modified some unexpected resisters, we should find out. Revert "arm: Allow system registers for KVM guests to be changed by QEMU code" This r

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

2019-03-14 Thread Michael S. Tsirkin
On Wed, Mar 13, 2019 at 03:27:27PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Mar 13, 2019 at 3:16 PM Michael S. Tsirkin wrote: > > > > On Tue, Mar 12, 2019 at 09:19:01PM +0100, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Mar 12, 2019 at 4:49 PM Michael S. Tsirkin > > > wrote: >

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart > >

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Paolo Bonzini
On 14/03/19 11:51, Peter Maydell wrote: > Our coverity model of g_strdup() includes: > __coverity_string_size_sink__(s); > > This seems to be causing Coverity to report false positives like > CID1399705 and 1399699 where we take a string from getenv() and > pass it to g_strdup() The getenv() str

Re: [Qemu-devel] [PATCH v3 0/5] Add ignore-external migration capability

2019-03-14 Thread Юрий Котов
Hi, I've sent a mail about this problem: [RFC PATCH] QEMU may write to system_memory before guest starts Regards, Yury 06.03.2019, 13:47, "Yury Kotov" : > 05.03.2019, 21:06, "Dr. David Alan Gilbert" : >>  * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >>>   * Yury Kotov (yury-ko...@yandex

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu: clear command queue on reset

2019-03-14 Thread Marc-André Lureau
Hi On Thu, Mar 14, 2019 at 7:17 AM Gerd Hoffmann wrote: > > It was never correct to not clear them. Due to commit "3912e66a3feb > virtio-vga: fix reset." this became more obvious though. The virtio > rings get properly reset now, and trying to process the stale commands > will trigger an assert

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Wed, Mar 13, 2019 at 10:47:08AM +0800, Yongji Xie wrote: > On Wed, 13 Mar 2019 at 09:16, Michael S. Tsirkin wrote: > > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > > an

[Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-14 Thread Yury Kotov
This patch isn't intended to merge. Just to reproduce a problem. The test for x-ignore-shread capability fails on aarch64 + tcg: Memory content inconsistency at 44c0 first_byte = 2 last_byte = 1 current = d1 hit_edge = 1 Memory content inconsistency at 44c01000 first_byte = 2 last_byte = 1 cu

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Wed, Mar 13, 2019 at 10:05:51AM +0800, Yongji Xie wrote: > On Wed, 13 Mar 2019 at 00:49, Michael S. Tsirkin wrote: > > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > > an

Re: [Qemu-devel] Seccomp profile for swtpm as default

2019-03-14 Thread Stefan Berger
On 3/14/19 5:59 AM, Daniel P. Berrangé wrote: On Wed, Mar 13, 2019 at 03:43:13PM -0400, Stefan Berger wrote: Hello!  If you have some feedback regarding a seccomp profile extension for swtpm for v0.2, please let me know. I created this github issue here: https://github.com/stefanberger/swtpm

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 08:43, Cédric Le Goater wrote: > > From: Christian Svensson > > If the host decrements the counter register that results in a negative > delta. This is then passed to muldiv64 which only handles unsigned > numbers resulting in bogus results. > > This fix ensures the data be

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Cédric Le Goater
On 3/14/19 11:47 AM, Christian Svensson wrote: > Hi all, > > I have a new patch but I'm not sure how you want me to post it. > Should I do a "PATCH v2" with a single patch and this thread as the thread ID? I would wait for feedback from Peter first. Thanks, C. > Thanks, > - Chris > > > On

Re: [Qemu-devel] [PATCH 7/7] coroutine-x86: add CET shadow stack support

2019-03-14 Thread Paolo Bonzini
On 14/03/19 01:04, Richard Henderson wrote: > On 3/13/19 5:40 AM, Paolo Bonzini wrote: >> +static bool have_cet(void) >> +{ >> +#if defined CONFIG_CET >> +uint64_t ssp; >> +asm ("xor %0, %0; rdsspq %0\n" : "=rm" (ssp)); > > The xor is incompatible with a memory output. > I don't think you

<    1   2   3   4   >