Re: [PATCH v2 1/2] qemu-img: Add --target-is-zero to convert

Eric Blake writes: > On 1/24/20 4:34 AM, David Edmondson wrote: >> In many cases the target of a convert operation is a newly provisioned >> target that the user knows is blank (filled with zeroes). In this >> situation there is no requirement for qemu-img to wastefully zero out >> the entire

Re: [PATCH v2 2/2] doc: Use @code rather than @var for options

Eric Blake writes: > On 1/24/20 4:34 AM, David Edmondson wrote: >> Texinfo defines @var for metasyntactic variables and such terms are >> shown in upper-case or italics in the output of makeinfo. When >> considering an option to a command, such as "-n", upper-casing is >> undesirable as it may

[Bug 1856837] Re: qemu 4.2.0 arm segmentation fault with gcc 9.2

Thanks, this helps a lot! We will now check the code again and see what causes the behaviour. Fabian -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856837 Title: qemu 4.2.0 arm segmentation

Re: [PATCH v4 0/7] hw/arm/raspi: Run U-Boot on the raspi machines

Hi Peter, (Cc'ed Wainer from the Python part). On 1/21/20 12:51 AM, Philippe Mathieu-Daudé wrote: Following Laurent report: https://www.mail-archive.com/qemu-devel@nongnu.org/msg639950.html The SYS_timer is already merged, see: https://git.qemu.org/?p=qemu.git;a=commit;h=d05be883fc

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

[including more folks into the discussion] On Fri, 17 Jan 2020 at 14:00, Peter Maydell wrote: On Thu, 19 Dec 2019 at 04:06, Gavin Shan wrote: This supports NMI injection for virtual machine and currently it's only supported on GICv3 controller, which is emulated by qemu or host kernel. The

[PATCH v2 1/3] Fixed assert in vhost_user_set_mem_table_postcopy

The current vhost_user_set_mem_table_postcopy() implementation populates each region of the VHOST_USER_SET_MEM_TABLE message without first checking if there are more than VHOST_MEMORY_MAX_NREGIONS already populated. This can cause memory corruption if too many regions are added to the message

[PATCH v2 2/3] Refactor vhost_user_set_mem_table functions

vhost_user_set_mem_table() and vhost_user_set_mem_table_postcopy() have gotten convoluted, and have some identical code. This change moves the logic populating the VhostUserMemory struct and fds array from vhost_user_set_mem_table() and vhost_user_set_mem_table_postcopy() to a new function,

[PATCH v2 0/3] vhost-user: Lift Max Ram Slots Limitation

In QEMU today, a VM with a vhost-user device can hot add memory a maximum of 8 times. See these threads, among others: [1] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01046.html https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01236.html [2]

[PATCH v2 3/3] Lift max memory slots limit imposed by vhost-user

The current vhost-user implementation in Qemu imposes a limit on the maximum number of memory slots exposed to a VM using a vhost-user device. This change provides a new protocol feature VHOST_USER_F_CONFIGURE_SLOTS which, when enabled, lifts this limit and allows a VM with a vhost-user device to

[PULL 0/2] Ide patches

The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you

[PULL 2/2] tests/ide-test: Create a single unit-test covering more PRDT cases

From: Alexander Popov Fuzzing the Linux kernel with syzkaller allowed to find how to crash qemu using a special SCSI_IOCTL_SEND_COMMAND. It hits the assertion in ide_dma_cb() introduced in the commit a718978ed58a in July 2015. Currently this bug is not reproduced by the unit tests. Let's

[PULL 1/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

From: Alexander Popov The commit a718978ed58a from July 2015 introduced the assertion which implies that the size of successful DMA transfers handled in ide_dma_cb() should be multiple of 512 (the size of a sector). But guest systems can initiate DMA transfers that don't fit this requirement.

Re: [PATCH v2] riscv: Add helper to make NaN-boxing for FP register

On Mon, Jan 27, 2020 at 4:37 PM Ian Jiang wrote: > > The function that makes NaN-boxing when a 32-bit value is assigned > to a 64-bit FP register is split out to a helper gen_nanbox_fpr(). > Then it is applied in translating of the FLW instruction. > > Signed-off-by: Ian Jiang Reviewed-by:

Re: [PATCH] riscv: Add helper to make NaN-boxing for FP register

The patch description is modified and a new version is committed. -- Ian Jiang Richard Henderson 于2020年1月28日周二 上午1:38写道： > > On 1/27/20 6:10 AM, Ian Jiang wrote: > > The function that makes NaN-boxing when a 32-bit value is assigned > > to a 64-bit FP register is split out to a helper

Re: Making QEMU easier for management tools and applications

On 1/27/20 5:38 PM, Paolo Bonzini wrote: > > > Il lun 27 gen 2020, 21:11 John Snow > ha scritto: > > > > ./qemu-core < { >     "machine": "Q35", >     "memory": "2GiB", >     "accel": "kvm" > } > EOF > > > And now you have to keep all

[PATCH v2] riscv: Add helper to make NaN-boxing for FP register

The function that makes NaN-boxing when a 32-bit value is assigned to a 64-bit FP register is split out to a helper gen_nanbox_fpr(). Then it is applied in translating of the FLW instruction. Signed-off-by: Ian Jiang --- target/riscv/insn_trans/trans_rvf.inc.c | 17 +++-- 1 file

Re: [PATCH v3 00/14] Fixes for DP8393X SONIC device emulation

On Mon, 20 Jan 2020, Finn Thain wrote: > Hi All, > > There are bugs in the emulated dp8393x device that can stop packet > reception in a Linux/m68k guest (q800 machine). > > With a Linux/mips guest (magnum machine), the driver fails to probe > the dp8393x device. > > With a NetBSD/arc 5.1

Re: [PATCH] riscv: Add helper to make NaN-boxing for FP register

On Mon, Jan 27, 2020 at 6:11 AM Ian Jiang wrote: > > The function that makes NaN-boxing when a 32-bit value is assigned > to a 64-bit FP register is split out to a helper gen_nanbox_fpr(). > Then it is applied in translating of the FLW instruction. > > This also applies for other instructions

Re: [PATCH v3 00/14] Fixes for DP8393X SONIC device emulation

Le 19/01/2020 à 23:59, Finn Thain a écrit : > Hi All, > > There are bugs in the emulated dp8393x device that can stop packet > reception in a Linux/m68k guest (q800 machine). > > With a Linux/mips guest (magnum machine), the driver fails to probe > the dp8393x device. > > With a NetBSD/arc 5.1

Re: [PATCH v4 29/40] target/arm: Flush tlb for ASID changes in EL2&0 translation regime

On 12/6/19 9:05 AM, Peter Maydell wrote: > On Tue, 3 Dec 2019 at 02:30, Richard Henderson > wrote: >> >> Since we only support a single ASID, flush the tlb when it changes. >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/helper.c | 9 + >> 1 file changed, 9 insertions(+) >>

Re: [PATCH] .travis.yml: Drop superfluous use of --python=python3 parameter

Philippe Mathieu-Daudé writes: > As we require Python3 since commit ddf9069963, we don't need to > explicit it with the --python=/usr/bin/python3 configure option. > > Reported-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé Queued to testing/next, thanks. > --- > Cc: Wainer dos

Re: [PATCH v2] riscv/virt: Add syscon reboot and poweroff DT nodes

On Wed, Jan 22, 2020 at 11:18 PM Anup Patel wrote: > > The SiFive test device found on virt machine can be used by > generic syscon reboot and poweroff drivers available in Linux > kernel. > > This patch updates FDT generation in virt machine so that > Linux kernel can probe and use generic

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On 1/27/20 12:35 PM, Cornelia Huck wrote: > On Mon, 27 Jan 2020 11:39:02 -0500 > Collin Walling wrote: > >> On 1/27/20 6:47 AM, Cornelia Huck wrote: >>> On Fri, 24 Jan 2020 17:14:04 -0500 >>> Collin Walling wrote: >>> [...] The availability of this instruction is determined by

Re: Making QEMU easier for management tools and applications

Il lun 27 gen 2020, 21:11 John Snow ha scritto: > > > ./qemu-core < { > "machine": "Q35", > "memory": "2GiB", > "accel": "kvm" > } > EOF > And now you have to keep all the syntactic sugar that is in vl.c. I don't think a redesign of -readconfig should accept anything less verbose

Re: [PATCH v2 1/2] qemu-img: Add --target-is-zero to convert

On 1/24/20 4:34 AM, David Edmondson wrote: In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option,

[PULL 17/19] multifd: Split multifd code into its own file

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/Makefile.objs | 1 + migration/migration.c | 1 + migration/multifd.c | 899 migration/multifd.h | 139 ++ migration/ram.c | 988

[PULL 14/19] multifd: Make multifd_save_setup() get an Error parameter

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- We can't trust that error_in is not NULL. Create a local_error. --- migration/migration.c | 4 +++- migration/ram.c | 2 +- migration/ram.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git

[PULL 16/19] multifd: Add multifd-method parameter

This will store the compression method to use. We start with none. Signed-off-by: Juan Quintela Reviewed-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- Rename it to NONE Fix typos (dave) We don't need to chek values returned by visit_type_MultifdCompress (markus) Fix yet more

[PULL 19/19] migration/compress: compress QEMUFile is not writable

From: Wei Yang We open a file with empty_ops for compress QEMUFile, which means this is not writable. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git

[PULL 13/19] migration: Make checkpatch happy with comments

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 8f04b5ab3a..12b76b7841 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1320,10

[PULL 18/19] migration: Simplify get_qlist

From: Eric Auger Instead of inserting read elements at the head and then reversing the list, it is simpler to add each element after the previous one. Introduce QLIST_RAW_INSERT_AFTER helper and use it in get_qlist(). Signed-off-by: Eric Auger Suggested-by: Juan Quintela Reviewed-by: Juan

[PULL 10/19] multifd: multifd_queue_page only needs the qemufile

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 602e9ca5a0..ad9cc3e7bd 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -974,7 +974,7 @@

[PULL 08/19] ram_addr: Split RAMBlock definition

We need some of the fields without having to poison everything else. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- MAINTAINERS | 1 + include/exec/ram_addr.h | 40 +- include/exec/ramblock.h | 64

[PULL 15/19] multifd: Make multifd_load_setup() get an Error parameter

We need to change the full chain to pass the Error parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Always use a local_err, and in case of error propagate/print it as needed. --- migration/migration.c | 35 +--

[PULL 11/19] multifd: multifd_send_sync_main only needs the qemufile

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index ad9cc3e7bd..152e9cf46d 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1082,7

[PULL 02/19] multifd: Make sure that we don't do any IO after an error

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index d2208b5534..f95d656c26 100644 --- a/migration/ram.c +++ b/migration/ram.c @@

[PULL 07/19] migration/multifd: fix nullptr access in multifd_send_terminate_threads

From: Zhimin Feng If the multifd_send_threads is not created when migration is failed, multifd_save_cleanup would be called twice. In this senario, the multifd_send_state is accessed after it has been released, the result is that the source VM is crashing down. Here is the coredump stack:

[PULL 12/19] multifd: Use qemu_target_page_size()

We will make it cpu independent. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 152e9cf46d..8f04b5ab3a 100644 --- a/migration/ram.c +++

[PULL 05/19] migration-test: Make sure that multifd and cancel works

Test that this sequence works: - launch source - launch target - start migration - cancel migration - relaunch target - do migration again Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- - Wait for 1st trhead to move to cancelled before launching second migration - Add

[PULL 03/19] qemu-file: Don't do IO after shutdown

Be sure that we are not doing neither read/write after shutdown of the QEMUFile. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Set error in case that there is none (dave) --- migration/qemu-file.c | 22 +- 1 file changed, 21 insertions(+), 1

[PULL 06/19] migration: Create migration_is_running()

This function returns true if we are in the middle of a migration. It is like migration_is_setup_or_active() with CANCELLING and COLO. Adapt all callers that are needed. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Fix typo. Thanks Denis. --- migration/migration.c |

[PULL 09/19] multifd: multifd_send_pages only needs the qemufile

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 82c7edb083..602e9ca5a0 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -929,7 +929,7 @@

[PULL 04/19] migration: Don't send data if we have stopped

If we do a cancel, we got out without one error, but we can't do the rest of the output as in a normal situation. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/ram.c

[PULL 01/19] migration-test: Use g_free() instead of free()

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 26e2e77289..b6a74a05ce 100644 ---

[PULL 00/19] 10 next patches

The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/10_next-pull-request

Re: [EXTERNAL] Re: QEMU for aarch64 with plugins seems to fail basic consistency checks

This proposed text sounds good. Better English is to say "concepts" rather than "conceptions". My plugin currently allocates its own unique user data structure on every call to the instrumentation-time callback. This piece of user data captures the transient data presented from qemu. What's

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

On Mon, 27 Jan 2020 at 15:07, Alex Bennée wrote: > Robert Foley writes: > > > Hi Drew, > > > > On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote: > > > >> > > >> > I suppose we could check the version of QEMU and use the above > >> > defaults only for earlier versions of QEMU. > >> > This is

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

On 1/27/20 3:43 PM, Peter Krempa wrote: > On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote: >> >> >> On 1/27/20 5:36 AM, Maxim Levitsky wrote: >>> This patch series is bunch of cleanups >>> to the hmp monitor code. >>> >>> This series only touched blockdev related hmp handlers. >>> >>>

Re: Making QEMU easier for management tools and applications

On 1/27/20 9:35 AM, Kevin Wolf wrote: > Am 24.01.2020 um 10:50 hat Daniel P. Berrangé geschrieben: >> On Thu, Jan 23, 2020 at 04:07:09PM -0500, John Snow wrote: >>> Well, sure. The context of this email was qmp-shell though, which is >>> meant to help facilitate the entry of JSON commands so

Re: [PATCH] tests/acceptance: Add a test for the canon-a1100 machine

Hey Wainer, On 1/27/20 6:45 PM, Wainer dos Santos Moschetta wrote: On 1/27/20 1:41 PM, Philippe Mathieu-Daudé wrote: On 1/27/20 4:39 PM, Thomas Huth wrote: On 27/01/2020 16.18, Philippe Mathieu-Daudé wrote: On 1/27/20 3:41 PM, Thomas Huth wrote: The canon-a1100 machine can be used with the

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote: > > > On 1/27/20 5:36 AM, Maxim Levitsky wrote: > > This patch series is bunch of cleanups > > to the hmp monitor code. > > > > This series only touched blockdev related hmp handlers. > > > > No functional changes expected other that > >

Re: [PATCH 0/9] more audio fixes and improvements

> On 23/01/2020 07:41, Volker Rümelin wrote: > >> The first two patches "audio: fix audio_generic_write" and >> "audio: fix audio_generic_read" are only compile tested. The >> code is only reachable from the DirectSound backend with the >> mixing-engine off. I don't know if it is reachable at all.

Re: Making QEMU easier for management tools and applications

* Kevin Wolf (kw...@redhat.com) wrote: > Am 24.01.2020 um 10:50 hat Daniel P. Berrangé geschrieben: > > On Thu, Jan 23, 2020 at 04:07:09PM -0500, John Snow wrote: > > > Well, sure. The context of this email was qmp-shell though, which is > > > meant to help facilitate the entry of JSON commands so

Re: Making QEMU easier for management tools and applications

* Kevin Wolf (kw...@redhat.com) wrote: > Am 25.01.2020 um 11:18 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: > > >> This is finally something I'd consider to be on a par with the > > >> original QEMU syntax, before

Re: Making QEMU easier for management tools and applications

On 1/27/20 6:56 AM, Kevin Wolf wrote: > Am 25.01.2020 um 11:18 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >>> Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: This is finally something I'd consider to be on a par with the original QEMU syntax, before we

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

Robert Foley writes: > Hi Drew, > > On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote: > >> > >> > I suppose we could check the version of QEMU and use the above >> > defaults only for earlier versions of QEMU. >> > This is something we will probably move to aarch64vm.py since it is common. >>

Re: [PULL 111/111] virtiofsd: add some options to the help message

* Christophe de Dinechin (dinec...@redhat.com) wrote: > > Dr. David Alan Gilbert (git) writes: > > > From: Masayoshi Mizuma > > > > Add following options to the help message: > > - cache > > - flock|no_flock > > - norace > > - posix_lock|no_posix_lock > > - readdirplus|no_readdirplus > > -

Re: [PATCH v1 12/13] tests/docker: re-enable cross-compiling for x86_64 hosts

On Mon, Jan 27, 2020 at 8:38 PM Philippe Mathieu-Daudé wrote: > On 1/24/20 9:40 PM, Alex Bennée wrote: > > Now we have moved everything around we can re-enable the builds for > > x86_64. Thanks to the descriptive names we are able to sort out QEMU > > build and tests build dockerfiles and ensure

Re: [PATCH v1 10/13] tests/docker: add debian10-native-qemu-build

On 1/24/20 9:40 PM, Alex Bennée wrote: This is a new dockerfile which can build the native architecture QEMU on a Debian 10 based image whatever architecture that may be. Signed-off-by: Alex Bennée --- .../dockerfiles/debian10-native-qemu-build.docker | 15 +++ 1 file changed,

Re: Making QEMU easier for management tools and applications

On 1/25/20 6:41 AM, Paolo Bonzini wrote: > On 20/01/20 10:55, Stefan Hajnoczi wrote: >>> >>> [1] https://qemu.readthedocs.io/en/latest/interop/live-block-operations.html >> John and I discussed async events in the past. qmp-shell currently uses >> the input() built-in function. If we modify

Re: [PATCH v1 12/13] tests/docker: re-enable cross-compiling for x86_64 hosts

On 1/24/20 9:40 PM, Alex Bennée wrote: Now we have moved everything around we can re-enable the builds for x86_64. Thanks to the descriptive names we are able to sort out QEMU build and tests build dockerfiles and ensure the correct debian dependencies. Move the fedora, mxe and travis

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

On 1/27/20 5:36 AM, Maxim Levitsky wrote: > This patch series is bunch of cleanups > to the hmp monitor code. > > This series only touched blockdev related hmp handlers. > > No functional changes expected other that > light error message changes by the last patch. > > This was inspired by

Re: [PULL 016/111] virtiofsd: Add options for virtio

* Christophe de Dinechin (dinec...@redhat.com) wrote: > > Dr. David Alan Gilbert (git) writes: > > > From: "Dr. David Alan Gilbert" > > > > Add options to specify parameters for virtio-fs paths, i.e. > > > >./virtiofsd -o vhost_user_socket=/tmp/vhostqemu > > Shouldn't that be

Re: [PATCH v2 2/2] doc: Use @code rather than @var for options

On 1/24/20 4:34 AM, David Edmondson wrote: Texinfo defines @var for metasyntactic variables and such terms are shown in upper-case or italics in the output of makeinfo. When considering an option to a command, such as "-n", upper-casing is undesirable as it may confuse the reader or be in

Re: [PATCH v3 1/4] tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter

On 1/24/20 7:36 AM, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: The test case may need to boot the VM with an accelerator that isn't actually enabled on the QEMU binary and/or present in the host. In this case the test behavior is undefined, and the

Re: [PATCH v1 02/13] tests/docker: better handle symlinked libs

On 1/24/20 9:40 PM, Alex Bennée wrote: When we are copying we want to ensure we grab the first resolution (the found in path section). However even that binary might be a symlink so lets make sure we chase the symlinks to copy the right binary to where it can be found. Signed-off-by: Alex

Re: [PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 1

On Fri, 24 Jan 2020 04:35:14 PST (-0800), Peter Maydell wrote: On Thu, 23 Jan 2020 at 18:43, Palmer Dabbelt wrote: On Thu, 23 Jan 2020 06:38:07 PST (-0800), Peter Maydell wrote: > Hi. This pull request doesn't seem to be signed with the GPG > key that I have on record for you... When I moved

Re: [PULL 00/11] target/hppa patch queue

Ho hum, missed "PULL" in the subject. r~ > The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into > staging (2020-01-27 13:02:36 +) > > are available in the Git

Re: Integrating QOM into QAPI

> On 26 Jan 2020, at 16:04, Peter Maydell wrote: > > On Sun, 26 Jan 2020 at 08:10, Christophe de Dinechin > wrote: >> I’m still puzzled as to why anybody would switch to something like >> GObject when there is C++. > > I'm fairly strongly against using C++. Just to be clear, so am I ;-) >

Re: Integrating QOM into QAPI

> On 26 Jan 2020, at 10:11, Marc-André Lureau > wrote: > > Hi > > On Sun, Jan 26, 2020 at 9:10 AM Christophe de Dinechin > wrote: >> >> >> >>> On 21 Jan 2020, at 16:11, Marc-André Lureau >>> wrote: >>> >>> Hi >>> >>> On Tue, Jan 21, 2020 at 7:01 PM Markus Armbruster wrote:

Re: Integrating QOM into QAPI

> On 26 Jan 2020, at 17:47, Paolo Bonzini wrote: > > On 26/01/20 10:11, Marc-André Lureau wrote: >>> I’m still puzzled as to why anybody would switch to something like >>> GObject when there is C++. >> C++ is another level of complexity. >> >> Replacing QOM with GObject would mainly bring us

[PATCH 00/11] target/hppa patch queue

: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-pa-20200127 for you to fetch changes up to b1af755c33bf0d690553a5ccd93689dfd15a98e8: target/hppa

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

Hi Drew, On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote: > > > > I suppose we could check the version of QEMU and use the above > > defaults only for earlier versions of QEMU. > > This is something we will probably move to aarch64vm.py since it is common. > > What versions of QEMU do these

Re: [qemu-web PATCH v2] Add "Security Process" information to the main website

On 27/01/20 11:00, Thomas Huth wrote: > On 23/01/2020 20.43, Eric Blake wrote: >> On 1/23/20 11:11 AM, Thomas Huth wrote: >>> One reporter of a security issue recently complained that it might not >>> be the best idea to store our "Security Process" in the Wiki. Well, while >>> the page in the

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On 1/27/20 1:21 PM, Collin Walling wrote: > On 1/27/20 12:55 PM, David Hildenbrand wrote: >> On 27.01.20 18:29, Cornelia Huck wrote: >>> On Mon, 27 Jan 2020 18:09:11 +0100 >>> David Hildenbrand wrote: >>> >>> +static void s390_diag318_reset(DeviceState *dev) >>> +{ >>> +if

Re: [GSoC/Outreachy QEMU project proposal] Measure and Analyze QEMU Performance

On 1/21/20 12:07 PM, Aleksandar Markovic wrote: On Mon, Jan 20, 2020 at 3:51 PM Stefan Hajnoczi wrote: On Sat, Jan 18, 2020 at 03:08:37PM +0100, Aleksandar Markovic wrote: 3) The community will be given all devised performance measurement methods in the form of easily reproducible

Re: [PATCH v1 12/13] tests/docker: re-enable cross-compiling for x86_64 hosts

Richard Henderson writes: > On 1/24/20 10:40 AM, Alex Bennée wrote: >> +../dockerfiles.cross/fedora-i386-build-qemu.docker >> \ No newline at end of file > > Lots of no trailing newlines. Probably not intentional? I think that's just a vagary of the git symlink representation. -- Alex

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On 1/27/20 12:55 PM, David Hildenbrand wrote: > On 27.01.20 18:29, Cornelia Huck wrote: >> On Mon, 27 Jan 2020 18:09:11 +0100 >> David Hildenbrand wrote: >> >> +static void s390_diag318_reset(DeviceState *dev) >> +{ >> +if (kvm_enabled()) >> +

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

On 27/01/20 14:26, Olaf Hering wrote: >> That's years away, so ideally libxl would have migrated away from >> xenfv before that. For now, sticking to a fixed version as in >> Olaf's patch is a good stopgap measure. > Is there a way to inspect a running qemu process to see what version > it is? I

[PULL 13/13] iscsi: Don't access non-existent scsi_lba_status_descriptor

In iscsi_co_block_status(), we may have received num_descriptors == 0 from the iscsi server. Therefore, we can't unconditionally access lbas->descriptors[0]. Add the missing check. Signed-off-by: Kevin Wolf Reviewed-by: Felipe Franciosi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: John

[PULL 07/13] block/backup-top: Don't acquire context while dropping top

From: Sergio Lopez All paths that lead to bdrv_backup_top_drop(), except for the call from backup_clean(), imply that the BDS AioContext has already been acquired, so doing it there too can potentially lead to QEMU hanging on AIO_WAIT_WHILE(). An easy way to trigger this situation is by issuing

[PULL 12/13] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)

From: Felipe Franciosi When querying an iSCSI server for the provisioning status of blocks (via GET LBA STATUS), Qemu only validates that the response descriptor zero's LBA matches the one requested. Given the SCSI spec allows servers to respond with the status of blocks beyond the end of the

[PULL 06/13] blockdev: honor bdrv_try_set_aio_context() context requirements

From: Sergio Lopez bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez Signed-off-by: Kevin Wolf --- blockdev.c | 68

[PULL 08/13] blockdev: Acquire AioContext on dirty bitmap functions

From: Sergio Lopez Dirty map addition and removal functions are not acquiring to BDS AioContext, while they may call to code that expects it to be acquired. This may trigger a crash with a stack trace like this one: #0 0x7f0ef146370f in __GI_raise (sig=sig@entry=6) at

[PULL 05/13] blockdev: unify qmp_blockdev_backup and blockdev-backup transaction paths

From: Sergio Lopez Issuing a blockdev-backup from qmp_blockdev_backup takes a slightly different path than when it's issued from a transaction. In the code, this is manifested as some redundancy between do_blockdev_backup() and blockdev_backup_prepare(). This change unifies both paths, merging

[PULL 10/13] iotests: Test handling of AioContexts with some blockdev actions

From: Sergio Lopez Includes the following tests: - Adding a dirty bitmap. * RHBZ: 1782175 - Starting a drive-mirror to an NBD-backed target. * RHBZ: 1746217, 1773517 - Aborting an external snapshot transaction. * RHBZ: 1779036 - Aborting a blockdev backup transaction. * RHBZ:

[PULL 01/13] iotests.py: Let wait_migration wait even more

From: Max Reitz The "migration completed" event may be sent (on the source, to be specific) before the migration is actually completed, so the VM runstate will still be "finish-migrate" instead of "postmigrate". So ask the users of VM.wait_migration() to specify the final runstate they desire

[PULL 09/13] blockdev: Return bs to the proper context on snapshot abort

From: Sergio Lopez external_snapshot_abort() calls to bdrv_set_backing_hd(), which returns state->old_bs to the main AioContext, as it's intended to be used then the BDS is going to be released. As that's not the case when aborting an external snapshot, return it to the AioContext it was before

[PULL 03/13] blockdev: fix coding style issues in drive_backup_prepare

From: Sergio Lopez Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c

[PULL 02/13] iotests: Add more "skip_if_unsupported" statements to the python tests

From: Thomas Huth The python code already contains a possibility to skip tests if the corresponding driver is not available in the qemu binary - use it in more spots to avoid that the tests are failing if the driver has been disabled. While we're at it, we can now also remove some of the old

[PULL 11/13] block/backup: fix memory leak in bdrv_backup_top_append()

From: Eiichi Tsukata bdrv_open_driver() allocates bs->opaque according to drv->instance_size. There is no need to allocate it and overwrite opaque in bdrv_backup_top_append(). Reproducer: $ QTEST_QEMU_BINARY=./x86_64-softmmu/qemu-system-x86_64 valgrind -q --leak-check=full

[PULL 00/13] Block layer patches

The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[PULL 04/13] blockdev: unify qmp_drive_backup and drive-backup transaction paths

From: Sergio Lopez Issuing a drive-backup from qmp_drive_backup takes a slightly different path than when it's issued from a transaction. In the code, this is manifested as some redundancy between do_drive_backup() and drive_backup_prepare(). This change unifies both paths, merging

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On 27.01.20 18:29, Cornelia Huck wrote: > On Mon, 27 Jan 2020 18:09:11 +0100 > David Hildenbrand wrote: > > +static void s390_diag318_reset(DeviceState *dev) > +{ > +if (kvm_enabled()) > +kvm_s390_set_diag318_info(0); > +} > + > +static void

Re: [PATCH] tests/acceptance: Add a test for the canon-a1100 machine

On 1/27/20 1:41 PM, Philippe Mathieu-Daudé wrote: On 1/27/20 4:39 PM, Thomas Huth wrote: On 27/01/2020 16.18, Philippe Mathieu-Daudé wrote: On 1/27/20 3:41 PM, Thomas Huth wrote: The canon-a1100 machine can be used with the Barebox firmware. The QEMU Advent Calendar 2018 features a

Re: [PATCH] riscv: Add helper to make NaN-boxing for FP register

On 1/27/20 6:10 AM, Ian Jiang wrote: > The function that makes NaN-boxing when a 32-bit value is assigned > to a 64-bit FP register is split out to a helper gen_nanbox_fpr(). > Then it is applied in translating of the FLW instruction. > > This also applies for other instructions when the RVD

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On Mon, 27 Jan 2020 11:39:02 -0500 Collin Walling wrote: > On 1/27/20 6:47 AM, Cornelia Huck wrote: > > On Fri, 24 Jan 2020 17:14:04 -0500 > > Collin Walling wrote: > > > >> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > >> be intercepted by SIE and handled via KVM.

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

On 1/24/20 3:03 PM, Thomas Huth wrote: The 2018 edition of the QEMU advent calendar 2018 featured Linux images for various non-x86 machines. We can use them for a boot tests in our acceptance test suite. Let's also make sure that we build the corresponding machines in Travis, and while we're

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On Mon, 27 Jan 2020 18:09:11 +0100 David Hildenbrand wrote: > >>> +static void s390_diag318_reset(DeviceState *dev) > >>> +{ > >>> +if (kvm_enabled()) > >>> +kvm_s390_set_diag318_info(0); > >>> +} > >>> + > >>> +static void s390_diag318_class_init(ObjectClass *klass, void *data) >

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

On Mon, Jan 27, 2020 at 11:47:35AM -0500, Robert Foley wrote: > On Mon, 27 Jan 2020 at 10:01, Alex Bennée wrote: > > > vm-boot-ssh-%: $(IMAGES_DIR)/%.img > > > $(call quiet-command, \ > > > - $(SRC_PATH)/tests/vm/$* \ > > > + $(PYTHON) $(SRC_PATH)/tests/vm/$* \ > >

  1   2   3   >