Re: [PATCH 2/3] hw/block/nvme: Check zone state before checking boundaries

2021-01-25 Thread Klaus Jensen
On Jan 26 14:02, Dmitry Fomichev wrote: > The code in nvme_check_zone_write() first checks for zone boundary > condition violation and only after that it proceeds to verify that the > zone state is suitable the write to happen. This is not consistent with > nvme_check_zone_read() flow - in that

Re: [PATCH 1/3] hw/block/nvme: Check for zone boundary during append

2021-01-25 Thread Klaus Jensen
On Jan 26 14:02, Dmitry Fomichev wrote: > It is observed that with the existing code it is possible to keep > appending to a zone indefinitely. To fix, add the missing check to > verify that the zone append is not going to write beyond zone capacity. > > Reported-by: Niklas Cassel >

[PATCH RESEND] hostmem: Don't report pmem attribute if unsupported

2021-01-25 Thread Michal Privoznik
When management applications (like Libvirt) want to check whether memory-backend-file.pmem is supported they can list object properties using 'qom-list-properties'. However, 'pmem' is declared always (and thus reported always) and only at runtime QEMU errors out if it was built without libpmem

[PATCH v3 5/5] vhost-vdpa: add callback function for configure interrupt

2021-01-25 Thread Cindy Lu
Add call back function for configure interrupt. Set the notifier's fd to the kernel driver when vdpa start. also set -1 while vdpa stop. then the kernel will release the related resource Signed-off-by: Cindy Lu --- hw/virtio/trace-events| 2 ++ hw/virtio/vhost-vdpa.c|

Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/24/21 10:41 PM, Richard Henderson wrote: > On 1/24/21 10:24 AM, Philippe Mathieu-Daudé wrote: >> On 1/24/21 9:07 PM, Richard Henderson wrote: >>> Doesn't this get put in libutil, where it is only pulled from the archive >>> when >>> needed? Also, libutil is built once, not per-target. >> >>

[PATCH v3 4/5] virtio-mmio: add support for configure interrupt

2021-01-25 Thread Cindy Lu
add configure interrupt support for virtio-mmio bus. This interrupt will working while backend is vhost-vdpa Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index

[Bug 1909256] Re: compile failure if gnutls headers not on default include path

2021-01-25 Thread Roman Bolshakov
The fix is committed in 3eacf70bb5a8. ** Changed in: qemu Status: New => Fix Committed ** Changed in: qemu Assignee: (unassigned) => Roman Bolshakov (roolebo) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v3 1/5] virtio: add support for configure interrupt

2021-01-25 Thread Cindy Lu
Add configure notifier and virtio_set_config_notifier_fd_handler in virtio Signed-off-by: Cindy Lu --- hw/virtio/virtio.c | 26 ++ include/hw/virtio/virtio-bus.h | 2 ++ include/hw/virtio/virtio.h | 6 ++ 3 files changed, 34 insertions(+) diff

Re: [PATCH v6 68/72] target/riscv: gdb: modify gdb csr xml file to align with csr register map

2021-01-25 Thread Frank Chang
On Tue, Jan 26, 2021 at 7:54 AM Alistair Francis wrote: > On Tue, Jan 12, 2021 at 2:50 AM wrote: > > > > From: Hsiangkai Wang > > > > Signed-off-by: Hsiangkai Wang > > Acked-by: Richard Henderson > > Signed-off-by: Frank Chang > > This patch won't apply any more, we have removed the

[PATCH v3 3/5] virtio-pci: add support for configure interrupt

2021-01-25 Thread Cindy Lu
Add support for configure interrupt, use kvm_irqfd_assign and set the gsi to kernel. When the configure notifier was eventfd_signal by host kernel, this will finally inject an msix interrupt to guest Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 92

[PATCH v3 2/5] vhost_net: enable configure interrupt when vhost_net start

2021-01-25 Thread Cindy Lu
While peer is vhost vdpa, setup the configure interrupt function vhost_net_start and release the resource when vhost_net_stop Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/net/vhost_net.c

[PATCH v3 0/5] vhost-vdpa: add support for configure interrupt

2021-01-25 Thread Cindy Lu
These code are all tested in vp-vdpa (support configure interrupt) vdpa_sim (not support configure interrupt) test in virtio-pci bus and virtio-mmio bus change in v2: Add support fot virtio-mmio bus active the notifier wihle the backend support configure intterrput misc fixes form v1 change in

Re: [PATCH] gitlab-ci.yml: Avoid recompiling the sources in the test jobs

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 7:57 AM, Thomas Huth wrote: > Currently, our check-system-* jobs are recompiling the whole sources > again. This happens due to the fact that the jobs are checking out > the whole source tree and required submodules again, and only try > to use the "build" directory with the binaries

Re: [PATCH v3 3/9] hw/ssi: Add SiFive SPI controller support

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 7:00 AM, Bin Meng wrote: > From: Bin Meng > > This adds the SiFive SPI controller model for the FU540 SoC. > The direct memory-mapped SPI flash mode is unsupported. > > Signed-off-by: Bin Meng > > --- > > Changes in v3: > - Simplify flush txfifo logic > > Changes in v2: > - Log

Re: [PATCH v9 04/11] slirp: feature detection for smbd

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 2:24 AM, Joelle van Dyne wrote: > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne > --- > configure | 22 +- > meson.build | 2 +- >

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Warner Losh
On Tue, Jan 26, 2021 at 12:08 AM Philippe Mathieu-Daudé wrote: > On 1/26/21 6:55 AM, Joelle van Dyne wrote: > > Previously, the only case where sys/disk.h does not exist is on > > platforms that define __DragonFly__. However, iOS also does not have > > this header. Previously, I had it as > > >

Re: [PATCH v9 07/11] darwin: fix cross-compiling for Darwin

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 2:24 AM, Joelle van Dyne wrote: > Add objc to the Meson cross file as well as detection of Darwin. > > Reviewed-by: Peter Maydell > Signed-off-by: Joelle van Dyne > --- > configure | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 8:08 AM, Philippe Mathieu-Daudé wrote: > On 1/26/21 6:55 AM, Joelle van Dyne wrote: >> Previously, the only case where sys/disk.h does not exist is on >> platforms that define __DragonFly__. However, iOS also does not have >> this header. Previously, I had it as >> >> #if

Re: [PATCH v9 10/11] darwin: detect CoreAudio for build

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 2:24 AM, Joelle van Dyne wrote: > On iOS there is no CoreAudio, so we should not assume Darwin always > has it. > > Signed-off-by: Joelle van Dyne > --- > configure | 35 +-- > 1 file changed, 33 insertions(+), 2 deletions(-) Reviewed-by: Philippe

Re: [PATCH v2 0/5] vhost-vdpa: add support for configure interrupt

2021-01-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210126070351.28575-1-l...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210126070351.28575-1-l...@redhat.com Subject: [PATCH v2 0/5] vhost-vdpa: add support for

Re: [PATCH 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-01-25 Thread Markus Armbruster
Kevin Wolf writes: > Am 25.01.2021 um 17:24 hat Markus Armbruster geschrieben: >> The previous commit rendered the name fdctrl_realize_common() somewhat >> misleading. Get rid of it by inlining the (now pretty simple) >> function into its only caller. >> >> Signed-off-by: Markus Armbruster >>

Re: [RFC PATCH v2 04/20] hw/arm/aspeed_soc: Mark the device with no migratable fields

2021-01-25 Thread Cédric Le Goater
On 1/17/21 8:24 PM, Philippe Mathieu-Daudé wrote: > This device doesn't have fields to migrate. Be explicit > by using vmstate_qdev_no_state_to_migrate. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C.

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/26/21 6:55 AM, Joelle van Dyne wrote: > Previously, the only case where sys/disk.h does not exist is on > platforms that define __DragonFly__. However, iOS also does not have > this header. Previously, I had it as > > #if defined(__DragonFly__) || defined(CONFIG_IOS) > > But there was a

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Warner Losh
On Mon, Jan 25, 2021 at 10:55 PM Joelle van Dyne wrote: > Previously, the only case where sys/disk.h does not exist is on > platforms that define __DragonFly__. However, iOS also does not have > this header. Previously, I had it as > > #if defined(__DragonFly__) || defined(CONFIG_IOS) > > But

[PATCH v2 3/5] virtio-pci: add support for configure interrupt

2021-01-25 Thread Cindy Lu
Add support for configure interrupt, use kvm_irqfd_assign and set the gsi to kernel. When the configure notifier was eventfd_signal by host kernel, this will finally inject an msix interrupt to guest Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 92

[PATCH v2 4/5] virtio-mmio: add support for configure interrupt

2021-01-25 Thread Cindy Lu
add configure interrupt support for virtio-mmio bus. This interrupt will working while backend is vhost-vdpa Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index

[PATCH v2 5/5] vhost-vdpa: add callback function for configure interrupt

2021-01-25 Thread Cindy Lu
Add call back function for configure interrupt. Set the notifier's fd to the kernel driver when vdpa start. also set -1 while vdpa stop. then the kernel will release the related resource Signed-off-by: Cindy Lu --- hw/virtio/trace-events| 2 ++ hw/virtio/vhost-vdpa.c|

[PATCH v2 2/5] vhost_net: enable configure interrupt when vhost_net start

2021-01-25 Thread Cindy Lu
While peer is vhost vdpa, setup the configure interrupt function vhost_net_start and release the resource when vhost_net_stop Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/net/vhost_net.c

[PATCH v2 1/5] virtio: add support for configure interrupt

2021-01-25 Thread Cindy Lu
Add configure notifier and virtio_set_config_notifier_fd_handler in virtio Signed-off-by: Cindy Lu --- hw/virtio/virtio.c | 26 ++ include/hw/virtio/virtio-bus.h | 2 ++ include/hw/virtio/virtio.h | 6 ++ 3 files changed, 34 insertions(+) diff

[PATCH v2 0/5] vhost-vdpa: add support for configure interrupt

2021-01-25 Thread Cindy Lu
These code are all tested in vp-vdpa (support configure interrupt) vdpa_sim (not support configure interrupt) change in v2: Add support for virtio-mmio bus Active the notifier while the backend support configure interrupt Misc fixes form v1 Cindy Lu (5): virtio: add support for configure

Re: [PATCH v1] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

2021-01-25 Thread Thomas Huth
On 25/01/2021 10.51, Paolo Bonzini wrote: On 25/01/21 10:03, Thomas Huth wrote: Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the

Re: [PATCH 1/2] hw/block/nvme: fix zone boundary check for append

2021-01-25 Thread Klaus Jensen
On Jan 26 04:55, Dmitry Fomichev wrote: > On Tue, 2021-01-19 at 14:54 +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > When a zone append is processed the controller checks that validity of > > the write before assigning the LBA to the append command. This causes > > the boundary check

[PATCH] gitlab-ci.yml: Avoid recompiling the sources in the test jobs

2021-01-25 Thread Thomas Huth
Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the "build" directory with the binaries and object files as an artifact from the previous

Re: [PATCH] hw/misc: Fix arith overflow in NPCM7XX PWM module

2021-01-25 Thread Philippe Mathieu-Daudé
Hi Hao Wu, On 1/26/21 12:48 AM, wuhaotsh--- via wrote: > There's a potential arith overflow in npcm7xx_pwm_calculate_duty. > This patch fixes it. ^ not very useful information ;) What about the simplest approach Peter suggested, a 32-bit duty? > Thanks Peter for finding this out.

Re: [PATCH v6 00/72] support vector extension v1.0

2021-01-25 Thread Frank Chang
On Wed, Jan 20, 2021 at 3:12 AM Alistair Francis wrote: > On Tue, Jan 12, 2021 at 1:40 AM wrote: > > > > From: Frank Chang > > > > This patchset implements the vector extension v1.0 for RISC-V on QEMU. > > > > As vector extension specification is near to be ratified, this patchset > is > >

Re: [RFC PATCH v2 0/3] vfio: Some fixes and optimizations for VFIO migration

2021-01-25 Thread Shenming Lu
On 2020/12/9 16:09, Shenming Lu wrote: > This patch set includes two fixes and one optimization for VFIO migration > as blew: > Patch 1-2: > - Fix two ordering problems in migration. > > Patch 3: > - Optimize the enabling process of the MSI-X vectors in migration. > Hi, Friendly ping, is there

[PATCH v3 8/9] docs/system: Add RISC-V documentation

2021-01-25 Thread Bin Meng
From: Bin Meng Add RISC-V system emulator documentation for generic information. `Board-specific documentation` and `RISC-V CPU features` are only a placeholder and will be added in the future. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1)

[PATCH v3 9/9] docs/system: riscv: Add documentation for sifive_u machine

2021-01-25 Thread Bin Meng
From: Bin Meng This adds detailed documentation for RISC-V `sifive_u` machine, including the following information: - Supported devices - Hardware configuration information - Boot options - Machine-specific options - Running Linux kernel - Running VxWorks kernel - Running U-Boot, and with an

[PATCH v3 5/9] hw/riscv: sifive_u: Add QSPI2 controller and connect an SD card

2021-01-25 Thread Bin Meng
From: Bin Meng This adds the QSPI2 controller to the SoC, and connects an SD card to it. The generation of corresponding device tree source fragment is also added. Specify machine property `msel` to 11 to boot the same upstream U-Boot SPL and payload image for the SiFive HiFive Unleashed board.

[PATCH v3 4/9] hw/riscv: sifive_u: Add QSPI0 controller and connect a flash

2021-01-25 Thread Bin Meng
From: Bin Meng This adds the QSPI0 controller to the SoC, and connects an ISSI 25WP256 flash to it. The generation of corresponding device tree source fragment is also added. Since the direct memory-mapped mode is not supported by the SiFive SPI model, the property does not populate the second

[PATCH v3 6/9] hw/riscv: sifive_u: Change SIFIVE_U_GEM_IRQ to decimal value

2021-01-25 Thread Bin Meng
From: Bin Meng All other peripherals' IRQs are in the format of decimal value. Change SIFIVE_U_GEM_IRQ to be consistent. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1) include/hw/riscv/sifive_u.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 3/9] hw/ssi: Add SiFive SPI controller support

2021-01-25 Thread Bin Meng
From: Bin Meng This adds the SiFive SPI controller model for the FU540 SoC. The direct memory-mapped SPI flash mode is unsupported. Signed-off-by: Bin Meng --- Changes in v3: - Simplify flush txfifo logic Changes in v2: - Log guest error when trying to write reserved registers - Log guest

[PATCH v3 2/9] hw/block: m25p80: Add various ISSI flash information

2021-01-25 Thread Bin Meng
From: Bin Meng This updates the flash information table to include various ISSI flashes that are supported by upstream U-Boot and Linux kernel. Signed-off-by: Bin Meng Acked-by: Alistair Francis --- (no changes since v1) hw/block/m25p80.c | 13 + 1 file changed, 13

[PATCH v3 1/9] hw/block: m25p80: Add ISSI SPI flash support

2021-01-25 Thread Bin Meng
From: Bin Meng This adds the ISSI SPI flash support. The number of dummy cycles in fast read, fast read dual output and fast read quad output commands is currently using the default 8. Likewise, the same default value is used for fast read dual/quad I/O command. Per the datasheet [1], the number

[PATCH v3 7/9] docs/system: Sort targets in alphabetical order

2021-01-25 Thread Bin Meng
From: Bin Meng Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1) docs/system/targets.rst | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/system/targets.rst b/docs/system/targets.rst index 560783644d..564cea9a9b

[PATCH v3 0/9] hw/riscv: sifive_u: Add missing SPI support

2021-01-25 Thread Bin Meng
From: Bin Meng This adds the missing SPI support to the `sifive_u` machine in the QEMU mainline. With this series, upstream U-Boot for the SiFive HiFive Unleashed board can boot on QEMU `sifive_u` out of the box. This allows users to develop and test the recommended RISC-V boot flow with a real

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Joelle van Dyne
Previously, the only case where sys/disk.h does not exist is on platforms that define __DragonFly__. However, iOS also does not have this header. Previously, I had it as #if defined(__DragonFly__) || defined(CONFIG_IOS) But there was a code review comment that we should use feature flags instead

[PATCH 3/3] hw/block/nvme: Add trace events for zone boundary violations

2021-01-25 Thread Dmitry Fomichev
Add three new trace events to be raised in case of zone boundary violations during Read, Write(Zeroes) and Zone Append. Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 8 ++-- hw/block/trace-events | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git

[PATCH 2/3] hw/block/nvme: Check zone state before checking boundaries

2021-01-25 Thread Dmitry Fomichev
The code in nvme_check_zone_write() first checks for zone boundary condition violation and only after that it proceeds to verify that the zone state is suitable the write to happen. This is not consistent with nvme_check_zone_read() flow - in that function, zone state is checked before making any

[PATCH 0/3] Fix zone write validation

2021-01-25 Thread Dmitry Fomichev
These patches solve a few problems that exist in zoned Write ans Zone Append validation code. Dmitry Fomichev (3): hw/block/nvme: Check for zone boundary during append hw/block/nvme: Check zone state before checking boundaries hw/block/nvme: Add trace events for zone boundary violations

[PATCH 1/3] hw/block/nvme: Check for zone boundary during append

2021-01-25 Thread Dmitry Fomichev
It is observed that with the existing code it is possible to keep appending to a zone indefinitely. To fix, add the missing check to verify that the zone append is not going to write beyond zone capacity. Reported-by: Niklas Cassel Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 8

Re: [PATCH 3/3] hw/block/nvme: align with existing style

2021-01-25 Thread Dmitry Fomichev
On Mon, 2021-01-25 at 09:22 +0100, Klaus Jensen wrote: > From: Gollu Appalanaidu > > Change status checks to align with the existing style and remove the > explicit check against NVME_SUCCESS. > > Cc: Dmitry Fomichev > Signed-off-by: Gollu Appalanaidu > Reviewed-by: Klaus Jensen Looks good.

Re: [PATCH 2/2] hw/block/nvme: refactor the logic for zone write checks

2021-01-25 Thread Dmitry Fomichev
On Tue, 2021-01-19 at 14:55 +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Refactor the zone write check logic such that the most "meaningful" > error is returned first. That is, first, if the zone is not writable, > return an appropriate status code for that. Then, make sure we are >

Re: [PATCH 1/2] hw/block/nvme: fix zone boundary check for append

2021-01-25 Thread Dmitry Fomichev
On Tue, 2021-01-19 at 14:54 +0100, Klaus Jensen wrote: > From: Klaus Jensen > > When a zone append is processed the controller checks that validity of > the write before assigning the LBA to the append command. This causes > the boundary check to be wrong. > > Fix this by checking the write

[PATCH] hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response

2021-01-25 Thread Bin Meng
From: Bin Meng The SEND_IF_COND command (CMD8) response is of format R7, but current code returns R1 for CMD8. Fix it. Fixes: 775616c3ae8c ("Partial SD card SPI mode support") Signed-off-by: Bin Meng --- When testing with VxWorks driver, this additional issue was exposed. It looks like

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Warner Losh
On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote: > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- > meson.build| 1 + > block.c| 2 +- > block/file-posix.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

[Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2021-01-25 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796520 Title: autogen

[PATCH v3] Fix crash with IOthread when block commit after snapshot

2021-01-25 Thread 08005325
From: Michael Qiu v3: reformat the commit log, remove duplicate content v2: modify the coredump backtrace within commit log with the newest qemu with master branch Currently, if guest has workloads, IO thread will acquire aio_context lock before do io_submit, it leads to segmentfault when

[PATCH v2] Fix crash with IOthread when block commit after snapshot

2021-01-25 Thread 08005325
From: Michael Qiu v2: modify the coredump backtrace within commit log with the newest qemu with master branch Currently, if guest has workloads, IO thread will acquire aio_context lock before do io_submit, it leads to segmentfault when do block commit after snapshot. Just like below:

[PULL v1 1/1] tpm: tpm_spapr: Remove unused tracepoint

2021-01-25 Thread Stefan Berger
From: Roman Bolshakov Linking of qemu-system-ppc64 fails on macOS with dtrace enabled: error: probe tpm_spapr_show_buffer doesn't exist error: Could not register probes ld: error creating dtrace DOF section for architecture x86_64 The failure is explained in 8c8ed03850208e4 ("net/colo:

[PULL v1 0/1] Merge tpm 2021/01/25 v1

2021-01-25 Thread Stefan Berger
Peter, this PR removes an unused tracepoint from tpm_spapr. Stefan The following changes since commit 31ee895047bdcf7387e3570cbd2a473c6f744b08: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2021-01-25 15:56:13 +) are available in the Git

Re: KVM guests reading/writing guest memory directly and accurately

2021-01-25 Thread Berto Furth
Thanks so much for your help and encouragement Peter. I really appreciate it. All the best! On Mon, 25 Jan 2021, at 03:07, Peter Maydell wrote: > On Sun, 24 Jan 2021 at 07:22, Berto Furth wrote: > > Can anyone give me some advice on how a machine or device can read and > > write kvm guest ram

[PATCH v9 09/11] block: check availablity for preadv/pwritev on mac

2021-01-25 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v9 11/11] darwin: remove 64-bit build detection on 32-bit OS

2021-01-25 Thread Joelle van Dyne
A workaround added in early days of 64-bit OSX forced x86_64 if the host machine had 64-bit support. This creates issues when cross- compiling for ARM64. Additionally, the user can always use --cpu=* to manually set the host CPU and therefore this workaround should be removed. Reviewed-by: Peter

[PATCH v9 04/11] slirp: feature detection for smbd

2021-01-25 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 22 +- meson.build | 2 +- net/slirp.c | 16 3 files changed, 30

[PATCH v9 05/11] osdep: build with non-working system() function

2021-01-25 Thread Joelle van Dyne
Build without error on hosts without a working system(). If system() is called, return -1 with ENOSYS. Signed-off-by: Joelle van Dyne --- meson.build | 1 + include/qemu/osdep.h | 12 2 files changed, 13 insertions(+) diff --git a/meson.build b/meson.build index

[PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build| 1 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 27110075df..6818d97df5 100644 ---

[PATCH v9 07/11] darwin: fix cross-compiling for Darwin

2021-01-25 Thread Joelle van Dyne
Add objc to the Meson cross file as well as detection of Darwin. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 1b2fc502ea..96738a19bc 100755 --- a/configure +++ b/configure @@ -6402,6

[PATCH v9 06/11] darwin: remove redundant dependency declaration

2021-01-25 Thread Joelle van Dyne
Meson will find CoreFoundation, IOKit, and Cocoa as needed. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index d72ab22da5..1b2fc502ea 100755 --- a/configure +++ b/configure @@ -781,7 +781,6 @@

[PATCH v9 10/11] darwin: detect CoreAudio for build

2021-01-25 Thread Joelle van Dyne
On iOS there is no CoreAudio, so we should not assume Darwin always has it. Signed-off-by: Joelle van Dyne --- configure | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/configure b/configure index fddd11fed9..89836f8692 100755 ---

[PATCH v9 02/11] configure: cross-compiling with empty cross_prefix

2021-01-25 Thread Joelle van Dyne
The iOS toolchain does not use the host prefix naming convention. So we need to enable cross-compile options while allowing the PREFIX to be blank. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v9 01/11] block: feature detection for host block support

2021-01-25 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v9 08/11] configure: cross compile should use x86_64 cpu_family

2021-01-25 Thread Joelle van Dyne
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 96738a19bc..fddd11fed9 100755 --- a/configure +++ b/configure @@ -6425,9 +6425,12 @@ if test "$cross_compile" =

[PATCH v9 00/11] iOS and Apple Silicon host support

2021-01-25 Thread Joelle van Dyne
These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported the changes to master, re-wrote a lot of the build script changes for meson, and broke up the patches into more

Re: [PATCH V6 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-01-25 Thread Minwoo Im
On 21-01-25 21:29:58, Klaus Jensen wrote: > On Jan 24 11:54, Minwoo Im wrote: > > Hello, > > > > This is sixth patch series for the support of NVMe subsystem scheme with > > multi-controller and namespace sharing in a subsystem. > > > > This version has a fix in nvme_init_ctrl() when 'cntlid' is

Re: [PATCH V6 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-25 Thread Minwoo Im
On 21-01-25 10:11:43, Keith Busch wrote: > On Mon, Jan 25, 2021 at 07:03:32PM +0100, Klaus Jensen wrote: > > On Jan 24 11:54, Minwoo Im wrote: > > > We have nvme-subsys and nvme devices mapped together. To support > > > multi-controller scheme to this setup, controller identifier(id) has to > > >

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-25 Thread Paolo Bonzini
On 26/01/21 01:12, Joelle van Dyne wrote: Here's how meson does cc.has_function https://github.com/mesonbuild/meson/blob/master/mesonbuild/compilers/mixins/clike.py#L761 Since the compiler error comes from the header file with __attribute__((availability(ios,unavailable))) The meson check

[PATCH] hw/block/nvme: fix wrong parameter name 'cross_read'

2021-01-25 Thread Minwoo Im
The actual parameter name is 'cross_read' rather than 'cross_zone_read'. Signed-off-by: Minwoo Im --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 21aec90637fa..bf9134f73d81 100644 --- a/hw/block/nvme.c +++

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-25 Thread Joelle van Dyne
Here's how meson does cc.has_function https://github.com/mesonbuild/meson/blob/master/mesonbuild/compilers/mixins/clike.py#L761 Since the compiler error comes from the header file with __attribute__((availability(ios,unavailable))) The meson check will always pass. cc.compiles should work

Re: [PATCH v2 0/2] vnc: unbreak older gtk-vnc

2021-01-25 Thread Laszlo Ersek
On 01/25/21 11:40, Gerd Hoffmann wrote: > > > Gerd Hoffmann (2): > Revert "vnc: move initialization to framebuffer_update_request" > vnc: send extended desktop resize on update requests > > ui/vnc.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > I didn't test

Re: [PATCH v6 68/72] target/riscv: gdb: modify gdb csr xml file to align with csr register map

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 2:50 AM wrote: > > From: Hsiangkai Wang > > Signed-off-by: Hsiangkai Wang > Acked-by: Richard Henderson > Signed-off-by: Frank Chang This patch won't apply any more, we have removed the hardcoded GDB register list. Alistair > --- > gdb-xml/riscv-32bit-csr.xml | 11

Re: [PATCH v6 26/72] target/riscv: rvv-1.0: floating-point square-root instruction

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 2:03 AM wrote: > > From: Frank Chang > > Signed-off-by: Frank Chang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn32.decode | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v6 27/72] target/riscv: rvv-1.0: floating-point classify instructions

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 2:03 AM wrote: > > From: Frank Chang > > Signed-off-by: Frank Chang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn32.decode | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] hw/misc: Fix arith overflow in NPCM7XX PWM module

2021-01-25 Thread wuhaotsh--- via
There's a potential arith overflow in npcm7xx_pwm_calculate_duty. This patch fixes it. Thanks Peter for finding this out. Signed-off-by: Hao Wu --- hw/misc/npcm7xx_pwm.c | 4 ++-- tests/qtest/npcm7xx_pwm-test.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC v4 01/16] target/riscv: reformat @sh format encoding for B-extension

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 11:18 PM wrote: > > From: Kito Cheng > > Signed-off-by: Kito Cheng > Signed-off-by: Frank Chang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn32.decode | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [PATCH v2 6/7] goldfish_rtc: re-arm the alarm after migration

2021-01-25 Thread Alistair Francis
On Sat, Jan 23, 2021 at 7:06 AM Laurent Vivier wrote: > > Is there someone to merge this? Do you mean just this patch or the whole series? Alistair > > Thanks, > Laurent > > Le 20/12/2020 à 12:26, Laurent Vivier a écrit : > > After a migration the clock offset is updated, but we also > > need

Re: [PATCH v6 25/72] target/riscv: rvv-1.0: take fractional LMUL into vector max elements calculation

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 2:04 AM wrote: > > From: Frank Chang > > Update vext_get_vlmax() and MAXSZ() to take fractional LMUL into > calculation for RVV 1.0. > > Signed-off-by: Frank Chang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h

Re: [PATCH v6 24/72] target/riscv: rvv-1.0: update vext_max_elems() for load/store insns

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 1:59 AM wrote: > > From: Frank Chang > > Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn_trans/trans_rvv.c.inc | 32 +++-- > target/riscv/vector_helper.c| 90 ++--- > 2 files changed, 74

RE: [PATCH v7 00/35] Hexagon patch series

2021-01-25 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 25, 2021 5:09 PM > To: Philippe Mathieu-Daudé ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain > Subject: RE: [PATCH v7 00/35] Hexagon patch

Re: [PATCH v6 23/72] target/riscv: rvv-1.0: load/store whole register instructions

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 1:59 AM wrote: > > From: Frank Chang > > Add the following instructions: > > * vlre.v > * vsr.v > > Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 21 > target/riscv/insn32.decode

Re: [PATCH v6 22/72] target/riscv: rvv-1.0: amo operations

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 2:01 AM wrote: > > From: Frank Chang > > Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 100 +++--- > target/riscv/insn32-64.decode | 18 +- > target/riscv/insn32.decode

RE: [PATCH v7 00/35] Hexagon patch series

2021-01-25 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Monday, January 25, 2021 4:15 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain >

Re: [PATCH v3] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-25 Thread Halil Pasic
On Mon, 25 Jan 2021 14:53:32 +0100 Christian Borntraeger wrote: > Secure execution (aka protected virtualization) guests cannot be > migrated at the moment. If the unpack facility is provided in the cpu > model, a guest may choose to transition to secure mode, making the > guest unmigratable at

Re: Thread safety of coroutine-sigaltstack

2021-01-25 Thread Paolo Bonzini
On 25/01/21 23:15, Laszlo Ersek wrote: - How does this case differ from the registration of types? type_init() is a constructor function, and it generally ends up adding some structures with function pointers (I reckon) via type_table_add(). The main executable doesn't call into the device code

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Richard Henderson
On 1/25/21 11:02 AM, Stefan Weil wrote: > Am 25.01.21 um 20:02 schrieb Richard Henderson: > >> On 1/25/21 8:58 AM, Stefan Weil wrote: >>> I have no evidence that TCI is less reliable than TCG, so I would not write >>> that. >> It can't pass make check-tcg. > > > Where does it fail? Maybe an

Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties

2021-01-25 Thread Vikram Garhwal
On Fri, Jan 22, 2021 at 01:21:53PM +, Peter Maydell wrote: Patch looks good to me. Reviewed-by: Vikram Garhwal > Just noticed this wasn't cc'd to the Xilinx folks. Would one > of you like to review it? > > thanks > -- PMM > > On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini wrote: > > > > The

Re: configure does not detect librados or librbd since the switch to meson

2021-01-25 Thread Peter Lieven
Am 25.01.21 um 22:57 schrieb Paolo Bonzini: > On 25/01/21 20:47, Peter Lieven wrote: >>> Can you include the meson-logs/meson-log.txt output? >> >> Sure:https://pastebin.com/u3XtbDvQ > > Does this work for you? > > diff --git a/meson.build b/meson.build > index 690d48a6fd..a662772c4a 100644 > ---

Re: Thread safety of coroutine-sigaltstack

2021-01-25 Thread Laszlo Ersek
On 01/23/21 14:35, Peter Maydell wrote: > On Sat, 23 Jan 2021 at 00:06, Laszlo Ersek wrote: >> On 01/22/21 11:14, Peter Maydell wrote: >>> I think (but have not checked) that that means we will build and >>> link the object file into the user-mode binaries if you happen >>> to build them in the

Re: [PATCH v7 00/35] Hexagon patch series

2021-01-25 Thread Philippe Mathieu-Daudé
Hi Taylor, On 1/20/21 4:28 AM, Taylor Simpson wrote: > This series adds support for the Hexagon processor with Linux user support > > See patch 02/33 Hexagon README for detailed information. > > This series assumes int128_or() is implemented. >

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-25 Thread Laszlo Ersek
On 01/25/21 22:13, Laszlo Ersek wrote: > On 01/23/21 23:13, Paolo Bonzini wrote: >> On 22/01/21 22:26, Laszlo Ersek wrote: >>> That seems bogus, per POSIX, given that all signals except SIGUSR2 are >>> included in the mask passed to sigsuspend(). >> >> What happens if you get a SIGSTOP at exactly

  1   2   3   4   >