Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 10:24:49AM -0600, Eric DeVolder wrote: > And here is what the main snippet looks like with the above changes (a diff > is quite messy): > > /* > * Macros for use with construction of the action instructions > */ > #define BUILD_READ_VALUE(width_in_bits) \ >

Re: [PATCH] hw/misc/macio/cuda: Simplify using the ldst API

2022-01-25 Thread Mark Cave-Ayland
On 24/01/2022 23:13, Philippe Mathieu-Daudé via wrote: This code is easier to review using the load/store API. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/macio/cuda.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/misc/macio/cuda.c

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-01-25 Thread Andrew Jones
CCing Igor. Thanks, drew On Wed, Jan 26, 2022 at 01:24:10PM +0800, Gavin Shan wrote: > The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() > when it isn't provided explicitly. However, the CPU topology isn't fully > considered in the default association and it causes

Re: [PATCH v6 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-25 Thread Mark Cave-Ayland
On 24/01/2022 19:33, Philippe Mathieu-Daudé via wrote: On 1/24/22 20:16, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 1/24/22 11:55, Alex Bennée wrote: Philippe Mathieu-Daudé writes: This is my last respin on this series which is fully reviewed. Just to note the "b4"

Re: [PATCH] hw/display/tcx: Avoid clearing dirty bitmap in DeviceReset()

2022-01-25 Thread Mark Cave-Ayland
On 22/01/2022 00:07, Philippe Mathieu-Daudé via wrote: Commit 2dd285b5f3 ("tcx: make display updates thread safe") converted this model to use the DirtyBitmapSnapshot API, resetting the dirty bitmap in tcx_update_display(). There is no need to do it again in the DeviceReset handler. See more

Re: [PATCH v4 1/3] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 25.01.2022 12:07, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> We are going to generate trace events for qmp commands. We should >> >> QMP >> >>> generate both trace_*() function calls and trace-events files listing >>> events

Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table

2022-01-25 Thread Ani Sinha
On Tue, 25 Jan 2022, Eric DeVolder wrote: > Ani, > Thanks for the feedback! Inline responses below. > eric > > On 1/25/22 04:53, Ani Sinha wrote: > > > > > > > + > > > +action = ACTION_BEGIN_CLEAR_OPERATION; > > > +BUILD_WRITE_REGISTER_VALUE(32, ERST_ACTION_OFFSET, action); > > > + > >

Re: [PATCH] hw/arm/virt: Enable HMAT on arm virt machine

2022-01-25 Thread chenxiang (M)
在 2022/1/25 20:46, Andrew Jones 写道: On Tue, Jan 25, 2022 at 07:46:43PM +0800, chenxiang (M) wrote: Hi Andrew, 在 2022/1/25 18:26, Andrew Jones 写道: On Tue, Jan 25, 2022 at 05:15:34PM +0800, chenxiang via wrote: From: Xiang Chen Since the patchset ("Build ACPI Heterogeneous Memory

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 1:38 PM, Dr. David Alan Gilbert > wrote: > > * Jag Raman (jag.ra...@oracle.com) wrote: >> >> >>> On Jan 19, 2022, at 7:12 PM, Michael S. Tsirkin wrote: >>> >>> On Wed, Jan 19, 2022 at 04:41:52PM -0500, Jagannathan Raman wrote: Allow PCI buses to be part of

[PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-01-25 Thread Gavin Shan
The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() when it isn't provided explicitly. However, the CPU topology isn't fully considered in the default association and it causes CPU topology broken warnings on booting Linux guest. For example, the following warning

Re: [PATCH v5 00/18] vfio-user server in QEMU

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 11:00 AM, Stefan Hajnoczi wrote: > > Hi Jag, > Thanks for this latest revision. The biggest outstanding question I have > is about the isolated address spaces design. Thank you for taking the time to review the patches, Stefan! > > This patch series needs a PCIBus with

Re: [PATCH v5 18/18] vfio-user: avocado tests for vfio-user

2022-01-25 Thread Philippe Mathieu-Daudé via
Hi Jagannathan, On 19/1/22 22:42, Jagannathan Raman wrote: Avocado tests for libvfio-user in QEMU - tests startup, hotplug and migration of the server object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- MAINTAINERS| 1

Re: [PATCH v5 12/18] vfio-user: run vfio-user context

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 10:10 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:42:01PM -0500, Jagannathan Raman wrote: >> Setup a handler to run vfio-user context. The context is driven by >> messages to the file descriptor associated with it - get the fd for >> the context and hook up

Re: [PATCH v5 11/18] vfio-user: find and init PCI device

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 9:48 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:42:00PM -0500, Jagannathan Raman wrote: >> Find the PCI device with specified id. Initialize the device context >> with the QEMU PCI device >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G

[PATCH] hw/sd: Correct CMD58's R3 response "in idle state" bit in SPI-mode

2022-01-25 Thread frank . chang
From: Frank Chang In SPI-mode, CMD58 returns R3 response with the format: 39 32 31 0 ++ +---+ | R1 | |OCR| ++ +---+ Where R1

[PATCH v2 01/38] target/ppc: Introduce TRANS*FLAGS macros

2022-01-25 Thread matheus . ferst
From: Luis Pires New macros that add FLAGS and FLAGS2 checking were added for both TRANS and TRANS64. Signed-off-by: Luis Pires [ferst: - TRANS_FLAGS2 instead of TRANS_FLAGS_E - Use the new macros in load/store vector insns ] Signed-off-by: Matheus Ferst Reviewed-by: Richard Henderson

[PATCH v2 00/38] target/ppc: PowerISA Vector/VSX instruction batch

2022-01-25 Thread matheus . ferst
From: Matheus Ferst This patch series implements 5 missing instructions from PowerISA v3.0 and 40 new instructions from PowerISA v3.1, moving 62 other instructions to decodetree along the way. v2: - New patch (30) to remove xscmpnedp Lucas Coutinho (2): target/ppc: Move vexts[bhw]2[wd] to

[PATCH v2 10/38] target/ppc: Move Vector Compare Not Equal or Zero to decodetree

2022-01-25 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 9 ++-- target/ppc/insn32.decode| 4 ++ target/ppc/int_helper.c | 50 + target/ppc/translate/vmx-impl.c.inc | 69 +++--

[PATCH v2 02/38] target/ppc: moved vector even and odd multiplication to decodetree

2022-01-25 Thread matheus . ferst
From: "Lucas Mateus Castro (alqotel)" Moved the instructions vmulesb, vmulosb, vmuleub, vmuloub, vmulesh, vmulosh, vmuleuh, vmulouh, vmulesw, vmulosw, muleuw and vmulouw from legacy to decodetree. Implemented the instructions vmulesd, vmulosd, vmuleud, vmuloud. Signed-off-by: Lucas Mateus

Re: Raspberry Pi?

2022-01-25 Thread Philippe Mathieu-Daudé via
Hi, On 26/1/22 00:59, Kenneth Adam Miller wrote: Hello all, I would like to emulate something on a pi so that I don't have to pay as high of a translation penalty since the guest and host will share the same arch. I'm finding that on some forums that people have been having trouble getting

[PATCH v2 03/38] target/ppc: Moved vector multiply high and low to decodetree

2022-01-25 Thread matheus . ferst
From: "Lucas Mateus Castro (alqotel)" Moved instructions vmulld, vmulhuw, vmulhsw, vmulhud and vmulhsd to decodetree Signed-off-by: Lucas Mateus Castro (alqotel) Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 8 target/ppc/insn32.decode| 6

[PATCH v2 30/38] target/ppc: Remove xscmpnedp instruction

2022-01-25 Thread matheus . ferst
From: Víctor Colombo xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. Signed-off-by: Víctor Colombo Acked-by: Greg Kurz Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Signed-off-by: Matheus

[PATCH v2 35/38] target/ppc: Move xs{max, min}[cj]dp to use do_helper_XX3

2022-01-25 Thread matheus . ferst
From: Víctor Colombo Also, fixes these instructions not being capitalized. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 8 target/ppc/helper.h | 8 target/ppc/translate/vsx-impl.c.inc | 30

[PATCH v2 36/38] target/ppc: Refactor VSX_MAX_MINC helper

2022-01-25 Thread matheus . ferst
From: Víctor Colombo Refactor xs{max,min}cdp VSX_MAX_MINC helper to prepare for xs{max,min}cqp implementation. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git

[PATCH v2 37/38] target/ppc: Implement xs{max,min}cqp

2022-01-25 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 2 ++ target/ppc/helper.h | 2 ++ target/ppc/insn32.decode| 3 +++ target/ppc/translate/vsx-impl.c.inc | 2 ++ 4 files changed, 9 insertions(+)

[PATCH v2 38/38] target/ppc: Implement xvcvbf16spn and xvcvspbf16 instructions

2022-01-25 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 21 +++ target/ppc/helper.h | 1 + target/ppc/insn32.decode| 11 +++--- target/ppc/translate/vsx-impl.c.inc | 31

Re: [PATCH] hw/misc/macio/cuda: Simplify using the ldst API

2022-01-25 Thread Matheus K. Ferst
On 24/01/2022 20:13, Philippe Mathieu-Daudé via wrote: This code is easier to review using the load/store API. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/macio/cuda.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Matheus Ferst -- Matheus K. Ferst

Re: [PATCH v2] target/riscv: Enable bitmanip Zicbo[m,z,p] instructions

2022-01-25 Thread Richard Henderson
On 1/25/22 1:00 AM, Christoph Muellner wrote: -ori . 110 . 0010011 @i +{ + [ +# *** RV32 Zicbop Sandard Extension (hints in the ori-space) *** +prefetch_i ... 0 . 110 0 0010011 @cbo_pref +prefetch_r ... 1 . 110 0

Raspberry Pi?

2022-01-25 Thread Kenneth Adam Miller
Hello all, I would like to emulate something on a pi so that I don't have to pay as high of a translation penalty since the guest and host will share the same arch. I'm finding that on some forums that people have been having trouble getting QEMU to run on raspberry pi. The posts are kind of old,

Re: [PATCH v4 00/42] CXl 2.0 emulation Support

2022-01-25 Thread Ben Widawsky
On 22-01-25 11:18:08, Ben Widawsky wrote: > Really awesome work Jonathan. Dan and I are wrapping up some of the kernel > bits, > so all I'll do for now is try to run this, but I hope to be able to review the > parts I'm familiar with at least. > > On 22-01-24 17:16:23, Jonathan Cameron wrote: >

Re: [PATCH 0/2] RISC-V: Correctly generate store/amo faults

2022-01-25 Thread Richard Henderson
On 1/24/22 4:17 PM, LIU Zhiwei wrote: On 2022/1/24 上午8:59, Alistair Francis wrote: From: Alistair Francis This series adds a MO_ op to specify that a load instruction should produce a store fault. This is used on RISC-V to produce a store/amo fault when an atomic access fails. Hi Alistair,

Re: [PATCH 2/2] target/arm: Bail out early on 0-length tlb range invalidate

2022-01-25 Thread Richard Henderson
On 1/26/22 9:06 AM, Peter Maydell wrote: On Tue, 25 Jan 2022 at 22:05, Richard Henderson wrote: On 1/11/22 3:47 AM, Idan Horowitz wrote: If the given range specifies no addresses to be flushed there's no reason to schedule a function on all CPUs that does nothing. Signed-off-by: Idan

Re: [PATCH v4 29/42] hw/cxl/host: Add support for CXL Fixed Memory Windows.

2022-01-25 Thread Alex Bennée
Jonathan Cameron writes: > On Tue, 25 Jan 2022 17:02:32 + > Alex Bennée wrote: > >> Jonathan Cameron writes: >> >> > From: Jonathan Cameron >> > >> > The concept of these is introduced in [1] in terms of the >> > description the CEDT ACPI table. The principal is more general. >> >

Re: [Q] arm: SVE accesses at EL0 is broken with E2H+TGE?

2022-01-25 Thread Richard Henderson
On 1/13/22 2:03 PM, Zenghui Yu wrote: Hi, I've just exercised the SVE emulation in QEMU with | `qemu-system-aarch64 -M virt,virtualization=on,gic-version=3 \ |  -cpu max -accel tcg [...]` Since QEMU sets ID_AA64MMFR1_EL1.VH for -cpu max, the Linux guest I use was booting with VHE enabled and

[PATCH v5 4/7] meson: generate trace events for qmp commands

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
1. Use --add-trace-events when generate qmp commands 2. Add corresponding .trace-events files as outputs in qapi_files custom target 3. Define global qapi_trace_events list of .trace-events file targets, to fill in trace/qapi.build and to use in trace/meson.build 4. In trace/meson.build use

Re: [PATCH 2/2] target/arm: Bail out early on 0-length tlb range invalidate

2022-01-25 Thread Peter Maydell
On Tue, 25 Jan 2022 at 22:05, Richard Henderson wrote: > > On 1/11/22 3:47 AM, Idan Horowitz wrote: > > If the given range specifies no addresses to be flushed there's no reason > > to schedule a function on all CPUs that does nothing. > > > > Signed-off-by: Idan Horowitz > > --- > >

[PATCH v5 7/7] qapi: generate trace events by default

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
We don't generate trace events for tests/ and qga/ because that it is not simple and not necessary. We have corresponding comments in both tests/meson.build and qga/meson.build. Still to not miss possible future qapi code generation call, and not to forget to enable trace events generation, let's

Re: [PATCH 2/2] target/arm: Bail out early on 0-length tlb range invalidate

2022-01-25 Thread Richard Henderson
On 1/11/22 3:47 AM, Idan Horowitz wrote: If the given range specifies no addresses to be flushed there's no reason to schedule a function on all CPUs that does nothing. Signed-off-by: Idan Horowitz --- target/arm/helper.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v5 2/7] qapi/commands: refactor error handling code

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
Move error_propagate() to if (err) and make "if (err)" block mandatory. This is to simplify further commit, which will bring trace events generation for QMP commands. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/devel/qapi-code-gen.rst | 2 +- scripts/qapi/commands.py | 10

[PATCH v5 5/7] docs/qapi-code-gen: update to cover trace events code generation

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
Previous commits enabled trace events generation for most of QAPI generated code (except for tests/ and qga/). Let's update documentation to illustrate it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/devel/qapi-code-gen.rst | 21 - 1 file changed, 20 insertions(+),

[PATCH v5 3/7] qapi/commands: Optionally generate trace for QMP commands

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
Add trace generation disabled by default and new option --gen-trace to enable it. The next commit will enable it for qapi/, but not for qga/ and tests/. Making it work for the latter two would involve some Meson hackery to ensure we generate the trace-events files before trace-tool uses them.

[PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
We are going to generate trace events for QMP commands. We should generate both trace_*() function calls and trace-events files listing events for trace generator. So, add an output module FOO.trace-events for each FOO schema module. Since we're going to add trace events only to command

[PATCH v5 0/7] trace qmp commands

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
This series aims to add trace points for each qmp command with help of qapi code generator. v5: small fixes and rewordings, + reshuffle patches so that main meson change now is like in v3 and Paolo's a-b make sense again. 01: - fix/reword commit message - fix typing in qapi/gen.py -

[PATCH v5 6/7] meson: document, why we don't generate trace events for tests/ and qga/

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
Making trace generation work for tests/ and qga/ would involve some Meson hackery to ensure we generate the trace-events files before trace-tool uses them. Since we don't actually support tracing there anyway, we bypass that problem. Let's add corresponding comments. Signed-off-by: Vladimir

Re: [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush

2022-01-25 Thread Richard Henderson
On 1/11/22 3:47 AM, Idan Horowitz wrote: +/* + * If the length is larger than the jump cache size, then it will take + * longer to clear each entry individually than it will to clear it all. + */ +if (d.len >= (TARGET_PAGE_SIZE * TB_JMP_CACHE_SIZE)) { +

Re: [PATCH v2 2/2] target/riscv: Add XVentanaCondOps custom extension

2022-01-25 Thread Richard Henderson
On 1/14/22 7:20 AM, Philipp Tomsich wrote: new file mode 100644 index 00..b8a5d031b5 --- /dev/null +++ b/target/riscv/insn_trans/trans_xventanacondops.inc The filename suffix should be ".c.inc". +static bool gen_condmask(DisasContext *ctx, arg_r *a, TCGCond cond) +{ +TCGv dest =

Re: [PATCH v1 08/22] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
24.01.2022 23:15, Alex Bennée wrote: From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop

Re: [PATCH v2 1/2] target/riscv: iterate over a table of decoders

2022-01-25 Thread Richard Henderson
On 1/14/22 7:20 AM, Philipp Tomsich wrote: +static inline bool always_true_p(CPURISCVState *env __attribute__((__unused__)), + DisasContext *ctx __attribute__((__unused__))) +{ +return true; +} Drop the inline; the function will be instantiated so that

Re: [PATCH v5 07/18] vfio-user: set qdev bus callbacks for remote machine

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:44 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:56PM -0500, Jagannathan Raman wrote: >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >> hw/remote/machine.c | 57

Re: [PATCH] target/ppc: Put do_rfi under a TCG-only block

2022-01-25 Thread Daniel Henrique Barboza
On 1/24/22 16:15, Fabiano Rosas wrote: The --disable-tcg build broke when do_rfi stopped being inlined. Fixes: 62e79ef914 ("target/ppc: Remove static inline") Signed-off-by: Fabiano Rosas --- Reviewed-by: Daniel Henrique Barboza target/ppc/excp_helper.c | 2 -- 1 file changed, 2

Re: [PATCH] cpuid: use unsigned for max cpuid

2022-01-25 Thread Philippe Mathieu-Daudé via
On 25/1/22 20:24, Michael S. Tsirkin wrote: __get_cpuid_max returns an unsigned value. For consistency, store the result in an unsigned variable. Found by running ./configure --extra-cflags=-Wconversion Cc: Paolo Bonzini Cc: Richard Henderson Signed-off-by: Michael S. Tsirkin --- Richard,

Re: [PATCH v4 12/12] KVM: Expose KVM_MEM_PRIVATE

2022-01-25 Thread Maciej S. Szmigiero
On 18.01.2022 14:21, Chao Peng wrote: KVM_MEM_PRIVATE is not exposed by default but architecture code can turn on it by implementing kvm_arch_private_memory_supported(). Also private memslot cannot be movable and the same file+offset can not be mapped into different GFNs. Signed-off-by: Yu

[PATCH] cpuid: use unsigned for max cpuid

2022-01-25 Thread Michael S. Tsirkin
__get_cpuid_max returns an unsigned value. For consistency, store the result in an unsigned variable. Found by running ./configure --extra-cflags=-Wconversion Cc: Paolo Bonzini Cc: Richard Henderson Signed-off-by: Michael S. Tsirkin --- Richard, if appropriate pls queue this. Thanks!

Re: [PATCH v4 00/42] CXl 2.0 emulation Support

2022-01-25 Thread Ben Widawsky
Really awesome work Jonathan. Dan and I are wrapping up some of the kernel bits, so all I'll do for now is try to run this, but I hope to be able to review the parts I'm familiar with at least. On 22-01-24 17:16:23, Jonathan Cameron wrote: > Previous version was RFC v3: CXL 2.0 Support. > No

Re: [PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-01-25 Thread Volker Rümelin
On Samstag, 22. Januar 2022 13:57:31 CET Volker Rümelin wrote: Replace open-coded buffer arithmetic with the new function audio_ring_posb(). That's the position in backward direction of a given point at a given distance. Signed-off-by: Volker Rümelin --- First of all, getting rid of all those

[PATCH] virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

2022-01-25 Thread Vivek Goyal
At the start, drop membership of all supplementary groups. This is not required. If we have membership of "root" supplementary group and when we switch uid/gid using setresuid/setsgid, we still retain membership of existing supplemntary groups. And that can allow some operations which are not

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-25 Thread Dr. David Alan Gilbert
* Jag Raman (jag.ra...@oracle.com) wrote: > > > > On Jan 19, 2022, at 7:12 PM, Michael S. Tsirkin wrote: > > > > On Wed, Jan 19, 2022 at 04:41:52PM -0500, Jagannathan Raman wrote: > >> Allow PCI buses to be part of isolated CPU address spaces. This has a > >> niche usage. > >> > >>

Re: [PATCH v4 31/42] hw/pci-host/gpex-acpi: Add support for dsdt construction for pxb-cxl

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 06:13:13PM +, Jonathan Cameron wrote: > On Tue, 25 Jan 2022 17:15:58 + > Alex Bennée wrote: > > > Jonathan Cameron writes: > > > > > This adds code to instantiate the slightly extended ACPI root port > > > description in DSDT as per the CXL 2.0 specification. >

Re: [PATCH v4 31/42] hw/pci-host/gpex-acpi: Add support for dsdt construction for pxb-cxl

2022-01-25 Thread Jonathan Cameron via
On Tue, 25 Jan 2022 17:15:58 + Alex Bennée wrote: > Jonathan Cameron writes: > > > This adds code to instantiate the slightly extended ACPI root port > > description in DSDT as per the CXL 2.0 specification. > > > > Basically a cut and paste job from the i386/pc code. > > This fails to

Re: [PATCH v5 06/18] vfio-user: add HotplugHandler for remote machine

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:32 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:55PM -0500, Jagannathan Raman wrote: >> Allow hotplugging of PCI(e) devices to remote machine >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >>

Re: [PATCH] gitlab: fall back to commit hash in qemu-setup filename

2022-01-25 Thread Philippe Mathieu-Daudé via
On 1/25/22 18:34, Stefan Hajnoczi wrote: > Personal repos may not have release tags (v6.0.0, v6.1.0, etc) and this > causes cross_system_build_job to fail when pretty-printing a unique > qemu-setup-*.exe name: > > version="$(git describe --match v[0-9]*)"; > ^^ fails

Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 10:24:49AM -0600, Eric DeVolder wrote: > Ani, > Thanks for the feedback! Inline responses below. > eric > > On 1/25/22 04:53, Ani Sinha wrote: > > > > > > On Mon, 24 Jan 2022, Eric DeVolder wrote: > > > > > This builds the ACPI ERST table to inform OSPM how to

Re: [PATCH] tests/9pfs: fix mkdir() being called twice

2022-01-25 Thread Christian Schoenebeck
On Dienstag, 25. Januar 2022 16:33:46 CET Greg Kurz wrote: > On Sat, 22 Jan 2022 20:12:16 +0100 > > Christian Schoenebeck wrote: > > The 9p test cases use mkdtemp() to create a temporary directory for > > running the 'local' 9p tests with real files/dirs. Unlike mktemp() > > which only generates

Re: [PATCH] gitlab: fall back to commit hash in qemu-setup filename

2022-01-25 Thread Greg Kurz
On Tue, 25 Jan 2022 17:34:54 + Stefan Hajnoczi wrote: > Personal repos may not have release tags (v6.0.0, v6.1.0, etc) and this > causes cross_system_build_job to fail when pretty-printing a unique > qemu-setup-*.exe name: > > version="$(git describe --match v[0-9]*)"; >

Re: [PATCH v4 29/42] hw/cxl/host: Add support for CXL Fixed Memory Windows.

2022-01-25 Thread Jonathan Cameron via
On Tue, 25 Jan 2022 17:02:32 + Alex Bennée wrote: > Jonathan Cameron writes: > > > From: Jonathan Cameron > > > > The concept of these is introduced in [1] in terms of the > > description the CEDT ACPI table. The principal is more general. > > Unlike once traffic hits the CXL root

[PATCH] gitlab: fall back to commit hash in qemu-setup filename

2022-01-25 Thread Stefan Hajnoczi
Personal repos may not have release tags (v6.0.0, v6.1.0, etc) and this causes cross_system_build_job to fail when pretty-printing a unique qemu-setup-*.exe name: version="$(git describe --match v[0-9]*)"; ^^ fails ^^^ mv -v qemu-setup*.exe

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-25 Thread Christian Schoenebeck
On Dienstag, 25. Januar 2022 12:08:21 CET Akihiko Odaki wrote: > On Tue, Jan 25, 2022 at 7:32 PM Peter Maydell wrote: > > On Tue, 25 Jan 2022 at 04:14, Akihiko Odaki wrote: > > > I'm neutral about the decision. I think QEMU should avoid using > > > Objective-C code except for interactions with

Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 10:32:45AM -0600, Eric DeVolder wrote: > Hi Michael, > Thanks for examining this! Inline response below. > eric > > On 1/25/22 06:05, Michael S. Tsirkin wrote: > > On Tue, Jan 25, 2022 at 04:23:49PM +0530, Ani Sinha wrote: > > > > > > > > > On Mon, 24 Jan 2022, Eric

[PATCH 0/1] migration: Remove unused and deprecated load_state_old

2022-01-25 Thread Juan Quintela
Based-on: <20220118104434.4117879-1-peter.mayd...@linaro.org> [PATCH] Remove unnecessary minimum_version_id_old fields After applying this patch, there is other use of load_state_old and minimum_version_id_old. As there already were deprecated, just remove them. Juan Quintela (1): migration:

Re: [PATCH v4 31/42] hw/pci-host/gpex-acpi: Add support for dsdt construction for pxb-cxl

2022-01-25 Thread Alex Bennée
Jonathan Cameron writes: > This adds code to instantiate the slightly extended ACPI root port > description in DSDT as per the CXL 2.0 specification. > > Basically a cut and paste job from the i386/pc code. This fails to build on all machines: FAILED: qemu-system-mips64el c++ -m64

Re: [PATCH] Remove unnecessary minimum_version_id_old fields

2022-01-25 Thread Juan Quintela
Peter Maydell wrote: > The migration code will not look at a VMStateDescription's > minimum_version_id_old field unless that VMSD has set the > load_state_old field to something non-NULL. (The purpose of > minimum_version_id_old is to specify what migration version is needed > for the code in

[PATCH 1/1] migration: Remove unused minimum_version_id_old and load_state_old

2022-01-25 Thread Juan Quintela
They were already deprecated and after ppc removal no users on the tree. RIP. Signed-off-by: Juan Quintela --- docs/devel/migration.rst| 7 +-- include/migration/vmstate.h | 2 -- migration/vmstate.c | 6 -- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git

Re: KVM call minutes for 2022-01-25

2022-01-25 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Today we have the KVM devel call. We discussed how to create machines > from QMP without needing to recompile QEMU. > > > Three different problems: > - startup QMP (*) > not discussed today > - one binary or two > not discussed today > - being able to create

Re: [PATCH v4 29/42] hw/cxl/host: Add support for CXL Fixed Memory Windows.

2022-01-25 Thread Alex Bennée
Jonathan Cameron writes: > From: Jonathan Cameron > > The concept of these is introduced in [1] in terms of the > description the CEDT ACPI table. The principal is more general. > Unlike once traffic hits the CXL root bridges, the host system > memory address routing is implementation defined

Re: [PATCH 3/3] hw/display/artist: rewrite vram access mode handling

2022-01-25 Thread Sven Schnelle
Gerd Hoffmann writes: > Hi, > >> +static void artist_vram_write4(ARTISTState *s, struct vram_buffer *buf, >> + uint32_t offset, uint32_t data) > >> +static int get_vram_offset(ARTISTState *s, struct vram_buffer *buf, >> + int pos, int

Re: KVM call minutes for 2022-01-25

2022-01-25 Thread Philippe Mathieu-Daudé via
On 25/1/22 17:39, Juan Quintela wrote: Hi Today we have the KVM devel call. We discussed how to create machines from QMP without needing to recompile QEMU. Three different problems: - startup QMP (*) not discussed today - one binary or two not discussed today - being able to create

Re: [PATCH v2] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-25 Thread Patrick Venture
On Tue, Jan 25, 2022 at 5:35 AM Igor Mammedov wrote: > On Mon, 24 Jan 2022 12:11:51 -0800 > Patrick Venture wrote: > > > This parameter is to be used in the processor_id lower 32-bit entry in > > the type 4 table. The upper 32-bits represent the features for the CPU. > > This patch leaves

KVM call for agenda for 2022-02-08

2022-01-25 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. For last week call, we already have one topic. - get QMP startup early People asked for Paolo and Daniel to discuss this, so I added them to this email. At the end of Monday I will send an email with the agenda or the

Re: [PATCH v6 04/33] block/export/fuse.c: allow writable exports to take RESIZE permission

2022-01-25 Thread Hanna Reitz
On 21.01.22 18:05, Emanuele Giuseppe Esposito wrote: Allow writable exports to get BLK_PERM_RESIZE permission from creation, in fuse_export_create(). In this way, there is no need to give the permission in fuse_do_truncate(), which might be run in an iothread. Permissions should be set only in

Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread David Hildenbrand
On 25.01.22 17:42, Philippe Mathieu-Daudé wrote: > On 25/1/22 15:54, Nico Boehr wrote: >> On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote: >>> I think you can actually just reuse in2_m2_64a, similar as we handle >>> SCKC >> >> I tried my SCK tests with your patch, it works just as well

Re: [PATCH v2 1/3] block/export/fuse: Extract fuse_fallocate_punch_hole()

2022-01-25 Thread Philippe Mathieu-Daudé via
On 1/25/22 12:10, Thomas Huth wrote: > On 24/01/2022 23.03, Philippe Mathieu-Daudé via wrote: >> Extract fuse_fallocate_punch_hole() to avoid #ifdef'ry >> mixed within if/else statement. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   block/export/fuse.c | 59

KVM call minutes for 2022-01-25

2022-01-25 Thread Juan Quintela
Hi Today we have the KVM devel call. We discussed how to create machines from QMP without needing to recompile QEMU. Three different problems: - startup QMP (*) not discussed today - one binary or two not discussed today - being able to create machines dynamically. everybody agrees

Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread Philippe Mathieu-Daudé via
On 25/1/22 15:54, Nico Boehr wrote: On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote: I think you can actually just reuse in2_m2_64a, similar as we handle SCKC I tried my SCK tests with your patch, it works just as well and seems much cleaner, thanks. Do you want to send this or

[PATCH v3] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-25 Thread Patrick Venture
This parameter is to be used in the processor_id entry in the type 4 table. This parameter is set as optional and if left will use the values from the CPU model. This enables hiding the host information from the guest and allowing AMD VMs to run pretending to be Intel for some userspace software

Re: [PATCH v4 00/42] CXl 2.0 emulation Support

2022-01-25 Thread Jonathan Cameron via
On Tue, 25 Jan 2022 13:55:29 + Alex Bennée wrote: Hi Alex, Thanks for taking a look so quickly! > Jonathan Cameron writes: > > > Previous version was RFC v3: CXL 2.0 Support. > > No longer an RFC as I would consider the vast majority of this > > to be ready for detailed review. There are

Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table

2022-01-25 Thread Eric DeVolder
Hi Michael, Thanks for examining this! Inline response below. eric On 1/25/22 06:05, Michael S. Tsirkin wrote: On Tue, Jan 25, 2022 at 04:23:49PM +0530, Ani Sinha wrote: On Mon, 24 Jan 2022, Eric DeVolder wrote: This builds the ACPI ERST table to inform OSPM how to communicate with the

Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table

2022-01-25 Thread Eric DeVolder
Ani, Thanks for the feedback! Inline responses below. eric On 1/25/22 04:53, Ani Sinha wrote: On Mon, 24 Jan 2022, Eric DeVolder wrote: This builds the ACPI ERST table to inform OSPM how to communicate with the acpi-erst device. Signed-off-by: Eric DeVolder --- hw/acpi/erst.c | 188

[PATCH] qemu-storage-daemon: Fix typo in vhost-user-blk help

2022-01-25 Thread Kevin Wolf
The syntax of the fd passing case misses the "addr.type=" key. Add it. Signed-off-by: Kevin Wolf --- storage-daemon/qemu-storage-daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-storage-daemon.c index

Re: [PATCH] docs: expand firmware descriptor to allow flash without NVRAM

2022-01-25 Thread Daniel P . Berrangé
On Tue, Jan 25, 2022 at 08:50:54AM +0100, Gerd Hoffmann wrote: > Hi, > > > > { 'struct' : 'FirmwareMappingFlash', > > > - 'data' : { 'executable' : 'FirmwareFlashFile', > > > - 'nvram-template' : 'FirmwareFlashFile' } } > > > + 'data' : { 'mode': 'FirmwareFlashMode', >

Re: [PATCH v5 12/18] vfio-user: run vfio-user context

2022-01-25 Thread Stefan Hajnoczi
On Wed, Jan 19, 2022 at 04:42:01PM -0500, Jagannathan Raman wrote: > Setup a handler to run vfio-user context. The context is driven by > messages to the file descriptor associated with it - get the fd for > the context and hook up the handler with it > > Signed-off-by: Elena Ufimtseva >

Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes

2022-01-25 Thread Daniel P . Berrangé
On Mon, Jan 24, 2022 at 02:50:39PM +0100, Markus Armbruster wrote: > Stefan Reiter writes: > > > Since the removal of the generic 'qmp_change' command, one can no longer > > replace > > the 'default' VNC display listen address at runtime (AFAIK). For our users > > who > > need to set up a

Re: [PATCH v5 00/18] vfio-user server in QEMU

2022-01-25 Thread Stefan Hajnoczi
Hi Jag, Thanks for this latest revision. The biggest outstanding question I have is about the isolated address spaces design. This patch series needs a PCIBus with its own Memory Space, I/O Space, and interrupts. That way a single QEMU process can host vfio-user servers that different VMs connect

Re: [PATCH v5 11/18] vfio-user: find and init PCI device

2022-01-25 Thread Stefan Hajnoczi
On Wed, Jan 19, 2022 at 04:42:00PM -0500, Jagannathan Raman wrote: > Find the PCI device with specified id. Initialize the device context > with the QEMU PCI device > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- >

Re: [PATCH 0/5] target/ppc: powerpc_excp improvements [BookS] (4/n)

2022-01-25 Thread Fabiano Rosas
Cédric Le Goater writes: > On 1/24/22 19:46, Fabiano Rosas wrote: >> This series splits the exception code for BookS CPUs: 970, POWER5+, >> POWER7, POWER8, POWER9, POWER10. After dealing with the 405, let's go >> back to something more familiar to give everyone a break. >> >> No upfront fixes

Re: [PATCH v5 10/18] vfio-user: instantiate vfio-user context

2022-01-25 Thread Stefan Hajnoczi
On Wed, Jan 19, 2022 at 04:41:59PM -0500, Jagannathan Raman wrote: > create a context with the vfio-user library to run a PCI device > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/remote/vfio-user-obj.c | 78

Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread Nico Boehr
On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote: > I think you can actually just reuse in2_m2_64a, similar as we handle > SCKC I tried my SCK tests with your patch, it works just as well and seems much cleaner, thanks. Do you want to send this or should I make a v2 and add you as

Re: [PATCH v5 05/18] qdev: unplug blocker for devices

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:27 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:54PM -0500, Jagannathan Raman wrote: >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >> include/hw/qdev-core.h | 5 + >>

Re: [PATCH v5 17/18] vfio-user: register handlers to facilitate migration

2022-01-25 Thread Stefan Hajnoczi
On Wed, Jan 19, 2022 at 04:42:06PM -0500, Jagannathan Raman wrote: > + * The client subsequetly asks the remote server for any data that subsequently > +static void vfu_mig_state_running(vfu_ctx_t *vfu_ctx) > +{ > +VfuObject *o = vfu_get_private(vfu_ctx); > +VfuObjectClass *k =

Fwd: BU Organization IC 6 Consulting Level Promotions

2022-01-25 Thread Paolo Bonzini
Hi! maybe theis was already discussed earlier, but anyway: do we already have an idea about whether (and if so how) BU "consulting" level associates will participate in the DE community? This will be more important as their ranks grow. Thanks, Paolo Forwarded Message

Re: [PATCH] tests/9pfs: fix mkdir() being called twice

2022-01-25 Thread Greg Kurz
On Sat, 22 Jan 2022 20:12:16 +0100 Christian Schoenebeck wrote: > The 9p test cases use mkdtemp() to create a temporary directory for > running the 'local' 9p tests with real files/dirs. Unlike mktemp() > which only generates a unique file name, mkdtemp() also creates the > directory, therefore

  1   2   3   >