Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver

nks, > Yuval > > On Wed, 7 Dec 2022 at 17:05, Claudio Fontana wrote: >> >> On 4/5/22 12:31, Marcel Apfelbaum wrote: >> > Hi Yuval, >> > Thank you for the changes. >> > >> > On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia >> > wrote: >

Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver

t; +} > + > if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) / >sizeof(struct cmd_handler)) { > rdma_error_report("Unsupported command"); > -- > 2.20.1 > cc-ing Peter and Philippe for a question: Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will have to wait a week or so. Reviewed by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH] hw/pvrdma: Some cosmetic fixes

+249,8 @@ static void init_dsr_dev_caps(PVRDMADev *dev) > { > struct pvrdma_device_shared_region *dsr; > > -if (dev->dsr_info.dsr == NULL) { > +if (!dev->dsr_info.dsr) { > +/* Buggy or malicious guest driver */ > rdma_error_report("Can't initialized DSR"); > return; > } > -- > 2.20.1 > cc: QEMU Trivial Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH] hw/pvrdma: Protect against buggy or malicious guest driver

> > rdma_pci_dma_unmap(pci_dev, dev->dsr_info.rsp, > - sizeof(union pvrdma_cmd_resp)); > + sizeof(union pvrdma_cmd_resp)); > > rdma_pci_dma_unmap(pci_dev, dev->dsr_info.dsr, > - sizeof(struc

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

l S. Tsirkin wrote: > > > > From: Marcel Apfelbaum > > > > > > > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > > > > As opposed to native PCIe hotplug, guests like Fedora 34 > > > > will not assign IO range to pcie

Re: [PULL 00/29] pc,pci,virtio: features, fixes

-sector.c:170:boot_sector_test: assertion > failed (signature == > > > > SIGNATURE): (0x == 0xdead) > > > > Makefile.mtest:368: recipe for target 'run-test-44' failed > > > > > > it might happen if VM is too slow > > > /* Wait at most 6

Re: [PATCH] MAINTAINERS: Add myself as reviewer of 'Machine core' API

t; --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 50435b8d2f5..b0a7bf36aa4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1617,6 +1617,7 @@ F: pc-bios/bios-microvm.bin > Machine core > M: Eduardo Habk

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

l S. Tsirkin wrote: > > > > From: Marcel Apfelbaum > > > > > > > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > > > > As opposed to native PCIe hotplug, guests like Fedora 34 > > > > will not assign IO range to pcie

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

Hi Michael, On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin wrote: > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > From: Marcel Apfelbaum > > > > > &

Re: [PATCH v2 0/2] enable fsdax rdma migration

dma: Try to register On-Demand Paging memory region > >migration/rdma: advise prefetch write for ODP region > > > > migration/rdma.c | 117 +---- > > migration/trace-events | 2 + > > 2 files changed, 98 insertions(+), 21 deletions(-) > > Series Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v2 1/2] migration/rdma: Try to register On-Demand Paging memory region

ase, we can try to register it with > > On-Demand Paging[1] like what rpma_mr_reg() does on rpma[2]. > > > > [1]: > > https://community.mellanox.com/s/article/understanding-on-demand-paging--odp-x > > [2]: http://pmem.io/rpma/manpages/v0.9.0/rpma_mr_reg.3 > > > > CC: Mar

Re: [PATCH 1/2] migration/rdma: Try to register On-Demand Paging memory region

Hi Zhijian, On Mon, Aug 23, 2021 at 4:41 AM lizhij...@fujitsu.com wrote: > > > > On 22/08/2021 16:53, Marcel Apfelbaum wrote: > > Hi > > > > On Sat, Jul 31, 2021 at 5:00 PM Li Zhijian wrote: > >> Previously, for the fsdax mem-backend-file, it w

Re: [PATCH 1/2] migration/rdma: Try to register On-Demand Paging memory region

Hi On Sat, Jul 31, 2021 at 5:00 PM Li Zhijian wrote: > > Previously, for the fsdax mem-backend-file, it will register failed with > Operation not supported. In this case, we can try to register it with > On-Demand Paging[1] like what rpma_mr_reg() does on rpma[2]. > > [1]: >

Re: [PATCH 2/2] migration/rdma: advise prefetch write for ODP region

*res) "Try to advise block %s prefetch write at %" PRIu32 "@0x%" PRIx64 > ": %s" > qemu_rdma_registration_handle_compress(int64_t length, int index, int64_t > offset) "Zapping zero chunk: %" PRId64 " bytes, index %d, offset %" PRId64 >

Re: [PATCH v2] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

Hi Daniel, On Mon, Aug 2, 2021 at 12:05 PM Daniel P. Berrangé wrote: > On Mon, Aug 02, 2021 at 12:00:57PM +0300, Marcel Apfelbaum wrote: > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > > As opposed to native PCIe hotplug, guests like Fedora 34 > > wil

[PATCH v2] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

stdio device_add e1000,bus=p1 In the Guest OS the respective pcie-root-port will have the IO range disabled. Fix it by setting the "reserve-io" hint capability of the pcie-root-ports so the firmware will allocate the IO range instead. Acked-by: Igor Mammedov Signed-off-by: Marcel

Re: [PATCH v2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2,12 @@ static void build_append_pci_bus_devices(Aml > *parent_scope, PCIBus *bus, > /* Notify about child bus events in any case */ > if (pcihp_bridge_en) { > QLIST_FOREACH(sec, >child, sibling) { > -int32_t devfn = sec->parent_dev->devfn; > - > if (pci_bus_is_root(sec)) { > continue; > } > > -aml_append(method, aml_name("^S%.02X.PCNT", devfn)); > +aml_append(method, aml_name("^S%.02X.PCNT", > +sec->parent_dev->devfn)); > } > } > > -- > 2.27.0 > > Thanks for fixing it! Reviewed-by: Marcel Apfelbaum Thanks, Marcel

[PATCH] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

t-ports so the firmware will allocate the IO range instead. Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/gen_pcie_root_port.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c index ec9907917e..20099a8ae3 100644 --

Re: [PULL 00/23] pc,pci,virtio: lots of new features

Hi, On Wed, Jul 14, 2021 at 11:33 PM Peter Maydell wrote: > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > The following changes since commit > 708f50199b59476ec4b45ebcdf171550086d6292: > > > > Merge remote-tracking branch > 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into

Re: [PATCH v6 5/6] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

Hi Igor, On Tue, Jul 13, 2021 at 10:59 AM Igor Mammedov wrote: > On Tue, 13 Jul 2021 02:42:04 +0200 > Julia Suvorova wrote: > > > Q35 has three different types of PCI devices hot-plug: PCIe Native, > > SHPC Native and ACPI hot-plug. This patch changes the default choice > > for cold-plugged

Re: [PATCH v6 2/6] hw/acpi/ich9: Enable ACPI PCI hot-plug

ia Suvorova > > Signed-off-by: Marcel Apfelbaum > > Reviewed-by: Igor Mammedov > > Reviewed-by: David Gibson > > Since it looks safe, however I think there are a couple of unnecessary > changes here: > > > [snip] > > @@ -103,6 +105,7 @@ s

Re: [PATCH v5 0/7] Use ACPI PCI hot-plug for Q35

Hi Julia, On Thu, Jun 17, 2021 at 10:07 PM Julia Suvorova wrote: > The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > I have tested

[PULL V2 3/3] pvrdma: Fix the ring init error flow (CVE-2021-3608)

Do not unmap uninitialized dma addresses. Fixes: CVE-2021-3608 Reviewed-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum Message-Id: <20210630115246.2178219-1-mar...@redhat.com> Tested-by: Yuval Shaia Reviewed-by: Yuval Shaia Reviewed-by: Ph

[PULL V2 0/3] PVRDMA queue

. Marcel Apfelbaum (3): hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582) pvrdma: Ensure correct input on ring init (CVE-2021-3607) pvrdma: Fix the ring init error flow (CVE-2021-3608) hw/rdma/vmw/pvrdma_cmd.c | 7

[PULL V2 2/3] pvrdma: Ensure correct input on ring init (CVE-2021-3607)

Check the guest passed a non zero page count for pvrdma device ring buffers. Fixes: CVE-2021-3607 Reported-by: VictorV (Kunlun Lab) Reviewed-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum Message-Id: <20210630114634.2168872-1-mar...@redhat.com> Reviewed-by: Yuval Shaia

[PULL V2 1/3] hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)

From: Marcel Apfelbaum Ensure mremap boundaries not trusting the guest kernel to pass the correct buffer length. Fixes: CVE-2021-3582 Reported-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum Message-Id: <20210616110600.20889-1-marcel.apf

Re: [Qemu-devel] [PULL 0/3] PVRDMA queue

Hi Peter, On Sun, Jul 4, 2021 at 8:28 PM Peter Maydell wrote: > On Sun, 4 Jul 2021 at 11:56, Marcel Apfelbaum > wrote: > > > > The following changes since commit > 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1: > > > > Merge remote-tracking branch 'remotes/kevin/

[PULL 1/3] hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)

From: Marcel Apfelbaum Ensure mremap boundaries not trusting the guest kernel to pass the correct buffer length. Fixes: CVE-2021-3582 Reported-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum Message-Id: <20210616110600.20889-1-marcel.apf

[PULL 2/3] pvrdma: Ensure correct input on ring init (CVE-2021-3607)

Check the guest passed a non zero page count for pvrdma device ring buffers. Fixes: CVE-2021-3607 Reported-by: VictorV (Kunlun Lab) Reviewed-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum Message-Id: <20210630114634.2168872-1-mar...@redhat.com> Reviewed-by: Yuval Shaia

[PULL 3/3] pvrdma: Fix the ring init error flow (CVE-2021-3608)

Do not unmap uninitialized dma addresses. Fixes: CVE-2021-3608 Reviewed-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum Message-Id: <20210630115246.2178219-1-mar...@redhat.com> Tested-by: Yuval Shaia Reviewed-by: Yuval Shaia Reviewed-by: Ph

[Qemu-devel] [PULL 0/3] PVRDMA queue

. Marcel Apfelbaum (3): hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582) pvrdma: Ensure correct input on ring init (CVE-2021-3607) pvrdma: Fix the ring init error flow (CVE-2021-3608) hw/rdma/vmw/pvrdma_cmd.c | 6

[PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)

Do not unmap uninitialized dma addresses. Fixes: CVE-2021-3608 Reviewed-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c

[PATCH] pvrdma: Ensure correct input on ring init (CVE-2021-3607)

Check the guest passed a non zero page count for pvrdma device ring buffers. Fixes: CVE-2021-3607 Reported-by: VictorV (Kunlun Lab) Reviewed-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/rdma

Re: [PATCH] hw/pci/pcie_port: Rename "enable-native-hotplug" property

nable-native-hotplug", PCIESlot, native_hotplug, > true), > +DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true), > DEFINE_PROP_END_OF_LIST() > }; > > -- > 2.30.2 > > Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v5 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Q35 has three different types of PCI devices hot-plug: PCIe Native, > SHPC Native and ACPI hot-plug. This patch changes the default choice > for cold-plugged bridges from PCIe Native to ACPI Hot-plug with > ability to use SHPC and PCIe

Re: [PATCH v5 5/7] bios-tables-test: Allow changes in DSDT ACPI tables

uot;tests/data/acpi/q35/DSDT.ipmibt", > +"tests/data/acpi/q35/DSDT.cphp", > +"tests/data/acpi/q35/DSDT.memhp", > +"tests/data/acpi/q35/DSDT.acpihmat", > +"tests/data/acpi/q35/DSDT.numamem", > +"tests/data/acpi/q35/DSDT.dimmpxm", > +"tests/data/acpi/q35/DSDT.nohpet", > -- > 2.30.2 > > Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v5 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

Enable native hot-plug on all hot-plugged bridges unless > > + * hot-plug is disabled on the slot. > > + */ > > +if (s->hotplug && > > +(s->native_hotplug || DEVICE(dev)->hotplugged)) { > > pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_SLTCAP, > > PCI_EXP_SLTCAP_HPS | > > PCI_EXP_SLTCAP_HPC); > > diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c > > index eb563ad435..a410111825 100644 > > --- a/hw/pci/pcie_port.c > > +++ b/hw/pci/pcie_port.c > > @@ -148,6 +148,7 @@ static Property pcie_slot_props[] = { > > DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0), > > DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0), > > DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true), > > +DEFINE_PROP_BOOL("enable-native-hotplug", PCIESlot, native_hotplug, > true), > > DEFINE_PROP_END_OF_LIST() > > }; > > > > -- > > 2.30.2 > > Looks good to me. I also like Igor's comment (rename native-hotplug), a patch on top is just fine. Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

atic bool bsel_is_set; > +Object *host = acpi_get_i386_pci_host(); > PCIBus *bus; > unsigned bsel_alloc = ACPI_PCIHP_BSEL_DEFAULT; > > @@ -111,7 +114,7 @@ static void acpi_set_pci_info(void) > } > bsel_is_set = true; > > -bus = find_i440fx(); /* TODO: Q35 support */ > +bus = PCI_HOST_BRIDGE(host)->bus; > if (bus) { > /* Scan all PCI buses. Set property to enable acpi based hotplug. > */ > pci_for_each_bus_depth_first(bus, acpi_set_bsel, NULL, > _alloc); > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 67753638e4..aa973aa746 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -299,7 +299,7 @@ static void acpi_get_misc_info(AcpiMiscInfo *info) > * Because of the PXB hosts we cannot simply query TYPE_PCI_HOST_BRIDGE. > * On i386 arch we only have two pci hosts, so we can look only for them. > */ > -static Object *acpi_get_i386_pci_host(void) > +Object *acpi_get_i386_pci_host(void) > { > PCIHostState *host; > > -- > 2.30.2 > > Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

(dsdt, pm->pcihp_io_base); > } > build_piix4_pci0_int(dsdt); > } else { > @@ -1450,6 +1455,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > } > build_q35_isa_bridge(dsdt); > build_isa_devices_aml(dsdt); > +if (pm->pcihp_bridge_en) { > +build_x86_acpi_pci_hotplug(dsdt, pm->pcihp_io_base); > +} > build_q35_pci0_int(dsdt); > if (pcms->smbus && !pcmc->do_not_add_smb_acpi) { > build_smb0(dsdt, pcms->smbus, ICH9_SMB_DEV, ICH9_SMB_FUNC); > @@ -1484,7 +1492,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > { > aml_append(scope, aml_name_decl("_HID", aml_string("ACPI0006"))); > > -if (misc->is_piix4 && (pm->pcihp_bridge_en || pm->pcihp_root_en)) > { > +if (pm->pcihp_bridge_en || pm->pcihp_root_en) { > method = aml_method("_E01", 0, AML_NOTSERIALIZED); > aml_append(method, > aml_acquire(aml_name("\\_SB.PCI0.BLCK"), 0x)); > -- > 2.30.2 > > Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v5 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

bus = find_i440fx(); > +bus = PCI_HOST_BRIDGE(host)->bus; > if (bus) { > /* setting the hotplug handler to NULL makes the bus > non-hotpluggable */ > qbus_set_hotplug_handler(BUS(bus), NULL); > -- > 2.30.2 > > Reviewed-by: Marcel Apfelbaum Thanks, Marcel

[PATCH] hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)

From: Marcel Apfelbaum Ensure mremap boundaries not trusting the guest kernel to pass the correct buffer length. Fixes: CVE-2021-3582 Reported-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 6 ++ 1 file changed, 6

Re: Adding pcie-root-port devices via QMP apparently isn't possible

Hi Thomas, On Tue, May 18, 2021 at 3:29 PM Thomas Parrott wrote: > > Due to QEMU moving towards a QMP configuration mechanism and away from config > file support, the LXD team are currently in the process of migrating to using > QMP to add devices to VMs (so that we can support the use of

Re: [PATCH v2 8/9] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE

Hi David, On Mon, Mar 8, 2021 at 10:45 AM David Hildenbrand wrote: > On 07.03.21 15:11, Marcel Apfelbaum wrote: > > Hi David, > > > > On Sun, Mar 7, 2021 at 3:18 PM David Hildenbrand > <mailto:da...@redhat.com>> wrote: > > > > On 05.03.21 16:

Re: [PATCH v2 8/9] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE

Hi David, On Sun, Mar 7, 2021 at 3:18 PM David Hildenbrand wrote: > On 05.03.21 16:51, Peter Xu wrote: > > On Fri, Mar 05, 2021 at 04:44:36PM +0100, David Hildenbrand wrote: > >> On 05.03.21 16:42, Peter Xu wrote: > >>> On Fri, Mar 05, 2021 at 11:16:33AM +0100, David Hildenbrand wrote: >

Re: [PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header

Hi Jason. On Tue, Feb 9, 2021 at 5:47 AM Jason Wang wrote: > > On 2021/2/9 上午1:28, Paolo Bonzini wrote: > > On 08/02/21 18:17, Cornelia Huck wrote: > >> On Fri, 29 Jan 2021 16:27:19 +0100 > >> Cornelia Huck wrote: > >> > >>> On Fri, 22 Jan 2021 19:00:29 +0100 > >>> Cornelia Huck wrote: > >>>

[Qemu-devel] [PULL 0/1] RDMA queue

The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging (2020-12-18 11:12:35 +) are available in the Git repository at: https://github.com/marcel-apf/qemu

[Qemu-devel] [PULL 1/1] contrib/rdmacm-mux: Fix error condition in hash_tbl_search_fd_by_ifid()

Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- contrib/rdmacm-mux/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c index bd82abbad3..771ca01e03 100644 --- a/contrib/rdmacm-mux/main.c +++ b/contrib/rdmacm-mux/

Re: [PATCH] contrib/rdmacm-mux: Fix error condition in hash_tbl_search_fd_by_ifid()

Hi Alex, On Wed, Nov 25, 2020 at 3:17 AM Alex Chen wrote: > On 2020/11/24 23:29, Peter Maydell wrote: > > On Tue, 24 Nov 2020 at 12:15, Alex Chen wrote: > >> > >> Hi everyone， > >> > >> Who can help me merge this patch into the master branch? This patch may > be need for qemu-5.2 > > > > This

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

Hi Michael, On Wed, Nov 11, 2020 at 2:35 PM Michael S. Tsirkin wrote: > On Thu, Oct 22, 2020 at 02:40:26PM +0300, Marcel Apfelbaum wrote: > > From: Marcel Apfelbaum > > > > During PCIe Root Port's transition from Power-Off to Power-ON (or > vice-versa) > > t

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

Hi Roman, On Wed, Nov 11, 2020 at 6:10 PM Roman Kagan wrote: > On Thu, Oct 22, 2020 at 02:40:26PM +0300, Marcel Apfelbaum wrote: > > From: Marcel Apfelbaum > > > > During PCIe Root Port's transition from Power-Off to Power-ON (or > vice-versa) > > the "Sl

Re: [PATCH 2/6] hw/rdma/rdma_backend: fix uninitialized variable warning in rdma_poll_cq()

quot;%s: " fmt, "rdma", ## __VA_ARGS__) > | ^~~~ > hw/rdma/rdma_backend.c:93:12: note: ‘ne’ was declared here > 93 | int i, ne, total_ne = 0; > |^~ > > Add a default value for 'ne' to prevented the warning. > > Reported-by: Euler Robot > Signed-off

Re: [PATCH] contrib/rdmacm-mux: Fix error condition in hash_tbl_search_fd_by_ifid()

nd matching for ifid 0x%llx\n", > *gid_ifid); > return -ENOENT; > } > -- > 2.19.1 > > Reviewed-by: Marcel Apfelbaum Thanks for the fix, Marcel

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

Hi David, On Fri, Oct 23, 2020 at 6:49 AM David Gibson wrote: > On Thu, 22 Oct 2020 11:01:04 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Oct 22, 2020 at 05:50:51PM +0300, Marcel Apfelbaum wrote: > > [...] > > > > Right. After detectin

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

Hi Michael, On Thu, Oct 22, 2020 at 6:01 PM Michael S. Tsirkin wrote: > On Thu, Oct 22, 2020 at 05:50:51PM +0300, Marcel Apfelbaum wrote: > > > > > > On Thu, Oct 22, 2020 at 5:33 PM Michael S. Tsirkin > wrote: > > > > On Thu, Oct 22, 2020 at 05:1

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

On Thu, Oct 22, 2020 at 5:33 PM Michael S. Tsirkin wrote: > On Thu, Oct 22, 2020 at 05:10:43PM +0300, Marcel Apfelbaum wrote: > > > > > > On Thu, Oct 22, 2020 at 5:01 PM Michael S. Tsirkin > wrote: > > > > On Thu, Oct 22, 2020 at 04:55:10PM +0300, Marcel

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

On Thu, Oct 22, 2020 at 5:01 PM Michael S. Tsirkin wrote: > On Thu, Oct 22, 2020 at 04:55:10PM +0300, Marcel Apfelbaum wrote: > > Hi David, Michael, > > > > On Thu, Oct 22, 2020 at 3:56 PM David Gibson wrote: > > > > On Thu, 22 Oct 2020 08:06:55 -0400 &g

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

Hi David, Michael, On Thu, Oct 22, 2020 at 3:56 PM David Gibson wrote: > On Thu, 22 Oct 2020 08:06:55 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Oct 22, 2020 at 02:40:26PM +0300, Marcel Apfelbaum wrote: > > > From: Marcel Apfelbaum > > > &g

[PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

From: Marcel Apfelbaum During PCIe Root Port's transition from Power-Off to Power-ON (or vice-versa) the "Slot Control Register" has the "Power Indicator Control" set to "Blinking" expressing a "power transition" mode. Any hotplug operation during the

Re: [PATCH v2 2/2] hw/pci/pcie: Replace PCI_DEVICE() casts with existing variable

; } -pcie_cap_slot_push_attention_button(PCI_DEVICE(hotplug_dev)); +pcie_cap_slot_push_attention_button(hotplug_pdev); } /* pci express slot for pci express root/downstream port Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v2 1/2] hw/pci/pcie: Forbid hot-plug if it's disabled on the slot

CI_DEVICE(hotplug_dev), dev, _err); if (local_err) { Reviewed-by: Marcel Apfelbaum Thanks, Marcel

[Qemu-devel] [PULL 0/1] RDMA queue

The following changes since commit 1c47613588ccff44422d4bdeea0dc36a0a308ec7: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-04-30 19:25:41 +0100) are available in the Git repository at: https://github.com/marcel-apf/qemu tags/rdma-pull-request for you to

[Qemu-devel] [PULL 1/1] hw/rdma: Destroy list mutex when list is destroyed

From: Yuval Shaia List mutex should be destroyed when gs list gets destroyed. Reported-by: Peter Maydell Signed-off-by: Yuval Shaia Message-Id: <20200413085738.11145-1-yuval.shaia...@gmail.com> Reviewed-by: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_utils.c |

Re: [PATCH v2] lockable: Replace locks with lock guard macros

Hi Julia, On 4/19/20 5:46 AM, Julia Suvorova wrote: On Sat, Apr 18, 2020 at 2:03 PM Marcel Apfelbaum wrote: Hi Simran, On 4/2/20 9:50 AM, Simran Singhal wrote: Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal

Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

Hi Ani, On 4/18/20 6:25 AM, Ani Sinha wrote: +Julia who implemented https://patchwork.kernel.org/patch/1131/ On Apr 18, 2020, at 3:26 AM, Laine Stump wrote: On 4/17/20 12:35 PM, Ani Sinha wrote: +Laine On Apr 17, 2020, at 9:39 PM, Michael S. Tsirkin wrote: Problem is, I think this

Re: [PATCH v2] lockable: Replace locks with lock guard macros

Hi Simran, On 4/2/20 9:50 AM, Simran Singhal wrote: Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- Changes in v2: -Drop changes in file hw/rdma/rdma_utils.c hw/hyperv/hyperv.c | 15

Re: [PATCH v2] lockable: Replace locks with lock guard macros

ame, handle); -qemu_mutex_lock(>lock); +QEMU_LOCK_GUARD(>lock); if (handle < tbl->tbl_sz) { clear_bit(handle, tbl->bitmap); tbl->used--; } -qemu_mutex_unlock(>lock); } int rdma_rm_alloc_pd(RdmaDeviceResources *dev_res, RdmaBackendDev *backend_dev, Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH] hw/rdma: Destroy list mutex when list is destroyed

;list = NULL; } } Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH] hw/pci/pcie: Forbid hot-plug via QMP if it's disabled on the slot

Hi Julia, On 4/7/20 5:50 PM, Julia Suvorova wrote: Raise an error when trying to hot-plug/unplug a device through QMP to a device with disabled hot-plug capability. This makes the device behaviour more consistent and provides an explanation of the failure in the case of asynchronous unplug.

Re: [PATCH] hw/rdma: Lock before destroy

Hi Peter,Yuval On 3/24/20 1:05 PM, Peter Maydell wrote: On Tue, 24 Mar 2020 at 10:54, Yuval Shaia wrote: To protect from the case that users of the protected_qlist are still using the qlist let's lock before detsroying it. Reported-by: Coverity (CID 1421951) Signed-off-by: Yuval Shaia ---

[Qemu-devel] [PATCH PULL 4/4] hw/rdma: avoid suspicious strncpy() use

Shaia Message-Id: <20200316160702.478964-3-stefa...@redhat.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_dev_ring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b/hw/rdma/vmw/pvrdma_dev_ring.c index c2b3dd70a9..c122fe7035 100644 --- a/hw/rd

[Qemu-devel] [PATCH PULL 2/4] hw/rdma: Cosmetic change - no need for two sge arrays

Apfelbaum Message-Id: <20200320143429.9490-2-yuval.shaia...@gmail.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c

[Qemu-devel] [PATCH PULL 1/4] hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy

Reviewed-by: Yuval Shaia Reviewed-by: Stefan Hajnoczi Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b/hw/rdma/vmw/pvrdma_dev_ring.c index d7bc7f5ccc..c2b3dd70a9 100644 --- a/hw

[Qemu-devel] [PATCH PULL 0/4] RDMA queue

The following changes since commit 52a96afaa23d883d281bc7b95b9e69db7d6d3d3f: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-20 16:00:21 +) are available in the Git repository at: https://github.com/marcel-apf/qemu

[Qemu-devel] [PATCH PULL 3/4] hw/rdma: Skip data-path mr_id translation

a cosmetic change to make the code cleaner - make one copy of the function rdma_backend_create_mr and leave the redundant guest_start argument in the legacy code. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Message-Id: <20200320143429.9490-3-yuval.shaia...@gmail.com> Signe

Re: [PATCH 2/2] hw/rdma: avoid suspicious strncpy() use

Hi Stefan, On 3/20/20 1:55 PM, Yuval Shaia wrote: On Mon, 16 Mar 2020 at 18:07, Stefan Hajnoczi > wrote: gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled reports the following error:   CC     

Re: [PATCH v1 2/2] hw/rdma: Skip data-path mr_id translation

nd_mr); +#endif } -/* We keep mr_handle in lkey so send and recv get get mr ptr */ -*lkey = *mr_handle; *rkey = -1; mr->pd_handle = pd_handle; Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH v1 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

-wr.sg_list = new_sge; +wr.sg_list = sge; wr.wr_id = bctx_id; rc = ibv_post_srq_recv(srq->ibsrq, , _wr); if (rc) { Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH 2/2] hw/rdma: Skip data-path mr_id translation

_handle; +#else +*lkey = rdma_backend_mr_lkey(>backend_mr); +#endif } -/* We keep mr_handle in lkey so send and recv get get mr ptr */ -*lkey = *mr_handle; *rkey = -1; mr->pd_handle = pd_handle; Reviewed-by: Marcel Apfelbaum Thanks, Marcel

Re: [PATCH 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

Hi Yuval, On 3/7/20 2:56 PM, Yuval Shaia wrote: The function build_host_sge_array uses two sge arrays, one for input and one for output. Since the size of the two arrays is the same, the function can write directly to the given source array (i.e. input/output argument). Signed-off-by: Yuval

Re: [PATCH] MAINTAINERS: Update Yuval Shaia's email address

Hi Laurent, On 12/19/19 11:46 AM, Laurent Vivier wrote: Le 18/12/2019 à 20:50, Marcel Apfelbaum a écrit : On 11/26/19 12:26 PM, Yuval Shaia wrote: Use gmail account for maintainer tasks. Signed-off-by: Yuval Shaia ---   MAINTAINERS | 2 +-   1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] MAINTAINERS: Update Yuval Shaia's email address

/MAINTAINERS @@ -2640,7 +2640,7 @@ F: tests/test-replication.c F: docs/block-replication.txt PVRDMA -M: Yuval Shaia +M: Yuval Shaia M: Marcel Apfelbaum S: Maintained F: hw/rdma/* Hi, Can someone grab this patch ? Thanks, Marcel

[Qemu-devel] [PATCH PULL 0/2] RDMA queue

The following changes since commit 412fbef3d076c43e56451bacb28c4544858c66a3: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging (2019-11-05 20:17:11 +) are available in the Git repository at: https://github.com/marcel-apf/qemu

[Qemu-devel] [PATCH PULL 2/2] hw/rdma: Utilize ibv_reg_mr_iova for memory registration

-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Message-Id: <20190818132107.18181-3-yuval.sh...@oracle.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c| 13 + hw/rdma/rdma_backend.h| 5 + hw/rdma/rdma_rm.c | 5 + hw/rdma/vmw/pvrdma_

[Qemu-devel] [PATCH PULL 1/2] configure: Check if we can use ibv_reg_mr_iova

From: Yuval Shaia The function reg_mr_iova is an enhanced version of ibv_reg_mr function that can help to easly register and use guest's MRs. Add check in 'configure' phase to detect if we have libibverbs with this support. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Message-Id

Re: [PATCH 0/2] rdma: Utilize ibv_reg_mr_iova for memory registration

Hi Yuval, On 8/18/19 4:21 PM, Yuval Shaia wrote: The virtual address that is provided by the guest in post_send and post_recv operations is related to the guest address space. This address space is unknown to the HCA resides on host so extra step in these operations is needed to adjust the

Re: [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate

Hi Julia, On 8/27/19 5:58 PM, Julia Suvorova wrote: On Mon, 2018-09-17 at 22:57 +0800, Zihan Yang wrote: Hi all Here is a minimal working version of supporting multiple pci domains. Hi Zihan, Do you plan to continue working on this project? Since the last submission was long ago we can

Re: [Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

device in the source host. pvrdma_post_load() maps to dsr using the loaded dma address, registers each loaded gid into the backend device, and finally calls load_dsr() to perform other mappings and ring init operations. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar

Re: [Qemu-devel] [PATCH v1 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr()

out of load_dsr() and call it before the latter as and when needed. This aids the case where load_dsr() is called having DSR mapping already done, but the rest of map and init operations are pending, and prevents an unmap of the DSR. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatna

Re: [Qemu-devel] [PATCH v1 0/2] Add live migration support in the PVRDMA device

Hi Sukrit, On 8/28/19 5:23 PM, Sukrit Bhatnagar wrote: This series enables the migration of various GIDs used by the device. This is in addition to the successful migration of PCI and MSIX states as well as various DMA addresses and ring page information. We have a setup having two hosts

Re: [Qemu-devel] [PATCH 2/2] hw/rdma: Utilize ibv_reg_mr_iova for memory registration

Hi Yuval, On 8/18/19 4:21 PM, Yuval Shaia wrote: The virtual address that is provided by the guest in post_send and post_recv operations is related to the guest address space. This address space is unknown to the HCA resides on host so extra step in these operations is needed to adjust the

Re: [Qemu-devel] [PATCH 1/2] configure: Check if we can use ibv_reg_mr_iova

On 8/18/19 4:21 PM, Yuval Shaia wrote: The function reg_mr_iova is an enhanced version of ibv_reg_mr function that can help to easly register and use guest's MRs. Add check in 'configure' phase to detect if we have libibverbs with this support. Signed-off-by: Yuval Shaia --- configure |

Re: [Qemu-devel] [PATCH 0/2] rdma: Utilize ibv_reg_mr_iova for memory registration

Hi Yuval, On 8/18/19 4:21 PM, Yuval Shaia wrote: The virtual address that is provided by the guest in post_send and post_recv operations is related to the guest address space. This address space is unknown to the HCA resides on host so extra step in these operations is needed to adjust the

Re: [Qemu-devel] [PATCH] xio3130_downstream: typo fix

, slt_sta; -pcie_cap_slot_get(d, _sta, _ctl); +pcie_cap_slot_get(d, _ctl, _sta); pci_bridge_write_config(d, address, val, len); pcie_cap_flr_write_config(d, address, val, len); pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len); Reviewed-by: Marcel

Re: [Qemu-devel] [PATCH v2] pcie: consistent names for function args

uint32_t addr, uint32_t val, int len); int pcie_cap_slot_post_load(void *opaque, int version_id); void pcie_cap_slot_push_attention_button(PCIDevice *dev); Reviewed-by: Marcel Apfelbaum Thanks, Marcel

[Qemu-devel] [PATCH V2] hw/net: fix vmxnet3 live migration

SaveVMHandlers. Signed-off-by: Marcel Apfelbaum Tested-by: Sukrit Bhatnagar Reviewed-by: Dmitry Fleytman --- V1 -> V2: - Bump migration version (Dave) hw/net/vmxnet3.c | 56 1 file changed, 4 insertions(+), 52 deletions(-) diff --git a/hw/net/vmxn

Re: [Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device

On 7/8/19 12:38 PM, Daniel P. Berrangé wrote: On Sat, Jul 06, 2019 at 10:04:55PM +0300, Marcel Apfelbaum wrote: Hi Sukrit, On 7/6/19 7:09 AM, Sukrit Bhatnagar wrote: Changes in v2: * Modify load_dsr() such that dsr mapping is not performed if dsr value is non-NULL. Also move free_dsr

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

On 7/8/19 7:03 PM, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: On 7/5/19 2:14 PM, Sukrit Bhatnagar wrote: On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman wrote: On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: At some point vmxnet3 live migration

Re: [Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device

Hi Sukrit, On 7/6/19 7:09 AM, Sukrit Bhatnagar wrote: Changes in v2: * Modify load_dsr() such that dsr mapping is not performed if dsr value is non-NULL. Also move free_dsr() out of load_dsr() and call it right before if needed. These two changes will allow us to call load_dsr() even

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

On 7/5/19 2:14 PM, Sukrit Bhatnagar wrote: On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman wrote: On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: At some point vmxnet3 live migration stopped working and git-bisect didn't help finding a working version. The issue is the PCI configuration

[Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

SaveVMHandlers. Signed-off-by: Marcel Apfelbaum --- hw/net/vmxnet3.c | 52 ++-- 1 file changed, 2 insertions(+), 50 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 10d01d0058..8b17548b02 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c

  1   2   3   4   5   6   7   8   9   10   >