Re: [PATCH] qom: Check for wellformed id in user_creatable_add_type()

2021-03-08 Thread Kevin Wolf
Am 06.03.2021 um 11:50 hat Paolo Bonzini geschrieben: > On 02/03/21 18:16, Kevin Wolf wrote: > > Most code paths for creating a user creatable object go through > > QemuOpts, which ensures that the provided 'id' option is actually a > > valid identifier. > > > > However, there are some code paths

Re: [PATCH] qom: Check for wellformed id in user_creatable_add_type()

2021-03-06 Thread Paolo Bonzini
On 02/03/21 18:16, Kevin Wolf wrote: Most code paths for creating a user creatable object go through QemuOpts, which ensures that the provided 'id' option is actually a valid identifier. However, there are some code paths that don't go through QemuOpts: qemu-storage-daemon --object (since

Re: [PATCH] qom: Check for wellformed id in user_creatable_add_type()

2021-03-02 Thread Paolo Bonzini
On 02/03/21 18:16, Kevin Wolf wrote: Most code paths for creating a user creatable object go through QemuOpts, which ensures that the provided 'id' option is actually a valid identifier. However, there are some code paths that don't go through QemuOpts: qemu-storage-daemon --object (since

Re: [PATCH] qom: Check for wellformed id in user_creatable_add_type()

2021-03-02 Thread Eric Blake
On 3/2/21 11:16 AM, Kevin Wolf wrote: > Most code paths for creating a user creatable object go through > QemuOpts, which ensures that the provided 'id' option is actually a > valid identifier. > > However, there are some code paths that don't go through QemuOpts: > qemu-storage-daemon --object

[PATCH] qom: Check for wellformed id in user_creatable_add_type()

2021-03-02 Thread Kevin Wolf
Most code paths for creating a user creatable object go through QemuOpts, which ensures that the provided 'id' option is actually a valid identifier. However, there are some code paths that don't go through QemuOpts: qemu-storage-daemon --object (since commit 8db1efd3) and QMP object-add (since