On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
On 11/19/2014 05:38 PM, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 20/11/2014 01:58, Eduardo Habkost wrote:
if (pc_machine-vmport == VMPORT_AUTO) {
no_vmport = xen_enabled();
} else {
no_vmport = (pc_machine-vmport == VMPORT_ON);
}
I'm still not sure why the
On 20/11/2014 11:00, Dr. David Alan Gilbert wrote:
I'm still not sure why the configuration should differ for -M pc
depending on whether xen is enabled.
I think this goes back to:
commit 1611977c3d8fdbdac6090cbd1fcee4aed6d9
Author: Anthony PERARD anthony.per...@citrix.com
Date:
On Thu, Nov 20, 2014 at 12:00:19PM +0100, Paolo Bonzini wrote:
On 20/11/2014 11:00, Dr. David Alan Gilbert wrote:
I'm still not sure why the configuration should differ for -M pc
depending on whether xen is enabled.
I think this goes back to:
commit
On 11/19/14 19:58, Eduardo Habkost wrote:
On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
[...]
@@ -234,9 +235,33 @@ static void pc_init1(MachineState *machine,
pc_vga_init(isa_bus, pci_enabled ? pci_bus : NULL);
+if (xen_enabled()) {
+switch
On 11/20/14 01:04, Paolo Bonzini wrote:
On 20/11/2014 01:58, Eduardo Habkost wrote:
if (pc_machine-vmport == VMPORT_AUTO) {
no_vmport = xen_enabled();
} else {
no_vmport = (pc_machine-vmport == VMPORT_ON);
}
I'm still not sure why the configuration should
On 20/11/2014 16:07, Don Slutz wrote:
The key reason is that with current xen, if vmport is enabled QEMU will
crash:
Thanks, that helps understanding the patch. :)
Paolo
On 11/20/14 04:13, Michael S. Tsirkin wrote:
On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
On 11/19/2014 05:38 PM, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1()
On Thu, Nov 20, 2014 at 10:16:37AM -0500, Don Slutz wrote:
On 11/20/14 04:13, Michael S. Tsirkin wrote:
On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
[...]
+{ 'enum': 'vmport',
All other enums in .json files are named in StudlyCaps. Please name
this starting with a capital
On 11/20/14 06:00, Paolo Bonzini wrote:
On 20/11/2014 11:00, Dr. David Alan Gilbert wrote:
I'm still not sure why the configuration should differ for -M pc
depending on whether xen is enabled.
I think this goes back to:
commit 1611977c3d8fdbdac6090cbd1fcee4aed6d9
Author: Anthony PERARD
On 11/20/2014 01:44 AM, Michael S. Tsirkin wrote:
On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the
On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
[...]
@@ -234,9 +235,33 @@ static void pc_init1(MachineState *machine,
pc_vga_init(isa_bus, pci_enabled ? pci_bus : NULL);
+if (xen_enabled()) {
+switch (pc_machine-vmport) {
+case VMPORT_MAX:
+
On 11/19/2014 05:38 PM, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
On 20/11/2014 01:58, Eduardo Habkost wrote:
if (pc_machine-vmport == VMPORT_AUTO) {
no_vmport = xen_enabled();
} else {
no_vmport = (pc_machine-vmport == VMPORT_ON);
}
I'm still not sure why the configuration should differ for -M pc
depending on whether xen
16 matches
Mail list logo
