Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-11 Thread Lluís Vilanova
Richard Henderson writes: > On 07/07/2017 07:32 AM, Lluís Vilanova wrote: [...] >> I can restore the NULL approach or add a default empty hook implementation >> (translator_ignored_op?) if there's a strong feeling to change it. > Ok, we can work that out. I'm not sure what you mean. Leave as-is

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-07 Thread Richard Henderson
On 07/07/2017 07:32 AM, Lluís Vilanova wrote: That said, even for AArch32 we know by the TB flags whether or not we're going to be generating arm or thumb code. I think that these hooks will allow arm and thumb mode to finally be split apart cleanly, instead of the tangle that they are now. I

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-07 Thread Lluís Vilanova
Richard Henderson writes: > On 07/07/2017 01:18 AM, Lluís Vilanova wrote: diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9c870f6d07..586a01a2de 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11244,6 +11244,9 @@

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-07 Thread Lluís Vilanova
Emilio G Cota writes: > On Fri, Jul 07, 2017 at 05:46:19 -1000, Richard Henderson wrote: >> I do wonder if we should provide a generic empty hook, so that a target that >> does not need a particular hook need not define an empty function. It could >> just put e.g. "translator_noop" into the

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-07 Thread Emilio G. Cota
On Fri, Jul 07, 2017 at 05:46:19 -1000, Richard Henderson wrote: > I do wonder if we should provide a generic empty hook, so that a target that > does not need a particular hook need not define an empty function. It could > just put e.g. "translator_noop" into the structure. Ok, maybe a better

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-07 Thread Richard Henderson
On 07/07/2017 01:18 AM, Lluís Vilanova wrote: diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9c870f6d07..586a01a2de 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11244,6 +11244,9 @@ static void

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-07 Thread Lluís Vilanova
Richard Henderson writes: > On 06/28/2017 06:53 AM, Lluís Vilanova wrote: >> Incrementally paves the way towards using the generic instruction translation >> loop. >> >> Signed-off-by: Lluís Vilanova >> --- >> target/arm/translate-a64.c | 74 >>

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-07-01 Thread Richard Henderson
On 06/28/2017 06:53 AM, Lluís Vilanova wrote: Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 74 +++- 1 file changed, 46

[Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

2017-06-28 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 74 +++- 1 file changed, 46 insertions(+), 28 deletions(-) diff --git