Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Eduardo Habkost
On Fri, Oct 14, 2016 at 04:33:07PM +0200, Igor Mammedov wrote: > On Fri, 14 Oct 2016 10:48:58 -0300 > Eduardo Habkost wrote: > > > On Fri, Oct 14, 2016 at 03:34:17PM +0200, Laurent Vivier wrote: > > > On 14/10/2016 15:33, Eduardo Habkost wrote: > > > > On Thu, Oct 13, 2016 at 06:24:44PM +0200,

Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Igor Mammedov
On Fri, 14 Oct 2016 10:48:58 -0300 Eduardo Habkost wrote: > On Fri, Oct 14, 2016 at 03:34:17PM +0200, Laurent Vivier wrote: > > On 14/10/2016 15:33, Eduardo Habkost wrote: > > > On Thu, Oct 13, 2016 at 06:24:44PM +0200, Laurent Vivier wrote: > > >> We have now the cpu_exec_realize() in realiz

Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Eduardo Habkost
On Fri, Oct 14, 2016 at 04:12:20PM +0200, Laurent Vivier wrote: > > > On 14/10/2016 15:48, Eduardo Habkost wrote: > > On Fri, Oct 14, 2016 at 03:34:17PM +0200, Laurent Vivier wrote: > >> On 14/10/2016 15:33, Eduardo Habkost wrote: > >>> On Thu, Oct 13, 2016 at 06:24:44PM +0200, Laurent Vivier wro

Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Laurent Vivier
On 14/10/2016 15:48, Eduardo Habkost wrote: > On Fri, Oct 14, 2016 at 03:34:17PM +0200, Laurent Vivier wrote: >> On 14/10/2016 15:33, Eduardo Habkost wrote: >>> On Thu, Oct 13, 2016 at 06:24:44PM +0200, Laurent Vivier wrote: We have now the cpu_exec_realize() in realize, so the init par

Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Eduardo Habkost
On Fri, Oct 14, 2016 at 03:34:17PM +0200, Laurent Vivier wrote: > On 14/10/2016 15:33, Eduardo Habkost wrote: > > On Thu, Oct 13, 2016 at 06:24:44PM +0200, Laurent Vivier wrote: > >> We have now the cpu_exec_realize() in realize, > >> so the init part must be in init. > >> > >> I've removed the can

Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 06:24:44PM +0200, Laurent Vivier wrote: > We have now the cpu_exec_realize() in realize, > so the init part must be in init. > > I've removed the cannot_destroy_with_object_finalize_yet field as > unsafe references have been moved to cpu_exec_realize(). > (tested with QOM c

Re: [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-14 Thread Laurent Vivier
On 14/10/2016 15:33, Eduardo Habkost wrote: > On Thu, Oct 13, 2016 at 06:24:44PM +0200, Laurent Vivier wrote: >> We have now the cpu_exec_realize() in realize, >> so the init part must be in init. >> >> I've removed the cannot_destroy_with_object_finalize_yet field as >> unsafe references have be

[Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init

2016-10-13 Thread Laurent Vivier
We have now the cpu_exec_realize() in realize, so the init part must be in init. I've removed the cannot_destroy_with_object_finalize_yet field as unsafe references have been moved to cpu_exec_realize(). (tested with QOM command provided by commit 4c315c27 with "athlon-x86_64-cpu") CC: Eduardo Ha