Re: [Qemu-devel] [PATCH v5 0/4] Add i.MX25 support through the 3DS evaluation board

2013-06-04 Thread Jean-Christophe DUBOIS
On 06/03/2013 05:23 PM, Peter Maydell wrote: On 12 May 2013 14:14, Peter Maydell wrote: On 12 May 2013 13:55, Jean-Christophe DUBOIS wrote: In your opinion, is this patch set good enough in its actual state for inclusion? Are you expecting anything else from me (beside maybe adding more i.MX

[Qemu-devel] [PATCH 2/2] nvram: Add tpm-tis drive support

2013-06-04 Thread Corey Bryant
Add a drive property to the tpm-tis device and initialize the TPM NVRAM if a drive is specified. Signed-off-by: Corey Bryant --- hw/tpm/tpm_int.h |2 ++ hw/tpm/tpm_tis.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/tpm/tpm_int.h b/hw/tpm/tpm_int.h index

[Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-04 Thread Corey Bryant
Provides TPM NVRAM implementation that enables storing of TPM NVRAM data in a persistent image file. The block driver is used to read/write the drive image. This will enable, for example, an ecrypted QCOW2 image to be used to store sensitive keys. This patch provides APIs that a TPM backend can

[Qemu-devel] [PATCH 0/2] TPM NVRAM persistent storage

2013-06-04 Thread Corey Bryant
This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the initial user of this functionality to store data that must persist through a reboot or migration. A sa

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Alex Williamson
On Tue, 2013-06-04 at 18:50 +0200, Paolo Bonzini wrote: > Il 04/06/2013 15:24, Paolo Bonzini ha scritto: > > Il 04/06/2013 14:36, Peter Maydell ha scritto: > >> On 4 June 2013 13:31, Paolo Bonzini wrote: > >>> Il 04/06/2013 14:24, Peter Maydell ha scritto: > On 4 June 2013 13:13, Paolo Bonzin

Re: [Qemu-devel] [PATCH 1/3] virtio: add bus_plugged() callback to VirtioDeviceClass

2013-06-04 Thread Andreas Färber
Hi, Am 04.06.2013 18:22, schrieb Jesse Larrew: > Virtio devices are initialized prior to plugging them into a bus. However, > other initializations (such as host_features) don't occur until after the > device is plugged into the bus. If a device needs to modify it's > configuration based on host_f

Re: [Qemu-devel] [PATCH 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-04 Thread Andreas Färber
Am 04.06.2013 18:58, schrieb Richard Henderson: > Reviewing the tcg/aarch64 patch set, and comparing that to > existing hosts made me remember that I've wanted to do this > for quite some time. > > > r~ > > > > Richard Henderson (2): > tcg: Use QEMU_BUILD_BUG_ON for CPU_TLB_ENTRY_BITS > tc

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 18:37, Markus Armbruster ha scritto: > I figure the bit that can't be resolved now is letting the user switch > off "stop on error" safely before a drive_del. Even if we had a command > for that, there'd still be a window between that command's execution and > drive_del's. Your patc

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Jordan Justen
On Tue, Jun 4, 2013 at 1:26 AM, Dunrong Huang wrote: > On Tue, Jun 4, 2013 at 3:51 PM, Gleb Natapov wrote: >> On Tue, Jun 04, 2013 at 03:47:47PM +0800, Dunrong Huang wrote: >> > On Tue, Jun 4, 2013 at 2:47 PM, Paolo Bonzini >> > wrote: >> > >> > > Il 04/06/2013 05:47, Dunrong Huang ha scritto: >

[Qemu-devel] [PATCH 1/2] tcg: Use QEMU_BUILD_BUG_ON for CPU_TLB_ENTRY_BITS

2013-06-04 Thread Richard Henderson
Rather than a hand-coded version of the same thing. Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h index d8c64e9..2e5a9ba 100644 --- a/include/exec/cpu-defs.h +++ b

[Qemu-devel] [PATCH 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-04 Thread Richard Henderson
Reviewing the tcg/aarch64 patch set, and comparing that to existing hosts made me remember that I've wanted to do this for quite some time. r~ Richard Henderson (2): tcg: Use QEMU_BUILD_BUG_ON for CPU_TLB_ENTRY_BITS tcg: Remove redundant tcg_target_init checks include/exec/cpu-defs.h | 2

[Qemu-devel] [PATCH 2/2] tcg: Remove redundant tcg_target_init checks

2013-06-04 Thread Richard Henderson
We've got a compile-time check for the condition in exec/cpu-defs.h. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 6 -- tcg/i386/tcg-target.c | 6 -- tcg/s390/tcg-target.c | 7 --- 3 files changed, 19 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-targe

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Markus Armbruster
Stefan Hajnoczi writes: > Paolo Bonzini suggested the following test case: > > 1. Launch a guest and wait at the GRUB boot menu: > > qemu-system-x86_64 -enable-kvm -m 1024 \ >-drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop >-device virtio-blk-pci,drive=foo,id=vir

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 15:24, Paolo Bonzini ha scritto: > Il 04/06/2013 14:36, Peter Maydell ha scritto: >> On 4 June 2013 13:31, Paolo Bonzini wrote: >>> Il 04/06/2013 14:24, Peter Maydell ha scritto: On 4 June 2013 13:13, Paolo Bonzini wrote: This is much less flexible than just using sysbus_m

Re: [Qemu-devel] [PATCH v2 12/17] pci-assign: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 14:13, Paolo Bonzini ha scritto: > Signed-off-by: Paolo Bonzini > --- > hw/i386/kvm/pci-assign.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c > index ff85590..4b1c2d9 100644 > --- a/hw/i386/kvm/pci-assign.

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Ed Maste
On 4 June 2013 12:04, Peter Maydell wrote: > You don't need to do this, because there are no config files > in default-configs/ for these, so this patch set will not > change the behaviour for them. Oh, my apologies; I tested the bsd-user WIP at some point in the past, and it seems I have arm- an

[Qemu-devel] [PATCH 3/3] virtio-net: revert MAC address workaround

2013-06-04 Thread Jesse Larrew
With a more permanent solution in place, the workaround in commit e9016ee2bda1b7757072b856b2196f691aee3388 is no longer needed. Signed-off-by: Jesse Larrew --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index

[Qemu-devel] [PATCH 1/3] virtio: add bus_plugged() callback to VirtioDeviceClass

2013-06-04 Thread Jesse Larrew
Virtio devices are initialized prior to plugging them into a bus. However, other initializations (such as host_features) don't occur until after the device is plugged into the bus. If a device needs to modify it's configuration based on host_features, then it needs to be notified when the bus is at

[Qemu-devel] [PATCH 2/3] virtio-net: implement bus_plugged()

2013-06-04 Thread Jesse Larrew
Use the new bus_plugged() callback to calculate and (if necessary) resize the config struct based on the requested host_features. This will help to keep the size of the config struct as small as possible, which will help prevent it from requiring a larger BAR size as future features are added. Sig

[Qemu-devel] [PATCH 0/3] Notify devices when a bus is attached

2013-06-04 Thread Jesse Larrew
The virtio-net driver can determine the required size of the config struct dynamically by inspecting the feature bits in host_features. The natural place to perform this calculation is within the driver's init routine. However, host_features isn't set until later when the device is plugged into a b

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-06-04 Thread Richard Henderson
On 06/04/2013 09:13 AM, Peter Maydell wrote: > Since we now default to "reserve 4GB space and > set guest-base" this should work OK (if all the > TCG bits are right). Indeed it should. Which reminds me... we should remove the bits that make guest-base optional, now that all TCG backends support i

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-06-04 Thread Peter Maydell
On 4 June 2013 16:55, Claudio Fontana wrote: > I'm trying to get this to run, in order to be able to test the > aarch64 TCG User mode support I have under development. Does it work as a first pass with aarch64 put in the configure list of "doesn't need a linker script"? Since we now default to "r

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Peter Maydell
On 4 June 2013 16:27, Ed Maste wrote: > On 20 May 2013 19:09, Peter Maydell wrote: >> I'm not sure that's worth the effort at this point when we don't >> actually have any targets in tree which aren't enabled by default, >> though. (I did cross-check the old and new lists so this patch >> isn't a

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-06-04 Thread Claudio Fontana
On 03.06.2013 16:57, Peter Maydell wrote: > On 3 June 2013 15:23, Richard Henderson wrote: >> On 06/02/2013 10:15 AM, Peter Maydell wrote: >>> So for a new architecture how do we determine whether we need >>> to fiddle with the start address or not? (More specifically, >>> is aarch64 going to need

[Qemu-devel] [PATCH] block/m25p80: Update Micron entries

2013-06-04 Thread Ed Maste
- Split 32Mb and 256Mb parts into a11 and a13 variants. - Add the 4K sector flag to the 128Mb parts. (These entries were taken from the Linux kernel list, which is missing the flag.) - Fill out the table of sizes with entries for 64Mb parts. Prodded by Peter Crosthwaite. Signed-off-by: Ed Mast

Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough

2013-06-04 Thread Benoît Canet
> >>Per the SRIOV spec, yes, but that's in PCIe ext cfg space. > >>That area of the PCI configuration is not saved or restored by dev-reset. > > > >Can a callback be added so PF driver can restore this state ? > > > As you pointed out, no need to, unless it's a device-specific, > PCIe cap structure

Re: [Qemu-devel] VFIO and scheduled SR-IOV cards

2013-06-04 Thread Benoît Canet
Hello, More informations on how the hardware works. -Each VF will have its own memory and MMR, etc. That means the resources are not shared. -Each VF will have its own bus number, function number and device number. That means request ID is separated for each VF. There is also VF save/restore a

Re: [Qemu-devel] [PATCH v2 0/2] MAINTAINERS: QMP: entry update and new maintainers

2013-06-04 Thread Markus Armbruster
Luiz Capitulino writes: > Hi, > > This is an small update on QMP/HMP/QAPI mainternership. Please, check > individual patches for details. > > v2 > > o add QMP/ to the QMP entry > o add Michael as a maintainer for the QAPI > > Luiz Capitulino (2): > MAINTAINERS: new maintainers for qapi-schema

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Ed Maste
On 20 May 2013 19:09, Peter Maydell wrote: > I'm not sure that's worth the effort at this point when we don't > actually have any targets in tree which aren't enabled by default, > though. (I did cross-check the old and new lists so this patch > isn't accidentally enabling a previously disabled co

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-04 Thread Anthony Liguori
Andreas Färber writes: > Am 03.06.2013 23:14, schrieb Anthony Liguori: >> It's not a GObject. >> >> Cc: Gerd Hoffman >> Reported-by: Michael Tokarev >> Signed-off-by: Anthony Liguori >> --- >> v1 -> v2 >> - Fix summary to agree with code (Peter) >> --- >> ui/gtk.c | 2 +- >> 1 file changed,

[Qemu-devel] [PATCH v5] NVMe: Initial commit for new storage interface

2013-06-04 Thread Keith Busch
Initial commit for emulated Non-Volatile-Memory Express (NVMe) pci storage device. NVMe is an open, industry driven storage specification defining an optimized register and command set designed to deliver the full capabilities of non-volatile memory on PCIe SSDs. Further information may be found o

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 16:48, Peter Lieven ha scritto: > Still using 3.2, but strange enough the above example is also not > increasing RSS size for me. > > Can you try the following: > qemu git master with 1G of memory (hanging in bios with no boot device) > and migrate it. Before migration RSS Size os so

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
On 04.06.2013 16:40, Paolo Bonzini wrote: Il 04/06/2013 16:38, Peter Lieven ha scritto: On 04.06.2013 16:14, Paolo Bonzini wrote: Il 04/06/2013 15:52, Peter Lieven ha scritto: On 30.05.2013 16:41, Paolo Bonzini wrote: Il 30/05/2013 16:38, Peter Lieven ha scritto: You could also scan the page

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 16:56, Peter Maydell ha scritto: >>> As a concrete example, if somebody submitted cirrus_vga >>> as a new driver, I have no idea how to tell that it needs >>> to set the owner for its memory regions, when 99% of >>> other devices don't. I think this is going to result in >>> "forgot t

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
On 04.06.2013 16:40, Paolo Bonzini wrote: Il 04/06/2013 16:38, Peter Lieven ha scritto: On 04.06.2013 16:14, Paolo Bonzini wrote: Il 04/06/2013 15:52, Peter Lieven ha scritto: On 30.05.2013 16:41, Paolo Bonzini wrote: Il 30/05/2013 16:38, Peter Lieven ha scritto: You could also scan the page

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Peter Maydell
On 4 June 2013 15:27, Paolo Bonzini wrote: > Il 04/06/2013 16:11, Peter Maydell ha scritto: >> We've already got a working implementation, in the shape >> of sysbus_mmio_get_region(). This is exactly the right way >> to do this API -- we have one API which says "give me a >> MemoryRegion*" and one

[Qemu-devel] [PATCH v2 1/5] Add a stp file for usage from build directory

2013-06-04 Thread Paolo Bonzini
From: Alon Levy For systemtap the location of the process being tapped is crucial, as a result the existing stp file requires installation for use. There are now two files: $(TARGET_DIR)/$(QEMU_PROG).stp-installed: copied to $(tapdir)/$(QEMU_PROG).stp $(TARGET_DIR)/$(QEMU_PROG).stp: pointing to

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 16:38, Peter Lieven ha scritto: > On 04.06.2013 16:14, Paolo Bonzini wrote: >> Il 04/06/2013 15:52, Peter Lieven ha scritto: >>> On 30.05.2013 16:41, Paolo Bonzini wrote: Il 30/05/2013 16:38, Peter Lieven ha scritto: >>> You could also scan the page for nonzero values before

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
On 04.06.2013 16:14, Paolo Bonzini wrote: Il 04/06/2013 15:52, Peter Lieven ha scritto: On 30.05.2013 16:41, Paolo Bonzini wrote: Il 30/05/2013 16:38, Peter Lieven ha scritto: You could also scan the page for nonzero values before writing it. i had this in mind, but then choosed the other app

[Qemu-devel] [PATCH v2 3/5] build: do not use TARGET_ARCH

2013-06-04 Thread Paolo Bonzini
TARGET_ARCH is generally wrong to use, there are better variables provided in config-target.mak. The right one is usually TARGET_NAME (previously TARGET_ARCH2), but for bsd-user we can also use TARGET_ABI_DIR for consistency with linux-user. Signed-off-by: Paolo Bonzini --- Makefile.target

[Qemu-devel] [PULL 07/10] block: drop bs_snapshots global variable

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became clear that hotplug could result in a dangling pointer. While auditing the block

Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-06-04 Thread Ed Maste
On 4 June 2013 07:31, Peter Crosthwaite wrote: >> /* Micron */ >> +{ INFO("n25q032a",0x20bb16, 0, 64 << 10, 64, ER_4K) }, > > Does this have a11 and a13 variants as well? > >> { INFO("n25q128a11", 0x20bb18, 0, 64 << 10, 256, 0) }, >> { INFO("n25q128a13", 0x20b

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 16:11, Peter Maydell ha scritto: > We've already got a working implementation, in the shape > of sysbus_mmio_get_region(). This is exactly the right way > to do this API -- we have one API which says "give me a > MemoryRegion*" and one which says "I have a MemoryRegion*, > please expo

[Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
This matches sysbus_pass_irq in cases where a device is a thin wrapper of another. MMIO regions will keep the subdevice as the owner. Signed-off-by: Paolo Bonzini --- hw/core/sysbus.c | 12 hw/cpu/arm11mpcore.c | 2 +- include/hw/sysbus.h | 1 + 3 files changed, 14 insertion

Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-06-04 Thread Anthony Liguori
Andreas Färber writes: > Anthony, > > Am 31.05.2013 20:48, schrieb Anthony Liguori: >> Applied. Thanks. > > I don't see this applied, neither in qemu-stable-1.1.git nor in qemu.git > stable-1.1 branch? Right, 1.1 is EOL. > Do we have an active maintainer for 1.1 or 1.3? Unfortunately qemu.git

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 15:52, Peter Lieven ha scritto: > On 30.05.2013 16:41, Paolo Bonzini wrote: >> Il 30/05/2013 16:38, Peter Lieven ha scritto: > You could also scan the page for nonzero values before writing it. >>> i had this in mind, but then choosed the other approach turned >>> out to be a

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-06-04 Thread Kevin Wolf
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: > These patches are the common part of my hmp/qmp block query series and Pavel's > qmp snapshot command converion series. It mainly does following things: > 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to > block/qap

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Peter Maydell
On 4 June 2013 14:24, Paolo Bonzini wrote: > Il 04/06/2013 14:36, Peter Maydell ha scritto: >> On 4 June 2013 13:31, Paolo Bonzini wrote: >>> Il 04/06/2013 14:24, Peter Maydell ha scritto: On 4 June 2013 13:13, Paolo Bonzini wrote: This is much less flexible than just using sysbus_mmio

[Qemu-devel] [PATCH v2 5/5] build: drop TARGET_TYPE

2013-06-04 Thread Paolo Bonzini
Just use the TARGET_NAME free string. Signed-off-by: Paolo Bonzini --- arch_init.c | 2 +- configure| 1 - qapi-schema.json | 18 +- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/arch_init.c b/arch_init.c index 23ca953..699c927 100644 --- a/arch_i

[Qemu-devel] [PATCH v2 0/5] configure: TARGET_ARCH cleanups

2013-06-04 Thread Paolo Bonzini
We have three variables currently in config-target.h: - TARGET_ARCH is used to create a unique per-arch symbol, used in #ifdefs. It is also used as a string through config-target.h, but this is almost always wrong. - TARGET_ARCH2 is the name of the executable (minus the qemu-/qemu-system- p

[Qemu-devel] [PATCH 03/13] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-06-04 Thread Alexey Kardashevskiy
Author: David Gibson The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather than register_vmstate() method. It's also rather broken, missing some important state on some CPU models. This patch completely rewrites the savevm for target-ppc, using

[Qemu-devel] [PATCH 1/2] MAINTAINERS: new maintainers for qapi-schema.json

2013-06-04 Thread Luiz Capitulino
I'm facing two problems lately wrt QMP patch review: increasingly lack of bandwidth and lack of background in so many different areas that are getting new QMP commands almost every week. In order to help me mitigate this problem, I'm adding Eric and Markus (besides me) as maintainers of the qapi-s

[Qemu-devel] [PATCH] MAINTAINERS: s/Marcelo/Paolo/

2013-06-04 Thread Michael S. Tsirkin
Marcelo doesn't maintain kvm anymore, Paolo is taking over the job. Update MAINTAINERS to stop flooding Marcelo with mail. Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index be02724..66e94da 100644

[Qemu-devel] [PULL 08/10] block: move snapshot code in block.c to block/snapshot.c

2013-06-04 Thread Kevin Wolf
From: Wenchao Xia All snapshot related code, except bdrv_snapshot_dump() and bdrv_is_snapshot(), is moved to block/snapshot.c. bdrv_snapshot_dump() will be moved to another file later. bdrv_is_snapshot() is not related with internal snapshot. It also fixes small code style errors reported by chec

[Qemu-devel] reminder: no kvm developer call today

2013-06-04 Thread Michael S. Tsirkin
Reminder: we witched to a bi-weekly schedule. There's no kvm developer call today. -- MST

Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-06-04 Thread Andreas Färber
Anthony, Am 31.05.2013 20:48, schrieb Anthony Liguori: > Applied. Thanks. I don't see this applied, neither in qemu-stable-1.1.git nor in qemu.git stable-1.1 branch? Do we have an active maintainer for 1.1 or 1.3? Unfortunately qemu.git MAINTAINERS has not been updated with stable branches and

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
On 30.05.2013 16:41, Paolo Bonzini wrote: Il 30/05/2013 16:38, Peter Lieven ha scritto: You could also scan the page for nonzero values before writing it. i had this in mind, but then choosed the other approach turned out to be a bad idea. alexey: i will prepare a patch later today, could

[Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-04 Thread Luiz Capitulino
This entry doesn't reflect reality for a few years now. This commit splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped as a maintainer. This is what we have been for the last few years. Also, it's going to help me to offload some of this work to someone else in the near future. S

[Qemu-devel] [PATCH v2 0/2] MAINTAINERS: QMP: entry update and new maintainers

2013-06-04 Thread Luiz Capitulino
Hi, This is an small update on QMP/HMP/QAPI mainternership. Please, check individual patches for details. v2 o add QMP/ to the QMP entry o add Michael as a maintainer for the QAPI Luiz Capitulino (2): MAINTAINERS: new maintainers for qapi-schema.json MAINTAINERS: split Monitor (QMP/HMP) e

[Qemu-devel] Qemu debugging

2013-06-04 Thread Abdelkader, Osama
Hello All, I would like to know a consistent way to debug qemu itself rather than message, I mean using IDE like eclipse. Thanks, Osama

Re: [Qemu-devel] [PATCH v3] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-04 Thread mdroth
On Tue, Jun 04, 2013 at 11:58:12AM +0200, Hans de Goede wrote: > Hi, > > On 06/03/2013 10:25 PM, Michael Roth wrote: > > > > >To fix these, let's just drop the BH. > > > >Since the initial reasoning for using it still applies to an extent, > >work around that by deferring the delivery of CHR_EV

[Qemu-devel] [PATCH] user-exec.c: Set is_write correctly in the ARM cpu_signal_handler()

2013-06-04 Thread Peter Maydell
In the ARM implementation of cpu_signal_handler(), set is_write correctly using the FSR value which the kernel passes us in the error_code field of uc_mcontext. Since the WnR bit of the FSR was only introduced in ARMv6, this means that v5 cores will continue to behave as before this patch, but they

Re: [Qemu-devel] [PATCH] MAINTAINERS: s/Marcelo/Paolo/

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 15:16, Michael S. Tsirkin ha scritto: > Marcelo doesn't maintain kvm anymore, > Paolo is taking over the job. > Update MAINTAINERS to stop flooding Marcelo with mail. > > Signed-off-by: Michael S. Tsirkin > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 14:36, Peter Maydell ha scritto: > On 4 June 2013 13:31, Paolo Bonzini wrote: >> Il 04/06/2013 14:24, Peter Maydell ha scritto: >>> On 4 June 2013 13:13, Paolo Bonzini wrote: >>> This is much less flexible than just using sysbus_mmio_get_region(), >>> because it only lets you pass t

[Qemu-devel] KVM call agenda for 2013-06-11

2013-06-04 Thread Michael S. Tsirkin
Juan is not available now, and Anthony asked for agenda to be sent early. So here comes: Agenda for the meeting Tue, June 11: - Generating acpi tables, redux Please, send any topic that you are interested in covering. Thanks, MST -- MST

[Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-04 Thread Paolo Bonzini
Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside the BQL (including in Xen or KVM). - memory_region_find callsites - creation of aliases and containers (only the aliased/contained region gets a reference to avoid loops) -

Re: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup

2013-06-04 Thread Dmitry Fleytman
Hi Stefan, Thanks for fixing this. Dmitry. Sent from my iPad On Jun 4, 2013, at 2:47 PM, Stefan Hajnoczi wrote: > Use qemu_del_nic() instead of qemu_del_net_client() to correctly free > the entire NICState. > > Reported-by: Paolo Bonzini > Signed-off-by: Stefan Hajnoczi > --- > hw/net/vmxn

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Kevin Wolf
Am 04.06.2013 um 14:40 hat Luiz Capitulino geschrieben: > On Tue, 4 Jun 2013 12:08:23 +0200 > Kevin Wolf wrote: > > > Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: > > > On Wed, 29 May 2013 10:13:42 +0200 > > > Kevin Wolf wrote: > > > > > > > Am 28.05.2013 um 18:07 hat Eric Blake gesc

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Luiz Capitulino
On Tue, 4 Jun 2013 14:49:55 +0200 Kevin Wolf wrote: > Am 04.06.2013 um 14:40 hat Luiz Capitulino geschrieben: > > On Tue, 4 Jun 2013 12:08:23 +0200 > > Kevin Wolf wrote: > > > > > Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: > > > > On Wed, 29 May 2013 10:13:42 +0200 > > > > Kevin Wo

Re: [Qemu-devel] [PATCH v2] linux-user: Allow getdents to be provided by getdents64

2013-06-04 Thread Richard Henderson
On 06/04/2013 04:12 AM, Peter Maydell wrote: > Newer architectures may only implement the getdents64 syscall, not > getdents. Provide an implementation of getdents in terms of getdents64 > so that we can run getdents-using targets on a getdents64-only host. > > Signed-off-by: Peter Maydell > Mess

[Qemu-devel] [PULL 00/10] Block patches

2013-06-04 Thread Kevin Wolf
The following changes since commit 171392406d8e230d62e5ebf4805f71460854b8ec: gtk: don't use g_object_unref on GdkCursor (2013-06-03 16:14:05 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to 5b91704469c0f801e0219f264583

Re: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 14:47, Stefan Hajnoczi ha scritto: > Use qemu_del_nic() instead of qemu_del_net_client() to correctly free > the entire NICState. > > Reported-by: Paolo Bonzini > Signed-off-by: Stefan Hajnoczi Cc: qemu-sta...@nongnu.org > --- > hw/net/vmxnet3.c | 2 +- > 1 file changed, 1 inser

Re: [Qemu-devel] [snabb-devel:300] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 02:19:23PM +0200, Luke Gorrie wrote: > The idea that excites me is to implement a complete PCI device in Snabb Switch > and expose this to the guest at the basic PCI/MMIO/DMA level. That would mean making snabb switch part of QEMU. -- MST

Re: [Qemu-devel] [snabb-devel:300] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-06-04 Thread Julian Stecklina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/04/2013 02:19 PM, Luke Gorrie wrote: > The idea that excites me is to implement a complete PCI device in > Snabb Switch and expose this to the guest at the basic PCI/MMIO/DMA > level. The device would be a Virtio network adapter based on Rusty >

[Qemu-devel] [PULL 09/10] block: move qmp and info dump related code to block/qapi.c

2013-06-04 Thread Kevin Wolf
From: Wenchao Xia This patch is a pure code move patch, except following modification: 1 get_human_readable_size() is changed to static function. 2 dump_human_image_info() is renamed to bdrv_image_info_dump(). 3 in qmp_query_block() and qmp_query_blockstats, use bdrv_next(bs) instead of direct tr

[Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup

2013-06-04 Thread Stefan Hajnoczi
Use qemu_del_nic() instead of qemu_del_net_client() to correctly free the entire NICState. Reported-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 5f483e7..4c575e

[Qemu-devel] [PULL 10/10] block: dump snapshot and image info to specified output

2013-06-04 Thread Kevin Wolf
From: Wenchao Xia bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no chance to be truncated. As a result, these two functions have no more issue of truncation, and they can be used by both qemu and qe

[Qemu-devel] [Bug 1187319] [NEW] Ctrl-Alt-- and Ctrl-Alt-+ have no effect in SDL

2013-06-04 Thread Lekensteyn
Public bug reported: The manual page mentions Ctrl-Alt-- for shrinking a window and Ctrl- Alt-+ for enlarging it. Pressing these keys do not seem to have any effect. I tried -/= with and without holding shift and the numpad. By the way, the numpad plus and min do not have any effect in GTK either

[Qemu-devel] [PULL 06/10] qemu-iotests: make create_image() common

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi Both 030 and 041 use create_image(). Move it to iotests.py. Also drop ImageStreamingTestCase since the class now has no methods. Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030| 32 +-

[Qemu-devel] [PULL 05/10] qemu-iotests: make compare_images() common

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi The iotests.compare_images() function returns True if two image files have the identical data. Previously this was implemented by converting images to raw and then comparing their contents using Python. Since "qemu-img compare" is now available and is more efficient, switc

[Qemu-devel] [Bug 1187241] [NEW] QEMU patch for PNP ID

2013-06-04 Thread Michael Reed
Private bug reported: A patch is needed for QEMU that either will statically change PNP ID for virtio devices or accept the PNP ID from command line. ** Affects: qemu Importance: Undecided Status: New ** Information type changed from Public to Private Security ** Information type

[Qemu-devel] [PULL 03/10] qemu-iotests: make assert_no_active_block_jobs() common

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi Tests 030 and 041 both use query-block-jobs to check whether any block jobs are active. Make this code common so that 'drive-backup' and other new feature tests will be able to reuse it. Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf -

[Qemu-devel] [PULL 04/10] qemu-iotests: make cancel_and_wait() common

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi The cancel_and_wait() function has been duplicated in 030 and 041. Move it into iotests.py and let it return the event so tests can perform additional asserts. Note that 041's cancel_and_wait(wait_ready=True) is replaced by wait_ready_and_cancel(), which uses the new wait_

[Qemu-devel] [PULL 01/10] qemu-iotests: fix 054 cluster size help output

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi Commit f3f4d2c09b9cf46903ba38425ec46c44185162bd added a hint to increase the cluster size when a large image cannot be created. Test 054 now has outdated output and fails because the golden output does not match. This patch updates the 054 golden output. Signed-off-by: St

[Qemu-devel] [PULL 02/10] block: add block driver read only whitelist

2013-06-04 Thread Kevin Wolf
From: Fam Zheng We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces a readonly whitelist option, and for backward compatibility, the old configure option --block-drv-whitelist is

[Qemu-devel] [PATCH v2 2/5] build: rename TARGET_ARCH2 to TARGET_NAME

2013-06-04 Thread Paolo Bonzini
Do not introduce any new use yet. Signed-off-by: Paolo Bonzini --- Makefile.target | 6 +++--- configure | 42 +- scripts/create_config | 2 +- 3 files changed, 25 insertions(+), 25 deletions(-) diff --git a/Makefile.target b/Makefile.

[Qemu-devel] [PATCH v2 4/5] main: use TARGET_ARCH only for the target-specific #define

2013-06-04 Thread Paolo Bonzini
Everything else needs to match the executable name, which is TARGET_NAME. Before: $ sh4eb-linux-user/qemu-sh4eb --help usage: qemu-sh4 [options] program [arguments...] Linux CPU emulator (compiled for sh4 emulation) After: $ sh4eb-linux-user/qemu-sh4eb --help usage: qemu-sh4eb

Re: [Qemu-devel] [PATCH 00/13 v2] pseries: savevm / migration support

2013-06-04 Thread Andreas Färber
Am 04.06.2013 14:20, schrieb Alexey Kardashevskiy: > I still have to learn how to force git not to overwrite the original commit > author :-/ > Is there any way to tell the original creator in the commit message so it > could live > in a git forever and survive commit changes? To fix it up: git

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Luiz Capitulino
On Tue, 4 Jun 2013 12:08:23 +0200 Kevin Wolf wrote: > Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: > > On Wed, 29 May 2013 10:13:42 +0200 > > Kevin Wolf wrote: > > > > > Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: > > > > On 05/28/2013 09:27 AM, Kevin Wolf wrote: > > > > > The

Re: [Qemu-devel] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-06-04 Thread Stefan Hajnoczi
On Fri, May 31, 2013 at 01:38:51PM +0200, Ján Tomko wrote: > Hello, > > since qemu's commit v1.4.0-736-gf17c90b [1]: > nbd: Keep hostname and port separate > > * literal IPv6 addresses no longer work in nbd URIs, because getaddrinfo is > called with the surrounding brackets: > $ qemu-system-x

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Peter Maydell
On 4 June 2013 13:31, Paolo Bonzini wrote: > Il 04/06/2013 14:24, Peter Maydell ha scritto: >> On 4 June 2013 13:13, Paolo Bonzini wrote: >> This is much less flexible than just using sysbus_mmio_get_region(), >> because it only lets you pass the whole set of MMIOs from the >> other device throug

Re: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 13:43, Andreas Färber ha scritto: > Am 03.06.2013 07:32, schrieb peter.crosthwa...@xilinx.com: >> > From: Peter Crosthwaite >> > >> > These comments we're a little difficult to read. First one had > While we're picky: "were" - Paolo can you fix up in your queue? Of course. Paolo

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 14:24, Peter Maydell ha scritto: > On 4 June 2013 13:13, Paolo Bonzini wrote: >> This matches sysbus_pass_irq in cases where a device is a thin wrapper >> of another. MMIO regions will keep the subdevice as the owner. >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/core/sysbus.c

[Qemu-devel] [PATCH 06/13] pseries: savevm support for PAPR VIO logical lan

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_llan (PAPR logical lan) device. Signed-off-by: David Gibson Signed-off-by: Alexey Kardashevskiy --- hw/char/spapr_vty.c | 16 hw/net/spapr_llan.c | 24 ++

Re: [Qemu-devel] [libvirt] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-06-04 Thread Ján Tomko
On 06/04/2013 02:19 PM, Stefan Hajnoczi wrote: > > CCing Kevin who authored v1.4.0-736-gf17c90b. > > Stefan > I've already posted patches for both issues: http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg00227.html Jan

[Qemu-devel] [PATCH v2 09/17] misc: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/char/serial-pci.c | 1 + hw/misc/pc-testdev.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 2138e35..6b6106b 100644 --- a/hw/char/serial-pci.c +++ b/hw/char/serial-pci.c @@ -106,6 +106,7 @@ static

[Qemu-devel] [PATCH 10/13] pseries: savevm support for pseries machine

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson This adds the necessary pieces to implement savevm / migration for the pseries machine. The most complex part here is migrating the hash table - for the paravirtualized pseries machine the guest's hash page table is not stored within guest memory, but externally and the guest

[Qemu-devel] [PATCH 13/13] pseries: savevm support with KVM

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson At present, the savevm / migration support for the pseries machine will not work when KVM is enabled. That's because KVM manages the guest's hash page table in the host kernel, so qemu has no visibility of it. This patch fixes this by using new kernel interfaces to extract an

[Qemu-devel] [PATCH 11/13] pseries: savevm support for PCI host bridge

2013-06-04 Thread Alexey Kardashevskiy
Author: David Gibson This adds the necessary support for saving the state of the PAPR virtual PCI host bridge (or host bridges). Signed-off-by: David Gibson Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 49 +++ include/hw/pci-h

[Qemu-devel] [PATCH 09/13] pseries: savevm support for PAPR virtual SCSI

2013-06-04 Thread Alexey Kardashevskiy
Author: David Gibson This patch adds the necessary support for saving the state of the PAPR VIO virtual SCSI device. This also saves and restores active SCSI requests. [David Gibson: implemented vscsi device vmsd] Signed-off-by: Alexey Kardashevskiy Cc: David Gibson --- hw/scsi/spapr_vscsi.c

<    1   2   3   >