Re: [Qemu-devel] [PATCH 09/17] migration-local: override before_ram_iterate to send pipefd

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 05:38, Lei Li ha scritto: Just want to confirm, normally, should I take these 'otherwise looks good/ok' as a 'Reviewed-by' from you If the other comment is fixed in the update version? Depends on how much the patch changes... right now I'm still expecting some changes so I

Re: [Qemu-devel] [PATCH 0/17 v2] Localhost migration with side channel for ram

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 06:58, Lei Li ha scritto: Right now just has inaccurate numbers without the new vmsplice, which based on the result from info migrate, as the guest ram size increases, although the 'total time' is number of times less compared with the current live migration, but the 'downtime'

Re: [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 05:30, Lei Li ha scritto: I am not sure about the name; for one thing, the new state would apply also to postcopy migration. About the name, how about 'live-upgrade'? OK, I'll add the transition between postcopy and this new state. Note I didn't mean postmigrate. For a

Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa-hpa on 1GB boundary

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 05:58, Marcelo Tosatti ha scritto: On Fri, Oct 25, 2013 at 12:55:36AM +0100, Paolo Bonzini wrote: +if (hpagesize == (130)) { +unsigned long holesize = 0x1ULL - below_4g_mem_size; + +memory_region_init_alias(ram_above_4g, NULL,

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Test for loading VM state from qcow2

2013-10-25 Thread Kevin Wolf
Am 24.10.2013 um 20:24 hat Max Reitz geschrieben: Add a test for saving a VM state from a qcow2 image and loading it back (with having restarted qemu in between); this should work without any problems. Signed-off-by: Max Reitz mre...@redhat.com Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 0/17 v2] Localhost migration with side channel for ram

2013-10-25 Thread Anthony Liguori
On Oct 25, 2013 8:30 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 25/10/2013 06:58, Lei Li ha scritto: Right now just has inaccurate numbers without the new vmsplice, which based on the result from info migrate, as the guest ram size increases, although the 'total time' is number of

Re: [Qemu-devel] [PATCH v2] qcow2: Flush image after creation

2013-10-25 Thread Kevin Wolf
Am 24.10.2013 um 20:35 hat Max Reitz geschrieben: Opening the qcow2 image with BDRV_O_NO_FLUSH prevents any flushes during the image creation. This means that the image has not yet been flushed to disk when qemu-img create exits. This flush is delayed until the next operation on the image

Re: [Qemu-devel] [PATCH 0/6] qapi: generate event defines automatically

2013-10-25 Thread Wenchao Xia
Hi, Markus I am coding V2 which support event in qapi-schema, and just remember it is on your TODO list. Is it OK to let me implement it instead as V2?

Re: [Qemu-devel] [PATCH] linux-user: create target_structs header to place ipc_perm and shmid_ds

2013-10-25 Thread Erik de Castro Lopo
Petar Jovanovic wrote: From: Petar Jovanovic petar.jovano...@imgtec.com Creating target_structs header in linux-user/$arch/ and making target_ipc_perm and target_shmid_ds its first inhabitants. The struct defintions may/should be further fine-tuned by arch maintainers. Signed-off-by:

Re: [Qemu-devel] Patch v3 : POSIX timer implementation for linux-user.

2013-10-25 Thread Erik de Castro Lopo
mle...@mega-nerd.com wrote: Changes from original: * Call host's libc functions directly rather than _syscall*() (as suggested by Peter Maydell). * Remove un-needed #defines. Launchpad bug is here: https://bugs.launchpad.net/bugs/1042388 Ping?

Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa-hpa on 1GB boundary

2013-10-25 Thread igor Mammedov
On Fri, 25 Oct 2013 02:58:05 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Oct 25, 2013 at 12:55:36AM +0100, Paolo Bonzini wrote: +if (hpagesize == (130)) { +unsigned long holesize = 0x1ULL - below_4g_mem_size; + +

Re: [Qemu-devel] [PATCH 1/1] sd: pl181: fix fifo count read support

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:33 Sat 19 Oct , Jean-Christophe PLAGNIOL-VILLARD wrote: as it's depend on current direction ony change to get that applied? Barebox relay on it so it can work on both qemu and real hw Best Regards, J. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com ---

Re: [Qemu-devel] [PATCH v5 4/5] Update documentation for LTTng ust tracing

2013-10-25 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca All looks good to me now. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Alex Bennée
tommu...@gmail.com writes: This patch adds routines to the softfloat library that are useful for the PowerPC VSX implementation. The routines are, however, not specific to PowerPC and are approprriate for softfloat. snip Is it worth adding some sort of test into make check to defend these

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Peter Maydell
On 25 October 2013 12:34, Alex Bennée alex.ben...@linaro.org wrote: Is it worth adding some sort of test into make check to defend these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches use these functions as float errors are often

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Peter Maydell
On 24 October 2013 17:17, Tom Musta tommu...@gmail.com wrote: This patch adds routines to the softfloat library that are useful for the PowerPC VSX implementation. The routines are, however, not specific to PowerPC and are approprriate for softfloat. The following routines are added: -

Re: [Qemu-devel] [PATCH 09/17] migration-local: override before_ram_iterate to send pipefd

2013-10-25 Thread Lei Li
On 10/25/2013 03:23 PM, Paolo Bonzini wrote: Il 25/10/2013 05:38, Lei Li ha scritto: Just want to confirm, normally, should I take these 'otherwise looks good/ok' as a 'Reviewed-by' from you If the other comment is fixed in the update version? Depends on how much the patch changes... right now

Re: [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE

2013-10-25 Thread Lei Li
On 10/25/2013 03:31 PM, Paolo Bonzini wrote: Il 25/10/2013 05:30, Lei Li ha scritto: I am not sure about the name; for one thing, the new state would apply also to postcopy migration. About the name, how about 'live-upgrade'? OK, I'll add the transition between postcopy and this new state.

Re: [Qemu-devel] [PATCH 0/17 v2] Localhost migration with side channel for ram

2013-10-25 Thread Lei Li
On 10/25/2013 03:30 PM, Paolo Bonzini wrote: Il 25/10/2013 06:58, Lei Li ha scritto: Right now just has inaccurate numbers without the new vmsplice, which based on the result from info migrate, as the guest ram size increases, although the 'total time' is number of times less compared with the

[Qemu-devel] KVM call agenda for 2013-10-29

2013-10-25 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 10:00 AM to 11:00 AM EDT Every two weeks If you need phone number details, contact me privately.

[Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file.

2013-10-25 Thread Thibaut LAURENT
Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c, bdrv_open_common will throw an error when trying to open a file read-only with the BDRV_O_COPY_ON_READ flag set. Although BDRV_O_RDWR is unset for the backing files, BDRV_O_COPY_ON_READ is still passed on if copy-on-read was requested for the

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Tom Musta
Peter: Thanks for your feedback. Responses below. On 10/25/2013 6:55 AM, Peter Maydell wrote: On 24 October 2013 17:17, Tom Musta tommu...@gmail.com wrote: This patch adds routines to the softfloat library that are useful for the PowerPC VSX implementation. The routines are, however, not

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 25 October 2013 12:34, Alex Bennée alex.ben...@linaro.org wrote: Is it worth adding some sort of test into make check to defend these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches use these

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca --- snip Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Tom Musta
On 10/25/2013 6:44 AM, Peter Maydell wrote: On 25 October 2013 12:34, Alex Bennée alex.ben...@linaro.org wrote: Is it worth adding some sort of test into make check to defend these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches

Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa-hpa on 1GB boundary

2013-10-25 Thread Marcelo Tosatti
On Fri, Oct 25, 2013 at 11:57:18AM +0200, igor Mammedov wrote: On Fri, 25 Oct 2013 02:58:05 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Oct 25, 2013 at 12:55:36AM +0100, Paolo Bonzini wrote: +if (hpagesize == (130)) { +unsigned long holesize =

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Peter Maydell
On 25 October 2013 14:01, Tom Musta tommu...@gmail.com wrote: On 10/25/2013 6:55 AM, Peter Maydell wrote: On 24 October 2013 17:17, Tom Musta tommu...@gmail.com wrote: - float32_is_denormal() returns true if the 32-bit floating point number is denormalized. - float64_is_denormal()

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Tom Musta
On 10/24/2013 3:38 PM, Richard Henderson wrote: On 10/24/2013 09:25 AM, Tom Musta wrote: \ snip +ft1 = tp##_to_##btp(s-fld[i], env-fp_status); \ +ft0 = btp##_##sum(ft0, ft1, env-fp_status);

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Mohamad Gebai
Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca --- snip Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée a...@bennee.com Yes, the bug is actually only in the Ubuntu package (missing liburcu*.pc files). It is fixed

Re: [Qemu-devel] [PATCH 15/19] Add VSX xmax/xmin Instructions

2013-10-25 Thread Tom Musta
On 10/24/2013 5:10 PM, Peter Maydell wrote: Can't you use the min and max softfloat functions? Those are there specifically because the corner cases mean you can't implement them using the comparisons. (For instance for the example you quote of max(-0.0, +0.0) they return +0.0 as you require.)

[Qemu-devel] e1000 patch for osx

2013-10-25 Thread jacek burghardt
Is there a patch for qemu git master that pre init e1000 so I can get rid off unpluged network cable message ? I know there is patch but is is for older version of qemu and it seeem that it no longer functions and does not apply fully as code was changed.

Re: [Qemu-devel] [PATCH 15/19] Add VSX xmax/xmin Instructions

2013-10-25 Thread Peter Maydell
On 25 October 2013 14:52, Tom Musta tommu...@gmail.com wrote: On 10/24/2013 5:10 PM, Peter Maydell wrote: Can't you use the min and max softfloat functions? Those are there specifically because the corner cases mean you can't implement them using the comparisons. (For instance for the

Re: [Qemu-devel] e1000 patch for osx

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 14:53, jacek burghardt ha scritto: Is there a patch for qemu git master that pre init e1000 so I can get rid off unpluged network cable message ? I know there is patch but is is for older version of qemu and it seeem that it no longer functions and does not apply fully as code

Re: [Qemu-devel] e1000 patch for osx

2013-10-25 Thread jacek burghardt
https://github.com/saucelabs/mac-osx-on-kvm/blob/master/e1000-mac-hacks.patch -} else -s-phy_reg[addr] = data; +} else { +/* some (reset) bits are self clearing, so better clear them */ +switch (addr) { +case PHY_CTRL: +

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Alex Bennée
mohamad.ge...@polymtl.ca writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca --- snip Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée a...@bennee.com Yes, the bug is actually only in the Ubuntu package (missing

[Qemu-devel] [PATCH 0/3 for 1.7] migration: introduce page flipping capability

2013-10-25 Thread Lei Li
This series is extracted from the lastest localhost migration with side channel for ram patch set with comments from Paolo fixed. Send it separately according to his suggestion. Localhost migration with side channel for ram: http://lists.gnu.org/archive/html/qemu-devel/2013-10/msg02787.html Lei

[Qemu-devel] [PATCH 3/3] qmp-command.hx: add missing docs for migration capabilites

2013-10-25 Thread Lei Li
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qmp-commands.hx |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index fba15cd..dcec433 100644 --- a/qmp-commands.hx +++

[Qemu-devel] [PATCH 1/3] QAPI: introduce magration capability unix_page_flipping

2013-10-25 Thread Lei Li
Introduce unix_page_flipping to MigrationCapability for localhost migration. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qapi-schema.json | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' = 'rdma'

2013-10-25 Thread Michael R. Hines
On 10/22/2013 04:20 PM, Eric Blake wrote: On 10/22/2013 05:59 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com As far as we can tell, all known bugs have been fixed, there as been very good participation in testing and running. 1. Parallel RDMA migrations are

[Qemu-devel] [PATCH 2/3] migration: add migrate_unix_page_flipping()

2013-10-25 Thread Lei Li
Add migrate_unix_page_flipping() to check if MIGRATION_CAPABILITY_UNIX_PAGE_FLIPPING is enabled. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |3 +++ migration.c |9 + 2 files

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' = 'rdma'

2013-10-25 Thread Michael R. Hines
On 10/23/2013 02:25 AM, Paolo Bonzini wrote: Il 22/10/2013 21:20, Eric Blake ha scritto: -# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is +# @rdma-pin-all: Controls whether or not the entire VM memory footprint is # mlock()'d on demand or all at once.

Re: [Qemu-devel] [PATCH 0/3 for 1.7] migration: introduce page flipping capability

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 15:59, Lei Li ha scritto: This series is extracted from the lastest localhost migration with side channel for ram patch set with comments from Paolo fixed. Send it separately according to his suggestion. Localhost migration with side channel for ram:

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' = 'rdma'

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 16:03, Michael R. Hines ha scritto: Well, I tried posting libvirt support with this naming scheme, but they didn't accepted. Their reason (Daniel, I think) is valid: experimental implies that it shouldn't be exposed in the management software until it is deemed stable at

[Qemu-devel] [RFC] block io lost in the guest , possible related to qemu?

2013-10-25 Thread Jack Wang
Hi Experts, We've seen guest block io lost in a VM.any response will be helpful environment is: guest os: Ubuntu 1304 running busy database workload with xfs on a disk export with virtio-blk the exported vdb has very high infight io over 300. Some times later a lot io process in D state, looks

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Mohamad Gebai
On 10/25/2013 10:33 AM, Alex Bennée wrote: mohamad.ge...@polymtl.ca writes: Yes, the bug is actually only in the Ubuntu package (missing liburcu*.pc files). It is fixed everywhere else, including the LTTng PPA. There is a bug report about it on Launchpad. Either ways, this fall back avoids

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Tom Musta
On 10/24/2013 3:38 PM, Richard Henderson wrote: On 10/24/2013 09:25 AM, Tom Musta wrote: \ +ft0 = tp##_to_##btp(xa.fld[i], env-fp_status); \ +ft1 = tp##_to_##btp(m-fld[i], env-fp_status); \

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Richard Henderson
On 10/25/2013 09:25 AM, Tom Musta wrote: I tried recoding xsmaddadp using float64_muladd. The problem that I hit is the boundary case where the intermediate product and the summand are infinities of the opposite sign. This is the case handled by the first if in the code snippet above.

Re: [Qemu-devel] [PATCH 1/2] target-arm: sort TCG cpreg list by 64bit id version

2013-10-25 Thread Peter Maydell
On 11 October 2013 18:38, Alvise Rigo a.r...@virtualopensystems.com wrote: Both KVM and TCG populate the cpreg_list with 64 bit registers IDs, but in the TCG side the cpreg_list is sorted using the 32 bit id version while in the kvm side the 64 bit id version is used. This patch makes the

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Tom Musta
On 10/25/2013 11:42 AM, Richard Henderson wrote: I believe that a better implementation could use float*_muladd, and check the result for float_flag_invalid. If set, compute the intermediate product so you can figure out the VXISI setting. But we'd expect that to be an unlikely path.

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Peter Maydell
On 25 October 2013 17:25, Tom Musta tommu...@gmail.com wrote: On 10/24/2013 3:38 PM, Richard Henderson wrote: You want to be using tp##muladd instead of widening to 128 bits. I tried recoding xsmaddadp using float64_muladd. The problem that I hit is the boundary case where the intermediate

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Richard Henderson
On 10/25/2013 10:13 AM, Tom Musta wrote: On 10/25/2013 11:42 AM, Richard Henderson wrote: I believe that a better implementation could use float*_muladd, and check the result for float_flag_invalid. If set, compute the intermediate product so you can figure out the VXISI setting. But we'd

Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions

2013-10-25 Thread Richard Henderson
On 10/25/2013 10:20 AM, Peter Maydell wrote: Are you sure that doing the arithmetic with the softfloat 128 bit float operations doesn't set the inexact flag anywhere it shouldn't? (ie where the intermediate product is not exact in 128 bit format but the final result is exact in 64 or 32 bits).

Re: [Qemu-devel] [PATCH v4] integrator: fix Linux boot failure by emulating dbg region

2013-10-25 Thread Peter Maydell
On 22 October 2013 15:16, alex.ben...@linaro.org wrote: +typedef struct { +SysBusDevice parent_obj; + +MemoryRegion iomem; + +uint32_t alpha; +uint32_t leds; +uint32_t switches; +} IntegratorDebugState You forgot to remove these unused fields. I've done so and added

Re: [Qemu-devel] [PATCH 1/1] sd: pl181: fix fifo count read support

2013-10-25 Thread Peter Maydell
On 25 October 2013 12:04, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 11:33 Sat 19 Oct , Jean-Christophe PLAGNIOL-VILLARD wrote: as it's depend on current direction ony change to get that applied? Barebox relay on it so it can work on both qemu and real hw I can't

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/2] sheepdog: make use of copy_policy

2013-10-25 Thread MORITA Kazutaka
At Wed, 23 Oct 2013 16:51:50 +0800, Liu Yuan wrote: v2: - merge the reserved bits This patch set makes use of copy_policy in struct SheepdogInode in order to support recently introduced erasure coding volume in sheepdog. Thanks Yuan Liu Yuan (2): sheepdog: explicitly set copies

[Qemu-devel] [PULL 5/6] target-arm: fix sorting issue of KVM cpreg list

2013-10-25 Thread Peter Maydell
From: Alvise Rigo a.r...@virtualopensystems.com The compare_u64 function was not sorting the KVM cpreg_list in the right way due to the wrong returned value. Since we are comparing two 64bit values we can't simply return their difference if the returned type is int. Signed-off-by: Alvise Rigo

[Qemu-devel] [PULL 0/6] target-arm queue

2013-10-25 Thread Peter Maydell
The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20131025

[Qemu-devel] [PULL 2/6] hw/arm: Tidy up conditional calls to arm_load_kernel

2013-10-25 Thread Peter Maydell
Now that arm_load_kernel doesn't insist on a kernel filename being present, we can remove some unnecessary conditionals in board models. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1379980897-21277-3-git-send-email-peter.mayd...@linaro.org --- hw/arm/omap_sx1.c | 10

[Qemu-devel] [PULL 6/6] integrator: fix Linux boot failure by emulating dbg region

2013-10-25 Thread Peter Maydell
From: Alex Bennée a...@bennee.com Commit 9b8c69243 (since reverted) broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in the kernel code). Relying on a varying

[Qemu-devel] [PULL 4/6] target-arm: sort TCG cpreg list by KVM-style 64 bit ID number

2013-10-25 Thread Peter Maydell
From: Alvise Rigo a.r...@virtualopensystems.com Both KVM and TCG populate the cpreg_list with 64 bit register IDs, but in the TCG side the cpreg_list is sorted using the 32 bit ID version while in the kvm side the 64 bit ID version is used. This patch makes the sorting of the cpreg_list

[Qemu-devel] [PULL 1/6] hw/arm/boot: Make user not specifying a kernel not an error

2013-10-25 Thread Peter Maydell
Typically ARM boards will have some kind of flash which might contain a boot ROM; it's therefore a valid use case to provide only an image for the boot ROM and not require QEMU's internal boot loader at all. Remove the fatal error if -kernel isn't specified. Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 3/6] target-arm: Add CP15 VBAR support

2013-10-25 Thread Peter Maydell
From: Nathan Rossi nathan.ro...@xilinx.com Added Vector Base Address remapping on ARM v7. Signed-off-by: Nathan Rossi nathan.ro...@xilinx.com Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [PMM: removed spurious mask of value with 131] Signed-off-by: Peter Maydell

Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa-hpa on 1GB boundary

2013-10-25 Thread Marcelo Tosatti
On Fri, Oct 25, 2013 at 09:52:34AM +0100, Paolo Bonzini wrote: Because offsets are zero, and lengths match the RAM block lengths, you do not need any complication with aliasing. This still has to be done only for new machine types. Not possible because you just wasted holesize bytes (if

[Qemu-devel] [PULL 00/29] ppc patch queue 2013-10-25

2013-10-25 Thread Alexander Graf
Hi Blue / Aurelien / Anthony, This is my current patch queue for ppc. Please pull. Alex The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700) are available in the git

[Qemu-devel] [PULL 17/29] xics: add cpu_setup callback

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This adds a cpu_setup callback to the XICS device class (as XICS-KVM will do it different), xics_cpu_setup() will call it if it is set. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Alexander Graf ag...@suse.de --- hw/intc/xics.c

[Qemu-devel] [PULL 02/29] pseries: Fix loading of little endian kernels

2013-10-25 Thread Alexander Graf
From: Benjamin Herrenschmidt b...@kernel.crashing.org Try loading the kernel as little endian if it fails big endian. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Reviewed-by: Anton Blanchard an...@samba.org Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppc/spapr.c | 13

[Qemu-devel] [PULL 20/29] xics: Implement H_XIRR_X

2013-10-25 Thread Alexander Graf
From: Benjamin Herrenschmidt b...@kernel.crashing.org This implements H_XIRR_X hypercall in addition to H_XIRR as it is mandatory for PAPR+ and there is no way for the guest to detect whether it is supported or not so just add it. As the Partition Adjunct Option is not supported at the moment,

[Qemu-devel] [PULL 25/29] target-ppc: Use #define for max slb entries

2013-10-25 Thread Alexander Graf
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Instead of opencoding 64 use MAX_SLB_ENTRIES. We don't update the kernel header here. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-ppc/cpu.h | 3 ++-

[Qemu-devel] [PULL 03/29] ppc: Add CFAR, DAR and DSISR to the dictionary of printable registers

2013-10-25 Thread Alexander Graf
From: Tom Musta tommu...@gmail.com The CFAR, DAR and DSISR registers are currently missing from the dictionary of registers that may be printed in the QEMU console. These are interesting registers when debugging. With this patch, the following commands work properly: (qemu) print $cfar

[Qemu-devel] [PULL 19/29] xics: Implement H_IPOLL

2013-10-25 Thread Alexander Graf
From: Benjamin Herrenschmidt b...@kernel.crashing.org This adds support for the H_IPOLL hypercall which the guest uses to poll for a pending interrupt. This hypercall is mandatory for PAPR+ and there is no way for the guest to detect whether it is supported or not so just add it. Signed-off-by:

[Qemu-devel] [PULL 05/29] PPC: Fix L2CR write accesses

2013-10-25 Thread Alexander Graf
Commit 2345f1c01 was supposed to render L2CR writes into noops. Instead, it made them illegal instruction traps which apparently didn't confuse XNU, but can easily confuse other OSs. Fix it up by actually doing nothing when we write to L2CR. Reported-by: Julio Guerra gu...@julio.in

[Qemu-devel] [PULL 22/29] spapr-pci: enable irqfd for INTx

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This enables IRQFD for LSI (level triggered INTx interrupts) by adding a spapr_route_intx_pin_to_irq() callback to the sPAPR PCI host bus. This callback is called to know the global interrupt number to link resampling fd with IRQFD's fd in KVM.

[Qemu-devel] [PULL 10/29] xics: move reset and cpu_setup

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This simple change makes following patches nicer. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Acked-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexander Graf ag...@suse.de --- hw/intc/xics.c | 72

[Qemu-devel] [PULL 04/29] target-ppc: Little Endian Correction to Load/Store Vector Element

2013-10-25 Thread Alexander Graf
From: Tom Musta tommu...@gmail.com The Load Vector Element (lve*x) and Store Vector Element (stve*x) instructions not only byte-swap in Little Endian mode, they also invert the element that is accessed. For example, the RTL for lvehx contains this: eb -- EA[60:63] if Big-Endian byte

[Qemu-devel] [PULL 14/29] xics: convert init() to realize()

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This fixes XICS according new QOM rules. This converts ICS's init() callbacks to realize(). This converts legacy qdev_init_nofail() to property_set(realized). Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Andreas Färber

[Qemu-devel] [PULL 09/29] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-10-25 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au Recent PowerKVM allows the kernel to intercept some RTAS calls from the guest directly. This is used to implement the more efficient in-kernel XICS for example. qemu is still responsible for assigning the RTAS token numbers however, and needs to

[Qemu-devel] [PULL 12/29] xics: replace fprintf with error_report

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This replaces old-style fprintf with new style error_report. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Andreas Färber afaer...@suse.de Acked-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexander Graf ag...@suse.de

[Qemu-devel] [PULL 06/29] spapr: increase temporary fdt buffer size

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru At the moment the size of the buffer is set to 64K which is enough for approximately 150 VCPUs which is not the limit. This increases the buffer up to 256K which allows having a tree for approximately 600 VCPUs which is way beyond the real number we

[Qemu-devel] [PULL 18/29] xics-kvm: Support for in-kernel XICS interrupt controller

2013-10-25 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au Recent (host) kernels support emulating the PAPR defined XICS interrupt controller system within KVM. This patch allows qemu to initialize and configure the in-kernel XICS, and keep its state in sync with qemu's XICS state as necessary. This should

[Qemu-devel] [PULL 21/29] xics-kvm: enable irqfd for MSI

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This enables IRQFD support for sPAPR. The feature decreases the latency of interrupt handling. To enable IRQFD for MSI, this sets kvm_gsi_direct_mapping to true which enables direct MSI mapping. To enable IRQFD for LSI (level triggered INTx interrupts),

[Qemu-devel] [PULL 23/29] target-ppc: Update slb array with correct index values.

2013-10-25 Thread Alexander Graf
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Without this, a value of rb=0 and rs=0 results in replacing the 0th index. This can be observed when using gdb remote debugging support. (gdb) x/10i do_fork 0xc0085330 do_fork:Cannot access memory at address

[Qemu-devel] [PULL 29/29] spapr: Use DeviceClass::fw_name for device tree CPU node

2013-10-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Instead of relying on cpu_model, obtain the device tree node label per CPU. Use DeviceClass::fw_name as source. Whenever DeviceClass::fw_name is unknown, default to PowerPC,UNKNOWN. As a consequence, spapr_fixup_cpu_dt() can operate on each CPU's fw_name,

[Qemu-devel] [PULL 26/29] dump-guest-memory: Check for the correct return value

2013-10-25 Thread Alexander Graf
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We should check for error with s-note_size Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dump.c

[Qemu-devel] [PULL 28/29] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-10-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Set the expected values for POWER7, POWER7+, POWER8 and POWER5+. Note that POWER5+ and POWER7+ are intentionally lacking the '+', so the lack of a POWER7P family constitutes no problem. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander

[Qemu-devel] [PULL 27/29] target-ppc: dump-guest-memory support

2013-10-25 Thread Alexander Graf
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch add support for dumping guest memory using dump-guest-memory monitor command. Before patch: (qemu) dump-guest-memory testcrash this feature or command is not currently supported (qemu) After patch: (qemu) dump-guest-memory

[Qemu-devel] [PULL 13/29] xics: add pre_save/post_load dispatchers

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru The upcoming support of in-kernel XICS will redefine migration callbacks for both ICS and ICP so classes and callback pointers are added. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Alexander Graf ag...@suse.de --- hw/intc/xics.c

[Qemu-devel] [PULL 24/29] target-ppc: Check for error on address translation in memsave command

2013-10-25 Thread Alexander Graf
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com When we translate the virtual address to physical check for error. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- cpus.c | 5 - 1 file changed, 4 insertions(+), 1

[Qemu-devel] [PULL 11/29] spapr: move cpu_setup after kvmppc_set_papr

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This moves the xics_cpu_setup() call after kvmppc_set_papr() in order to get VCPUs initialized as this is required by upcoming XICS-KVM. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Acked-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by:

[Qemu-devel] [PULL 07/29] spapr: Add ibm, purr property on power7 and newer

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru PAPR+ says that no ibm,purr tells the guest that H_PURR is not supported. However some guests still try calling H_PURR on POWER7 unless the property is present and equal to 0. This adds the property for CPUs supporting the PURR special register.

[Qemu-devel] [PULL 08/29] spapr-rtas: fix h_rtas parameters reading

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru On the real hardware, RTAS is called in real mode and therefore top 4 bits of the address passed in the call are ignored. So does the patch. This converts h_rtas() to use existing rtas_ld() handlers. This fixed rtas_ld()/rtas_st() to ignore top 4 bits.

[Qemu-devel] [PATCHv1 3/4] Timers: Instrument timer_mod

2013-10-25 Thread Alex Bligh
Add instrumentation for timer_mod to allow measurement of the average time delta to expiry plus the number of short delta periods. This is only run when logging to a file because getting the clock value may add appreciable expense. Signed-off-by: Alex Bligh a...@alex.org.uk --- qemu-timer.c |

[Qemu-devel] [PATCHv1 0/4] Timers: add timer debugging through -timer-debug-log

2013-10-25 Thread Alex Bligh
This patch set adds facilities for debugging timers using the additional command line option -timer-debug-log=FILE. If this option is selected, a debugging file will be written showing information about the current state of timers in the system, which the author feels will be useful for debugging

[Qemu-devel] [PATCHv1 1/4] Timers: add debugging macros wrapping timer functions and debug structures

2013-10-25 Thread Alex Bligh
Add debugging versions of functions creating timers to record the file and line number that they were called from. Add macros to call these transparently. Add fields to timer struct to store debugging information. Note this patch contains one checkpatch.pl warning (space before parenthesis) and a

[Qemu-devel] [PATCHv1 2/4] Timers: add command line option -timer-debug-log

2013-10-25 Thread Alex Bligh
Add a command line option -timer-debug-log which takes the name of a file to which periodic timer debugging information will be written. Signed-off-by: Alex Bligh a...@alex.org.uk --- include/qemu/timer.h |1 + qemu-options.hx | 11 +++ qemu-timer.c |1 + vl.c

[Qemu-devel] [PATCHv1 4/4] Timers: produce timer-debug-log file

2013-10-25 Thread Alex Bligh
Write a timer-debug-log file if enabled containing data about the currently existing timers. Signed-off-by: Alex Bligh a...@alex.org.uk --- qemu-timer.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/qemu-timer.c b/qemu-timer.c

[Qemu-devel] [PULL 16/29] xics: split to xics and xics-common

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru The upcoming XICS-KVM support will use bits of emulated XICS code. So this introduces new level of hierarchy - xics-common class. Both emulated XICS and XICS-KVM will inherit from it and override class callbacks when required. The new xics-common class

[Qemu-devel] [PULL 15/29] xics: add missing const specifiers to TypeInfo

2013-10-25 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This adds missing const specifiers to ICS and ICP TypeInfo's. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/intc/xics.c | 4 ++-- 1 file changed, 2

Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa-hpa on 1GB boundary

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 20:50, Marcelo Tosatti ha scritto: On Fri, Oct 25, 2013 at 09:52:34AM +0100, Paolo Bonzini wrote: Because offsets are zero, and lengths match the RAM block lengths, you do not need any complication with aliasing. This still has to be done only for new machine types. Not

Re: [Qemu-devel] [PATCHv1 0/4] Timers: add timer debugging through -timer-debug-log

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 23:30, Alex Bligh ha scritto: This patch set adds facilities for debugging timers using the additional command line option -timer-debug-log=FILE. If this option is selected, a debugging file will be written showing information about the current state of timers in the system,

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/29] ppc patch queue 2013-10-25

2013-10-25 Thread Mark Cave-Ayland
On 25/10/13 22:27, Alexander Graf wrote: Hi Blue / Aurelien / Anthony, This is my current patch queue for ppc. Please pull. Alex Hi Alex, Did you get my repost of the PPC PCI configuration space patch to qemu-devel here:

  1   2   >