[Qemu-devel] [PULL 24/26] target-arm: Make vbar_write writeback to any CPREG

2014-05-27 Thread Peter Maydell
From: Edgar E. Iglesias edgar.igles...@xilinx.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com Message-id: 1400980132-25949-22-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PULL 00/33] Block patches

2014-05-27 Thread Peter Maydell
On 23 May 2014 16:41, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-22 19:04:49 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA

2014-05-27 Thread Stefano Stabellini
On Fri, 23 May 2014, Roger Pau Monne wrote: ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the hypervisor are translated to ENOENT. Also, the error code is returned in errno if the call returns -1, so compare the error code with the value in errno instead of the value

Re: [Qemu-devel] [PATCH v2 06/11] block: make 'top' argument to block-commit optional

2014-05-27 Thread Eric Blake
On 05/27/2014 08:28 AM, Jeff Cody wrote: Now that active layer block-commit is supported, the 'top' argument no longer needs to be mandatory. Change it to optional, with the default being the active layer in the device chain. Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Benoit

Re: [Qemu-devel] [v2 PATCH] target-mips: implement UserLocal Register

2014-05-27 Thread Richard Henderson
On 05/27/2014 09:46 AM, Petar Jovanovic wrote: Can you please add more thoughts on this? Within the same translation block, we can have an instruction that alters HWrena (mtc0) and rdwhr instruction that will behave differently based on content of HWrena. The normal way to handle this is to

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA

2014-05-27 Thread Roger Pau Monné
On 27/05/14 18:18, Stefano Stabellini wrote: On Fri, 23 May 2014, Roger Pau Monne wrote: ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the hypervisor are translated to ENOENT. Also, the error code is returned in errno if the call returns -1, so compare the error code with

[Qemu-devel] [PULL 14/26] target-arm: Add SPSR entries for EL2/HYP and EL3/MON

2014-05-27 Thread Peter Maydell
From: Edgar E. Iglesias edgar.igles...@xilinx.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com Message-id: 1400980132-25949-12-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [v2 PATCH] target-mips: implement UserLocal Register

2014-05-27 Thread Petar Jovanovic
The normal way to handle this is to end the translation block whenever we issue an instruction that could (unpredictably) affect how the TB is translated. In the mips translator, this is done via ctx-bstate = BS_STOP. There are plenty of examples within gen_mtc0 already. Yes, I am aware of

Re: [Qemu-devel] [v3][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: The OpRegion shouldn't be mapped 1:1 because the address in the host can't be used in the guest directly. This patch traps read and write access to the opregion of the Intel GPU config space (offset 0xfc). The original patch is from Jean Guyader

[Qemu-devel] [PULL 25/26] target-arm: A64: Register VBAR_EL2

2014-05-27 Thread Peter Maydell
From: Edgar E. Iglesias edgar.igles...@xilinx.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com Message-id: 1400980132-25949-23-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH v2 07/11] block: Accept node-name arguments for block-commit

2014-05-27 Thread Eric Blake
On 05/27/2014 08:28 AM, Jeff Cody wrote: This modifies the block operation block-commit so that it will accept node-name arguments for either 'top' or 'base' BDS. The filename and node-name are mutually exclusive to each other; i.e.: top and top-node-name are mutually exclusive

Re: [Qemu-devel] [v3][PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: basic gfx passthrough support: - add a vga type for gfx passthrough - retrieve VGA bios from sysfs, then load it to guest 0xC - register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx The original patch is from Weidong Han

Re: [Qemu-devel] [v2 PATCH] target-mips: implement UserLocal Register

2014-05-27 Thread Richard Henderson
On 05/27/2014 10:28 AM, Petar Jovanovic wrote: The normal way to handle this is to end the translation block whenever we issue an instruction that could (unpredictably) affect how the TB is translated. In the mips translator, this is done via ctx-bstate = BS_STOP. There are plenty of

Re: [Qemu-devel] [Xen-devel] [v3][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-05-27 Thread Stefano Stabellini
On Tue, 27 May 2014, Konrad Rzeszutek Wilk wrote: On Mon, May 26, 2014 at 05:43:06PM +0800, Tiejun Chen wrote: ISA bridge is needed since Intel gfx drive will probe it instead of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that only need to expose ISA bridge to let

Re: [Qemu-devel] QEMU build broken

2014-05-27 Thread Sean Bruno
On Fri, 2014-05-09 at 12:26 -0500, Stacey Son wrote: On May 9, 2014, at 4:55 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 9 May 2014 09:57, Riku Voipio riku.voi...@linaro.org wrote: On 8 May 2014 17:54, Peter Maydell peter.mayd...@linaro.org wrote: Ah, bsd-user. Do you actually

[Qemu-devel] [PULL 05/26] target-arm/translate.c: Clean up mmu index handling for ldrt/strt

2014-05-27 Thread Peter Maydell
Clean up the mmu index handling for ldrt/strt insns: instead of a flag 'user' indicating whether to treat the store as user mode or not, use 'memidx' to indicate the correct memory index to use. Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Peter Maydell

Re: [Qemu-devel] [v3][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to passthrough these registers of physical host bridge to guest because emulated host bridge in guest doesn't have these mappings. The original patch is from Weidong Han weidong.han @

Re: [Qemu-devel] [v3][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: Implement that pci host bridge to specific to passthrough. Actually thsi just inherit the standard one. Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- v3: * Just fix this patch head description typo. v2: * New patch.

Re: [Qemu-devel] [Qemu-stable] [PATCH 09/14] blockdev: Plug memory leak in drive_init()

2014-05-27 Thread Benoît Canet
The Tuesday 27 May 2014 à 18:13:12 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Monday 26 May 2014 à 19:37:10 (+0200), Markus Armbruster wrote : Introduced in commit f298d07. Spotted by Coverity. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 15/26] target-arm: A64: Introduce aarch64_banked_spsr_index()

2014-05-27 Thread Peter Maydell
From: Edgar E. Iglesias edgar.igles...@xilinx.com Add aarch64_banked_spsr_index(), used to map an Exception Level to an index in the banked_spsr array. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com Message-id:

[Qemu-devel] [PULL 20/26] target-arm: A64: Forbid ERET to higher or unimplemented ELs

2014-05-27 Thread Peter Maydell
From: Edgar E. Iglesias edgar.igles...@xilinx.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com Message-id: 1400980132-25949-18-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH v7 2/3] VFIO: Helper function to retrieve container fd

2014-05-27 Thread Alex Williamson
On Wed, 2014-05-28 at 01:17 +1000, Gavin Shan wrote: On Tue, May 27, 2014 at 08:16:47AM -0600, Alex Williamson wrote: On Tue, 2014-05-27 at 18:51 +1000, Gavin Shan wrote: The patch adds function vfio_get_container_fd_by_group_id() to retrieve the container's fd of the specified VFIO group.

Re: [Qemu-devel] QEMU build broken

2014-05-27 Thread Peter Maydell
On 27 May 2014 18:53, Sean Bruno sbr...@ignoranthack.me wrote: On Fri, 2014-05-09 at 12:26 -0500, Stacey Son wrote: As for restructuring the (25,000+ lines of) patches Sean has agreed to help with that given that I am busy with some other things at the moment. Hey folks, Sean here. I'm

Re: [Qemu-devel] [PATCH v2 0/2] prep: Remove some clearly wrong assumptions

2014-05-27 Thread Hervé Poussineau
Ping. Le 20/05/2014 07:34, Hervé Poussineau a écrit : Ping. Le 23/04/2014 23:19, Hervé Poussineau a écrit : Hi, These two patches remove some bugs for a PReP firmware. Note that first patch is very PReP-oriented, and breaks OHW compatibility with other QEMU emulations (oldworld and

[Qemu-devel] [PATCH v1 0/2] testing SMBIOS tables

2014-05-27 Thread Gabriel L. Somlo
This patch set adds testing for SMBIOS tables. Since I'm piggybacking on the existing ACPI test infrastructure, I've renamed acpi-test.c to bios-tables-test.c (1/2), and added the smbios testing to the renamed file (2/2). Thanks, Gabriel PS. This came up as part of the conversation surrounding

[Qemu-devel] [PATCH v1 1/2] tests: rename acpi-test to bios-tables-test

2014-05-27 Thread Gabriel L. Somlo
The test harness for acpi (generating a boot disk, starting qemu, waiting for the BIOS to finish booting before examining guest memory, etc.) is perfectly suited for testing other bios tables beside acpi, such as e.g., smbios. This patch renames acpi-test to bios-tables-test to reflect that, and

[Qemu-devel] [PATCH v1 2/2] tests: add smbios testing

2014-05-27 Thread Gabriel L. Somlo
Add tests to find and verify the smbios entry point structure, and to walk and perform checks on the actual smbios tables. Suggested-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Gabriel Somlo so...@cmu.edu --- tests/bios-tables-test.c | 126

Re: [Qemu-devel] [PATCH 0/2] tcg/optimize fix for known-zero bits

2014-05-27 Thread Richard Henderson
On 05/23/2014 11:57 AM, Richard Henderson wrote: This specific bug may only be visible on s390. It is unique in that it has a 32-bit register move operation that does not modify the high bits of the 64-bit register. Unlike x86_64 + aarch64 which zero the high bits, or sparc64 + ppc64 that

Re: [Qemu-devel] [Qemu-stable] [PATCH 09/14] blockdev: Plug memory leak in drive_init()

2014-05-27 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 18:13:12 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Monday 26 May 2014 à 19:37:10 (+0200), Markus Armbruster wrote : Introduced in commit f298d07. Spotted by Coverity.

Re: [Qemu-devel] [PATCH V9 2/4] raw, qcow2: don't convert file size to sector size

2014-05-27 Thread Eric Blake
On 05/27/2014 02:22 AM, Chen Fan wrote: From: Hu Tao hu...@cn.fujitsu.com and avoid converting it back later. And round up file size to nearest sector. The fact that you started a sentence with And makes me wonder if this should be two patches. Signed-off-by: Hu Tao hu...@cn.fujitsu.com

[Qemu-devel] [PULL 00/18] tcg patch queue

2014-05-27 Thread Richard Henderson
A collection of 4 patch sets accumulated over the last three weeks. The final one fixes bugs visible in the s390 port, and (shortly) in the ppc64 port. Please pull. r~ The following changes since commit 93f94f9018229f146ed6bbe9e5ff72d67e4bd7ab: Merge remote-tracking branch

[Qemu-devel] [PULL 03/18] tcg: Push tcg-runtime routines into exec/helper-*

2014-05-27 Thread Richard Henderson
Rather than special casing them, use the standard mechanisms for tcg helper generation. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 1 + include/exec/helper-head.h | 12 include/exec/helper-proto.h | 1 + include/exec/helper-tcg.h | 1 +

[Qemu-devel] [PULL 08/18] tcg: Save flags and computed sizemask in TCGHelperInfo

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-tcg.h | 44 tcg/tcg.c | 7 +++ 2 files changed, 35 insertions(+), 16 deletions(-) diff --git a/include/exec/helper-tcg.h b/include/exec/helper-tcg.h index

[Qemu-devel] [PULL 06/18] tcg: Move side effects out of dh_sizemask

2014-05-27 Thread Richard Henderson
Moving them into dh_arg instead. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 18 ++ include/exec/helper-head.h | 5 ++--- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h

[Qemu-devel] [PULL 09/18] tcg: Remove sizemask and flags arguments to tcg_gen_callN

2014-05-27 Thread Richard Henderson
Take them from the TCGHelperInfo struct instead. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 18 ++ include/exec/helper-head.h | 3 +-- tcg/tcg.c | 17 +++-- tcg/tcg.h | 4 ++-- 4 files

Re: [Qemu-devel] [Qemu-stable] [PATCH 09/14] blockdev: Plug memory leak in drive_init()

2014-05-27 Thread Benoît Canet
The Tuesday 27 May 2014 à 21:11:45 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 18:13:12 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Monday 26 May 2014 à 19:37:10 (+0200), Markus

[Qemu-devel] [PULL 11/18] tcg: Allow the debug_frame data structure to be constant

2014-05-27 Thread Richard Henderson
Adjust the FDE to point to the code_buffer after we've copied it to the image, rather than requiring that the backend set it prior. This allows the backend to use read-only storage for its data. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg.c | 18 +++--- 1 file

[Qemu-devel] [PULL 10/18] tcg: Move size effects out of dh_arg

2014-05-27 Thread Richard Henderson
Tidying the initialization of the args arrays at the same time. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 87 -- include/exec/helper-head.h | 2 +- 2 files changed, 39 insertions(+), 50 deletions(-) diff --git

[Qemu-devel] [PULL 13/18] tcg-aarch64: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/aarch64/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 77bb6d9..56dae66 100644 --- a/tcg/aarch64/tcg-target.c +++

[Qemu-devel] [PULL 16/18] tcg-sparc: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/sparc/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 17ff577..40f2ec1 100644 --- a/tcg/sparc/tcg-target.c +++

[Qemu-devel] [PULL 14/18] tcg-arm: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 538ca2a..e40301c 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@

[Qemu-devel] [PULL 18/18] tcg/optimize: Remember garbage high bits for 32-bit ops

2014-05-27 Thread Richard Henderson
For a 64-bit host, the high bits of a register after a 32-bit operation are undefined. Adjust the temps mask for all 32-bit ops to reflect that. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 33 ++--- 1 file changed, 26 insertions(+), 7

[Qemu-devel] [PULL 15/18] tcg-s390: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/s390/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 07164e5..63e9c82 100644 --- a/tcg/s390/tcg-target.c +++

[Qemu-devel] [PULL 17/18] tcg/optimize: Move updating of gen_opc_buf into tcg_opt_gen_mov*

2014-05-27 Thread Richard Henderson
No functional change, just reduce a bit of redundancy. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 117 +++-- 1 file changed, 56 insertions(+), 61 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

Re: [Qemu-devel] [PATCH V9 3/4] raw-posix: Add full image preallocation option

2014-05-27 Thread Eric Blake
On 05/27/2014 02:22 AM, Chen Fan wrote: From: Hu Tao hu...@cn.fujitsu.com This patch adds a new option preallocation for raw format, and implements full preallocation by writing zeros to disk. The metadata option is changed to use posix_fallocate() to ensure subsquent writes to image file

[Qemu-devel] [PULL 05/18] tcg: Inline tcg_gen_helperN

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 12 ++-- tcg/tcg-op.h | 7 --- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h index abde615..208d1d2 100644 ---

Re: [Qemu-devel] [ping: PATCH v2 0/3] e1000: allow model/device_id selection on command line

2014-05-27 Thread Gabriel L. Somlo
ping ? On Wed, May 21, 2014 at 02:27:41PM -0400, Gabriel L. Somlo wrote: This started out as a single patch (now patch 2/3): Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. New in v2: - moved check for 8257x

Re: [Qemu-devel] [PATCH v2 08/11] block: extend block-commit to accept a string for the backing file

2014-05-27 Thread Eric Blake
On 05/27/2014 08:28 AM, Jeff Cody wrote: On some image chains, QEMU may not always be able to resolve the filenames properly, when updating the backing file of an image after a block commit. For instance, certain relative pathnames may fail, or drives may have been specified originally by

Re: [Qemu-devel] [PATCH v6 5/7] vfio: Introduce VFIO address spaces

2014-05-27 Thread Alex Williamson
On Sun, 2014-05-25 at 23:36 +1000, David Gibson wrote: On Sun, May 25, 2014 at 12:16:20PM +0200, Alexander Graf wrote: On 24.05.14 05:12, Alexey Kardashevskiy wrote: On 05/24/2014 07:15 AM, Alexander Graf wrote: On 23.05.14 18:16, Alexey Kardashevskiy wrote: On 05/23/2014 10:05 PM,

Re: [Qemu-devel] [Qemu-stable] [PATCH 09/14] blockdev: Plug memory leak in drive_init()

2014-05-27 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 21:11:45 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 18:13:12 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The

[Qemu-devel] [PATCH 0/1] Refresh FreeBSD System Call Numbers

2014-05-27 Thread Sean Bruno
This is the first step in firing off the bsd-user work done by Stacey Son s...@freebsd.org I have attempted to track head and keep things updated and am submitting these changes in smaller, digestible chunks for everyone's review. Stacey Son (1): bsd-user: refresh freebsd system call numbers

[Qemu-devel] [PATCH 1/1] bsd-user: refresh freebsd system call numbers

2014-05-27 Thread Sean Bruno
From: Stacey Son s...@freebsd.org Update FreeBSD system call numbers in freebsd/syscall_nr.h. Reviewed-by: Ed Maste ema...@freebsd.org --- bsd-user/freebsd/syscall_nr.h | 813 +++--- 1 file changed, 445 insertions(+), 368 deletions(-) diff --git

Re: [Qemu-devel] QEMU build broken

2014-05-27 Thread Sean Bruno
On Tue, 2014-05-27 at 19:52 +0100, Peter Maydell wrote: On 27 May 2014 18:53, Sean Bruno sbr...@ignoranthack.me wrote: On Fri, 2014-05-09 at 12:26 -0500, Stacey Son wrote: As for restructuring the (25,000+ lines of) patches Sean has agreed to help with that given that I am busy with some

Re: [Qemu-devel] [PATCH v2 0/3] e1000: allow model/device_id selection on command line

2014-05-27 Thread Michael S. Tsirkin
On Wed, May 21, 2014 at 02:27:41PM -0400, Gabriel L. Somlo wrote: This started out as a single patch (now patch 2/3): Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. New in v2: - moved check for 8257x out of

[Qemu-devel] [PULL 04/18] tcg: Use helper-gen.h in tcg-op.h

2014-05-27 Thread Richard Henderson
No need to open-code the setup of the builtin helpers. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-op.h | 175 +-- 1 file changed, 25 insertions(+), 150 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index

[Qemu-devel] [PULL 01/18] tcg: Optimize brcond2 and setcond2 ne/eq

2014-05-27 Thread Richard Henderson
If either the high or low pair can be resolved, we can simplify to either a constant or to a 32-bit comparison. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 94 ++ 1 file changed, 94 insertions(+) diff --git

Re: [Qemu-devel] [Qemu-stable] [PATCH 09/14] blockdev: Plug memory leak in drive_init()

2014-05-27 Thread Benoît Canet
The Tuesday 27 May 2014 à 21:44:15 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 21:11:45 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 18:13:12 (+0200), Markus

[Qemu-devel] [PULL 07/18] tcg: Register the helper info struct rather than the name

2014-05-27 Thread Richard Henderson
This will let us find all the info from the hash table. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 4679c19..56ef0fd 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -356,7 +356,7

[Qemu-devel] [PULL 12/18] tcg-i386: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index a373073..d910233 100644 --- a/tcg/i386/tcg-target.c +++

Re: [Qemu-devel] [PATCH v2 09/11] block: add ability for block-stream to use node-name

2014-05-27 Thread Eric Blake
On 05/27/2014 08:28 AM, Jeff Cody wrote: This adds the ability for block-stream to use node-name arguments for base, to specify the backing image to stream from. Both 'base' and 'base-node-name' are optional, but mutually exclusive. Either can be specified, but not both together. The

[Qemu-devel] [PULL 02/18] tcg: Invert the inclusion of helper.h

2014-05-27 Thread Richard Henderson
Rather than include helper.h with N values of GEN_HELPER, include a secondary file that sets up the macros to include helper.h. This minimizes the files that must be rebuilt when changing the macros for file N. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h

Re: [Qemu-devel] [PATCH v2 09/11] block: add ability for block-stream to use node-name

2014-05-27 Thread Jeff Cody
On Tue, May 27, 2014 at 02:06:00PM -0600, Eric Blake wrote: On 05/27/2014 08:28 AM, Jeff Cody wrote: This adds the ability for block-stream to use node-name arguments for base, to specify the backing image to stream from. Both 'base' and 'base-node-name' are optional, but mutually

Re: [Qemu-devel] [PATCH v2 10/11] block: add backing-file option to block-stream

2014-05-27 Thread Eric Blake
On 05/27/2014 08:28 AM, Jeff Cody wrote: On some image chains, QEMU may not always be able to resolve the filenames properly, when updating the backing file of an image after a block job. For instance, certain relative pathnames may fail, or drives may have been specified originally by file

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-27 Thread Bandan Das
Paolo Bonzini pbonz...@redhat.com writes: CS.RPL is not equal to the CPL in the few instructions between setting CR0.PE and reloading CS. We get this right in the common case, because writes to CR0 do not modify the CPL, but it would not be enough if an SMI comes exactly during that brief

Re: [Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM, user-mode emulation and VM86 mode

2014-05-27 Thread Bandan Das
Paolo Bonzini pbonz...@redhat.com writes: With the next patch, these need to be correct or VM86 tasks have the wrong CPL. The flags are basically what the Intel VMX documentation say is mandatory for entry into a VM86 guest. Are you referring to 26.3.1.2 ? Just a nit, I guess it helps to

Re: [Qemu-devel] [PATCH v7 2/3] VFIO: Helper function to retrieve container fd

2014-05-27 Thread Benjamin Herrenschmidt
On Tue, 2014-05-27 at 12:27 -0600, Alex Williamson wrote: Ugh, the patches are flying too fast, I can't even keep track that this is a QEMU patch. I'm not as concerned about the get in QEMU, but do we really want to create a future hotplug issue where we've handed out a file descriptor to

Re: [Qemu-devel] [PULL 00/18] tcg patch queue

2014-05-27 Thread Richard Henderson
On 05/27/2014 12:12 PM, Richard Henderson wrote: A collection of 4 patch sets accumulated over the last three weeks. The final one fixes bugs visible in the s390 port, and (shortly) in the ppc64 port. Please pull. Gah. I overwrote the branch that contained the R-B tags that I'd received.

[Qemu-devel] [Bug 1322302] [NEW] local provider is very slow to tranistion from agent-status: pending

2014-05-27 Thread Launchpad Bug Tracker
You have been subscribed to a public bug: ubuntu@trusty-installer:~$ juju version 1.18.3-trusty-amd64 ubuntu@trusty-installer:~$ dpkg -l juju-core ii juju-core1.18.3-0ubuntu1~1 amd64 Juju is devops distilled - client ubuntu@trusty-installer:~$ dpkg -l juju-local ii

[Qemu-devel] [PATCH 0/2] aarch64 disassembler improvement

2014-05-27 Thread Richard Henderson
Pet peeve: no support for adrp, which we use frequently in aarch64 code gen. r~ Richard Henderson (2): disas/libvixl: Update README for version base disas/libvixl: Properly display pc-relative addresses disas/arm-a64.cc| 1 + disas/libvixl/README| 2 +-

[Qemu-devel] [PATCH 1/2] disas/libvixl: Update README for version base

2014-05-27 Thread Richard Henderson
From: Richard Henderson r...@redhat.com Signed-off-by: Richard Henderson r...@redhat.com --- disas/libvixl/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/libvixl/README b/disas/libvixl/README index 96814a5..a0ecac3 100644 --- a/disas/libvixl/README +++

[Qemu-devel] [PATCH 2/2] disas/libvixl: Properly display pc-relative addresses

2014-05-27 Thread Richard Henderson
From: Richard Henderson r...@redhat.com This includes handling the ADRP instruction. Signed-off-by: Richard Henderson r...@redhat.com --- disas/arm-a64.cc| 1 + disas/libvixl/a64/disasm-a64.cc | 32 disas/libvixl/a64/disasm-a64.h | 2 ++ 3

[Qemu-devel] [Bug 1322302] Re: local provider is very slow to tranistion from agent-status: pending

2014-05-27 Thread Robie Basak
I think investigation needs to start from a qemu performance perspective. It may be that uvtool needs to tell libvirt to tell qemu to do something differently, but in that case I need to know what. ** Project changed: uvtool = qemu ** Project changed: qemu = qemu (Ubuntu) ** Changed in: qemu

[Qemu-devel] [PULL v2 02/18] tcg: Invert the inclusion of helper.h

2014-05-27 Thread Richard Henderson
Rather than include helper.h with N values of GEN_HELPER, include a secondary file that sets up the macros to include helper.h. This minimizes the files that must be rebuilt when changing the macros for file N. Reviewed-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Richard Henderson

[Qemu-devel] [PULL v2 11/18] tcg: Allow the debug_frame data structure to be constant

2014-05-27 Thread Richard Henderson
Adjust the FDE to point to the code_buffer after we've copied it to the image, rather than requiring that the backend set it prior. This allows the backend to use read-only storage for its data. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg.c | 18 +++--- 1 file

[Qemu-devel] [PULL v2 07/18] tcg: Register the helper info struct rather than the name

2014-05-27 Thread Richard Henderson
This will let us find all the info from the hash table. Reviewed-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 4679c19..56ef0fd 100644

[Qemu-devel] [PULL v2 08/18] tcg: Save flags and computed sizemask in TCGHelperInfo

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-tcg.h | 44 tcg/tcg.c | 7 +++ 2 files changed, 35 insertions(+), 16 deletions(-) diff --git a/include/exec/helper-tcg.h b/include/exec/helper-tcg.h index

[Qemu-devel] [PULL v2 05/18] tcg: Inline tcg_gen_helperN

2014-05-27 Thread Richard Henderson
Reviewed-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 12 ++-- tcg/tcg-op.h | 7 --- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/include/exec/helper-gen.h

[Qemu-devel] [PULL v2 13/18] tcg-aarch64: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/aarch64/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 77bb6d9..56dae66 100644 --- a/tcg/aarch64/tcg-target.c +++

[Qemu-devel] [PULL v2 06/18] tcg: Move side effects out of dh_sizemask

2014-05-27 Thread Richard Henderson
Moving them into dh_arg instead. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 18 ++ include/exec/helper-head.h | 5 ++--- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h

[Qemu-devel] [PATCH] qcow2: preallocate() extands image less enough

2014-05-27 Thread 蒙聪
cow2_alloc_cluster_offset() sets the host_offset pointing to the first byte of the cluster referenced by guest_offset other than to the exact byte referenced by guest_offset. In this case, preallocate() fails to extend the image large enough. This bug can be reproduced by following steps: $

[Qemu-devel] [PULL v2 04/18] tcg: Use helper-gen.h in tcg-op.h

2014-05-27 Thread Richard Henderson
No need to open-code the setup of the builtin helpers. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-op.h | 175 +-- 1 file changed, 25 insertions(+), 150 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index

[Qemu-devel] [PULL v2 15/18] tcg-s390: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/s390/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 07164e5..63e9c82 100644 --- a/tcg/s390/tcg-target.c +++

Re: [Qemu-devel] [RFC PATCH 3/4] cpu_exec: Add sleeping algorithm

2014-05-27 Thread Sebastian Tanase
Hello, First of all thank you for your feedback. - Mail original - De: Paolo Bonzini pbonz...@redhat.com À: Sebastian Tanase sebastian.tan...@openwide.fr, qemu-devel@nongnu.org Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, peter maydell peter.mayd...@linaro.org,

[Qemu-devel] [PULL v2 18/18] tcg/optimize: Remember garbage high bits for 32-bit ops

2014-05-27 Thread Richard Henderson
For a 64-bit host, the high bits of a register after a 32-bit operation are undefined. Adjust the temps mask for all 32-bit ops to reflect that. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 33

[Qemu-devel] [RFC PATCH 4/4] cpu_exec: Print to console if the guest is late

2014-05-27 Thread Sebastian Tanase
If the align option is enabled, we print to the user whenever the guest clock is behind the host clock in order for he/she to have a hint about the actual performance. The maximum print interval is 2s so as not to spam the console. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr

Re: [Qemu-devel] [PATCH 0/2] aarch64 disassembler improvement

2014-05-27 Thread Peter Maydell
On 27 May 2014 21:43, Richard Henderson r...@twiddle.net wrote: Pet peeve: no support for adrp, which we use frequently in aarch64 code gen. Should be fixed in the next version of libvixl; I'd prefer to wait, personally... disas/libvixl: Update README for version base Doh. This obviously

[Qemu-devel] [RFC PATCH 2/4] icount: Make icount_time_shift available everywhere

2014-05-27 Thread Sebastian Tanase
icount_time_shift is used for calculting the delay qemu has to sleep in order to synchronise the host and guest clocks. Therefore, we need it in cpu-exec.c. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille Bégué camille.be...@openwide.fr --- cpus.c|

[Qemu-devel] [RFC PATCH 0/4] icount: Implement delay algorithm between guest and host clocks

2014-05-27 Thread Sebastian Tanase
The icount option already implemented in QEMU allows the guest to run at a theoretical frequency of 1/(2^N) GHz (N is the icount parameter). The goal of this patch is to have a real guest frequency close to the one imposed by using the icount option. The main idea behind the algorithm is that

[Qemu-devel] [RFC PATCH 1/4] icount: Add 'align' and 'icount' options

2014-05-27 Thread Sebastian Tanase
The align option is used for activating the align algorithm in order to synchronise the host clock and the guest clock. Therefore we slightly modified the existing icount option. Thus, the new way to specify an icount is '-icount [icount=][N|auto][,align]' Signed-off-by: Sebastian Tanase

[Qemu-devel] [PATCH] qcow2: preallocate() extands image less enough

2014-05-27 Thread 蒙聪
cow2_alloc_cluster_offset() sets the host_offset pointing to the first byte of the cluster referenced by guest_offset other than to the exact byte referenced by guest_offset. In this case, preallocate() fails to extend the image large enough. This bug can be reproduced by following steps: $

Re: [Qemu-devel] [PATCH V9 3/4] raw-posix: Add full image preallocation option

2014-05-27 Thread Peter Lieven
Am 27.05.2014 um 21:24 schrieb Eric Blake ebl...@redhat.com: On 05/27/2014 02:22 AM, Chen Fan wrote: From: Hu Tao hu...@cn.fujitsu.com This patch adds a new option preallocation for raw format, and implements full preallocation by writing zeros to disk. The metadata option is changed to

Re: [Qemu-devel] [PULL 00/24] tcg mips updates

2014-05-27 Thread Peter Maydell
On 24 May 2014 16:53, Richard Henderson r...@twiddle.net wrote: Thanks to Paolo for the review. r~ The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-22 19:04:49 +0100) are

[Qemu-devel] [PULL v2 00/18] tcg patch queue

2014-05-27 Thread Richard Henderson
A collection of 4 patch sets accumulated over the last three weeks. The final one fixes bugs visible in the s390 port, and (shortly) in the ppc64 port. This time with Paolo's and Alex's Reviewed-by tags. Please pull. r~ Richard Henderson (18): tcg: Optimize brcond2 and setcond2 ne/eq

[Qemu-devel] [PULL v2 10/18] tcg: Move size effects out of dh_arg

2014-05-27 Thread Richard Henderson
Tidying the initialization of the args arrays at the same time. Reviewed-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/helper-gen.h | 87 -- include/exec/helper-head.h | 2 +- 2 files

[Qemu-devel] [PULL v2 17/18] tcg/optimize: Move updating of gen_opc_buf into tcg_opt_gen_mov*

2014-05-27 Thread Richard Henderson
No functional change, just reduce a bit of redundancy. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 117 +++-- 1 file changed, 56 insertions(+), 61 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[Qemu-devel] [PULL v2 16/18] tcg-sparc: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/sparc/tcg-target.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 17ff577..40f2ec1 100644 --- a/tcg/sparc/tcg-target.c +++

[Qemu-devel] [PULL v2 12/18] tcg-i386: Make debug_frame const

2014-05-27 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index a373073..d910233 100644 --- a/tcg/i386/tcg-target.c +++

[Qemu-devel] [PATCH v2 00/26] Merge ppc32/ppc64 tcg backends

2014-05-27 Thread Richard Henderson
The ppc32 backend isn't getting much love and attention recently, with all of the improvements coming from me into the ppc64 backend. Let's reduce the maint burden a bit and combine them. This does have a few other patches that are not strictly related to the merge of the backends, such as

[Qemu-devel] [PATCH v2 05/26] tcg-ppc64: Use tcg_out_{ld, st, cmp} internally

2014-05-27 Thread Richard Henderson
Rather than using tcg_out32 and opcodes directly. This allows us to remove LD_ADDR and CMP_L macros. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc64/tcg-target.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git

[Qemu-devel] [PATCH v2 04/26] tcg-ppc64: Relax register restrictions in tcg_out_mem_long

2014-05-27 Thread Richard Henderson
In order to be able to use tcg_out_ld/st sensibly with scratch registers, assert only when we'd incorrectly clobber a scratch. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc64/tcg-target.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

<    1   2   3   4   5   6   >