Re: [Qemu-devel] TCG semantics

2017-02-06 Thread Ed Robbins
On 6 February 2017 10:39:11 GMT+00:00, Peter Maydell wrote: >On 6 February 2017 at 10:14, Ed Robbins wrote: >> It seems pretty good. I was surprised that call instructions can >> have arguments/return specified, and wonder if those are normally >>

[Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Daniel P. Berrange
In commit ba78db44f6532d66a1e704bd44613e841baa2fc5 Author: Daniel P. Berrange Date: Wed Jan 25 16:14:10 2017 + make: move top level dir to end of include search path The dir $(BUILD_DIR)/$(@D) was added to the include path. This would sometimes point to a

[Qemu-devel] [PATCH] xhci: apply limits to loops

2017-02-06 Thread Gerd Hoffmann
Limits should be big enough that normal guest should not hit it. Add a tracepoint to log them, just in case. Also, while being at it, log the existing link trb limit too. Reported-by: 李强 Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 15

Re: [Qemu-devel] [libvirt] [Block Replication] Question about supporting COLO in libvirt

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 08:34:28PM +0800, Hailiang Zhang wrote: > Hi, > I'm trying to implement supporting COLO in libvirt, > But i found an annoying problem that libvirt does not > support the command line option argument syntax we used > for block replication in QEMU. > > That is libvirt does

Re: [Qemu-devel] [PATCH] hw/char/mcf_uart: QOMify the ColdFire UART

2017-02-06 Thread Paolo Bonzini
On 28/01/2017 07:56, Thomas Huth wrote: > Use type_init() etc. to adapt the ColdFire UART > to the latest QEMU device conventions. > > Signed-off-by: Thomas Huth > --- > hw/char/mcf_uart.c| 102 > +- > hw/m68k/mcf5208.c

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add float128_to_uint64_round_to_zero()

2017-02-06 Thread Peter Maydell
On 6 February 2017 at 08:58, Bharata B Rao wrote: > On Fri, Feb 03, 2017 at 03:39:16PM +, Peter Maydell wrote: >> On 3 February 2017 at 15:12, Bharata B Rao >> wrote: >> > As I said above, it is based on float128_to_int64() >> >> Ah,

[Qemu-devel] libslirp and QEMU slirp

2017-02-06 Thread Stefan Hajnoczi
Hi, There was a talk about new developments in VDEplug at FOSDEM 2017. The QEMU slirp code has been extracted into a library: https://fosdem.org/2017/schedule/event/iaas_modvde/ QEMU's slirp code does not have many contributors. Other projects using slirp are probably in this situation too.

[Qemu-devel] [PATCH 2/4] xhci: add qemu xhci controller

2017-02-06 Thread Gerd Hoffmann
Turn existing TYPE_XHCI into an abstract base class. Create two child classes, TYPE_NEC_XHCI (same name as old xhci controller) and TYPE_QEMU_XHCI (using an ID from our namespace). Signed-off-by: Gerd Hoffmann --- docs/specs/pci-ids.txt | 1 + hw/usb/hcd-xhci.c | 40

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Paolo Bonzini
On 06/02/2017 13:05, Daniel P. Berrange wrote: >>> $(shell mkdir -p ./ $(sort $(dir $($v >>> -$(shell cd $(BUILD_DIR) && mkdir -p ./ $(sort $(dir $($v >> I know this is the same syntax as the existing line above >> and we're deleting it anyway, but what does it actually

Re: [Qemu-devel] TCG semantics

2017-02-06 Thread Ed Robbins
On 3 February 2017 14:46:15 GMT+00:00, Stefan Hajnoczi wrote: >On Thu, Feb 02, 2017 at 12:09:02PM +, E.Robbins wrote: >> I having been looking for prior work on a formalised semantics for >the TCG language. I have seen passing references, and wondered if >anyone can

Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"

2017-02-06 Thread Daniel P. Berrange
On Sun, Feb 05, 2017 at 12:39:45AM +0200, Lluís Vilanova wrote: > Fam Zheng writes: > > > We install this file to data dir but since 0ab8ed18 it's no longer > > required by any objects during "make". List it explicitly as a depended > > target of install and fix the broken "make install" command.

[Qemu-devel] [PULL 3/9] usb: accept usb3 control requests

2017-02-06 Thread Gerd Hoffmann
Windows 10 reportedly sends these, so accept them in case the device in question is a superspeed (usb3) device. Signed-off-by: Gerd Hoffmann Message-id: 1485870727-21956-2-git-send-email-kra...@redhat.com --- hw/usb/desc.c| 7 +++ include/hw/usb.h | 2 ++ 2 files

[Qemu-devel] [PULL 4/9] xhci: only free completed transfers

2017-02-06 Thread Gerd Hoffmann
Most callsites check already, one was missed. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55 Reported-by: Fabian Lesniak Signed-off-by: Gerd Hoffmann Message-id: 1485790607-31399-2-git-send-email-kra...@redhat.com ---

[Qemu-devel] [PULL 7/9] xhci: guard xhci_kick_epctx against recursive calls

2017-02-06 Thread Gerd Hoffmann
Track xhci_kick_epctx processing being active in a variable. Check the variable before calling xhci_kick_epctx from xhci_kick_ep. Add an assert to make sure we don't call recursively into xhci_kick_epctx. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55

[Qemu-devel] [PULL 1/9] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-02-06 Thread Gerd Hoffmann
From: Phil Dennis-Jordan 1. Set bInterfaceProtocol to 0x00 for usb-tablet. This should be non-zero for boot protocol devices only, which the usb-tablet is not. 2. Set the usb-tablet's usage to "mouse" in the report descriptor. The boot protocol of 0x02 specifically

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 11:50:09AM +, Peter Maydell wrote: > On 6 February 2017 at 11:29, Daniel P. Berrange wrote: > > In > > > > commit ba78db44f6532d66a1e704bd44613e841baa2fc5 > > Author: Daniel P. Berrange > > Date: Wed Jan 25 16:14:10

[Qemu-devel] [Block Replication] Question about supporting COLO in libvirt

2017-02-06 Thread Hailiang Zhang
Hi, I'm trying to implement supporting COLO in libvirt, But i found an annoying problem that libvirt does not support the command line option argument syntax we used for block replication in QEMU. That is libvirt does not support the bellow syntax for block: -drive

Re: [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests

2017-02-06 Thread Fam Zheng
On Sat, 01/28 05:59, Nir Soffer wrote: > From: Nir Soffer > > Add regression tests checking that qemu-io fail with non-zero exit code > when reading non-existing file or using the wrong format. > > Signed-off-by: Nir Soffer This message is not correctly

Re: [Qemu-devel] TCG semantics

2017-02-06 Thread Peter Maydell
On 6 February 2017 at 10:14, Ed Robbins wrote: > It seems pretty good. I was surprised that call instructions can > have arguments/return specified, and wonder if those are normally > just empty, so that emulation of the target stack/registers just > carries the args/return in

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Peter Maydell
On 6 February 2017 at 11:29, Daniel P. Berrange wrote: > In > > commit ba78db44f6532d66a1e704bd44613e841baa2fc5 > Author: Daniel P. Berrange > Date: Wed Jan 25 16:14:10 2017 + > > make: move top level dir to end of include search path > >

[Qemu-devel] [PATCH 3/4] xhci: fix nec vendor quirk handling

2017-02-06 Thread Gerd Hoffmann
Only the TYPE_NEC_XHCI controller will have the nec vendor quirks. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 44 +--- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index

Re: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci.

2017-02-06 Thread Peter Maydell
he following changes since commit a951316b8a5c3c63254f20a826afeed940dd4cba: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-02-03 14:41:49 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Jason Wang
On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-06 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > [...] > >> >> ===

Re: [Qemu-devel] [PATCH v4 1/8] make: move top level dir to end of include search path

2017-02-06 Thread Daniel P. Berrange
On Sat, Feb 04, 2017 at 05:48:01PM +0200, Alberto Garcia wrote: > On Wed, Jan 25, 2017 at 04:14:10PM +, Daniel P. Berrange wrote: > > > One final complication is that the absolute '-I$(BUILD_DIR)/$(@D)' > > will sometimes end up pointing to a non-existant directory if > > that sub-dir does

[Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci.

2017-02-06 Thread Gerd Hoffmann
' into staging (2017-02-03 14:41:49 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20170206-1 for you to fetch changes up to 7da76e12cc5cc902dda4c168d8d608fd4e61cbc5: xhci: fix event queue IRQ handling (2017-02-06 12:12:26 +0100

[Qemu-devel] [PULL 6/9] xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer

2017-02-06 Thread Gerd Hoffmann
xhci_submit and xhci_fire_ctl_transfer are is called from xhci_kick_epctx processing loop only, so there is no need to call xhci_kick_epctx make sure processing continues. Also eecursive calls into xhci_kick_epctx can cause trouble. Drop the xhci_kick_epctx calls. Cc: 1653...@bugs.launchpad.net

[Qemu-devel] [PULL 5/9] xhci: rename xhci_complete_packet to xhci_try_complete_packet

2017-02-06 Thread Gerd Hoffmann
Make clear that this isn't guaranteed to actually complete the transfer, the usb packet can still be in flight after calling that function. Signed-off-by: Gerd Hoffmann Message-id: 1485790607-31399-3-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 12 ++-- 1

[Qemu-devel] [PULL 8/9] usb: ccid: check ccid apdu length

2017-02-06 Thread Gerd Hoffmann
From: Prasad J Pandit CCID device emulator uses Application Protocol Data Units(APDU) to exchange command and responses to and from the host. The length in these units couldn't be greater than 65536. Add check to ensure the same. It'd also avoid potential integer overflow

Re: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci.

2017-02-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci. Message-id: 1486380501-13431-1-git-send-email-kra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL 0/3] isa-cleanup queue 20170206

2017-02-06 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/isa-cleanup-20170206 > > for you to fetch changes up to c124c4d13bcb19fc866e7f6de075f906fca6af4a: > > Split ISA and sysbus versions o

[Qemu-devel] [PATCH 4/4] xhci: drop via vendor command handling

2017-02-06 Thread Gerd Hoffmann
Seems pretty pointless, we don't emulate an via xhci controller. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 0e25943..fbf8a8b 100644 ---

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 01:22:08PM +0100, Paolo Bonzini wrote: > > > On 06/02/2017 13:05, Daniel P. Berrange wrote: > >>> $(shell mkdir -p ./ $(sort $(dir $($v > >>> -$(shell cd $(BUILD_DIR) && mkdir -p ./ $(sort $(dir $($v > >> I know this is the same syntax as the

[Qemu-devel] [PATCH 3/4] target-ppc: Add xsmaxcdp and xsmincdp instructions

2017-02-06 Thread Nikunj A Dadhania
From: Bharata B Rao xsmaxcdp: VSX Scalar Maximum Type-C Double-Precision xsmincdp: VSX Scalar Minimum Type-C Double-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania ---

[Qemu-devel] [PATCH 2/4] target-ppc: implement store atomic instruction

2017-02-06 Thread Nikunj A Dadhania
From: Balamuruhan S stwat: Store Word Atomic stdat: Store Doubleword Atomic The instruction includes as function code (5 bits) which gives a detail on the operation to be performed. The patch implements five such functions. Signed-off-by: Balamuruhan S

[Qemu-devel] [PATCH 0/4] xhci: cleanups, add qemu-xhci device.

2017-02-06 Thread Gerd Hoffmann
Hi, This series adds a new qemu-xhci device. It is pretty much identical to the existing nec-usb-xhci device, except that some quirks needed to make the nec/renesas windows driver work will be disabled for the qemu-xhci device. And qemu-xhci gets a PCI ID from the qemu PCi ID range. please

[Qemu-devel] [Bug 1661815] Re: Stack address is returned from function translate_one

2017-02-06 Thread shqking
Thanks for your reply. Inspired by this issue in apache httpd (https://bz.apache.org/bugzilla/show_bug.cgi?id=59844#c0), we customized a checker based on the Clang Static Analyzer to detect such undefined behavior. Yes. After examining the code carefully, we didn't find any place where the

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-06 Thread Dr. David Alan Gilbert
Hi Matwey, 1) Can you provide me with the output of the 'dmesg' command straight after boot on your host. 2) If you look in target/i386/kvm.c in kvm_arch_init_vcpu around line 871 is some code like: if ((ver & 0xff) > 0) { has_msr_architectural_pmu = true;

[Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part14

2017-02-06 Thread Nikunj A Dadhania
This series contains 8 new instructions for POWER9 ISA3.0 VSX Scalar Maximum DP VSX Scalar Minimum DP Load/Store Atomic instructions Balamuruhan S (2): target-ppc: implement load atomic instruction target-ppc: implement store atomic instruction Bharata B Rao (2): target-ppc:

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

2017-02-06 Thread Daniel P. Berrange
On Fri, Feb 03, 2017 at 07:56:11PM +0100, Max Reitz wrote: > > In case you say that's inconvenient: pretty much everything about dd's > > archaic user interface is inconvenient. If you want convenient, roll > > your own. If you want familiar, stick to the original. > > I agree. But qemu-img dd

[Qemu-devel] [PATCH 1/4] target-ppc: implement load atomic instruction

2017-02-06 Thread Nikunj A Dadhania
From: Balamuruhan S lwat: Load Word Atomic ldat: Load Doubleword Atomic The instruction includes as function code (5 bits) which gives a detail on the operation to be performed. The patch implements five such functions. Signed-off-by: Balamuruhan S

Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"

2017-02-06 Thread Daniel P. Berrange
On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote: > We install this file to data dir but since 0ab8ed18 it's no longer > required by any objects during "make". List it explicitly as a depended > target of install and fix the broken "make install" command. > > Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH 4/4] target-ppc: Add xsmaxjdp and xsminjdp instructions

2017-02-06 Thread Nikunj A Dadhania
From: Bharata B Rao xsmaxjdp: VSX Scalar Maximum Type-J Double-Precision xsminjdp: VSX Scalar Minimum Type-J Double-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania ---

[Qemu-devel] [PULL 9/9] xhci: fix event queue IRQ handling

2017-02-06 Thread Gerd Hoffmann
The qemu xhci emulation doesn't handle the ERDP_EHB flag correctly. When the host adapter queues a new event the ERDP_EHB flag is set. The flag is cleared (via w1c) by the guest when it updates the ERDP (event ring dequeue pointer) register to notify the host adapter which events it has fetched.

[Qemu-devel] [PULL 2/9] usb/uas: more verbose error message

2017-02-06 Thread Gerd Hoffmann
Print some more details in case we get a unknown control request, to ease trouble-shooting. Signed-off-by: Gerd Hoffmann Message-id: 1485870727-21956-1-git-send-email-kra...@redhat.com --- hw/usb/dev-uas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 03/17] migration: split common postcopy out of ram postcopy

2017-02-06 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 01.02.2017 14:06, Vladimir Sementsov-Ogievskiy wrote: > > 24.01.2017 22:53, Dr. David Alan Gilbert wrote: > > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > > 24.01.2017 12:24, Juan Quintela wrote: > > > >

[Qemu-devel] [PATCH 1/4] xhci: drop ER_FULL_HACK workaround

2017-02-06 Thread Gerd Hoffmann
The nec/renesas driver problems have finally been debugged and root caused, see commit "7da76e1 xhci: fix event queue IRQ handling". It's pretty clear now that (a) The whole "driver can't handle ring full" story is most likely wrong. (b) The ER_FULL_HACK workaround based on the false

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add float128_to_uint64_round_to_zero()

2017-02-06 Thread Bharata B Rao
On Mon, Feb 06, 2017 at 10:31:49AM +, Peter Maydell wrote: > On 6 February 2017 at 08:58, Bharata B Rao wrote: > > On Fri, Feb 03, 2017 at 03:39:16PM +, Peter Maydell wrote: > >> On 3 February 2017 at 15:12, Bharata B Rao > >>

Re: [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()

2017-02-06 Thread Gerd Hoffmann
On Fr, 2017-02-03 at 18:24 +, Peter Maydell wrote: > The functions vnc_has_job() and vnc_jobs_clear() are > never used; remove them. Added to ui patch queue. thanks, Gerd

[Qemu-devel] [PATCH] qemu-option: reject empty number value

2017-02-06 Thread Marc-André Lureau
When no number is provided, return an invalid number error. (note: this may break some users relying on default 0 value) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1417864 Signed-off-by: Marc-André Lureau --- util/qemu-option.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] hw/vfio/pci-quirks: Set category of the "vfio-pci-igd-lpc-bridge" device

2017-02-06 Thread Thomas Huth
On 03.02.2017 19:10, Alex Williamson wrote: > On Tue, 24 Jan 2017 09:02:38 +0100 > Thomas Huth wrote: > >> The device has "bridge" in its name, so it should obviously be in >> the category DEVICE_CATEGORY_BRIDGE. > > Well, physical device is a bridge, but this is really just a

Re: [Qemu-devel] QEMU Wiki

2017-02-06 Thread Peter Maydell
On 3 February 2017 at 22:21, Jonathan Michael Stryer wrote: > Hello, > > > Could I have someone create me an account for the QEMU wiki? Sure; what username do you want? thanks -- PMM

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-02-06 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 03/02/2017 07:00, Stefan Hajnoczi wrote: > > On Thu, Feb 02, 2017 at 07:05:30AM -0800, Paolo Bonzini wrote: > >> The replication feature is a small amount of code, does not > >> require any external library and unless used does not add > >>

[Qemu-devel] [Bug 1661815] Re: Stack address is returned from function translate_one

2017-02-06 Thread Thomas Huth
The calling function never uses "->fields", so I do not see a real vulnerability here, is there? Did you use a code analyser for this, or how did you come across this issue? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-06 Thread Daniel P. Berrange
On Sat, Feb 04, 2017 at 08:21:50PM +0800, Fam Zheng wrote: > On Thu, 02/02 20:42, Markus Armbruster wrote: > > === Comparison === > > > > In my opinion, dotted keys are weird and ugly, but at least they don't > > add to the quoting mess. Structured values look better, except when > > they do add

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Hailiang Zhang
On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Alberto Garcia
On Mon 06 Feb 2017 12:29:53 PM CET, "Daniel P. Berrange" wrote: > Rather than trying to workaround this, just revert the code that > attempted to mkdir the missing include directories. Instead just turn > off the compiler warning in question as the missing dir is expected & > harmless in general.

Re: [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO

2017-02-06 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2017年01月26日 11:04, Zhang Chen wrote: > > Hi~ > > > > No news for a week. > > > > We need comments ~~ > > > > Ping... > > > > Cc David who is one of the maintainer of migration. My difficulty is I don't know any Xen and I don't understand

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-06 Thread Kevin Wolf
Am 02.02.2017 um 20:42 hat Markus Armbruster geschrieben: > = Brief recap of dotted key convention = > > We'll discuss use of dotted key convention later, so let me explain it > briefly for the readers who don't know it already. > > The dotted key convention interprets the KEY part as a sequence

[Qemu-devel] [PATCH v3 13/16] target-m68k: add fsglmul and fsgldiv

2017-02-06 Thread Laurent Vivier
fsglmul and fsgldiv truncate data to single precision before computing results. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 22 ++ target/m68k/helper.h | 2 ++ target/m68k/translate.c | 8 3 files changed, 32 insertions(+)

[Qemu-devel] [PATCH v3 07/16] target-m68k: manage FPU exceptions

2017-02-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 28 + target/m68k/fpu_helper.c | 107 ++- target/m68k/helper.h | 1 + target/m68k/translate.c | 27 4 files changed, 162 insertions(+), 1

[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-06 Thread wayen
@Eric Blake, Thanks very much for your help. In your way, I have verified that this feature already exists. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [RFC PATCH 1/9] spapr: fix off-by-one error in spapr_ovec_populate_dt()

2017-02-06 Thread Sam Bobroff
The last byte of the option vector was missing due to an off-by-one error. Without this fix, client architecture support negotiation will fail because the last byte of option vector 5, which contains the MMU support, will be missed. Signed-off-by: Sam Bobroff ---

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-02-06 Thread Richard Henderson
On 02/01/2017 02:04 AM, Stafford Horne wrote: For kernel builds I have created toolchain binaries here: http://shorne.noip.me/crosstool/files/bin/x86_64/5.4.0/ These should work. This gdb crashes on the first "stepi" that I issue. To reproduce, $ cat z.c int main() { return 0; } $

Re: [Qemu-devel] [PATCH v6 06/18] intel_iommu: renaming gpa to iova where proper

2017-02-06 Thread Peter Xu
On Tue, Feb 07, 2017 at 01:27:37PM +0800, Jason Wang wrote: > > > On 2017年02月03日 16:22, Peter Xu wrote: > >There are lots of places in current intel_iommu.c codes that named > >"iova" as "gpa". It is really confusing to use a name "gpa" in these > >places (which is very easily to be understood

[Qemu-devel] [PATCH v3 00/16] target-m68k: implement 680x0 FPU

2017-02-06 Thread Laurent Vivier
This series modifies the original ColdFire FPU implementation to use floatx80 instead of float64 internally as this is the native datatype for 680x0. I didn't keep the float64 type for ColdFire, but if someone thinks it's required I can update this series in this way. The series also adds the FPU

[Qemu-devel] [PATCH v3 02/16] softloat: disable floatx80_invalid_encoding() for m68k

2017-02-06 Thread Laurent Vivier
According to the comment, this definition of invalid encoding is given by intel developer's manual, and doesn't work with the behavior of 680x0 FPU. CC: Andreas Schwab Signed-off-by: Laurent Vivier --- fpu/softfloat.c | 31

[Qemu-devel] [PATCH v3 08/16] target-m68k: define 96bit FP registers for gdb on 680x0

2017-02-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- configure| 2 +- gdb-xml/m68k-fp.xml | 21 + target/m68k/helper.c | 45 + 3 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 gdb-xml/m68k-fp.xml

[Qemu-devel] [PATCH v3 01/16] softfloat: define 680x0 specific values

2017-02-06 Thread Laurent Vivier
CC: Peter Maydell Signed-off-by: Laurent Vivier --- fpu/softfloat-specialize.h | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index

[Qemu-devel] [PATCH v3 05/16] target-m68k: use floatx80 internally

2017-02-06 Thread Laurent Vivier
Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 13 +- target/m68k/cpu.h| 10 +- target/m68k/fpu_helper.c | 202

Re: [Qemu-devel] [PATCH v10 05/23] tcg: add options for enabling MTTCG

2017-02-06 Thread Pranith Kumar
Hi Alex, I just spotted this: On Mon, Feb 6, 2017 at 10:30 AM, Alex Bennée wrote: > From: KONRAD Frederic > > We know there will be cases where MTTCG won't work until additional work > is done in the front/back ends to support. It will

Re: [Qemu-devel] [PULL 18/26] target-hppa: Add framework and enable compilation

2017-02-06 Thread Richard Henderson
On 01/30/2017 05:49 AM, Peter Maydell wrote: +case 35: +env->iaoq_b = val; Is this a missing "break;" or a missing "/* fall through */" ? Yep, thanks. r~

Re: [Qemu-devel] [PATCH v6 04/18] intel_iommu: add "caching-mode" option

2017-02-06 Thread Jason Wang
On 2017年02月03日 16:22, Peter Xu wrote: From: Aviv Ben-David This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David [peterx: using

[Qemu-devel] [PULL 2/5] linux-user: fix "apt-get update" on linux-user hppa

2017-02-06 Thread Richard Henderson
From: Laurent Vivier apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This

[Qemu-devel] [PULL 4/5] target/hppa: Tidy do_cbranch

2017-02-06 Thread Richard Henderson
Removes some dead code detected by Covarity. Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/target/hppa/translate.c

Re: [Qemu-devel] [PATCH v6 07/18] intel_iommu: fix trace for inv desc handling

2017-02-06 Thread Jason Wang
On 2017年02月03日 16:22, Peter Xu wrote: VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. Looks like we end up with

[Qemu-devel] [PATCH v3 14/16] target-m68k: add explicit single and double precision operations

2017-02-06 Thread Laurent Vivier
Add fssqrt, fdsqrt, fsabs, fdabs, fsneg, fdneg, fsadd, fdadd, fssub, fdsub, fsmul, fdmul, fsdiv, fddiv, fsmove and fdmove. The precision is managed using set_floatx80_rounding_precision(), except for fsmove, fdmove, fsneg, fdneg, fsabs and fdabs: the value is converted manually to the given

[Qemu-devel] [PULL 1/5] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh

2017-02-06 Thread Richard Henderson
From: Laurent Vivier As we have now a linux-user HPPA target, we can add it to the list of supported targets in qemu-binfmt-conf.sh Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id:

[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-06 Thread wayen
** Description changed: I have a base image file "base.qcow2" and a delta qcow2 image file "delta.qcow2" whose backing file is "base.qcow2". Now I use qemu-img to convert "delta.qcow2" and will get a new image file "new.qcow2" which is entire and equivalent to combination of

[Qemu-devel] [Bug 613529] Re: qemu does not accept regular disk geometry

2017-02-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/613529 Title: qemu does

[Qemu-devel] [Bug 920772] Re: Win98SE glitches RHEL6.2/CentOS6.2 QEMU

2017-02-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/920772 Title: Win98SE

[Qemu-devel] [PATCH v3 16/16] target-m68k: add fsincos

2017-02-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 21 + target/m68k/helper.h | 1 + target/m68k/translate.c | 15 +++ 3 files changed, 37 insertions(+) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index

[Qemu-devel] [PULL 3/5] linux-user: define correct UTS machine name for hppa

2017-02-06 Thread Richard Henderson
From: Laurent Vivier the correct UTS machine name (as expected by systemd) is "parisc", not "hppa". Signed-off-by: Laurent Vivier Message-Id: <20170126080449.28255-4-laur...@vivier.eu> Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-02-06 Thread Richard Henderson
On 02/03/2017 07:14 AM, Stafford Horne wrote: I tried your tgt-or1k-2 branch with my latest kernel and have no issues. Ok, excellent, thanks. I'll send a pull for that branch then. r~

[Qemu-devel] [PULL 5/5] target/hppa: Fix gdb_write_register

2017-02-06 Thread Richard Henderson
Add a missing break, detected by Coverity. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- target/hppa/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c index 413a5e1..c37a56f

[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-06 Thread wayen
@Eric Blake. Sorry, I didn't make it clear. In fact, I don't want to get a complete image. I just want to convert qcow2 overlay and get a new qcow2 overlay. Maybe you think my intention is meaningless, but this is what I want. ** Changed in: qemu Status: Invalid => Incomplete **

Re: [Qemu-devel] [PATCH v6 16/18] intel_iommu: do replay when context invalidate

2017-02-06 Thread Jason Wang
On 2017年02月03日 16:22, Peter Xu wrote: Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a domain switch (only if cache-mode is enabled for vIOMMU). In that case we need to notify all the

[Qemu-devel] [PATCH v3 12/16] target-m68k: add fscale, fgetman, fgetexp and fmod

2017-02-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 1 + target/m68k/fpu_helper.c | 56 target/m68k/helper.h | 4 target/m68k/translate.c | 14 4 files changed, 75 insertions(+) diff --git

[Qemu-devel] [PATCH v3 10/16] target-m68k: add fscc.

2017-02-06 Thread Laurent Vivier
use DisasCompare with FPU conditions in fscc and fbcc. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 228 1 file changed, 153 insertions(+), 75 deletions(-) diff --git a/target/m68k/translate.c

Re: [Qemu-devel] [PATCH v3 00/16] target-m68k: implement 680x0 FPU

2017-02-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 00/16] target-m68k: implement 680x0 FPU Message-id: 20170207005930.28327-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-06 Thread Gonglei (Arei)
Hi, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, February 07, 2017 2:20 AM > Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto > device specification > > On Mon, Feb 06, 2017 at 03:46:25PM +, Stefan Hajnoczi wrote: > > On Mon, Feb 06, 2017 at

[Qemu-devel] [RFC PATCH 2/9] Update headers using update-linux-headers.sh

2017-02-06 Thread Sam Bobroff
This provides some new definitions needed by ISA 3.00 guests. It is a large change because this is the first import since some kernel header files have become autogenerated. Note: update-linux-headers.sh currently generates a change that (incorrectly) removes virtio_mmio.h and the change has

[Qemu-devel] [RFC PATCH 9/9] spapr: Small cleanup of PPC MMU enums

2017-02-06 Thread Sam Bobroff
The PPC MMU types are sometimes treated as if they were a bit field and sometime as if they were an enum which causes maintenance problems: flipping bits in the MMU type (which is done on both the 1TB segment and 64K segment bits) currently produces new MMU type values that are not handled in

[Qemu-devel] [RFC PATCH 7/9] spapr: Set ISA 3.00 radix and hash bits in OV5

2017-02-06 Thread Sam Bobroff
Set new option vector 5 bits to indicate KVM support for in-memory radix or hash modes and related options. The existing logic will propagate the results back to the guest in the device tree. This allows guests to perform client architecture support negotiation on the new radix and hash MMU modes

Re: [Qemu-devel] [PATCH v6 06/18] intel_iommu: renaming gpa to iova where proper

2017-02-06 Thread Jason Wang
On 2017年02月03日 16:22, Peter Xu wrote: There are lots of places in current intel_iommu.c codes that named "iova" as "gpa". It is really confusing to use a name "gpa" in these places (which is very easily to be understood as "Guest Physical Address", while it's not). To make the codes (much)

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-06 Thread Fam Zheng
On Mon, 02/06 13:36, Eric Blake wrote: > On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote: > > This patchset adds the throttle support for the 9p-local driver. > > For now this functionality can be enabled only through qemu cli options. > > QMP interface and support to other drivers need further

Re: [Qemu-devel] [PATCH v6 18/18] intel_iommu: enable vfio devices

2017-02-06 Thread Jason Wang
On 2017年02月03日 16:22, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my

[Qemu-devel] [PATCH v3 11/16] target-m68k: add fmovecr

2017-02-06 Thread Laurent Vivier
fmovecr moves a floating point constant from the FPU ROM to a floating point register. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 31 +++ target/m68k/helper.h | 1 + target/m68k/translate.c | 12 +++- 3 files

[Qemu-devel] [PATCH v3 04/16] target-m68k: define ext_opsize

2017-02-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 9f60fbc..d9ba735 100644 ---

Re: [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO

2017-02-06 Thread Zhang Chen
Hi~ Eric. If you have time, please give me some comments. This series has been sent for a long time. Thanks Zhang Chen On 02/06/2017 09:13 PM, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2017年01月26日 11:04, Zhang Chen wrote: Hi~ No news for a week. We

  1   2   3   >