Re: [Qemu-devel] [PATCH for 2.10 0/4] check dtc submodule is outdated

On 07/26/2017 06:40 PM, Philippe Mathieu-Daudé wrote:> patch 4: if no system libdtc and submodule present, compile the dtc submodule and verify it is at least v1.4.2. Prefixed RFC because I'm not sure about these 3 lines: +make -C dtc 1>/dev/null which can leads to: /bin/sh: 1: cannot

Re: [Qemu-devel] [for-2.11 PATCH 26/26] spapr: add hotplug hooks for PHB hotplug

On 26/07/17 18:40, Greg Kurz wrote: > Hotplugging PHBs is a machine-level operation, but PHBs reside on the > main system bus, so we register spapr machine as the handler for the > main system bus. > > Signed-off-by: Michael Roth > Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH for 2.10 v2 10/20] m68k/translate: fix incorrect copy/paste

On 07/26/2017 07:42 PM, Philippe Mathieu-Daudé wrote: db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, 5] target/m68k/translate.c:1323:70: warning: identical expressions on both sides of logical operator if (op == CC_OP_ADDB || op == CC_OP_ADDW || op ==

[Qemu-devel] RFC: unified --help information

I noticed that some utilities provide a handy link to the website (which in turn connects the users to bug database, mailing list, online docs, ...); for example, look at 'ls --help | tail -n3': GNU coreutils online help: Full documentation at:

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Tue, Jul 25, 2017 at 05:47:08PM +0300, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Mon, Jul 24, 2017 at 08:02:24PM +0300, Lluís Vilanova wrote: > >> This series adds a basic interface to instrument tracing events and control > >> their tracing state. > >> > >> The instrumentation

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

Hi, > qcodes as currently defined cover only a subset of the AT set1 > scancodes, > so we need to define countless more qcodes before we consider > converting > UIs to use qcodes. > > Aside from the pause/break bug, the changes to ps2 driver to round > trip > via qcodes have now made it

[Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

We don't want the page to become too long, but these are good suggestions. Also tone down the sentence about using the latest release or latest git tree, though we do prefer those. Signed-off-by: Paolo Bonzini --- contribute.md | 2 +-

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26 July 2017 at 12:44, Paolo Bonzini wrote: > We don't want the page to become too long, but these are good suggestions. > > Also tone down the sentence about using the latest release or latest git > tree, though we do prefer those. > * Reproduce the problem directly

[Qemu-devel] [PATCH 5/6] hw/block: Use errp directly rather than local_err

Pass the error message to errp directly rather than the local variable local_err and propagate it to errp via error_propagate(). Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Keith Busch Cc: Stefan Hajnoczi

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On 26/07/2017 13:42, Laszlo Ersek wrote: > Not exactly; the PCD controls whether the EFI_ACPI_TABLE_PROTOCOL will > expose an RSDT, an XSDT, or both (with matching contents). You're right that the code does not produce a v1 FADT, I mis-skimmed the awful code of AcpiTableDxe. Though the

Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > Add multimedia keys to QKeyCodes and to the keymaps. > > Signed-off-by: Gerd Hoffmann > --- > ui/input-keymap.c | 44 > qapi-schema.json | 17 - > 2 files changed, 60

[Qemu-devel] [PATCH 6/6] dev-storage: Fix the unusual function name

The function name of usb_msd_{realize,unrealize}_*, usb_msd_class_initfn_* are unusual. Rename it to usb_msd_*_{realize,unrealize}, usb_msd_class_*_initfn. Cc: Gerd Hoffmann Signed-off-by: Mao Zhongyi --- hw/usb/dev-storage.c | 20

Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

On 07/26/2017 07:08 AM, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote: >> On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: >>> Add multimedia keys to QKeyCodes and to the keymaps. >>> >>> Signed-off-by: Gerd Hoffmann >>> --- >>>

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26/07/2017 13:52, Peter Maydell wrote: >> * Reproduce the problem directly with a QEMU command-line. Avoid frontends >> and management stacks, to ensure that the bug is in QEMU itself and not in a >> frontend. >> >> -* Include as information about the guest (operating system, version, >>

Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

On Wed, 2017-07-26 at 07:12 -0500, Eric Blake wrote: > On 07/26/2017 07:08 AM, Daniel P. Berrange wrote: > > On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote: > > > On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > > > > Add multimedia keys to QKeyCodes and to the keymaps. > > > > > > > >

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On 26/07/2017 15:08, Igor Mammedov wrote: > On Tue, 25 Jul 2017 18:23:22 +0200 > Paolo Bonzini wrote: > >> On 25/07/2017 18:14, Laszlo Ersek wrote: >>> "No regressions became apparent in tests with a range of Windows >>>(XP-10)" >>> >>> In theory, w2k falls within that

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On 26/07/2017 15:30, Igor Mammedov wrote: > On Wed, 26 Jul 2017 15:10:40 +0200 > Paolo Bonzini wrote: > >> On 26/07/2017 15:08, Igor Mammedov wrote: >>> On Tue, 25 Jul 2017 18:23:22 +0200 >>> Paolo Bonzini wrote: >>> On 25/07/2017 18:14, Laszlo

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

On 26/07/2017 05:13, Philippe Mathieu-Daudé wrote: > Hi John, > > On 07/25/2017 07:55 PM, Programmingkid wrote: >> While compiling the mips64el-softmmu target I encountered these errors: >> >>CC hw/display/g364fb.o >> hw/core/loader-fit.c:105:41: error: expected expression >>

Re: [Qemu-devel] [PATCH 2/2] vhost-user-blk: introduce a vhost-user-blk sample application

On Thu, Jul 27, 2017 at 10:00:51AM +0800, Changpeng Liu wrote: > diff --git a/contrib/vhost-user-blk/vhost-user-blk.c > b/contrib/vhost-user-blk/vhost-user-blk.c > new file mode 100644 > index 000..00826f5 > --- /dev/null > +++ b/contrib/vhost-user-blk/vhost-user-blk.c > @@ -0,0 +1,695 @@ >

Re: [Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

On 07/26/2017 06:10 AM, Paolo Bonzini wrote: > The bug reporting instructions are pretty static, and it is nicer if bug > reporters stay within the familiar QEMU web site layout. Move the page > to qemu.org. > > Signed-off-by: Paolo Bonzini > --- > _includes/footer.html

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

On 26.07.2017 11:28, David Hildenbrand wrote: > On 25.07.2017 17:33, Cornelia Huck wrote: >> Only set the zpci feature bit on builds that actually support pci. >> >> Signed-off-by: Cornelia Huck >> --- >> hw/s390x/s390-pci-bus.c | 5 + >> hw/s390x/s390-pci-bus.h | 1 + >>

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

On Tue, Jul 25, 2017 at 07:21:45PM +0300, Manos Pitsidianakis wrote: > On Tue, Jul 25, 2017 at 05:09:41PM +0100, Stefan Hajnoczi wrote: > > On Tue, Jul 25, 2017 at 01:29:08PM +0300, Manos Pitsidianakis wrote: > > > On Mon, Jul 24, 2017 at 04:12:47PM +0100, Stefan Hajnoczi wrote: > > > > On Fri,

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 07/26/2017 06:44 AM, Paolo Bonzini wrote: > We don't want the page to become too long, but these are good suggestions. > > Also tone down the sentence about using the latest release or latest git > tree, though we do prefer those. > > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26/07/2017 13:57, Thomas Huth wrote: > On 26.07.2017 13:44, Paolo Bonzini wrote: >> We don't want the page to become too long, but these are good suggestions. >> >> Also tone down the sentence about using the latest release or latest git >> tree, though we do prefer those. > > Well, sometimes

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

Hi Diana, On 23/05/2017 13:12, Diana Craciun wrote: > Device IDs are required by the ARM GICv3 ITS for IRQ remapping. > Currently, for PCI devices, the requester ID was used as device > ID in the virt machine. If the system has multiple masters that if the system has multiple root complex? > use

Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10

On 07/26/2017 07:09 AM, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Message-id: 20170726115637.21558-1-kra...@redhat.com > Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 > Type: series > > GEN

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

Peter Maydell writes: > On 26 July 2017 at 12:26, Stefan Hajnoczi wrote: >> On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote: >>> Is your proposal that my-instrumentation.c gets compiled into >>> QEMU at this point? That doesn't seem like a great idea to >>> me,

Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

> I wondered if this would work, but didn't mention anything on the > assumption that it built for you.  But now that patchew is > complaining > about a failed build, I suspect your attempt at abbreviation here is > the > reason. It worked for me, but only because it didn't build the docs.

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On Wednesday, July 26, 2017 7:55 PM, Michal Hocko wrote: > On Wed 26-07-17 19:44:23, Wei Wang wrote: > [...] > > I thought about it more. Probably we can use the callback function > > with a little change like this: > > > > void walk_free_mem(void *opaque1, void (*visit)(void *opaque2, > >

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > The tables that QEMU provides are not ACPI 1.0 compatible since commit > 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > guest OS support.", 2017-05-03). This is visible with Windows 2000, > which refuses

Re: [Qemu-devel] [qemu-web PATCH] Change the "Full list of releases" link to point to download.qemu.org

On 26/07/2017 14:59, Thomas Huth wrote: > The list in the Wiki is not up to date anymore, so let's simply point > the users to the file list on the download server instead. > > Signed-off-by: Thomas Huth > --- > _includes/releases.html | 2 +- > 1 file changed, 1 insertion(+),

[Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

Most browsers try to download a /favicon.ico file from the web servers which is then e.g. used in the browser tabs or bookmark lists. So let's add such a file for the QEMU website, too. The .ico has been created resizing the logo from http://wiki.qemu.org/Logo to 16x16 pixels. Signed-off-by:

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On Wed, 26 Jul 2017 15:33:37 +0200 Paolo Bonzini wrote: > On 26/07/2017 15:30, Igor Mammedov wrote: > > On Wed, 26 Jul 2017 15:10:40 +0200 > > Paolo Bonzini wrote: > > > >> On 26/07/2017 15:08, Igor Mammedov wrote: > >>> On Tue, 25 Jul 2017

Re: [Qemu-devel] [PATCH v3 1/9] kvm: remove hard dependency on pci

On 25.07.2017 17:33, Cornelia Huck wrote: > The msi routing code in kvm calls some pci functions: provide > some stubs to enable builds without pci. > > Fixes: e1d4fb2de ("kvm-irqchip: x86: add msi route notify fn") > Fixes: 767a554a0 ("kvm-all: Pass requester ID to MSI routing functions") >

Re: [Qemu-devel] [PATCH v3 8/9] s390x/kvm: msi route fixup for non-pci

On 26.07.2017 10:25, Thomas Huth wrote: > On 26.07.2017 10:20, Cornelia Huck wrote: >> On Wed, 26 Jul 2017 09:09:06 +0200 >> Thomas Huth wrote: >> >>> On 25.07.2017 17:33, Cornelia Huck wrote: If we don't provide pci, we cannot have a pci device for which we have to

Re: [Qemu-devel] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

Am 25.07.2017 um 23:55 schrieb Eric Blake: > On 07/25/2017 09:41 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> block/qcow2.c| 7 +++ >> qapi/block-core.json | 6 +- >> 2 files changed, 12 insertions(+), 1 deletion(-) >> >> +++

Re: [Qemu-devel] [PATCH v3 0/9] s390x: zPCI detangling

On 07/25/2017 05:33 PM, Cornelia Huck wrote: > Next version, now without RFC. The goals are still the same: > - Being able to disable PCI support in a build completely. > - Properly fencing off PCI if the relevant facility bit is not provided. > > Changes v2->v3: > - Only enable the zpci bit

Re: [Qemu-devel] [for-2.11 PATCH 03/26] spapr_iommu: use g_strdup_printf() instead of snprintf()

On Wed, 26 Jul 2017 13:37:03 +1000 Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > Passing a stack allocated buffer of arbitrary length to snprintf() > > without checking the return value can cause the resultant strings > > to be silently truncated. > >

Re: [Qemu-devel] RFC: unified --help information

On 07/26/2017 06:11 AM, Paolo Bonzini wrote: >> >> qemu-nbd mentions: Report bugs to >> qemu-ga mentions: Report bugs to >> >> while qemu-system-*, qemu-img, and qemu-io mention nothing at all. Is >> it worth unifying these to all mention

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

On Tue, Jul 25, 2017 at 04:34:19PM +0100, Peter Maydell wrote: > On 25 July 2017 at 16:20, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote: > >> Should ./check be run from the source tree, or the build tree? The > >> existing README

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

On 07/25/2017 06:37 PM, Bruce Hoult wrote: > Do you have any good estimates for how much of the execution time is > typically spent in instruction decode? > > RISC-V qemu is twice as fast as ARM or Aarch64 qemu, so it's doing > something right! > > (I suspect it's probably mostly the lack of

[Qemu-devel] [PATCH 3/6] hw/block/nvme: Convert to realize

Convert nvme_init() to realize and rename it to nvme_realize(). Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/block/nvme.c | 18

[Qemu-devel] [PATCH 2/6] hw/block/fdc: Convert to realize

Convert floppy_drive_init() to realize and rename it to floppy_drive_realize(). Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi ---

Re: [Qemu-devel] [PATCH 1/5] ui: add next and prior keysyms

On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > Page-up and Page-down where renamed. Add the names to the keysym list s/where/were/ > so we can parse both old and new names. The keypad versions are already > present in the vnc map. > > Signed-off-by: Gerd Hoffmann > --- >

Re: [Qemu-devel] [for-2.11 PATCH 13/26] qdev: store DeviceState's canonical path to use when unparenting

Quoting David Gibson (2017-07-26 00:24:43) > On Tue, Jul 25, 2017 at 08:00:47PM +0200, Greg Kurz wrote: > > From: Michael Roth > > > > device_unparent(dev, ...) is called when a device is unparented, > > either directly, or as a result of a parent device being > >

Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote: > On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > > Add multimedia keys to QKeyCodes and to the keymaps. > > > > Signed-off-by: Gerd Hoffmann > > --- > > ui/input-keymap.c | 44

[Qemu-devel] [PATCH 4/6] hw/block: Fix the return type

When the function no success value to transmit, it usually make the function return void. It has turned out not to be a success, because it means that the extra local_err variable and error_propagate() will be needed. It leads to cumbersome code, therefore, transmit success/ failure in the return

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 07/26/2017 07:19 AM, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 01:57:35PM +0200, Thomas Huth wrote: >> On 26.07.2017 13:44, Paolo Bonzini wrote: >>> We don't want the page to become too long, but these are good suggestions. >>> >>> Also tone down the sentence about using the latest

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

Stefan Hajnoczi writes: > On Tue, Jul 25, 2017 at 06:11:43PM +0300, Lluís Vilanova wrote: >> Peter Maydell writes: >> >> > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote: >> >> Instead I suggest adding a trace backend generates calls to registered >> >> "callback"

[Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

Block driver documentation is available in qemu-doc.html. It would be convenient to have documentation for formats, protocols, and filter drivers in a man page. Extract the relevant part of qemu-doc.html into a new file called docs/qemu-block-drivers.texi. This file can also be built as a

Re: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page

On Mon, Jul 24, 2017 at 11:46:14AM +0200, Kevin Wolf wrote: > Am 27.06.2017 um 17:41 hat Stefan Hajnoczi geschrieben: > > Extract the relevant part of qemu-doc.html into a new file called > > docs/qemu-block-drivers.texi. This file can also be built as a > > stand-alone document (man, html, etc).

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

On Wed, Jul 26, 2017 at 02:07:13PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 03:52:43PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > > > The tables that QEMU provides are not ACPI 1.0 compatible since commit > > > 77af8a2b95

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

On 26 July 2017 at 06:15, Programmingkid wrote: > >> On Jul 26, 2017, at 12:13 AM, Philippe Mathieu-Daudé wrote: >> >> Hi John, >> >> On 07/25/2017 07:55 PM, Programmingkid wrote: >>> While compiling the mips64el-softmmu target I encountered these

Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report())

On Tue, Jul 25, 2017 at 04:26:32PM -0700, Alistair Francis wrote: > Actually, what about to avoid duplication we can add a make check-slow > that runs all the slow tests that make check doesn't run. Then make > check-all can run both make check and make check-slow. > > That way you can run make

Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report())

On Tue, Jul 25, 2017 at 04:08:18PM -0300, Eduardo Habkost wrote: > On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: > > On 24/07/2017 08:30, Markus Armbruster wrote: > > > Markus Armbruster writes: > > > > > >> Kevin Wolf writes: > > >> > > >>>

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

On Thu, Jul 27, 2017 at 10:00:50AM +0800, Changpeng Liu wrote: > +static void vhost_user_blk_set_config(VirtIODevice *vdev, const uint8_t > *config) > +{ > +VHostUserBlk *s = VHOST_USER_BLK(vdev); > +struct virtio_blk_config blkcfg; > + > +memcpy(, config, sizeof(blkcfg)); > + > +

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

On 07/26/2017 05:01 AM, Dong Jia Shi wrote: > Hello Halil, > > * Halil Pasic [2017-07-26 00:44:42 +0200]: > >> According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must >> contain zeros. Bits 0-3 are already covered by cmd_code validity >> checking,

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On Wed 26-07-17 19:44:23, Wei Wang wrote: [...] > I thought about it more. Probably we can use the callback function with a > little change like this: > > void walk_free_mem(void *opaque1, void (*visit)(void *opaque2, unsigned long > pfn, >unsigned long nr_pages)) > { > ... >

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26.07.2017 13:44, Paolo Bonzini wrote: > We don't want the page to become too long, but these are good suggestions. > > Also tone down the sentence about using the latest release or latest git > tree, though we do prefer those. Well, sometimes people still report bugs against QEMU 2.1 or so

Re: [Qemu-devel] [PATCH v2 1/2] Increased the size of requester_id field from MemTxAttrs

Hi Diana, On 23/05/2017 13:12, Diana Craciun wrote: > The PCI requester ID field is 16 bits. The requester_id field > from MemTxAttrs is used for MSIs to specify the device ID for > the platforms where this device ID is needed (e.g virt machine + GICv3 > ITS). However, if more entities that uses

Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > Add multimedia keys to QKeyCodes and to the keymaps. > > Signed-off-by: Gerd Hoffmann > --- > ui/input-keymap.c | 44 > qapi-schema.json | 17 - > 2 files changed, 60

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

Stefan Hajnoczi writes: > On Tue, Jul 25, 2017 at 05:47:08PM +0300, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > On Mon, Jul 24, 2017 at 08:02:24PM +0300, Lluís Vilanova wrote: >> >> This series adds a basic interface to instrument tracing events and >> >> control >> >> their

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

On 26/07/2017 14:52, Michael S. Tsirkin wrote: > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: >> The tables that QEMU provides are not ACPI 1.0 compatible since commit >> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve >> guest OS support.", 2017-05-03).

Re: [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception

On Wed, Jul 26, 2017 at 06:39:28AM +0200, Lukáš Doktor wrote: > Dne 25.7.2017 v 18:06 Eduardo Habkost napsal(a): > > On Tue, Jul 25, 2017 at 05:09:46PM +0200, Lukáš Doktor wrote: > >> The naked Exception should not be widely used. It makes sense to be a > >> bit more specific and use better-suited

Re: [Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

On Wed, Jul 26, 2017 at 02:03:37PM +0100, Stefan Hajnoczi wrote: > Block driver documentation is available in qemu-doc.html. It would be > convenient to have documentation for formats, protocols, and filter > drivers in a man page. > > Extract the relevant part of qemu-doc.html into a new file

[Qemu-devel] Regarding tracing machine instructions through qemu

Hello Peter, Regarding my last mail for tracing qemu. Actually I need to trace the machine instructions of guest operating system(in my case it is android - arm architecture). So that I can simulate the same. This is my project for M.Tech. So I started with the code to play around and figure out

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

On 07/25/2017 10:28 PM, Philippe Mathieu-Daudé wrote: >>> - rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS >>> cscope.* *.pod *~ */*~ >>> + rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga${EXESUF} >>> TAGS cscope.* *.pod *~ */*~ >>> >>> It's a bit ugly since `rm -f

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Tue, Jul 25, 2017 at 06:11:43PM +0300, Lluís Vilanova wrote: > Peter Maydell writes: > > > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote: > >> Instead I suggest adding a trace backend generates calls to registered > >> "callback" functions: > >> > >> $ cat

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Tue, Jul 25, 2017 at 01:53:40PM +0200, Gerd Hoffmann wrote: > Hi, > > > > You're putting some specific code for spice in ps2 emulation. > > > IMO, the workaround should be moved to spice keyboard handling > > > (ui/spice-input.c), > > > which needs to generate a qcode instead of a scancode.

Re: [Qemu-devel] RFC: unified --help information

On 26 July 2017 at 12:22, Eric Blake wrote: > So something like these two lines (via a macro) in all of the > executables, ideally at the tail end of --help output? > > See for bug reports. > More information on the qemu project at

Re: [Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

On 07/26/2017 06:32 AM, Thomas Huth wrote: > On 26.07.2017 13:10, Paolo Bonzini wrote: >> The bug reporting instructions are pretty static, and it is nicer if bug >> reporters stay within the familiar QEMU web site layout. Move the page >> to qemu.org. >> >> Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On 26 July 2017 at 12:26, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote: >> Is your proposal that my-instrumentation.c gets compiled into >> QEMU at this point? That doesn't seem like a great idea to >> me, because it means you can

[Qemu-devel] [PATCH 2/5] ui: move qemu_input_linux_to_qcode()

Move from input-linux.c to input-keymap.c and export it, so the function is available elsewhere too. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input-keymap.c | 115 + ui/input-linux.c | 113

[Qemu-devel] [PATCH 1/5] ui: add next and prior keysyms

Page-up and Page-down where renamed. Add the names to the keysym list so we can parse both old and new names. The keypad versions are already present in the vnc map. Signed-off-by: Gerd Hoffmann --- ui/curses_keys.h | 2 ++ ui/vnc_keysym.h | 2 ++ 2 files changed, 4

[Qemu-devel] [PATCH 5/5] ps2: enable multimedia keys

Fixes: 8c10e0baf0260b59a4e984744462a18016662e3e Signed-off-by: Gerd Hoffmann --- hw/input/ps2.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 3ba05efd06..25ae7fc852 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -224,7 +224,6

Re: [Qemu-devel] [PATCH 2/5] ui: move qemu_input_linux_to_qcode()

On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > Move from input-linux.c to input-keymap.c and export it, > so the function is available elsewhere too. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/input.h | 1 + > ui/input-keymap.c | 115 >

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On Tue, 25 Jul 2017 18:23:22 +0200 Paolo Bonzini wrote: > On 25/07/2017 18:14, Laszlo Ersek wrote: > > "No regressions became apparent in tests with a range of Windows > >(XP-10)" > > > > In theory, w2k falls within that range. > > Nope, Windows 2000 is like NT

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

On Wed, Jul 26, 2017 at 03:52:43PM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > > The tables that QEMU provides are not ACPI 1.0 compatible since commit > > 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > > guest OS

Re: [Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

On 26/07/2017 15:27, Thomas Huth wrote: > Most browsers try to download a /favicon.ico file from the web servers > which is then e.g. used in the browser tabs or bookmark lists. So let's > add such a file for the QEMU website, too. The .ico has been created > resizing the logo from

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On Wed 26-07-17 10:22:23, Wei Wang wrote: > On 07/25/2017 10:53 PM, Michal Hocko wrote: > >On Tue 25-07-17 14:47:16, Wang, Wei W wrote: > >>On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > >>>On Tue 25-07-17 19:56:24, Wei Wang wrote: > On 07/25/2017 07:25 PM, Michal Hocko wrote: > >On

Re: [Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

On 26.07.2017 13:10, Paolo Bonzini wrote: > The bug reporting instructions are pretty static, and it is nicer if bug > reporters stay within the familiar QEMU web site layout. Move the page > to qemu.org. > > Signed-off-by: Paolo Bonzini > --- > _includes/footer.html

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

Digressing: On 07/26/17 10:53, Paolo Bonzini wrote: > On 25/07/2017 23:25, Phil Dennis-Jordan wrote: >> Thanks for this, Paolo. Very interesting idea. >> >> I couldn't get things working initially, but with a few fixups on the >> SeaBIOS side I can boot both legacy and modern OSes. See comments

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On 07/26/2017 06:24 PM, Michal Hocko wrote: On Wed 26-07-17 10:22:23, Wei Wang wrote: On 07/25/2017 10:53 PM, Michal Hocko wrote: On Tue 25-07-17 14:47:16, Wang, Wei W wrote: On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: On Tue 25-07-17 19:56:24, Wei Wang wrote: On 07/25/2017 07:25

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

On 26 July 2017 at 12:33, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 04:34:19PM +0100, Peter Maydell wrote: >> On 25 July 2017 at 16:20, Stefan Hajnoczi wrote: >> > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote: >> >> Should ./check

[Qemu-devel] [PATCH 3/5] ui: update keymaps

Add recently added QKeyCodes to the keymaps. Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index d4972bb364..7461e1edde 100644 --- a/ui/input-keymap.c +++ b/ui/input-keymap.c

Re: [Qemu-devel] [PATCH 1/2] s390x/css: check ccw address validity

On 07/26/2017 05:31 AM, Dong Jia Shi wrote: > * Halil Pasic [2017-07-26 00:44:41 +0200]: > >> According to the PoP channel command words (CCW) must be doubleword >> aligned and 31 bit addressable for format 1 and 24 bit addressable for >> format 0 CCWs. >> >> If the

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

Hi Samuel, On 07/25/2017 04:31 PM, Samuel Falvo II wrote: > For those of us who are not in the know, how does target/s390 decoding work? sorry about that. I was going into this with a QEMU-dev mindset :) The basic idea of s390x is to have every instruction + instruction formats specified in

[Qemu-devel] [PATCH 1/6] hw/ide: Convert DeviceClass init to realize

Replace init with realize in IDEDeviceClass, which has errp as a parameter. So all the implementations now use error_setg instead of error_report for reporting error. Cc: John Snow Cc: Markus Armbruster Signed-off-by: Mao Zhongyi

[Qemu-devel] [PATCH 0/6] Convert to realize and improve error handling

This series mainly implements the conversions of ide, floppy and nvme device to realize. Add some error handling messages and remove the local variable local_err, use errp to propagate the error directly. Also fix the unusual function name. Cc: John Snow Cc: Kevin Wolf

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On Wed, Jul 26, 2017 at 01:57:35PM +0200, Thomas Huth wrote: > On 26.07.2017 13:44, Paolo Bonzini wrote: > > We don't want the page to become too long, but these are good suggestions. > > > > Also tone down the sentence about using the latest release or latest git > > tree, though we do prefer

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26/07/2017 14:19, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 01:57:35PM +0200, Thomas Huth wrote: >> On 26.07.2017 13:44, Paolo Bonzini wrote: >>> We don't want the page to become too long, but these are good suggestions. >>> >>> Also tone down the sentence about using the latest

Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10

Hi, > error message).  I suspect this is caused by your use of '@ac_*' > instead > of spelling out all the ac_ members added in qapi-schema.json in 4/5 > - Hmm, adding them all will be a pretty long list, and it will probably become alot longer when we add more missing keys in 2.11 ... Should

Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10

On 07/26/2017 07:49 AM, Gerd Hoffmann wrote: > Hi, > >> error message). I suspect this is caused by your use of '@ac_*' >> instead >> of spelling out all the ac_ members added in qapi-schema.json in 4/5 >> - > > Hmm, adding them all will be a pretty long list, and it will probably > become

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On Wed, 26 Jul 2017 15:10:40 +0200 Paolo Bonzini wrote: > On 26/07/2017 15:08, Igor Mammedov wrote: > > On Tue, 25 Jul 2017 18:23:22 +0200 > > Paolo Bonzini wrote: > > > >> On 25/07/2017 18:14, Laszlo Ersek wrote: > >>> "No regressions became

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: > On 24/07/2017 08:30, Markus Armbruster wrote: > > Markus Armbruster writes: > > > >> Kevin Wolf writes: > >> > >>> Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: > From:

Re: [Qemu-devel] RFC: unified --help information

On 26/07/2017 12:53, Eric Blake wrote: > > GNU coreutils online help: > Full documentation at: > or available locally via: info '(coreutils) ls invocation' > > or 'm4 --help | tail -n3': > Report bugs to:

[Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

The bug reporting instructions are pretty static, and it is nicer if bug reporters stay within the familiar QEMU web site layout. Move the page to qemu.org. Signed-off-by: Paolo Bonzini --- _includes/footer.html | 2 +- contribute.md | 2 +-

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote: > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote: > > Instead I suggest adding a trace backend generates calls to registered > > "callback" functions: > > > > $ cat >my-instrumentation.c > > #include

Re: [Qemu-devel] [PULL v2 1/8] target/s390x: Implement CSST

On 17/07/2017 23:24, Richard Henderson wrote: > +case 4: > +if (parallel_cpus) { > +#ifdef CONFIG_ATOMIC128 > +TCGMemOpIdx oi = make_memop_idx(MO_TEQ | MO_ALIGN_16, > mem_idx); > +Int128 sv = int128_make128(svl, svh); > +

[Qemu-devel] [PATCH 4/5] ui: add multimedia keys

Add multimedia keys to QKeyCodes and to the keymaps. Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 44 qapi-schema.json | 17 - 2 files changed, 60 insertions(+), 1 deletion(-) diff --git

  1   2   3   4   5   >