Re: [Qemu-devel] [PATCH for-2.10 2/3] Revert "qdev: Free QemuOpts when the QOM path goes away"

On Wed, 26 Jul 2017 20:30:54 -0500 Michael Roth wrote: > This reverts commit abed886ec60cf239a03515cf0b30fb11fa964c44. > > This patch originally addressed an issue where a DEVICE_DELETED > event could be emitted (in device_unparent()) before a Device's > QemuOpts were

[Qemu-devel] [PATCH for-2.10 2/5] tests: acpi: init table descriptor in test_dst_table()

remove code duplication and make sure that table descriptor passed in for initialization is in expected state. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/bios-tables-test.c

[Qemu-devel] [PATCH for-2.10 4/5] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage

Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index ed32e9a..a2a90d7 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -251,6 +251,8

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

On Sat, Jul 29, 2017 at 06:49:33PM +0800, Haozhong Zhang wrote: > On 07/28/17 13:45 -0600, Ross Zwisler wrote: > > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > > > On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler > > > wrote: > > > > I've been using

[Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

While refactoring i386/FADT generation to build_append_int_noprefix() and testing it, It turned out that FADT is only tested for valid checksum but actual test for unintended changes isn't applied to it even though we have reference tables in tree.

[Qemu-devel] [PATCH for-2.10 1/5] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table()

at best it's confusing that array for list of tables to be tested against reference tables is allocated within test_acpi_dsdt_table() and at worst it would just overwrite list of tables if they were added before test_acpi_dsdt_table(). Move array initialization to test_acpi_one() before we start

[Qemu-devel] [PATCH for-2.10 5/5] tests: acpi: fix FADT not being compared to reference table

It turns out that FADT isn't actually tested for changes against reference table, since it happens to be the 1st table in RSDT which is currently ignored. Fix it by making sure that all tables from RSDT are added to test list. Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH for-2.10 3/5] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage

Main purpose of test_dst_table() is loading a table from QEMU with checking that checksum in header matches actual one, rename it reflect main action it performs. Likewise test_acpi_tables() name is to broad, while the function only loads tables referenced by RSDT, rename it to reflect it.

Re: [Qemu-devel] [PATCH v4 0/3] qemu-img check: format allocation info

31.07.2017 18:14, Eric Blake wrote: On 07/29/2017 11:41 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. See 01 patch for the doc. Question to discuss. If I understand correctly get_block_status flags allocated, zero, and data actually provide 5 possible combinations, which I combine into

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

On 31/07/2017 16:51, Stefan Hajnoczi wrote: > typedef enum VhostUserRequest { > ... > > /* Submitted by the vhost-user master when the guest writes to > * virtio config space and also after live migration on the > * destination host. > */ > VHOST_USER_SET_CONFIG, > >

Re: [Qemu-devel] [PULL 0/7] target-arm queue

mjt/tags/trivial-patches-fetch' into > staging (2017-07-31 11:27:43 +0100) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20170731 > > for you to fetch changes up to 89cbc3778a3d61761e2231e74026921

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

On Mon, Jul 31, 2017 at 05:16:02PM +0200, Edgar E. Iglesias wrote: > On Wed, Jul 26, 2017 at 02:22:28PM +0200, Auger Eric wrote: > > Hi Diana, > > On 23/05/2017 13:12, Diana Craciun wrote: > > > Device IDs are required by the ARM GICv3 ITS for IRQ remapping. > > > Currently, for PCI devices, the

Re: [Qemu-devel] [PATCH v2 4/4] trace-events: fix code style: print 0x before hex numbers

On Mon, 31 Jul 2017 18:05:46 +0300 Vladimir Sementsov-Ogievskiy wrote: > 31.07.2017 12:49, Cornelia Huck wrote: > > On Sat, 29 Jul 2017 16:11:59 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> The only exception are groups of numers

Re: [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On 07/31/2017 12:17 PM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 11:54:57AM -0300, Philippe Mathieu-Daudé wrote: On 07/31/2017 11:38 AM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is

Re: [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On Mon, Jul 31, 2017 at 11:54:57AM -0300, Philippe Mathieu-Daudé wrote: > On 07/31/2017 11:38 AM, Jeff Cody wrote: > >On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > >>When skipping implicit nodes in bdrv_block_device_info(), we know that > >>bs0 is always non-NULL; initially,

Re: [Qemu-devel] [PATCH v2 1/2] trace: add TRACE__BACKEND_DSTATE()

On Mon, Jul 31, 2017 at 03:07:17PM +0100, Stefan Hajnoczi wrote: > QEMU keeps track of trace event enabled/disabled state and provides > monitor commands to inspect and modify the "dstate". SystemTap and > LTTng UST maintain independent enabled/disabled states for each trace > event, the other

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

On Wed, Jul 26, 2017 at 02:22:28PM +0200, Auger Eric wrote: > Hi Diana, > On 23/05/2017 13:12, Diana Craciun wrote: > > Device IDs are required by the ARM GICv3 ITS for IRQ remapping. > > Currently, for PCI devices, the requester ID was used as device > > ID in the virt machine. If the system has

Re: [Qemu-devel] [PATCH v4 0/3] qemu-img check: format allocation info

On 07/29/2017 11:41 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > See 01 patch for the doc. > > Question to discuss. > If I understand correctly get_block_status flags allocated, zero, and data > actually provide 5 possible combinations, which I combine into three. There are actually 8

Re: [Qemu-devel] [PATCH v2 0/2] Add global device ID in virt machine

On 07/31/2017 05:06 PM, Michael S. Tsirkin wrote: > On Mon, Jul 31, 2017 at 01:22:45PM +, Diana Madalina Craciun wrote: If we are to use a value of 0 for the constant in case of PCI devices, what happens if we have multiple PCI controllers? >>> I guess we'd use the PCI Segment number

Re: [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

Am 31.07.2017 um 16:54 hat Philippe Mathieu-Daudé geschrieben: > On 07/31/2017 11:38 AM, Jeff Cody wrote: > > On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > > > When skipping implicit nodes in bdrv_block_device_info(), we know that > > > bs0 is always non-NULL; initially, because

Re: [Qemu-devel] [PATCH v2 1/2] Add more function keys to QEMU

> On Jul 31, 2017, at 11:06 AM, Daniel P. Berrange wrote: > > On Mon, Jul 31, 2017 at 10:52:46AM -0400, Programmingkid wrote: >> >>> On Jul 31, 2017, at 9:10 AM, Daniel P. Berrange wrote: >>> >>> On Mon, Jul 31, 2017 at 08:46:56AM -0400,

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

On 31.07.2017 16:12, Michael S. Tsirkin wrote: > On Fri, Jul 28, 2017 at 05:48:07PM +0200, David Hildenbrand wrote: >> In general, a paravirtualized interface (for detection of PMEM regions) >> might have one big advantage: not limited to certain architectures. > > What follows is a generic rant,

Re: [Qemu-devel] [PATCH v2 2/2] trace: add trace_event_get_state_backends()

Stefan Hajnoczi writes: > Code that checks dstate is unaware of SystemTap and LTTng UST dstate, so > the following trace event will not fire when solely enabled by SystemTap > or LTTng UST: > if (trace_event_get_state(TRACE_MY_EVENT)) { > str = g_strdup_printf("Expensive string to

Re: [Qemu-devel] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

On Mon, Jul 31, 2017 at 09:44:13AM -0500, Eric Blake wrote: > On 07/31/2017 08:47 AM, Jeff Cody wrote: > > Right now, all qemu-iotests output data into the same scratch directory, > > and so each tests needs to be responsible for cleanup up its own files. > > s/cleanup up/cleaning up/ > Thanks -

Re: [Qemu-devel] [PATCH v2 1/2] Add more function keys to QEMU

On Mon, Jul 31, 2017 at 10:52:46AM -0400, Programmingkid wrote: > > > On Jul 31, 2017, at 9:10 AM, Daniel P. Berrange wrote: > > > > On Mon, Jul 31, 2017 at 08:46:56AM -0400, Programmingkid wrote: > >> > >>> On Jul 31, 2017, at 5:46 AM, Daniel P. Berrange

Re: [Qemu-devel] [PATCH v2 4/4] trace-events: fix code style: print 0x before hex numbers

31.07.2017 12:49, Cornelia Huck wrote: On Sat, 29 Jul 2017 16:11:59 +0300 Vladimir Sementsov-Ogievskiy wrote: The only exception are groups of numers separated by symbols '.', ' ', ':', '/', like 'ab.09.7d'. (...) Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

On Mon, Jul 31, 2017 at 4:50 PM, Eduardo Habkost wrote: > On Mon, Jul 31, 2017 at 10:51:06AM +0200, Amador Pahim wrote: >> Let's provide extra control and flexibility by using python logging >> system instead of print and/or sys.std*.write(). >> >> Signed-off-by: Amador Pahim

Re: [Qemu-devel] [PATCH v2 for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

On 07/31/2017 08:47 AM, Jeff Cody wrote: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is whatever is

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

On Sat, Jul 29, 2017 at 03:21:16AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Friday, July 28, 2017 6:36 PM > > To: Liu, Changpeng > > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com;

Re: [Qemu-devel] [RFC] block-insert-node and block-job-delete

On Fri, Jul 28, 2017 at 02:08:43PM +0200, Kevin Wolf wrote: > Am 27.07.2017 um 12:07 hat Stefan Hajnoczi geschrieben: > > On Wed, Jul 26, 2017 at 09:23:20PM +0300, Manos Pitsidianakis wrote: > > > On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote: > > > > On Wed, Jul 26, 2017 at

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

On 31.07.2017 16:23, Fam Zheng wrote: > On Sun, 07/30 19:23, Peter Maydell wrote: >> On 30 July 2017 at 17:51, Kamil Rytarowski wrote: >>> On 29.07.2017 21:34, Peter Maydell wrote: On 29 July 2017 at 14:50, Patrick Steinhardt wrote: > On Fri, Jul 28, 2017 at

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

On Mon, Jul 31, 2017 at 10:51:06AM +0200, Amador Pahim wrote: > Let's provide extra control and flexibility by using python logging > system instead of print and/or sys.std*.write(). > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py | 16 +--- > 1 file

Re: [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On 07/31/2017 11:38 AM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is always non-NULL; initially, because it's taken from a BdrvChild Not to mention, we deference bs0 in the chunk of

Re: [Qemu-devel] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

On 07/31/2017 08:47 AM, Jeff Cody wrote: > Right now, all qemu-iotests output data into the same scratch directory, > and so each tests needs to be responsible for cleanup up its own files. s/cleanup up/cleaning up/ > > Have each test use 'scratch/$seq' as its temp directory, so the check >

Re: [Qemu-devel] [PATCH v2 1/2] Add more function keys to QEMU

> On Jul 31, 2017, at 9:10 AM, Daniel P. Berrange wrote: > > On Mon, Jul 31, 2017 at 08:46:56AM -0400, Programmingkid wrote: >> >>> On Jul 31, 2017, at 5:46 AM, Daniel P. Berrange wrote: >>> >>> On Sun, Jul 30, 2017 at 04:29:27PM -0400,

Re: [Qemu-devel] [for-2.11 PATCH 04/26] spapr_drc: use g_strdup_printf() instead of snprintf()

On 07/31/2017 09:53 AM, David Gibson wrote: On Mon, Jul 31, 2017 at 12:34:41PM +0200, Greg Kurz wrote: On Mon, 31 Jul 2017 07:11:45 -0300 Philippe Mathieu-Daudé wrote: Hi David, On 07/26/2017 12:58 AM, David Gibson wrote: On Tue, Jul 25, 2017 at 07:58:53PM +0200, Greg Kurz

Re: [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > When skipping implicit nodes in bdrv_block_device_info(), we know that > bs0 is always non-NULL; initially, because it's taken from a BdrvChild Not to mention, we deference bs0 in the chunk of code right above this, so we'd segfault

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

On Mon, Jul 31, 2017 at 10:23:08PM +0800, Fam Zheng wrote: > On Sun, 07/30 19:23, Peter Maydell wrote: > > On 30 July 2017 at 17:51, Kamil Rytarowski wrote: > > > On 29.07.2017 21:34, Peter Maydell wrote: > > >> On 29 July 2017 at 14:50, Patrick Steinhardt wrote: > >

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

On 31 July 2017 at 15:23, Fam Zheng wrote: > No objection to adding more BSDs to patchew as long as I can find a few more > gigabytes RAM to run the VM (BTW I'm also thinking about converting long > running > VMs to boot/shutdown on demand, to support more types of guests). But

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

On Sun, 07/30 19:23, Peter Maydell wrote: > On 30 July 2017 at 17:51, Kamil Rytarowski wrote: > > On 29.07.2017 21:34, Peter Maydell wrote: > >> On 29 July 2017 at 14:50, Patrick Steinhardt wrote: > >>> On Fri, Jul 28, 2017 at 02:20:49PM -0300, Philippe Mathieu-Daudé

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

On Fri, Jul 28, 2017 at 05:48:07PM +0200, David Hildenbrand wrote: > In general, a paravirtualized interface (for detection of PMEM regions) > might have one big advantage: not limited to certain architectures. What follows is a generic rant, and slightly offtopic -sorry about that. I thought

Re: [Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

On 31/07/2017 17:00, Michael S. Tsirkin wrote: On Sat, Jul 29, 2017 at 02:34:31AM +0300, Aleksandr Bezzubikov wrote: On PCI init PCI bridge devices may need some extra info about bus number to reserve, IO, memory and prefetchable memory limits. QEMU can provide this with special vendor-specific

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

Am 31.07.2017 um 16:00 hat Eric Blake geschrieben: > On 07/31/2017 08:06 AM, Eric Blake wrote: > > On 07/31/2017 07:51 AM, Kevin Wolf wrote: > > In the subject line, s/redundat/redundant/ Thanks, I'll fix this. Kevin signature.asc Description: PGP signature

[Qemu-devel] [PATCH v2 1/2] trace: add TRACE__BACKEND_DSTATE()

QEMU keeps track of trace event enabled/disabled state and provides monitor commands to inspect and modify the "dstate". SystemTap and LTTng UST maintain independent enabled/disabled states for each trace event, the other backends rely on QEMU dstate. Introduce a new per-event macro that

Re: [Qemu-devel] [PATCH v6 1/7] qemu.py: use poll() instead of 'returncode'

On Mon, Jul 31, 2017 at 10:51:04AM +0200, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will: "Check if child process has terminated. > Set and return

[Qemu-devel] [PATCH v2 2/2] trace: add trace_event_get_state_backends()

Code that checks dstate is unaware of SystemTap and LTTng UST dstate, so the following trace event will not fire when solely enabled by SystemTap or LTTng UST: if (trace_event_get_state(TRACE_MY_EVENT)) { str = g_strdup_printf("Expensive string to generate ...",

[Qemu-devel] [PATCH v2 0/2] trace: fix trace_event_get_state() for SystemTap and LTTng UST

v2: * Don't special-case QEMU dstate [Daniel Berrange] * Use _backends() postfix to clarify function purpose [Lluís] Trace events that compute their arguments can affect performance. The following idom can be used to avoid computing arguments when the trace event is disabled: if

Re: [Qemu-devel] [PATCH v2 0/2] Add global device ID in virt machine

On Mon, Jul 31, 2017 at 01:22:45PM +, Diana Madalina Craciun wrote: > >> If we are to use a value of 0 for the constant in case of PCI devices, > >> what happens if we have multiple PCI controllers? > > I guess we'd use the PCI Segment number for that? > > > > > > Yes, we can use the PCI

Re: [Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

On Sat, Jul 29, 2017 at 02:34:31AM +0300, Aleksandr Bezzubikov wrote: > On PCI init PCI bridge devices may need some > extra info about bus number to reserve, IO, memory and > prefetchable memory limits. QEMU can provide this > with special vendor-specific PCI capability. > > This capability is

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On 07/31/2017 08:06 AM, Eric Blake wrote: > On 07/31/2017 07:51 AM, Kevin Wolf wrote: In the subject line, s/redundat/redundant/ >> When skipping implicit nodes in bdrv_block_device_info(), we know that >> bs0 is always non-NULL; initially, because it's taken from a BdrvChild >> and a BdrvChild

Re: [Qemu-devel] [PATCH v3 3/3] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

On Sat, Jul 29, 2017 at 02:34:32AM +0300, Aleksandr Bezzubikov wrote: > In case of Red Hat Generic PCIE Root Port reserve additional buses, > which number is provided in a vendor-specific capability. > > Signed-off-by: Aleksandr Bezzubikov Why does this ignore io/memory

[Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error

Now that ./check takes care of cleaning up after each tests, it can also selectively not clean up. Add option to leave all output from tests intact if that test encountered an error. Note: this currently only works for bash tests, as the python tests still clean up after themselves manually.

Re: [Qemu-devel] [PATCH v3 3/3] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

On Sat, Jul 29, 2017 at 02:34:32AM +0300, Aleksandr Bezzubikov wrote: > In case of Red Hat Generic PCIE Root Port reserve additional buses, > which number is provided in a vendor-specific capability. > > Signed-off-by: Aleksandr Bezzubikov > --- > src/fw/pciinit.c | 37

[Qemu-devel] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

Right now, all qemu-iotests output data into the same scratch directory, and so each tests needs to be responsible for cleanup up its own files. Have each test use 'scratch/$seq' as its temp directory, so the check script can do simple cleanup of removing the whole temporary directory.

[Qemu-devel] [PATCH v2 for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

All files for a given test are now self-contained in a subdirectory, and therefore the "./check" script can do all file-related cleanup without any help. This removes file cleanups from the bash tests. The only cleanup left is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu.

[Qemu-devel] [PATCH v2 for-2.11 0/3] qemu-iotests: place output in unique dir

Differences v1 -> v2: Rebase on Kevin's block branch [Suggested-by Eric] Patch 1: 'check': Added && to the directory change so that the test cannot run if the directory change fails [Thanks Eric] Patch 2: [Thanks Eric] 058: Removed the _cleanup(), and just trap _cleanup_nbd() 091:

Re: [Qemu-devel] [PATCH] migration: optimize the downtime

* Jay Zhou (jianjay.z...@huawei.com) wrote: > Hi Dave, > > On 2017/7/25 18:34, Dr. David Alan Gilbert wrote: > > > After checking the codes of the newest libvirt, I think it is the same > > > in the qemuMigrationWaitForCompletion function, which is used to poll > > > qemu every 50ms. > > > >

[Qemu-devel] [PATCH] target-mips: Don't stop on [d]mtc0 DESAVE/KScratch

Writing to the MIPS DESAVE register (and now the KScratch registers) will stop translation, supposedly due to risk of execution mode switches. However these registers are basically RW scratch registers with no side effects so there is no risk of them triggering execution mode changes. Drop the

Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI

> From: Markus Armbruster [mailto:arm...@redhat.com] > "Pavel Dovgalyuk" writes: > > >> From: Markus Armbruster [mailto:arm...@redhat.com] > >> ReplayMode is defined in the QAPI schema, but not used there. Of the > >> stuff QAPI generates for it only the typedef is actually

Re: [Qemu-devel] [Bug 1707297] [NEW] qemu became more picky parsing -m option

Eric Blake writes: > On 07/31/2017 03:34 AM, Markus Armbruster wrote: >> John Florian <1707...@bugs.launchpad.net> writes: >> >>> Public bug reported: >>> >>> With qemu-kvm-2.9.0-3.fc26.x86_64 I am no longer to specify the memory >>> size using something like "-m 1.0GiB"

Re: [Qemu-devel] [PATCH v2 0/2] Add global device ID in virt machine

On 07/06/2017 02:44 AM, Michael S. Tsirkin wrote: > On Wed, May 31, 2017 at 12:02:56PM +, Diana Madalina Craciun wrote: >> On 05/25/2017 01:12 AM, Michael S. Tsirkin wrote: >>> On Tue, May 23, 2017 at 02:12:43PM +0300, Diana Craciun wrote: The NXP DPAA2 is a hardware architecture designed

Re: [Qemu-devel] [PATCH] target/mips: Fix microMIPS jumps in 128MB block

On Wed, Jul 19, 2017 at 08:41:26AM -0700, no-re...@patchew.org wrote: > ERROR:/tmp/qemu-test/src/tests/test-qga.c:78:fixture_setup: assertion failed > (fixture->fd != -1): (-1 != -1) > GTester: last random seed: R02Sdc111f0781db4246a37f87a06bb4b260 > make: *** [check-tests/test-qga] Error 1 >

Re: [Qemu-devel] [RFC v2 6/8] virtio-iommu: Implement the translation and commands

Hi Peter, Bharat, On 17/07/2017 03:28, Peter Xu wrote: > On Fri, Jul 14, 2017 at 06:40:34AM +, Bharat Bhushan wrote: >> Hi Peter, >> >>> -Original Message- >>> From: Peter Xu [mailto:pet...@redhat.com] >>> Sent: Friday, July 14, 2017 7:48 AM >>> To: Eric Auger

Re: [Qemu-devel] [PATCH v2 0/2] Add global device ID in virt machine

Hi Peter, On 07/10/2017 08:10 PM, Peter Maydell wrote: On 23 May 2017 at 12:12, Diana Craciun wrote: The NXP DPAA2 is a hardware architecture designed for high-speeed network packet processing. The DPAA2 hardware components are managed by

[Qemu-devel] [Bug 1707297] Re: qemu became more picky parsing -m option

Not sure why I can only see Markus' comment here as part of Eric's but anyway... the behavior change *is* expected. Can qemu behave more like virsh then? That would be ideal IMHO. I prefer to specify my RAM in powers of 2 and disk in powers of 10 so that when I test virtually using qemu I more

Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI

"Pavel Dovgalyuk" writes: >> From: Markus Armbruster [mailto:arm...@redhat.com] >> ReplayMode is defined in the QAPI schema, but not used there. Of the >> stuff QAPI generates for it only the typedef is actually used. Use of >> QAPI is pointless and only complicates things,

Re: [Qemu-devel] [for-2.11 PATCH 04/26] spapr_drc: use g_strdup_printf() instead of snprintf()

On Mon, Jul 31, 2017 at 12:34:41PM +0200, Greg Kurz wrote: > On Mon, 31 Jul 2017 07:11:45 -0300 > Philippe Mathieu-Daudé wrote: > > > Hi David, > > > > On 07/26/2017 12:58 AM, David Gibson wrote: > > > On Tue, Jul 25, 2017 at 07:58:53PM +0200, Greg Kurz wrote: > > >> Passing

[Qemu-devel] [PATCH 2/2] mips: Add KVM T segment support for TCG

MIPS KVM trap & emulate guest kernels have a different segment layout compared with traditional MIPS kernels, to allow both the user and kernel code to run from the user address segment without repeatedly trapping to KVM. QEMU currently supports this layout only for KVM, but its sometimes useful

Re: [Qemu-devel] [PATCH v2 1/2] Add more function keys to QEMU

On Mon, Jul 31, 2017 at 08:46:56AM -0400, Programmingkid wrote: > > > On Jul 31, 2017, at 5:46 AM, Daniel P. Berrange wrote: > > > > On Sun, Jul 30, 2017 at 04:29:27PM -0400, Programmingkid wrote: > >> There are now keyboards that have 19 function keys. This patch extends

[Qemu-devel] [PATCH 1/2] mips: Improve segment defs for KVM T guests

Improve the segment definitions used by get_physical_address() to yield target_ulong types, e.g. 0x8000 instead of 0x8000. This is in preparation for enabling emulation of MIPS KVM T segments in TCG MIPS targets, which unlike KVM could potentially have 64-bit target_ulong. In such

[Qemu-devel] [PATCH 0/2] mips: KVM T segment support for TCG

MIPS KVM trap & emulate guest kernels have a different segment layout compared with traditional MIPS kernels, to allow both the user and kernel code to run from the user address segment without repeatedly trapping to KVM. QEMU currently supports this layout only for KVM, but its sometimes useful

Re: [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On 07/31/2017 07:51 AM, Kevin Wolf wrote: > When skipping implicit nodes in bdrv_block_device_info(), we know that > bs0 is always non-NULL; initially, because it's taken from a BdrvChild > and a BdrvChild never has a NULL bs, and after the first iteration > because implicit nodes always have a

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

On 07/31/2017 01:50 AM, Peter Maydell wrote: On 28 July 2017 at 22:28, Anatol Pomozov wrote: So I need to perform 2 things: - Load ELF section headers into target's memory. I did by appending additional space to mbs.mb_buf and copying header data. Is it the best

Re: [Qemu-devel] [PATCH for-2.11 3/3] qemu-iotests: add option to save temp files on error

On 07/31/2017 12:04 AM, Jeff Cody wrote: > Now that ./check takes care of cleaning up after each tests, it > can also selectively not clean up. Add option to leave all output from > tests intact if that test encountered an error. > > Note: this currently only works for bash tests, as the python

Re: [Qemu-devel] [PULL 15/25] syscall: fix dereference of undefined pointer

On 31 July 2017 at 11:21, Michael Tokarev wrote: > From: Philippe Mathieu-Daudé > > linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value > if (*host_rt_dev_ptr != 0) { > ^~~~ > > Reported-by: Clang Static Analyzer

[Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is always non-NULL; initially, because it's taken from a BdrvChild and a BdrvChild never has a NULL bs, and after the first iteration because implicit nodes always have a backing file. Remove the NULL check and add an

Re: [Qemu-devel] [PATCH v2 3/4] checkpatch: check trace-events code style

On 07/31/2017 04:26 AM, Stefan Hajnoczi wrote: > On Sat, Jul 29, 2017 at 04:11:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Accordingly to CODING_STYLE, check that in trace-events: s/Accordingly/According/ >> 1. hex numbers are prefixed with '0x' >> 2. '#' flag of printf is not used >> 3.

Re: [Qemu-devel] [PATCH v2 2/4] trace-events: fix code style: %# -> 0x%

On 07/29/2017 08:11 AM, Vladimir Sementsov-Ogievskiy wrote: > In trace format '#' flag of printf is forbidden. Fix it to '0x%'. > > This patch is created by the following: > > check that we have a problem >> find . -name trace-events | xargs grep '%#' | wc -l > 56 > > check that there are no

Re: [Qemu-devel] [PATCH v2 1/2] Add more function keys to QEMU

> On Jul 31, 2017, at 5:46 AM, Daniel P. Berrange wrote: > > On Sun, Jul 30, 2017 at 04:29:27PM -0400, Programmingkid wrote: >> There are now keyboards that have 19 function keys. This patch extends QEMU >> so these function keys can be used. >> >> Signed-off-by: John

Re: [Qemu-devel] [PATCH v2 1/4] coding_style: add point about 0x in trace-events

On 07/31/2017 04:19 AM, Stefan Hajnoczi wrote: > On Sat, Jul 29, 2017 at 04:11:56PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> CODING_STYLE | 23 +++ >> 1 file changed, 23 insertions(+) >> >>

Re: [Qemu-devel] [Bug 1707297] [NEW] qemu became more picky parsing -m option

On 07/31/2017 03:34 AM, Markus Armbruster wrote: > John Florian <1707...@bugs.launchpad.net> writes: > >> Public bug reported: >> >> With qemu-kvm-2.9.0-3.fc26.x86_64 I am no longer to specify the memory >> size using something like "-m 1.0GiB" but with qemu- >> kvm-2.7.1-7.fc25.x86_64 I

Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends

On 07/31/2017 03:16 AM, Markus Armbruster wrote: qtest_qmp(s, "%p", QOBJECT(dict)) takes ownership of dict? >>> >> So given the clean bill of health from valgrind, we definitely DO turn >> over responsibility for freeing on object to its new wrapper, once it is >> passed through %p.

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

On 07/31/2017 12:20 AM, Michael S. Tsirkin wrote: On Sun, Jul 30, 2017 at 07:18:33PM +0300, Michael S. Tsirkin wrote: On Sun, Jul 30, 2017 at 05:59:17AM +, Wang, Wei W wrote: That's a hypervisor implementation detail. From guest point of view, discarding contents can not be distinguished

Re: [Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug

On 07/31/2017 01:13 PM, Cornelia Huck wrote: > On Mon, 31 Jul 2017 11:51:37 +0800 > Dong Jia Shi wrote: > >> * Cornelia Huck [2017-07-27 13:59:10 +0200]: >> >>> On Thu, 27 Jul 2017 03:54:18 +0200 >>> Dong Jia Shi

Re: [Qemu-devel] [PATCH for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

On Mon, Jul 31, 2017 at 07:20:03AM -0500, Eric Blake wrote: > On 07/31/2017 12:04 AM, Jeff Cody wrote: > > All files for a given test are now self-contained in a subdirectory, > > and therefore the "./check" script can do all file-related cleanup > > without any help. > > > > This removes file

[Qemu-devel] [PULL 2/7] target/arm: Don't do MPU lookups for addresses in M profile PPB region

The M profile PMSAv7 specification says that if the address being looked up is in the PPB region (0xe000 - 0xe00f) then we do not use the MPU regions but always use the default memory map. Implement this (we were previously behaving like an R profile PMSAv7, which does not special case

[Qemu-devel] [PULL 3/7] target/arm: Don't allow guest to make System space executable for M profile

For an M profile v7PMSA, the system space (0xe000 - 0x) can never be executable, even if the guest tries to set the MPU registers up that way. Enforce this restriction. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 0/7] target-arm queue

at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170731 for you to fetch changes up to 89cbc3778a3d61761e2231e740269218c9a8a41d: hw/mps2_scc: fix incorrect properties (2017-07-31 13:11:56 +0100) target-arm

[Qemu-devel] [PULL 5/7] target/arm: Move PMSAv7 reset into arm_cpu_reset() so M profile MPUs get reset

When the PMSAv7 implementation was originally added it was for R profile CPUs only, and reset was handled using the cpreg .resetfn hooks. Unfortunately for M profile cores this doesn't work, because they do not register any cpregs. Move the reset handling into arm_cpu_reset(), where it will work

[Qemu-devel] [PULL 4/7] target/arm: Rename cp15.c6_rgnr to pmsav7.rnr

Almost all of the PMSAv7 state is in the pmsav7 substruct of the ARM CPU state structure. The exception is the region number register, which is in cp15.c6_rgnr. This exception is a bit odd for M profile, which otherwise generally does not store state in the cp15 substruct. Rename cp15.c6_rgnr to

[Qemu-devel] [PULL 1/7] target/arm: Correct MPU trace handling of write vs execute

Correct off-by-one bug in the PSMAv7 MPU tracing where it would print a write access as "reading", an insn fetch as "writing", and a read access as "execute". Since we have an MMUAccessType enum now, we can make the code clearer in the process by using that rather than the raw 0/1/2 values.

[Qemu-devel] [PULL 6/7] target/arm: Migrate MPU_RNR register state for M profile cores

The PMSAv7 region number register is migrated for R profile cores using the cpreg scheme, but M profile doesn't use cpregs, and so we weren't migrating the MPU_RNR register state at all. Fix that by adding a migration subsection for the M profile case. Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 7/7] hw/mps2_scc: fix incorrect properties

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20170729234930.725-1-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/misc/mps2-scc.c | 4 ++-- 1

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

On 07/31/2017 03:20 AM, Markus Armbruster wrote: >>> It's not "worse", it's just different :) >>> >>> Suggest: >> >> "Mikey likes it" (no idea if that pop culture reference from my >> childhood has broader range than the US) > > 'fraid I'm out of range :) It's not fair of me to leave you

Re: [Qemu-devel] [PATCH for 2.10] hw/mps2_scc: fix incorrect properties

On 30 July 2017 at 00:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > sorry, I missed them in my review :( > > hw/misc/mps2-scc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/misc/mps2-scc.c

Re: [Qemu-devel] [PATCH for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

On 07/31/2017 12:04 AM, Jeff Cody wrote: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is whatever is

Re: [Qemu-devel] [PATCH for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

On 07/31/2017 12:04 AM, Jeff Cody wrote: > Right now, all qemu-iotests output data into the same scratch directory, > and so each tests needs to be responsible for cleanup up its own files. And, tests must either use unique names or else cannot be run in parallel. > > Have each test use

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.10 0/5] M profile MPU bugfixes

On 27 July 2017 at 11:59, Peter Maydell wrote: > This patchset fixes some bugs in the M profile MPU code: > * the guest shouldn't be able to make system space executable > * PPB region accesses should not be subject to MPU lookups > * we were not resetting the PMSAv7

Re: [Qemu-devel] [PATCH] hw/arm: use defined type name instead of hard-coded string

On 27 July 2017 at 14:48, Philippe Mathieu-Daudé wrote: > On 07/27/2017 09:36 AM, Peter Maydell wrote: >> >> On 17 July 2017 at 14:30, Philippe Mathieu-Daudé wrote: >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> >>> Hi Peter, this

Re: [Qemu-devel] [PULL 00/25 for-2.10] Trivial patches for 2017-07-31

y Philippe Mathieu-Daudé. > > Please consider applying. > > Thanks, > > /mjt > > The following changes since commit 0c26c080ee592ea47597d3ab8fd712d7d2c4ba0f: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170731' > into staging (2017-07-31 09:5

<    1   2   3   >