[Qemu-devel] blockdev-commit design

Hi, as the next step after my commit block job fixes, I'm trying to implement a new, clean version of the QMP command, which I'm calling blockdev-commit for consistency with all the other "modern" QMP commands. I'll start with the schema that I have so far: { 'command': 'blockdev-commit',

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

On 26 September 2017 at 18:27, Thomas Huth wrote: > On 25.09.2017 19:59, Eduardo Habkost wrote: >> On Mon, Sep 25, 2017 at 07:42:13PM +0200, Thomas Huth wrote: >> "make check" found a few candidates: >> https://travis-ci.org/ehabkost/qemu/jobs/278743999 >> >> Initialization of

Re: [Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27

On 09/19/2017 07:45 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.10.1: > > https://github.com/mdroth/qemu/commits/stable-2.10-staging > > The release is planned for 2017-10-02: > > https://wiki.qemu.org/Planning/2.10 > > Please respond

[Qemu-devel] [PATCH v1 6/6] s390x/tcg: make idte/ipte use the new _real mmu

We don't wrap addresses in the mmu for the _real case, therefore the behavior should be unchanged. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c

Re: [Qemu-devel] blockdev-commit design

Am 26.09.2017 um 20:29 hat Eric Blake geschrieben: > On 09/26/2017 12:59 PM, Kevin Wolf wrote: > > This was the easy part. Then I started looking at the code and found a > > few a bit more interesting questions: > > > > * The old block-commit command decides between an "actual" commit job > >

Re: [Qemu-devel] [PATCH v4 03/23] block: Make bdrv_round_to_clusters() signature more useful

On 09/26/2017 01:51 PM, John Snow wrote: > > > On 09/13/2017 12:03 PM, Eric Blake wrote: >> In the process of converting sector-based interfaces to bytes, >> I'm finding it easier to represent a byte count as a 64-bit >> integer at the block layer (even if we are internally capped >> by SIZE_MAX

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

On Fri, Sep 22, 2017 at 05:06:57AM +0200, Thomas Huth wrote: > If QEMU has been compiled with the flags --enable-tcg-interpreter and > --enable-debug, the guest is running incredibly slow. The pxe boot test > can take up to 400 seconds when testing the pseries ppc64 machine. While > we should

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

On 26 September 2017 at 20:31, Michael S. Tsirkin wrote: > On Mon, Sep 25, 2017 at 12:06:40AM +0300, Michael Tokarev wrote: >> 22.09.2017 06:06, Thomas Huth wrote: >> > If QEMU has been compiled with the flags --enable-tcg-interpreter and >> > --enable-debug, the guest is running

[Qemu-devel] [PATCH v3 2/9] target/ppc: Convert to disas_set_info hook

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 33 - monitor.c | 5 - target/ppc/translate.c | 5 + target/ppc/translate_init.c |

[Qemu-devel] [PATCH v3 3/9] disas: Remove unused flags arguments

Now that every target is using the disas_set_info hook, the flags argument is unused. Remove it. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/disas/disas.h | 4 ++-- include/exec/log.h| 4 ++--

Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1

On 26.09.2017 20:05, Christian Borntraeger wrote: > We disabled ais for 2.10 lets also remove it from the z14 default model. > > Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility > Signed-off-by: Christian Borntraeger > --- >

Re: [Qemu-devel] [PATCH v4 03/23] block: Make bdrv_round_to_clusters() signature more useful

On 09/13/2017 12:03 PM, Eric Blake wrote: > In the process of converting sector-based interfaces to bytes, > I'm finding it easier to represent a byte count as a 64-bit > integer at the block layer (even if we are internally capped > by SIZE_MAX or even INT_MAX for individual transactions, it's

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

On Mon, Sep 25, 2017 at 12:06:40AM +0300, Michael Tokarev wrote: > 22.09.2017 06:06, Thomas Huth wrote: > > If QEMU has been compiled with the flags --enable-tcg-interpreter and > > --enable-debug, the guest is running incredibly slow. The pxe boot test > > can take up to 400 seconds when testing

Re: [Qemu-devel] [PATCH v2 1/3] nbd-client: avoid read_reply_co entry if send failed

CC: qemu-sta...@nongnu.org On 08/29/2017 07:27 AM, Stefan Hajnoczi wrote: > The following segfault is encountered if the NBD server closes the UNIX > domain socket immediately after negotiation: > > Program terminated with signal SIGSEGV, Segmentation fault. ... > Note this only happens with

[Qemu-devel] [PATCH v1 3/6] s390x/tcg: make lura(g) use the new _real mmu.

Looks like, lurag was not loading 64bit but only 32bit. As we properly handle the return address now, we can drop potential_page_fault(). Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 7 ++- target/s390x/translate.c | 2 -- 2 files changed, 2

[Qemu-devel] [PATCH v1 2/6] s390x/tcg: add MMU for real addresses

This makes it easy to access real addresses (prefix) and in addition checks for valid memory addresses, which is missing when using e.g. stl_phys(). We can later reuse it to implement low address protection checks (then we might even decide to introduce yet another MMU for absolute addresses,

[Qemu-devel] [PATCH v1 4/6] s390x/tcg: make stora(g) use the new _real mmu

As we properly handle the return address now, we can drop potential_page_fault(). Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 8 ++-- target/s390x/translate.c | 2 -- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 04/23] qcow2: Switch is_zero_sectors() to byte-based

On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > function (no semantic change), and rename it to is_zero() in the > process. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH v4 03/23] block: Make bdrv_round_to_clusters() signature more useful

On 09/26/2017 03:18 PM, Eric Blake wrote: > On 09/26/2017 01:51 PM, John Snow wrote: >> >> >> On 09/13/2017 12:03 PM, Eric Blake wrote: >>> In the process of converting sector-based interfaces to bytes, >>> I'm finding it easier to represent a byte count as a 64-bit >>> integer at the block

Re: [Qemu-devel] [PATCH v4 07/23] block: Convert bdrv_get_block_status() to bytes

On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. In the common case, allocation is unlikely to ever use > values that are not naturally sector-aligned, but it is possible > that byte-based values will let us be more

[Qemu-devel] [PATCH v3 7/9] ppc: Support Capstone in disas_set_info

Signed-off-by: Richard Henderson --- disas.c | 4 target/ppc/translate_init.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/disas.c b/disas.c index 23c4742f8d..0d212f2ac5 100644 --- a/disas.c +++ b/disas.c @@ -449,6 +449,10 @@

[Qemu-devel] [PATCH v3 9/9] disas: Add capstone as submodule

Do not require the submodule, but use it if present (in preference even to a system copy). This will allow us to easily use capstone in older systems for which a package is not available, and also easily track bug fixes from upstream. Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v4 09/23] block: Switch BdrvCoGetBlockStatusData to byte-based

On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > type (no semantic change), and rename it to match the corresponding > public function rename. > > Signed-off-by:

[Qemu-devel] [PATCH] gitignore: ignore check-qlit test

Signed-off-by: Carlo Marcelo Arenas Belón --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index cf6d99c91e..53cb2efaee 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ check-qdict check-qnum

[Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1

We disabled ais for 2.10 lets also remove it from the z14 default model. Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility Signed-off-by: Christian Borntraeger --- target/s390x/gen-features.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v4 02/23] block: Add flag to avoid wasted work in bdrv_is_allocated()

On 09/13/2017 12:03 PM, Eric Blake wrote: > Not all callers care about which BDS owns the mapping for a given > range of the file. In particular, bdrv_is_allocated() cares more > about finding the largest run of allocated data from the guest > perspective, whether or not that data is

Re: [Qemu-devel] [PATCH v4 06/23] qemu-img: Switch get_block_status() to byte-based

On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Continue by converting > an internal function (no semantic change), and simplifying its > caller accordingly. > > Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v3 0/9] Support the Capstone disassembler

Changes since v2: * Fix a minor buglet in the monitor disassembly * Add capstone as a submodule, preferring that when present. The submodule idea came from discussion with PMM. The idea is that we would potentially remove the old binutils code, and libvxil, and rely on capstone entirely.

[Qemu-devel] [PATCH v3 1/9] target/i386: Convert to disas_set_info hook

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 22 ++ monitor.c | 21 - target/i386/cpu.c | 12 target/i386/translate.c | 8

[Qemu-devel] [PATCH v3 4/9] disas: Support the Capstone disassembler library

If configured, prefer this over our rather dated copy of the GPLv2-only binutils. This will be especially apparent with the proposed vector extensions to TCG, as disas/i386.c does not handle AVX. Signed-off-by: Richard Henderson --- include/disas/bfd.h | 4

[Qemu-devel] [PATCH v3 5/9] i386: Support Capstone in disas_set_info

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 4 target/i386/cpu.c | 7 +++ 2 files changed, 11 insertions(+) diff --git a/disas.c b/disas.c index 746d76c07d..1c44514254 100644 --- a/disas.c +++

Re: [Qemu-devel] [PULL 0/4] NBD patches for 2017-09-25

On 25 September 2017 at 14:41, Eric Blake wrote: > The following changes since commit 460b6c8e581aa06b86f59eebd9e52edfe7adf417: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-09-23 12:55:40 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

On 09/19/2017 08:03 AM, Richard Henderson wrote: > +while (1) { > +/* We want to read memory for one insn, but generically we do not > + know how much memory that is. We have a small buffer which is > + known to be sufficient for all supported targets. Try to not

Re: [Qemu-devel] [PULL 0/1] tcg patch queue

On 25 September 2017 at 23:16, Richard Henderson wrote: > Just one patch, but should make stable 2.10.1 this week. > > > r~ > > > The following changes since commit 460b6c8e581aa06b86f59eebd9e52edfe7adf417: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v4 05/23] block: Switch bdrv_make_zero() to byte-based

On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Change the internal > loop iteration of zeroing a device to track by bytes instead of > sectors (although we are still guaranteed that we

Re: [Qemu-devel] [PULL 0/2] Fw 20170926 patches

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20170926110628.2705-1-kra...@redhat.com Subject: [Qemu-devel] [PULL 0/2] Fw 20170926 patches

[Qemu-devel] [PATCH v3 6/9] arm: Support Capstone in disas_set_info

Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 3 +++ target/arm/cpu.c | 21 ++--- 2 files changed, 21 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v1 1/6] s390x/tcg: fix checking for invalid memory check

It should have been a >=, but let's directly perform a proper access check to also be able to deal with hotplugged memory later. Signed-off-by: David Hildenbrand --- target/s390x/excp_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using low address

Conny reported that a guest Linux currently spits out: "The s390-virtio transport is deprecated. Please switch to a modern host providing virtio-ccw." This is strange, because we have no legacy virtio transport in QEMU :) Main problem is, that a page is tested for acccess, and the test does

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

On 26.09.2017 18:20, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > creating the s390 phb dependant on the zpci facility. This broke > migration from pre-cpu model machines which was fixed with > 8ad9087c4a ("s390x/ccw: create s390 phb for compat reasons as

Re: [Qemu-devel] blockdev-commit design

On 09/26/2017 12:59 PM, Kevin Wolf wrote: > Hi, > > as the next step after my commit block job fixes, I'm trying to > implement a new, clean version of the QMP command, which I'm calling > blockdev-commit for consistency with all the other "modern" QMP > commands. > > I'll start with the schema

[Qemu-devel] [PATCH v1 5/6] s390x/tcg: make testblock use the new _real mmu

Low address protection checks will be moved into the mmu later. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index

Re: [Qemu-devel] [PATCH v3 1/6] tcg: Add types and operations for host vectors

Richard Henderson writes: > Nothing uses or enables them yet. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h | 26 +++ > tcg/tcg-opc.h | 37 ++ > tcg/tcg.h | 34 + > tcg/tcg-op.c | 234 >

Re: [Qemu-devel] [PATCH v4 07/23] block: Convert bdrv_get_block_status() to bytes

On 09/26/2017 02:39 PM, John Snow wrote: >> -int64_t bdrv_get_block_status(BlockDriverState *bs, >> - int64_t sector_num, >> - int nb_sectors, int *pnum, >> - BlockDriverState **file) >> +int64_t

Re: [Qemu-devel] [PATCH v4 08/23] block: Switch bdrv_co_get_block_status() to byte-based

On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > function (no semantic change); and as with its public counterpart, > rename to bdrv_co_block_status() to make the

[Qemu-devel] [PATCH v3 8/9] disas: Remove monitor_disas_is_physical

Even though there is only one monitor, and thus no race on this global data object, there is also no point in having it. We can just as well record the decision in the read_memory_function that we select. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 2/4] qmp: get_device_class() helper

Extract device type lookup code from qmp_device_list_properties() to a get_device_class() helper. It will be reused by other QMP commands. Signed-off-by: Eduardo Habkost --- qmp.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 0/4] qmp: query-device-type command

This series implements a new 'query-device-type' command, that can be used to query TYPE_DEVICE-specific information that is not returned by qom-list-types. The new field can be used instead of "info qdm" parsing by the device-crash-test script. It can be also used by hotplug test cases, to skip

[Qemu-devel] [PATCH 1/4] qmp: qom_type_get_info() helper

Extract the code that fills ObjectTypeInfo fields to a qom_type_get_info() helper. It will be reused in other QMP commands. Signed-off-by: Eduardo Habkost --- qmp.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/qmp.c b/qmp.c index

[Qemu-devel] [PATCH 3/4] qmp: query-device-type command

Add a command that returns QOM type information that is specific to device types and is not returned by qom-list-types. The returned DeviceTypeInfo struct inherits from ObjectTypeInfo, so fields returned by qom-list-types are also included. Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 2/6] device-crash-test: Log detailed info on success too

Instead of making checkOneCase() return None on success, return detailed info even if no problems were found. This will make handling of device_add errors simpler, and improve debug output. As logFailure() won't handle only failures, rename it to logResult() and make it a bit more flexible about

[Qemu-devel] [RFC 4/6] device-crash-test: Exit immediately on fatal failures on quick mode

If we're running on quick mode, we won't wait for the full test run, and will exit immediately if a fatal failure is found. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 4 1 file changed, 4 insertions(+) diff --git a/scripts/device-crash-test

[Qemu-devel] [RFC 1/6] device-crash-test: Make whitelist code a bit more flexible

Allow test results without the 'log' and 'exitcode' keys. The new device_add code won't report exitcode/log because multiple devices will be tested on a single QEMU run. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 5 +++-- 1 file changed, 3

[Qemu-devel] [RFC 0/6] device-crash-test: device_add test mode

This series implements device_add testing on device-crash-test. The new test mode will be enabled by default in addition to the old test cases, but if only device_add testing is wanted, it can be specified using the '-t' command-line option, e.g.: $ ./scripts/device-crash-test -t

Re: [Qemu-devel] [PATCH] gitignore: ignore check-qlit test

On 09/26/2017 03:25 PM, Carlo Marcelo Arenas Belón wrote: Worth mentioning in the commit message body that it was introduced in commit 382176b4. > Signed-off-by: Carlo Marcelo Arenas Belón > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

Am 26.09.2017 um 21:30 schrieb Michael S. Tsirkin: > On Fri, Sep 22, 2017 at 05:06:57AM +0200, Thomas Huth wrote: >> If QEMU has been compiled with the flags --enable-tcg-interpreter and >> --enable-debug, the guest is running incredibly slow. The pxe boot test >> can take up to 400 seconds when

[Qemu-devel] [RFC 3/6] device-crash-test: Allow checkOneCase() to report multiple results

This will allow the test code to be improved to test multiple devices in a single run. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/scripts/device-crash-test

[Qemu-devel] [RFC 6/6] device-crash-test: Multi-device device_add test

When running device_add tests, test all devices in a single run instead of restarting QEMU every time. There's a plug_all testcase argument that can be used to make the test code plug all devices at once. I'm adding this mode because there's a crash that was detected while testing the script

[Qemu-devel] [RFC 5/6] device-crash-test: Basic device_add support

Add a 'method' testcase argument that will test the device using device_add instead of -device. A new device_add_error whitelist key is now supported, to catch device_add errors. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 38

[Qemu-devel] [PATCH 4/4] device-crash-test: Use query-device-info for user-creatable check

Now that we have query-device-info, we don't need to parse "info qdm" output to find out if a device is user-creatable. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 2/6] tcg: Add vector expanders

Richard Henderson writes: > Signed-off-by: Richard Henderson Other than live comments: Reviewed-by: Alex Bennée > --- > Makefile.target | 2 +- > accel/tcg/tcg-runtime.h | 24 ++ >

Re: [Qemu-devel] [PATCH v3 0/9] Support the Capstone disassembler

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20170926201427.2833-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v3 0/9] Support the

Re: [Qemu-devel] [PULL 00/29] Trivial patches for 2017-09-26

On 26 September 2017 at 07:14, Michael Tokarev wrote: > This is a resend of yesterday's pull request, with two patches > removed: > filter-mirror: segfault when specifying non existent device > (causes testsuite to fail) > dma/i82374: avoid double creation of i82374

[Qemu-devel] [PATCH v2] gitignore: ignore check-qlit test

test introduced in 382176b4d78e070d119af8e0dcd00884c11bbec2 Signed-off-by: Carlo Marcelo Arenas Belón Reviewed-by: Eric Blake --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index

Re: [Qemu-devel] [PATCH v3 3/6] target/arm: Align vector registers

Richard Henderson writes: > Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée > --- > target/arm/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/cpu.h

Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using low address

On 09/26/2017 11:33 AM, David Hildenbrand wrote: > David Hildenbrand (6): > s390x/tcg: fix checking for invalid memory check > s390x/tcg: add MMU for real addresses > s390x/tcg: make lura(g) use the new _real mmu. > s390x/tcg: make stora(g) use the new _real mmu > s390x/tcg: make

Re: [Qemu-devel] [PATCH v3 4/6] target/arm: Use vector infrastructure for aa64 add/sub/logic

Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 216 > ++--- > 1 file changed, 143

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

Hi Halil, On 2017/9/15 23:59, Halil Pasic wrote: > > > On 09/11/2017 03:12 AM, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >>

[Qemu-devel] [Bug 1719689] [NEW] [feature request] add flag to treat warnings as errors

Public bug reported: Since booting could potentially take a lot of time and warnings are likely to indicate that something is wrong, it would be useful to have a command line flag which would abort the boot if there are any warnings. An example might be network configuration. The following

Re: [Qemu-devel] [PATCH v3 0/6] TCG vectorization and example conversion

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170916023417.14599-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v3 0/6] TCG vectorization and example conversion === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made creating the s390 phb dependant on the zpci facility. This broke migration from pre-cpu model machines which was fixed with 8ad9087c4a ("s390x/ccw: create s390 phb for compat reasons as well"). However, that is not enough: Migration from

[Qemu-devel] [PATCH 0/1] s390x: more zpci compat fun

Here's a (hopefully) less hackish variant of the fix in <932ad4e2-a10c-77fc-fcb7-5dbbed0d2...@de.ibm.com>. Not really tested (I had problems reproducing the problem on z12, but that might be just me). Please review & test, if possible. Patch against my s390-next branch (but should fix on top of

Re: [Qemu-devel] [PATCH 4/7] tcg: Add support for "inlining" regions of code

Lluís Vilanova writes: > Richard Henderson writes: >> On 09/14/2017 08:20 AM, Lluís Vilanova wrote: >>> Richard Henderson writes: >>> On 09/10/2017 09:27 AM, Lluís Vilanova wrote: > TCG BBLs and instructions have multiple exit points from where to raise > tracing events, but some of

Re: [Qemu-devel] [PATCH 2/5] commit: Support multiple roots above top node

Am 25.09.2017 um 21:38 hat Eric Blake geschrieben: > On 09/25/2017 07:28 AM, Kevin Wolf wrote: > > This changes the commit block job to support operation in a graph where > > there is more than a single active layer that references the top node. > > > > This involves inserting the commit filter

Re: [Qemu-devel] [PATCH v1 8/8] target: Replace fprintf(stderr, "*\n" with error_report()

On 09/25/2017 05:09 PM, Alistair Francis wrote: > diff --git a/target/cris/translate.c b/target/cris/translate.c > index 38a999e6f1..8847005984 100644 > --- a/target/cris/translate.c > +++ b/target/cris/translate.c > @@ -138,7 +138,7 @@ typedef struct DisasContext { > > static void

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

On 26 September 2017 at 03:59, Eduardo Habkost wrote: > On Mon, Sep 25, 2017 at 07:05:26PM +0100, Peter Maydell wrote: >> On 25 September 2017 at 18:59, Eduardo Habkost wrote: >> If we just diff "list of devices marked hotplug before this patch" >>

Re: [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile

On 09/26/2017 10:36 AM, Alex Bennée wrote: The usual behaviour of /etc/profile is to set the default PATH for users. This runs into problems when we have updated PATH in our dockerfile e.g. to access a cross-compiler in a non-standard location. It shouldn't be needed anyway as we inherit the env

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

On 09/26/2017 11:14 AM, Yi Min Zhao wrote: 在 2017/9/25 下午7:47, Christian Borntraeger 写道: On 09/25/2017 01:45 PM, Cornelia Huck wrote: On Mon, 25 Sep 2017 12:12:49 +0200 Christian Borntraeger wrote: On 09/25/2017 12:07 PM, Cornelia Huck wrote: On Fri, 22 Sep 2017

Re: [Qemu-devel] [PATCH 04/43] windbg: added '-windbg' option

On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov wrote: > This option starts windbg server. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov

Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev

On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov wrote: > Added chardev for listening to windbg. Target device is a parameter in the > '-windbg' option. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] SunOS support

Hello Peter Tribble, Please see in-line. On 22.09.2017 14:05, Peter Maydell wrote: > On 20 September 2017 at 19:50, Peter Tribble wrote: >> To introduce myself: I'm a member of the illumos community (the successor >> to OpenSolaris, to those unfamiliar with us), and I

[Qemu-devel] [PATCH] scsi: Ignore executable for in-tree builds

The new qemu-pr-helper (commit b855f8d17) should not be checked in, even when doing in-tree builds. Signed-off-by: Eric Blake --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 40acfcb9e2..3a7e01dc6a 100644 --- a/.gitignore +++

Re: [Qemu-devel] [PATCH] virtio: introduce `info virtio' hmp command

Am 26.09.2017 um 18:13 hat Jan Dakinevich geschrieben: > The command is intended for exposing device specific virtio feature bits > and their negotiation status. It is convenient and useful for debug > purpose. > > Names of features are taken from a devices via get_feature_name() within >

Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false

On 26 September 2017 at 18:03, Alistair Francis wrote: > On Tue, Sep 26, 2017 at 9:52 AM, Thomas Huth wrote: >> On 26.09.2017 18:36, Alistair Francis wrote: >>> On Tue, Sep 26, 2017 at 8:51 AM, Thomas Huth wrote: The device

Re: [Qemu-devel] [PATCH 00/43] Windbg supporting

On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov wrote: > We made the debugger module WinDbg (like GDB) for QEMU. This is the > replacement of the remote stub in Windows kernel. Used for remote Windows > kernel debugging without debugging mode. > > WinDbg is a

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

Emilio G Cota writes: > On Mon, Sep 25, 2017 at 21:03:39 +0300, Lluís Vilanova wrote: >> I know it's not exactly the same we're discussing, but the plot in [1] >> compares >> a few different ways to trace memory accesses on SPEC benchmarks: >> >> * First bar is using a Intel's tool called PIN

Re: [Qemu-devel] [PATCH v1 0/8] Remove some of the fprintf(stderr, "*

On Tue, Sep 26, 2017 at 2:05 AM, Stefan Hajnoczi wrote: > On Mon, Sep 25, 2017 at 05:08:34PM -0700, Alistair Francis wrote: >> >> Continue on improving QEMUs logging/error messages by removing more >> fprintf()'s. >> >> Unfortunatley my Coccinelle skills aren't that great so

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

On 09/26/2017 06:20 PM, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > creating the s390 phb dependant on the zpci facility. This broke > migration from pre-cpu model machines which was fixed with > 8ad9087c4a ("s390x/ccw: create s390 phb for compat reasons

Re: [Qemu-devel] [PATCH 05/43] windbg: added helper features

On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov wrote: > Added some helper features for windbgstub. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov

Re: [Qemu-devel] [PATCH] scsi: Ignore executable for in-tree builds

Reviewed-by: Carlo Marcelo Arenas Belón On Tue, Sep 26, 2017 at 8:14 AM, Eric Blake wrote: > The new qemu-pr-helper (commit b855f8d17) should not be checked in, > even when doing in-tree builds. > > Signed-off-by: Eric Blake > --- >

[Qemu-devel] [PATCH] virtio: introduce `info virtio' hmp command

The command is intended for exposing device specific virtio feature bits and their negotiation status. It is convenient and useful for debug purpose. Names of features are taken from a devices via get_feature_name() within VirtioDeviceClass. If certain device doesn't implement it, the command

Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false

On 26.09.2017 18:36, Alistair Francis wrote: > On Tue, Sep 26, 2017 at 8:51 AM, Thomas Huth wrote: >> The device uses serial_hds in its realize function and thus can't be >> used twice. Apart from that, the comma in its name makes it quite hard >> to use for the user anyway,

Re: [Qemu-devel] [PULL 08/24] iotests: Print full path of bad output if mismatch

Am 26.09.2017 um 16:56 hat Eric Blake geschrieben: > On 09/26/2017 09:21 AM, Kevin Wolf wrote: > > From: Fam Zheng > > > > So it is easier to copy paste the path. > > > > Signed-off-by: Fam Zheng > > Signed-off-by: Kevin Wolf > > --- > >

Re: [Qemu-devel] [RFC 0/6] initial plugin support

On Tue, Sep 26, 2017 at 06:22:31 +0200, Thomas Huth wrote: > Sorry for my ignorance, but if you send a patch series like this, could > you please elaborate a little bit more on the topic what this all is > about? In this cover letter, you basically give only some pointers about > other patch

Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false

On Tue, Sep 26, 2017 at 8:51 AM, Thomas Huth wrote: > The device uses serial_hds in its realize function and thus can't be > used twice. Apart from that, the comma in its name makes it quite hard > to use for the user anyway, since a comma is normally used to separate > the

Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false

On Tue, Sep 26, 2017 at 9:52 AM, Thomas Huth wrote: > On 26.09.2017 18:36, Alistair Francis wrote: >> On Tue, Sep 26, 2017 at 8:51 AM, Thomas Huth wrote: >>> The device uses serial_hds in its realize function and thus can't be >>> used twice. Apart from that,

Re: [Qemu-devel] [PATCH 05/43] windbg: added helper features

On 09/26/2017 12:13 PM, Alistair Francis wrote: >> +#if (WINDBG_DEBUG_ON) >> + >> +# define WINDBG_DEBUG(...) do {\ >> +printf("Debug: " __VA_ARGS__); \ >> +printf("\n"); \ >> +} while (false) >> + >> +# define WINDBG_ERROR(...) do {\ >> +printf("Error: "

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

On 25.09.2017 19:59, Eduardo Habkost wrote: > On Mon, Sep 25, 2017 at 07:42:13PM +0200, Thomas Huth wrote: >> On 25.09.2017 17:26, Peter Maydell wrote: >>> On 25 September 2017 at 16:19, Thomas Huth wrote: Not sure whether this works for the virtio-xxx-device devices,

Re: [Qemu-devel] Support for ARM CP15 registers via GDB interface of qemu

On Fri, Sep 22, 2017 at 8:14 AM, Peter Maydell wrote: > On 22 September 2017 at 16:11, Abhijit Ray Chaudhury > wrote: >> Hi Peter, >> >> Thanks for your prompt response. I have gone through target >> description xml format for gdb >>

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->name

On 26 September 2017 at 11:54, Andrew Jones wrote: > On Fri, Sep 22, 2017 at 08:51:15AM -0500, Wei Huang wrote: >> Instead of using "1.0" as the system version of SMBIOS, we should use >> mc->name for mach-virt machine type. This matches with x86 code and >> prevents the

  1   2   3   4   >