Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

2018-02-13 Thread Laszlo Ersek
On 02/13/18 13:57, Igor Mammedov wrote: > On Mon, 12 Feb 2018 15:17:21 -0500 > Stefan Berger wrote: > >> On 02/12/2018 02:45 PM, Kevin O'Connor wrote: >>> On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: I have played around with this patch and some modifications to EDK2. Tho

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 12:51 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 11:43:55AM +, Dr. David Alan Gilbert wrote: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reit

Re: [Qemu-devel] [PATCH 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-13 Thread Luiz Capitulino
On Tue, 13 Feb 2018 13:30:02 +0100 Viktor Mihajlovski wrote: > On 12.02.2018 19:15, Luiz Capitulino wrote: > > On Mon, 12 Feb 2018 13:14:32 +0100 > > Viktor Mihajlovski wrote: > > > >> -{ 'struct': 'CpuInfoFast', > >> - 'data': {'cpu-index': 'int', 'qom-path': 'str', > >> - 'thread

[Qemu-devel] [PATCH] linux-user: Remove THREAD macro

2018-02-13 Thread Peter Maydell
Back when we used to support compiling either with or without NPTL threading library support, we used a macro THREAD which would expand either to nothing (no thread support) or to __thread (threads supported). For a long time now we have required thread support, so remove the macro and just use __t

[Qemu-devel] [Bug 1392504] Re: libvirt not relabeling devices on USB Passthrough

2018-02-13 Thread Thomas Huth
** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1392504 Title: libvirt not relabeling devices on USB Passthrough Status in libvirt package in Ubuntu: Tria

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 02:20:00PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 12:51 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 13, 2018 at 11:43:55AM +, Dr. David Alan Gilbert wrote: > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange ges

[Qemu-devel] [Bug 1402289] Re: netware 5.1 and SCSI (LSI Logic 53c895a) = lsi_scsi: error: readb 0x49

2018-02-13 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-13 Thread Peter Maydell
A persistent build problem we see is where a source file accidentally omits the #include of log.h. This slips through local developer testing because if you configure with the default (log) trace backend trace.h will pull in log.h for you. Compilation fails only if some other backend is selected.

Re: [Qemu-devel] [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

2018-02-13 Thread Abdallah Bouassida
[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating dynamically an XML-description for these registers. Signed-off-by: Abdallah Bouassida --- Hi Peter, Tha

[Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Thomas Huth
We are currently facing some migration failure on s390x when running certain avocado tests, e.g. when running the test type_specific.io-github-autotest-qemu.migrate.with_reboot.exec.gzip_exec. This test is using 'migrate -d "exec:nc localhost 5200"' for the migration. The problem is detected at the

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

2018-02-13 Thread Igor Mammedov
On Tue, 13 Feb 2018 14:31:41 +0100 Laszlo Ersek wrote: > On 02/13/18 13:57, Igor Mammedov wrote: > > On Mon, 12 Feb 2018 15:17:21 -0500 > > Stefan Berger wrote: > > > >> On 02/12/2018 02:45 PM, Kevin O'Connor wrote: > >>> On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: >

[Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-13 Thread Stefan Hajnoczi
BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop activity while a condition evaluates to true. This is used to implement synchronous operations where it acts as a condvar between the IOThread running the operation and the main loop waiting for the operation. It can also be c

[Qemu-devel] [PATCH v2 4/4] Revert "IDE: Do not flush empty CDROM drives"

2018-02-13 Thread Stefan Hajnoczi
This reverts commit 4da97120d51a4383aa96d741a2b837f8c4bbcd0b. blk_aio_flush() now handles the blk->root == NULL case, so we no longer need this workaround. Cc: John Snow Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- hw/ide/core.c | 10 +- 1 file changed, 1 insertion(+), 9

[Qemu-devel] [PATCH v2 2/4] block: add BlockBackend->in_flight counter

2018-02-13 Thread Stefan Hajnoczi
BlockBackend currently relies on BlockDriverState->in_flight to track requests for blk_drain(). There is a corner case where BlockDriverState->in_flight cannot be used though: blk->root can be NULL when there is no medium. This results in a segfault when the NULL pointer is dereferenced. Introdu

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:14:39PM +0100, Thomas Huth wrote: > We are currently facing some migration failure on s390x when running > certain avocado tests, e.g. when running the test > type_specific.io-github-autotest-qemu.migrate.with_reboot.exec.gzip_exec. > This test is using 'migrate -d "exec:

[Qemu-devel] [PATCH v2 0/4] block: fix blk_aio_*() segfault when blk->root == NULL

2018-02-13 Thread Stefan Hajnoczi
v2: * Introduce AIO_WAIT_WHILE() since aio_poll(ctx, true) is not allowed [Paolo] Using bdrv_inc_in_flight(blk_bs(blk)) doesn't work since BlockBackend->root may be NULL. This patch series solves the issue by adding an BlockBackend->in_flight counter so requests can be tracked even when there is

[Qemu-devel] [PATCH v2 3/4] block: test blk_aio_flush() with blk->root == NULL

2018-02-13 Thread Stefan Hajnoczi
From: Kevin Wolf This patch adds test cases for the scenario where blk_aio_flush() is called on a BlockBackend with no root. Calling drain afterwards should complete the requests with -ENOMEDIUM. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- tests/Make

Re: [Qemu-devel] [PATCH] vnc: add qapi/error.h include to stubs

2018-02-13 Thread Eric Blake
On 02/13/2018 01:05 AM, Gerd Hoffmann wrote: Fixes --disable-vnc build failure. Signed-off-by: Gerd Hoffmann --- ui/vnc-stubs.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake diff --git a/ui/vnc-stubs.c b/ui/vnc-stubs.c index f51280549a..06c4ac6296 100644 --- a/ui/vnc-st

Re: [Qemu-devel] [PATCH v2 03/32] target/arm/cpu64: allow fp16 to be disabled

2018-02-13 Thread Peter Maydell
On 8 February 2018 at 17:31, Alex Bennée wrote: > While for CONFIG_USER_ONLY it is policy for the "cpu" to be the most > capable is can be this does cause problems. For example legacy RISU > runs would fail as there are a bunch of implemented instructions which > would have caused failures that no

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-13 Thread Peter Maydell
On 8 February 2018 at 17:31, Alex Bennée wrote: > Hi, > > Some of this was posted before as part of the various partial patch > series when we first started messing around with FP16 in softfloat. > This series is now just the ARM bits and expects to have the V4 > softfloat patches as a prerequisit

Re: [Qemu-devel] [PATCH v4] tests/migration: Add source to PC boot block

2018-02-13 Thread Eric Blake
On 02/13/2018 04:06 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The boot block used in the migration test is currently only shipped as a hex (with the source in the git commit message of ea0c6d62), change this to actually include the source. A script is added to rebu

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > Then you could just use the regular migrate QMP commands for loading > > > and saving snapshots. > > > > Y

Re: [Qemu-devel] [PULL 00/48] Misc patches for 2018-02-13

2018-02-13 Thread Peter Maydell
On 13 February 2018 at 12:00, Paolo Bonzini wrote: > The following changes since commit 7d848450b6e2a3e14a776b4c93704710e7f3d233: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180212' > into staging (2018-02-12 14:52:48 +) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH v4 24/39] qcow2: Update discard_single_l2() to support L2 slices

2018-02-13 Thread Eric Blake
On 02/05/2018 08:33 AM, Alberto Garcia wrote: discard_single_l2() limits the number of clusters to be discarded to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. The function is renamed to discard_in_l2_slice() for cl

Re: [Qemu-devel] [PATCH v4 25/39] qcow2: Update zero_single_l2() to support L2 slices

2018-02-13 Thread Eric Blake
On 02/05/2018 08:33 AM, Alberto Garcia wrote: zero_single_l2() limits the number of clusters to be zeroed to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. The function is renamed to zero_in_l2_slice() for clarity. A

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > Then you could just use the regular migrate QMP commands for loading > > > and saving snapshots. > > > > Yes, you c

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > > Then you could just use the regular migr

Re: [Qemu-devel] [PATCH V10 8/9] hw/rdma: Implementation of PVRDMA device

2018-02-13 Thread Yanjun Zhu
On 2018/2/13 2:08, Marcel Apfelbaum wrote: From: Yuval Shaia PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. It works with its Linux Kernel driver AS IS, no need for any special guest modifications. While it complies with the VMware device, it can also communicate

Re: [Qemu-devel] [PATCH V10 4/9] hw/rdma: Add wrappers and macros

2018-02-13 Thread Yanjun Zhu
On 2018/2/13 2:08, Marcel Apfelbaum wrote: From: Yuval Shaia As all mapping for this device are from driver to device, declare wrappers on top of pci_dma_*map functions. In addition, declare macros to be used for debug messages. Reviewed-by: Dotan Barak Signed-off-by: Yuval Shaia Signed-o

Re: [Qemu-devel] [PATCH V10 5/9] hw/rdma: Definitions for rdma device and rdma resource manager

2018-02-13 Thread Yanjun Zhu
On 2018/2/13 2:08, Marcel Apfelbaum wrote: From: Yuval Shaia Definition of various structures and constants used in backend and resource manager modules. Reviewed-by: Dotan Barak Signed-off-by: Yuval Shaia Signed-off-by: Marcel Apfelbaum Reviewed-by: Zhu Yanjun Zhu Yanjun --- hw/rdm

Re: [Qemu-devel] [PATCH V10 7/9] hw/rdma: PVRDMA commands and data-path ops

2018-02-13 Thread Yanjun Zhu
On 2018/2/13 2:08, Marcel Apfelbaum wrote: From: Yuval Shaia First PVRDMA sub-module - implementation of the PVRDMA device. - PVRDMA commands such as create CQ and create MR. - Data path QP operations - post_send and post_recv. - Completion handler. Reviewed-by: Dotan Barak Signed-off-by: Y

[Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-complete functionality

2018-02-13 Thread Dimitris Karagkasidis
The QEMU monitor enters an infinite loop when trying to auto-complete commands that accept only optional parameters. The commands currently affected by this issue are 'info registers' and 'info mtree'. Signed-off-by: Dimitris Karagkasidis --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH V10 6/9] hw/rdma: Implementation of generic rdma device layers

2018-02-13 Thread Yanjun Zhu
On 2018/2/13 2:08, Marcel Apfelbaum wrote: From: Yuval Shaia This layer is composed of two sub-modules, backend and resource manager. Backend sub-module is responsible for all the interaction with IB layers such as ibverbs and umad (external libraries). Resource manager is a collection of fun

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > > Am 11.01.2018 um 14:04 hat Daniel P. Be

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 05:48 PM, Daniel P. Berrangé wrote: > On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: >> Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: >>> On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wr

Re: [Qemu-devel] [PATCH v4 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-02-13 Thread Eric Blake
On 02/05/2018 08:33 AM, Alberto Garcia wrote: qcow2_update_snapshot_refcount() increases the refcount of all clusters of a given snapshot. In order to do that it needs to load all its L2 tables and iterate over their entries. Since we'll be loading L2 slices instead of full tables we need to add

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 05:43 PM, Kevin Wolf wrote: > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: >> On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: >>> Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: Then you could just use the regular migrate QMP commands for loading >>>

Re: [Qemu-devel] [PATCH v4 00/39] Allow configuring the qcow2 L2 cache entry size

2018-02-13 Thread Max Reitz
On 2018-02-05 15:33, Alberto Garcia wrote: > this is the new revision of the patch series to allow configuring the > entry size of the qcow2 L2 cache. Follow this link for the full > description from the first version: > >https://lists.gnu.org/archive/html/qemu-block/2017-10/msg00458.html > >

Re: [Qemu-devel] [PATCH v4 31/39] qcow2: Update qcow2_truncate() to support L2 slices

2018-02-13 Thread Eric Blake
On 02/05/2018 08:33 AM, Alberto Garcia wrote: The qcow2_truncate() code is mostly independent from whether we're using L2 slices or full L2 tables, but in full and falloc preallocation modes new L2 tables are allocated using qcow2_alloc_cluster_link_l2(). Therefore the code needs to be modified

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:47, Alex Bennée wrote: > Hi, > > The main change is applying the __attribute__((flatten)) to some of > the public functions that show up in Emilio's dbt-benchmark. This > seems to be a cleaner solution that squashing inlines higher up the > chain and still leaves the chanc

Re: [Qemu-devel] [PATCH 1/7] gluster: Move glfs_close() to create's clean-up

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: glfs_close() is a classical clean-up operation, as can be seen by the fact that it is executed even if the truncation before it failed. Also, moving it to clean-up makes it more clear that if it fails, we do not want it to overwrite the current ret value i

Re: [Qemu-devel] [PATCH 3/7] gluster: Query current size in do_truncate()

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: Instead of expecting the current size to be 0, query it and allocate only the area [current_size, offset) if preallocation is requested. Signed-off-by: Max Reitz --- block/gluster.c | 21 +++-- 1 file changed, 19 insertions(+), 2 delet

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: > > Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > > > On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin W

Re: [Qemu-devel] [PATCH 2/7] gluster: Pull truncation from qemu_gluster_create

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: Pull out the truncation code from the qemu_cluster_create() function so we can later reuse it in qemu_gluster_truncate(). Signed-off-by: Max Reitz --- block/gluster.c | 74 +++-- 1 file changed, 40 i

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > > Then you could just use the regular migrate QMP

Re: [Qemu-devel] [PATCH 4/7] gluster: Add preallocated truncation

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: By using qemu_do_cluster_truncate() in qemu_cluster_truncate(), we now automatically have preallocated truncation. Signed-off-by: Max Reitz --- block/gluster.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) Reviewed-by: Eri

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: >>> Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: >

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > We are currently facing some migration failure on s390x when running > certain avocado tests, e.g. when running the test > type_specific.io-github-autotest-qemu.migrate.with_reboot.exec.gzip_exec. > This test is using 'migrate -d "exec:nc localhost 5200"' f

Re: [Qemu-devel] [PATCH 6/7] sheepdog: Pass old and new size to sd_prealloc()

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: sd_prealloc() will now preallocate the area [old_size, new_size). As before, it rounds to buf_size and may thus overshoot and preallocate areas that were not requested to be preallocated. For image creation, this is no change in behavior. For truncation

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@virtuozzo.com) wrote: > On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >> On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: > >>> Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > On Tue,

Re: [Qemu-devel] [PATCH 5/7] sheepdog: Make sd_prealloc() take a BDS

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: We want to use this function in sd_truncate() later on, so taking a filename is not exactly ideal. Signed-off-by: Max Reitz --- block/sheepdog.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) @@ -1837,10 +1837

Re: [Qemu-devel] [PATCH 7/7] sheepdog: Allow fully preallocated truncation

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- block/sheepdog.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.or

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/3] qmp: expose s390-specific CPU info

2018-02-13 Thread Eric Blake
On 02/13/2018 06:20 AM, Viktor Mihajlovski wrote: We're adding the same information to query-cpus-fast. Why do we need to duplicate this into query-cpus? Do you plan to keep using query-cpus? If yes, why? Wonder if we could simply pass a flag to query-cpus "fast=true", that makes it behave diff

Re: [Qemu-devel] [PULL 00/48] Misc patches for 2018-02-13

2018-02-13 Thread Paolo Bonzini
On 13/02/2018 15:37, Peter Maydell wrote: > Hi. This fails tests on Linux/ppc64, Linux/s390x > and Linux/sparc: > > TEST: tests/sdhci-test... (pid=63141) > /x86_64/sdhci/pc:** > ERROR:/home/pm215/qemu/tests/sdhci-test.c:118:check_specs_version:

Re: [Qemu-devel] [PATCH 0/7] block: Preallocated truncation for gluster and sheepdog

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 14:03 hat Max Reitz geschrieben: > As far as I can see, these are the only protocols beside file-posix that > support preallocated creation. In contrast to file-posix, however, they > have not supported preallocated truncation so far. This series brings > their truncation code to

Re: [Qemu-devel] [PATCH] linux-user: Remove THREAD macro

2018-02-13 Thread Laurent Vivier
Le 13/02/2018 à 14:22, Peter Maydell a écrit : > Back when we used to support compiling either with or without > NPTL threading library support, we used a macro THREAD which would > expand either to nothing (no thread support) or to __thread (threads > supported). For a long time now we have requir

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:09:12PM +, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: > > We are currently facing some migration failure on s390x when running > > certain avocado tests, e.g. when running the test > > type_specific.io-github-autotest-qemu.migrate.with_reb

Re: [Qemu-devel] [PATCH v4 16/22] fpu/softfloat: re-factor round_to_int

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:48, Alex Bennée wrote: > We can now add float16_round_to_int and use the common round_decomposed and > canonicalize functions to have a single implementation for > float16/32/64 round_to_int functions. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson > >

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-13 Thread Eric Blake
On 02/13/2018 08:00 AM, Peter Maydell wrote: A persistent build problem we see is where a source file accidentally omits the #include of log.h. This slips through local developer testing because if you configure with the default (log) trace backend trace.h will pull in log.h for you. Compilation

Re: [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-13 Thread Viktor Mihajlovski
On 12.02.2018 17:50, Dr. David Alan Gilbert wrote: [...] >> diff --git a/hmp.c b/hmp.c >> index a6b94b7..598bfe5 100644 >> --- a/hmp.c >> +++ b/hmp.c >> @@ -410,6 +410,27 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict) >> qapi_free_CpuInfoList(cpu_list); >> } >> >> +void hmp_info_cp

Re: [Qemu-devel] [PATCH v2 14/20] fpu/softfloat: re-factor muladd

2018-02-13 Thread Peter Maydell
On 9 January 2018 at 12:22, Alex Bennée wrote: > We can now add float16_muladd and use the common decompose and > canonicalize functions to have a single implementation for > float16/32/64 muladd functions. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter May

Re: [Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:48, Alex Bennée wrote: > We can now add float16_mul and use the common decompose and > canonicalize functions to have a single implementation for > float16/32/64 versions. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson > > --- > v3 > +/* > + * Returns

Re: [Qemu-devel] [PATCH v2 10/29] qapi: Touch generated files only when they change

2018-02-13 Thread Marc-Andre Lureau
Hi On Mon, Feb 12, 2018 at 8:48 PM, Eric Blake wrote: > On 02/11/2018 03:35 AM, Markus Armbruster wrote: >> >> A massive number of objects depends on QAPI-generated headers. In my >> "build everything" tree, it's roughly 4800 out of 5100. This is >> particularly annoying when only some of the g

Re: [Qemu-devel] [PATCH] linux-user: Use *at functions to implement interp_prefix

2018-02-13 Thread Richard Henderson
On 02/13/2018 04:12 AM, Peter Maydell wrote: >> +const char *linux_user_path(const char *pathname) >> +{ >> +static THREAD size_t save_len; >> +static THREAD char *save_buf; > > I think THREAD is a remnant of when we used to support configuration > with and without NPTL, so we should be lo

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 15:58 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange ge

Re: [Qemu-devel] [PATCH v4 14/22] fpu/softfloat: re-factor div

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:48, Alex Bennée wrote: > We can now add float16_div and use the common decompose and > canonicalize functions to have a single implementation for > float16/32/64 versions. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson > +static FloatParts div_floats(

Re: [Qemu-devel] [PATCH v2 09/29] qapi-gen: Convert from getopt to argparse

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > argparse is nicer to use than getopt, and gives us --help almost for > free. > > Signed-off-by: Markus Armbruster nice, Reviewed-by: Marc-André Lureau > --- > scripts/qapi-gen.py| 48 ++--

Re: [Qemu-devel] [PATCH] linux-user: Remove THREAD macro

2018-02-13 Thread Richard Henderson
On 02/13/2018 05:22 AM, Peter Maydell wrote: > Back when we used to support compiling either with or without > NPTL threading library support, we used a macro THREAD which would > expand either to nothing (no thread support) or to __thread (threads > supported). For a long time now we have required

Re: [Qemu-devel] [PATCH v2 01/29] Include qapi/qmp/qerror.h exactly where needed

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > block.c | 1 - > block/qcow2.c | 1 - > chardev/char-fe.c | 1 + > chardev/char.c | 1 + > qom/object_interfaces.c | 1

Re: [Qemu-devel] [PATCH v2 19/29] qapi: Make code-generating visitors use QAPIGen more

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > The use of QAPIGen is rather shallow so far: most of the output > accumulation is not converted. Take the next step: convert output > accumulation in the code-generating visitor classes. Helper functions > outside these classes are not

Re: [Qemu-devel] [PATCH v2 18/29] qapi: Rename generated qmp-marshal.c to qmp-commands.c

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > All generated .c are named like their .h, except for qmp-marshal.c and > qmp-commands.h. To add to the confusion, tests-qmp-commands.c falsely > matches generated test-qmp-commands.h. > > Get rid of this unnecessary complication. > > Si

Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support

2018-02-13 Thread Brijesh Singh
On Mon, Feb 12, 2018 at 3:19 PM, Borislav Petkov wrote: > On Mon, Feb 12, 2018 at 03:07:26PM -0600, Brijesh Singh wrote: > > In current implementation, when -cpu ...,+sev is passed without > > appropriate SEV configuration then we populate the Fn8000_001F CPUID but > > VMCB will not have SEV bit

Re: [Qemu-devel] [PATCH v2 04/29] qapi: Rename variable holding the QAPISchemaGenFOOVisitor

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > Rename the variable holding the QAPISchemaGenFOOVisitor from gen to > vis, to avoid confusion in the next commit. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi-commands.py | 8 >

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 13, 2018 at 03:09:12PM +, Dr. David Alan Gilbert wrote: > > * Thomas Huth (th...@redhat.com) wrote: > > > We are currently facing some migration failure on s390x when running > > > certain avocado tests, e.g. when running the test

Re: [Qemu-devel] [PATCH v2 20/29] qapi/types qapi/visit: Generate built-in stuff into separate files

2018-02-13 Thread Marc-Andre Lureau
Hi On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > Linking code from multiple separate QAPI schemata into the same > program is possible, but involves some weirdness around built-in > types: > > * We generate code for built-in types into .c only with option > --builtins. The user

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:41:45PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, Feb 13, 2018 at 03:25:30PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Tue, Feb 13, 2018 at 03:09:12PM

Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support

2018-02-13 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.ksi...@gmail.com) wrote: > On Mon, Feb 12, 2018 at 3:19 PM, Borislav Petkov wrote: > > > On Mon, Feb 12, 2018 at 03:07:26PM -0600, Brijesh Singh wrote: > > > In current implementation, when -cpu ...,+sev is passed without > > > appropriate SEV configuration then we popula

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Roman Kagan (rka...@virtuozzo.com) wrote: > On Tue, Feb 13, 2018 at 03:05:03PM +, Dr. David Alan Gilbert wrote: > > * Denis V. Lunev (d...@virtuozzo.com) wrote: > > > On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > >> That

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 04:23:21PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 15:58 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > > > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 13, 2018 at 03:41:45PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Tue, Feb 13, 2018 at 03:25:30PM +, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redh

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:25:30PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, Feb 13, 2018 at 03:09:12PM +, Dr. David Alan Gilbert wrote: > > > * Thomas Huth (th...@redhat.com) wrote: > > > > We are currently facing some migration failur

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 16:30 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 04:23:21PM +0100, Kevin Wolf wrote: > > Am 13.02.2018 um 15:58 hat Daniel P. Berrangé geschrieben: > > > On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > > > > Am 13.02.2018 um 15:30 hat Roman Kagan ge

Re: [Qemu-devel] [PATCH v4 22/22] fpu/softfloat: re-factor sqrt

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:48, Alex Bennée wrote: > This is a little bit of a departure from softfloat's original approach > as we skip the estimate step in favour of a straight iteration. > > Suggested-by: Richard Henderson > Signed-off-by: Alex Bennée > > --- > v3 > - added to series > - fix

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

2018-02-13 Thread Laszlo Ersek
On 02/13/18 15:17, Igor Mammedov wrote: > On Tue, 13 Feb 2018 14:31:41 +0100 > Laszlo Ersek wrote: > >> On 02/13/18 13:57, Igor Mammedov wrote: >>> On Mon, 12 Feb 2018 15:17:21 -0500 >>> Stefan Berger wrote: >>> On 02/12/2018 02:45 PM, Kevin O'Connor wrote: > On Fri, Feb 09, 2018 a

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 06:27 PM, Dr. David Alan Gilbert wrote: > * Roman Kagan (rka...@virtuozzo.com) wrote: >> On Tue, Feb 13, 2018 at 03:05:03PM +, Dr. David Alan Gilbert wrote: >>> * Denis V. Lunev (d...@virtuozzo.com) wrote: On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > * Daniel P

Re: [Qemu-devel] [PATCH v2 23/29] Include less of the generated modular QAPI headers

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > In my "build everything" tree, a change to the types in > qapi-schema.json triggers a recompile of about 4800 out of 5100 > objects. > > The previous commit split up qmp-commands.h, qmp-event.h, qmp-visit.h, > qapi-types.h. Each of thes

Re: [Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-13 Thread Richard Henderson
On 02/13/2018 07:20 AM, Peter Maydell wrote: >> +static FloatParts mul_floats(FloatParts a, FloatParts b, float_status *s) >> +{ >> +bool sign = a.sign ^ b.sign; >> + >> +if (a.cls == float_class_normal && b.cls == float_class_normal) { >> +uint64_t hi, lo; >> +int exp = a.e

[Qemu-devel] [Bug 1749223] [NEW] mouse offset or invisible wall 2.11.0-3

2018-02-13 Thread zlice
Public bug reported: (There was another post, I'm not sure if it is related though. Also not sure if it's Arch related, I wouldn't be surprised as I normally use Gentoo and have less problems with Gentoo.) qemu-system-x86_64 -enable-kvm -M q35 -cpu host -m 8192 -vga vmware -smp 4,sockets=1,core

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 13, 2018 at 03:25:30PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Tue, Feb 13, 2018 at 03:09:12PM +, Dr. David Alan Gilbert wrote: > > > > * Thomas Huth (th...@redhat.com) wr

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:47, Alex Bennée wrote: > Hi, > > The main change is applying the __attribute__((flatten)) to some of > the public functions that show up in Emilio's dbt-benchmark. This > seems to be a cleaner solution that squashing inlines higher up the > chain and still leaves the chanc

Re: [Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-13 Thread Eric Blake
On 02/13/2018 08:20 AM, Stefan Hajnoczi wrote: BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop activity while a condition evaluates to true. This is used to implement synchronous operations where it acts as a condvar between the IOThread running the operation and the main

Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support

2018-02-13 Thread Borislav Petkov
On Tue, Feb 13, 2018 at 09:39:01AM -0600, Brijesh Singh wrote: > Yes, I think we should be able to avoid creating new CPU model to > handle this case. I am leaning towards dropping this patch and > implement logic to populate the CPUID 0x8000_001F only when SEV is > enabled. This should not require

Re: [Qemu-devel] [PATCH v2 26/29] docs: Correct outdated information on QAPI

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > * Fix guidance on error classes > > * Point to generated documentation > > * Drop plea for documentation, because the QAPI code generator > enforces it since commit 3313b6124b > > * Minor tweaks here and there > > Signed-off-by: Markus

[Qemu-devel] [PULL v2 00/48] Miscellaneous patches for 2017-02-13

2018-02-13 Thread Paolo Bonzini
The following changes since commit 7d848450b6e2a3e14a776b4c93704710e7f3d233: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180212' into staging (2018-02-12 14:52:48 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

Re: [Qemu-devel] [PATCH v2 27/29] qapi: Move qapi-schema.json to qapi/, rename generated files

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > Move qapi-schema.json to qapi/, so it's next to its modules, and all > files get generated to qapi/, not just the ones generated for modules. > > Consistently name the generated files qapi-MODULE.EXT: > qmp-commands.[ch] become qapi-comm

Re: [Qemu-devel] [PATCH] io/channel-command: Delay the killing of the child after closing the pipe

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:49:42PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, Feb 13, 2018 at 03:41:45PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Tue, Feb 13, 2018 at 03:25:30PM

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis Plotnikov
On 13.02.2018 18:05, Dr. David Alan Gilbert wrote: * Denis V. Lunev (d...@virtuozzo.com) wrote: On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: * Daniel P. Berrangé (berra...@redhat.com) wrote: On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: Am 13.02.2018 um 15:36 hat Dani

Re: [Qemu-devel] [PATCH v2 28/29] Fix up dangling references to qmp-commands.* in comment and doc

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit > 5032a16d1d. > > Fix up the reference to qmp-commands.txt in > docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa. > > Signed-off-by: Markus Armbruster > --

Re: [Qemu-devel] [PATCH v2 25/29] docs/devel/writing-qmp-commands: Update for modular QAPI

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > With modular code generation, putting stuff right into > qapi-schema.json is a bad idea. Update writing-qmp-commands.txt > accordingly. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > docs/devel/writing

Re: [Qemu-devel] [PATCH v2 29/29] qapi: Don't create useless directory qapi-generated

2018-02-13 Thread Marc-Andre Lureau
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > We used to generate first test and later QGA QAPI code into > qapi-generated/. Commit b93b63f574 moved the test code to tests/. > Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The > directory has been unused since. > > S

<    1   2   3   4   5   >