[Qemu-devel] [PATCH 0/3] target/ppc: convert to generic translation loop

After converting riscv to the translation loop, I'm trying to keep the momentum going. Hopefully this will lead to quite a few more targets being converted. The appended converts the ppc target to TranslatorOps. I have tested it by booting ubuntu on a ppc64 guest. Please review! Thanks,

[Qemu-devel] [PATCH 1/3] translator: add retcode to translator_loop_temp_check

This will allow us to print further info from target code. Signed-off-by: Emilio G. Cota --- accel/tcg/translator.c| 4 +++- include/exec/translator.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index

[Qemu-devel] [PATCH 26/30] hw/smbios: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 27a07e96f4..fa02f9ce3f 100644 ---

[Qemu-devel] [PATCH 23/30] hw/net: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/allwinner_emac.h | 4 ++-- hw/net/e1000e.c | 6 +++--- hw/net/eepro100.c | 6 ++ 3 files changed, 7 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 05/30] hw/mips/r4k: constify params_size

On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_r4k.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c > index 830ee7732c..5a74c44b9a 100644 >

[Qemu-devel] [PATCH 00/30] hw: use the BYTE-based definitions when useful

Hi, This series: - split the byte-based definitions from "qemu/cutils.h" to "qemu/cunits.h" and let them available for all hw/ files (via "hw/hw.h"); - clean hw/ includes; - replace different constants used for byte size with their corresponding BYTE-based definitions. patches generated

[Qemu-devel] [PATCH 15/30] hw/lm32: use the BYTE-based definitions

It ease code review, unit is explicit. --- hw/lm32/lm32_boards.c | 12 ++-- hw/lm32/milkymist.c | 8 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index 527bcc229c..15315101be 100644 --- a/hw/lm32/lm32_boards.c

[Qemu-devel] [PATCH 22/30] hw/display: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 9 - hw/display/g364fb.c | 2 +- hw/display/qxl.c| 26 +++--- hw/display/vga-isa-mm.c | 4 ++-- hw/display/vga.c| 4

[Qemu-devel] [PATCH 29/30] tpm: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/acpi/tpm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h index 96fd3a92f7..751567a73a 100644 ---

[Qemu-devel] [PATCH 17/30] hw/tricore: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/tricore/tricore_testboard.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c index

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

On 14.02.2018 21:23, Eric Blake wrote: > On 02/14/2018 11:31 AM, Thomas Huth wrote: >> When running configure with --with-pkgversion=foo there is no >> space anymore between the version number and the parentheses: >> >> $ m68k-softmmu/qemu-system-m68k -version >> QEMU emulator version 2.11.50(foo)

Re: [Qemu-devel] [PATCH 04/30] hw/lm32/milkymist: remove unused include

On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/milkymist.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c > index 471a74eaa1..c28379399f 100644 > ---

[Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase

A couple of notes: - removed ctx->nip in favour of base->pc_next. Yes, it is annoying, but didn't want to waste its 4 bytes. - ctx->singlestep_enabled does a lot more than base.singlestep_enabled; this confused me at first. Signed-off-by: Emilio G. Cota ---

Re: [Qemu-devel] [PATCH 5/5] spapr: drop DIV_ROUND_UP() from xics_max_server_number()

On Wed, Feb 14, 2018 at 08:41:03PM +0100, Greg Kurz wrote: > XICS needs to know the highest VCPU id that may be presented to the > guest plus 1. Commit f303f117fec3 "spapr: ensure we have at least one > XICS server" changed how the maximum is computed from: > > smp_cpus *

Re: [Qemu-devel] [PATCH 4/5] spapr: consolidate the VCPU id numbering logic in a single place

On Wed, Feb 14, 2018 at 08:40:53PM +0100, Greg Kurz wrote: > Several places in the code need to calculate a VCPU id: > > (cpu_index / smp_threads) * spapr->vsmt + cpu_index % smp_threads > (core_id / smp_threads) * spapr->vsmt (1 user) > index * spapr->vsmt (2 users) > > or guess

[Qemu-devel] [PATCH 07/30] hw/arm: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/stm32f205_soc.h | 4 ++-- hw/arm/boot.c | 6 +++--- hw/arm/collie.c| 4 ++-- hw/arm/digic_boards.c | 6 +++--- hw/arm/gumstix.c

[Qemu-devel] [PATCH 14/30] hw/alpha: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/typhoon.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 6a40869488..0acfb4b1d0 100644 ---

[Qemu-devel] [PATCH 11/30] hw/s390x: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/sclp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 276972b59f..8537aa2688 100644 --- a/hw/s390x/sclp.c +++

[Qemu-devel] [PATCH 20/30] hw/cris: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/cris/axis_dev88.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index 9ccc4350a5..1dea3c594c 100644 --- a/hw/cris/axis_dev88.c

[Qemu-devel] [PATCH 27/30] vfio/pci: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/pci-quirks.c | 8 hw/vfio/pci.c| 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index

Re: [Qemu-devel] [PATCH v4] hw/char: remove legacy interface escc_init()

On Wed, Feb 14, 2018 at 07:35:58AM +0100, Laurent Vivier wrote: > Move necessary stuff in escc.h and update type names. > Remove slavio_serial_ms_kbd_init(). > Fix code style problems reported by checkpatch.pl > Update mac_newworld, mac_oldworld and sun4m to use directly the > QDEV interface. > >

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 1/3] ppc/spapr-caps: Change migration macro to take full spapr-cap name

On Thu, Feb 15, 2018 at 11:44:41AM +1100, Suraj Jitindar Singh wrote: > Change the macro that generates the vmstate migration field and the needed > function for the spapr-caps to take the full spapr-cap name. This has > the benefit of meaning this instance will be picked up when greping > for the

[Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ich9.h | 2 +- hw/i386/acpi-build.c | 4 ++-- hw/i386/pc.c | 18 +- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +-

[Qemu-devel] [PATCH 13/30] hw/xtensa: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 70686a2eb1..922417af15 100644 --- a/hw/xtensa/xtfpga.c +++

[Qemu-devel] [PATCH 24/30] hw/ipack: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/ipack/tpci200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c index da05c8589d..56c0ad8932 100644 --- a/hw/ipack/tpci200.c +++

[Qemu-devel] [PATCH 12/30] hw/hppa: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c| 2 +- hw/hppa/machine.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 15aefde09c..7728123cc8 100644 ---

[Qemu-devel] [PATCH 18/30] hw/microblaze: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/microblaze/petalogix_ml605_mmu.c | 6 +++--- hw/microblaze/petalogix_s3adsp1800_mmu.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 19/30] hw/nios2: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/nios2/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c index 771e00267b..911f28c0d8 100644 --- a/hw/nios2/boot.c +++ b/hw/nios2/boot.c

[Qemu-devel] ERROR:qom/object.c:907:object_unref: assertion failed (obj->ref > 0): (0 > 0)

I get the error mentioined in the subject line when using vncviewer with commit 13e1d0e71e78a925848258391a6e616b6b5ae219: Author: Daniel P. Berrange Date: Thu Feb 1 16:45:14 2018 + ui: convert VNC server to QIONetListener The VNC server already has the

[Qemu-devel] [PATCH] target/hppa: use tb_cflags() to access tb->cflags

Signed-off-by: Emilio G. Cota --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6499b39..b4b74a8 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -2075,7

Re: [Qemu-devel] [PATCH 10/30] hw/ppc: use the BYTE-based definitions

On Thu, Feb 15, 2018 at 01:28:40AM -0300, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > include/hw/ppc/spapr.h | 2 +- > hw/pci-host/prep.c |

[Qemu-devel] [PATCH V3 2/2] tests: Add migration test for aarch64

This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86

Re: [Qemu-devel] [PATCH 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file

On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > where it is used. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.h | 1 - > hw/block/nvme.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.h b/hw/block/nvme.h > index

[Qemu-devel] [PATCH V3 0/2] tests: Add migration test for aarch64

This is a new version of migration-test for aarch64. This version needs to be applied on top of Dave Gilbert's recent patch "[v4] tests/migration: Add source to PC boot block". V2->V3: * Convert build script to Makefile * Add cross-compilation support * Fix CPU type for "tcg" machine type *

[Qemu-devel] [PATCH V3 1/2] tests/migration: Convert the boot block compilation script into Makefile

The x86 boot block header currently is generated with a shell script. To better support other CPUs (e.g. aarch64), we convert the script into Makefile. This allows us to 1) support cross-compilation easily; 2) avoid creating a script file for every architecture. Signed-off-by: Wei Huang

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

On 15.02.2018 07:38, Thomas Huth wrote: > On 14.02.2018 18:46, Collin L. Walling wrote: >> I'm beginning to like the usage of splash-time to represent a timeout >> for the boot menu >> less and less.  It is really meant for how long a _splash_ _image_ >> should appear during boot. >> >> I'd like

[Qemu-devel] [PATCH] nbd: Honor server's advertised minimum block size

Commit 79ba8c98 (v2.7) changed the setting of request_alignment to occur only during bdrv_refresh_limits(), rather than at at bdrv_open() time; but at the time, NBD was unaffected, because it still used sector-based callbacks, so the block layer defaulted NBD to use 512 request_alignment. Later,

[Qemu-devel] [PATCH 10/30] hw/ppc: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/spapr.h | 2 +- hw/pci-host/prep.c | 2 +- hw/ppc/e500.c | 8 hw/ppc/mac_oldworld.c | 7 +++ hw/ppc/ppc405_boards.c | 8 hw/ppc/ppc405_uc.c

[Qemu-devel] [PATCH 16/30] hw/sh4: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/tc58128.c | 2 +- hw/sh4/r2d.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index 1d9f7ee000..3e658d509f 100644 ---

Re: [Qemu-devel] [qemu-s390x] [PATCH 11/30] hw/s390x: use the BYTE-based definitions

On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/s390x/sclp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index

Re: [Qemu-devel] [PATCH 1/5] spapr: use spapr->vsmt to compute VCPU ids

On Wed, Feb 14, 2018 at 08:40:26PM +0100, Greg Kurz wrote: > Since the introduction of VSMT in 2.11, the spacing of VCPU ids > between cores is controllable through a machine property instead > of being only dictated by the SMT mode of the host: > > cpu->vcpu_id = (cc->core_id * spapr->vsmt /

Re: [Qemu-devel] [PATCH 3/5] spapr: rename spapr_vcpu_id() to spapr_get_vcpu_id()

On Wed, Feb 14, 2018 at 08:40:44PM +0100, Greg Kurz wrote: > The spapr_vcpu_id() function is an accessor actually. Let's rename it > for symmetry with the recently added spapr_set_vcpu_id() helper. > > The motivation behind this is that a later patch will consolidate > the VCPU id formula in a

[Qemu-devel] [PATCH 09/30] hw/sparc: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 8 hw/sparc/sun4m.c | 7 +++ hw/sparc64/niagara.c | 2 +- hw/sparc64/sun4u.c | 2 +- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 25/30] hw/scsi: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 49d2559d93..bfdb34a71c 100644 ---

[Qemu-devel] [PATCH 21/30] hw/misc: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/auxbus.c | 2 +- hw/misc/edu.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index b4cacd664b..c78aaebcbe 100644 ---

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

On 14.02.2018 16:33, Collin L. Walling wrote: > On 02/14/2018 05:57 AM, David Hildenbrand wrote: [...] >> 1. CKC interrupts can be cleared by resetting the CKC >> 2. SCLP interrupts can be cleared only via delivery (apart from CPU >> reset) >> >> So if you have CKC and SCLP pending at the same

[Qemu-devel] [PATCH 04/30] hw/lm32/milkymist: remove unused include

Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 471a74eaa1..c28379399f 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -30,7 +30,6 @@ #include

[Qemu-devel] [PATCH 06/30] hw/mips: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/mips_gic.h | 2 +- include/hw/mips/bios.h | 2 +- hw/mips/boston.c | 2 +- hw/mips/mips_fulong2e.c| 6 +++--- hw/mips/mips_malta.c | 19

[Qemu-devel] [PATCH 05/30] hw/mips/r4k: constify params_size

Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_r4k.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index 830ee7732c..5a74c44b9a 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -79,8 +79,9 @@

[Qemu-devel] [PATCH 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h"

(added in 076b35b5a56) Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cunits.h | 11 +++ include/qemu/cutils.h | 8 +--- 2 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 include/qemu/cunits.h diff --git a/include/qemu/cunits.h

[Qemu-devel] [PATCH 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"

These files were including "qemu/cutils.h" to use the byte-based size definitions, now available in "qemu/cunits.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/hw.h | 1 + hw/arm/msf2-soc.c | 1 - hw/arm/msf2-som.c | 1 - hw/core/loader-fit.c | 1 -

[Qemu-devel] [PATCH 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file

where it is used. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.h | 1 - hw/block/nvme.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.h b/hw/block/nvme.h index 8f3981121d..cabcf20c32 100644 --- a/hw/block/nvme.h +++

[Qemu-devel] [PATCH 30/30] xen: use the BYTE-based definitions

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/xen_disk.c| 4 ++-- hw/xenpv/xen_domainbuild.c | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index

[Qemu-devel] [PATCH 28/30] ivshmem: use the BYTE-based definitions

It ease code review, unit is explicit. --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 16f03701b7..9b3ad96471 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -1302,7 +1302,7 @@ static void

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

On 10/01/18 19:59, David Gibson wrote: > On Mon, Jan 08, 2018 at 07:35:43PM +1100, Alexey Kardashevskiy wrote: >> On 03/01/18 11:09, David Gibson wrote: >>> On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote: On 11/12/17 17:20, Alexey Kardashevskiy wrote: > On 09/11/17

Re: [Qemu-devel] [PATCH 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"

On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > These files were including "qemu/cutils.h" to use the byte-based size > definitions, now available in "qemu/cunits.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/hw.h | 1 + > hw/arm/msf2-soc.c | 1

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

On 14.02.2018 18:46, Collin L. Walling wrote: > I'm beginning to like the usage of splash-time to represent a timeout > for the boot menu > less and less.  It is really meant for how long a _splash_ _image_ > should appear during boot. > > I'd like to suggest adding a new boot option

<    1   2   3