[Qemu-devel] [PATCH 0/3] change q35 default NIC to e1000e

The Intel 82574 NIC has better performance and more features than the aging e1000 (aka 82540), for example MSI-X. This patch chooses it by default for the Q35 machine type. As suggested by Thomas, instead of special casing e1000e, all PCI NIC device names become valid models for "-net

[Qemu-devel] [PATCH 1/3] qom: introduce object_class_get_list_sorted

Unify half a dozen copies of very similar code (the only difference being whether comparisons were case-sensitive) and use it also in Tricore, which did not do any sorting of CPU model names. Signed-off-by: Paolo Bonzini --- include/qom/object.h| 10 ++

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

On 03/05/2018 04:52 PM, Corey Minyard wrote: On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs structure, instead create a kcs structure separate

[Qemu-devel] [PATCH] iotests: Update output of 051 and 186 after commit 1454509726719e0933c

Signed-off-by: Alberto Garcia --- tests/qemu-iotests/051.pc.out | 20 tests/qemu-iotests/186.out| 22 +++--- 2 files changed, 3 insertions(+), 39 deletions(-) diff --git a/tests/qemu-iotests/051.pc.out b/tests/qemu-iotests/051.pc.out

Re: [Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context

Am 01.03.2018 um 17:36 hat Paolo Bonzini geschrieben: > Check and invalidate_cache share some parts of the implementation > with the regular I/O path. This is sometimes complicated because the > I/O path wants to use a CoMutex but that is not possible outside coroutine > context. By moving

Re: [Qemu-devel] [Qemu-block] block migration and MAX_IN_FLIGHT_IO

Am 06.03.2018 um 17:07 schrieb Stefan Hajnoczi: > On Mon, Mar 05, 2018 at 02:52:16PM +, Dr. David Alan Gilbert wrote: >> * Peter Lieven (p...@kamp.de) wrote: >>> Am 05.03.2018 um 12:45 schrieb Stefan Hajnoczi: On Thu, Feb 22, 2018 at 12:13:50PM +0100, Peter Lieven wrote: > I stumbled

Re: [Qemu-devel] [PATCH v3] iotests: Test abnormally large size in compressed cluster descriptor

ping On Mon 26 Feb 2018 03:36:23 PM CET, Alberto Garcia wrote: > L2 entries for compressed clusters have a field that indicates the > number of sectors used to store the data in the image. > > That's however not the size of the compressed data itself, just the > number of sectors where that data

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180306154625.23910-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH] trace: only

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: fix 203 migration completion race

On Mon, Mar 05, 2018 at 05:04:52PM +0100, Max Reitz wrote: > On 2018-03-05 16:59, Stefan Hajnoczi wrote: > > There is a race between the test's 'query-migrate' QMP command after the > > QMP 'STOP' event and completing the migration: > > > > The test case invokes 'query-migrate' upon receiving

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

On Tue, Mar 06, 2018 at 08:05:18AM -0800, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > Type: series >

[Qemu-devel] [PATCH] build-sys: make help could have 'modules' target

Available when configure --enable-modules. Signed-off-by: Marc-André Lureau --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 9a75c48ae0..5d9ef3b8fd 100644 --- a/Makefile +++ b/Makefile @@ -1046,6 +1046,9 @@ include

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

RFE for patchew... Now we're sending separate email alerts for each build job, can we make patchew include the job name in the subject line, so it is immediately obvious which job failed without needing to read the body. Regards, Daniel On Tue, Mar 06, 2018 at 08:12:27AM -0800,

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180306154625.23910-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH] trace: only

[Qemu-devel] [PATCH v2 4/7] qcow2: Check snapshot L1 tables in qcow2_check_metadata_overlap()

The inactive-l2 overlap check iterates uses the L1 tables from all snapshots, but it does not validate them first. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake ---

[Qemu-devel] [PATCH v2 5/7] qcow2: Check snapshot L1 table in qcow2_snapshot_goto()

This function copies a snapshot's L1 table into the active one without validating it first. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia Cc: Eric Blake --- block/qcow2-snapshot.c | 9 +

[Qemu-devel] [PATCH v2 2/7] qcow2: Check L1 table offset in qcow2_snapshot_load_tmp()

This function checks that the size of a snapshot's L1 table is not too large, but it doesn't validate the offset. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-snapshot.c

Re: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180306040154.3669-1-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PATCH v2 1/7] qcow2: Generalize validate_table_offset() into qcow2_validate_table()

This function checks that the offset and size of a table are valid. While the offset checks are fine, the size check is too generic, since it only verifies that the total size in bytes fits in a 64-bit integer. In practice all tables used in qcow2 have much smaller size limits, so the size needs

[Qemu-devel] [PATCH v2 0/7] Add checks for corruption in the snapshot table

Hey, here's the new version of this series. It fixes a leak reported by Kevin and adds a couple of error_report_err() to make use of the message returned by qcow2_validate_table(). Regards, Berto Changes: v2: - Patch 3: Don't leak l1_table and report the error returned by

[Qemu-devel] [PATCH v2 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

This function iterates over all snapshots of a qcow2 file in order to expand all zero clusters, but it does not validate the snapshots' L1 tables first. We now have a function to take care of this, so let's use it. We can also take the opportunity to replace the sector-based bdrv_read() with

[Qemu-devel] [PATCH v2 6/7] qcow2: Check snapshot L1 table in qcow2_snapshot_delete()

This function deletes a snapshot from disk, removing its entry from the snapshot table, freeing its L1 table and decreasing the refcounts of all clusters. The L1 table offset and size are however not validated. If we use invalid values in this function we'll probably corrupt the image even more,

[Qemu-devel] [PATCH v2 7/7] qcow2: Make qemu-img check detect corrupted L1 tables in snapshots

'qemu-img check' cannot detect if a snapshot's L1 table is corrupted. This patch checks the table's offset and size and reports corruption if the values are not valid. This patch doesn't add code to fix that corruption yet, only to detect and report it. Signed-off-by: Alberto Garcia

Re: [Qemu-devel] block migration and MAX_IN_FLIGHT_IO

Am 05.03.2018 um 15:52 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am 05.03.2018 um 12:45 schrieb Stefan Hajnoczi: >>> On Thu, Feb 22, 2018 at 12:13:50PM +0100, Peter Lieven wrote: I stumbled across the MAX_INFLIGHT_IO field that was introduced in 2015 and

Re: [Qemu-devel] [Qemu-block] block migration and MAX_IN_FLIGHT_IO

On Mon, Mar 05, 2018 at 02:52:16PM +, Dr. David Alan Gilbert wrote: > * Peter Lieven (p...@kamp.de) wrote: > > Am 05.03.2018 um 12:45 schrieb Stefan Hajnoczi: > > > On Thu, Feb 22, 2018 at 12:13:50PM +0100, Peter Lieven wrote: > > >> I stumbled across the MAX_INFLIGHT_IO field that was

Re: [Qemu-devel] [PATCH v3 3/4] target/arm: Add the XML dynamic generation

On 6 March 2018 at 15:29, Abdallah Bouassida wrote: > Hi Peter, >>> diff --git a/gdbstub.c b/gdbstub.c >>> index f1d5148..ffab30b 100644 >>> --- a/gdbstub.c >>> +++ b/gdbstub.c >>> @@ -665,6 +665,9 @@ static const char *get_feature_xml(const char *p, const >>>

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180306154625.23910-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH] trace: only

Re: [Qemu-devel] [PATCH v2 4/6] target/arm: Make 'any' CPU just an alias for 'max'

On 6 March 2018 at 15:16, Igor Mammedov wrote: > On Tue, 6 Mar 2018 12:55:24 + > Peter Maydell wrote: > >> Now we have a working '-cpu max', the linux-user-only >> 'any' CPU is pretty much the same thing, so implement it >> that way. >> >> For

Re: [Qemu-devel] [PATCH v2 0/2] block latency histogram

On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v2: > > 01: add block_latency_histogram_clear() > 02: fix spelling (sorry =() > some rewordings > remove histogram if latency parameter unspecified > > Vladimir Sementsov-Ogievskiy (2): > block/accounting:

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add block latency histogram interface

On Wed, Feb 07, 2018 at 03:50:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 8225308904..74fe3fe9c4 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -451,6 +451,74 @@ > 'status':

Re: [Qemu-devel] [PATCH v2 07/30] hw/arm: use the BYTE-based definitions

Philippe Mathieu-Daudé writes: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé >

[Qemu-devel] [PATCH] trace: include filename when printing parser error messages

Improves error messages from: ValueError: Error on line 72: need more than 1 value to unpack To ValueError: Error at /home/berrange/src/virt/qemu/trace-events:72: need more than 1 value to unpack Signed-off-by: Daniel P. Berrangé --- scripts/simpletrace.py

[Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

Some trace backends will compile code based on the declared trace events. It should not be assumed that the backends can resolve any QEMU specific typedefs. So trace events should restrict their argument types to the standard C types and fixed size integer types. Any complex pointer types can be

[Qemu-devel] [PATCH 1/1] scsi-disk.c: consider bl->max_transfer in INQUIRY emulation

The calculation of the max_transfer atribute of BlockDriverState makes considerations such as max_segments and transfer_length via the BLKSECTGET ioctl (if available). However, bl->max_transfer isn't considered when emulating the INQUIRY 'Block Limit' response to the scsi-hd devices. This leads

[Qemu-devel] [PATCH] .shippable.yml: disable powerpc-cross image

Something has happened to the old emdebian setup which means it no longer builds. Let's disable the shippable builds which are always failing. Signed-off-by: Alex Bennée --- .shippable.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.shippable.yml

Re: [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

On Wed, Feb 07, 2018 at 03:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Introduce latency histogram statics for block devices. > For each accounted operation type latency region [0, +inf) is > divided into subregions by several points. Then, calculate > hits for each subregion. > >

Re: [Qemu-devel] [PATCH v3 3/4] target/arm: Add the XML dynamic generation

Hi Peter, >> diff --git a/gdbstub.c b/gdbstub.c >> index f1d5148..ffab30b 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c >> @@ -665,6 +665,9 @@ static const char *get_feature_xml(const char *p, const >> char **newp, >> pstrcat(target_xml, sizeof(target_xml), ">

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/3] s390x/sclp: proper support of larger send and receive masks

On Tue, 6 Mar 2018 16:21:18 +0100 Cornelia Huck wrote: > On Fri, 2 Mar 2018 10:09:16 +0100 > Christian Borntraeger wrote: > > > On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: > > > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length >

Re: [Qemu-devel] [PATCH V4 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

On 14.01.2018 21:14, p...@cmp.felk.cvut.cz wrote: > From: Pavel Pisa > > Signed-off-by: Pavel Pisa > --- > default-configs/pci.mak | 1 + > hw/can/Makefile.objs| 1 + > hw/can/can_kvaser_pci.c | 375 >

Re: [Qemu-devel] [PATCH 0/7] audio: modularize

Hi On Tue, Mar 6, 2018 at 2:27 PM, Gerd Hoffmann wrote: >> >> /home/elmarco/src/qemu/build/x86_64-softmmu/../audio-pa.so: undefined >> >> symbol: audio_pt_unlock_and_signal > >> Fresh directory, cleaned ccache. That didn't help. fwiw, I am >> compiling on f27, gcc (GCC) 7.3.1

Re: [Qemu-devel] [PATCH v4 2/3] s390x/sclp: clean up sclp masks

On Fri, 23 Feb 2018 18:42:57 +0100 Claudio Imbrenda wrote: > Introduce an sccb_mask_t to be used for SCLP event masks instead of just > unsigned int or uint32_t. This will allow later to extend the mask with > more ease. > > Signed-off-by: Claudio Imbrenda

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/3] s390x/sclp: proper support of larger send and receive masks

On Fri, 2 Mar 2018 10:09:16 +0100 Christian Borntraeger wrote: > On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: > > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event > > masks") > > we only supported sclp event masks with a size of exactly 4 bytes,

Re: [Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated

On 06/03/2018 16:13, Thomas Huth wrote: > On 06.03.2018 14:19, Paolo Bonzini wrote: >> From: Thomas Huth >> >> These options have been marked in a comment in qemu-options.hx as >> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we >> never informed the users

Re: [Qemu-devel] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

On Tue 06 Mar 2018 04:11:17 PM CET, Kevin Wolf wrote: > I've finished the review now, the rest looks correct. > > The only other thing I wondered is about the cases where you pass a > NULL errp because the callers don't get an Error parameter, so they > can't pass it on. Some of these callers

Re: [Qemu-devel] [PATCH v2 4/6] target/arm: Make 'any' CPU just an alias for 'max'

On Tue, 6 Mar 2018 12:55:24 + Peter Maydell wrote: > Now we have a working '-cpu max', the linux-user-only > 'any' CPU is pretty much the same thing, so implement it > that way. > > For the moment we don't add any of the extra feature bits > to the

Re: [Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated

On 06.03.2018 14:19, Paolo Bonzini wrote: > From: Thomas Huth > > These options have been marked in a comment in qemu-options.hx as > deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we > never informed the users about these deprecations. Let's catch up > on that

Re: [Qemu-devel] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

Am 06.03.2018 um 16:01 hat Alberto Garcia geschrieben: > On Tue 06 Mar 2018 03:54:26 PM CET, Kevin Wolf wrote: > >> @@ -2092,11 +2092,18 @@ int qcow2_expand_zero_clusters(BlockDriverState > >> *bs, > >> } > >> > >> for (i = 0; i < s->nb_snapshots; i++) { > >> -int l1_sectors =

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On Tue, 6 Mar 2018 10:27:52 +0100 Cornelia Huck wrote: > On Tue, 6 Mar 2018 09:23:23 +0100 > Christian Borntraeger wrote: > > > On 03/05/2018 04:27 PM, Cornelia Huck wrote: > > > On Fri, 2 Mar 2018 10:44:46 +0100 > > > Christian Borntraeger

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On Tue, 6 Mar 2018 09:23:23 +0100 Christian Borntraeger wrote: > On 03/05/2018 04:27 PM, Cornelia Huck wrote: > > On Fri, 2 Mar 2018 10:44:46 +0100 > > Christian Borntraeger wrote: > > > >> On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: >

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On Mon, 5 Mar 2018 16:27:10 +0100 Cornelia Huck wrote: > On Fri, 2 Mar 2018 10:44:46 +0100 > Christian Borntraeger wrote: > > > On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: > > > Extend the SCLP event masks to 64 bits. > > > > > > Notice that

Re: [Qemu-devel] [PATCH v9 01/14] hw/arm/smmu-common: smmu base device and datatypes

Hi Peter, On 06/03/18 13:09, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> The patch introduces the smmu base device and class for the ARM >> smmu. Devices for specific versions will be derived from this >> base device. >> >> We also introduce

Re: [Qemu-devel] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

On Tue 06 Mar 2018 03:54:26 PM CET, Kevin Wolf wrote: >> @@ -2092,11 +2092,18 @@ int qcow2_expand_zero_clusters(BlockDriverState *bs, >> } >> >> for (i = 0; i < s->nb_snapshots; i++) { >> -int l1_sectors = DIV_ROUND_UP(s->snapshots[i].l1_size * >> -

Re: [Qemu-devel] [PATCH] vfio-ccw: license text should indicate GPL v2 or later

On Tue, 27 Feb 2018 18:32:51 +0100 Cornelia Huck wrote: > The license text currently specifies "any version" of the GPL. It > is unlikely that GPL v1 was ever intended; change this to the > standard "or any later version" text. > > Cc: Dong Jia Shi

Re: [Qemu-devel] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

Am 01.03.2018 um 17:27 hat Alberto Garcia geschrieben: > This function iterates over all snapshots of a qcow2 file in order to > expand all zero clusters, but it does not validate the snapshots' L1 > tables first. > > We now have a function to take care of this, so let's use it. > > We can also

Re: [Qemu-devel] [PATCH v8 0/9] vfio: add display support

On Tue, Mar 06, 2018 at 12:34:33PM +0100, Gerd Hoffmann wrote: > This series adds support for a vgpu display to the qemu vfio code. Ok, for anyone who wants play with this, the requirements: qemu The repo at git://git.kraxel.org/qemu has a sirius/dmabufs-merge branch with this series and

Re: [Qemu-devel] [PATCH v9 02/14] hw/arm/smmu-common: IOMMU memory region and address space setup

On 6 March 2018 at 14:47, Auger Eric wrote: > Hi Peter, > > On 06/03/18 15:08, Peter Maydell wrote: >> On 17 February 2018 at 18:46, Eric Auger wrote: >>> +if (!smmu_pci_bus) { >>> +GHashTableIter iter; >>> + >>> +

Re: [Qemu-devel] [PATCH 0/5] Convert the TPM code to use tracing

On Sun, Mar 04, 2018 at 04:56:22PM -0500, Stefan Berger wrote: > This series of patches converts the TPM code to use tracing rather > than the #define DEBUG_XYZ type of debugging. > > Regards, >Stefan > > Stefan Berger (5): > tpm: convert tpm_crb.c to use trace-events > tpm: convert

Re: [Qemu-devel] [PATCH v9] vhost: used_memslots refactoring

On Mon, 5 Mar 2018 17:37:42 +0200 "Michael S. Tsirkin" wrote: > On Mon, Mar 05, 2018 at 05:12:49PM +0800, Jay Zhou wrote: > > Used_memslots is shared by vhost kernel and user, it is equal to > > dev->mem->nregions, which is correct for vhost kernel, but not for > > vhost user,

Re: [Qemu-devel] [PATCH v9 02/14] hw/arm/smmu-common: IOMMU memory region and address space setup

Hi Peter, On 06/03/18 15:08, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> We enumerate all the PCI devices attached to the SMMU and >> initialize an associated IOMMU memory region and address space. >> This happens on SMMU base instance init.

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

On 06/03/2018 15:31, Stefan Hajnoczi wrote: > On Fri, Mar 02, 2018 at 01:43:19PM +0300, Julia Suvorova wrote: >> g_path_get_* do the same as g_strdup(basename/dirname(...)) but >> without modifying the argument. >> >> Signed-off-by: Julia Suvorova >> --- >> scripts/checkpatch.pl

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

On Tue, 6 Mar 2018 10:07:21 + Nia Alarie wrote: > Allows a branch to be removed - this function always returns 0. > > Signed-off-by: Nia Alarie > Reviewed-by: Christian Borntraeger > --- > hw/s390x/virtio-ccw.c | 6

Re: [Qemu-devel] [PATCH v3 1/2] s390x/sclpconsole: Remove dead code - remove exit handlers

On Tue, 6 Mar 2018 10:07:20 + Nia Alarie wrote: > The other event handlers (quiesce and cpu) do not define these > handlers, and this one does nothing, so it can be removed. > > Signed-off-by: Nia Alarie > Reviewed-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

On Fri, Mar 02, 2018 at 01:43:19PM +0300, Julia Suvorova wrote: > g_path_get_* do the same as g_strdup(basename/dirname(...)) but > without modifying the argument. > > Signed-off-by: Julia Suvorova > --- > scripts/checkpatch.pl | 5 + > 1 file changed, 5 insertions(+)

Re: [Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context

On 06/03/2018 14:59, Kevin Wolf wrote: > Am 01.03.2018 um 17:36 hat Paolo Bonzini geschrieben: >> Check and invalidate_cache share some parts of the implementation >> with the regular I/O path. This is sometimes complicated because the >> I/O path wants to use a CoMutex but that is not possible

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/5] aarch64-linux-user: Add support for SVE signal frame records

Richard Henderson writes: > Depending on the currently selected size of the SVE vector registers, > we can either store the data within the "standard" allocation, or we > may beedn to allocate additional space with an EXTRA record. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On Mon, 26 Feb 2018 17:57:51 +0100 Cornelia Huck wrote: > On Fri, 23 Feb 2018 18:42:58 +0100 > Claudio Imbrenda wrote: > > > Extend the SCLP event masks to 64 bits. > > > > Notice that using any of the new bits results in a state that > > cannot

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 4/5] aarch64-linux-user: Add support for EXTRA signal frame records

Richard Henderson writes: > The EXTRA record allows for additional space to be allocated > beyon what is currently reserved. Add code to emit and read > this record type. > > Nothing uses extra space yet. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events

On Tue, Mar 06, 2018 at 02:16:00PM +, Mark Cave-Ayland wrote: > On 06/03/18 13:44, Daniel P. Berrangé wrote: > > > The trace events all use a uint64_t data type, so should be using the > > corresponding PRIx64 format, not HWADDR_PRIx which is intended for use > > with the 'hwaddr' type. > >

Re: [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06

On 6 March 2018 at 13:18, Paolo Bonzini wrote: > The following changes since commit 58e2e17dba49b43f4ac9de19468aeae1c787dcc2: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-03-06 11:20:44 +) > > are available in the git

Re: [Qemu-devel] [PATCH 0/7] Add checks for corruption in the snapshot table

On Tue 06 Mar 2018 03:06:46 PM CET, Kevin Wolf wrote: >> So although having a way to repair this kind of corruption would be >> nice, we should still allow the user to try to open the image and >> read data from it without requiring a potentially destructive >> operation first. > > Generally

Re: [Qemu-devel] [PATCH v4 3/5] aarch64-linux-user: Remove struct target_aux_context

Richard Henderson writes: > This changes the qemu signal frame layout to be more like the kernel's, > in that the various records are dynamically allocated rather than fixed > in place by a structure. > > For now, all of the allocation is out of

Re: [Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events

On 06/03/18 13:44, Daniel P. Berrangé wrote: The trace events all use a uint64_t data type, so should be using the corresponding PRIx64 format, not HWADDR_PRIx which is intended for use with the 'hwaddr' type. Ha okay looks like you beat me to it ;) I wonder if we can teach checkpatch.pl

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

On 06/03/18 13:24, Daniel P. Berrangé wrote: Use types that are defined by QEMU in trace events caused build failures for the UST trace backend: In file included from trace-ust-all.c:13:0: trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ It only knows about C built-in types,

Re: [Qemu-devel] [PATCH v4 2/5] aarch64-linux-user: Split out helpers for guest signal handling

Richard Henderson writes: > Split out helpers from target_setup_frame and target_restore_sigframe > for dealing with general registers, fpsimd registers, and the end record. > > When we add support for sve registers, the relative positions of > these will change. >

Re: [Qemu-devel] [PATCH v9 02/14] hw/arm/smmu-common: IOMMU memory region and address space setup

On 17 February 2018 at 18:46, Eric Auger wrote: > We enumerate all the PCI devices attached to the SMMU and > initialize an associated IOMMU memory region and address space. > This happens on SMMU base instance init. > > Those info are stored in SMMUDevice objects. The

Re: [Qemu-devel] [PATCH 0/7] Add checks for corruption in the snapshot table

Am 01.03.2018 um 17:27 hat Alberto Garcia geschrieben: > Hey ho! > > As we have already discussed in the mailing list, the offset and size > values of snapshots' L1 tables are almost never validated in the QEMU > code. > > One way to deal with this is to validate them when the image is being >

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 1/5] linux-user: Implement aarch64 PR_SVE_SET/GET_VL

Peter Maydell writes: > On 6 March 2018 at 12:28, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> As an implementation choice, widening VL has zeroed the >>> previously inaccessible portion of the sve

Re: [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1520342370-123606-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context

Am 01.03.2018 um 17:36 hat Paolo Bonzini geschrieben: > Check and invalidate_cache share some parts of the implementation > with the regular I/O path. This is sometimes complicated because the > I/O path wants to use a CoMutex but that is not possible outside coroutine > context. By moving

Re: [Qemu-devel] [RFC] qemu-img: Drop BLK_ZERO from convert

On Wed, Feb 28, 2018 at 09:11:32PM +0100, Max Reitz wrote: > On 2018-02-28 19:08, Max Reitz wrote: > > On 2018-02-27 17:17, Stefan Hajnoczi wrote: > >> On Mon, Feb 26, 2018 at 06:03:13PM +0100, Max Reitz wrote: > >>> There are filesystems (among which is tmpfs) that have a hard time > >>>

Re: [Qemu-devel] [PATCH v2] misc: don't use hwaddr as a type in trace events

On 6 March 2018 at 13:43, Daniel P. Berrangé wrote: > Use types that are defined by QEMU in trace events caused build failures > for the UST trace backend: > > In file included from trace-ust-all.c:13:0: > trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ > >

[Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events

The trace events all use a uint64_t data type, so should be using the corresponding PRIx64 format, not HWADDR_PRIx which is intended for use with the 'hwaddr' type. Signed-off-by: Daniel P. Berrangé --- hw/ide/trace-events | 4 ++-- hw/misc/trace-events | 8 2

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

On 6 March 2018 at 13:24, Daniel P. Berrangé wrote: > Use types that are defined by QEMU in trace events caused build failures > for the UST trace backend: > > In file included from trace-ust-all.c:13:0: > trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ > >

[Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

Use types that are defined by QEMU in trace events caused build failures for the UST trace backend: In file included from trace-ust-all.c:13:0: trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ It only knows about C built-in types, and any types that are pulled in from includs of

[Qemu-devel] [PULL 28/34] Fix WHPX additional lock acquisition

From: "Justin Terry (VM) via Qemu-devel" The code already is holding the qemu_mutex for the IO thread. We do not need to additionally take the lock again in this case. Signed-off-by: Justin Terry (VM) Message-Id:

[Qemu-devel] [PULL 31/34] WHXP Removes the use of WHvGetExitContextSize

From: "Justin Terry (VM) via Qemu-devel" The use of WHvGetExitContextSize will break ABI compatibility if the platform changes the context size while a qemu compiled executable does not recompile. To avoid this we now use sizeof and let the platform determine which version

[Qemu-devel] [PULL 33/34] balloon: Fix documentation of the --balloon parameter and deprecate it

From: Thomas Huth There are two issues with the documentation of the --balloon parameter: First, "--balloon none" is simply doing nothing. Even if a machine had a balloon device by default, this option is not disabling anything, it is simply ignored. Thus let's simply drop this

[Qemu-devel] [PULL 30/34] Fix WHPX issue leaking tpr values

From: "Justin Terry (VM) via Qemu-devel" Fixes an issue where if the tpr is assigned to the array but not a different value from what is already expected on the vp the code will skip incrementing the reg_count. In this case its possible that we set an invalid memory

[Qemu-devel] [PATCH v2] misc: don't use hwaddr as a type in trace events

Use types that are defined by QEMU in trace events caused build failures for the UST trace backend: In file included from trace-ust-all.c:13:0: trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ It only knows about C built-in types, and any types that are pulled in from includs of

[Qemu-devel] [PULL 23/34] checkpatch: add check for `while` and `for`

From: Su Hang Adding check for `while` and `for` statements, which condition has more than one line. The former checkpatch.pl can check `if` statement, which condition has more than one line, whether block misses brace round, like this: ''' if (cond1 || cond2)

[Qemu-devel] [PULL 32/34] WHPX improve interrupt notification registration

From: "Justin Terry (VM) via Qemu-devel" Improves the usage of the InterruptNotification registration by skipping the additional call to WHvSetVirtualProcessorRegisters if we have already registered for the window exit. Signed-off-by: Justin Terry (VM)

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

On 6 March 2018 at 13:38, Daniel P. Berrangé wrote: > On Tue, Mar 06, 2018 at 01:33:42PM +, Peter Maydell wrote: >> If the type isn't "hwaddr" then HWADDR_PRIx is the wrong >> format string macro -- those should change to PRIx64. > > Eeek, that HWADDR_PRIx macro is used

[Qemu-devel] [PULL 29/34] Fix WHPX typo in 'mmio'

From: "Justin Terry (VM) via Qemu-devel" Renames the usage of 'memio' to 'mmio' in the emulator callbacks. Signed-off-by: Justin Terry (VM) Message-Id: <1519665216-1078-6-git-send-email-jute...@microsoft.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 17/34] address_space_write: address_space_to_flatview needs RCU lock

address_space_write is calling address_space_to_flatview but it can be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock pair up from flatview_write to address_space_write. Reviewed-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 27/34] Remove unnecessary WHPX __debugbreak();

From: "Justin Terry (VM) via Qemu-devel" Minor code cleanup. The calls to __debugbreak() are not required and should no longer be used to prevent unnecessary breaks. Signed-off-by: Justin Terry (VM) Message-Id:

Re: [Qemu-devel] [PATCH V3 0/4] vfio: Introduce Live migration capability to vfio_mdev device

Hi Kirti, Yes, that is the plan and we will address it in the coming versions. In this version we just rebase the code and looking for more inputs. Thanks, Yulei > -Original Message- > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Monday, March 5, 2018 9:03 PM > To: Zhang,

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

On Tue, Mar 06, 2018 at 01:33:42PM +, Peter Maydell wrote: > On 6 March 2018 at 13:24, Daniel P. Berrangé wrote: > > Use types that are defined by QEMU in trace events caused build failures > > for the UST trace backend: > > > > In file included from

[Qemu-devel] [PULL 15/34] openpic_kvm: drop address_space_to_flatview call

The MemoryListener is registered on address_space_memory, there is not much to assert. This currently works because the callback is invoked only once when the listener is registered, but section->fv is the _new_ FlatView, not the old one on later calls and that would break. This confines

[Qemu-devel] [PULL 24/34] Revert "build-sys: compile with -Og or -O1 when --enable-debug"

This reverts commit 906548689e37ab6cca1e93b3f8d9327a4e17e8af. Even with -Og, the debug experience is noticeably worse because gdb shows a lot more "" variables and function arguments. Signed-off-by: Paolo Bonzini --- configure | 15 ++- 1 file changed, 2

Re: [Qemu-devel] [PATCH 0/7] audio: modularize

> >> /home/elmarco/src/qemu/build/x86_64-softmmu/../audio-pa.so: undefined > >> symbol: audio_pt_unlock_and_signal > Fresh directory, cleaned ccache. That didn't help. fwiw, I am > compiling on f27, gcc (GCC) 7.3.1 20180130. I'll investigate further > if you can't reproduce. Hmm, working fine

[Qemu-devel] [PULL 13/34] sdhci-test: fix leaks

From: Marc-André Lureau Fix the following ASAN reports: ==20125==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f0faea03a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) #1 0x7f0fae450f75

<    1   2   3   4   5   >