Re: [Qemu-devel] [PATCH 2/4] sparp_pci: simplify how the PCI LSIs are allocated

2018-06-05 Thread Cédric Le Goater
On 06/05/2018 05:44 AM, David Gibson wrote: > On Sat, May 26, 2018 at 11:40:23AM +0200, Greg Kurz wrote: >> On Fri, 18 May 2018 18:44:03 +0200 >> Cédric Le Goater wrote: >> >>> PCI LSIs are today allocated one by one using the IRQ alloc_block >>> routine. Change the code sequence to first

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Laurent Vivier
On 05/06/2018 07:27, Richard Henderson wrote: > On 06/03/2018 06:04 PM, Laurent Vivier wrote: >> On 01/06/2018 00:49, Richard Henderson wrote: >>> If the interp_prefix is a complete chroot, it may have a *lot* of files. >>> Setting up the cache for this is quite expensive. >>> >>> For the most

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-05 Thread Peter Xu
On Mon, Jun 04, 2018 at 04:04:51PM +0800, Wei Wang wrote: > On 05/30/2018 08:47 PM, Michael S. Tsirkin wrote: > > On Wed, May 30, 2018 at 05:12:09PM +0800, Wei Wang wrote: > > > On 05/29/2018 11:24 PM, Michael S. Tsirkin wrote: > > > > On Tue, Apr 24, 2018 at 02:13:47PM +0800, Wei Wang wrote: > >

Re: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-06-05 Thread Peter Xu
On Mon, Jun 04, 2018 at 04:29:28PM +0100, Peter Maydell wrote: > Hi; this is v2 of my iommu patchset, which does: > * support IOMMUs that are aware of memory transaction attributes and >may generate different translations for different attributes > * support TCG execution out of memory which

Re: [Qemu-devel] [PATCH v4 00/19] reverse debugging

2018-06-05 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> > Ping? >> >> I started having a look but I ran into this straight away. First I >> recorded a boot of the kernel: >> >> ./aarch64-softmmu/qemu-system-aarch64 -machine

[Qemu-devel] [PATCH] spapr/vio: deprecate the "irq" property

2018-06-05 Thread Cédric Le Goater
VIO devices have an "irq" property that can be used by the sPAPR IRQ allocator as an IRQ number hint. But it is not set in QEMU nor in libvirt. It brings unnecessary complexity to the underlying layers managing the IRQ number space and it is in full opposition with the new static IRQ allocator we

Re: [Qemu-devel] [PATCH v4 00/19] reverse debugging

2018-06-05 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> > Ping? >> >> I started having a look but I ran into this straight away. First I >> recorded a boot of the kernel: >> >> ./aarch64-softmmu/qemu-system-aarch64 -machine

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-05 Thread Cédric Le Goater
On 06/05/2018 05:34 AM, David Gibson wrote: > On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wrote: >> On 05/28/2018 08:17 AM, Thomas Huth wrote: >>> On 25.05.2018 16:02, Greg Kurz wrote: On Fri, 18 May 2018 18:44:02 +0200 Cédric Le Goater wrote: > This IRQ number

Re: [Qemu-devel] [RFC PATCH] target/ppc: extend eieio for POWER9

2018-06-05 Thread Cédric Le Goater
On 06/05/2018 01:10 AM, David Gibson wrote: > On Mon, Jun 04, 2018 at 07:20:39PM +0200, Cédric Le Goater wrote: >> POWER9 introduced a new variant of the eieio instruction using bit 6 >> as a hint to tell the CPU it is a store-forwarding barrier. >> >> The usage of this eieio extension was

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > Hi, > > > > Add to that shortcuts like -cdrom > > > stop working, > > > > Maybe is fixable. > > Already fixed for ages. > > > I see marking Q35 as the default machine a first step. > > Maybe the better option is to go the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: Allow privileged access to SPR_PCR

2018-06-05 Thread Greg Kurz
On Mon, 4 Jun 2018 17:59:45 +1000 David Gibson wrote: > On Thu, May 31, 2018 at 01:27:33PM +0200, Greg Kurz wrote: > > On Thu, 31 May 2018 09:38:10 +0200 > > Cédric Le Goater wrote: > > > > > On 05/30/2018 04:42 PM, Joel Stanley wrote: > > > > The powerpc Linux kernel[1] and skiboot

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 22:06:35 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 05:01:11PM +0200, Igor Mammedov wrote: > [...] > > I'd prefer your patch, as it doesn't break error handling, > > or maybe even shorter version which keeps state transitions in one place: > > > > diff --git

Re: [Qemu-devel] [RFC v2 6/6] hw/arm: Populate non-contiguous memory regions

2018-06-05 Thread Shameerali Kolothum Thodi
Hi Drew, > -Original Message- > From: Shameerali Kolothum Thodi > Sent: 30 May 2018 15:49 > To: 'Auger Eric' ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: drjo...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > alex.william...@redhat.com; Zhaoshenglong ; > Jonathan

Re: [Qemu-devel] [PATCH] vl.c: make default main_loop_wait() timeout independed of slirp

2018-06-05 Thread Paolo Bonzini
On 05/06/2018 10:27, Igor Mammedov wrote: >> I don't get this part. Why default infinite timeout doesn't make >> sense? Why would a 1 second timeout make sense? > > I've meant that there is no reason for infinite timeout, > and 1sec is good as any other finite one. > Hence we can unify timeout

Re: [Qemu-devel] [PULL 16/40] migration: allow dst vm pause on postcopy

2018-06-05 Thread Peter Xu
On Mon, Jun 04, 2018 at 02:49:58PM +0100, Peter Maydell wrote: > On 16 May 2018 at 00:39, Juan Quintela wrote: > > From: Peter Xu > > > > When there is IO error on the incoming channel (e.g., network down), > > instead of bailing out immediately, we allow the dst vm to switch to the > > new

Re: [Qemu-devel] [PATCH] spapr/vio: deprecate the "irq" property

2018-06-05 Thread Thomas Huth
On 05.06.2018 08:56, Cédric Le Goater wrote: > VIO devices have an "irq" property that can be used by the sPAPR IRQ > allocator as an IRQ number hint. But it is not set in QEMU nor in > libvirt. It brings unnecessary complexity to the underlying layers > managing the IRQ number space and it is in

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-05 Thread Peter Xu
On Fri, Jun 01, 2018 at 04:33:29PM +0100, Dr. David Alan Gilbert wrote: [...] > > > > Meanwhile, this reminds me about a more funny idea: whether we can > > > > just avoid sending the zero pages directly from QEMU's perspective. > > > > In other words, can we just do nothing if save_zero_page()

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-05 Thread Gerd Hoffmann
Hi, > > Add to that shortcuts like -cdrom > > stop working, > > Maybe is fixable. Already fixed for ages. > I see marking Q35 as the default machine a first step. Maybe the better option is to go the arm route: Just don't define a default, so users have to specify pc or q35. That will

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-05 Thread Cornelia Huck
On Tue, 5 Jun 2018 06:33:22 +0200 Thomas Huth wrote: > On 05.06.2018 03:17, Alex Williamson wrote: > > On Mon, 4 Jun 2018 17:21:40 +0100 > > Peter Maydell wrote: > > > >> The codebase has a bit of a mix of > >> /* multiline comments > >> * like this > >> */ > >> and > >> /* multiline

Re: [Qemu-devel] [PATCH v4 07/14] spapr: route all memory devices through the machine hotplug handler

2018-06-05 Thread David Hildenbrand
On 05.06.2018 03:09, David Gibson wrote: > On Thu, May 17, 2018 at 10:15:20AM +0200, David Hildenbrand wrote: >> Necessary to hotplug them cleanly later. >> >> Signed-off-by: David Hildenbrand > > As for PC, I think it would be nicer to drop the explicit check > against PC_DIMM, since it is

Re: [Qemu-devel] [PATCH v4 06/14] spapr: prepare for multi stage hotplug handlers

2018-06-05 Thread David Hildenbrand
On 05.06.2018 03:08, David Gibson wrote: > On Thu, May 17, 2018 at 10:15:19AM +0200, David Hildenbrand wrote: >> For multi stage hotplug handlers, we'll have to do some error handling >> in some hotplug functions, so let's use a local error variable (except >> for unplug requests). >> >> Also, add

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 21:35:46 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 07:37:15PM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 17:11:57 +0100 > > Daniel P. Berrangé wrote: > > > > > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > > > On Mon, 4 Jun 2018

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 21:56:47 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > [...] > > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > > } > > > break; > > > case

[Qemu-devel] [PATCH v2 2/2] backup: Use copy offloading

2018-06-05 Thread Fam Zheng
The implementation is similar to the 'qemu-img convert'. In the beginning of the job, offloaded copy is attempted. If it fails, further I/O will go through the existing bounce buffer code path. Signed-off-by: Fam Zheng --- block/backup.c | 151 +

[Qemu-devel] [PATCH v2 1/2] block: Honour BDRV_REQ_NO_SERIALISING in copy range

2018-06-05 Thread Fam Zheng
This semantics is needed by drive-backup so implement it before using this API there. Signed-off-by: Fam Zheng --- block/io.c| 6 -- include/block/block.h | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/block/io.c b/block/io.c index

[Qemu-devel] [PATCH v2 0/2] backup: Use copy offloading

2018-06-05 Thread Fam Zheng
Based-on: <20180601092648.24614-1-f...@redhat.com> ([PATCH v9 00/10] qemu-img convert with copy offloading) This enhances the backup job to make use of the copy offloading API. It eliminates the necessity to use the bounce buffer as well as speeding up the copy operation when the backend supports

Re: [Qemu-devel] [PATCH] vl.c: make default main_loop_wait() timeout independed of slirp

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 22:04:13 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 10:14:38PM +0200, Igor Mammedov wrote: > > Since commit (047f7038f58 cli: add --preconfig option) QEMU is > > stuck with indefinite timeout in os_host_main_loop_wait() > > at RUN_STATE_PRECONFIG even if

Re: [Qemu-devel] vIOMMU Posted-interrupt implementation - atomic operation?

2018-06-05 Thread Tian, Kevin
> From: Jintack Lim > Sent: Friday, June 1, 2018 11:47 AM > > Hi, > > I'm implementing Posted-interrupt functionality in vIOMMU. According > to Vt-d spec 5.2.3, IOMMU performs a coherent atomic read-modify-write > operation of the posted-interrupt descriptor. I wonder how can we > achieve this

Re: [Qemu-devel] [PATCH] vl.c: make default main_loop_wait() timeout independed of slirp

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:27:03AM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 22:04:13 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 10:14:38PM +0200, Igor Mammedov wrote: > > > Since commit (047f7038f58 cli: add --preconfig option) QEMU is > > > stuck with indefinite

[Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-06-05 Thread Pavel Dovgalyuk
The following series implements dynamic binary instrumentation upon QEMU. It is based on the following prior sources: - KVM Forum 2017 talk "Instrumenting, Introspection, and Debugging with QEMU" https://www.linux-kvm.org/images/3/3d/Introspect.pdf - Discussion on Lluis Vilanova

[Qemu-devel] [RFC PATCH v2 2/7] Add plugin support

2018-06-05 Thread Pavel Dovgalyuk
This patch adds support for dynamically loaded plugins. Every plugin is a dynamic library with a set of optional exported functions that will be called from QEMU. Signed-off-by: Pavel Dovgalyuk --- Makefile.target |1 configure | 14 ++-

[Qemu-devel] [RFC PATCH v2 1/7] tcg: add headers for non-target helpers

2018-06-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds functions and headers for adding the helpers from the modules other than the target translators. Signed-off-by: Pavel Dovgalyuk --- include/exec/helper-register.h | 53 tcg/tcg.c | 12

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-06-05 Thread Halil Pasic
On 06/05/2018 12:14 PM, Cornelia Huck wrote: On Thu, 24 May 2018 19:58:27 +0200 Halil Pasic wrote: There is at least one guest (OS) such that although it does not rely on the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka P bit) not being set, it fails to tell this to

Re: [Qemu-devel] [PATCH V6 2/7] memory, exec: switch file ram allocation functions to 'flags' parameters

2018-06-05 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 04:10:24PM +0800, junyan...@gmx.com wrote: > From: Junyan He > > As more flag parameters besides the existing 'share' are going to be > added to following functions > memory_region_init_ram_from_file > qemu_ram_alloc_from_fd > qemu_ram_alloc_from_file > let's switch

Re: [Qemu-devel] [PATCH 3/3] pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to the UUID

2018-06-05 Thread Thomas Huth
On 04.06.2018 11:36, Cornelia Huck wrote: > On Wed, 30 May 2018 11:16:58 +0200 > Thomas Huth wrote: > >> With the STSI instruction, we can get the UUID of the current VM instance, >> so we can support loading pxelinux config files via UUID in the file name, >> too. >> >> Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 01:03:44PM +0100, Daniel P. Berrangé wrote: > diff --git a/vl.c b/vl.c > index 06031715ac..30d0e985f0 100644 > --- a/vl.c > +++ b/vl.c > @@ -561,7 +561,7 @@ static int default_driver_check(void *opaque, QemuOpts > *opts, Error **errp) >

[Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow a bunch of the info commands to be used in preconfig. Could probably add most of them. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands-info.hx | 9 + hmp-commands.hx | 1 + 2 files changed, 10 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might see two devices with same mac and get confused. I think that we should only make primary visible after guest acked the backup feature bit. And on reset or when

[Qemu-devel] [PATCH] usb: update docs

2018-06-05 Thread Gerd Hoffmann
xhci is rock solid meanwhile. So move it up in the docs and feature it as prefered usb host adapter, instead of the old shy version saying "you might want try ...". While being at it rework the text on ehci and companion controllers too. Signed-off-by: Gerd Hoffmann --- docs/usb2.txt | 80

Re: [Qemu-devel] [PULL 00/11] Block patches

2018-06-05 Thread Peter Maydell
On 4 June 2018 at 12:20, Stefan Hajnoczi wrote: > The following changes since commit c25e8bba1f546ea72744ccfab77f8a9e8a323be8: > > Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180601' > into staging (2018-06-01 13:11:30 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-05 Thread Cornelia Huck
On Tue, 5 Jun 2018 10:19:15 +0100 Peter Maydell wrote: > On 5 June 2018 at 08:46, Cornelia Huck wrote: > > On Tue, 5 Jun 2018 06:33:22 +0200 > > Thomas Huth wrote: > >> Anyway, could we either use that dense format or the kernel-style > >> multi-lines-comment format, please? Mixing it

[Qemu-devel] [RFC PATCH v2 5/7] plugins: add plugin template

2018-06-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This is a template of the QEMU plugin. It includes empty functions that plugins may implement. Signed-off-by: Pavel Dovgalyuk --- plugins/template/Makefile | 19 +++ plugins/template/template.c | 19 +++ 2 files changed, 38

[Qemu-devel] [RFC PATCH v2 3/7] plugins: provide helper functions for plugins

2018-06-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds interface functions that may be called from the loaded plugins. Such functions are needed to inspect the VM state and to pass data to the QEMU (e.g., QEMU-side logging). Signed-off-by: Pavel Dovgalyuk --- Makefile.target |2 +-

[Qemu-devel] [RFC PATCH v2 4/7] tcg: add instrumenting module

2018-06-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This is a samples of the instrumenting interface and implementation of some instruction tracing tasks. Signed-off-by: Pavel Dovgalyuk --- accel/tcg/translator.c|5 + include/qemu/instrument.h |7 +++ plugins/helper.h |1 +

[Qemu-devel] [RFC PATCH v2 7/7] plugins: add syscall logging plugin sample

2018-06-05 Thread Pavel Dovgalyuk
This is an example of plugin which instruments only specific instructions: sysenter and sysexit. When executing them, it prints system call id and return code to the QEMU log. Signed-off-by: Pavel Dovgalyuk --- plugins/syscall-log/Makefile | 19

Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 21:41:46 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote: > [...] > > Avoiding the double-run of main_loop is good, however, I think we should > > also not have put current_run_state in RUN_STATE_PRECONFIG in the first > >

Re: [Qemu-devel] [PATCH V6 5/7] mem/nvdimm: ensure write persistence to PMEM in label emulation

2018-06-05 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 04:10:27PM +0800, junyan...@gmx.com wrote: > From: Junyan He > > Guest writes to vNVDIMM labels are intercepted and performed on the > backend by QEMU. When the backend is a real persistent memort, QEMU > needs to take proper operations to ensure its write persistence on

Re: [Qemu-devel] [PATCH V6 3/7] hostmem-file: add the 'pmem' option

2018-06-05 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 04:10:25PM +0800, junyan...@gmx.com wrote: > From: Junyan He > > When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it > needs to know whether the backend storage is a real persistent memory, > in order to decide whether special operations should be performed

Re: [Qemu-devel] [PATCH V6 7/7] migration/ram: ensure write persistence on loading all data to PMEM.

2018-06-05 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 04:10:29PM +0800, junyan...@gmx.com wrote: > diff --git a/migration/ram.c b/migration/ram.c > index aa0c6f0..09525b2 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -33,6 +33,7 @@ > #include "qemu/bitops.h" > #include "qemu/bitmap.h" > #include

[Qemu-devel] [PATCH v2 1/2] kvm: sync linux headers

2018-06-05 Thread Dongjiu Geng
Import KVM_CAP_ARM_INJECT_SERROR_ESR and struct kvm_vcpu_events for arm64 Signed-off-by: Dongjiu Geng --- linux-headers/asm-arm64/kvm.h | 13 + linux-headers/linux/kvm.h | 1 + 2 files changed, 14 insertions(+) diff --git a/linux-headers/asm-arm64/kvm.h

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-05 Thread Cornelia Huck
On Tue, 22 May 2018 17:10:44 +0200 Pierre Morel wrote: > On 22/05/2018 14:52, Cornelia Huck wrote: > > On Wed, 16 May 2018 15:32:48 +0200 > > Pierre Morel wrote: > > > >> On 15/05/2018 18:10, Cornelia Huck wrote: > >>> On Fri, 11 May 2018 11:33:35 +0200 > >>> Pierre Morel wrote: > >>>

Re: [Qemu-devel] [PATCH] spapr/vio: deprecate the "irq" property

2018-06-05 Thread Greg Kurz
On Tue, 5 Jun 2018 08:56:26 +0200 Cédric Le Goater wrote: > VIO devices have an "irq" property that can be used by the sPAPR IRQ > allocator as an IRQ number hint. But it is not set in QEMU nor in > libvirt. It brings unnecessary complexity to the underlying layers > managing the IRQ number

Re: [Qemu-devel] [RFC PATCH qemu] qdev: Use "string" for QOM string properties

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 07:15:08PM +1000, Alexey Kardashevskiy wrote: > For QOM properties QEMU uses "string", for example: > > {"execute": "qom-list", "arguments": {"path": "/machine"}} > [{'return': [{'type': 'string', 'name': 'append'}, {'type': 'string', > 'name': 'kernel'}] > > However

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-06-05 Thread Cornelia Huck
On Thu, 24 May 2018 19:58:27 +0200 Halil Pasic wrote: > There is at least one guest (OS) such that although it does not rely on > the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka > P bit) not being set, it fails to tell this to the machine. > > Usually this ain't a big

Re: [Qemu-devel] [PULL 16/40] migration: allow dst vm pause on postcopy

2018-06-05 Thread Peter Xu
On Tue, Jun 05, 2018 at 03:48:09PM +0800, Peter Xu wrote: [...] > > There are also a couple of other things Coverity thinks might > > be data race conditions (CID 1391295 and CID 1391288) that you > > might want to look at, though I suspect they are false-positives > > (access occurs before

[Qemu-devel] [RFC PATCH v2 6/7] plugin: add instruction execution logger

2018-06-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds a plugin for logging addresses of all executed instructions, making a complete instruction-level trace. Signed-off-by: Pavel Dovgalyuk --- plugins/exec-log/Makefile | 19 +++ plugins/exec-log/exec-log.c | 18 ++ 2

Re: [Qemu-devel] [Qemu-block] [PATCH v2 5/8] qcow: Switch to a byte-based driver

2018-06-05 Thread Eric Blake
On 06/04/2018 04:33 PM, Jeff Cody wrote: On Thu, May 31, 2018 at 03:50:43PM -0500, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based. The qcow driver is now ready to fully utilize the byte-based callback interface, as long as we override the

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 13:23, Laurent Vivier wrote: > They are used by tests/qemu-iotests/socket_scm_helper and > qemu-bridge-helper. > > Perhaps we can disable qemu-iotests with linux-user only and to not > build qemu-bridge-helper when tools are disabled? Yeah, we shouldn't be building those if

Re: [Qemu-devel] [PATCH v2 1/2] kvm: sync linux headers

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 21:52, Dongjiu Geng wrote: > Import KVM_CAP_ARM_INJECT_SERROR_ESR and struct kvm_vcpu_events > for arm64 > > Signed-off-by: Dongjiu Geng Was this produced with the update-headers script? If so, the commit message should say so and also which upstream kernel commit/tag the sync

Re: [Qemu-devel] [PATCH v3 1/5] cutils: Provide strchrnul

2018-06-05 Thread Greg Kurz
On Tue, 5 Jun 2018 13:48:02 +0200 Greg Kurz wrote: > On Sat, 2 Jun 2018 17:29:35 -0400 > Keno Fischer wrote: > > > strchrnul is a GNU extension and thus unavailable on a number of targets. > > In the review for a commit removing strchrnul from 9p, I was asked to > > create a qemu_strchrnul

Re: [Qemu-devel] [PATCH v2 0/7] ramfb: simple boot framebuffer, no legacy vga

2018-06-05 Thread Gerd Hoffmann
On Tue, Jun 05, 2018 at 02:07:27PM +0200, Laszlo Ersek wrote: > On 06/05/18 13:06, Gerd Hoffmann wrote: > > Hi, > > > I could imagine an OvmfPkg-specific PCI capability that said, "all PCI > drivers in OvmfPkg that could otherwise drive this device, ignore it -- > another

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-05 Thread Dr. David Alan Gilbert
This seems to have fizzled out because of a lack of a concrete proposal; so here is one based on a reply to Max's post: * Max Reitz (mre...@redhat.com) wrote: > The original problem was that you need to supply a machine type to qemu, > and that multiple common architectures now have multiple

Re: [Qemu-devel] [PATCH v2 3/3] usb/dev-mtp: Fix use of uninitialized values

2018-06-05 Thread Gerd Hoffmann
> +for (i = c->argc; i < ARRAY_SIZE(c->argv); i++) { > +c->argv[i] = 0; > +} I think the code filling c->argv (in usb_mtp_handle_data) should so that. Or just memset(0) cmd in usb_mtp_handle_data ... cheers, Gerd PS: the other patches are fine.

Re: [Qemu-devel] [RFC PATCH 2/5] kbd-state: add hotkey registry

2018-06-05 Thread Gerd Hoffmann
Hi, > You say the hotkey is a QKeyCode and a modifier key combined. But it looks > like a single QKeyCode would be supported. I would prefer being able to use a > single key like F16 to ungrab the mouse. Would that be possible here? > > Kbd_state_hotkey_register(kbd, KBD_HOTKEY_GRAB,

Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 11:39, Pavel Dovgalyuk wrote: > The following series implements dynamic binary instrumentation upon QEMU. > The aim of submission of this series at that early stage is to get > the feedback which will guide the development process. We are faced > the following questions: > 1.

Re: [Qemu-devel] Preconfig state reachable without --preconfig given

2018-06-05 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 4 Jun 2018 11:46:06 +0200 > Max Reitz wrote: > > > On 2018-06-02 12:46, Michal Privoznik wrote: > > > On 06/01/2018 03:28 PM, Max Reitz wrote: > > >> Hi, > > >> > > >> The @preconfig RunState documentation states: > > >> > > >>> The

Re: [Qemu-devel] [PATCH V6 4/7] configure: add libpmem support

2018-06-05 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 04:10:26PM +0800, junyan...@gmx.com wrote: > From: Junyan He > > Add a pair of configure options --{enable,disable}-libpmem to control > whether QEMU is compiled with PMDK libpmem [1]. > > QEMU may write to the host persistent memory (e.g. in vNVDIMM label > emulation

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-06-05 Thread Thomas Huth
On 01.06.2018 22:19, Farhan Ali wrote: > > > On 05/31/2018 11:21 PM, Thomas Huth wrote: >>> Just a question do we want to clear cfgbuf here, before calling >>> pxelinux_load_parse_cfg? >> That's theoretically not necessary. The buffer either gets populated >> with data, or the function errors

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-05 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 11:53:15PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 13:03:45 +0100 > Daniel P. Berrangé wrote: > > > When using --daemonize, the initial lead process will fork a child and > > then wait to be notified that setup is complete via a pipe, before it > > exits. When

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > } > > break; > > case QEMU_OPTION_preconfig: > > -

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 10:37:55AM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 21:56:47 -0300 > Eduardo Habkost wrote: > > On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > > [...] > > > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > > >

Re: [Qemu-devel] [PATCH v2 0/7] ramfb: simple boot framebuffer, no legacy vga

2018-06-05 Thread Laszlo Ersek
On 06/05/18 13:06, Gerd Hoffmann wrote: > Hi, > I could imagine an OvmfPkg-specific PCI capability that said, "all PCI drivers in OvmfPkg that could otherwise drive this device, ignore it -- another (platform) driver in OvmfPkg will pick it up instead". >>> >>> pci capability for

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 13:05, Laurent Vivier wrote: > Le 05/06/2018 à 12:52, Peter Maydell a écrit : >> On 5 June 2018 at 06:27, Richard Henderson >> wrote: >>> On Fedora 28, one can no longer build a static qemu. We depend on libraries >>> for which Fedora no longer ships static versions. >> >> Do

Re: [Qemu-devel] [RFC PATCH v2 1/7] tcg: add headers for non-target helpers

2018-06-05 Thread Thomas Huth
On 05.06.2018 12:39, Pavel Dovgalyuk wrote: > From: Pavel Dovgalyuk > > This patch adds functions and headers for adding the helpers from > the modules other than the target translators. > > Signed-off-by: Pavel Dovgalyuk > --- > include/exec/helper-register.h | 53 >

[Qemu-devel] [RFC PATCH qemu] qdev: Use "string" for QOM string properties

2018-06-05 Thread Alexey Kardashevskiy
For QOM properties QEMU uses "string", for example: {"execute": "qom-list", "arguments": {"path": "/machine"}} [{'return': [{'type': 'string', 'name': 'append'}, {'type': 'string', 'name': 'kernel'}] However for the device properties copied from DEVICE_CLASS(class)->props, "str" is used for a

Re: [Qemu-devel] [PATCH] hw/char/serial: Only retry if qemu_chr_fe_write returns 0

2018-06-05 Thread Paolo Bonzini
On 05/06/2018 09:54, Sergio Lopez wrote: > Only retry on serial_xmit if qemu_chr_fe_write returns 0, as this is the > only recoverable error. > > Retrying with any other scenario, in addition to being a waste of CPU > cycles, can compromise the Guest stability if by the vCPU issuing the > write

Re: [Qemu-devel] [PULL 00/17] Linux user for 3.0 patches

2018-06-05 Thread Peter Maydell
On 4 June 2018 at 16:19, Laurent Vivier wrote: > The following changes since commit 392fba9f583223786f844dce9b2e7f9a0ce0147a: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-travis-updates-010618-1' into staging (2018-06-01 > 17:32:30 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 06:27, Richard Henderson wrote: > On Fedora 28, one can no longer build a static qemu. We depend on libraries > for which Fedora no longer ships static versions. Do you mean you can't build the system binaries statically (that's never really been very supported), or that you

Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-06-05 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > This series doesn't seem to add anything to Documentation/ that > describes the API we make available to plugins. I'm a lot more > interested in reviewing the API that will be used by plugins > than I am in the implementation at this

[Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a flag to command definitions to allow them to be used in preconfig and check it. Signed-off-by: Dr. David Alan Gilbert --- monitor.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/monitor.c b/monitor.c index 6d0cec552e..50b95f41db

[Qemu-devel] [PATCH 5/6] hmp: add exit_preconfig

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add the exit_preconfig command to return to normality. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 15 +++ hmp.c | 7 +++ hmp.h | 1 + 3 files changed, 23 insertions(+) diff --git a/hmp-commands.hx

[Qemu-devel] [PATCH 2/6] hmp: Allow help on preconfig commands

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow the 'help' command in preconfig state but make it only list the preconfig commands. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 1 + monitor.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx

[Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Reenable HMP in preconfig mode; it's pretty easy and anyway I want to do a similar thing for OOB eventually. We'll want to enable more commands in preconfig mode to make it useful at some point. Dave Dr. David Alan Gilbert (6): hmp: Add flag for preconfig

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 02:23:56PM +0200, Laurent Vivier wrote: > Le 05/06/2018 à 14:14, Peter Maydell a écrit : > > On 5 June 2018 at 13:05, Laurent Vivier wrote: > >> Le 05/06/2018 à 12:52, Peter Maydell a écrit : > >>> On 5 June 2018 at 06:27, Richard Henderson > >>> wrote: > On Fedora

[Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Now we can cope with preconfig in HMP, reenable by reverting commit 71dc578e116599ea73c8a2a4e693134702ec0e83. Signed-off-by: Dr. David Alan Gilbert --- monitor.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Don't show the commands that aren't available. Signed-off-by: Dr. David Alan Gilbert --- monitor.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 7d1709c225..9b29787a52 100644 --- a/monitor.c +++

Re: [Qemu-devel] vIOMMU Posted-interrupt implementation - atomic operation?

2018-06-05 Thread Jintack Lim
Thanks, Kevin. On Tue, Jun 5, 2018 at 2:54 AM, Tian, Kevin wrote: >> From: Jintack Lim >> Sent: Friday, June 1, 2018 11:47 AM >> >> Hi, >> >> I'm implementing Posted-interrupt functionality in vIOMMU. According >> to Vt-d spec 5.2.3, IOMMU performs a coherent atomic read-modify-write >>

Re: [Qemu-devel] [PATCH] usb: update docs

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 13:52, Gerd Hoffmann wrote: > xhci is rock solid meanwhile. So move it up in the docs and feature it > as prefered usb host adapter, instead of the old shy version saying "you > might want try ...". > > While being at it rework the text on ehci and companion controllers too. >

[Qemu-devel] libvirt default machine-type guarantees? (was Re: [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Eduardo Habkost
(CCing libvir-list) On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > Add to that shortcuts like -cdrom > > > > stop working, > > > > > > Maybe is fixable. > > > > Already fixed for ages.

Re: [Qemu-devel] libvirt default machine-type guarantees? (was Re: [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > (CCing libvir-list) > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > Add to that shortcuts like -cdrom > > >

Re: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 08:39, Peter Xu wrote: > On Mon, Jun 04, 2018 at 04:29:28PM +0100, Peter Maydell wrote: >> Hi; this is v2 of my iommu patchset, which does: >> * support IOMMUs that are aware of memory transaction attributes and >>may generate different translations for different attributes

Re: [Qemu-devel] [PATCH] spapr: don't call KVM_PPC_CONFIGURE_V3_MMU if HPT is in userspace

2018-06-05 Thread Greg Kurz
On Tue, 5 Jun 2018 09:42:11 +1000 David Gibson wrote: > On Fri, May 25, 2018 at 02:54:12PM +0200, Greg Kurz wrote: > > Since the kernel commit "dbfcf3cb9c68 powerpc/64: Call H_REGISTER_PROC_TBL > > when running as a HPT guest on POWER9", a nested guest running with PR KVM > > hangs at boot: > >

Re: [Qemu-devel] [PATCH V6 6/7] migration/ram: Add check and info message to nvdimm post copy.

2018-06-05 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 04:10:28PM +0800, junyan...@gmx.com wrote: > From: Junyan He > > The nvdimm kind memory does not support post copy now. > We disable post copy if we have nvdimm memory and print some > log hint to user. > > Signed-off-by: Junyan He > --- > migration/ram.c | 9 +

Re: [Qemu-devel] [PATCH v4 00/19] reverse debugging

2018-06-05 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Pavel Dovgalyuk writes: > >> > >> > Ping? > >> > >> I started having a look but I ran into this straight away. First I > >> recorded a boot of the kernel:

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-05 Thread Thomas Huth
On 05.06.2018 11:19, Peter Maydell wrote: > On 5 June 2018 at 08:46, Cornelia Huck wrote: >> On Tue, 5 Jun 2018 06:33:22 +0200 >> Thomas Huth wrote: >>> On 05.06.2018 03:17, Alex Williamson wrote: On Mon, 4 Jun 2018 17:21:40 +0100 Peter Maydell wrote: > +Multiline comments blocks

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-05 Thread Peter Maydell
On 5 June 2018 at 08:46, Cornelia Huck wrote: > On Tue, 5 Jun 2018 06:33:22 +0200 > Thomas Huth wrote: >> On 05.06.2018 03:17, Alex Williamson wrote: >> > On Mon, 4 Jun 2018 17:21:40 +0100 >> > Peter Maydell wrote: >> >> +Multiline comments blocks should have a row of stars on the left >> >>

Re: [Qemu-devel] [PATCH 3/3] pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to the UUID

2018-06-05 Thread Cornelia Huck
On Tue, 5 Jun 2018 14:04:18 +0200 Thomas Huth wrote: > On 04.06.2018 11:36, Cornelia Huck wrote: > > On Wed, 30 May 2018 11:16:58 +0200 > > Thomas Huth wrote: > > > >> With the STSI instruction, we can get the UUID of the current VM instance, > >> so we can support loading pxelinux config

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Laurent Vivier
Le 05/06/2018 à 14:14, Peter Maydell a écrit : > On 5 June 2018 at 13:05, Laurent Vivier wrote: >> Le 05/06/2018 à 12:52, Peter Maydell a écrit : >>> On 5 June 2018 at 06:27, Richard Henderson >>> wrote: On Fedora 28, one can no longer build a static qemu. We depend on libraries

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-05 Thread Laurent Vivier
Le 05/06/2018 à 14:33, Peter Maydell a écrit : > On 5 June 2018 at 13:23, Laurent Vivier wrote: >> They are used by tests/qemu-iotests/socket_scm_helper and >> qemu-bridge-helper. >> >> Perhaps we can disable qemu-iotests with linux-user only and to not >> build qemu-bridge-helper when tools are

[Qemu-devel] [PATCH v2 0/2] add support for VCPU event states

2018-06-05 Thread Dongjiu Geng
support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception state, and support the state migration. change since v1: 1. update the code to fix the build errors Dongjiu Geng (2): kvm: sync linux headers target: arm: Add support for VCPU event states linux-headers/asm-arm64/kvm.h |

  1   2   3   4   >