Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-07-11 Thread Pavel Dovgalyuk
> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > On Tue, Jun 05, 2018 at 02:56:29PM +0300, Pavel Dovgalyuk wrote: > > > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > > > > > This series doesn't seem to add anything to Documentation/ that > > > describes the API we make available

[Qemu-devel] [PATCH] docker: Install more packages in centos7

2018-07-11 Thread Fam Zheng
This makes test-block work. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos7.docker | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker index 575de29a0a..83462b7205 100644 ---

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Thomas Huth
On 10.07.2018 08:50, Peter Maydell wrote: > On 9 July 2018 at 23:03, Thomas Huth wrote: >> On 09.07.2018 23:42, Peter Maydell wrote: >>> On 9 July 2018 at 22:03, Thomas Huth wrote: When trying to "device_add bcm2837" on a machine that is not suitable for this device, you can quickly

[Qemu-devel] [PATCH] iotests: 153: Fix dead code

2018-07-11 Thread Fam Zheng
This step was left behind my mistake. As suggested by the echoed text, the intention was to test two devices with the same image, with different options. The behavior should be the same as two QEMU processes. Complete it. Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 2 ++

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Cornelia Huck
On Wed, 11 Jul 2018 08:53:20 +0200 Thomas Huth wrote: > On 10.07.2018 17:24, Peter Krempa wrote: > > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: > >> So, from that I gather that a hard failure would be the easiest for > >> libvirt to detect (and everything else would become

[Qemu-devel] [Bug 1476183] Re: can not create 4 serial port on window (guest os)

2018-07-11 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU and Windows? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [Bug 1474263] Re: "Image format was not specified" warning should be suppressed for the vvfat (and probably nbd) driver

2018-07-11 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this bug with the latest version of QEMU? At least for vvfat, the warning message does not seem to occur anymore. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Thomas Huth
On 10.07.2018 17:24, Peter Krempa wrote: > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >> On Tue, 10 Jul 2018 16:39:31 +0200 >> Peter Krempa wrote: >>> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: On Tue, 10 Jul 2018 07:59:15 +0200 Markus Armbruster

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-11 Thread David Gibson
On Tue, Jul 10, 2018 at 05:14:53PM +1000, Alexey Kardashevskiy wrote: > On Tue, 10 Jul 2018 16:42:48 +1000 > David Gibson wrote: > > > On Tue, Jul 10, 2018 at 12:22:44PM +1000, Alexey Kardashevskiy wrote: > > > On Mon, 2 Jul 2018 16:26:44 +1000 > > > Alexey Kardashevskiy wrote: > > > > > >

[Qemu-devel] [PATCH v2] iotests: nbd: Stop qemu-nbd before remaking image

2018-07-11 Thread Fam Zheng
197 is one example where _make_test_img is used twice without stopping the NBD server in between. An error will occur like this: @@ -26,9 +26,13 @@ === Partial final cluster === +qemu-img: TEST_DIR/t.IMGFMT: Failed to get "resize" lock +Is another process using the image?

[Qemu-devel] [Bug 1476800] Re: Instant runtime error (Host: Windows 8.1 VM: WinXP ISO)

2018-07-11 Thread Thomas Huth
Looking through old bug tickets... which version of QEMU did you use here? Can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH] docker: Update debootstrap script after Debian migration from Alioth to Salsa

2018-07-11 Thread Fam Zheng
On Tue, 07/03 12:35, Philippe Mathieu-Daudé wrote: > This silents the following warning: > > Cloning into './debootstrap.git'... > warning: redirecting to > https://salsa.debian.org/installer-team/debootstrap.git/ > > See https://lists.debian.org/debian-devel-announce/2018/01/msg4.html

Re: [Qemu-devel] [PATCH v3 15/20] kvm: arm/arm64: Allow tuning the physical address size for VM

2018-07-11 Thread Suzuki K Poulose
On 10/07/18 18:03, Dave Martin wrote: On Tue, Jul 10, 2018 at 05:38:39PM +0100, Suzuki K Poulose wrote: On 09/07/18 14:37, Dave Martin wrote: On Mon, Jul 09, 2018 at 01:29:42PM +0100, Marc Zyngier wrote: On 09/07/18 12:23, Dave Martin wrote: [...] Wedging arguments into a few bits in the

Re: [Qemu-devel] [PATCH] ppc/xics: split ICP into icp-base and icp class

2018-07-11 Thread Greg Kurz
On Wed, 11 Jul 2018 11:28:02 +1000 David Gibson wrote: > On Tue, Jul 10, 2018 at 05:55:14PM +0200, Greg Kurz wrote: > > Recent cleanup in commit a028dd423ee6 causes QEMU to crash during CPU > > hotplug: > > > > (qemu) device_add host-spapr-cpu-core,id=core1,core-id=1 > > Segmentation fault

Re: [Qemu-devel] [PATCH v2] iotests: nbd: Stop qemu-nbd before remaking image

2018-07-11 Thread Kevin Wolf
Am 11.07.2018 um 08:40 hat Fam Zheng geschrieben: > 197 is one example where _make_test_img is used twice without stopping > the NBD server in between. An error will occur like this: > > @@ -26,9 +26,13 @@ > > === Partial final cluster === > > +qemu-img: TEST_DIR/t.IMGFMT: Failed

Re: [Qemu-devel] [PATCH] qemu-img: Document copy offloading implications with -S and -c

2018-07-11 Thread Kevin Wolf
Am 11.07.2018 um 03:22 hat Fam Zheng geschrieben: > Explicitly enabling zero detection or compression suppresses copy > offloading during convert. Document it. > > Suggested-by: Kevin Wolf > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v6 0/2] file-posix: specify expected filetypes

2018-07-11 Thread Kevin Wolf
Am 10.07.2018 um 19:00 hat John Snow geschrieben: > Tighten which types of files we'll allow you to specify for the various > file drivers (file, host_device, host_cdrom). Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] fix gdbserver_state pointer validation

2018-07-11 Thread stephane duverger
To reach gdb_set_stop_cpu() with gdbserver_state == NULL, you previously > entered gdb_vm_state_change() with and use CPUState *cpu = > gdbserver_state->c_cpu = NULL deref, which shouldn't happen. > Also in gdb_set_stop_cpu() you finally call cpu_single_step(cpu=crap) > which then deref

Re: [Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is really needed

2018-07-11 Thread Peter Xu
On Thu, Jun 28, 2018 at 05:33:58PM +0800, Xiao Guangrong wrote: > > > On 06/19/2018 03:36 PM, Peter Xu wrote: > > On Mon, Jun 04, 2018 at 05:55:15PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > Try to hold src_page_req_mutex only if the queue is not > > > empty

Re: [Qemu-devel] [PATCH v2 2/2] memory: fix possible NULL pointer dereference

2018-07-11 Thread Dima Stepanov
Gentle ping. CCing Paolo Bonzini. Regards, Dima. On Tue, Jun 19, 2018 at 05:12:16PM +0300, Dima Stepanov wrote: > Ping. > > Regards, Dima. > > On Wed, Jun 13, 2018 at 11:19:55AM +0300, Dima Stepanov wrote: > > In the memory_region_do_invalidate_mmio_ptr() routine the section > > variable is

Re: [Qemu-devel] [PATCH v3 15/20] kvm: arm/arm64: Allow tuning the physical address size for VM

2018-07-11 Thread Dave Martin
On Wed, Jul 11, 2018 at 10:05:50AM +0100, Suzuki K Poulose wrote: > On 10/07/18 18:03, Dave Martin wrote: > >On Tue, Jul 10, 2018 at 05:38:39PM +0100, Suzuki K Poulose wrote: > >>On 09/07/18 14:37, Dave Martin wrote: > >>>On Mon, Jul 09, 2018 at 01:29:42PM +0100, Marc Zyngier wrote: > On

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Paolo Bonzini
On 10/07/2018 17:50, Stefan Hajnoczi wrote: > The ->pre_plug() callback is invoked before the device is realized. The > ->plug() callback is invoked when the device is being realized but > before it is reset. > > This patch adds a ->post_plug() callback which is invoked after the > device has

Re: [Qemu-devel] [PATCH] iotests: 153: Fix dead code

2018-07-11 Thread Kevin Wolf
Am 11.07.2018 um 09:05 hat Fam Zheng geschrieben: > This step was left behind my mistake. As suggested by the echoed text, > the intention was to test two devices with the same image, with > different options. The behavior should be the same as two QEMU > processes. Complete it. > >

Re: [Qemu-devel] [qemu-s390x] [RFC 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2018-07-11 Thread Thomas Huth
On 05.07.2018 19:25, Jason J. Herne wrote: > From: "Jason J. Herne" You might want to do a --reset-author of this patch to get rid of this "From:" line... > Add bootindex property and iplb data for vfio-ccw devices. This allows us to > forward boot information into the bios for vfio-ccw

Re: [Qemu-devel] [PATCH V5] qemu-img: align result of is_allocated_sectors

2018-07-11 Thread Kevin Wolf
Am 10.07.2018 um 22:16 hat Peter Lieven geschrieben: > > > > Am 10.07.2018 um 17:31 schrieb Kevin Wolf : > > > > Am 10.07.2018 um 17:05 hat Peter Lieven geschrieben: > >> We currently don't enforce that the sparse segments we detect during > >> convert are > >> aligned. This leads to

[Qemu-devel] [PATCH for-3.0] target/arm: Fix LD1W and LDFF1W (scalar plus vector)

2018-07-11 Thread Richard Henderson
'I' was being double-incremented; correctly within the inner loop and incorrectly within the outer loop. Signed-off-by: Richard Henderson --- Fixes a SIGSEGV within one of these generated helpers, exposed by an armclang vectorized code sample. r~ --- target/arm/sve_helper.c | 4 ++-- 1 file

Re: [Qemu-devel] [PATCH for-3.0] target/arm: Fix LD1W and LDFF1W (scalar plus vector)

2018-07-11 Thread Laurent Desnogues
Hello, On Wed, Jul 11, 2018 at 12:39 PM, Richard Henderson wrote: > 'I' was being double-incremented; correctly within the inner loop > and incorrectly within the outer loop. > > Signed-off-by: Richard Henderson I didn't try to apply the patch but line numbers look wrong. I guess this should

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-11 Thread Cornelia Huck
On Tue, 10 Jul 2018 17:07:37 -0700 Siwei Liu wrote: > On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: > >> The plan is to enable group ID based matching in the first place rather > >> than > >> match by MAC, the latter

[Qemu-devel] [PATCH] linux-user: ppc64: use the correct values for F_*LK64s

2018-07-11 Thread Shivaprasad G Bhat
Qemu includes the glibc headers for the host defines and target headers are part of the qemu source themselves. The glibc has the F_GETLK64, F_SETLK64 and F_SETLKW64 defined to 12, 13 and 14 for all archs(generic) in sysdeps/unix/sysv/linux/bits/fcntl-linux.h. The linux kernel generic definition

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

2018-07-11 Thread Kevin Wolf
Am 10.07.2018 um 16:02 hat Marc-André Lureau geschrieben: > Hi > > On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: > > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: > >> handle_qmp_command() reports JSON syntax errors right away. This is > >> wrong when OOB is enabled, because

Re: [Qemu-devel] [qemu-s390x] [RFC 03/15] s390-bios: decouple common boot logic from virtio

2018-07-11 Thread Thomas Huth
On 05.07.2018 19:25, Jason J. Herne wrote: > From: "Jason J. Herne" git commit --amend --reset-author ? > Create a boot_setup function to handle getting boot information from > the machine/hypervisor. This decouples common boot logic from the > virtio code path and allows us to make use of it

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-11 Thread Alexey Kardashevskiy
On Wed, 11 Jul 2018 16:26:19 +1000 David Gibson wrote: > On Tue, Jul 10, 2018 at 05:14:53PM +1000, Alexey Kardashevskiy wrote: > > On Tue, 10 Jul 2018 16:42:48 +1000 > > David Gibson wrote: > > > > > On Tue, Jul 10, 2018 at 12:22:44PM +1000, Alexey Kardashevskiy wrote: > > > > On Mon, 2

[Qemu-devel] [PATCH v2 2/4] tests/vm: Pass verbose flag into VM make commands

2018-07-11 Thread Fam Zheng
Our Makefile has: vm-build-%: tests/vm/%.img $(call quiet-command, \ $(SRC_PATH)/tests/vm/$* \ $(if $(V)$(DEBUG), --debug) \ $(if $(DEBUG), --interactive) \ the intention of which is to let the make command in VM have V=1 if V=1 is set. We

Re: [Qemu-devel] [PATCH] docker: Install more packages in centos7

2018-07-11 Thread Fam Zheng
On Wed, 07/11 14:58, Fam Zheng wrote: > This makes test-block work. > > Signed-off-by: Fam Zheng Queued, thanks.

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:31AM +0200, Emanuele Giuseppe Esposito wrote: > -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc) > +static void *qpci_get_driver(void *obj, const char *interface) > { > -QPCIBusPC *ret = g_new0(QPCIBusPC, 1); > +QPCIBusPC *qpci = obj; > +if

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:28, Stefan Hajnoczi wrote: >> + * build_driver_cmd_line(): builds the command line for the driver >> + * @node. The node name must be a valid qemu identifier, since it >> + * will be used to build the command line. >> + * >> + * It is also possible to pass an optional @args that

Re: [Qemu-devel] [PATCH 6/7] tests/qgraph: gtest integration

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:35AM +0200, Emanuele Giuseppe Esposito wrote: > Add main executable that takes care of starting the framework, create the > nodes, set the available drivers/machines, discover the path and run tests. This is elegant, I like it. > Signed-off-by: Emanuele Giuseppe

Re: [Qemu-devel] [Qemu-arm] [PATCH 6/6] target/arm: Allow execution from small regions

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/10/2018 01:00 PM, Peter Maydell wrote: > Now that we have full support for small regions, including execution, > we can remove the workarounds where we marked all small regions as > non-executable for the M-profile MPU and SAU. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: > +/** > + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. > +qos_add_test("sdhci-test", "sdhci", test_machine);

Re: [Qemu-devel] [PATCH v2 2/4] tests/vm: Pass verbose flag into VM make commands

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 11:18 AM, Fam Zheng wrote: > Our Makefile has: > > vm-build-%: tests/vm/%.img > $(call quiet-command, \ > $(SRC_PATH)/tests/vm/$* \ > $(if $(V)$(DEBUG), --debug) \ > $(if $(DEBUG), --interactive) \ > > the intention of which is to let

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2018-07-11 Thread M0Rf30
In order not to upload a big image I can say that you can generate the image with this tool https://github.com/M0Rf30/simonpi the initrd used is in the arch linux arm boot partition generated by the previous referenced tool. -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:59, Stefan Hajnoczi wrote: >> +machine->obj.get_device = raspi2_get_device; >> +machine->obj.destructor = raspi2_destroy; >> +qos_create_sdhci_mm(>sdhci, 0x3f30, &(QSDHCIProperties) { >> +.version = 3, >> +.baseclock = 52, >> +.capab.sdma =

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Igor Mammedov
On Wed, 11 Jul 2018 15:32:12 +0200 Paolo Bonzini wrote: > On 11/07/2018 15:29, Stefan Hajnoczi wrote: > >> if (dev->hotplugged) { > >> device_reset(dev); > >> + > >> +if (hotplug_ctrl) { > > In the final patch I will move this out of if (dev->hotplugged) since

[Qemu-devel] [PATCH v2 0/4] Add a CentOS test image to run docker tests

2018-07-11 Thread Fam Zheng
v2: Drop archive-source.sh changes. The new test depends on the iotests nbd fix I posted today to pass. Docker testing on patchew has long suffered from 'make check' hangings. The cleanness of VM testing is the cure. Now let's add a CentOS 7 image to run the tests. It's purely ad-hoc, but

[Qemu-devel] [PATCH v2 3/4] tests: Allow overriding archive path with SRC_ARCHIVE

2018-07-11 Thread Fam Zheng
In VM based tests, the source archive is created in host, we don't have to run archive-source.sh again, as it complicates the Makefile and scripts. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 1/4] tests: Add an option for snapshot (default: off)

2018-07-11 Thread Fam Zheng
Not using snapshot has the benefit of automatically persisting useful test harnesses, such as docker images and ccache database. Although it will lose some cleanness, it is imaginably useful for patchew. Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 7 ++- 1 file changed, 6

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/6] accel/tcg: Return -1 for execution from MMIO regions in get_page_addr_code()

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/10/2018 01:00 PM, Peter Maydell wrote: > Now that all the callers can handle get_page_addr_code() returning -1, > remove all the code which tries to handle execution from MMIO regions > or small-MMU-region RAM areas. This will mean that we can correctly > execute from these areas, rather

Re: [Qemu-devel] [PATCH] seccomp: allow sched_setscheduler() with SCHED_IDLE policy

2018-07-11 Thread Eduardo Otubo
On 10/07/2018 - 16:55:57, Marc-André Lureau wrote: > Current and upcoming mesa releases rely on a shader disk cash. It uses > a thread job queue with low priority, set with > sched_setscheduler(SCHED_IDLE). However, that syscall is rejected by > the "resourcecontrol" seccomp qemu filter. > >

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:49, Stefan Hajnoczi wrote: > On Mon, Jul 09, 2018 at 11:11:31AM +0200, Emanuele Giuseppe Esposito wrote: >> -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc) >> +static void *qpci_get_driver(void *obj, const char *interface) >> { >> -QPCIBusPC *ret =

Re: [Qemu-devel] [PATCH v2 4/4] tests: Add centos VM testing

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Fam, On 07/11/2018 11:18 AM, Fam Zheng wrote: > This one does docker testing in the VM. It is intended to replace the > native docker testing on patchew testers. > > Signed-off-by: Fam Zheng > --- > tests/vm/Makefile.include | 2 +- > tests/vm/centos | 84

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 10:07:31AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > > Every time we create new PC machine-types in QEMU, the defaults > > for SMBIOS fields change unnecessarily because the version field > > defaults to

Re: [Qemu-devel] [PATCH] linux-user: ppc64: use the correct values for F_*LK64s

2018-07-11 Thread Laurent Vivier
Le 11/07/2018 à 15:04, Laurent Vivier a écrit : > Le 11/07/2018 à 12:55, Shivaprasad G Bhat a écrit : >> Qemu includes the glibc headers for the host defines and target headers are >> part of the qemu source themselves. The glibc has the F_GETLK64, F_SETLK64 >> and F_SETLKW64 defined to 12, 13 and

[Qemu-devel] [PATCH] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread

2018-07-11 Thread Yongji Xie
According to KVM API Documentation, we should only run vcpu ioctls from the same thread that was used to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL ioctl consistent with the Documentation. No functional change. Signed-off-by: Yongji Xie Signed-off-by: Chai Wen --- hw/i386/kvm/clock.c

Re: [Qemu-devel] [PATCH v3] accel: forbid early use of kvm_enabled() and friends

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/05/2018 04:54 AM, Greg Kurz wrote: > It is unsafe to rely on *_enabled() helpers before the accelerator has > been initialized, ie, accel_init_machine() has succeeded, because they > always return false. But it is still possible to end up calling them > indirectly by inadvertance, and cause

Re: [Qemu-devel] [BUG] checkpatch.pl hangs on target/mips/msa_helper.c

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 09:36 AM, Stefan Hajnoczi wrote: > On Wed, Jul 04, 2018 at 03:35:18PM +, Aleksandar Markovic wrote: >> If checkpatch.pl is applied (using switch "-f") on file >> target/mips/msa_helper.c, it will hang. >> >> There is a workaround for this particular file: >> >> These lines in

Re: [Qemu-devel] [PATCH] fix gdbserver_state pointer validation

2018-07-11 Thread Philippe Mathieu-Daudé
Hi Stephane, On 07/11/2018 04:52 AM, stephane duverger wrote: > To reach gdb_set_stop_cpu() with gdbserver_state == NULL, you previously >> entered gdb_vm_state_change() with and use CPUState *cpu = >> gdbserver_state->c_cpu = NULL deref, which shouldn't happen. >> Also in gdb_set_stop_cpu() you

[Qemu-devel] [Bug 1719339] Re: serial8250: too much work for irq3

2018-07-11 Thread Paul Gear
** Tags added: canonical-is -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719339 Title: serial8250: too much work for irq3 Status in QEMU: New Bug description: It's know issue and sometimes

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-11 Thread Emanuele
On 07/11/2018 04:00 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:29AM +0200, Emanuele Giuseppe Esposito wrote: Basic framework steps are the following: - All nodes and edges are created in their respective machine/driver/test files - The framework starts QEMU and asks for a list of

[Qemu-devel] [PATCH v2 4/4] tests: Add centos VM testing

2018-07-11 Thread Fam Zheng
This one does docker testing in the VM. It is intended to replace the native docker testing on patchew testers. Signed-off-by: Fam Zheng --- tests/vm/Makefile.include | 2 +- tests/vm/centos | 84 +++ 2 files changed, 85 insertions(+), 1

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:30AM +0200, Emanuele Giuseppe Esposito wrote: > +/* Graph Edge.*/ > +struct QOSGraphEdge { > +QOSEdgeType type; > +char *dest; > +char *arg; /* just for CONTAIS and CONSUMED_BY */ CONTAINS? > +/** > + * remove_node(): removes a node @val from the nodes

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:33AM +0200, Emanuele Giuseppe Esposito wrote: > Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so > its constructor must take care of setting it properly when called. > > Signed-off-by: Emanuele Giuseppe Esposito > --- >

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Igor Mammedov
On Tue, 10 Jul 2018 16:50:36 +0100 Stefan Hajnoczi wrote: > The ->pre_plug() callback is invoked before the device is realized. The > ->plug() callback is invoked when the device is being realized but > before it is reset. > > This patch adds a ->post_plug() callback which is invoked after

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:29AM +0200, Emanuele Giuseppe Esposito wrote: > This work is being done as Google Summer of Code 2018 project for QEMU, > my mentors are Paolo Bonzini and Laurent Vivier. > Additional infos on the project can be found at: >

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-11 Thread Emanuele
On 07/11/2018 04:49 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:31AM +0200, Emanuele Giuseppe Esposito wrote: -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc) +static void *qpci_get_driver(void *obj, const char *interface) { -QPCIBusPC *ret = g_new0(QPCIBusPC,

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Sebastian Bauer
Am 2018-07-11 17:48, schrieb Eduardo Habkost: "none" looked like a false positive when I first looked, but now I think it's not. Shouldn't it set default_display="none"? I think that there is some other logic burried that these machine doesn't get a graphics display. But overall it is indeed

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Peter Maydell
On 11 July 2018 at 17:12, Eduardo Habkost wrote: > On Wed, Jul 11, 2018 at 09:21:48AM +0200, Thomas Huth wrote: >> On 10.07.2018 08:50, Peter Maydell wrote: >> > On 9 July 2018 at 23:03, Thomas Huth wrote: >> >> On 09.07.2018 23:42, Peter Maydell wrote: >> >>> On 9 July 2018 at 22:03, Thomas

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Paolo Bonzini
On 09/07/2018 23:03, Thomas Huth wrote: > > The problem is that qdev_set_parent_bus() from instance_init adds a link > to the child devices which is not valid anymore after the device init > failed. Thus the qdev_set_parent_bus() must rather be done in the realize > function instead. The

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Paolo Bonzini
On 10/07/2018 08:50, Peter Maydell wrote: >>> Yuck. The real problem here is that we're still requiring the >>> code that creates these QOM devices to manually set the parent >>> in the first place. It's not surprising that we don't get it right >>> (either parenting in the wrong place or not at

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Emanuele
On 07/11/2018 05:15 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: +/** + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. Paolo

Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()

2018-07-11 Thread Laurent Vivier
Le 11/07/2018 à 18:40, Laurent Vivier a écrit : > The value given by mmap_find_vma_reserved() is used with mmap(), > so it is needed to be aligned with the host page size. > > Since commit 18e80c55bb, reserved_va is only aligned to TARGET_PAGE_SIZE, > and it works well if this size is greater or

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 07:20:42PM +0200, Paolo Bonzini wrote: > On 09/07/2018 23:03, Thomas Huth wrote: > > > > The problem is that qdev_set_parent_bus() from instance_init adds a link > > to the child devices which is not valid anymore after the device init > > failed. Thus the

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 07:00:54PM +0200, Sebastian Bauer wrote: > Am 2018-07-11 17:48, schrieb Eduardo Habkost: > > "none" looked like a false positive when I first looked, but now > > I think it's not. Shouldn't it set default_display="none"? > > I think that there is some other logic burried

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Thomas Huth
On 11.07.2018 19:20, Paolo Bonzini wrote: > On 09/07/2018 23:03, Thomas Huth wrote: >> >> The problem is that qdev_set_parent_bus() from instance_init adds a link >> to the child devices which is not valid anymore after the device init >> failed. Thus the qdev_set_parent_bus() must rather be done

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-11 Thread Thomas Huth
On 11.07.2018 19:21, Paolo Bonzini wrote: > On 10/07/2018 08:50, Peter Maydell wrote: Yuck. The real problem here is that we're still requiring the code that creates these QOM devices to manually set the parent in the first place. It's not surprising that we don't get it right

[Qemu-devel] [PULL 1/1] monitor: fix double-free of request error

2018-07-11 Thread Markus Armbruster
From: Marc-André Lureau qmp_error_response() will free the given error. Fix double-free in later qmp_request_free(). Signed-off-by: Marc-André Lureau Message-Id: <20180705164201.9853-1-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1

[Qemu-devel] [PULL 0/1] Monitor patches for 2018-07-11

2018-07-11 Thread Markus Armbruster
The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc: Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-07-11 for you to fetch changes up to

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 06:19:33PM +0200, Paolo Bonzini wrote: > On 11/07/2018 18:00, Eduardo Habkost wrote: > >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, > >> CPUState *cs, > >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of > >> *

Re: [Qemu-devel] [BUG] checkpatch.pl hangs on target/mips/msa_helper.c

2018-07-11 Thread Stefan Hajnoczi
On Wed, Jul 04, 2018 at 03:35:18PM +, Aleksandar Markovic wrote: > If checkpatch.pl is applied (using switch "-f") on file > target/mips/msa_helper.c, it will hang. > > There is a workaround for this particular file: > > These lines in msa_helper.c: > > uint## BITS ##_t S = _S, T

Re: [Qemu-devel] [Qemu-discuss] IRQ per CPU

2018-07-11 Thread Stefan Hajnoczi
On Thu, Jul 05, 2018 at 03:16:44PM +0800, Dongli Zhang wrote: > > > On 07/05/2018 12:12 PM, Probir Roy wrote: > >> Does 'per CPU basis' indicates irq per cpu, or irq per device queue? > > > > IRQ per CPU core, meaning that IRQ will be raised at and served by > > that CPU. Does IRQ per queue

Re: [Qemu-devel] [RFC v3 2/2] tests: Add ARMv6-M reserved register test

2018-07-11 Thread Stefan Hajnoczi
On Fri, Jul 06, 2018 at 03:55:14PM +0100, Peter Maydell wrote: > On 5 July 2018 at 23:21, Julia Suvorova wrote: > > Check that reserved SCS registers return 0 at read, > > and writes are ignored. > > > > Based-on: <20180627143815.1829-1-j...@jms.id.au> > > Based-on:

Re: [Qemu-devel] qemu-nbd vs 'simple' trace backend vs iotest 147

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 03:45:49PM +0200, Cornelia Huck wrote: > Hi, > > I recently noticed that iotest 147 was hanging on my laptop, but worked > fine on my s390x LPAR. Turned out that the architecture was a red > herring; on both platforms, things fail with the 'simple' trace backend > and work

Re: [Qemu-devel] [PATCH] nvic: Change NVIC to support ARMv6-M

2018-07-11 Thread Stefan Hajnoczi
On Tue, Jul 10, 2018 at 06:33:35PM +0300, Julia Suvorova via Qemu-devel wrote: > The differences from ARMv7-M NVIC are: > * ARMv6-M only supports up to 32 external interrupts >(configurable feature already). The ICTR is reserved. > * Active Bit Register is reserved. > * ARMv6-M supports

Re: [Qemu-devel] [PATCH] nvic: Change NVIC to support ARMv6-M

2018-07-11 Thread Peter Maydell
On 11 July 2018 at 14:25, Stefan Hajnoczi wrote: > On Tue, Jul 10, 2018 at 06:33:35PM +0300, Julia Suvorova via Qemu-devel wrote: >> The differences from ARMv7-M NVIC are: >> * ARMv6-M only supports up to 32 external interrupts >>(configurable feature already). The ICTR is reserved. >> *

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Kashyap Chamarthy
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote: [...] > Who is, in general, testing which libvirt version? I can think of: > - libvirt developers, which will probably run libvirt current git, but > more likely a released QEMU? > - QEMU (and other related tools) developers, who

Re: [Qemu-devel] [PATCH v2 2/2] memory: fix possible NULL pointer dereference

2018-07-11 Thread Peter Maydell
On 11 July 2018 at 14:47, Philippe Mathieu-Daudé wrote: > Hi Dima, > > On 07/11/2018 05:34 AM, Dima Stepanov wrote: >> Gentle ping. CCing Paolo Bonzini. >> >> Regards, Dima. >> >> On Tue, Jun 19, 2018 at 05:12:16PM +0300, Dima Stepanov wrote: >>> Ping. >>> >>> Regards, Dima. >>> >>> On Wed, Jun

[Qemu-devel] [Bug 1474263] Re: "Image format was not specified" warning should be suppressed for the vvfat (and probably nbd) driver

2018-07-11 Thread Max Reitz
Yes, it does appear, you just need to make vvfat rw: $ qemu-system-x86_64 -drive file.driver=vvfat,file.dir=foo,file.rw=on vvfat foo chs 1024,16,63 WARNING: Image format was not specified for 'json:{"dir": "foo", "driver": "vvfat", "rw": "on"}' and probing guessed raw. Automatically

Re: [Qemu-devel] [PATCH v3] accel: forbid early use of kvm_enabled() and friends

2018-07-11 Thread Stefan Hajnoczi
On Thu, Jul 05, 2018 at 09:54:30AM +0200, Greg Kurz wrote: > It is unsafe to rely on *_enabled() helpers before the accelerator has > been initialized, ie, accel_init_machine() has succeeded, because they > always return false. But it is still possible to end up calling them > indirectly by

Re: [Qemu-devel] [RFC PATCH 5/6] virt-acpi-build: add PPTT table

2018-07-11 Thread Andrew Jones
On Wed, Jul 04, 2018 at 02:49:22PM +0200, Andrew Jones wrote: > The ACPI PPTT table supports topology descriptions for ACPI > guests. Note, while a DT boot Linux guest with a non-flat CPU > topology will see socket and core IDs being sequential integers > starting from zero, e.g. with -smp

Re: [Qemu-devel] [PATCH v2 1/3] hw/arm: extract ARM M Profile base class from ARMv7-M

2018-07-11 Thread Stefan Hajnoczi
On Thu, Jul 05, 2018 at 04:49:22PM +0100, Peter Maydell wrote: > On 5 July 2018 at 16:45, Peter Maydell wrote: > > On 30 June 2018 at 10:13, Stefan Hajnoczi wrote: > >> The ARMv7-M code is largely similar to what other M Profile CPUs need. > >> Extract the common M Profile aspects into the

Re: [Qemu-devel] qemu-nbd vs 'simple' trace backend vs iotest 147

2018-07-11 Thread Cornelia Huck
On Wed, 11 Jul 2018 14:06:17 +0100 Stefan Hajnoczi wrote: > On Mon, Jul 09, 2018 at 03:45:49PM +0200, Cornelia Huck wrote: > > Hi, > > > > I recently noticed that iotest 147 was hanging on my laptop, but worked > > fine on my s390x LPAR. Turned out that the architecture was a red > > herring;

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

2018-07-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.07.2018 um 16:02 hat Marc-André Lureau geschrieben: >> Hi >> >> On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: >> > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: >> >> handle_qmp_command() reports JSON syntax errors right away. This is >> >> wrong

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle-groups: fix hang when group member leaves

2018-07-11 Thread Stefan Hajnoczi
On Wed, Jul 04, 2018 at 03:54:10PM +0100, Stefan Hajnoczi wrote: Sorry you weren't CCed originally, Berto. This one is for you! :) > Throttle groups consist of members sharing one throttling state > (including bps/iops limits). Round-robin scheduling is used to ensure > fairness. If a group

Re: [Qemu-devel] [PATCH] linux-user: ppc64: use the correct values for F_*LK64s

2018-07-11 Thread Laurent Vivier
Le 11/07/2018 à 12:55, Shivaprasad G Bhat a écrit : > Qemu includes the glibc headers for the host defines and target headers are > part of the qemu source themselves. The glibc has the F_GETLK64, F_SETLK64 > and F_SETLKW64 defined to 12, 13 and 14 for all archs(generic) in >

Re: [Qemu-devel] [RFC v3 06/15] hw/arm/virt: Allocate device_memory

2018-07-11 Thread Igor Mammedov
On Thu, 5 Jul 2018 16:27:05 +0200 Auger Eric wrote: > Hi Shameer, > > On 07/05/2018 03:19 PM, Shameerali Kolothum Thodi wrote: > > > >> -Original Message- > >> From: Auger Eric [mailto:eric.au...@redhat.com] > >> Sent: 05 July 2018 13:18 > >> To: David Hildenbrand ;

[Qemu-devel] [PATCH] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread

2018-07-11 Thread Yongji Xie
According to KVM API Documentation, we should only run vcpu ioctls from the same thread that was used to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL ioctl consistent with the Documentation. No functional change. Signed-off-by: Yongji Xie Signed-off-by: Chai Wen --- hw/i386/kvm/clock.c

Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback

2018-07-11 Thread Stefan Hajnoczi
On Tue, Jul 10, 2018 at 04:50:36PM +0100, Stefan Hajnoczi wrote: > The ->pre_plug() callback is invoked before the device is realized. The > ->plug() callback is invoked when the device is being realized but > before it is reset. > > This patch adds a ->post_plug() callback which is invoked

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Document copy offloading implications with -S and -c

2018-07-11 Thread Stefan Hajnoczi
On Wed, Jul 11, 2018 at 09:22:27AM +0800, Fam Zheng wrote: > Explicitly enabling zero detection or compression suppresses copy > offloading during convert. Document it. > > Suggested-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > qemu-img.texi | 6 -- > 1 file changed, 4 insertions(+),

Re: [Qemu-devel] qemu-nbd vs 'simple' trace backend vs iotest 147

2018-07-11 Thread Cornelia Huck
On Wed, 11 Jul 2018 15:15:45 +0200 Cornelia Huck wrote: > On Wed, 11 Jul 2018 14:06:17 +0100 > Stefan Hajnoczi wrote: > > > On Mon, Jul 09, 2018 at 03:45:49PM +0200, Cornelia Huck wrote: > > > Hi, > > > > > > I recently noticed that iotest 147 was hanging on my laptop, but worked > > > fine

[Qemu-devel] [Bug 1781211] [NEW] HAXM acceleration does not work at all.

2018-07-11 Thread Dmitriy via Qemu-devel
Public bug reported: I have qemu windows build 2.12.90, haxm 7.2.0. Ubuntu, nor arch linux does not works when i turn on hax acceleration. Permanent kernel panics, black screen freezing and other crashes happens when i run qemu. Qemu crashed with hax - when i ran it from iso. It crashed on

Re: [Qemu-devel] [PATCH] docker: Install more packages in centos7

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 03:58 AM, Fam Zheng wrote: > This makes test-block work. > > Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/centos7.docker | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/docker/dockerfiles/centos7.docker >

  1   2   >