Re: [Qemu-devel] [PATCH 05/12] migration: show the statistics of compression

2018-07-18 Thread Xiao Guangrong
On 07/17/2018 03:01 AM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: On 06/14/2018 12:25 AM, Dr. David Alan Gilbert wrote: } static void migration_bitmap_sync(RAMState *rs) @@ -1412,6 +1441,9 @@ static void flush_compressed_data(RAMState *rs)

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Cornelia Huck
On Wed, 18 Jul 2018 10:50:01 +0200 David Hildenbrand wrote: > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index cfdbccf46d..604898a882 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -716,6 +716,14 @@ CpuModelBaselineInfo >

Re: [Qemu-devel] [PATCH for-3.0] qapi: Make 'allow-oob' optional in SchemaInfoCommand

2018-07-18 Thread Peter Xu
On Wed, Jul 18, 2018 at 11:05:57AM +0200, Markus Armbruster wrote: > Making 'allow-oob' optional in SchemaInfoCommand permits omitting it > in the common case. Shrinks query-qmp-schema's output from 122.1KiB > to 118.6KiB for me. > > Note that out-of-band execution is still experimental (you

[Qemu-devel] [PATCH v2] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread David Hildenbrand
Usually, when baselining two CPU models, whereby one of them has base CPU features disabled (e.g. z14-base,msa=off), we fallback to an older model that did not have these features in the base model. We always try to create a "sane" CPU model (as far as possible), and one part of it is that

Re: [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements

2018-07-18 Thread Cornelia Huck
On Wed, 18 Jul 2018 14:48:03 +0800 Peter Xu wrote: > On Tue, Jul 17, 2018 at 04:47:31PM -0600, Alex Williamson wrote: > > Directly assigned vfio devices have never been compatible with > > ballooning. Zapping MADV_DONTNEED pages happens completely > > independent of vfio page pinning and IOMMU

[Qemu-devel] [PATCH for 3.0 4/4] tests: fix TLS handshake failure with TLS 1.3

2018-07-18 Thread Daniel P . Berrangé
When gnutls negotiates TLS 1.3 instead of 1.2, the order of messages sent by the handshake changes. This exposed a logic bug in the test suite which caused us to wait for the server to see handshake completion, but not wait for the client to see completion. The result was the client didn't receive

Re: [Qemu-devel] [libvirt] CPU Support

2018-07-18 Thread Daniel P . Berrangé
On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: > Hi, > > I've been looking at the CPU list and although I see lots of CPU's, I > cannot find 2 CPU families: > > * AMD Ryzen > * AMD Threadripper > > Although EPYC has been added recently. > > Are there any missing details which

[Qemu-devel] [PATCH] file-posix: Skip effectiveless OFD lock operations

2018-07-18 Thread Fam Zheng
If we know we've already locked the bytes, don't do it again; similarly don't unlock a byte if we haven't locked it. This doesn't change the behavior, but fixes a corner case explained below. Libvirt had an error handling bug that an image can get its (ownership, file mode, SELinux) permissions

Re: [Qemu-devel] [PATCH 0/9] monitor: enable OOB by default

2018-07-18 Thread Peter Xu
On Tue, Jul 17, 2018 at 08:08:55PM +0800, Peter Xu wrote: [...] > > > > Whatever we don't address right away we should at least mark FIXME in > > the source code. > > > > Assuming my list is complete, and my assessments correct, then we're > > quite close to the point where we can enable OOB.

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread David Hildenbrand
On 18.07.2018 10:44, Christian Borntraeger wrote: > > > On 07/18/2018 10:40 AM, David Hildenbrand wrote: >> On 18.07.2018 10:39, Christian Borntraeger wrote: >>> >>> >>> On 07/18/2018 10:24 AM, David Hildenbrand wrote: Usually, when baselining two CPU models, whereby one of them has base

[Qemu-devel] [PATCH for-3.0] qapi: Make 'allow-oob' optional in SchemaInfoCommand

2018-07-18 Thread Markus Armbruster
Making 'allow-oob' optional in SchemaInfoCommand permits omitting it in the common case. Shrinks query-qmp-schema's output from 122.1KiB to 118.6KiB for me. Note that out-of-band execution is still experimental (you have to configure the monitor with x-oob=on to use it). Signed-off-by: Markus

[Qemu-devel] [PATCH for 3.0 0/4] Multiple fixes and improvements to TLS tests

2018-07-18 Thread Daniel P . Berrangé
The switch to enable TLS 1.3 protocol support in GNUTLS in Fedora exposed a subtle flaw in our TLS unit tests. This was horrible to debug because of bad error reporting in our tests which caused all the error messages to be irretrievably lost instead of displayed on stderr. Daniel P. Berrangé

[Qemu-devel] [PATCH for 3.0 1/4] tests: call qcrypto_init instead of gnutls_global_init

2018-07-18 Thread Daniel P . Berrangé
Calling qcrypto_init ensures that all relevant initialization is done. In particular this honours the debugging settings and thread settings. Signed-off-by: Daniel P. Berrangé --- tests/crypto-tls-x509-helpers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH for 3.0 2/4] tests: don't silence error reporting for all tests

2018-07-18 Thread Daniel P . Berrangé
The test-vmstate test is a bit chatty because it triggers various expected failure scenarios and the code in question uses error_report instead of accepting 'Error **errp' parameters. To silence this test the stubs for error_vprintf() were changed to send errors via g_test_message() instead of

[Qemu-devel] [PATCH v1 16/17] migration: move the device state saving logic to a separate function

2018-07-18 Thread Denis Plotnikov
The logic being split will be reused by the background snapshot. Signed-off-by: Denis Plotnikov --- migration/savevm.c | 91 +- migration/savevm.h | 2 + 2 files changed, 52 insertions(+), 41 deletions(-) diff --git a/migration/savevm.c

[Qemu-devel] [PATCH v1 02/17] bitops: add some atomic versions of bitmap operations

2018-07-18 Thread Denis Plotnikov
1. test bit 2. test and set bit Signed-off-by: Denis Plotnikov --- include/qemu/bitops.h | 25 + 1 file changed, 25 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 3f0926cf40..72afcfaec5 100644 --- a/include/qemu/bitops.h +++

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Stefan Hajnoczi
On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: > This is needed for builds with the mingw64-* packages from Cygwin, > but also works for Linux. > > Move the zlib test also more to the end because users should > get information on the really important missing packages > (which also

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Daniel P . Berrangé
On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: > This is needed for builds with the mingw64-* packages from Cygwin, > but also works for Linux. > > Move the zlib test also more to the end because users should > get information on the really important missing packages > (which also

Re: [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements

2018-07-18 Thread Alex Williamson
On Wed, 18 Jul 2018 14:48:03 +0800 Peter Xu wrote: > On Tue, Jul 17, 2018 at 04:47:31PM -0600, Alex Williamson wrote: > > Directly assigned vfio devices have never been compatible with > > ballooning. Zapping MADV_DONTNEED pages happens completely > > independent of vfio page pinning and IOMMU

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-18 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Jul 09, 2018 at 11:11:29AM +0200, Emanuele Giuseppe Esposito wrote: >> This work is being done as Google Summer of Code 2018 project for QEMU, >> my mentors are Paolo Bonzini and Laurent Vivier. >> Additional infos on the project can be found at: >>

[Qemu-devel] [PATCH v1 11/17] background snapshot: add a memory page copying function

2018-07-18 Thread Denis Plotnikov
It's the only function making a memory page copy. It supports multithreading semantics ensuring that the page is copied by one thread only and releasing the copied page from write protection. Signed-off-by: Denis Plotnikov --- migration/ram.c | 56

[Qemu-devel] [PATCH v1 08/17] migration: add helpers to change VM memory protection rights

2018-07-18 Thread Denis Plotnikov
Signed-off-by: Denis Plotnikov --- migration/ram.c | 54 + migration/ram.h | 3 +++ 2 files changed, 57 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 27d3403435..ce3dead932 100644 --- a/migration/ram.c +++ b/migration/ram.c

[Qemu-devel] [PATCH v1 10/17] background snapshots: adapt the page queueing code for using page copies

2018-07-18 Thread Denis Plotnikov
The background snapshot uses memeory page copying to seal the page memory content. The patch adapts the migration infrastructure to save copies of the pages. Signed-off-by: Denis Plotnikov --- migration/migration.c | 2 +- migration/ram.c | 59 ---

[Qemu-devel] [PATCH v1 17/17] background snapshot: enable background snapshot

2018-07-18 Thread Denis Plotnikov
The patch enables to save vmstate to a migration thread in the background: ram is being saved while vCPUs are running. This is done to reduce downtime on vm snapshotting: the majority of vmstate is ram, the rest of devices consumes only a few MB of memory on a typical vm. By this moment, there

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-18 Thread Stefan Hajnoczi
On Thu, Jul 12, 2018 at 11:02:08PM +0800, Peng Tao wrote: > On Tue, Jul 10, 2018 at 9:40 PM, Stefan Hajnoczi wrote: > > Two things come to mind: > > > > At that point both guest kernel and agent address-space layout > > randomization (ASLR) is finished. ALSR makes it harder for memory > >

Re: [Qemu-devel] [PATCH for-3.1] qemu-iotests: Adapt to moved location of StringIO module in py3

2018-07-18 Thread Eduardo Habkost
On Wed, Jul 18, 2018 at 12:22:19PM -0300, Philippe Mathieu-Daudé wrote: > On 07/18/2018 12:05 PM, Eduardo Habkost wrote: > > On Wed, Jul 18, 2018 at 12:02:39PM -0300, Philippe Mathieu-Daudé wrote: > >> Hi Eduardo, > >> > >> On 07/18/2018 11:53 AM, Eduardo Habkost wrote: > >>> On Tue, Jul 17, 2018

Re: [Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits

2018-07-18 Thread Alex Williamson
On Wed, 18 Jul 2018 14:40:15 +0800 Peter Xu wrote: > On Tue, Jul 17, 2018 at 04:47:37PM -0600, Alex Williamson wrote: > > A simple true/false internal state does not allow multiple users. Fix > > this within the existing interface by converting to a counter, so long > > as the counter is

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Stefan Weil
Am 18.07.2018 um 18:21 schrieb Daniel P. Berrangé: > On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: >> This is needed for builds with the mingw64-* packages from Cygwin, >> but also works for Linux. >> >> Move the zlib test also more to the end because users should >> get information

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Daniel P . Berrangé
On Wed, Jul 18, 2018 at 06:59:25PM +0200, Stefan Weil wrote: > Am 18.07.2018 um 18:21 schrieb Daniel P. Berrangé: > > On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: > >> This is needed for builds with the mingw64-* packages from Cygwin, > >> but also works for Linux. > >> > >> Move

Re: [Qemu-devel] [PATCH v4] monitor: let cur_mon be per-thread

2018-07-18 Thread Peter Xu
On Wed, Jul 18, 2018 at 05:38:11PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > After the Out-Of-Band work, the monitor iothread may be accessing the > > cur_mon as well (via monitor_qmp_dispatch_one()). Let's convert the > > cur_mon variable to be a per-thread variable to make sure

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-18 Thread Pankaj Gupta
> > > This patch adds virtio-pmem Qemu device. > > > > This device presents memory address range information to guest > > which is backed by file backend type. It acts like persistent > > memory device for KVM guest. Guest can perform read and persistent > > write operations on this

Re: [Qemu-devel] [PATCH v5 08/10] migration: create a dedicated thread to release rdma resource

2018-07-18 Thread 858585 jemmy
On Thu, Jul 5, 2018 at 10:26 PM, 858585 jemmy wrote: > On Thu, Jun 28, 2018 at 2:59 AM, Dr. David Alan Gilbert > wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >>> ibv_dereg_mr wait for a long time for big memory size virtual server. >>> >>> The test result is: >>> 10GB 326ms >>>

[Qemu-devel] [PATCH] hw/block/nvme: add optional parameter num_namespaces for nvme device

2018-07-18 Thread Weiping Zhang
Add an optional paramter num_namespaces for device, and set it to 1 by default. Signed-off-by: Weiping Zhang --- hw/block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 156ecf3c41..b53be4b5c0 100644 --- a/hw/block/nvme.c

Re: [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements

2018-07-18 Thread Peter Xu
On Wed, Jul 18, 2018 at 10:31:33AM -0600, Alex Williamson wrote: > On Wed, 18 Jul 2018 14:48:03 +0800 > Peter Xu wrote: > > > On Tue, Jul 17, 2018 at 04:47:31PM -0600, Alex Williamson wrote: > > > Directly assigned vfio devices have never been compatible with > > > ballooning. Zapping

Re: [Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits

2018-07-18 Thread Peter Xu
On Wed, Jul 18, 2018 at 10:37:36AM -0600, Alex Williamson wrote: > On Wed, 18 Jul 2018 14:40:15 +0800 > Peter Xu wrote: > > > On Tue, Jul 17, 2018 at 04:47:37PM -0600, Alex Williamson wrote: > > > A simple true/false internal state does not allow multiple users. Fix > > > this within the

Re: [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements

2018-07-18 Thread Peter Xu
On Wed, Jul 18, 2018 at 11:36:40AM +0200, Cornelia Huck wrote: > On Wed, 18 Jul 2018 14:48:03 +0800 > Peter Xu wrote: > > > On Tue, Jul 17, 2018 at 04:47:31PM -0600, Alex Williamson wrote: > > > Directly assigned vfio devices have never been compatible with > > > ballooning. Zapping

Re: [Qemu-devel] [Qemu-stable] [PATCH v2] tap: fix memory leak on success to create a tap device

2018-07-18 Thread Michael Roth
Quoting Jason Wang (2018-05-31 04:46:05) > > > On 2018年05月31日 15:28, wangyunjian wrote: > > From: Yunjian Wang > > > > The memory leak on success to create a tap device. And the nfds and > > nvhosts may not be the same and need to be processed separately. > > > > Fixes: 07825977 ("tap: fix

Re: [Qemu-devel] [Qemu-stable] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-07-18 Thread Michael Roth
Quoting Kevin Wolf (2018-05-29 15:19:17) > Am 28.05.2018 um 14:03 hat Greg Kurz geschrieben: > > Removing a drive with drive_del while it is being used to run an I/O > > intensive workload can cause QEMU to crash. > > > > An AIO flush can yield at some point: > > > > blk_aio_flush_entry() > >

[Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-18 Thread Richard Henderson
This allows the tests generated by debian-powerpc-user-cross to function properly, especially tests/test-coroutine. Technically this syscall is available to both ppc32 and ppc64, but only ppc32 glibc actually uses it. Thus the ppc64 path is untested. Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] hw/display/sm501* status

2018-07-18 Thread Sebastian Bauer
Hi, Am 2018-07-18 04:30, schrieb David Gibson: On Mon, Jul 16, 2018 at 09:43:05PM +0100, Peter Maydell wrote: On 16 July 2018 at 21:26, BALATON Zoltan wrote: > I could list sm501 in the sam460ex section thus formally taking > sub-maintainership but this would only go as far that I'll get cc-d

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-18 Thread Paolo Bonzini
On 11/07/2018 19:46, Emanuele wrote: >>> +static void qpci(void) >>> +{ >>> +    qos_node_create_interface("pci-bus"); >>> +} >>> + >>> +libqos_init(qpci); >> Why does an interface need to be created?  The drivers declare which >> interfaces they support? >> >> I don't think this can be used to

Re: [Qemu-devel] [BUG?] aio_get_linux_aio: Assertion `ctx->linux_aio' failed

2018-07-18 Thread Nishanth Aravamudan via Qemu-devel
On 18.07.2018 [11:10:27 -0400], Farhan Ali wrote: > > > On 07/18/2018 09:42 AM, Farhan Ali wrote: > > > > > > On 07/17/2018 04:52 PM, Nishanth Aravamudan wrote: > > > iiuc, this possibly implies AIO was not actually used previously on this > > > guest (it might have silently been falling back

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Peter Maydell
On 18 July 2018 at 18:04, Daniel P. Berrangé wrote: > On Wed, Jul 18, 2018 at 06:59:25PM +0200, Stefan Weil wrote: >> Am 18.07.2018 um 18:21 schrieb Daniel P. Berrangé: >> > this fallback support for non-pkgconfig scenarios can be entirely >> > deleted, just leaving the error_exit message.

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-18 Thread Paolo Bonzini
On 18/07/2018 16:23, Stefan Hajnoczi wrote: +struct QOSGraphObject { +/* for produces, returns void * */ +QOSGetDriver get_driver; >>> Unused? >>> +/* for contains, returns a QOSGraphObject * */ +QOSGetDevice get_device; >>> Unused? >> What is unused? >

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes

2018-07-18 Thread Paolo Bonzini
On 18/07/2018 20:29, Emanuele wrote: > I had to put this patch here because it also introduces > qpci_device_init, used by sdhci (patch 3). > > For the next version I plan to have a patch X where I rename all > occurrences of qpci_init_pc in qpci_pc_new, and a patch X+1 that > introduces

Re: [Qemu-devel] [PATCH 0/7] Qtest driver framework

2018-07-18 Thread Paolo Bonzini
On 18/07/2018 19:14, Markus Armbruster wrote: >> The main challenge to me seems "how can we make tests simpler?". The >> presence of a new API and object model raises the bar for writing and >> running tests. I hope all qtests will use qgraph but if the complexity >> is too high then qgraph may

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Cornelia Huck
On Wed, 18 Jul 2018 11:23:30 +0200 David Hildenbrand wrote: > Usually, when baselining two CPU models, whereby one of them has base > CPU features disabled (e.g. z14-base,msa=off), we fallback to an older > model that did not have these features in the base model. We always try to > create a

Re: [Qemu-devel] [PATCH] target/ppc: bcdsub fix sign when result is zero

2018-07-18 Thread Yasmin Beatriz
On Wed, Jul 18, 2018 at 12:22:02PM +1000, David Gibson wrote: > On Mon, Jul 16, 2018 at 07:03:12PM +, Yasmin Beatriz wrote: > > When the result of bcdsub is equal to zero, the result sign may be > > set to negative in some cases, and this does not follow the Power ISA > > specifications as to

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-18 Thread Luiz Capitulino
On Fri, 13 Jul 2018 13:22:32 +0530 Pankaj Gupta wrote: > This patch adds virtio-pmem Qemu device. > > This device presents memory address range information to guest > which is backed by file backend type. It acts like persistent > memory device for KVM guest. Guest can perform read and

[Qemu-devel] [Bug 1782300] [NEW] COLO unable to failover to secondary VM

2018-07-18 Thread PJ Tsao
Public bug reported: I test COLO feature on my host following docs/COLO-FT.txt in qemu folder, but fail to failover to secondary VM. Is there any mistake in my execution steps? Execution environment: QEMU v2.12.0-rc4 OS: Ubuntu 16.04.3 LTS Kernel: Linux 4.4.35 Secondary VM IP: noted as

Re: [Qemu-devel] [RFC v3 06/15] hw/arm/virt: Allocate device_memory

2018-07-18 Thread Igor Mammedov
On Thu, 12 Jul 2018 16:53:01 +0200 Auger Eric wrote: > Hi Drew, > > On 07/12/2018 04:45 PM, Andrew Jones wrote: > > On Thu, Jul 12, 2018 at 04:22:05PM +0200, Auger Eric wrote: > >> Hi Igor, > >> > >> On 07/11/2018 03:17 PM, Igor Mammedov wrote: > >>> On Thu, 5 Jul 2018 16:27:05 +0200 > >>>

Re: [Qemu-devel] [RFC v3 06/15] hw/arm/virt: Allocate device_memory

2018-07-18 Thread Igor Mammedov
On Tue, 3 Jul 2018 09:19:49 +0200 Eric Auger wrote: > We define a new hotpluggable RAM region (aka. device memory). > Its base is 2TB GPA. This obviously requires 42b IPA support > in KVM/ARM, FW and guest kernel. At the moment the device > memory region is max 2TB. > > This is largely

Re: [Qemu-devel] [qemu-s390x] [RFC 14/15] s390-bios: Support booting from real dasd device

2018-07-18 Thread Cornelia Huck
On Wed, 18 Jul 2018 12:55:51 +0200 Halil Pasic wrote: > On 07/18/2018 09:40 AM, Cornelia Huck wrote: > > On Tue, 17 Jul 2018 22:43:27 +0200 > > David Hildenbrand wrote: > > > >> On 05.07.2018 19:25, Jason J. Herne wrote: > > > >>> +* > >>> +*

Re: [Qemu-devel] [RFC 14/15] s390-bios: Support booting from real dasd device

2018-07-18 Thread Halil Pasic
On 07/05/2018 07:25 PM, Jason J. Herne wrote: From: "Jason J. Herne" Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- docs/devel/s390-dasd-ipl.txt | 132 +++ pc-bios/s390-ccw/Makefile|

Re: [Qemu-devel] [qemu-s390x] [RFC 14/15] s390-bios: Support booting from real dasd device

2018-07-18 Thread Halil Pasic
On 07/18/2018 01:35 PM, Cornelia Huck wrote: So to translate the new stuff we would actually have to stop the channel program and resubmit the rest (either by suspend+resume or by break chaining+ssch). The problem with that an execution of a channel program that is composed of four ccws

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2018-07-18 Thread Robie Basak
Hello Dominique, or anyone else affected, Accepted qemu into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.5+dfsg- 5ubuntu10.31 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Qemu-devel] [PATCH 0/3] crypto: increase min required gnutls, gcrypt and nettle

2018-07-18 Thread Daniel P . Berrangé
Since adopting a formal policy around supported build hosts, and increasing the minimum required glib version, it is now possible to also increase the min required versions for gnutls, gcrypt and nettle libraries. This allows simplification of a bunch of conditional logic. Daniel P. Berrangé (3):

[Qemu-devel] [PATCH 1/3] crypto: require gnutls >= 3.1.18 for building QEMU

2018-07-18 Thread Daniel P . Berrangé
gnutls 3.0.0 was released in 2011 and all the distros that are build target platforms for QEMU [1] include it: RHEL-7: 3.1.18 Debian (Stretch): 3.5.8 Debian (Jessie): 3.3.8 OpenBSD (ports): 3.5.18 FreeBSD (ports): 3.5.18 OpenSUSE Leap 15: 3.6.2 Ubuntu (Xenial): 3.4.10 macOS

[Qemu-devel] [PATCH 3/3] crypto: require nettle >= 1.5.0 for building QEMU

2018-07-18 Thread Daniel P . Berrangé
nettle 2.7.1 was released in 2013 and all the distros that are build target platforms for QEMU [1] include it: RHEL-7: 2.7.1 Debian (Stretch): 3.3 Debian (Jessie): 2.7.1 OpenBSD (ports): 3.4 FreeBSD (ports): 3.4 OpenSUSE Leap 15: 3.4 Ubuntu (Xenial): 3.2 macOS (Homebrew): 3.4

[Qemu-devel] [PATCH 2/3] crypto: require libgcrypt >= 1.5.0 for building QEMU

2018-07-18 Thread Daniel P . Berrangé
libgcrypt 1.5.0 was released in 2011 and all the distros that are build target platforms for QEMU [1] include it: RHEL-7: 1.5.3 Debian (Stretch): 1.7.6 Debian (Jessie): 1.6.3 OpenBSD (ports): 1.8.2 FreeBSD (ports): 1.8.3 OpenSUSE Leap 15: 1.8.2 Ubuntu (Xenial): 1.6.5 macOS

[Qemu-devel] [PATCH RFC 08/10] docker: disable additional non-x86 images

2018-07-18 Thread Alex Bennée
- travis - doesn't support non-x8 - centos7 - only AltArch, next release should have support - debian-8 based - docker hub issue? - ubuntu - image a bit old, maybe update to 18.04 Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 7 +++ 1 file changed, 7 insertions(+) diff

[Qemu-devel] [PATCH RFC 10/10] tests/tcg: debian-mips64el-user-cross fallback

2018-07-18 Thread Alex Bennée
When we can't use the debian-mips64el-cross to build our tests we can use the user-cross fallback. Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.include | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/tcg/mips/Makefile.include b/tests/tcg/mips/Makefile.include index

Re: [Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is really needed

2018-07-18 Thread Peter Xu
On Wed, Jul 18, 2018 at 04:56:13PM +0800, Xiao Guangrong wrote: > > > On 07/12/2018 04:26 PM, Peter Xu wrote: > > On Thu, Jul 12, 2018 at 03:47:57PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 07/11/2018 04:21 PM, Peter Xu wrote: > > > > On Thu, Jun 28, 2018 at 05:33:58PM +0800, Xiao

[Qemu-devel] [PATCH 1/3] milkymist-pfpu: more accurate emulation

2018-07-18 Thread Michael Walle
Emulate write collisions, stray writes and microcode which has no VECTOUT opcode. Although the latter was supported before, the emulation was incorrect. Signed-off-by: Michael Walle --- hw/misc/milkymist-pfpu.c | 105 +-- 1 file changed, 75

[Qemu-devel] [PATCH 2/3] qtest: new functions for pulsed IRQs

2018-07-18 Thread Michael Walle
It is only possible to retrieve the current state of an interrupt line. But there are devices which just pulses the interrupt line. Introduce a latch which is set by qtest and which can be cleared by the test case. Signed-off-by: Michael Walle Cc: Paolo Bonzini Cc: Andreas Färber ---

[Qemu-devel] [PATCH 3/3] milkymist-pfpu: add qtests

2018-07-18 Thread Michael Walle
Add initial tests which check basic computations and error cases on the PFPU. Signed-off-by: Michael Walle --- MAINTAINERS | 1 + hw/lm32/lm32.h | 2 + tests/Makefile.include | 4 + tests/milkymist-pfpu-test.c | 193

Re: [Qemu-devel] [qemu-s390x] [RFC 14/15] s390-bios: Support booting from real dasd device

2018-07-18 Thread Halil Pasic
On 07/18/2018 09:40 AM, Cornelia Huck wrote: On Tue, 17 Jul 2018 22:43:27 +0200 David Hildenbrand wrote: On 05.07.2018 19:25, Jason J. Herne wrote: +* +* How this all pertains to Qemu * +* + +In

[Qemu-devel] [PATCH RFC 05/10] docker: fall-back to binfmt_misc debian-mips64el-user-cross on non-x86

2018-07-18 Thread Alex Bennée
The Debian archives don't package their large array of cross compilers for all host architectures. For MIPS let's fall back to a linux-user based image when we can't use the native ones. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 11 +++

[Qemu-devel] [PATCH RFC 01/10] docker: rename docker-amd64 to docker-host

2018-07-18 Thread Alex Bennée
When building on non-x86 systems the base system will be correct so if we avoid too many x86'isms in the install we can still use the image. Signed-off-by: Alex Bennée --- .../dockerfiles/{debian-amd64.docker => debian-host.docker} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH RFC 06/10] docker: fall-back to binfmt_misc debian-ppc64el-user-cross on non-x86

2018-07-18 Thread Alex Bennée
The Debian archives don't package their large array of cross compilers for all host architectures. For ppc64el let's fall back to a linux-user based image when we can't use the native ones. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 10 +-

[Qemu-devel] [PATCH RFC 03/10] docker: add a placeholder for handling non-x86 hosts

2018-07-18 Thread Alex Bennée
We want to keep all our variations in one place. This is that place. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 12 1 file changed, 12 insertions(+) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 22adf6ac73..7d13ddd497 100644

[Qemu-devel] [PATCH RFC 07/10] docker: fall-back to binfmt_misc debian-s390x-user-cross on non-x86

2018-07-18 Thread Alex Bennée
The Debian archives don't package their large array of cross compilers for all host architectures. For s390x let's fall back to a linux-user based image when we can't use the native ones. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 9 -

[Qemu-devel] [PATCH RFC 02/10] docker: change docker-image to docker-all-images target

2018-07-18 Thread Alex Bennée
We also evaluate this list later in the build rule after all decisions about what will and won't be built have been made. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/docker/Makefile.include

[Qemu-devel] [PATCH RFC 00/10] docker on non-x86 hosts

2018-07-18 Thread Alex Bennée
Hi, Our existing support for docker is fairly x86 centric. While docker itself has support for multiple architectures not all architectures are equal. For example Debian only packages the widest range of cross-compilers in it's x86 images (although for example armhf is available on aarch64 based

[Qemu-devel] [PATCH RFC 09/10] tests: tcg skip docker images we can't build

2018-07-18 Thread Alex Bennée
We have a mechansim (DOCKER_PARTIAL_IMAGES) for marking stuff that is incomplete or won't build. We can use this to avoid attempting to build them at the top of a check-tcg build. We need to move the inclusion of docker/Makefile.include to ensure everything is resolved by this point. We also have

[Qemu-devel] [PATCH RFC 04/10] docker: don't include docker-arm64-cross on aarch64 hosts

2018-07-18 Thread Alex Bennée
Attempting to install the native compiler as a cross compiler rarely goes well. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 1 file changed, 4 insertions(+) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 7d13ddd497..2cb180ff6c 100644

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-07-18 Thread Frank Schreuder
I may have found the issue and if it is the case it should be fixed after applying: http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00820.html Is there a reason why this patch is not backported to 2.11.2? The theory is that the VM is not actually "frozen", but catching up in time, as

Re: [Qemu-devel] [PATCH v2] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report

2018-07-18 Thread Michael Walle
Am 2018-07-02 03:40, schrieb Philippe Mathieu-Daudé: qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errorslog when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [libvirt] CPU Support

2018-07-18 Thread Pavel Hrdina
On Wed, Jul 18, 2018 at 10:50:34AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: > > Hi, > > > > I've been looking at the CPU list and although I see lots of CPU's, I > > cannot find 2 CPU families: > > > > * AMD Ryzen > > * AMD Threadripper >

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Christian Borntraeger
On 07/18/2018 11:23 AM, David Hildenbrand wrote: > Usually, when baselining two CPU models, whereby one of them has base > CPU features disabled (e.g. z14-base,msa=off), we fallback to an older > model that did not have these features in the base model. We always try to > create a "sane" CPU

Re: [Qemu-devel] [PATCH 0/9] monitor: enable OOB by default

2018-07-18 Thread Markus Armbruster
Peter Xu writes: > On Tue, Jul 17, 2018 at 08:08:55PM +0800, Peter Xu wrote: > > [...] > >> > >> > Whatever we don't address right away we should at least mark FIXME in >> > the source code. >> > >> > Assuming my list is complete, and my assessments correct, then we're >> > quite close to the

Re: [Qemu-devel] [PATCH v4 12/20] intc/arm_gic: Implement virtualization extensions in gic_(deactivate|complete_irq)

2018-07-18 Thread Luc Michel
On 07/17/2018 03:32 PM, Peter Maydell wrote: > On 14 July 2018 at 18:15, Luc Michel wrote: >> Implement virtualization extensions in the gic_deactivate_irq() and >> gic_complete_irq() functions. When a guest tries to deactivat or end an > > "deactivate" > >> IRQ that does not exist in the

Re: [Qemu-devel] [PATCH v4 14/20] intc/arm_gic: Wire the vCPU interface

2018-07-18 Thread Luc Michel
On 07/17/2018 04:26 PM, Peter Maydell wrote: > On 14 July 2018 at 18:15, Luc Michel wrote: >> Add the read/write functions to handle accesses to the vCPU interface. >> Those accesses are forwarded to the real CPU interface, with the CPU id >> being converted to the corresponding vCPU id (vCPU id

Re: [Qemu-devel] [PATCH for-3.0] i386: Rename enum CacheType members

2018-07-18 Thread Aleksandar Markovic
On 07/17/2018 04:40 PM, Eduardo Habkost wrote: > Rename DCACHE to DATA_CACHE and ICACHE to INSTRUCTION_CACHE. > > This avoids conflict with Linux asm/cachectl.h macros and fixes > build failure on mips hosts. > > Reported-by: Philippe Mathieu-Daudé > Signed-off-by: Eduardo Habkost Acked-by:

Re: [Qemu-devel] [PATCH for 3.0 1/4] tests: call qcrypto_init instead of gnutls_global_init

2018-07-18 Thread Philippe Mathieu-Daudé
Hi Daniel, On 07/18/2018 06:38 AM, Daniel P. Berrangé wrote: > Calling qcrypto_init ensures that all relevant initialization is > done. In particular this honours the debugging settings and thread > settings. > > Signed-off-by: Daniel P. Berrangé > --- > tests/crypto-tls-x509-helpers.c | 4

Re: [Qemu-devel] [BUG?] aio_get_linux_aio: Assertion `ctx->linux_aio' failed

2018-07-18 Thread Farhan Ali
On 07/17/2018 04:52 PM, Nishanth Aravamudan wrote: iiuc, this possibly implies AIO was not actually used previously on this guest (it might have silently been falling back to threaded IO?). I don't have access to s390x, but would it be possible to run qemu under gdb and see if

Re: [Qemu-devel] [PATCH for 3.0 2/4] tests: don't silence error reporting for all tests

2018-07-18 Thread Philippe Mathieu-Daudé
Hi Daniel, On 07/18/2018 06:38 AM, Daniel P. Berrangé wrote: > The test-vmstate test is a bit chatty because it triggers various > expected failure scenarios and the code in question uses error_report > instead of accepting 'Error **errp' parameters. To silence this test the > stubs for

Re: [Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tests on Fedora Docker image

2018-07-18 Thread Eduardo Habkost
On Wed, Jul 18, 2018 at 08:25:48AM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 17, 2018 at 08:37:58PM -0300, Philippe Mathieu-Daudé wrote: > > I noticed this while running "make docker-test-block@fedora": > > > > $ make docker-test-block@fedora NETWORK=1 > > BUILD fedora > > RUN

Re: [Qemu-devel] [PATCH for 3.0 3/4] tests: use error_abort in places expecting errors

2018-07-18 Thread Philippe Mathieu-Daudé
On 07/18/2018 06:38 AM, Daniel P. Berrangé wrote: > Most of the TLS related tests are passing an in a "Error" object to > methods that are expected to fail, but then ignoring any error that is > set and instead asserting on a return value. This means that when an > error is unexpectedly raised, no

Re: [Qemu-devel] [PATCH for-3.0] i386: Rename enum CacheType members

2018-07-18 Thread Moger, Babu
> -Original Message- > From: Aleksandar Markovic [mailto:amarko...@wavecomp.com] > Sent: Wednesday, July 18, 2018 8:35 AM > To: Philippe Mathieu-Daudé ; Eduardo Habkost > ; qemu-devel@nongnu.org > Cc: Moger, Babu ; Paolo Bonzini > ; Aurelien Jarno ; Richard > Henderson > Subject: Re:

Re: [Qemu-devel] [libvirt] CPU Support

2018-07-18 Thread Eduardo Habkost
CCing the AMD people who worked on this. On Wed, Jul 18, 2018 at 12:18:45PM +0200, Pavel Hrdina wrote: > On Wed, Jul 18, 2018 at 10:50:34AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: > > > Hi, > > > > > > I've been looking at the CPU list

Re: [Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tests on Fedora Docker image

2018-07-18 Thread Philippe Mathieu-Daudé
Hi Daniel, On 07/18/2018 04:25 AM, Daniel P. Berrangé wrote: > On Tue, Jul 17, 2018 at 08:37:58PM -0300, Philippe Mathieu-Daudé wrote: >> I noticed this while running "make docker-test-block@fedora": >> >> $ make docker-test-block@fedora NETWORK=1 >> BUILD fedora >> RUN test-block in

<    1   2