Re: [RFC v3 02/25] hw/iommu: introduce DualStageIOMMUObject

2020-02-12 Thread David Gibson
On Fri, Jan 31, 2020 at 11:42:06AM +, Liu, Yi L wrote: > Hi David, > > > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > > Sent: Friday, January 31, 2020 11:59 AM > > To: Liu, Yi L > > Subject: Re: [RFC v3 02/25] hw/iommu: introduce DualStageIOMMUObject > > > > On Wed, Jan 29,

Re: [PATCH v4 4/4] target/riscv: add vector configure instruction

2020-02-12 Thread LIU Zhiwei
On 2020/2/12 0:56, Richard Henderson wrote: On 2/10/20 8:12 AM, LIU Zhiwei wrote: static inline void cpu_get_tb_cpu_state(CPURISCVState *env, target_ulong *pc, -target_ulong *cs_base, uint32_t *flags) +

[PATCH v3 1/4] target/i386: Add Denverton-v2 (no MPX) CPU model

2020-02-12 Thread Tao Xu
Because MPX is being removed from the linux kernel, remove MPX feature from Denverton. Signed-off-by: Tao Xu --- target/i386/cpu.c | 12 1 file changed, 12 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 32efa46852..848c992cd3 100644 --- a/target/i386/cpu.c

[PATCH v3 0/4] Add extra information to versioned CPU models

2020-02-12 Thread Tao Xu
This series of patches will remove MPX from Denverton, remove Remove monitor from some CPU models. Add additional information for -cpu help to indicate the changes in this version of CPU model. The output is as follows: ./x86_64-softmmu/qemu-system-x86_64 -cpu help | grep "\[" x86 Broadwell-v2

[PATCH v3 3/4] target/i386: Add new property note to versioned CPU models

2020-02-12 Thread Tao Xu
Add additional information for -cpu help to indicate the changes in this version of CPU model. Suggested-by: Eduardo Habkost Signed-off-by: Tao Xu --- target/i386/cpu.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

[PATCH v3 2/4] target/i386: Remove monitor from some CPU models

2020-02-12 Thread Tao Xu
Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana CPU model to remove MONITOR/MWAIT feature. After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT (commit id 6f131f13e68d648a8e4f083c667ab1acd88ce4cd), the MONITOR/MWAIT feature in these CPU model is unused.

Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote: > > On 2020/2/11 下午7:33, Michael S. Tsirkin wrote: > > On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: > > > From: Liu Jiang > > > > > > The standard virtio-mmio devices use notification register to signal > > > backend. This

Re: [PATCH v5 05/26] nvme: populate the mandatory subnqn and ver fields

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Required for compliance with NVMe revision 1.2.1 or later. See NVM > Express 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Section > 7.9 ("NVMe Qualified Names"). > > This also bumps the supported version to 1.2.1. > >

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:06:52PM +0800, Jason Wang wrote: > > On 2020/2/12 上午11:54, Liu, Jing2 wrote: > > > > > > On 2/11/2020 3:40 PM, Jason Wang wrote: > > > > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > > > > > > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > > > > > >

Re: [PATCH v5 04/26] nvme: add missing fields in the identify data structures

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Not used by the device model but added for completeness. See NVM Express > 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Figure 93. > > Signed-off-by: Klaus Jensen > --- > include/block/nvme.h | 48

[PATCH v3 0/5] vhost-user block device backend implementation

2020-02-12 Thread Coiby Xu
v3: * separate generic vhost-user-server code from vhost-user-blk-server code * re-write vu_message_read and kick hander function as coroutines to directly call blk_co_preadv, blk_co_pwritev, etc. * add aio_context notifier functions to support multi-threading model * other fixes

Re: [PATCH 2/2] target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA

2020-02-12 Thread Alex Bennée
Richard Henderson writes: > Now that we can pass 7 parameters, do not encode register > operands within simd_data. What defines the upper limit? Is it the ABI of the backend or just the efficiency of implementing the prologue for the call? > --- a/target/arm/sve_helper.c > +++

Re: [PATCH] ui/cocoa: Drop workarounds for pre-10.12 OSX

2020-02-12 Thread Gerd Hoffmann
On Sat, Feb 01, 2020 at 05:05:34PM +, Peter Maydell wrote: > Our official OSX support policy covers the last two released versions. > Currently that is 10.14 and 10.15. We also may work on older versions, but > don't guarantee it. > > In commit 50290c002c045280f8d in mid-2019 we introduced

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-12 Thread Gerd Hoffmann
Hi, > Thanks to the QMP coroutine support, the screendump handler can > trigger a graphic_hw_update(), yield and let the main loop run until > update is done. Then the handler is resumed, and the ppm_save() will > write the screen image to disk in the coroutine context (thus > non-blocking). >

Re: [PATCH v3 1/5] target/riscv: add vector unit stride load and store instructions

2020-02-12 Thread LIU Zhiwei
Hi, Richard Thanks for comments. On 2020/2/12 14:38, Richard Henderson wrote: On 2/9/20 11:42 PM, LIU Zhiwei wrote: +/* + * As simd_desc supports at most 256 bytes, and in this implementation, + * the max vector group length is 2048 bytes. So split it into two parts. + * + * The first part is

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Jason Wang
On 2020/2/11 下午10:00, Michael S. Tsirkin wrote: Yes, it can work but it may bring extra effort when you want to mask a vector which is was shared by a lot of queues. Thanks masking should be per vq too. -- Yes, but if the vector is shard by e.g 16 queues, then all those virtqueues

Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-12 Thread Laurent Vivier
Le 06/02/2020 à 18:38, Eric Blake a écrit : > Detected by a hang in the libnbd testsuite. If a client requests > multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) > at the same time, our attempt to silence a false-positive warning > about a potential uninitialized variable

Re: [PATCH v5 06/26] nvme: refactor nvme_addr_read

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Pull the controller memory buffer check to its own function. The check > will be used on its own in later patches. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 18 +- > 1 file changed, 13 insertions(+), 5

Re: [PATCH v5 12/26] nvme: add missing mandatory features

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Add support for returning a resonable response to Get/Set Features of > mandatory features. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 57 --- > hw/block/trace-events | 2 ++ >

Re: [PATCH v5 13/26] nvme: additional tracing

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Add a trace call for nvme_enqueue_req_completion. > > Also, streamline nvme_identify_ns and nvme_identify_ns_list. They do not > need to repeat the command, it is already in the trace name. > > Signed-off-by: Klaus Jensen > --- >

Re: [PATCH v5 17/26] nvme: allow multiple aios per command

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > This refactors how the device issues asynchronous block backend > requests. The NvmeRequest now holds a queue of NvmeAIOs that are > associated with the command. This allows multiple aios to be issued for > a command. Only when all requests

Re: [PATCH v5 18/26] nvme: use preallocated qsg/iov in nvme_dma_prp

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > Since clean up of the request qsg/iov has been moved to the common > nvme_enqueue_req_completion function, there is no need to use a > stack allocated qsg/iov in nvme_dma_prp. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 18

Re: [RFC PATCH v3 2/2] virtio-gpu: add the ability to export resources

2020-02-12 Thread Gerd Hoffmann
On Fri, Feb 07, 2020 at 04:40:33PM +0900, David Stevens wrote: > Signed-off-by: David Stevens > --- > virtio-gpu.tex | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/virtio-gpu.tex b/virtio-gpu.tex > index af4ca61..e950ad3 100644 > --- a/virtio-gpu.tex >

[Bug 1857811] Re: qemu user static binary seems to lack support for network namespace.

2020-02-12 Thread Laurent Vivier
The interesting part in emerge.log is: 23473 socket(16,,IPPROTO_IP) = 5 23473 bind(5,274886353720,12,0,1,274889671712) = 0 23473 sendto(5,275542232672,38,0,274886353960,12) = -1 errno=95 (Operation not supported) 23473 close(5) = 0 Unable to configure loopback interface: Operation not

Re: [PATCH v5 01/26] nvme: rename trace events to nvme_dev

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Change the prefix of all nvme device related trace events to 'nvme_dev' > to not clash with trace events from the nvme block driver. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 185

Re: [PATCH v5 02/26] nvme: remove superfluous breaks

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > These break statements was left over when commit 3036a626e9ef ("nvme: > add Get/Set Feature Timestamp support") was merged. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [PATCH v5 07/26] nvme: add support for the abort command

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, > Section 5.1 ("Abort command"). > > The Abort command is a best effort command; for now, the device always > fails to abort the given command. > > Signed-off-by:

[PATCH v3 3/5] vhost-user block device backend server

2020-02-12 Thread Coiby Xu
By making use of libvhost, multiple block device drives can be exported and each drive can serve multiple clients simultaneously. Since vhost-user-server needs a block drive to be created first, delay the creation of this object. Signed-off-by: Coiby Xu --- Makefile.target |

[PATCH v3 4/5] a standone-alone tool to directly share disk image file via vhost-user protocol

2020-02-12 Thread Coiby Xu
vhost-user-blk could have played as vhost-user backend but it only supports raw file and don't support VIRTIO_BLK_T_DISCARD and VIRTIO_BLK_T_WRITE_ZEROES operations on raw file (ioctl(fd, BLKDISCARD) is only valid for real block device). In the future Kevin's qemu-storage-daemon will be used to

Re: [PATCH v5 11/26] nvme: add support for the asynchronous event request command

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, > Section 5.2 ("Asynchronous Event Request command"). > > Mostly imported from Keith's qemu-nvme tree. Modified with a max number > of queued events (controllable with

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-12 Thread Stefan Hajnoczi
On Tue, Feb 11, 2020 at 11:31:17AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 11, 2020 at 04:20:41PM +, Stefan Hajnoczi wrote: > > On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > > > On Mon, Feb 03, 2020 at 10:57:44AM +, Daniel P. Berrangé wrote: > > > > On Mon, Feb 03,

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-12 Thread Peter Maydell
On Wed, 12 Feb 2020 at 06:39, Gavin Shan wrote: > > On 2/5/20 10:05 PM, Gavin Shan wrote: > > This allows to inject SError interrupt, which will be used on receiving > > QMP/HMP "nmi" command in next patch. > > > > Signed-off-by: Gavin Shan > > --- > > target/arm/cpu.c| 11 +++ > >

Re: [PATCH v2 0/2] ui/gtk: Fix gd_refresh_rate_millihz() when widget window is not realized

2020-02-12 Thread Gerd Hoffmann
On Sat, Feb 08, 2020 at 05:10:46PM +0100, Philippe Mathieu-Daudé wrote: > Fix bug report from Jan Kiszka: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg678130.html > https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg02260.html Added to UI queue. thanks, Gerd

Re: The issues about architecture of the COLO checkpoint

2020-02-12 Thread Daniel Cho
Hi Hailiang, Thanks for your replaying and explain in detail. We will try to use the attachments to enhance memory copy. However, we have some questions for your replying. 1. As you said, "for each checkpoint, we have to send the whole PVM's pages To SVM", why the only first checkpoint will

RE: [RFC v3 16/25] intel_iommu: add PASID cache management infrastructure

2020-02-12 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, February 12, 2020 7:36 AM > To: Liu, Yi L > Subject: Re: [RFC v3 16/25] intel_iommu: add PASID cache management > infrastructure > > On Wed, Jan 29, 2020 at 04:16:47AM -0800, Liu, Yi L wrote: > > From: Liu Yi L > > > > This patch adds a PASID cache

Re: [PATCH v3 4/4] target/i386: Add notes for versioned CPU models

2020-02-12 Thread Igor Mammedov
On Wed, 12 Feb 2020 16:13:28 +0800 Tao Xu wrote: > Add which features are added or removed in this version. Remove the > changed model-id in versioned CPU models, to keep the model name > unchanged at /proc/cpuinfo inside the VM. > > Signed-off-by: Tao Xu > --- > > Changes in v2: > -

Re: [PATCH v5 03/26] nvme: move device parameters to separate struct

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Move device configuration parameters to separate struct to make it > explicit what is configurable and what is set internally. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 44 ++-- >

Re: [PATCH] i.MX: Fix inverted register bits in wdt code.

2020-02-12 Thread Roman Kapl
On 2/11/20 6:57 PM, Peter Maydell wrote: On Fri, 7 Feb 2020 at 09:55, Roman Kapl wrote: Documentation says for WDA '0: Assert WDOG output.' and for SRS '0: Assert system reset signal.'. Signed-off-by: Roman Kapl --- hw/misc/imx2_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v4 0/4] qmp: Optionally run handlers in coroutines

2020-02-12 Thread Kevin Wolf
Am 05.02.2020 um 15:00 hat Kevin Wolf geschrieben: > Am 21.01.2020 um 19:11 hat Kevin Wolf geschrieben: > > Some QMP command handlers can block the main loop for a relatively long > > time, for example because they perform some I/O. This is quite nasty. > > Allowing such handlers to run in a

[Bug 1859656] Re: [2.6] Unable to reboot s390x KVM machine after initial deploy

2020-02-12 Thread Andrew Cloke
After discussing, I realise I had a misunderstanding in comment #30 that I'd like to correct. I had incorrectly assumed that feeding the PXEBooting KVM guest a zero length pxelinux.cfg file *instructed* it to boot from the local disk. I now realise that is incorrect. Feeding the PXEBooting KVM

Re: [PATCH v5 16/26] nvme: refactor prp mapping

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Refactor nvme_map_prp and allow PRPs to be located in the CMB. The logic > ensures that if some of the PRP is in the CMB, all of it must be located > there, as per the specification. To be honest this looks like not refactoring but a bugfix

Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-12 Thread Laurent Vivier
Le 12/02/2020 à 13:10, Eric Blake a écrit : > On 2/12/20 3:24 AM, Laurent Vivier wrote: >> Le 06/02/2020 à 18:38, Eric Blake a écrit : >>> Detected by a hang in the libnbd testsuite.  If a client requests >>> multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) >>> at the same

Re: [PATCH v5 10/26] nvme: add support for the get log page command

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Add support for the Get Log Page command and basic implementations of > the mandatory Error Information, SMART / Health Information and Firmware > Slot Information log pages. > > In violation of the specification, the SMART / Health

[PATCH v3 1/5] extend libvhost to support IOThread and coroutine

2020-02-12 Thread Coiby Xu
Previously libvhost dispatch events in its own GMainContext. Now vhost-user client's kick event can be dispatched in block device drive's AioContext thus IOThread is supported. And also allow vu_message_read and vu_kick_cb to be replaced so QEMU can run them as coroutines. Signed-off-by: Coiby Xu

[PATCH v3 2/5] generic vhost user server

2020-02-12 Thread Coiby Xu
Sharing QEMU devices via vhost-user protocol Signed-off-by: Coiby Xu --- util/Makefile.objs | 3 + util/vhost-user-server.c | 429 +++ util/vhost-user-server.h | 56 + 3 files changed, 489 insertions(+) create mode 100644

Re: [PATCH 02/13] target/arm: Add isar_feature_any_fp16 and document naming/usage conventions

2020-02-12 Thread Peter Maydell
On Wed, 12 Feb 2020 at 06:24, Philippe Mathieu-Daudé wrote: > > On 2/11/20 6:37 PM, Peter Maydell wrote: > > @@ -185,7 +185,7 @@ uint32_t vfp_get_fpscr(CPUARMState *env) > > void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) > > { > > /* When ARMv8.2-FP16 is not supported, FZ16

Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-12 Thread Eric Blake
On 2/12/20 3:24 AM, Laurent Vivier wrote: Le 06/02/2020 à 18:38, Eric Blake a écrit : Detected by a hang in the libnbd testsuite. If a client requests multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) at the same time, our attempt to silence a false-positive warning about a

[PATCH v3 4/4] target/i386: Add notes for versioned CPU models

2020-02-12 Thread Tao Xu
Add which features are added or removed in this version. Remove the changed model-id in versioned CPU models, to keep the model name unchanged at /proc/cpuinfo inside the VM. Signed-off-by: Tao Xu --- Changes in v2: - correct the note of Cascadelake v3 (Xiaoyao) --- target/i386/cpu.c | 54

Re: [PATCH 1/2] NetRxPkt: Introduce support for additional hash types

2020-02-12 Thread Yuri Benditovich
Hi Jason, Can you please review these 2 patches and apply if there are no objections. Thanks, Yuri Benditovich On Wed, Jan 29, 2020 at 6:09 PM Dmitry Fleytman wrote: > > > > > On 27 Jan 2020, at 13:54, Yuri Benditovich > > wrote: > > > > Add support for following hash types: > > IPV6 TCP

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Jason Wang
On 2020/2/12 上午11:54, Liu, Jing2 wrote: On 2/11/2020 3:40 PM, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote:

Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-12 Thread Jason Wang
On 2020/2/12 下午4:53, Jason Wang wrote: On 2020/2/12 下午4:18, Michael S. Tsirkin wrote: On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote: On 2020/2/11 下午7:33, Michael S. Tsirkin wrote: On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: From: Liu Jiang The standard

Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:33:06PM +0800, Jason Wang wrote: > > On 2020/2/12 下午4:53, Jason Wang wrote: > > > > On 2020/2/12 下午4:18, Michael S. Tsirkin wrote: > > > On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote: > > > > On 2020/2/11 下午7:33, Michael S. Tsirkin wrote: > > > > > On Mon,

[PATCH v3 5/5] new qTest case to test the vhost-user-blk-server

2020-02-12 Thread Coiby Xu
This test case has the same tests as tests/virtio-blk-test.c except for tests have block_resize. Signed-off-by: Coiby Xu --- tests/libqos/vhost-user-blk.c | 126 ++ tests/libqos/vhost-user-blk.h | 44 +++ tests/vhost-user-blk-test.c | 694 ++ 3 files

Re: [PATCH v5 14/26] nvme: make sure ncqr and nsqr is valid

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > 0x is not an allowed value for NCQR and NSQR in Set Features on > Number of Queues. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/block/nvme.c

Re: [PATCH v5 20/26] nvme: handle dma errors

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > Handling DMA errors gracefully is required for the device to pass the > block/011 test ("disable PCI device while doing I/O") in the blktests > suite. > > With this patch the device passes the test by retrying "critical" > transfers

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:03:00PM +0800, Jason Wang wrote: > > On 2020/2/11 下午10:00, Michael S. Tsirkin wrote: > > > Yes, it can work but it may bring extra effort when you want to mask a > > > vector which is was shared by a lot of queues. > > > > > > Thanks > > > > > masking should be per vq

Re: [PATCH v5 08/26] nvme: refactor device realization

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > This patch splits up nvme_realize into multiple individual functions, > each initializing a different subset of the device. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 175 +++- >

Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL

2020-02-12 Thread Alex Bennée
Richard Henderson writes: > On 1/30/20 1:38 PM, Stefan Hajnoczi wrote: >> From: Salvador Fandino >> >> NULL is a valid log filename used to indicate we want to use stderr >> but qemu_set_log_filename (which is called by bsd-user/main.c) was not >> handling it correctly. >> >> That also made

Re: [PATCH 1/2] tcg: Add tcg_gen_gvec_5_ptr

2020-02-12 Thread Alex Bennée
Richard Henderson writes: > Extend the vector generator infrastructure to handle > 5 vector arguments. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/tcg/tcg-op-gvec.h | 7 +++ > tcg/tcg-op-gvec.c | 32 > 2 files

Re: Cross-project NBD extension proposal: NBD_INFO_INIT_STATE

2020-02-12 Thread Eric Blake
On 2/12/20 1:27 AM, Wouter Verhelst wrote: Hi, On Mon, Feb 10, 2020 at 10:52:55PM +, Richard W.M. Jones wrote: But anyway ... could a flag indicating that the whole image is sparse be useful, either as well as NBD_INIT_SPARSE or instead of it? You could use it to avoid an initial disk

Re: [PATCH v5 21/26] nvme: add support for scatter gather lists

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > For now, support the Data Block, Segment and Last Segment descriptor > types. > > See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). > > Signed-off-by: Klaus Jensen > Acked-by: Fam Zheng > --- > block/nvme.c | 18

Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-12 Thread Jason Wang
On 2020/2/12 下午4:18, Michael S. Tsirkin wrote: On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote: On 2020/2/11 下午7:33, Michael S. Tsirkin wrote: On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: From: Liu Jiang The standard virtio-mmio devices use notification register to

Re: [PATCH 1/2] NetRxPkt: Introduce support for additional hash types

2020-02-12 Thread Jason Wang
On 2020/2/12 下午4:50, Yuri Benditovich wrote: Hi Jason, Can you please review these 2 patches and apply if there are no objections. Thanks, Yuri Benditovich Applied. Thanks

Re: [PATCH v5 09/26] nvme: add temperature threshold feature

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > It might seem wierd to implement this feature for an emulated device, > but it is mandatory to support and the feature is useful for testing > asynchronous event request support, which will be added in a later > patch. Absolutely but as the

Re: [PATCH v5 15/26] nvme: bump supported specification to 1.3

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > Add new fields to the Identify Controller and Identify Namespace data > structures accoding to NVM Express 1.3d. > > NVM Express 1.3d requires the following additional features: > - addition of the Namespace Identification Descriptor List

Re: [PATCH v3 5/7] ui/gtk: implement show-cursor option

2020-02-12 Thread Gerd Hoffmann
> > +if (s->opts->has_show_cursor && s->opts->show_cursor) { > > +s->null_cursor = NULL; /* default pointer */ > > +} else { > > +s->null_cursor = gdk_cursor_new_for_display(window_display, > > +GDK_BLANK_CURSOR); > > +

[PATCH v30 16/22] hw/char: RX62N serial communication interface (SCI)

2020-02-12 Thread Yoshinori Sato
This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v30 06/22] target/rx: CPU definition

2020-02-12 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-4-ys...@users.sourceforge.jp> Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable

[PATCH v30 18/22] hw/rx: Honor -accel qtest

2020-02-12 Thread Yoshinori Sato
From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-16-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé

[PATCH v30 03/22] hw/registerfields.h: Add 8bit and 16bit register macros

2020-02-12 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe

[PATCH v2 16/16] kvm: Implement region_resize() for atomic memory section resizes

2020-02-12 Thread David Hildenbrand
virtio-mem wants to resize (esp. grow) memory regions while the guest is already aware of them and makes use of them. Resizing a KVM slot can only currently be done by removing it and re-adding it. While the kvm slot is temporarily removed, VCPUs that try to read from these slots will fault.

[PATCH v2 05/16] pc: Support for virtio-mem-pci

2020-02-12 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- hw/i386/Kconfig | 1 + hw/i386/pc.c| 42 -- 2 files changed, 25 insertions(+), 18 deletions(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index cdc851598c..e8ce582edd 100644 --- a/hw/i386/Kconfig +++

[PATCH v2 10/16] hostmem: Factor out applying settings

2020-02-12 Thread David Hildenbrand
We want to reuse the functionality when resizing resizable memory region. Signed-off-by: David Hildenbrand --- backends/hostmem.c | 137 + 1 file changed, 76 insertions(+), 61 deletions(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index

[PATCH v2 fixed 11/16] util/mmap-alloc: Prepare for resizable mmaps

2020-02-12 Thread David Hildenbrand
When shrinking a mmap we want to re-reserve the already populated area. When growing a memory region, we want to populate starting with a given fd_offset. Prepare by allowing to pass these parameters. Also, let's make sure we always process full pages, to avoid unmapping/remapping pages that are

[PATCH v2 fixed 09/16] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve()

2020-02-12 Thread David Hildenbrand
We want to reserve a memory region without actually populating memory. Let's factor that out. Reviewed-by: Igor Kotrasinski Acked-by: Murilo Opsfelder Araujo Reviewed-by: Richard Henderson Cc: "Michael S. Tsirkin" Cc: Greg Kurz Cc: Murilo Opsfelder Araujo Cc: Eduardo Habkost Cc: "Dr. David

[PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-12 Thread David Hildenbrand
Factor it out and add a comment. Reviewed-by: Igor Kotrasinski Acked-by: Murilo Opsfelder Araujo Reviewed-by: Richard Henderson Cc: "Michael S. Tsirkin" Cc: Murilo Opsfelder Araujo Cc: Greg Kurz Cc: Eduardo Habkost Cc: "Dr. David Alan Gilbert" Cc: Igor Mammedov Signed-off-by: David

[PATCH v2 fixed 10/16] util/mmap-alloc: Factor out populating of memory to mmap_populate()

2020-02-12 Thread David Hildenbrand
We want to populate memory within a reserved memory region. Let's factor that out. Reviewed-by: Richard Henderson Acked-by: Murilo Opsfelder Araujo Cc: Igor Kotrasinski Cc: "Michael S. Tsirkin" Cc: Greg Kurz Cc: Murilo Opsfelder Araujo Cc: Eduardo Habkost Cc: "Dr. David Alan Gilbert" Cc:

[PATCH v2 fixed 00/16] Ram blocks with resizable anonymous allocations under POSIX

2020-02-12 Thread David Hildenbrand
We already allow resizable ram blocks for anonymous memory, however, they are not actually resized. All memory is mmaped() R/W, including the memory exceeding the used_length, up to the max_length. When resizing, effectively only the boundary is moved. Implement actually resizable anonymous

Re: [PATCH v2 01/16] virtio-mem: Prototype

2020-02-12 Thread Eric Blake
On 2/12/20 7:35 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- It's at least worth mentioning VirtioMEMDeviceInfo in the commit message, to make it easier to find which commit introduces a given QAPI struct when searching the git log. +++ b/qapi/misc.json @@ -1557,19

Re: [PATCH v30 00/22] Add RX archtecture support

2020-02-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id:

RE: [PATCH 1/2] tcg: Add tcg_gen_gvec_5_ptr

2020-02-12 Thread Taylor Simpson
Reviewed-by: Taylor Simpson > -Original Message- > From: Richard Henderson > Sent: Tuesday, February 11, 2020 8:52 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; alex.ben...@linaro.org; Taylor Simpson > > Subject: [PATCH 1/2] tcg: Add tcg_gen_gvec_5_ptr > > Extend the

RE: [PATCH 2/2] target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA

2020-02-12 Thread Taylor Simpson
Reviewed-by: Taylor Simpson > -Original Message- > From: Richard Henderson > Sent: Tuesday, February 11, 2020 8:52 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; alex.ben...@linaro.org; Taylor Simpson > > Subject: [PATCH 2/2] target/arm: Use tcg_gen_gvec_5_ptr for sve >

Re: [PATCH v5 22/26] nvme: support multiple namespaces

2020-02-12 Thread Maxim Levitsky
On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > themselves with the nvme

[PATCH v30 04/22] target/rx: TCG translation

2020-02-12 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v30 07/22] target/rx: RX disassembler

2020-02-12 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480

[PATCH v30 00/22] Add RX archtecture support

2020-02-12 Thread Yoshinori Sato
and rx_load_image move to rx-virt. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20200212 Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ gzip -d u-boot.bin.gz $ qemu-system-rx -bios u-boot.bin linux

[PATCH v2 04/16] numa: Handle virtio-mem in NUMA stats

2020-02-12 Thread David Hildenbrand
Account the memory to the configured nide. Signed-off-by: David Hildenbrand --- hw/core/numa.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 601cf9f603..4deb27ebee 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -855,10

[PATCH v2 01/16] virtio-mem: Prototype

2020-02-12 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- hw/virtio/Kconfig | 11 + hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-mem.c | 805 + include/hw/virtio/virtio-mem.h | 83 qapi/misc.json | 39 +- 5 files changed, 938

[PATCH v2 03/16] hmp: Handle virtio-mem when printing memory device infos

2020-02-12 Thread David Hildenbrand
Print the memory device info just like other memory devices. Signed-off-by: David Hildenbrand --- monitor/hmp-cmds.c | 16 1 file changed, 16 insertions(+) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 558fe06b8f..798aead52e 100644 --- a/monitor/hmp-cmds.c +++

[PATCH v2 00/16] Ram blocks with resizable anonymous allocations under POSIX

2020-02-12 Thread David Hildenbrand
We already allow resizable ram blocks for anonymous memory, however, they are not actually resized. All memory is mmaped() R/W, including the memory exceeding the used_length, up to the max_length. When resizing, effectively only the boundary is moved. Implement actually resizable anonymous

[PATCH v2 07/16] memory: Add memory_region_max_size() and memory_region_is_resizable()

2020-02-12 Thread David Hildenbrand
We want to pass resizable memory regions to devices that can deal with them (and autoamtically resize them). Allow them to easily identify if a region can be resized and what the maximum size is. Add both functions, adding qemu_ram_is_resizable() as a helper. Signed-off-by: David Hildenbrand

[PATCH v2 02/16] virtio-pci: Proxy for virtio-mem

2020-02-12 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-mem-pci.c | 136 + hw/virtio/virtio-mem-pci.h | 33 + include/hw/pci/pci.h | 1 + 4 files changed, 171 insertions(+) create mode 100644

Re: [PATCH] nbd-client: Support leading / in NBD URI

2020-02-12 Thread Richard W.M. Jones
On Tue, Feb 11, 2020 at 08:31:01PM -0600, Eric Blake wrote: > The NBD URI specification [1] states that only one leading slash at > the beginning of the URI path component is stripped, not all such > slashes. This becomes important to a patch I just proposed to nbdkit > [2], which would allow the

[PATCH v2 fixed 06/16] exec: Reuse qemu_ram_apply_settings() in qemu_ram_remap()

2020-02-12 Thread David Hildenbrand
I don't see why we shouldn't apply all settings to make it look like the surrounding RAM (and enable proper VMA merging). Note: memory backend settings might have overridden these settings. We would need a callback to let the memory backend fix that up. Reviewed-by: Richard Henderson Cc:

Re: [PATCH v2 00/16] Ram blocks with resizable anonymous allocations under POSIX

2020-02-12 Thread David Hildenbrand
On 12.02.20 14:35, David Hildenbrand wrote: > We already allow resizable ram blocks for anonymous memory, however, they > are not actually resized. All memory is mmaped() R/W, including the memory > exceeding the used_length, up to the max_length. > > When resizing, effectively only the boundary

Re: Summary of Re: Making QEMU easier for management tools and applications

2020-02-12 Thread Daniel P . Berrangé
On Wed, Feb 12, 2020 at 01:54:42PM +, Stefan Hajnoczi wrote: > On Mon, Feb 10, 2020 at 05:43:13PM +0100, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > > > On Tue, Feb 4, 2020 at 3:54 PM Markus Armbruster > > > wrote: > > >> = Ways to provide machine-friendly initial

Re: [PATCH v2 01/16] virtio-mem: Prototype

2020-02-12 Thread David Hildenbrand
On 12.02.20 15:15, Eric Blake wrote: > On 2/12/20 7:35 AM, David Hildenbrand wrote: >> Signed-off-by: David Hildenbrand >> --- > > It's at least worth mentioning VirtioMEMDeviceInfo in the commit > message, to make it easier to find which commit introduces a given QAPI > struct when searching

Re: [PATCH] docs: Fix virtiofsd.1 location

2020-02-12 Thread Daniel P . Berrangé
On Wed, Feb 12, 2020 at 02:18:19PM +, Peter Maydell wrote: > On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina wrote: > > > > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man > > page virtiofsd.1. Unfortunately, wrong file location is used as > > source for install command.

Re: [PATCH v30 00/22] Add RX archtecture support

2020-02-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id:

Re: [PATCH v30 00/22] Add RX archtecture support

2020-02-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id:

  1   2   3   4   >