A JSON block comment like this:
Returns: nothing on success
If @node is not a valid block device, DeviceNotFound
If @name is not found, GenericError with an explanation
renders like this:
Returns: nothing on success If node is not a valid block device,
DeviceNotFound If
rST insists on a blank line before and after a bulleted list,
but our texinfo doc generator did not. Add some extra blank
lines in the doc comments so they're acceptable rST input.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
qapi/block-core.json | 1 +
qapi/char.json
On 2/6/20 5:09 AM, Christian Borntraeger wrote:
On 05.02.20 19:21, Jason J. Herne wrote:
This fixes vfio-ccw when booting non-Linux operating systems. Without this
struct being packed, a few extra bytes of low core memory get overwritten when
we assign a value to memory address 0 in
Store the smp sockets in CpuTopology. The socket information required to
build the apic id in EPYC mode. Right now socket information is not passed
to down when decoding the apic id. Add the socket information here.
Signed-off-by: Babu Moger
Reviewed-by: Eduardo Habkost
---
hw/core/machine.c
Update structures X86CPUTopoIDs and CPUX86State to hold the nodes_per_pkg.
This is required to build EPYC mode topology.
Signed-off-by: Babu Moger
---
hw/i386/pc.c |1 +
hw/i386/x86.c |2 ++
include/hw/i386/topology.h |2 ++
include/hw/i386/x86.h |
On 2020-02-13 17:29, Cornelia Huck wrote:
Move to system/, as this is mostly about configuring vfio-ap.
Signed-off-by: Cornelia Huck
---
MAINTAINERS | 2 +-
docs/system/index.rst| 1 +
docs/{vfio-ap.txt => system/vfio-ap.rst} | 796
On Fri, 31 Jan 2020 17:02:46 PST (-0800), Alistair Francis wrote:
Mark both sstatus and vsstatus as dirty (3).
Signed-off-by: Alistair Francis
---
target/riscv/translate.c | 12
1 file changed, 12 insertions(+)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
David Hildenbrand wrote:
> Resizing while migrating is dangerous and does not work as expected.
> The whole migration code works on the usable_length of ram blocks and does
> not expect this to change at random points in time.
>
> Precopy: The ram block size must not change on the source, after
>
Daniel P. Berrangé wrote:
> On Wed, Jan 29, 2020 at 12:56:48PM +0100, Juan Quintela wrote:
>> This will store the compression method to use. We start with none.
>>
>> Signed-off-by: Juan Quintela
>> Reviewed-by: Markus Armbruster
>> Reviewed-by: Dr. David Alan Gilbert
>> ---
>>
On 13.02.20 19:32, Peter Xu wrote:
> On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote:
>> Resizing while migrating is dangerous and does not work as expected.
>> The whole migration code works on the usable_length of ram blocks and does
>> not expect this to change at random
On 2/11/20 11:45 AM, Philippe Mathieu-Daudé wrote:
Use NetBSD content delivery network to get faster downloads.
Suggested-by: Kamil Rytarowski
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/ppc_prep_40p.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
LGTM.
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> hw/core/qdev-properties.c| 2 +-
>> migration/Makefile.objs | 1 +
>> migration/migration.c| 9 +
>> migration/migration.h| 1 +
>>
On Thu, Feb 13, 2020 at 09:43:34AM +0100, Markus Armbruster wrote:
> Supporting a build platform beyond its end of life makes no sense.
> Spell that out just to be clear.
>
> Signed-off-by: Markus Armbruster
Thanks!
Reviewed-by: Eduardo Habkost
> ---
> qemu-doc.texi | 9 +
> 1 file
Add it to several build systems to make testing good.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
.gitlab-ci.yml| 1 +
.travis.yml | 1 +
configure | 30
The ascii-art graph in the BlockLatencyHistogramInfo documentation
doesn't render correctly, because the whitespace is collapsed.
Use the '|' format that emits a literal 'example' block so the graph
is displayed correctly.
Strictly the texinfo generated is still wrong because each line
goes into
The doc comment for GuestDiskBusType doesn't match up with the
enumeration because of a missing hyphen in 'file-backed-virtual'.
This means the docs are rendered wrongly:
"virtual"
Win virtual bus type "file-backed" virtual: Win file-backed bus type
"file-backed-virtual"
The texinfo doc generation doesn't care much about indentation
levels, but we would like to add a rST backend, and rST does care
about indentation.
Make the doc comments more strongly consistent about indentation
for multiline constructs like:
@arg: description line 1
description line 2
Avoid texinfo style quoting with `...', because rST treats it
as a syntax error. Use '...' instead, as we do in other
doc comments. This looks OK in texinfo, and rST formats it as
paired-quotation-marks.
Signed-off-by: Peter Maydell
Reviewed-by: Markus Armbruster
---
qapi/ui.json | 24
Initialize all the parameters in one function init_topo_info.
Move the data structure X86CPUTopoIDs and X86CPUTopoInfo into
x86.h.
Signed-off-by: Babu Moger
Reviewed-by: Eduardo Habkost
---
hw/i386/pc.c |4 +---
hw/i386/x86.c | 14 +++---
If the system is numa configured the pkg_offset needs
to be adjusted for EPYC cpu models. Fix it calling the
model specific handler.
Signed-off-by: Babu Moger
---
hw/i386/pc.c |1 +
hw/i386/x86.c |4
target/i386/cpu.c |4 ++--
target/i386/cpu.h |1 +
4 files
On 2/12/20 6:36 PM, Philippe Mathieu-Daudé wrote:
The www.helenos.org server is slow and downloading the Leon3 binary
takes too long [*]. Do not include this test in the default suite.
Similarly to commit 471c97a69b:
Currently the Avocado framework does not distinct the time spent
Our current QAPI doc-comment markup allows section headers
(introduced with a leading '=' or '==') anywhere in any documentation
comment. This works for texinfo because the texi generator simply
prints a texinfo heading directive at that point in the output
stream. For rST generation, since
Some qapi doc comments have forgotten the ':' after the
@argument, like this:
# @filename Filename for the new image file
# @size Size of the virtual disk in bytes
The result is that these are parsed as part of the body
text and appear as a run-on line:
filename Filename
Some of our documentation is auto-generated from documentation
comments in the JSON schema.
For Sphinx, rather than creating a file to include, the most natural
way to handle this is to have a small custom Sphinx extension which
processes the JSON file and inserts documentation into the rST
file
This is an effort to re-arrange few data structure for better readability.
Add X86CPUTopoInfo which will have all the topology informations required
to build the cpu topology. There is no functional changes.
Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
---
hw/i386/pc.c |
For consistancy rename apicid_from_topo_ids to x86_apicid_from_topo_ids.
No functional change.
Signed-off-by: Babu Moger
---
hw/i386/pc.c |2 +-
include/hw/i386/topology.h |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
This parameter specifies the zstd compression level. The next patch
will put it to use.
Signed-off-by: Juan Quintela
Acked-by: Markus Armbruster
---
migration/migration.c | 24
migration/migration.h | 1 +
monitor/hmp-cmds.c| 4
qapi/migration.json | 29
This parameter specifies the zlib compression level. The next patch
will put it to use.
Signed-off-by: Juan Quintela
Acked-by: Markus Armbruster
Reviewed-by: Dr. David Alan Gilbert
---
migration/migration.c | 24
migration/migration.h | 1 +
monitor/hmp-cmds.c|
Fix a typo in the dependency list for the manpages built from the
'interop' manual, which meant we were accidentally not including
the .hx file in the dependency list.
Fixes: e13c59fa4414215500e6
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
Makefile | 2 +-
1 file
In the doc comment for input-send-event, there is a multi-line
chunk of text ("The @device...take precedence") which is intended
to be the main body text describing the event. However it has
been placed after the arguments and Returns: section, which
means that the parser actually thinks that this
We no longer use the generated texinfo format documentation,
so delete the code that generates it, and the test case for
the generation.
Signed-off-by: Peter Maydell
---
Makefile| 1 -
tests/Makefile.include | 15 +-
scripts/qapi-gen.py | 2 -
Rename few data structures related to X86 topology. X86CPUTopoIDs will
have individual arch ids. Next patch introduces X86CPUTopoInfo which will
have all topology information(like cores, threads etc..).
Signed-off-by: Babu Moger
Reviewed-by: Eduardo Habkost
---
hw/i386/pc.c |
Now that we have all the parameters in X86CPUTopoInfo, we can just
pass the structure to calculate the offsets and width.
Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
---
include/hw/i386/topology.h | 64 ++--
target/i386/cpu.c | 23
Update the documentation of QAPI document comment syntax to match
the new rST backend requirements. The principal changes are:
* whitespace is now significant, and multiline definitions
must have their second and subsequent lines indented to
match the first line
* general rST format markup
As we accumulate lines from doc comments when parsing the JSON, the
QAPIDoc class generally strips leading and trailing whitespace using
line.strip() when it calls _append_freeform(). This is fine for
texinfo, but for rST leading whitespace is significant. We'd like to
move to having the text in
Add the new EPYC model specific handlers to fix the apicid decoding.
The APIC ID is decoded based on the sequence sockets->dies->cores->threads.
This works fine for most standard AMD and other vendors' configurations,
but this decoding sequence does not follow that of AMD's APIC ID enumeration
Load the model specific handlers if available or else default handlers
will be loaded. Add the model specific handlers if apicid decoding
differs from the standard sequential numbering.
Signed-off-by: Babu Moger
---
target/i386/cpu.c | 38 ++
Check and Load the apicid handlers from X86CPUDefinition if available.
Update the calling convention for the apicid handlers.
Signed-off-by: Babu Moger
---
hw/i386/pc.c |6 +++---
hw/i386/x86.c | 27 +++
2 files changed, 26 insertions(+), 7 deletions(-)
diff
On 13.02.20 20:09, Juan Quintela wrote:
> David Hildenbrand wrote:
>> Resizing while migrating is dangerous and does not work as expected.
>> The whole migration code works on the usable_length of ram blocks and does
>> not expect this to change at random points in time.
>>
>> Precopy: The ram
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> So we don't have to compile everything in, or have ifdefs
>>
>> Signed-off-by: Juan Quintela
>
> As far as I can tell this matches the way all the rest of the module
> stuff works, so:
>
> Reviewed-by: Dr. David
On 2/11/20 7:42 AM, Thomas Huth wrote:
Now that we can select the second serial console in the acceptance tests
(see commit 746f244d9720 "Allow to use other serial consoles than default"),
we can also test the sh4 image from the QEMU advent calendar 2018.
And another recent commit
On 2/11/20 11:19 AM, Philippe Mathieu-Daudé wrote:
The ftp.netbsd.org server is slow and downloading the NetBSD ISO
takes too long. Do not include this test in the default suite.
Similarly to commit 471c97a69b:
Currently the Avocado framework does not distinct the time spent
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> hw/core/qdev-properties.c| 2 +-
>> migration/Makefile.objs | 1 +
>> migration/migration.c| 9 +
>> migration/migration.h| 1 +
>>
Patchew URL:
https://patchew.org/QEMU/20200213175647.17628-1-peter.mayd...@linaro.org/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
Signed-off-by: Juan Quintela
Acked-by: Markus Armbruster
Reviewed-by: Dr. David Alan Gilbert
---
hw/core/qdev-properties.c| 2 +-
migration/Makefile.objs | 1 +
migration/multifd-zstd.c | 339 +++
migration/multifd.h | 1 +
On Thu, Feb 13, 2020 at 03:21:47PM +0100, Christian Borntraeger wrote:
> QEMU has a funny new build error message when I use the upstream kernel
> headers:
>
> CC block/file-posix.o
> In file included from /home/cborntra/REPOS/qemu/include/qemu/timer.h:4,
> from
>
It will be used later.
Signed-off-by: Juan Quintela
---
No comp value needs to be zero.
---
migration/migration.c | 9 ++
migration/migration.h | 1 +
migration/multifd.c | 185 --
migration/multifd.h | 26 ++
migration/ram.c | 1 +
Although documented in the comments we don't display all the various
invocations we can in the usage.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
---
tests/rcutorture.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/rcutorture.c
Hi,
I've ended up combining my accumulated testing fixes with the plugin
fixes as there is some cross-over between the two. On the testing side
I still haven't seen rcutorture trip up on my branches but the final
patch that light re-factors it needs to be reviewed. I've also added
some fixes for
On Thu, Feb 13, 2020 at 04:38:38PM +0100, Greg Kurz wrote:
> Until the CAS negotiation is over, an HPT can be allocated on three
> different paths:
>
> 1) during machine reset if the host doesn't support radix,
>
> 2) during CAS if the guest wants hash and doesn't support HPT resizing,
>in
Otherwise any -D settings the user may have made get ignored.
Signed-off-by: Alex Bennée
---
trace/control.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/trace/control.c b/trace/control.c
index 6c775e68eba..2ffe0008184 100644
--- a/trace/control.c
+++
On 2/13/20 12:37 AM, Philippe Mathieu-Daudé wrote:
> Hi Sven, Helge.
>
> On 12/20/19 10:15 PM, Sven Schnelle wrote:
>> From: Helge Deller
>>
>> The tests of the dino chip with the Online-diagnostics CD
>> ("ODE DINOTEST") now succeeds.
>> Additionally add some qemu trace events.
>>
>>
On Fri, 14 Feb 2020 01:41:35 +0530
Kirti Wankhede wrote:
>
>
>
> +static int vfio_iova_dirty_bitmap(struct vfio_iommu *iommu, dma_addr_t
> iova,
> + size_t size, uint64_t pgsize,
> + unsigned char
On Fri, Feb 14, 2020 at 12:57:34AM +0100, BALATON Zoltan wrote:
> "Deferred" was misspelled as "differed" in some comments, correct this
> typo,
>
> Signed-off-by: BALATON Zoltan
Applied to ppc-for-5.0, thanks.
> ---
> target/ppc/fpu_helper.c| 2 +-
>
On 2/13/20 11:51 PM, Alex Bennée wrote:
> From: "Emilio G. Cota"
>
> Reported-by: Robert Henry
> Signed-off-by: Emilio G. Cota
> Signed-off-by: Alex Bennée
> Reviewed-by: Richard Henderson
> Message-Id: <20200105072940.32204-1-c...@braap.org>
Fixes: 54cb65d8588
Reviewed-by: Philippe
On Thu, Feb 13, 2020 at 10:17:04AM +, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.y...@linux.intel.com) wrote:
>> ram_discard_range() unmap page for specific range. To be specific, this
>> clears related page table entries so that userfault would be triggered.
>> But this step is not
3:26 PM Čet, 13.02.2020. Filip Bozuta је
написао/ла:
>
> +int main(int argc, char **argv)
> +{
> +char ioctls[15][35] = {"SNDRV_TIMER_IOCTL_PVERSION",
> + "SNDRV_TIMER_IOCTL_INFO",
> + "SNDRV_TIMER_IOCTL_NEXT_DEVICE",
> +
This still seems to be a problem for Travis.
Signed-off-by: Alex Bennée
---
.travis.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 0612998958b..f4020dcc6c8 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -400,7 +400,7 @@ jobs:
-
This is pure code motion with no functional effect.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
---
tests/rcutorture.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/tests/rcutorture.c b/tests/rcutorture.c
index e8b2169e7dd..256d24ed5ba
From: Chen Qun
According to the glibc function requirements, we need initialise
the variable. Otherwise there will be compilation warnings:
glib-autocleanups.h:28:3: warning: ‘out’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
g_free (*pp);
^~~~
Reported-by:
Coverity reports:
*** CID 1419393: Memory - corruptions (OVERRUN)
/hw/hppa/dino.c: 363 in dino_chip_write_with_attrs()
357 /* These registers are read-only. */
358 break;
359
360 case DINO_GMASK ... DINO_TLTIM:
361 i = (addr -
Register 0x818 is documented as 'undefined', and register
0x82c is not documented. Refuse their access.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/hppa/dino.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index be799aad43..2b1b38c58a
Add a comment with the name of each register in the 0x800-0x833 range.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/hppa/dino.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index 9797a7f0d9..c237ad3b1b 100644
---
On 13/02/2020 21:17, Paolo Bonzini wrote:
> On 13/02/20 02:43, Alexey Kardashevskiy wrote:
>>
>> Ok. So, I have made a small firmware which does OF CI, loads GRUB and
>> instantiates RTAS:
>> https://github.com/aik/of1275
>> Quite raw but gives the idea.
>>
>> It does not contain drivers and
"Deferred" was misspelled as "differed" in some comments, correct this
typo,
Signed-off-by: BALATON Zoltan
---
target/ppc/fpu_helper.c| 2 +-
target/ppc/translate/fp-impl.inc.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/ppc/fpu_helper.c
TCG plugins are responsible for their own memory usage and although
the plugin_exit is tied to the end of execution in this case it is
still poor practice. Ensure we delete the hash table and related data
when we are done to be a good plugin citizen.
Signed-off-by: Alex Bennée
Reviewed-by:
On Thu, Feb 13, 2020 at 12:46:43PM +0100, Greg Kurz wrote:
> On Thu, 13 Feb 2020 11:58:35 +1100
> David Gibson wrote:
>
> > Upcoming Secure VM support for pSeries machines introduces some
> > complications for virtio, since the transfer buffers need to be
> > explicitly shared so that the
Although most people use the docker images this can trip up on
developer systems with actual valid cross-compilers!
Signed-off-by: Alex Bennée
---
tests/tcg/configure.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index
On Thu, Feb 13, 2020 at 03:34:25PM +0100, Greg Kurz wrote:
> On Thu, 13 Feb 2020 11:58:36 +1100
> David Gibson wrote:
>
> > PAPR specifies a kind of odd, paravirtualized PCI bus, which looks to
> > the guess mostly like classic PCI, even if some of the individual
> > devices on the bus are PCI
When combined with heavy plugins we occasionally hit the timeouts.
Signed-off-by: Alex Bennée
---
tests/tcg/Makefile.target | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index 3c7421a356e..b3cff3cad1a 100644
---
Only 24 bits of the PCIROR register are documented
(see pp. 37 of datasheet referenced in this file header).
Signed-off-by: Philippe Mathieu-Daudé
---
hw/hppa/dino.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index 8868e31793..be799aad43
Easy fix for the overrun reported by Coverity.
Last 2 patches are RFC because I haven't tested them,
I simply took note while reviewing the datasheet (I
also checked the errata).
Philippe Mathieu-Daudé (4):
hw/hppa/dino: Add comments with register name
hw/hppa/dino: Fix reg800_keep_bits[]
On 2/13/20 11:51 PM, Alex Bennée wrote:
> Although most people use the docker images this can trip up on
> developer systems with actual valid cross-compilers!
>
Oops =)
Fixes: bb516dfc5b3
Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Alex Bennée
> ---
> tests/tcg/configure.sh | 2 +-
On 2/13/20 11:51 PM, Alex Bennée wrote:
> When combined with heavy plugins we occasionally hit the timeouts.
>
> Signed-off-by: Alex Bennée
> ---
> tests/tcg/Makefile.target | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/Makefile.target
From: Yoshinori Sato
Signed-off-by: Yoshinori Sato
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Signed-off-by: Alex Bennée
Message-Id:
I forgot to document the lifetime of handles in the developer
documentation. Do so now.
Signed-off-by: Alex Bennée
Reviewed-by: Robert Foley
Reviewed-by: Robert Foley
---
docs/devel/tcg-plugins.rst | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git
At least on ZFS this was failing as 512 was less than or equal to 512.
I suspect the reason is additional compression done by ZFS and however
qemu-img gets the actual size.
Loosen the criteria to make sure after is not bigger than before and
also dump the values in the report.
Signed-off-by:
From: Thomas Huth
Since we can now use a s390x host on Travis, we can also build and
test the s390-ccw bios images there. For this we have to make sure
that roms/SLOF is checked out, too, and then move the generated *.img
files to the right location before running the tests.
Signed-off-by:
The plugin system would throw up a harmless warning when it detected
that a disassembly of an instruction didn't use all it's bytes. Fix
the riscv decoder to only load the instruction bytes it needs as it
needs them.
This drops opcode from the ctx in favour if passing the appropriately
sized
Pointer authentication isn't perfect so measure the percentage of
failed checks. As we want to vary the pointer that is authenticated we
recurse down the stack.
Signed-off-by: Alex Bennée
---
tests/tcg/aarch64/pauth-4.c | 54 +
1 file changed, 37
Coverity reports:
*** CID 1419388: Control flow issues (DEADCODE)
/hw/display/artist.c: 739 in draw_line_xy()
733 if (endy < 0) {
734 endy = 0;
735 }
736
737
738 if (endx < 0) {
>>> CID 1419388: Control flow issues (DEADCODE)
>>>
Signed-off-by: Philippe Mathieu-Daudé
---
RFC because untested =)
---
hw/display/artist.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 97c811b35e..5492079116 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -557,90 +557,93 @@
We want to have an early exit path. Delay some initializations
before the variables are used.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/artist.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index
We are initializating incy inconditionally:
if (y1 <= y2) {
incy = 1;
} else {
incy = -1;
}
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/artist.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index
Another easy Coverity fix.
Philippe Mathieu-Daudé (5):
hw/display/artist: Move trace event to draw_line()
hw/display/artist: Remove pointless initialization
hw/display/artist: Delay some variables initialization
hw/display/artist: Avoid drawing line when nothing to display
Instead of emitting the trace event before each call to
draw_line(), call it once at draw_line() entrance.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/artist.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index
The command is 32-bit, but we are loading the 16 upper bits with
the 'get_uint16(s->scb + 2)' call.
Once shifted by 16, the command bits match the status bits:
- Command
Bit 31 ACK-CX Acknowledges that the CU completed an Action Command.
Bit 30 ACK-FR Acknowledges that the RU received a
On Thu, Feb 13, 2020 at 3:08 PM Alex Bennée wrote:
>
> The plugin system would throw up a harmless warning when it detected
> that a disassembly of an instruction didn't use all it's bytes. Fix
> the riscv decoder to only load the instruction bytes it needs as it
> needs them.
>
> This drops
This is mainly to help with reasoning what the test is trying to do.
We can move rcu_stress_idx to a local variable as there is only ever
one updater thread. I've also added an assert to catch the case where
we end up updating the current structure to itself which is the only
way I can see the
From: "Emilio G. Cota"
Reported-by: Robert Henry
Signed-off-by: Emilio G. Cota
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-Id: <20200105072940.32204-1-c...@braap.org>
Cc: qemu-sta...@nongnu.org
---
plugins/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git
From: Wainer dos Santos Moschetta
This fixes the following warnings Travis has detected on the
YAML configuration:
- 'on root: missing os, using the default "linux"'
- 'on root: the key matrix is an alias for jobs, using jobs'
- 'on jobs.include.python: unexpected sequence, using the first
If we have plugins enabled we still need to have built the test to be
able to run it.
Signed-off-by: Alex Bennée
---
tests/tcg/aarch64/Makefile.softmmu-target | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/tcg/aarch64/Makefile.softmmu-target
6:59 PM Čet, 13.02.2020. Peter Maydell је
написао/ла:
>
> The ascii-art graph
Just out of couriousity, are unicode characters allowed in rst files?
The boxes could've been rendered in a much more beautifull way using "lines
and corners" group of unicode characters.
Aleksandar
> in the
From: Richard Henderson
While do_gen_mem_cb does copy (via extu_tl_i64) vaddr into a new temp
this won't help if the vaddr temp gets clobbered by the actual
load/store op. To avoid this clobbering we explicitly copy vaddr
before the op to ensure it is live my the time we do the
instrumentation.
Patchew URL:
https://patchew.org/QEMU/20200213225109.13120-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v2 00/19] testing and plugin updates
Message-id:
On 2/14/20 12:57 AM, BALATON Zoltan wrote:
> "Deferred" was misspelled as "differed" in some comments, correct this
> typo,
>
Fixes: 7c58044c
Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: BALATON Zoltan
> ---
> target/ppc/fpu_helper.c| 2 +-
>
On Mon, Feb 10, 2020 at 12:26:07PM +0100, Paolo Bonzini wrote:
> On 10/02/20 08:28, David Gibson wrote:
> > On Thu, Feb 06, 2020 at 09:27:01AM +0100, Paolo Bonzini wrote:
> >> On 05/02/20 07:06, David Gibson wrote:
> >>> On Tue, Feb 04, 2020 at 12:26:32AM +0100, Paolo Bonzini wrote:
> >> I'm
Xilinx USB devices are now instantiated through TYPE_CHIPIDEA,
and xlnx support in the EHCI code is no longer needed.
Signed-off-by: Guenter Roeck
---
hw/usb/hcd-ehci-sysbus.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/hw/usb/hcd-ehci-sysbus.c
USB ports must be instantiated as TYPE_CHIPIDEA to work.
Linux expects and checks various chipidea registers, which
do not exist with the basic ehci emulation.
Without this patch, USB ports fail to instantiate under Linux.
ci_hdrc ci_hdrc.0: doesn't support host
ci_hdrc ci_hdrc.0: no supported
On 2/13/20 9:31 PM, Peter Maydell wrote:
On Thu, 13 Feb 2020 at 03:49, Gavin Shan wrote:
On 2/12/20 10:34 PM, Peter Maydell wrote:
Yeah, this is on my list to look at; Richard Henderson also could
have a look at it. From a quick scan I suspect you may be missing
handling for AArch32.
Yes,
201 - 300 of 373 matches
Mail list logo
