Markus Armbruster writes:
> Peter Maydell writes:
>
>> Some qapi doc comments have forgotten the ':' after the
>> @argument, like this:
>>
>> # @filename Filename for the new image file
>> # @size Size of the virtual disk in bytes
>>
>> The result is that these are parsed as
Add Migration support. We rely on recently added gtree and qlist
migration. We only migrate the domain gtree. The endpoint gtree
is re-constructed in a post-load operation.
Signed-off-by: Eric Auger
Acked-by: Peter Xu
Reviewed-by: Juan Quintela
Reviewed-by: Michael S. Tsirkin
---
v15 ->
This patch implements virtio_iommu_map/unmap.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v11 -> v12:
- check unmanaged managed flags on map
- removed 2 qemu_log_mask in unmap()
- fix leak
v10 -> v11:
- revisit the implementation of unmap according to
This patchs adds the skeleton for the virtio-iommu device.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v13 -> v14:
- use device_class_set_props
- updated copyright's year
v12 -> v13
- removed IOMMU_PCI_BUS_MAX and IOMMU_PCI_DEVFN_MAX
v11 -> v12:
-
The event queue allows to report asynchronous errors.
The translate function now injects faults when relevant.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v13 -> v14:
- remove loop
- add Peter's R-b
v12 -> v13:
- return on virtio_error()
v11 -> v12:
-
This patch implements the endpoint attach/detach to/from
a domain.
Domain and endpoint internal datatypes are introduced.
Both are stored in RB trees. The domain owns a list of
endpoints attached to it. Also helpers to get/put
end points and domains are introduced.
As for the IOMMU memory
This patch implements the translate callback
Signed-off-by: Eric Auger
Reviewed-by: Jean-Philippe Brucker
Reviewed-by: Michael S. Tsirkin
---
v11 -> v12:
- Added Jean's R-b
- s/qemu_log_mask/error_report_once
v10 -> v11:
- take into account the new value struct and use
This patch adds the command payload decoding and
introduces the functions that will do the actual
command handling. Those functions are not yet implemented.
Signed-off-by: Eric Auger
Reviewed-by: Jean-Philippe Brucker
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v11 -> v12:
-
This series implements the QEMU virtio-iommu device.
This matches the v0.12 spec (voted) and the corresponding
virtio-iommu driver upstreamed in 5.3. All kernel dependencies
are resolved for DT integration. The virtio-iommu can be
instantiated in ARM virt using:
"-device virtio-iommu-pci".
Non
Hi Marc-Andre,
On Tue, 2020-02-11 at 22:24 +0100, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 11, 2020 at 4:24 PM Boeuf, Sebastien
> wrote:
> > From c073d528b8cd7082832fd1825dc33dd65b305aa2 Mon Sep 17 00:00:00
> > 2001
> > From: Sebastien Boeuf
> > Date: Tue, 11 Feb 2020 16:01:22 +0100
> >
Am 11.02.2020 um 10:48 hat Kevin Wolf geschrieben:
> Kevin Wolf (3):
> qcow2: update_refcount(): Reset old_table_index after
> qcow2_cache_put()
> qcow2: Fix qcow2_alloc_cluster_abort() for external data file
> iotests: Test copy offloading with external data file
Applied to the block
Arm GIC in Zynq SOC implements 5 priority bits i.e bits 7..3.
Signed-off-by: Sai Pavan Boddu
---
hw/arm/xilinx_zynq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 3a0fa5b..7aa43ad 100644
--- a/hw/arm/xilinx_zynq.c
+++
Set number of priority bits property of gic as guided by machine
configuration.
Signed-off-by: Sai Pavan Boddu
---
hw/cpu/a9mpcore.c | 2 ++
include/hw/cpu/a9mpcore.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
index 1f8bc8a..eb1e752
Make sure that it compiles OK with RDMA compiled out; I think this is a
windows cross build that's failing, but more generally even a Linux box
with no-RDMA libraries.
Dave
* no-re...@patchew.org (no-re...@patchew.org) wrote:
> Patchew URL:
>
Priority bits implemented in arm-gic can 8 to 4, un-implemented bits
are read as zeros(RAZ).
Signed-off-by: Sai Pavan Boddu
---
hw/intc/arm_gic.c| 9 ++---
hw/intc/arm_gic_common.c | 1 +
include/hw/intc/arm_gic_common.h | 1 +
3 files changed, 8 insertions(+), 3
This patch series implements the mask for un-implemented priority bits
in arm-gic. Which will return the expected number of priority bits on
read.
Sai Pavan Boddu (3):
arm_gic: Mask the un-supported priority bits
cpu/a9mpcore: Add num priority bits property
arm/xilinx_zynq: Set number of
Public bug reported:
On AArch64 CPU with SVE register, there seems to be a bug in the
operation when executing EXT instruction to V registers. Bits above the
128 bits of the SVE register must be cleared to 0, but qemu-aarch64
seems to hold the value.
Example
ext v0.16b, v1.16b v2.16b, 8
After
Peter Maydell writes:
> On Fri, 7 Feb 2020 at 08:33, Markus Armbruster wrote:
>>
>> Peter Maydell writes:
>>
>> > rST format requires a blank line before the start of a bulleted
>> > or enumerated list. Two places in qapi-schema.json were missing
>> > this blank line.
>> >
>> > Some places
Am 09.02.2020 um 18:51 hat Hikaru Nishida geschrieben:
> Before this commit, BDRVVVFATState.qcow is unrefed in write_target_close
> on closing backing bdrv of vvfat. However, qcow bdrv is opend as a child
> of vvfat in enable_write_target() so it will be also unrefed on closing
> vvfat itself.
* David Hildenbrand (da...@redhat.com) wrote:
> On 12.02.20 14:42, David Hildenbrand wrote:
> > We already allow resizable ram blocks for anonymous memory, however, they
> > are not actually resized. All memory is mmaped() R/W, including the memory
> > exceeding the used_length, up to the
Peter Maydell writes:
> Some qapi doc comments have forgotten the ':' after the
> @argument, like this:
>
> # @filename Filename for the new image file
> # @size Size of the virtual disk in bytes
>
> The result is that these are parsed as part of the body
> text and appear as
Peter Maydell writes:
> The ascii-art graph in the BlockLatencyHistogramInfo documentation
> doesn't render correctly, because the whitespace is collapsed.
>
> Use the '|' format that emits a literal 'example' block so the graph
> is displayed correctly.
>
> Strictly the texinfo generated is
Am 13.02.2020 um 18:16 hat Alberto Garcia geschrieben:
> I/O requests to encrypted media should be aligned to the sector size
> used by the underlying encryption method, not to BDRV_SECTOR_SIZE.
> Fortunately this doesn't break anything at the moment because
> both existing
David Hildenbrand wrote:
I agree with the removed bits.
> diff --git a/migration/ram.c b/migration/ram.c
> index ed23ed1c7c..f86f32b453 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -52,6 +52,7 @@
> #include "migration/colo.h"
> #include "block.h"
> #include "sysemu/sysemu.h"
Peter Maydell writes:
> rST format requires a blank line before the start of a bulleted
> or enumerated list. Two places in qapi-schema.json were missing
> this blank line.
Relies on the previous commit message's "we would like to add a rST
backend" to establish context. Suggest:
We would
On Fri, 14 Feb 2020 at 12:36, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > The texinfo doc generation doesn't care much about indentation
>
> Let's spell Texinfo with a capital T.
>
> > levels, but we would like to add a rST backend, and rST does care
> > about indentation.
>
>
On Fri, 14 Feb 2020 at 12:20, Markus Armbruster wrote:
>
> Peter Maydell writes:
> >> # Default objcc to clang if available, otherwise use CC
> >> @@ -4803,7 +4816,7 @@ has_sphinx_build() {
> >> # sphinx-build doesn't exist at all or if it is too old.
> >> mkdir -p "$TMPDIR1/sphinx"
>
Keqian Zhu wrote:
> At the tail stage of throttle, VM is very sensitive to
> CPU percentage. We just throttle 30% of remaining CPU
> when throttle is more than 80 percentage.
Why?
If we really think that this is better that current approarch, just do
this _always_. And throothre 30% of
Peter Maydell writes:
> The texinfo doc generation doesn't care much about indentation
Let's spell Texinfo with a capital T.
> levels, but we would like to add a rST backend, and rST does care
> about indentation.
Nitpick: an rST *backend* should not care about the doc generator's
*input*
* Keqian Zhu (zhukeqi...@huawei.com) wrote:
> At the tail stage of throttle, VM is very sensitive to
> CPU percentage. We just throttle 30% of remaining CPU
> when throttle is more than 80 percentage.
This is a bit unusual; all of the rest of the throttling has no
fixed constants; all values are
Peter Maydell writes:
> On Fri, 14 Feb 2020 at 06:33, Markus Armbruster wrote:
>>
>> Does not work out of the box on my Fedora 30 build host, where
>> sphinx-build gives me sphinx-build-2. I have to specify
>> --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
>> breaks
On Thu, Feb 13, 2020 at 11:51 PM Alex Bennée wrote:
>
> This still seems to be a problem for Travis.
>
> Signed-off-by: Alex Bennée
> ---
> .travis.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 0612998958b..f4020dcc6c8 100644
On 14.02.20 12:08, David Hildenbrand wrote:
> On 14.02.20 12:02, Dr. David Alan Gilbert wrote:
>> * David Hildenbrand (da...@redhat.com) wrote:
>>> On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
* David Hildenbrand (da...@redhat.com) wrote:
> On 14.02.20 11:25, Dr. David Alan Gilbert
On Fri, Feb 14, 2020 at 10:56 AM Michal Privoznik wrote:
>
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Philippe
On Fri, Feb 14, 2020 at 10:20 AM Michal Privoznik wrote:
> On 2/14/20 9:47 AM, Michal Privoznik wrote:
> > In a few places we report errno formatted as a negative integer.
> > This is not as user friendly as it can be. Use strerror() and/or
> > error_setg_errno() instead.
> >
> > Signed-off-by:
On Fri, 14 Feb 2020 13:29:00 +1100
David Gibson wrote:
> On Mon, Feb 03, 2020 at 11:36:22PM +0100, Greg Kurz wrote:
> > Hot unplugging a device is an asynchronous operation. If the guest is
> > migrated after the event was sent but before it could release the
> > device with RTAS, the
Hi Mark,
On Fri, Feb 14, 2020 at 9:48 AM Mark Cave-Ayland
wrote:
>
> Remove the call to pci_cmd646_ide_init() since global device init functions
> are deprecated in preference of using qdev directly.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/alpha/dp264.c | 8 +++-
> 1 file changed, 7
On 2/13/20 9:27 PM, Keqian Zhu wrote:
At the tail stage of throttle, VM is very sensitive to
CPU percentage. We just throttle 30% of remaining CPU
when throttle is more than 80 percentage.
This doesn't conflict with cpu_throttle_increment.
This may make migration time longer, and is disabled
* Muhui Jiang (jiangmu...@gmail.com) wrote:
> Dear All
>
> I am recently using qemu-system-arm to boot a linux uImage.
>
> I would like to do some dynamic instrumentation on the uncompressed kernel.
> It seems that I need to focus on two key points.
>
> Firstly, I need to know when the kernel
On Sat, 8 Feb 2020 at 12:58, Richard Henderson
wrote:
>
> Include definitions for all of the bits in ID_MMFR3.
> We already have a definition for ID_AA64MMFR1.PAN.
>
> Reviewed-by: Alex Bennée
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> @@ -3443,6 +3452,16 @@ static
Hi Michal,
On 2/14/20 10:55 AM, Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
Reviewed-by: Eric Auger
Thanks
Eric
On 14.02.20 12:02, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
>>> * David Hildenbrand (da...@redhat.com) wrote:
On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com)
* David Hildenbrand (da...@redhat.com) wrote:
> On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> >>> * David Hildenbrand (da...@redhat.com) wrote:
> Resizing while migrating is dangerous
On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
>>> * David Hildenbrand (da...@redhat.com) wrote:
Resizing while migrating is dangerous and does not work as expected.
The whole migration
* David Hildenbrand (da...@redhat.com) wrote:
> On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> Resizing while migrating is dangerous and does not work as expected.
> >> The whole migration code works on the usable_length of ram blocks and
On Fri, 14 Feb 2020 10:55:19 +0100
Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
> ---
>
> v1 posted here:
>
>
On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> Resizing while migrating is dangerous and does not work as expected.
>> The whole migration code works on the usable_length of ram blocks and does
>> not expect this to change at random points in
On Thu, Feb 13, 2020 at 10:08:59PM +0100, Juan Quintela wrote:
> Daniel P. Berrangé wrote:
> > On Wed, Jan 29, 2020 at 12:56:53PM +0100, Juan Quintela wrote:
> >> Signed-off-by: Juan Quintela
> >> Reviewed-by: Dr. David Alan Gilbert
> >> ---
> >> configure | 30 ++
>
* David Hildenbrand (da...@redhat.com) wrote:
> Resizing while migrating is dangerous and does not work as expected.
> The whole migration code works on the usable_length of ram blocks and does
> not expect this to change at random points in time.
>
> Precopy: The ram block size must not change
On Fri, Feb 14, 2020 at 07:25:43AM +, miaoyubo wrote:
>
> > -Original Message-
> > From: Daniel P. Berrangé [mailto:berra...@redhat.com]
> > Sent: Thursday, February 13, 2020 9:52 PM
> > To: miaoyubo
> > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com;
> > imamm...@redhat.com;
On Thu, 13 Feb 2020 at 09:07, Gerd Hoffmann wrote:
>
> The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730:
>
> Merge remote-tracking branch
> 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging
> (2020-02-10 18:09:14 +)
>
> are available in the Git
On Sat, 8 Feb 2020 01:12:28 +0530
Kirti Wankhede wrote:
(...)
Minor wording nits:
> +/*
> + * Structure vfio_device_migration_info is placed at 0th offset of
"...at the 0th offset..."
> + * VFIO_REGION_SUBTYPE_MIGRATION region to get/set VFIO device related
> migration
> + * information.
* Juan Quintela (quint...@redhat.com) wrote:
> It will be used later.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
>
> ---
>
> No comp value needs to be zero.
> ---
> migration/migration.c | 9 ++
> migration/migration.h | 1 +
> migration/multifd.c | 185
On Fri, Feb 14, 2020 at 10:55:19AM +0100, Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
v1 posted here:
> ehci-platform 1c1c000.usb: new USB bus registered, assigned bus number 2
> ehci-platform 1c1c000.usb: irq 31, io mem 0x01c1c000
> ehci-platform 1c1c000.usb: USB 2.0 started, EHCI 1.00
> +for (i = 0; i < ARRAY_SIZE(s->ehci); i++) {
> +
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
v1 posted here:
https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html
diff to v1:
On 2/14/20 10:47 AM, Cornelia Huck wrote:
On Fri, 14 Feb 2020 09:47:39 +0100
Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
Thanks for your review. I will fix these errors in the next version(V3).
Due to migration data transfer using RDMA WRITE operation, we don't need to
receive data in the destination.
We only need to poll the CQE in the destination, so multifd_recv_thread() can't
be used directly.
-Original
On Fri, 14 Feb 2020 09:47:39 +0100
Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
> ---
> hw/vfio/common.c| 2 +-
On Fri, 14 Feb 2020 at 06:05, Guenter Roeck wrote:
>
> USB ports must be instantiated as TYPE_CHIPIDEA to work.
> Linux expects and checks various chipidea registers, which
> do not exist with the basic ehci emulation.
Hi; I didn't see a cover letter email for this series (sorry if
I missed it).
On Fri, 14 Feb 2020 at 06:33, Markus Armbruster wrote:
>
> Does not work out of the box on my Fedora 30 build host, where
> sphinx-build gives me sphinx-build-2. I have to specify
> --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
> breaks things when I try to build
On 2/14/20 9:47 AM, Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
hw/vfio/common.c| 2 +-
util/vfio-helpers.c | 6
On 13/02/20 23:50, Alex Bennée wrote:
> This is mainly to help with reasoning what the test is trying to do.
> We can move rcu_stress_idx to a local variable as there is only ever
> one updater thread. I've also added an assert to catch the case where
> we end up updating the current structure to
On 13.02.20 21:56, Peter Xu wrote:
> On Thu, Feb 13, 2020 at 08:42:23PM +0100, David Hildenbrand wrote:
>> On 13.02.20 19:32, Peter Xu wrote:
>>> On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote:
Resizing while migrating is dangerous and does not work as expected.
The
On Fri, Feb 14, 2020 at 09:47:39AM +0100, Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
hw/vfio/common.c| 2 +-
Juan Quintela writes:
> Markus Armbruster wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>>> * Juan Quintela (quint...@redhat.com) wrote:
Signed-off-by: Juan Quintela
---
migration/migration.c | 15 +++
monitor/hmp-cmds.c| 4
qapi/migration.json
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
hw/vfio/common.c| 2 +-
util/vfio-helpers.c | 6 +++---
2 files changed, 4 insertions(+), 4
Signed-off-by: Mark Cave-Ayland
---
hw/ide/cmd646.c | 12
include/hw/ide.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 335c060673..d953932104 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -317,18 +317,6 @@ static void
Remove the call to pci_cmd646_ide_init() since global device init functions
are deprecated in preference of using qdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/alpha/dp264.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
The recent cmd646 discussions reminded me of this patch I've had sitting in an
old branch for a while.
The DP264 machine is the last remaining user of the deprecated
pci_cmd646_ide_init() init function. Switch it over to using qdev via
pci_create()
and then remove the now-unused
201 - 270 of 270 matches
Mail list logo
