Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-03 Thread Andrew Jones
On Wed, Jul 29, 2020 at 04:40:54PM +0200, Andrew Jones wrote: > > > +static inline void kvm_arm_steal_time_finalize(ARMCPU *cpu, Error > > > **errp) {} > > > > Does this stub need to report an error to the caller via errp, > > or is it a "never called but needs to exist to avoid linker errors" ?

Re: [PATCH for-5.1] hw/arm/nrf51_soc: Set system_clock_scale

2020-08-03 Thread Philippe Mathieu-Daudé
On 7/27/20 9:34 PM, Peter Maydell wrote: > The nrf51 SoC model wasn't setting the system_clock_scale > global.which meant that if guest code used the systick timer in "use > the processor clock" mode it would hang because time never advances. > > Set the global to match the documented CPU clock

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Kevin Wolf
Am 03.08.2020 um 18:03 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > This means the two parts might be considered separately: > > > > - replacing single-quote with double-quote strings > > > > - replacing # comments with // > > If all we want is decent editor support out of the

Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines

2020-08-03 Thread Philippe Mathieu-Daudé
On 7/30/20 1:34 PM, Igor Mammedov wrote: > On Fri, 24 Jul 2020 18:52:59 +0200 > Philippe Mathieu-Daudé wrote: > >> No MIPS machine uses the ACPI cpu-hotplug feature >> (QEMU implementation is X86 specific). > > if I recall correctly we were building it to satisfy symbol dependencies > due to

Re: [PATCH for-5.1] hw/timer/imx_epit: Avoid assertion when CR.SWR is written

2020-08-03 Thread Philippe Mathieu-Daudé
On 7/27/20 5:45 PM, Peter Maydell wrote: > The imx_epit device has a software-controllable reset triggered by > setting the SWR bit in the CR register. An error in commit cc2722ec83ad9 > means that we will end up assert()ing if the guest does this, because > the code in imx_epit_write() starts

Re: qapi-schema esotera

2020-08-03 Thread Eric Blake
On 8/3/20 11:49 AM, John Snow wrote: UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py, I notice that we modify the perceived type of the 'type' expression based on the two union forms. 1a. Simple unions allow Array[T]

Re: qapi-schema esotera

2020-08-03 Thread John Snow
On 8/3/20 1:25 PM, Eric Blake wrote: On 8/3/20 11:49 AM, John Snow wrote: UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py, I notice that we modify the perceived type of the 'type' expression based on the two union

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Richard Henderson
On 8/1/20 6:13 AM, Helge Deller wrote: > From: Sven Schnelle > > Signed-off-by: Sven Schnelle > Signed-off-by: Helge Deller > --- > hw/display/artist.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) Looks ok, if not ideal. Reviewed-by: Richard Henderson

[PATCH v1 0/1] docs/system/arm: Document the Xilinx Versal Virt board

2020-08-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This adds some basic documentation for the Xilinx Versal Virt board, including a few command-line examples on how to run ARM Trusterd Firmware, U-boot, Xen and Linux. If this looks OK I'll send similar basic documentation for the ZynqMP and Zynq. Best regards,

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 17:35, Anthony PERARD wrote: > > On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > > CONFIG_XEN is generated by configure and stored in "config-target.h", > > which is (obviously) only include for target-specific objects. > > This is a problem for

[PATCH] target/arm: Fix Rt/Rt2 in ESR_ELx for copro traps from AArch32 to 64

2020-08-03 Thread Peter Maydell
When a coprocessor instruction in an AArch32 guest traps to AArch32 Hyp mode, the syndrome register (HSR) includes Rt and Rt2 fields which are simply copies of the Rt and Rt2 fields from the trapped instruction. However, if the instruction is trapped from AArch32 to an AArch64 higher exception

Re: [PULL 00/63] riscv-to-apply queue

2020-08-03 Thread Thomas Huth
On 30/06/2020 10.44, LIU Zhiwei wrote: > > > On 2020/6/30 16:11, Thomas Huth wrote: >> On 30/06/2020 08.56, LIU Zhiwei wrote: >>> >>> >>> On 2020/6/29 6:51, Alistair Francis wrote: On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell wrote: > On Fri, 26 Jun 2020 at 22:53, Alistair

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-03 Thread Julien Freche
Of course. I just tested the patch (used the branch from https://github.com/patchew-project/qemu) and it didn't seem to help. Could that be linked to the fact that the translation is only in the SMC exception path? It should probably target the MSR exception path also (and probably others too).

Re: [PULL 00/63] riscv-to-apply queue

2020-08-03 Thread Thomas Huth
On 03/08/2020 20.00, Philippe Mathieu-Daudé wrote: > On 8/3/20 7:53 PM, Thomas Huth wrote: >> On 30/06/2020 10.44, LIU Zhiwei wrote: >>> >>> >>> On 2020/6/30 16:11, Thomas Huth wrote: On 30/06/2020 08.56, LIU Zhiwei wrote: > > > On 2020/6/29 6:51, Alistair Francis wrote: >> On

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread John Snow
On 8/3/20 8:01 AM, Paolo Bonzini wrote: That said, after a bit more research I'm skeptical about the possibility of using an off-the-shelf parser because most of them either don't support comments, or are based on YAJL which simply discards comments. Heresy: Docstrings could become part of

Re: [PATCH 2/2] libvhost-user: handle endianness as mandated by the spec

2020-08-03 Thread Cornelia Huck
On Thu, 30 Jul 2020 16:07:31 +0200 Marc Hartmayer wrote: > Since virtio existed even before it got standardized, the virtio > standard defines the following types of virtio devices: > > + legacy device (pre-virtio 1.0) > + non-legacy or VIRTIO 1.0 device > + transitional device (which can

[PATCH v2 2/8] linux-user: Add support for a group of btrfs ioctls used for snapshots

2020-08-03 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SNAP_CREATE - Creating a subvolume snapshot Create a snapshot of a btrfs subvolume. The snapshot is created using the ioctl's third argument that is a pointer to a 'struct btrfs_ioctl_vol_args' (which was mentioned

[PATCH v2 3/8] linux-user: Add support for btrfs ioctls used to manipulate with devices

2020-08-03 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SCAN_DEV - Scanning device for a btrfs filesystem Scan a device for a btrfs filesystem. The device that is to be scanned is passed in the ioctl's third argument which represents a pointer to a 'struct ioc_vol_args'

[PATCH v2 1/8] linux-user: Add support for a group of btrfs ioctls used for subvolumes

2020-08-03 Thread Filip Bozuta
This patch implements functionality of following ioctls: BTRFS_IOC_SUBVOL_CREATE - Creating a btrfs subvolume Create a btrfs subvolume. The subvolume is created using the ioctl's third argument which represents a pointer to a following structure type: struct btrfs_ioctl_vol_args

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Markus Armbruster
Paolo Bonzini writes: > On 31/07/20 17:44, Daniel P. Berrangé wrote: >> I'd consider the runtime protocol separately. In terms of what's on the >> wire, we use genuine JSON format. The runtime problem is simply that JSON >> standard is useless when it comes to integers, leaving behaviour

[PATCH 0/7] target/arm: copro decode cleanup

2020-08-03 Thread Peter Maydell
This patchset cleans up the handling of copro instructions in the A32/T32 decoder, converting the MRC/MCR/MRRC/MCRR insns to decodetree. The main motivation here was correcting how we do NOCP checks for M-profile: the architecture specifies that the NOCP exception when a coprocessor is not

Re: [PULL 0/1] Seabios 20200803 patches

2020-08-03 Thread Peter Maydell
in the Git repository at: > > git://git.kraxel.org/qemu tags/seabios-20200803-pull-request > > for you to fetch changes up to 1f42e246995a99890f6af4e42329f184ee14b0e7: > > seabios: update to master snapshot (2020-08-03 07:01:02 +0200) > > -

[PATCH 2/7] target/arm: Separate decode from handling of coproc insns

2020-08-03 Thread Peter Maydell
As a prelude to making coproc insns use decodetree, split out the part of disas_coproc_insn() which does instruction decoding from the part which does the actual work, and make do_coproc_insn() handle the UNDEF-on-bad-permissions and similar cases itself rather than returning 1 to eventually

Re: [PATCH v4 2/2] trace: Example of non-tracing recorder use

2020-08-03 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jul 23, 2020 at 03:29:03PM +0200, Christophe de Dinechin wrote: >> This patch is a simple example showing how the recorder can be used to >> have one "topic" covering multiple entries. Here, the topic is "lock", >> the idea being to have the latest lock changes

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Paolo Bonzini
On 03/08/20 13:36, Daniel P. Berrangé wrote: >>> Given that QEMU needs to pass >>> uint64 values, JSON was simply the wrong choice of format for QMP. > > I wasn't refering to RFC7159. The problem of undefined integer precision > with JSON came up right at the very start when QMP was first designed

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Paolo Bonzini
On 01/08/20 01:12, Nir Soffer wrote: > I think inventing DSLs and developing tools is wrong. Use standard > format and tools and spend time on the core of the project. Please don't apply 2020 standards to choices that were made in 2009. Or if you do, be ready to contribute code. Paolo

[Bug 1821771] Re: KVM guest does not reflect numa distances configured through qemu

2020-08-03 Thread Satheesh Rajendran
Documentation describing the current qemu behaviour is captured here, https://www.mail-archive.com/qemu-devel@nongnu.org/msg726442.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821771 Title:

Re: [PATCH 2/2] libvhost-user: handle endianness as mandated by the spec

2020-08-03 Thread Marc Hartmayer
On Sun, Aug 02, 2020 at 01:13 AM -0400, "Michael S. Tsirkin" wrote: > On Thu, Jul 30, 2020 at 04:07:31PM +0200, Marc Hartmayer wrote: >> Since virtio existed even before it got standardized, the virtio >> standard defines the following types of virtio devices: >> >> + legacy device (pre-virtio

[Bug 1890160] [NEW] Abort in vmxnet3_validate_queues

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001004 outw 0xcfc 0x7 write 0x0 0x1 0xe1 write 0x1 0x1 0xfe write 0x2

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-03 Thread Andrew Jones
On Sat, Aug 01, 2020 at 02:00:34PM +0200, Andrew Jones wrote: > > > if (kvm_enabled()) { > > > +hwaddr pvtime_base = vms->memmap[VIRT_PVTIME].base; > > > +hwaddr pvtime_size = vms->memmap[VIRT_PVTIME].size; > > > + > > > +if (steal_time) { > > > +

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Paolo Bonzini
On 03/08/20 18:03, Markus Armbruster wrote: >> In general it seems like a good idea to use a standard file format and >> not "a standard file format except for two characters". :) We also >> wouldn't be having discussions on editors. > > No argument. But towards which standard file format

Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Henrik Carlqvist
Would you please consider my patch which implements the honor of the -k switch for sparc as a sun keyboard language dip switch setting instead of a hard coded en-us keyboard layout? The initial patch mail was sent to the mailing list and the listed maintainers of escc.c and is also available at

Re: [Bug 1890160] [NEW] Abort in vmxnet3_validate_queues

2020-08-03 Thread Philippe Mathieu-Daudé
Cc'ing Dmitry as he doesn't have lauchpad account :/ On 8/3/20 4:37 PM, Alexander Bulekov wrote: > Public bug reported: > > Hello, > Reproducer: > > cat << EOF | ./i386-softmmu/qemu-system-i386 \ > -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic > outl 0xcf8 0x80001014 > outl 0xcfc

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Aug 03, 2020 at 02:16:19PM +0200, Paolo Bonzini wrote: >> On 03/08/20 13:36, Daniel P. Berrangé wrote: >> >>> Given that QEMU needs to pass >> >>> uint64 values, JSON was simply the wrong choice of format for QMP. >> > >> > I wasn't refering to RFC7159. The

Re: [PATCH v2 0/5] virtio mmio specification enhancement

2020-08-03 Thread Alex Bennée
Alex Bennée writes: > Pincus, Josh writes: > >> Hi, >> >> >> >> We were looking into a similar enhancement for the Virt I/O MMIO transport >> and came across this project. >> >> This enhancement would be perfect for us. > > So there is certainly an interest in optimising MMIO based virtio

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Anthony PERARD
On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and

[PATCH v1 1/1] docs/system/arm: Document the Xilinx Versal Virt board

2020-08-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Document the Xilinx Versal Virt board. Signed-off-by: Edgar E. Iglesias --- docs/system/arm/xlnx-versal-virt.rst | 176 +++ docs/system/target-arm.rst | 1 + MAINTAINERS | 3 +- 3 files changed, 179

qapi-schema esotera

2020-08-03 Thread John Snow
UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py, I notice that we modify the perceived type of the 'type' expression based on the two union forms. 1a. Simple unions allow Array[T] 1b. Flat unions disallow Array[T] From

Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Paolo Bonzini
On 03/08/20 19:26, Henrik Carlqvist wrote: > Would you please consider my patch which implements the honor of the -k switch > for sparc as a sun keyboard language dip switch setting instead of a hard > coded en-us keyboard layout? > > The initial patch mail was sent to the mailing list and the

Re: [PULL 00/63] riscv-to-apply queue

2020-08-03 Thread Philippe Mathieu-Daudé
On 8/3/20 7:53 PM, Thomas Huth wrote: > On 30/06/2020 10.44, LIU Zhiwei wrote: >> >> >> On 2020/6/30 16:11, Thomas Huth wrote: >>> On 30/06/2020 08.56, LIU Zhiwei wrote: On 2020/6/29 6:51, Alistair Francis wrote: > On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell > wrote:

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-03 Thread Julien Freche
Maybe it's covered by EXCP_HYP_TRAP already... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879587 Title: Register number in ESR is incorrect for certain banked registers when switching from

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-03 Thread Eugenio Pérez
On Fri, 2020-07-03 at 15:24 +0800, Jason Wang wrote: > On 2020/7/2 下午11:45, Peter Xu wrote: > > On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: > > > So I think we agree that a new notifier is needed? > > Good to me, or a new flag should be easier (IOMMU_NOTIFIER_DEV_IOTLB)? > > That

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Markus Armbruster
Paolo Bonzini writes: > On 03/08/20 13:28, Markus Armbruster wrote: We could remove them from the QAPI schema language. Flag day, and git-blame becomes pretty much useless for a couple of years. >>> Is that a nack or a "whatever"? >> It's "is this really worth the trouble?" I guess

Re: [PULL 0/2] bitmaps patches for -rc3, 2020-08-03

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 15:13, Eric Blake wrote: > > The following changes since commit 6c5dfc9ccb643a0d50fdec9f10806b14960571d1: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-08-03' > into staging (2020-08-03 12:21:57 +0100) > > are available in the Git repository at: > >

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-08-03 Thread Philippe Mathieu-Daudé
Hi Igor, Paolo. On 3/23/20 12:04 PM, Marcelo Tosatti wrote: > On Mon, Mar 23, 2020 at 09:05:06AM +0100, Paolo Bonzini wrote: >> On 22/03/20 17:27, Philippe Mathieu-Daudé wrote: > That 'ugly' is typically used within QEMU to deal with such things probably due to its low complexity.

[PULL 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Anthony PERARD
From: Philippe Mathieu-Daudé CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by

[PULL 0/1] xen queue 2020-08-03

2020-08-03 Thread Anthony PERARD
-dm.git tags/pull-xen-20200803 for you to fetch changes up to b3fcc98f391e9a60a369d825333b852871cf67b0: accel/xen: Fix xen_enabled() behavior on target-agnostic objects (2020-08-03 17:39:38 +0100) xen patches bug fix

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-03 Thread Peter Maydell
Thanks for the bug report; I think this patch should fix it: https://patchew.org/QEMU/20200803165409.15099-1-peter.mayd...@linaro.org/ Any chance you could test it? ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu-

Re: [PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet

2020-08-03 Thread Lirong Yuan
On Mon, Aug 3, 2020 at 4:27 AM Alex Bennée wrote: > > > Lirong Yuan writes: > > > This allows gdb to access the target’s auxiliary vector, > > which can be helpful for telling system libraries important details > > about the hardware, operating system, and process. > > > > Signed-off-by: Lirong

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
Hi, I applied this patch, but I can still trigger a segfault and heap overread through artist_reg_write -> fill_window. I dont know if these problems are related to what this patch fixes. If not, let me know and I can create a separate launchpad report for these. -Alex (1) Segfault: cat << EOF |

Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Artyom Tarasenko
On Mon, Aug 3, 2020 at 7:52 PM Paolo Bonzini wrote: > > On 03/08/20 19:26, Henrik Carlqvist wrote: > > Would you please consider my patch which implements the honor of the -k > > switch > > for sparc as a sun keyboard language dip switch setting instead of a hard > > coded en-us keyboard layout?

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Paolo Bonzini
On 03/08/20 20:10, John Snow wrote: > Heresy: > > Docstrings could become part of the data format so they can be parsed, > analyzed and validated. Parsers largely treat comments like non-semantic > information and discard it. Round-trip parsers that preserve comments in > any language are

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread John Snow
On 8/3/20 2:16 PM, Paolo Bonzini wrote: On 03/08/20 20:10, John Snow wrote: Heresy: Docstrings could become part of the data format so they can be parsed, analyzed and validated. Parsers largely treat comments like non-semantic information and discard it. Round-trip parsers that preserve

[PATCH v2 0/8] linux-user: Adding support for a group of btrfs ioctls

2020-08-03 Thread Filip Bozuta
This series covers support for following btrfs ioctls *BTRFS_SUBVOL_CREATE *BTRFS_IOC_ADD_DEV *BTRFS_SUBVOL_SETFLAGS *BTRFS_IOC_RM_DEV *BTRFS_SUBVOL_GETFLAGS *BTRFS_IOC_DEV_INFO *BTRFS_GET_SUBVOL_INFO *BTRFS_IOC_GET_DEV_STATS

[PATCH-for-5.1? 4/4] hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize

2020-08-03 Thread Philippe Mathieu-Daudé
Clock canonical name is set in device_set_realized (see the block added to hw/core/qdev.c in commit 0e6934f264). If we connect a clock after the device is realized, this code is not executed. This is currently not a problem as this name is only used for trace events, however this disrupt tracing.

Re: [PATCH] target/arm: Delete unused VFP_DREG macros

2020-08-03 Thread Alex Bennée
Peter Maydell writes: > As part of the Neon decodetree conversion we removed all > the uses of the VFP_DREG macros, but forgot to remove the > macro definitions. Do so now. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > target/arm/translate.c | 15 --- > 1

[PATCH v2 8/8] linux-user: Add support for btrfs ioctls used to scrub a filesystem

2020-08-03 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SCRUB - Starting a btrfs filesystem scrub Start a btrfs filesystem scrub. The third ioctls argument is a pointer to a following type: struct btrfs_ioctl_scrub_args { __u64 devid;

[PATCH v2 7/8] linux-user: Add support for btrfs ioctls used to manage quota

2020-08-03 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_QUOTA_CTL - Enabling/Disabling quota support Enable or disable quota support for a btrfs filesystem. Quota support is enabled or disabled using the ioctls third argument which represents a pointer to a following

[PATCH v2 6/8] linux-user: Add support for two btrfs ioctls used for subvolume

2020-08-03 Thread Filip Bozuta
This patch implements functionality for following ioctl: BTRFS_IOC_DEFAULT_SUBVOL - Setting a default subvolume Set a default subvolume for a btrfs filesystem. The third ioctl's argument is a '__u64' (unsigned long long) which represents the id of a subvolume that is to be set as

[PATCH v2 5/8] linux-user: Add support for a group of btrfs inode ioctls

2020-08-03 Thread Filip Bozuta
This patch implements functionality of following ioctls: BTRFS_IOC_INO_LOOKUP - Reading tree root id and path Read tree root id and path for a given file or directory. The name and tree root id are returned in an ioctl's third argument that represents a pointer to a following type:

[PATCH v2 4/8] linux-user: Add support for btrfs ioctls used to get/set features

2020-08-03 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_GET_FEATURES - Getting feature flags Read feature flags for a btrfs filesystem. The feature flags are returned inside the ioctl's third argument which represents a pointer to a following structure type: struct

[REPORT] [GSoC - TCG Continuous Benchmarking] [#7] Measuring QEMU Emulation Efficiency

2020-08-03 Thread Ahmed Karaman
Hi everyone, The seventh report of the TCG Continuous Benchmarking series presents a method for measuring the TCG emulation efficiency of QEMU for seventeen different targets. This is achieved by comparing the number of guest instructions (running the program natively on the target) and the

Re: [PATCH v4 1/2] trace: Add support for recorder back-end

2020-08-03 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 03:29:02PM +0200, Christophe de Dinechin wrote: > diff --git a/configure b/configure > index 4bd80ed507..3770ff873d 100755 > --- a/configure > +++ b/configure > @@ -7761,6 +7761,20 @@ fi > if have_backend "log"; then >echo "CONFIG_TRACE_LOG=y" >> $config_host_mak > fi

Re: [PATCH] tests/Makefile: test-replication needs CONFIG_POSIX

2020-08-03 Thread Philippe Mathieu-Daudé
On 8/3/20 9:05 AM, Thomas Huth wrote: > test-replication uses sigaction() and friends which are only available > on posix-like systems. "POSIX-like" (acronym) Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 4 +++- > 1 file changed, 3

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Aug 03, 2020 at 10:18:29AM +0200, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >> > - the single-quote strings, which are not particularly useful in QAPI >> > schema >> >> Every single string in the QAPI schema uses them, though. >> >> I have no

Re: [PATCH 1/1] docs: adding NUMA documentation for pseries

2020-08-03 Thread Greg Kurz
On Thu, 30 Jul 2020 10:58:52 +1000 David Gibson wrote: > On Wed, Jul 29, 2020 at 09:57:56AM -0300, Daniel Henrique Barboza wrote: > > This patch adds a new documentation file, ppc-spapr-numa.rst, > > informing what developers and user can expect of the NUMA distance > > support for the pseries

Re: [PATCH v4 1/2] trace: Add support for recorder back-end

2020-08-03 Thread Markus Armbruster
Christophe de Dinechin writes: > The recorder library provides support for low-cost continuous > recording of events, which can then be replayed. This makes it > possible to collect data after the fact, for example to show the > events that led to a crash or unexpected condition. > > In this

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Daniel P . Berrangé
On Mon, Aug 03, 2020 at 02:33:36PM +0200, Paolo Bonzini wrote: > On 03/08/20 14:23, Daniel P. Berrangé wrote: > > We'd really love to move off YAJL for JSON parsing > > What are the issues with YAJL? It is abandonware for more than 5 years now, with an ever growing list of bug reports and pull

Re: [PATCH 1/1] docs: adding NUMA documentation for pseries

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 13:15, Daniel Henrique Barboza wrote: > On 8/3/20 8:49 AM, Greg Kurz wrote: > > I'm now hitting this: > > > > Warning, treated as error: > > docs/specs/ppc-spapr-numa.rst:document isn't included in any toctree > > How are you hitting this? I can't reproduce this error. Tried

[Bug 1890152] [NEW] malloc 0xff0000030 bytes with vmxnet3

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, This reproducer causes vmxnet3 to malloc 0xff030 bytes cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001004 outw 0xcfc 0x7

[Bug 1890157] [NEW] Assertion failure in net_tx_pkt_reset through vmxnet3

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001004 outw 0xcfc 0x7 outl 0xcf8 0x80001083 write 0x0 0x1 0xe1 write

Re: [RFC v3 0/8] QEMU cpus.c refactoring part2

2020-08-03 Thread Paolo Bonzini
On 03/08/20 11:05, Claudio Fontana wrote: > 1) make icount TCG-only (building the icount module only under > CONFIG_TCG), as this series suggests, and provide a separate virtual > counter for qtest, > > > or > > > 2) continue to keep icount functions and fields, including vmstate, > in all

Re: [Virtio-fs] [PATCH] virtiofsd: Disable remote posix locks by default

2020-08-03 Thread Stefan Hajnoczi
On Mon, Jul 27, 2020 at 12:18:41PM -0400, Vivek Goyal wrote: > Right now we enable remote posix locks by default. That means when guest > does a posix lock it sends request to server (virtiofsd). But currently > we only support non-blocking posix lock and return -EOPNOTSUPP for > blocking version.

Re: [PATCH v4 2/2] trace: Example of non-tracing recorder use

2020-08-03 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 03:29:03PM +0200, Christophe de Dinechin wrote: > This patch is a simple example showing how the recorder can be used to > have one "topic" covering multiple entries. Here, the topic is "lock", > the idea being to have the latest lock changes for instance in case of > a

[PATCH 6/7] target/arm: Convert T32 coprocessor insns to decodetree

2020-08-03 Thread Peter Maydell
Convert the T32 coprocessor instructions to decodetree. As with the A32 conversion, this corrects an underdecoding where we did not check that MRRC/MCRR [24:21] were 0b0010 and so treated some kinds of LDC/STC and MRRC/MCRR rather than UNDEFing them. Signed-off-by: Peter Maydell ---

Re: [PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet

2020-08-03 Thread Alex Bennée
Lirong Yuan writes: > This allows gdb to access the target’s auxiliary vector, > which can be helpful for telling system libraries important details > about the hardware, operating system, and process. > > Signed-off-by: Lirong Yuan I cleaned up the test a little: modified

Re: [PULL 05/12] iotests/030: Reduce job speed to make race less likely

2020-08-03 Thread Peter Maydell
On Fri, 17 Jul 2020 at 13:55, Kevin Wolf wrote: > > It can happen that the throttling of the stream job doesn't make it slow > enough that we can be sure that it still exists when it is referenced > again. Just use a much smaller speed to make this very unlikely to > happen again. > >

Re: [PATCH 1/1] docs: adding NUMA documentation for pseries

2020-08-03 Thread Greg Kurz
On Mon, 3 Aug 2020 09:14:22 -0300 Daniel Henrique Barboza wrote: > > > On 8/3/20 8:49 AM, Greg Kurz wrote: > > On Thu, 30 Jul 2020 10:58:52 +1000 > > David Gibson wrote: > > > >> On Wed, Jul 29, 2020 at 09:57:56AM -0300, Daniel Henrique Barboza wrote: > >>> This patch adds a new

Re: [PATCH] target/arm: Delete unused VFP_DREG macros

2020-08-03 Thread Philippe Mathieu-Daudé
On 8/3/20 2:48 PM, Peter Maydell wrote: > As part of the Neon decodetree conversion we removed all > the uses of the VFP_DREG macros, but forgot to remove the > macro definitions. Do so now. > > Signed-off-by: Peter Maydell > --- > target/arm/translate.c | 15 --- > 1 file changed,

Re: [Bug 1888606] [NEW] Heap-use-after-free in virtio_gpu_ctrl_response

2020-08-03 Thread Li Qiang
Gerd Hoffmann 于2020年8月3日周一 下午2:57写道: > > Hi, > > > > The ASAN trace: > > > ==29798==ERROR: AddressSanitizer: heap-use-after-free on address > > > 0x60d050e8 at pc 0x560629814761 bp 0x7ffe916eb1e0 sp 0x7ffe916eb1d8 > > > READ of size 8 at 0x60d050e8 thread T0 > > > #0 0x560629814760

Re: [PATCH 1/1] docs: adding NUMA documentation for pseries

2020-08-03 Thread Daniel Henrique Barboza
On 8/3/20 9:59 AM, Peter Maydell wrote: On Mon, 3 Aug 2020 at 13:15, Daniel Henrique Barboza wrote: On 8/3/20 8:49 AM, Greg Kurz wrote: I'm now hitting this: Warning, treated as error: docs/specs/ppc-spapr-numa.rst:document isn't included in any toctree How are you hitting this? I can't

[Bug 1890159] [NEW] Assertion failure in net_tx_pkt_add_raw_fragment through vmxnet3

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001010 outl 0xcfc 0xe000 outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001001 outl 0xcfc

Re: [RFC v2 75/76] target/riscv: gdb: support vector registers for rv64

2020-08-03 Thread Alex Bennée
Richard Henderson writes: > On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: >> +if (env->misa & RVV) { >> +/* TODO: support vlen other than 128, 256, 512 bits. */ >> +const char *vector_xml_name = NULL; >> +switch (cpu->cfg.vlen) { >> +case 128: >> +

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Daniel P . Berrangé
On Mon, Aug 03, 2020 at 02:16:19PM +0200, Paolo Bonzini wrote: > On 03/08/20 13:36, Daniel P. Berrangé wrote: > >>> Given that QEMU needs to pass > >>> uint64 values, JSON was simply the wrong choice of format for QMP. > > > > I wasn't refering to RFC7159. The problem of undefined integer

[PATCH] target/arm: Delete unused VFP_DREG macros

2020-08-03 Thread Peter Maydell
As part of the Neon decodetree conversion we removed all the uses of the VFP_DREG macros, but forgot to remove the macro definitions. Do so now. Signed-off-by: Peter Maydell --- target/arm/translate.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/target/arm/translate.c

Re: [PULL 0/3] QAPI patches patches for 2020-08-03

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 10:10, Markus Armbruster wrote: > > The following changes since commit d74824cf7c8b352f9045e949dc636c7207a41eee: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200731' into > staging (2020-07-31 10:28:13 +0100) > > are available in the Git repository at: >

Re: [PATCH 1/1] docs: adding NUMA documentation for pseries

2020-08-03 Thread Daniel Henrique Barboza
David, This patch is breaking the build, as Greg mentioned below. Just sent a v2 that works properly. If you prefer you can squash this to the existing patch to fix it: $ git diff HEAD^ docs/specs/index.rst diff --git a/docs/specs/index.rst b/docs/specs/index.rst index 426632a475..1b0eb979d5

[RFC v3 3/8] cpus: extract out TCG-specific code to accel/tcg

2020-08-03 Thread Claudio Fontana
TCG is the first accelerator to register a "CpusAccel" interface on initialization, providing functions for starting a vcpu, kicking a vcpu, sychronizing state and getting virtual clock and ticks. Signed-off-by: Claudio Fontana --- accel/tcg/Makefile.objs | 1 + accel/tcg/tcg-all.c | 12

[RFC v3 8/8] cpus: extract out hvf-specific code to target/i386/hvf/

2020-08-03 Thread Claudio Fontana
register a "CpusAccel" interface for HVF as well. Signed-off-by: Claudio Fontana --- softmmu/cpus.c| 63 target/i386/hvf/Makefile.objs | 2 +- target/i386/hvf/hvf-cpus.c| 131 ++ target/i386/hvf/hvf-cpus.h|

[PULL 1/3] qapi/machine.json: Fix missing newline in doc comment

2020-08-03 Thread Markus Armbruster
From: Peter Maydell In commit 176d2cda0dee9f4 we added the @die-id field to the CpuInstanceProperties struct, but in the process accidentally removed the newline between the doc-comment lines for @core-id and @thread-id. Put the newline back in; this fixes a misformatting in the generated HTML

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-08-03 Thread Markus Armbruster
Josh DuBois writes: > Well, this is a bit embarrassing.  The patch below simply > re-introduced the bug which the Fixes: line was trying to fix in the > first place. > > I.e, : > > - with my patch (just committed as > 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4) applied, a QEMU built with > simple

[PULL 3/3] schemas: Add vim modeline

2020-08-03 Thread Markus Armbruster
From: Andrea Bolognani The various schemas included in QEMU use a JSON-based format which is, however, strictly speaking not valid JSON. As a consequence, when vim tries to apply syntax highlight rules for JSON (as guessed from the file name), the result is an unreadable mess which mostly

[PULL 2/3] qapi: Delete unwanted indentation of top-level expressions

2020-08-03 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20200730091656.264-1-arm...@redhat.com> Reviewed-by: Eric Blake [One more line de-indented] --- qapi/block-core.json | 26 +- qapi/ui.json | 4 ++-- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Daniel P . Berrangé
On Mon, Aug 03, 2020 at 10:18:29AM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > - the single-quote strings, which are not particularly useful in QAPI schema > > Every single string in the QAPI schema uses them, though. > > I have no idea why Anthony put them in the QAPI schema

[PATCH 5/7] target/arm: Do M-profile NOCP checks early and via decodetree

2020-08-03 Thread Peter Maydell
For M-profile CPUs, the architecture specifies that the NOCP exception when a coprocessor is not present or disabled should cover the entire wide range of coprocessor-space encodings, and should take precedence over UNDEF exceptions. (This is the opposite of A-profile, where checking for a

[PATCH 3/7] target/arm: Convert A32 coprocessor insns to decodetree

2020-08-03 Thread Peter Maydell
Convert the A32 coprocessor instructions to decodetree. Note that this corrects an underdecoding: for the 64-bit access case (MRRC/MCRR) we did not check that bits [24:21] were 0b0010, so we would incorrectly treat LDC/STC as MRRC/MCRR rather than UNDEFing them. The decodetree versions of these

[PATCH 4/7] target/arm: Tidy up disas_arm_insn()

2020-08-03 Thread Peter Maydell
The only thing left in the "legacy decoder" is the handling of disas_xscale_insn(), and we can simplify the code. Signed-off-by: Peter Maydell --- target/arm/translate.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/target/arm/translate.c

[PATCH 1/7] target/arm: Pull handling of XScale insns out of disas_coproc_insn()

2020-08-03 Thread Peter Maydell
At the moment we check for XScale/iwMMXt insns inside disas_coproc_insn(): for CPUs with ARM_FEATURE_XSCALE all copro insns with cp 0 or 1 are handled specially. This works, but is an odd place for this check, because disas_coproc_insn() is called from both the Arm and Thumb decoders but the

[RFC v3 7/8] cpus: extract out whpx-specific code to target/i386/

2020-08-03 Thread Claudio Fontana
register a "CpusAccel" interface for WHPX as well. Signed-off-by: Claudio Fontana --- MAINTAINERS | 1 + softmmu/cpus.c| 79 -- target/i386/Makefile.objs | 2 +- target/i386/whpx-all.c| 3 ++ target/i386/whpx-cpus.c | 96

[PULL 0/3] QAPI patches patches for 2020-08-03

2020-08-03 Thread Markus Armbruster
The following changes since commit d74824cf7c8b352f9045e949dc636c7207a41eee: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200731' into staging (2020-07-31 10:28:13 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2020-08-03 for

  1   2   3   >