Signed-off-by: Emanuele Giuseppe Esposito
---
docs/devel/testing.rst | 4
1 file changed, 4 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index d743e88746..1192d6489e 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -250,6 +250,10 @@ a
On 19/05/2021 20.54, Philippe Mathieu-Daudé wrote:
Series fully reviewed.
Hi,
Gitlab recommends to use job templates. To be able to re-use /
include templates, they can not use YAML anchors. All current jobs
has first to be converted to use the 'extends' keyworkd.
This is the first part of
As with gdbserver, valgrind delays the test execution, so
the default QMP socket timeout timeout too soon.
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/iotests.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py
the error path after calling qemu_rdma_dest_init() should do rdma cleanup
Signed-off-by: Li Zhijian
---
migration/rdma.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 41726cc74a..7e7595faab 100644
--- a/migration/rdma.c
+++
When using -valgrind on the script tests, it generates a log file
in $TEST_DIR that is either read (if valgrind finds problems) or
otherwise deleted. Provide the same exact behavior when using
-valgrind on the python tests.
Signed-off-by: Emanuele Giuseppe Esposito
---
On 19/05/2021 18.34, Philippe Mathieu-Daudé wrote:
isa_superio_realize() calls isa_fdc_init_drives(), which is defined
in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol.
Add a isa_fdc_init_drives() stub for when FDC is not selected.
Reported-by: John Snow
Suggested-by: Thomas
On Thu, May 20, 2021 at 1:58 AM Changbin Du wrote:
>
> This dumps the CSR mscratch/sscratch/satp and meanwhile aligns
> the output of CSR mtval/stval.
>
> Signed-off-by: Changbin Du
> Reviewed-by: Alistair Francis
> Reviewed-by: Bin Meng
Thanks!
Applied to riscv-to-apply.next
Alistair
>
>
On 20/05/21 07:08, Thomas Huth wrote:
OK... Not sure how to detect it from ninja then.
Every time you pull, there could be changes to the "configure" script
which affect the build ... I guess you also won't notice those when
you're only compiling with ninja? Thus at least after pulling from
Alsp add a new _qmp_timer field to the QEMUMachine class.
Let's change the default socket timeout to None, so that if
a subclass needs to add a timer, it can be done by modifying
this private field.
At the same time, restore the timer to be 15 seconds in iotests.py, to
give an upper bound to
Signed-off-by: Emanuele Giuseppe Esposito
---
docs/devel/testing.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 8144e316a4..a746cab745 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -229,6 +229,17 @@
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/iotests.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index cf1ca60376..c9628e6828 100644
--- a/tests/qemu-iotests/iotests.py
+++
Attaching gdbserver implies that the qmp socket
should wait indefinitely for an answer from QEMU.
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/iotests.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py
Using the flag -p, allow the qemu binary to print to stdout.
Reviewed-by: Max Reitz
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/check | 4 +++-
tests/qemu-iotests/iotests.py | 9 +
tests/qemu-iotests/testenv.py | 9 +++--
3 files changed, 19 insertions(+),
Reviewed-by: Max Reitz
Signed-off-by: Emanuele Giuseppe Esposito
---
docs/devel/testing.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index a746cab745..d743e88746 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@
From: Your Name
destination side:
$ build/qemu-system-x86_64 -enable-kvm -netdev
tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device
e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -drive
if=none,file=./Fedora-rdma-server-migration.qcow2,id=drive-virtio-disk0 -device
Commit bc2f4fcb1d ("qom: move user_creatable_add_opts logic to vl.c
and QAPIfy it", 2021-03-19) switched the creation of objects from
qemu_opts_foreach to a bespoke QTAILQ in preparation for supporting JSON
syntax in -object.
Unfortunately in doing so it lost support for [object] stanzas in
Change the parser to put the values into a QDict and pass them
to a callback. qemu_config_parse's QemuOpts creation is
itself turned into a callback function.
This is useful for -readconfig to support keyval-based options;
getting a QDict from the parser removes a roundtrip from
QDict to
John Snow writes:
> This is part five (a), and focuses on QAPISchemaParser in parser.py.
> It does not touch QAPIDoc yet, which will be covered next.
>
> gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5a
>
> Requirements:
> - Python 3.6+
> - mypy >= 0.770
> - pylint >=
LXD developers have reported that [object] stanzas have stopped
working in configuration files.
The problem is that QEMU 6.0 switched the creation of objects from
qemu_opts_foreach to a bespoke QTAILQ, in preparation for supporting
JSON syntax in -object. Entries from the configuration file
On Wed, 19 May 2021 14:04:20 +0100,
Steven Price wrote:
>
> On 17/05/2021 18:17, Marc Zyngier wrote:
> > On Mon, 17 May 2021 13:32:36 +0100,
> > Steven Price wrote:
> >>
> >> Define the new system registers that MTE introduces and context switch
> >> them. The MTE feature is still hidden from
Uh, one more little thing... this commit message isn't quite right:
John Snow writes:
> We can have a two-letter variable name, as a treat.
>
> Signed-off-by: John Snow
>
> --
This line is not a separator.
>
> I don't want to use 'chr' or 'char', and in context 'ch' works well
> enough. I
On Thu, May 20, 2021 at 06:23:58AM +, Kasireddy, Vivek wrote:
> Hi Gerd,
>
> > > +#ifdef CONFIG_LINUX
> >
> > > +void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
> >
> > > +#else
> >
> > > +void *virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
> > > +{
On Wed, 19 May 2021 14:26:31 +0100,
Steven Price wrote:
>
> On 17/05/2021 18:40, Marc Zyngier wrote:
> > On Mon, 17 May 2021 13:32:37 +0100,
> > Steven Price wrote:
> >>
> >> It's now safe for the VMM to enable MTE in a guest, so expose the
> >> capability to user space.
> >>
> >>
On Wed, 19 May 2021 15:09:23 +0100,
Steven Price wrote:
>
> On 17/05/2021 19:09, Marc Zyngier wrote:
> > On Mon, 17 May 2021 13:32:39 +0100,
> > Steven Price wrote:
> >>
> >> A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports
> >> granting a guest access to the tags, and
In commit 019a3edbb25 ("virtio: make features 64bit wide") we
increased the 'features' field to 64-bit, but forgot to update
the virtio_bus_get_vdev_bad_features() helper. The 'bad features'
are truncated to 32-bit. The virtio_net_bad_features() handler
from the virtio-net devices is potentially
Am 20.05.2021 um 11:26 hat Paolo Bonzini geschrieben:
> Change the parser to put the values into a QDict and pass them
> to a callback. qemu_config_parse's QemuOpts creation is
> itself turned into a callback function.
>
> This is useful for -readconfig to support keyval-based options;
> getting
On 20/05/2021 11:09, Marc Zyngier wrote:
> On Wed, 19 May 2021 14:26:31 +0100,
> Steven Price wrote:
>>
>> On 17/05/2021 18:40, Marc Zyngier wrote:
>>> On Mon, 17 May 2021 13:32:37 +0100,
>>> Steven Price wrote:
It's now safe for the VMM to enable MTE in a guest, so expose the
Let -readconfig support parsing command line options into QDict or
QemuOpts. This will be used to add back support for objects in
-readconfig.
Cc: Markus Armbruster
Cc: qemu-sta...@nongnu.org
Reviewed-by: Kevin Wolf
Signed-off-by: Paolo Bonzini
---
v1->v2: fix overlong line
On 19/05/21 23:39, John Snow wrote:
On 5/19/21 12:34 PM, Philippe Mathieu-Daudé wrote:
Hi,
The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
This series clean that by extracting each device in its own file,
On 20/05/2021 11:24, Marc Zyngier wrote:
> On Wed, 19 May 2021 15:09:23 +0100,
> Steven Price wrote:
>>
>> On 17/05/2021 19:09, Marc Zyngier wrote:
>>> On Mon, 17 May 2021 13:32:39 +0100,
>>> Steven Price wrote:
[...] +bytes (i.e. 1/16th of the corresponding size). Each byte
contains a
On Thu, 20 May 2021 12:28:22 +0200
Philippe Mathieu-Daudé wrote:
> In commit 019a3edbb25 ("virtio: make features 64bit wide") we
> increased the 'features' field to 64-bit, but forgot to update
> the virtio_bus_get_vdev_bad_features() helper. The 'bad features'
> are truncated to 32-bit. The
Check rext.info to avoid potential NULL pointer dereference. A similar check
exists in interface_release_resource() in hw/display/qxl.c.
Reported-by: Yu Lu
Signed-off-by: Mauro Matteo Cascella
---
ui/spice-display.c | 4
1 file changed, 4 insertions(+)
diff --git a/ui/spice-display.c
On Tue, 18 May 2021 17:08:31 +
Eric DeVolder wrote:
> Hi Igor,
> Thanks for the information. I am primarily interested in ensuring data
> persistence in the case of #1.
> As it stands so far, I have yet to observe any kind of write back into the
> backing file. Just to summarize,
> what
On Fri, 30 Apr 2021 at 00:42, Shashi Mallela wrote:
>
> Implemented lpi processing at redistributor to get lpi config info
> from lpi configuration table,determine priority,set pending state in
> lpi pending table and forward the lpi to cpuif.Added logic to invoke
> redistributor lpi processing
All address_space internal handlers have the /* warning: addr
must be aligned */ comment, so we don't expect any caller to
pass unaligned addresses.
Now than we added the MemTxAttrs.aligned attribute, callers
might want to pass unaligned addresses. In case they do, be
ready and return
Use uint16_t for (unsigned) 16-bit word.
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/memory_ldst_cached.h.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/exec/memory_ldst_cached.h.inc
b/include/exec/memory_ldst_cached.h.inc
index
A bus master might specify the 'aligned' attribute to enforce
a transaction using aligned address. If the address is not
aligned, the accessor will return MEMTX_UNALIGNED_ERROR.
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/memattrs.h | 3 +++
1 file changed, 3 insertions(+)
diff
If the caller requires strict alignment, check the address
satisfies it before doing the transaction. Otherwise return
a MEMTX_UNALIGNED_ERROR.
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/memory_ldst_cached.h.inc | 42 +++
1 file changed, 42 insertions(+)
To ease the file review, sort the declarations by the size of
the access (8, 16, 32). Simple code movement, no logical change.
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/memory_ldst_cached.h.inc | 46 +--
1 file changed, 23 insertions(+), 23 deletions(-)
Use uint16_t for unsigned 16-bit data and uint32_t for unsigned 32-bit.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/virtio/virtio-access.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/virtio/virtio-access.h
b/include/hw/virtio/virtio-access.h
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/memory_ldst_cached.h.inc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/exec/memory_ldst_cached.h.inc
b/include/exec/memory_ldst_cached.h.inc
index a8f146251d4..515beb48f47 100644
---
To be able to specify memory transaction attributes (such the
address alignment), extract virtio_lduw_phys_cached_with_attrs()
from virtio_lduw_phys_cached().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/virtio/virtio-access.h | 35 +++
1 file changed, 31
On Tue, 18 May 2021 at 10:07, Alex Bennée wrote:
>
> The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging
> (2021-05-17 16:44:47 +0100)
>
> are available in the
+Stefan/Daniel
On 5/20/21 10:02 AM, Thomas Huth wrote:
> On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote:
>> If a runner has ccache installed, use it and display statistics
>> at the end of the build.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> .gitlab-ci.d/buildtest-template.yml |
On Mon, May 17, 2021 at 01:32:35PM +0100, Steven Price wrote:
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index c5d1f3c87dbd..8660f6a03f51 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -822,6 +822,31 @@ transparent_hugepage_adjust(struct kvm_memory_slot
>
On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote:
> diff --git a/arch/arm64/include/uapi/asm/kvm.h
> b/arch/arm64/include/uapi/asm/kvm.h
> index 24223adae150..b3edde68bc3e 100644
> --- a/arch/arm64/include/uapi/asm/kvm.h
> +++ b/arch/arm64/include/uapi/asm/kvm.h
> @@ -184,6 +184,17 @@
Hi,
This series is an experiment after chatting with Stefan and having
received review from Peter / Richard on an orthogonal series aiming
to handle unaligned pointers (atomically):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg808954.html
Here we don't aim to fix unatomic accesses,
Use uint8_t for (unsigned) byte, and uint16_t for (unsigned)
16-bit word.
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/memory_ldst.h.inc | 16
memory_ldst.c.inc | 20 ++--
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git
Per the virtio spec [*] the vring is aligned, so the 'flag' field
is also 16-bit aligned. If it is not, this is a guest error, and
we'd rather report any malicious activity.
Enforce the transaction alignment by setting the 'aligned' attribute
and log unaligned addresses.
Signed-off-by: Philippe
If the caller passed a MemTxResult argument, we must fill
it with the transaction result. We do it when no cache is
present, complete the other case (which is always successful).
Fixes: 48564041a73 ("exec: reintroduce MemoryRegion caching")
Signed-off-by: Philippe Mathieu-Daudé
---
To be able to check the memory transaction succeeded, change
the vring_avail_flags() to take the value to read by argument,
so we can return a boolean whether we succeeded or not.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/virtio/virtio.c | 13 +
1 file changed, 9 insertions(+), 4
* Max Reitz (mre...@redhat.com) wrote:
> On 17.05.21 16:57, Vivek Goyal wrote:
> > On Wed, May 12, 2021 at 02:55:42PM +0200, Max Reitz wrote:
> > > Mount point directories represent two inodes: On one hand, they are a
> > > normal directory on their parent filesystem. On the other, they are the
>
On 19/05/2021 19:06, Catalin Marinas wrote:
> On Mon, May 17, 2021 at 01:32:34PM +0100, Steven Price wrote:
>> A KVM guest could store tags in a page even if the VMM hasn't mapped
>> the page with PROT_MTE. So when restoring pages from swap we will
>> need to check to see if there are any saved
On Tue, 11 May 2021 at 04:25, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> Can this patch go via your qemu-arm tree (it is reviewed)?
Sure.
Applied to target-arm.next, thanks.
-- PMM
On Thu, 20 May 2021, Mark Cave-Ayland wrote:
On 20/05/2021 09:35, Stefan Hajnoczi wrote:
I realized I don't really understand how ISA IDE and PCI IDE interact in
PIIX3:
You're not alone with that. :-)
- ISA IDE has well-known PIO registers that are always present?
- PCI IDE has the same
On Thu, May 20, 2021 at 12:55:21PM +0100, Steven Price wrote:
> On 19/05/2021 19:06, Catalin Marinas wrote:
> > On Mon, May 17, 2021 at 01:32:34PM +0100, Steven Price wrote:
> >> A KVM guest could store tags in a page even if the VMM hasn't mapped
> >> the page with PROT_MTE. So when restoring
On Thu, 20 May 2021 at 14:06, Philippe Mathieu-Daudé wrote:
>
> On 5/20/21 9:43 AM, Paolo Bonzini wrote:
> > On 20/05/21 07:08, Thomas Huth wrote:
> >>> OK... Not sure how to detect it from ninja then.
> >>
> >> Every time you pull, there could be changes to the "configure" script
> >> which
18.05.2021 13:07, Emanuele Giuseppe Esposito wrote:
As done in BlockCopyCallState, categorize BlockCopyTask
and BlockCopyState in IN, State and OUT fields.
This is just to understand which field has to be protected with a lock.
BlockCopyTask .zeroes is a special case, because it is only
Some virtio blocks definitely have no partitions and should not be scanned.
Yury Kamenev (1):
virtio: disable partitions scanning for no partitions block
hw/block/virtio-blk.c | 4
include/hw/virtio/virtio-blk.h | 1 +
On 20/05/2021 17:00, Vladimir Sementsov-Ogievskiy wrote:
18.05.2021 13:07, Emanuele Giuseppe Esposito wrote:
As done in BlockCopyCallState, categorize BlockCopyTask
and BlockCopyState in IN, State and OUT fields.
This is just to understand which field has to be protected with a lock.
Patchew URL:
https://patchew.org/QEMU/20210520145647.3483809-1-david.edmond...@oracle.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210520145647.3483809-1-david.edmond...@oracle.com
Subject: [RFC PATCH 0/7]
Signed-off-by: Yury Kamenev
---
hw/block/virtio-blk.c | 4
include/hw/virtio/virtio-blk.h | 1 +
include/standard-headers/linux/virtio_blk.h | 1 +
3 files changed, 6 insertions(+)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index
This is an immutable, named, typed tuple. It's nicer than arbitrary
dicts for passing data around when using strict typing. We may upgrade
this to a @dataclass style class in the future if we want to support
mutability at a later time. (And after 3.7+ is available for use.)
Turn parser.exprs into
This is part five (c), and focuses on sharing strict types between
parser.py and expr.py.
gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5c
Requirements:
- Python 3.6+
- mypy >= 0.770
- pylint >= 2.6.0 (2.7.0+ when using Python 3.9+)
Every commit should pass with:
-
On 20/05/2021 12:54, Catalin Marinas wrote:
> On Mon, May 17, 2021 at 01:32:35PM +0100, Steven Price wrote:
>> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
>> index c5d1f3c87dbd..8660f6a03f51 100644
>> --- a/arch/arm64/kvm/mmu.c
>> +++ b/arch/arm64/kvm/mmu.c
>> @@ -822,6 +822,31 @@
The hexagon container is always manually built but of course not
everyone will be building it themselves and pushing to their
registries. We still need to create a "local" registry copy for the
actual gitlab tests to run. We don't build it in this case, just pull
it across from the upstream
On Thu, May 20, 2021 at 01:25:50PM +0100, Catalin Marinas wrote:
> On Thu, May 20, 2021 at 12:55:21PM +0100, Steven Price wrote:
> > The problem I hit is one of include dependencies:
> >
> > is_swap_pte() is defined (as a static inline) in
> > include/linux/swapops.h. However the definition
Ping for code review, please?
thanks
-- PMM
On Mon, 10 May 2021 at 16:00, Peter Maydell wrote:
>
> In icc_eoir_write() we assume that we can identify the group of the
> IRQ being completed based purely on which register is being written
> to and the current CPU state, and that "CPU state
On Mon, 10 May 2021 at 20:08, Peter Maydell wrote:
>
> This patchset fixes some bugs in how we were modelling the
> TCMs and the SRAM in the SSE-300 which were preventing
> Arm TF-M from booting on our AN547 model; there are also
> some fixes to things I noticed while I was in the code.
>
> The
On Tue, 11 May 2021 at 11:22, Alistair Francis wrote:
>
> Signed-off-by: Alistair Francis
> Reviewed-by: Richard Henderson
> Message-id:
> fcc125d96da941b56c817c9dd6068dc36478fc53.1619234854.git.alistair.fran...@wdc.com
> ---
> target/riscv/cpu_bits.h | 10 --
> target/riscv/csr.c
Hi Shashi,
[ fixing my email address ]
On 5/13/21 4:25 PM, Shashi Mallela wrote:
> Hi,
>
> Since the current SMMUv3 qemu implementation only supports stage 1
> translation,wanted to understand if the implementation could be extended
> to stage 2 translation support and if yes what is the
One more step closer to .bdrv_open(): use options instead of plain
arguments. Move to bdrv_open_child() calls, native for drive open
handlers.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/copy-before-write.c | 40 +--
1 file changed, 26
Here:
- long line
- move to new interface of vm.qmp() (direct passing dict), to avoid
mypy false-positive, as it thinks that unpacked dict is a positional
argument.
- extra parenthesis
- handle event_wait possible None value
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
We are going to publish copy-before-write filter to be used in separate
of backup. Future step would support bitmap for the filter. But let's
start from full set bitmap.
We have to modify backup, as bitmap is first initialized by
copy-before-write filter, and then backup modifies it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index c7ec16c082..9fa0162b07 100644
--- a/tests/qemu-iotests/iotests.py
+++
New fleecing method becomes available: copy-before-write filter.
Actually we don't need backup job to setup image fleecing. Add test
for new recommended way of image fleecing.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/image-fleecing | 50 +-
On Mon, May 17, 2021 at 03:26:37PM +0200, Greg Kurz wrote:
> The device model batching its ioeventfds in a single MR transaction is
> an optimization. Clarify this in virtio-scsi, virtio-blk and generic
> virtio code. Also clarify that the transaction must commit before
> closing ioeventfds so
On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
-static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr)
+static inline uint16_t virtio_lduw_p(VirtIODevice *vdev, const void *ptr)
While this one looks obviously correct,
-static inline int virtio_ldl_p(VirtIODevice *vdev, const
On 5/19/21 2:40 PM, Philippe Mathieu-Daudé wrote:
On 5/19/21 9:20 PM, Richard Henderson wrote:
On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
The series is decomposed as:
- cleanups (1-6)
- clean ldst API using macros (7-13)
- add aligned ldst methods (14)
- add aligned memory methods
On Thu, 20 May 2021 16:38:31 +0100
Alex Bennée wrote:
> The hexagon container is always manually built but of course not
> everyone will be building it themselves and pushing to their
> registries. We still need to create a "local" registry copy for the
> actual gitlab tests to run. We don't
In theory we don't need an actual record/replay to enact reverse
debugging on a purely deterministic system (i.e one with no external
inputs running under icount). Tidy away the logic into a little
function.
Signed-off-by: Alex Bennée
---
gdbstub.c | 13 +++--
1 file changed, 11
From: Philippe Mathieu-Daudé
Instead of jumping through hoops let glib deal with both tracking the
number of elements and auto freeing the memory once we are done. This
allows is to drop the usage of ALLOCA(3) which the man-page mentions
its "use is discouraged".
Signed-off-by: Alex Bennée
From: John Snow
We can have a two-letter variable name, as a treat.
Signed-off-by: John Snow
Message-Id: <20210519183951.3946870-15-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/qapi/pylintrc | 1 +
1 file changed, 1 insertion(+)
diff --git
On Thu, Apr 22, 2021 at 06:11:19PM +0200, Vitaly Kuznetsov wrote:
> Just like with cpuid_cache, it makes no sense to call
> KVM_GET_SUPPORTED_HV_CPUID more than once and instead of (ab)using
> env->features[] and/or trying to keep all the code in one place, it is
> better to introduce persistent
On Thu, May 20, 2021 at 12:38 PM Alex Bennée wrote:
>
> The hexagon container is always manually built but of course not
> everyone will be building it themselves and pushing to their
> registries. We still need to create a "local" registry copy for the
> actual gitlab tests to run. We don't
On Thu, 20 May 2021 at 17:15, Richard Henderson
wrote:
>
> On 5/20/21 8:40 AM, Peter Maydell wrote:
> > On Sun, 16 May 2021 at 13:38, Richard Henderson
> > Hi -- Coverity is suspicious about this line (CID 1453209),
> > because udiv_qrrnd()'s prototype is
> > static inline uint64_t
180521-2' into staging
(2021-05-20 10:00:58 +0100)
are available in the Git repository at:
https://gitlab.com/cohuck/qemu.git tags/s390x-20210520-v2
for you to fetch changes up to f66487756b0553b156d8e3e81bc6411cfc38176e:
tests/tcg/x86_64: add vsyscall smoke test (2021-05-20 14:19:30
From: Ilya Leoshkevich
If arch-specific code generates a translation block of size 0,
tb_gen_code() may generate a spurious exception. Add an assertion in
order to catch such situations early.
Signed-off-by: Ilya Leoshkevich
Reviewed-by: David Hildenbrand
Message-Id:
From: Ilya Leoshkevich
tb_gen_code() assumes that tb->size must never be zero, otherwise it
may produce spurious exceptions. For xtensa this may happen when
decoding an unknown instruction, when handling a write into the
CCOUNT or CCOMPARE special register and when single-stepping the first
From: Ilya Leoshkevich
Hitting an uretprobe in a s390x TCG guest causes a SIGSEGV. What
happens is:
* uretprobe maps a userspace page containing an invalid instruction.
* uretprobe replaces the target function's return address with the
address of that page.
* When tb_gen_code() is called on
From: Ilya Leoshkevich
tb_gen_code() assumes that tb->size must never be zero, otherwise it
may produce spurious exceptions. For ARM this may happen when creating
a translation block for the commpage.
Fix by pretending that commpage translation blocks have at least one
instruction.
From: Philippe Mathieu-Daudé
Instead of having all TYPE_CCW_DEVICE children set the bus type to
TYPE_VIRTUAL_CSS_BUS, do it once in the abstract parent.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Eric Farman
Message-Id: <20210424145313.3287400-1-f4...@amsat.org>
Signed-off-by: Cornelia
From: Eric Farman
Commit 690e29b91102 ("vfio-ccw: Refactor ccw irq handler") changed
one of the checks for the IRQ notifier registration from saying
"the host needs to recognize the only IRQ that exists" to saying
"the host needs to recognize ANY IRQ that exists."
And this worked fine, because
From: Eric Farman
The vfio_ccw_unrealize() routine makes an unconditional attempt to
unregister every IRQ notifier, though they may not have been registered
in the first place (when running on an older kernel, for example).
Let's mirror this behavior in the error cleanups in vfio_ccw_realize()
From: John Snow
Signed-off-by: John Snow
Message-Id: <20210519183951.3946870-16-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Doc string spacing tweaked slightly]
Signed-off-by: Markus Armbruster
---
scripts/qapi/parser.py | 69 ++
1 file changed,
From: John Snow
TypeGuards wont exist in Python proper until 3.10. Ah well. We can hack
up our own by declaring this function to return the type we claim it
checks for and using this to safely downcast object -> List[str].
In so doing, I bring this function under _pragma so it can use the
From: John Snow
No self, no thank you!
(Quiets pylint warnings.)
Signed-off-by: John Snow
Message-Id: <20210519183951.3946870-9-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/qapi/parser.py | 6 --
1 file changed, 4 insertions(+), 2
gt; Merge remote-tracking branch
> 'remotes/stsquad/tags/pull-testing-and-plugin-updates-180521-2' into staging
> (2021-05-20 10:00:58 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/cohuck/qemu.git tags/s390x-20210520-v2
>
> for you to fetch cha
On 5/20/21 6:27 PM, Richard Henderson wrote:
> On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
>> -static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr)
>> +static inline uint16_t virtio_lduw_p(VirtIODevice *vdev, const void
>> *ptr)
>
> While this one looks obviously correct,
>
On Wed, May 19, 2021 at 4:38 PM Philippe Mathieu-Daudé wrote:
>
> On 5/19/21 9:26 PM, Willian Rampazzo wrote:
> > On Wed, May 19, 2021 at 3:55 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> From: Philippe Mathieu-Daudé
> >>
> >> The acceptance tests aren't accepting anything,
> >> rename them
101 - 200 of 332 matches
Mail list logo
