[PATCH v2 8/9] Revert "vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration"

2021-09-09 Thread Longpeng(Mike)
Commit ecebe53fe993 ("vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration") avoid inefficiently disabling and enabling vectors repeatedly and let the unmasked vectors to be enabled one by one. But we want to batch multiple routes and defer the commit, and only commit once out

[PATCH v2 5/9] msix: reset poll_notifier to NULL if fail to set notifiers

2021-09-09 Thread Longpeng(Mike)
'msix_vector_poll_notifier' should be reset to NULL in the error path in msix_set_vector_notifiers(). Signed-off-by: Longpeng(Mike) --- hw/pci/msix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 6768228..8057709 100644 --- a/hw/pci/msix.c +++

[PATCH v2 1/9] vfio: simplify the conditional statements in vfio_msi_enable

2021-09-09 Thread Longpeng(Mike)
It's unnecessary to test against the specific return value of VFIO_DEVICE_SET_IRQS, since any positive return is an error indicating the number of vectors we should retry with. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 0/9] optimize the downtime for vfio migration

2021-09-09 Thread Longpeng(Mike)
Hi guys, In vfio migration resume phase, the cost would increase if the vfio device has more unmasked vectors. We try to optimize it in this series. You can see the commit message in PATCH 9 for details. Patch 1-5 are simple cleanups and fixup. Patch 6-8 are the preparations for the

Re: [RFC PATCH 0/2] riscv: Adding custom CSR related Kconfig options

2021-09-09 Thread Alistair Francis
On Tue, Sep 7, 2021 at 6:05 PM Ruinland ChuanTzu Tsai wrote: > > Hi Alistair, > > Thanks for the comment. > > On Mon, Sep 06, 2021 at 05:55:25PM +1000, Alistair Francis wrote: > > On Mon, Sep 6, 2021 at 5:37 PM Ruinland ChuanTzu Tsai > > wrote: > > > > > > Hi Alistair, > > > > > > So glad to

Re: [PATCH RFC server v2 06/11] vfio-user: handle PCI config space accesses

2021-09-09 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:25PM -0400, Jagannathan Raman wrote: > +static ssize_t vfu_object_cfg_access(vfu_ctx_t *vfu_ctx, char * const buf, > + size_t count, loff_t offset, > + const bool is_write) > +{ > +VfuObject

Re: [PATCH v5 3/9] migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*()

2021-09-09 Thread Juan Quintela
David Hildenbrand wrote: > The parameter is unused, let's drop it. > > Reviewed-by: Peter Xu > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: David Hildenbrand Reviewed-by: Juan Quintela

Re: [PULL for-6.1 06/11] hw/nvme: fix controller hot unplugging

2021-09-09 Thread Klaus Jensen
On Sep 9 09:02, Hannes Reinecke wrote: > On 7/26/21 9:18 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Prior to this patch the nvme-ns devices are always children of the > > NvmeBus owned by the NvmeCtrl. This causes the namespaces to be > > unrealized when the parent device is

[PATCH] qemu-options.hx: remove -spice options from --help

2021-09-09 Thread marcandre . lureau
From: Marc-André Lureau Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1982600 Signed-off-by: Marc-André Lureau --- softmmu/vl.c| 4 +++- qemu-options.hx | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 55ab70eb97..1e60d286b9

[PATCH v2 3/9] vfio: simplify the failure path in vfio_msi_enable

2021-09-09 Thread Longpeng(Mike)
Use vfio_msi_disable_common to simplify the error handling in vfio_msi_enable. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 1e6797f..8236cd7 100644 --- a/hw/vfio/pci.c +++

Re: [PATCH 3/7] i386: Add sgx_get_info() interface

2021-09-09 Thread Yang Zhong
On Wed, Sep 08, 2021 at 10:55:13AM +0200, Paolo Bonzini wrote: > On 08/09/21 10:19, Yang Zhong wrote: > >+if (x86ms->sgx_epc_list) { > >+PCMachineState *pcms = PC_MACHINE(ms); > >+SGXEPCState *sgx_epc = >sgx_epc; > >+info = g_new0(SGXInfo, 1); > >+ > >+info->sgx

Re: [PATCH] multifd: Implement yank for multifd send side

2021-09-09 Thread Juan Quintela
Lukas Straub wrote: > When introducing yank functionality in the migration code I forgot > to cover the multifd send side. > > Signed-off-by: Lukas Straub > Tested-by: Leonardo Bras > Reviewed-by: Leonardo Bras Reviewed-by: Juan Quintela

Re: [PATCH RFC server v2 10/11] vfio-user: register handlers to facilitate migration

2021-09-09 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:29PM -0400, Jagannathan Raman wrote: > +static ssize_t vfu_mig_buf_read(void *opaque, uint8_t *buf, int64_t pos, > +size_t size, Error **errp) > +{ > +VfuObject *o = opaque; > + > +if (pos > o->vfu_mig_buf_size) { > +

[PATCH 2/2] hmp: Drop a bogus sentence from set_password's documentation

2021-09-09 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hmp-commands.hx | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8e45bce2cd..cf723c69ac 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1522,12 +1522,11 @@ ERST SRST

Re: [PATCH] coroutine: resize pool periodically instead of limiting size

2021-09-09 Thread Daniel P . Berrangé
On Wed, Sep 01, 2021 at 05:09:23PM +0100, Stefan Hajnoczi wrote: > It was reported that enabling SafeStack reduces IOPS significantly > (>25%) with the following fio benchmark on virtio-blk using a NVMe host > block device: > > # fio --rw=randrw --bs=4k --iodepth=64 --runtime=1m --direct=1 \ >

Re: [PATCH 1/2] hmp: Unbreak "change vnc"

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 10:12:18AM +0200, Markus Armbruster wrote: > HMP command "change vnc" can take the password as argument, or prompt > for it: > > (qemu) change vnc password 123 > (qemu) change vnc password > Password: *** > (qemu) > > This regressed in commit cfb5387a1d

Re: [PATCH 2/2] hmp: Drop a bogus sentence from set_password's documentation

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 10:12:19AM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [RFC PATCH 0/2] riscv: Adding custom CSR related Kconfig options

2021-09-09 Thread Alistair Francis
On Tue, Sep 7, 2021 at 8:15 PM Rahul Pathak wrote: > > Hi Alistair, > > One clarification: The unification of architectures is also going to allow > multi-arch CPUs (RV32/RV64) in a single machine instance? Or it's just > limited to only one in the runtime. The first step (which doesn't work

Re: [PATCH v3 2/2] sifive_u: Connect the SiFive PWM device

2021-09-09 Thread Alistair Francis
On Thu, Sep 9, 2021 at 2:37 PM Bin Meng wrote: > > On Thu, Sep 9, 2021 at 11:55 AM Alistair Francis > wrote: > > > > From: Alistair Francis > > > > Connect the SiFive PWM device and expose it via the device tree. > > > > Signed-off-by: Alistair Francis > > --- > >

Re: [PATCH RFC server v2 08/11] vfio-user: handle PCI BAR accesses

2021-09-09 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:27PM -0400, Jagannathan Raman wrote: > +/** > + * VFU_OBJECT_BAR_HANDLER - macro for defining handlers for PCI BARs. > + * > + * To create handler for BAR number 2, VFU_OBJECT_BAR_HANDLER(2) would > + * define vfu_object_bar2_handler > + */ > +#define

Re: [PATCH RFC server v2 00/11] vfio-user server in QEMU

2021-09-09 Thread Stefan Hajnoczi
Hi Jag, I have finished reviewing these patches and left comments. I didn't take a look at the libvfio-user's implementation. Stefan signature.asc Description: PGP signature

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-09 Thread Michael S. Tsirkin
On Tue, Sep 07, 2021 at 02:22:24PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote: > > Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support") > > enabled the SEQPACKET feature bit. > > This commit is released with QEMU 6.1, so

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-09 Thread Markus Armbruster
Markus Armbruster writes: [...] > Limitations: > > 1. If we convert a long-running HMP command to this technique, we print >its output only after it completed its work. We also end up with a >long-running QMP command, which is bad, because it stops the main >loop and makes the QMP

Re: [PATCH] hw/display/ati_2d: Fix buffer overflow in ati_2d_blt (CVE-2021-3638)

2021-09-09 Thread Mauro Matteo Cascella
On Tue, Sep 7, 2021 at 8:22 AM Philippe Mathieu-Daudé wrote: > > On 9/7/21 7:38 AM, Philippe Mathieu-Daudé wrote: > > On 9/6/21 9:52 PM, BALATON Zoltan wrote: > >> I don't think assigning a CVE to a bug that is in an experimental and > >> largely unused part and happens when one enables debug

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-09 Thread Paolo Bonzini
On 08/09/21 17:09, Markus Armbruster wrote: This is 77 out of 170 HMP commands. I was hoping for fewer. There are several that are not quite 1:1, but still not HMP-specific. exit_preconfig This is x-exit-preconfig. migrate_set_capability migrate_set_parameter These are

Re: [PATCH v2 04/22] target/riscv: Improve fidelity of guest external interrupts

2021-09-09 Thread Alistair Francis
On Thu, Sep 2, 2021 at 9:26 PM Anup Patel wrote: > > The guest external interrupts for external interrupt controller are > not delivered to the guest running under hypervisor on time. This > results in a guest having sluggish response to serial console input > and other I/O events. To improve

Re: [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform

2021-09-09 Thread Yang Zhong
On Wed, Sep 08, 2021 at 10:54:06AM +0200, Paolo Bonzini wrote: > On 08/09/21 10:19, Yang Zhong wrote: > >+if (sgx_enabled) { > >+MachineState *ms = MACHINE(qdev_get_machine()); > >+X86MachineState *x86ms = X86_MACHINE(qdev_get_machine()); > >+ > > You can use

Re: [PULL for-6.1 06/11] hw/nvme: fix controller hot unplugging

2021-09-09 Thread Hannes Reinecke
On 7/26/21 9:18 PM, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the parent device is removed. However, when subsystems are involved, this is not what we

Re: [PATCH RFC server v2 07/11] vfio-user: handle DMA mappings

2021-09-09 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:26PM -0400, Jagannathan Raman wrote: > Define and register callbacks to manage the RAM regions used for > device DMA > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/remote/vfio-user-obj.c | 50 >

[PATCH v2 9/9] vfio: defer to commit kvm irq routing when enable msi/msix

2021-09-09 Thread Longpeng(Mike)
In migration resume phase, all unmasked msix vectors need to be setup when load the VF state. However, the setup operation would take longer if the VM has more VFs and each VF has more unmasked vectors. The hot spot is kvm_irqchip_commit_routes, it'll scan and update all irqfds that already

Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-09-09 Thread Juan Quintela
Lukas Straub wrote: > Unconditionally unregister yank function in multifd_load_cleanup(). > If it is not unregistered here, it will leak and cause a crash > in yank_unregister_instance(). Now if the ioc is still in use > afterwards, it will only lead to qemu not being able to recover > from a

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 06:48:21AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Sep 08, 2021 at 05:09:13PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > We are still adding HMP commands without any QMP counterparts. This is > >> >

Re: [PATCH v1 2/3] io: Add zerocopy and errqueue

2021-09-09 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Sep 08, 2021 at 09:30:58AM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Sep 07, 2021 at 12:06:15PM +0100, Dr. David Alan Gilbert wrote: > > > > > > What if we do the 'flush()' before we start post-copy,

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 04:47:42AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 07, 2021 at 02:22:24PM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote: > > > Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support") > > >

Re: [PATCH RFC v2 09/16] vfio-user: region read/write

2021-09-09 Thread John Johnson
> On Sep 7, 2021, at 10:24 AM, John Levon wrote: > > On Mon, Aug 16, 2021 at 09:42:42AM -0700, Elena Ufimtseva wrote: > >> +int vfio_user_region_write(VFIODevice *vbasedev, uint32_t index, >> + uint64_t offset, uint32_t count, void *data) >> +{ >> +g_autofree

[PATCH v2 4/9] msix: simplify the conditional in msix_set/unset_vector_notifiers

2021-09-09 Thread Longpeng(Mike)
'msix_function_masked' is synchronized with the device's config, we can use it to replace the complex conditional statementis in msix_set/unset_vector_notifiers. Signed-off-by: Longpeng(Mike) --- hw/pci/msix.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH RFC v2 04/16] vfio-user: connect vfio proxy to remote server

2021-09-09 Thread Stefan Hajnoczi
On Thu, Sep 09, 2021 at 05:11:49AM +, John Johnson wrote: > > > > On Sep 7, 2021, at 6:21 AM, Stefan Hajnoczi wrote: > > > > > > This way the network communication code doesn't need to know how > > messages will by processed by the client or server. There is no need for > > if (isreply) {

Re: [PATCH v2 2/2] migration: allow enabling mutilfd for specific protocol only

2021-09-09 Thread Juan Quintela
Li Zhijian wrote: > And change the default to true so that in '-incoming defer' case, user is able > to change multifd capability. > > Signed-off-by: Li Zhijian Reviewed-by: Juan Quintela

Re: [PATCH v4 1/1] hw/pflash_cfi01: Allow backing devices to be smaller than memory region

2021-09-09 Thread Philippe Mathieu-Daudé
Hi David, On 8/10/21 3:40 PM, David Edmondson wrote: > Allow the backing device to be smaller than the extent of the flash > device by mapping it as a subregion of the flash device region. > > Return zeroes for all reads of the flash device beyond the extent of > the backing device. > > For

[PATCH v2 6/9] kvm: irqchip: extract kvm_irqchip_add_deferred_msi_route

2021-09-09 Thread Longpeng(Mike)
Extract a common helper that add MSI route for specific vector but does not commit immediately. Signed-off-by: Longpeng(Mike) --- accel/kvm/kvm-all.c | 15 +-- include/sysemu/kvm.h | 6 ++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c

[PATCH v2 2/9] vfio: move re-enabling INTX out of the common helper

2021-09-09 Thread Longpeng(Mike)
Move re-enabling INTX out, and the callers should decide to re-enable it or not. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index f7a3a13..1e6797f 100644 --- a/hw/vfio/pci.c

[PATCH v2 7/9] vfio: add infrastructure to commit the deferred kvm routing

2021-09-09 Thread Longpeng(Mike)
'defer_kvm_irq_routing' indicates whether we should defer to commit the kvm routing. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 42 +- hw/vfio/pci.h | 1 + 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c

Re: [PATCH v2 22/22] docs/system: riscv: Document AIA options for virt machine

2021-09-09 Thread Alistair Francis
On Thu, Sep 2, 2021 at 10:07 PM Anup Patel wrote: > > We have two new machine options "aia" and "aia-guests" available > for the RISC-V virt machine so let's document these options. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair > --- > docs/system/riscv/virt.rst | 16

Re: [PATCH v2 1/2] migration: allow multifd for socket protocol only

2021-09-09 Thread Juan Quintela
Li Zhijian wrote: > multifd with unsupported protocol will cause a segment fault. > (gdb) bt > #0 0x563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at > ../util/qemu-sockets.c:1190 > #1 0x563b4a797a03 in qio_channel_socket_connect_sync > (ioc=0x563b4d16e8c0, addr=0x0,

Re: [PATCH RFC server v2 09/11] vfio-user: handle device interrupts

2021-09-09 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:28PM -0400, Jagannathan Raman wrote: > Forward remote device's interrupts to the guest > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/remote/iohub.h | 2 ++ > hw/remote/iohub.c |

[PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc

2021-09-09 Thread Markus Armbruster
If you'd rather delete "change vnc", go ahead and post a patch. Markus Armbruster (2): hmp: Unbreak "change vnc" hmp: Drop a bogus sentence from set_password's documentation monitor/hmp-cmds.c | 2 +- hmp-commands.hx| 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) --

[PATCH 1/2] hmp: Unbreak "change vnc"

2021-09-09 Thread Markus Armbruster
HMP command "change vnc" can take the password as argument, or prompt for it: (qemu) change vnc password 123 (qemu) change vnc password Password: *** (qemu) This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET" command", v6.0.0. (qemu) change vnc passwd 123

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2021-09-09 Thread Stefano Garzarella
On Wed, Sep 08, 2021 at 06:20:49PM +0300, Denis Plotnikov wrote: On 08.09.2021 16:22, Stefano Garzarella wrote: Message bounced, I use new Denis's email address. On Wed, Sep 08, 2021 at 03:17:16PM +0200, Stefano Garzarella wrote: Hi Denis, I just found this discussion since we still have the

Re: [PATCH 4/5] qapi: introduce x-query-registers QMP command

2021-09-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > This is a counterpart to the HMP "info registers" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long term

Re: [PATCH] hw/display/ati_2d: Fix buffer overflow in ati_2d_blt (CVE-2021-3638)

2021-09-09 Thread Philippe Mathieu-Daudé
On 9/9/21 11:16 AM, Mauro Matteo Cascella wrote: > On Tue, Sep 7, 2021 at 8:22 AM Philippe Mathieu-Daudé > wrote: >> On 9/7/21 7:38 AM, Philippe Mathieu-Daudé wrote: >>> On 9/6/21 9:52 PM, BALATON Zoltan wrote: I don't think assigning a CVE to a bug that is in an experimental and

Re: [PATCH 3/5] target/i386: convert to use format_state instead of dump_state

2021-09-09 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 11:06:33PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 08, 2021 at 01:05:13PM -0500, Eric Blake wrote: > > On Wed, Sep 08, 2021 at 11:37:09AM +0100, Daniel P. Berrangé wrote: > > > Signed-off-by: Daniel P. Berrangé > > > --- > > > target/i386/cpu-dump.c | 325

[PULL 4/7] migration/rdma: advise prefetch write for ODP region

2021-09-09 Thread Juan Quintela
From: Li Zhijian To: , CC: , Li Zhijian , "Marcel Apfelbaum" Date: Mon, 23 Aug 2021 11:33:58 +0800 (2 weeks, 3 days, 3 hours ago) The responder mr registering with ODP will sent RNR NAK back to the requester in the face of the page fault. - ibv_poll_cq wc.status=13 RNR retry counter

[PULL 1/7] multifd: Implement yank for multifd send side

2021-09-09 Thread Juan Quintela
From: Lukas Straub To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 1 Sep 2021 17:58:57 +0200 (1 week, 15 hours, 17 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-09-01T17:58:57+0200 using

[PULL 0/7] Migration.next patches

2021-09-09 Thread Juan Quintela
The following changes since commit bd662023e683850c085e98c8ff8297142c2dd9f2: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210908' into staging (2021-09-08 11:06:17 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git

Re: [RFC v3 00/32] Rust binding for QAPI and qemu-ga QMP handler examples

2021-09-09 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Sep 8, 2021 at 5:23 PM Markus Armbruster wrote: > >> Build fails for me: >> >> make: Entering directory '/work/armbru/qemu/bld' >> config-host.mak is out-of-date, running configure >> GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 >>

Re: [RFC PATCH 02/10] accel: Use qemu_security_policy_taint(), mark KVM and Xen as safe

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 01:20:16AM +0200, Philippe Mathieu-Daudé wrote: > Add the AccelClass::secure_policy_supported field to classify > safe (within security boundary) vs unsafe accelerators. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/accel.h | 5 + >

Re: [RFC PATCH 03/10] block: Use qemu_security_policy_taint() API

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 01:20:17AM +0200, Philippe Mathieu-Daudé wrote: > Add the BlockDriver::bdrv_taints_security_policy() handler. > Drivers implementing it might taint the global QEMU security > policy. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/block/block_int.h | 6 +- >

Re: [PATCH] hw/nvme: reattach subsystem namespaces on hotplug

2021-09-09 Thread Klaus Jensen
On Sep 9 11:43, Hannes Reinecke wrote: > With commit 5ffbaeed16 ("hw/nvme: fix controller hot unplugging") > namespaces get moved from the controller to the subsystem if one > is specified. > That keeps the namespaces alive after a controller hot-unplug, but > after a controller hotplug we have

[RFC PATCH v1 2/3] hw/pci: Add PCIe RCEC support

2021-09-09 Thread Mayuresh Chitale
This patch adds support for PCIe Root Complex Event Collector (RCEC) emulation. Further, if a RCiEP supports AER capability then a mapping is created for that RCiEP in the RCEC's endpoint association capability. Signed-off-by: Mayuresh Chitale --- hw/pci/meson.build | 2 +-

[RFC PATCH v1 0/3] PCIe Root complex event collector

2021-09-09 Thread Mayuresh Chitale
Hi All, This is a first attempt to add PCIe Root Complex Event Collector emulation support to Qemu. This patch is created on Qemu commit:88afdc92b6 and tested using Qemu Risc V virt machine and the PCIe aer error injection module in the Linux kernel(v 5.14). Thanks, Mayuresh. Mayuresh Chitale

[PATCH 0/2] RX target update

2021-09-09 Thread Yoshinori Sato
I found some problem in RX target. This patches fix it. Yoshinori Sato (2): target/rx: Fix helper definiton. target/rx: gdbstub add acc register operation. target/rx/helper.h | 36 ++-- target/rx/gdbstub.c | 3 ++- 2 files changed, 20 insertions(+), 19

Re: [PATCH RFC v2 09/16] vfio-user: region read/write

2021-09-09 Thread John Levon
On Thu, Sep 09, 2021 at 06:00:36AM +, John Johnson wrote: > > On Sep 7, 2021, at 10:24 AM, John Levon wrote: > > > > On Mon, Aug 16, 2021 at 09:42:42AM -0700, Elena Ufimtseva wrote: > > > >> +int vfio_user_region_write(VFIODevice *vbasedev, uint32_t index, > >> +

[PATCH 1/2] target/rx: Fix helper definiton.

2021-09-09 Thread Yoshinori Sato
Due to an incorrect definition of helper, TCG optimization could sometimes behave unexpectedly. Signed-off-by: Yoshinori Sato --- target/rx/helper.h | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/target/rx/helper.h b/target/rx/helper.h

Re: [PATCH 1/2] target/rx: Fix helper definiton.

2021-09-09 Thread Peter Maydell
On Thu, 9 Sept 2021 at 13:10, Yoshinori Sato wrote: > > Due to an incorrect definition of helper, > TCG optimization could sometimes behave unexpectedly. > > Signed-off-by: Yoshinori Sato Could you give more detail, please? I had a look at one or two -- it looks like the floating point related

RE: [PATCH v2] net/colo: check vnet_hdr_support flag when using virtio-net

2021-09-09 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Sunday, September 5, 2021 7:48 PM > To: Zhang, Chen > Cc: Xu, Tao3 ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [PATCH v2] net/colo: check vnet_hdr_support flag when using > virtio-net > > On

Re: [PATCH RFC v2 11/16] vfio-user: get and set IRQs

2021-09-09 Thread Stefan Hajnoczi
On Thu, Sep 09, 2021 at 05:50:39AM +, John Johnson wrote: > > > > On Sep 7, 2021, at 8:14 AM, Stefan Hajnoczi wrote: > > > > On Mon, Aug 16, 2021 at 09:42:44AM -0700, Elena Ufimtseva wrote: > >> From: John Johnson > >> > >> Signed-off-by: Elena Ufimtseva > >> Signed-off-by: John G

[PATCH] docs: link to archived Fedora code of conduct

2021-09-09 Thread Paolo Bonzini
Fedora has switched to a different CoC. QEMU's own code of conduct is based on the previous version and cites it as a source. Replace the link with one to the Wayback Machine. Signed-off-by: Paolo Bonzini --- docs/devel/code-of-conduct.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

[RFC PATCH 4/5] target/i386: Define specific PT feature set for IceLake-server and Snowridge

2021-09-09 Thread Xiaoyao Li
For IceLake-server, it's just the same as using the default PT feature set since the default one is exact taken from ICX. For Snowridge, define it according to real SNR silicon capabilities. Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 20 1 file changed, 20

[RFC PATCH 1/5] target/i386: Print CPUID subleaf info for unsupported feature

2021-09-09 Thread Xiaoyao Li
Some CPUID leaves have meaningful subleaf index. Print the subleaf info in feature_word_description for CPUID features. Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

Re: [PULL 0/7] Migration.next patches

2021-09-09 Thread Peter Maydell
On Thu, 9 Sept 2021 at 15:49, Li, Zhijian wrote: > > on 2021/9/9 21:42, Peter Maydell wrote: > > On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote: > > Fails to build, FreeBSD: > > > > ../src/migration/rdma.c:1146:23: error: use of undeclared identifier > > 'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE'

Re: [PULL 00/42] bsd-user updates to run hello world

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 09:12:45AM -0600, Warner Losh wrote: > On Thu, Sep 9, 2021, 9:01 AM Peter Maydell wrote: > > > On Tue, 7 Sept 2021 at 22:56, wrote: > > > > > > From: Warner Losh > > > > > > The following changes since commit > > f214d8e0150766c31172e16ef4b17674f549d852: > > > > > >

Re: [PATCH v2 0/3] hw/arm/virt_acpi_build: Generate DBG2 table

2021-09-09 Thread Eric Auger
Hi Drew, On 9/8/21 11:14 AM, Andrew Jones wrote: > On Mon, Sep 06, 2021 at 02:31:36PM +0200, Eric Auger wrote: >> This series generates the ACPI DBG2 table along with machvirt. >> It applies on top of Igor's >> [PATCH v2 00/35] acpi: refactor error prone build_header() and >> packed structures

Re: [PULL v4 00/43] (Mostly) x86 changes for 2021-09-06

2021-09-09 Thread Peter Maydell
On Wed, 8 Sept 2021 at 11:07, Paolo Bonzini wrote: > > The following changes since commit f9128631fbeb40a55f7bc145397981c963d40909: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-09-07 > 13:24:43 +0100) > > are available in the Git

[RFC PATCH 2/5] target/i386: Introduce FeatureWordInfo for Intel PT CPUID leaf 0xD

2021-09-09 Thread Xiaoyao Li
CPUID leaf 0x14 subleaf 0x0 and 0x1 enumerate the resource and capability of Intel PT. Introduce FeatureWord FEAT_14_0_EBX, FEAT_14_1_EAX and FEAT_14_1_EBX, and complete FEAT_14_0_ECX. Thus all the features of Intel PT can be expanded when "-cpu host/max" and can be configured in named CPU model.

[RFC PATCH 0/5] Make Intel PT configurable

2021-09-09 Thread Xiaoyao Li
Initial Intel PT support was added by making it as fixed feature set as ICX's capabilities, which allowed different CPU model with PT enabled live migration on ICX host. However, it breaks the PT exposure/working on SPR machine. Because SPR has less PT capabilities regrading

[RFC PATCH 5/5] target/i386: Access MSR_IA32_RTIT_ADDRn based on guest CPUID configuration

2021-09-09 Thread Xiaoyao Li
KVM only allows userspace to access legal number of MSR_IA32_RTIT_ADDRn, which is enumrated by guest's CPUID(0x14,0x1):EAX[2:0], i.e., env->features[FEAT_14_1_EAX] & INTEL_PT_ADDR_RANGES_NUM_MASK Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 1 - target/i386/cpu.h | 2 ++

Re: [PULL 0/7] Migration.next patches

2021-09-09 Thread Peter Maydell
On Thu, 9 Sept 2021 at 16:23, Juan Quintela wrote: > From 964e436bdb8aef7dbebc28415e4ac3c5822b552e Mon Sep 17 00:00:00 2001 > From: Juan Quintela > Date: Thu, 9 Sep 2021 17:07:17 +0200 > Subject: [PATCH] rdma: test for ibv_advise_mr API > > Signed-off-by: Juan Quintela > --- > configure

Re: [PATCH] coroutine: resize pool periodically instead of limiting size

2021-09-09 Thread Stefan Hajnoczi
On Thu, Sep 09, 2021 at 09:37:20AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 01, 2021 at 05:09:23PM +0100, Stefan Hajnoczi wrote: > > It was reported that enabling SafeStack reduces IOPS significantly > > (>25%) with the following fio benchmark on virtio-blk using a NVMe host > > block

Re: [PATCH 5/7] qmp: Add the qmp_query_sgx_capabilities()

2021-09-09 Thread Philippe Mathieu-Daudé
On 9/9/21 2:06 PM, Yang Zhong wrote: > On Thu, Sep 09, 2021 at 11:36:58AM +0200, Philippe Mathieu-Daudé wrote: >> On 9/9/21 4:51 AM, Yang Zhong wrote: >>> On Wed, Sep 08, 2021 at 10:38:59AM +0200, Philippe Mathieu-Daudé wrote: On 9/8/21 10:19 AM, Yang Zhong wrote: > Libvirt can use

Re: [PULL v4 00/43] (Mostly) x86 changes for 2021-09-06

2021-09-09 Thread Philippe Mathieu-Daudé
On 9/9/21 3:25 PM, Peter Maydell wrote: > On Wed, 8 Sept 2021 at 11:07, Paolo Bonzini wrote: >> >> The following changes since commit f9128631fbeb40a55f7bc145397981c963d40909: >> >> Merge remote-tracking branch >> 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-09-07 >>

Re: [PATCH 1/4] target/arm: Add TB flag for "MVE insns not predicated"

2021-09-09 Thread Peter Maydell
On Fri, 3 Sept 2021 at 14:58, Richard Henderson wrote: > > On 9/2/21 5:09 PM, Peter Maydell wrote: > > Our current codegen for MVE always calls out to helper functions, > > because some byte lanes might be predicated. The common case is > > that in fact there is no predication active and all

Re: [PULL 00/42] bsd-user updates to run hello world

2021-09-09 Thread Warner Losh
On Thu, Sep 9, 2021, 9:01 AM Peter Maydell wrote: > On Tue, 7 Sept 2021 at 22:56, wrote: > > > > From: Warner Losh > > > > The following changes since commit > f214d8e0150766c31172e16ef4b17674f549d852: > > > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210826'

[PATCH v2] qemu-options: show -spice options only if #ifdef CONFIG_SPICE

2021-09-09 Thread marcandre . lureau
From: Marc-André Lureau Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1982600 Signed-off-by: Marc-André Lureau --- softmmu/vl.c| 4 +++- qemu-options.hx | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 55ab70eb97..1e60d286b9

RE: [PATCH V3 00/10] vhost-vDPA multiqueue

2021-09-09 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Jason Wang > Sent: Tuesday, September 7, 2021 5:03 PM > To: m...@redhat.com; jasow...@redhat.com; qemu-devel@nongnu.org > Cc: epere...@redhat.com; e...@nvidia.com; gda...@xilinx.com; Zhu, >

RE: [PATCH V3 04/10] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *

2021-09-09 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Jason Wang > Sent: Tuesday, September 7, 2021 5:03 PM > To: m...@redhat.com; jasow...@redhat.com; qemu-devel@nongnu.org > Cc: epere...@redhat.com; e...@nvidia.com; gda...@xilinx.com; Zhu, >

Re: [PATCH] coroutine: resize pool periodically instead of limiting size

2021-09-09 Thread Stefan Hajnoczi
On Wed, Sep 08, 2021 at 10:30:09PM -0400, Daniele Buono wrote: > Stefan, the patch looks great. > Thank you for debugging the performance issue that was happening with > SafeStack. > > On 9/2/2021 4:10 AM, Stefan Hajnoczi wrote: > > On Wed, Sep 01, 2021 at 05:09:23PM +0100, Stefan Hajnoczi wrote:

Re: [PULL v4 35/43] Kconfig: Add CONFIG_SGX support

2021-09-09 Thread Philippe Mathieu-Daudé
On 9/9/21 3:16 PM, Philippe Mathieu-Daudé wrote: > On 9/8/21 12:04 PM, Paolo Bonzini wrote: >> From: Yang Zhong >> >> Add new CONFIG_SGX for sgx support in the Qemu, and the Kconfig >> default enable sgx in the i386 platform. >> >> Signed-off-by: Yang Zhong >> Message-Id:

Re: [PATCH 1/4] target/arm: Add TB flag for "MVE insns not predicated"

2021-09-09 Thread Peter Maydell
On Fri, 3 Sept 2021 at 14:58, Richard Henderson wrote: > I think you need to go ahead and end the TB and resync immediately. > Just set dc->base.is_jmp = DISAS_UPDATE_NOCHAIN instead. Is there a rule for when we should set is_jmp to DISAS_UPDATE_NOCHAIN, when we should set it to

[RFC PATCH 3/5] target/i386: Enable host pass through of Intel PT

2021-09-09 Thread Xiaoyao Li
commit e37a5c7fa459 ("i386: Add Intel Processor Trace feature support") added the support of Intel PT by making CPUID[14] of PT as fixed feature set (from ICX) for any CPU model on any host. This truly breaks the PT exposing on Intel SPR platform because SPR has less supported bitmap

Re: [PULL 0/7] Migration.next patches

2021-09-09 Thread Li, Zhijian
on 2021/9/9 21:42, Peter Maydell wrote: On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote: Fails to build, FreeBSD: ../src/migration/rdma.c:1146:23: error: use of undeclared identifier 'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE' int advice = wr ? IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE :

Re: [PULL 00/42] bsd-user updates to run hello world

2021-09-09 Thread Peter Maydell
On Tue, 7 Sept 2021 at 22:56, wrote: > > From: Warner Losh > > The following changes since commit f214d8e0150766c31172e16ef4b17674f549d852: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210826' into staging (2021-08-26 > 18:03:57 +0100) > > are available in the

RE: [PATCH V3 05/10] net: introduce control client

2021-09-09 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Jason Wang > Sent: Tuesday, September 7, 2021 5:03 PM > To: m...@redhat.com; jasow...@redhat.com; qemu-devel@nongnu.org > Cc: epere...@redhat.com; e...@nvidia.com; gda...@xilinx.com; Zhu, >

Re: [PULL 0/7] Migration.next patches

2021-09-09 Thread Peter Maydell
On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote: > > The following changes since commit bd662023e683850c085e98c8ff8297142c2dd9f2: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210908' > into staging (2021-09-08 11:06:17 +0100) > > are available in the Git repository

[PATCH] memory: remove incorrect RCU comment for address_space_read()

2021-09-09 Thread Stefan Hajnoczi
Although the doc comment says "Called within RCU critical section" the address_space_read() function takes the RCU read lock itself. There is no need for the caller to hold an RCU read lock. Cc: Paolo Bonzini Fixes: b2a44fcad74f1cc7a6786d38eba7db12ab2352ba ("address_space_read:

Re: [RFC v3 00/32] Rust binding for QAPI and qemu-ga QMP handler examples

2021-09-09 Thread Marc-André Lureau
Hi On Thu, Sep 9, 2021 at 2:31 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Wed, Sep 8, 2021 at 5:23 PM Markus Armbruster > wrote: > > > >> Build fails for me: > >> > >> make: Entering directory '/work/armbru/qemu/bld' > >> config-host.mak is out-of-date,

Re: [PULL 0/7] Migration.next patches

2021-09-09 Thread Juan Quintela
"Li, Zhijian" wrote: > on 2021/9/9 21:42, Peter Maydell wrote: >> On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote: >> Fails to build, FreeBSD: >> >> ../src/migration/rdma.c:1146:23: error: use of undeclared identifier >> 'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE' >> int advice = wr ?

Re: [RFC v3 13/32] rust: use vendored-sources

2021-09-09 Thread Peter Maydell
On Tue, 7 Sept 2021 at 13:32, wrote: > > From: Marc-André Lureau > > Most likely, QEMU will want tighter control over the sources, rather > than relying on crates.io downloading, use a git submodule with all the > dependencies. However, cargo --offline was added in 1.36. > > "cargo vendor" helps

Re: [PULL 0/7] Migration.next patches

2021-09-09 Thread Juan Quintela
"Li, Zhijian" wrote: > on 2021/9/9 21:42, Peter Maydell wrote: >> On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote: >> Fails to build, FreeBSD: >> >> ../src/migration/rdma.c:1146:23: error: use of undeclared identifier >> 'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE' >> int advice = wr ?

Re: [PATCH] coroutine: resize pool periodically instead of limiting size

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 04:51:44PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 09, 2021 at 09:37:20AM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 01, 2021 at 05:09:23PM +0100, Stefan Hajnoczi wrote: > > > It was reported that enabling SafeStack reduces IOPS significantly > > > (>25%) with the

Re: [PATCH v2] hw/arm: Add support for kudo-bmc board.

2021-09-09 Thread Patrick Venture
On Tue, Sep 7, 2021 at 3:35 PM Chris Rauer wrote: > kudo-bmc is a board supported by OpenBMC. > https://github.com/openbmc/openbmc/tree/master/meta-fii/meta-kudo > > Since v1: > - hyphenated Cortex-A9 > > Tested: Booted kudo firmware. > Signed-off-by: Chris Rauer > Reviewed-by: Patrick Venture

  1   2   3   >