[PATCH v2 08/54] ps2: implement ps2_reset() for the PS2_DEVICE QOM type based upon ps2_common_reset()

2022-06-24 Thread Mark Cave-Ayland
The functionality of ps2_common_reset() can be moved into a new ps2_reset() function for the PS2_DEVICE QOM type. Update PS2DeviceClass to hold a reference to the parent reset function and update the PS2_KBD_DEVICE and PS2_MOUSE_DEVICE types to use device_class_set_parent_reset() accordingly.

[PATCH v2 16/54] lasips2: spacing fixes

2022-06-24 Thread Mark Cave-Ayland
This helps improve the readability of lasips2.c. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Acked-by: Helge Deller --- hw/input/lasips2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c index

[PATCH v2 15/54] pl050: split pl050_update_irq() into separate pl050_set_irq() and pl050_update_irq() functions

2022-06-24 Thread Mark Cave-Ayland
This will soon allow pl050_set_irq() to be used as a GPIO input function. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Acked-by: Helge Deller --- hw/input/pl050.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/input/pl050.c

[PATCH v2 34/54] ps2: add gpio for output IRQ and optionally use it in ps2_raise_irq() and ps2_lower_irq()

2022-06-24 Thread Mark Cave-Ayland
Define the gpio for the PS2 output IRQ in ps2_init() and add logic to optionally use it in ps2_raise_irq() and ps2_lower_irq() if the gpio is connected. If the gpio is not connected then call the legacy update_irq() function as before. This allows the incremental conversion of devices from the

[PATCH v2 27/54] pckbd: alter i8042_mm_init() to return a I8042_MMIO device

2022-06-24 Thread Mark Cave-Ayland
This exposes the I8042_MMIO device to the caller to allow the register memory region to be mapped outside of i8042_mm_init(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/pckbd.c | 8 +--- include/hw/input/i8042.h | 6 +++--- 2

Re: [PATCH v3 30/51] target/arm: Implement FMOPA, FMOPS (non-widening)

2022-06-24 Thread Richard Henderson
On 6/24/22 05:31, Peter Maydell wrote: On Mon, 20 Jun 2022 at 19:07, Richard Henderson wrote: Signed-off-by: Richard Henderson +void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn, + void *vpm, void *vst, uint32_t desc) +{ +intptr_t row, col,

[PATCH v2 44/54] lasips2: add base property

2022-06-24 Thread Mark Cave-Ayland
This is in preparation for handling vmstate_register() within the device. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller --- hw/input/lasips2.c | 17 - include/hw/input/lasips2.h | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git

[PATCH] build: Do not depend on pc-bios for config-host.mak

2022-06-24 Thread Akihiko Odaki
Commit 45f1eecdd63f9e4fa93fef01dd826e7706ac6d7b removed the dependency from configure to pc-bios Signed-off-by: Akihiko Odaki --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3c0d89057eb..2e95d473b3e 100644 --- a/Makefile +++ b/Makefile

Re: [PATCH] msi: fix MSI vector limit check in msi_set_mask()

2022-06-24 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi On Thu, 23 Jun 2022 at 16:42, Jagannathan Raman wrote: > > MSI supports a maximum of PCI_MSI_VECTORS_MAX vectors - from 0 to > PCI_MSI_VECTORS_MAX - 1. > > msi_set_mask() was previously using PCI_MSI_VECTORS_MAX as the upper > limit for MSI vectors. Fix the upper

Re: [PATCH v2 46/54] lasips2: use sysbus IRQ for output IRQ

2022-06-24 Thread Peter Maydell
On Fri, 24 Jun 2022 at 14:44, Mark Cave-Ayland wrote: > > This enables the IRQ to be wired up using sysbus_connect_irq() in > lasips2_initfn(). > > Signed-off-by: Mark Cave-Ayland > Acked-by: Helge Deller Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v2 1/2] hw: canokey: Remove HS support as not compliant to the spec

2022-06-24 Thread MkfsSion
Canokey core currently using 16 bytes as maximum packet size for control endpoint, but to run the device in high-speed a 64 bytes maximum packet size is required according to USB 2.0 specification. Since we don't acutally need to run the device in high-speed, simply don't assign high member in

Re: [PATCH v3 22/51] target/arm: Trap AdvSIMD usage when Streaming SVE is active

2022-06-24 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:09, Richard Henderson wrote: > > This new behaviour is in the ARM pseudocode function > AArch64.CheckFPAdvSIMDEnabled, which applies to AArch32 > via AArch32.CheckAdvSIMDOrFPEnabled when the EL to which > the trap would be delivered is in AArch64 mode. > > Given that

[PULL v2 06/20] block: Support passing NULL ops to blk_set_dev_ops()

2022-06-24 Thread Kevin Wolf
From: Xie Yongji This supports passing NULL ops to blk_set_dev_ops() so that we can remove stale ops in some cases. Signed-off-by: Xie Yongji Reviewed-by: Stefan Hajnoczi Message-Id: <20220523084611.91-2-xieyon...@bytedance.com> Signed-off-by: Kevin Wolf --- block/block-backend.c | 2 +- 1

Re: [PATCH 1/2] target/arm: Extend arm_pamax to more than aarch64

2022-06-24 Thread Peter Maydell
On Sun, 19 Jun 2022 at 01:16, Richard Henderson wrote: > > Move the code from hw/arm/virt.c that is supposed > to handle v7 into the one function. > > Signed-off-by: Richard Henderson > --- > hw/arm/virt.c| 10 +- > target/arm/ptw.c | 24 Reviewed-by: Peter

[RFC PATCH] tests/9p: introduce declarative function calls

2022-06-24 Thread Christian Schoenebeck
There are currently 3 different functions for sending a 9p 'Twalk' request. They are all doing the same thing, just in a slightly different way and with slightly different function arguments. Merge those 3 functions into a single function by using a struct for function call arguments and use

Re: [PATCH v2 3/3] target/ppc: Check page dir/table base alignment

2022-06-24 Thread Fabiano Rosas
Leandro Lupori writes: > Check if each page dir/table base address is properly aligned and > log a guest error if not, as real hardware behave incorrectly in > this case. I think the commit message could be clearer, something like: According to PowerISA 3.1B, Book III 6.7.6 programming note,

[PATCH RESEND v2 2/2] target/ppc: Implement ISA 3.00 tlbie[l]

2022-06-24 Thread Leandro Lupori
This initial version supports the invalidation of one or all TLB entries. Flush by PID/LPID, or based in process/partition scope is not supported, because it would make using the generic QEMU TLB implementation hard. In these cases, all entries are flushed. Signed-off-by: Leandro Lupori ---

[PATCH v2 14/54] pl050: checkpatch fixes

2022-06-24 Thread Mark Cave-Ayland
This patch also includes a couple of minor spacing updates. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Acked-by: Helge Deller --- hw/input/pl050.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/hw/input/pl050.c

Re: [PATCH v3 01/12] ppc/pnv: add PHB3 bus init helper

2022-06-24 Thread Cédric Le Goater
(Adding people who could help making the right change) On 6/24/22 10:49, Daniel Henrique Barboza wrote: The PnvPHB3 bus init consists of initializing the pci_io and pci_mmio regions, registering it via pci_register_root_bus() and then setup the iommu. We'll want to init the bus from outside

[PATCH v2 32/54] ps2: use ps2_raise_irq() instead of calling update_irq() directly

2022-06-24 Thread Mark Cave-Ayland
This consolidates the logic of raising the PS2 IRQ into one single function. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index

[PATCH v2 47/54] lasips2: switch over from update_irq() function to PS2 device gpio

2022-06-24 Thread Mark Cave-Ayland
Add a qdev gpio input in lasips2_init() by taking the existing lasips2_port_set_irq() function, updating it accordingly and then renaming to lasips2_set_irq(). Use these new qdev gpio inputs to wire up the PS2 keyboard and mouse devices. At the same time set update_irq() and update_arg to NULL

Re: [PATCH v2 1/8] aspeed: Set CPU memory property explicitly

2022-06-24 Thread Peter Delevoryas
> On Jun 23, 2022, at 11:55 PM, Cédric Le Goater wrote: > > On 6/24/22 08:36, Cédric Le Goater wrote: >> On 6/24/22 02:36, Peter Delevoryas wrote: >>> Signed-off-by: Peter Delevoryas >> Please merge this patch with patch 2 in which the "memory" property >> is defined. > > Ah no. That's

[PATCH v8 2/4] cutils: Introduce bundle mechanism

2022-06-24 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files in the installation tree. The build tree will have a new directory, qemu-bundle, to

[PATCH v8 0/4] cutils: Introduce bundle mechanism

2022-06-24 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory,

Re: [PATCH v11 1/2] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2022-06-24 Thread Jonathan Cameron via
On Fri, 24 Jun 2022 15:08:44 +0100 Jonathan Cameron wrote: > On Fri, 24 Jun 2022 13:56:32 +0100 > Peter Maydell wrote: > > > On Fri, 24 Jun 2022 at 13:39, Jonathan Cameron > > wrote: > > > > > > On Fri, 24 Jun 2022 11:48:47 +0100 > > > Peter Maydell wrote: > > > > > > > > This seems to

Re: [PATCH v8 0/4] cutils: Introduce bundle mechanism

2022-06-24 Thread Akihiko Odaki
On 2022/06/25 0:26, Paolo Bonzini wrote: The only change I'd make (which I can do when queueing the patch) is to change the directory name to something "strange" like "=install", so that it's unlikely to have a directory named like that in the $bindir. Any opinions? Actually I prepended

[PULL v2 20/20] vduse-blk: Add name option

2022-06-24 Thread Kevin Wolf
From: Xie Yongji Currently we use 'id' option as the name of VDUSE device. It's a bit confusing since we use one value for two different purposes: the ID to identfy the export within QEMU (must be distinct from any other exports in the same QEMU process, but can overlap with names used by other

Re: [PATCH v2 2/3] target/ppc: Improve Radix xlate level validation

2022-06-24 Thread Fabiano Rosas
Leandro Lupori writes: > Check if the number and size of Radix levels are valid on > POWER9/POWER10 CPUs, according to the supported Radix Tree > Configurations described in their User Manuals. > > Signed-off-by: Leandro Lupori > --- > target/ppc/mmu-radix64.c | 51

[PATCH v2 22/54] pckbd: implement i8042_mmio_reset() for I8042_MMIO device

2022-06-24 Thread Mark Cave-Ayland
This allows the I8042_MMIO reset function to be registered directly within the DeviceClass rather than using qemu_register_reset() directly. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller --- hw/input/pckbd.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH v2 39/54] lasips2: move lasips2 QOM types from lasips2.c to lasips2.h

2022-06-24 Thread Mark Cave-Ayland
This allows the QOM types in lasips2.c to be used elsewhere by simply including lasips2.h. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/lasips2.c | 23 --- include/hw/input/lasips2.h | 22 ++ 2

[PATCH v2 35/54] pckbd: replace irq_kbd and irq_mouse with qemu_irq array in KBDState

2022-06-24 Thread Mark Cave-Ayland
This allows both IRQs to be declared as a single qdev gpio array. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/pckbd.c | 12 ++-- include/hw/input/i8042.h | 6 -- 2 files changed, 10 insertions(+), 8 deletions(-) diff

[PATCH v2 48/54] lasips2: add QEMU interface comment

2022-06-24 Thread Mark Cave-Ayland
This describes the LASI PS2 device interface implemented within QEMU. Signed-off-by: Mark Cave-Ayland --- include/hw/input/lasips2.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/hw/input/lasips2.h b/include/hw/input/lasips2.h index 7e4437b925..03f0c9e9f9 100644

[PATCH v2 50/54] pckbd: add QEMU interface comment for I8042_MMIO device

2022-06-24 Thread Mark Cave-Ayland
This describes the I8042_MMIO device interface implemented within QEMU. Signed-off-by: Mark Cave-Ayland --- include/hw/input/i8042.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/hw/input/i8042.h b/include/hw/input/i8042.h index 4ba2664377..d4747b62b8 100644 ---

Re: [PATCH v3 00/51] target/arm: Scalable Matrix Extension

2022-06-24 Thread Peter Maydell
On Mon, 20 Jun 2022 at 18:52, Richard Henderson wrote: > > Changes for v3: > * Rebase on mainline (20 patches upstreamed; new conflicts resolved). > * Test bit 31 before disas_sme. > > The first 21 patches, excepting 17, have been reviewed. I'm applying patches 1-20 to target-arm.next (with

Re: [PATCH v2 47/54] lasips2: switch over from update_irq() function to PS2 device gpio

2022-06-24 Thread Peter Maydell
On Fri, 24 Jun 2022 at 14:44, Mark Cave-Ayland wrote: > > Add a qdev gpio input in lasips2_init() by taking the existing > lasips2_port_set_irq() > function, updating it accordingly and then renaming to lasips2_set_irq(). Use > these > new qdev gpio inputs to wire up the PS2 keyboard and mouse

Re: [PATCH v2 29/54] pckbd: more vmstate_register() from i8042_mm_init() to i8042_mmio_realize()

2022-06-24 Thread Peter Maydell
On Fri, 24 Jun 2022 at 14:43, Mark Cave-Ayland wrote: > > Note in this case it is not possible to register a (new) VMStateDescription in > the DeviceClass without breaking migration compatibility for the MIPS magnum > machine. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell

Re: [PATCH v2 26/54] pckbd: implement i8042_mmio_init() function

2022-06-24 Thread Peter Maydell
On Fri, 24 Jun 2022 at 14:42, Mark Cave-Ayland wrote: > > This enables use to set the required value of extended_state directly during > device init rather than in i8042_mm_init(). > > Signed-off-by: Mark Cave-Ayland > Acked-by: Helge Deller > --- > hw/input/pckbd.c | 11 +-- > 1 file

[PULL v2 00/20] Block layer patches

2022-06-24 Thread Kevin Wolf
The following changes since commit 3a821c52e1a30ecd9a436f2c67cc66b5628c829f: Merge tag 'nvme-next-pull-request' of git://git.infradead.org/qemu-nvme into staging (2022-06-23 14:52:30 -0700) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[PULL v2 01/20] block: drop unused bdrv_co_drain() API

2022-06-24 Thread Kevin Wolf
From: Stefan Hajnoczi bdrv_co_drain() has not been used since commit 9a0cec664eef ("mirror: use bdrv_drained_begin/bdrv_drained_end") in 2016. Remove it so there are fewer drain scenarios to worry about. Use bdrv_drained_begin()/bdrv_drained_end() instead. They are "mixed" functions that can be

[PULL v2 02/20] block: get rid of blk->guest_block_size

2022-06-24 Thread Kevin Wolf
From: Stefan Hajnoczi Commit 1b7fd729559c ("block: rename buffer_alignment to guest_block_size") noted: At this point, the field is set by the device emulation, but completely ignored by the block layer. The last time the value of buffer_alignment/guest_block_size was actually used was

[PULL v2 12/20] vduse-blk: Add vduse-blk resize support

2022-06-24 Thread Kevin Wolf
From: Xie Yongji To support block resize, this uses vduse_dev_update_config() to update the capacity field in configuration space and inject config interrupt on the block resize callback. Signed-off-by: Xie Yongji Reviewed-by: Stefan Hajnoczi Message-Id:

[PULL v2 11/20] vduse-blk: Implement vduse-blk export

2022-06-24 Thread Kevin Wolf
From: Xie Yongji This implements a VDUSE block backends based on the libvduse library. We can use it to export the BDSs for both VM and container (host) usage. The new command-line syntax is: $ qemu-storage-daemon \ --blockdev file,node-name=drive0,filename=test.img \ --export

[PULL v2 05/20] block: simplify handling of try to merge different sized bitmaps

2022-06-24 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy We have too much logic to simply check that bitmaps are of the same size. Let's just define that hbitmap_merge() and bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of same size, this simplifies things. Let's look through the callers: For

Re: [RFC v2] Adding block layer APIs resembling Linux ZoneBlockDevice ioctls.

2022-06-24 Thread Sam Li
Stefan Hajnoczi 于2022年6月24日周五 23:50写道: > > On Fri, Jun 24, 2022 at 11:14:32AM +0800, Sam Li wrote: > > Hi Stefan, > > > > Stefan Hajnoczi 于2022年6月20日周一 15:55写道: > > > > > > On Mon, Jun 20, 2022 at 11:36:11AM +0800, Sam Li wrote: > > > > > > Hi Sam, > > > Is this version 2 of "[RFC v1] Add

[PULL v2 18/20] nbd: Drop dead code spotted by Coverity

2022-06-24 Thread Kevin Wolf
From: Eric Blake CID 1488362 points out that the second 'rc >= 0' check is now dead code. Reported-by: Peter Maydell Fixes: 172f5f1a40(nbd: remove peppering of nbd_client_connected) Signed-off-by: Eric Blake Message-Id: <20220516210519.76135-1-ebl...@redhat.com> Reviewed-by: Peter Maydell

[PATCH v2 2/3] target/ppc: Improve Radix xlate level validation

2022-06-24 Thread Leandro Lupori
Check if the number and size of Radix levels are valid on POWER9/POWER10 CPUs, according to the supported Radix Tree Configurations described in their User Manuals. Signed-off-by: Leandro Lupori --- target/ppc/mmu-radix64.c | 51 +++- 1 file changed, 40

[PATCH v2 0/3] ppc: Check for bad Radix configs

2022-06-24 Thread Leandro Lupori
Changes from v1: - Use proper format defines in logs - Optimized ppc_radix64_is_valid_level() and added a comment with instructions on how to proceed when adding new Radix CPUs with different configurations - Moved calls to ppc_radix64_is_valid_level() outside of ppc_radix64_next_level().

[PATCH v2 1/3] ppc: Check partition and process table alignment

2022-06-24 Thread Leandro Lupori
Check if partition and process tables are properly aligned, in their size, according to PowerISA 3.1B, Book III 6.7.6 programming note. Hardware and KVM also raise an exception in these cases. Signed-off-by: Leandro Lupori --- hw/ppc/spapr.c | 5 + hw/ppc/spapr_hcall.c |

[PATCH v2 3/3] target/ppc: Check page dir/table base alignment

2022-06-24 Thread Leandro Lupori
Check if each page dir/table base address is properly aligned and log a guest error if not, as real hardware behave incorrectly in this case. Signed-off-by: Leandro Lupori --- target/ppc/mmu-radix64.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target/ppc/mmu-radix64.c

Re: [PULL 0/3] Linux user for 7.1 patches

2022-06-24 Thread Richard Henderson
) linux-user pull request 20220624 Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate. r~ Helge Deller (1): linux-user: Adjust child_tidptr on set_tid_address

Re: [PATCH v11 2/2] qtest/cxl: Add aarch64 virt test for CXL

2022-06-24 Thread Jonathan Cameron via
On Fri, 24 Jun 2022 17:12:25 +0100 Peter Maydell wrote: > On Thu, 16 Jun 2022 at 15:20, Jonathan Cameron > wrote: > > > > Add a single complex case for aarch64 virt machine. > > > > Signed-off-by: Jonathan Cameron > > --- > > tests/qtest/cxl-test.c | 48

Re: [PATCH v2 3/3] target/ppc: Check page dir/table base alignment

2022-06-24 Thread Richard Henderson
On 6/24/22 10:16, Leandro Lupori wrote: Check if each page dir/table base address is properly aligned and log a guest error if not, as real hardware behave incorrectly in this case. Signed-off-by: Leandro Lupori --- target/ppc/mmu-radix64.c | 15 +++ 1 file changed, 15

[PATCH v2 25/54] pckbd: implement i8042_mmio_realize() function

2022-06-24 Thread Mark Cave-Ayland
Move the initialisation of the register memory region to the I8042_MMIO device realize function and expose it using sysbus_init_mmio(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/pckbd.c | 14 +- include/hw/input/i8042.h

[PATCH v2 29/54] pckbd: more vmstate_register() from i8042_mm_init() to i8042_mmio_realize()

2022-06-24 Thread Mark Cave-Ayland
Note in this case it is not possible to register a (new) VMStateDescription in the DeviceClass without breaking migration compatibility for the MIPS magnum machine. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller --- hw/input/pckbd.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v2 21/54] pckbd: introduce new I8042_MMIO QOM type

2022-06-24 Thread Mark Cave-Ayland
Currently i8042_mm_init() creates a new KBDState directly which is used by the MIPS magnum machine. Introduce a new I8042_MMIO QOM type that will soon be used to allow the MIPS magnum machine to be wired up using standard qdev GPIOs. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller

[PATCH v2 45/54] lasips2: implement lasips2_realize()

2022-06-24 Thread Mark Cave-Ayland
Move ps2_kbd_init() and ps2_mouse_init() from lasips2_initfn() to lasips2_realize. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/lasips2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/input/lasips2.c

[PATCH v2 33/54] ps2: introduce ps2_lower_irq() instead of calling update_irq() directly

2022-06-24 Thread Mark Cave-Ayland
This consolidates the logic of lowering the PS2 IRQ into one single function. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/ps2.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index

[PATCH v2 30/54] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i8042_mmio_realize()

2022-06-24 Thread Mark Cave-Ayland
Move ps2_kbd_init() and ps2_mouse_init() from i8042_mm_init() to i8042_mmio_realize() to further reduce the initialisation logic done in i8042_mm_init(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/pckbd.c | 6 +++--- 1 file changed, 3

[PATCH v2 38/54] lasips2: QOMify LASIPS2State

2022-06-24 Thread Mark Cave-Ayland
Currently lasip2_init() creates a new LASIPS2State directly which is used by the HPPA machine. Introduce a new LASIPS2 QOM type that will soon be used to allow the HPPA machine to be wired up using standard qdev GPIOs. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter

[PATCH v8 4/4] module: Use bundle mechanism

2022-06-24 Thread Akihiko Odaki
Before this change, the directory of the executable was being added to resolve modules in the build tree. However, get_relocated_path() can now resolve them with the new bundle mechanism. Signed-off-by: Akihiko Odaki --- util/module.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] meson: Prefix each element of firmware path

2022-06-24 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- configure | 23 +++ meson.build | 10 -- meson_options.txt | 2 +- scripts/meson-buildoptions.py | 7 +-- scripts/meson-buildoptions.sh | 6 +++--- softmmu/datadir.c

[PULL v2 08/20] block/export: Abstract out the logic of virtio-blk I/O process

2022-06-24 Thread Kevin Wolf
From: Xie Yongji Abstract the common logic of virtio-blk I/O process to a function named virtio_blk_process_req(). It's needed for the following commit. Signed-off-by: Xie Yongji Message-Id: <20220523084611.91-4-xieyon...@bytedance.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf

[PULL v2 09/20] linux-headers: Add vduse.h

2022-06-24 Thread Kevin Wolf
From: Xie Yongji This adds vduse header to linux headers so that the relevant VDUSE API can be used in subsequent patches. Signed-off-by: Xie Yongji Reviewed-by: Stefan Hajnoczi Message-Id: <20220523084611.91-5-xieyon...@bytedance.com> Signed-off-by: Kevin Wolf ---

[PULL v2 17/20] aio_wait_kick: add missing memory barrier

2022-06-24 Thread Kevin Wolf
From: Emanuele Giuseppe Esposito It seems that aio_wait_kick always required a memory barrier or atomic operation in the caller, but nobody actually took care of doing it. Let's put the barrier in the function instead, and pair it with another one in AIO_WAIT_WHILE. Read aio_wait_kick() comment

[PULL v2 14/20] qsd: document vduse-blk exports

2022-06-24 Thread Kevin Wolf
From: Stefan Hajnoczi Document vduse-blk exports in qemu-storage-daemon --help and the qemu-storage-daemon(1) man page. Based-on: <20220523084611.91-1-xieyon...@bytedance.com> Cc: Xie Yongji Signed-off-by: Stefan Hajnoczi Message-Id: <20220525121947.859820-1-stefa...@redhat.com>

Re: [RFC v2] Adding block layer APIs resembling Linux ZoneBlockDevice ioctls.

2022-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2022 at 11:14:32AM +0800, Sam Li wrote: > Hi Stefan, > > Stefan Hajnoczi 于2022年6月20日周一 15:55写道: > > > > On Mon, Jun 20, 2022 at 11:36:11AM +0800, Sam Li wrote: > > > > Hi Sam, > > Is this version 2 of "[RFC v1] Add support for zoned device"? Please > > keep the email subject line

Re: [PATCH] meson: Prefix each element of firmware path

2022-06-24 Thread Paolo Bonzini
Queued, thanks! Paolo On 6/24/22 17:40, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- configure | 23 +++ meson.build | 10 -- meson_options.txt | 2 +- scripts/meson-buildoptions.py | 7 +--

Re: [PATCH 2/2] target/arm: Check V7VE as well as LPAE in arm_pamax

2022-06-24 Thread Peter Maydell
On Sun, 19 Jun 2022 at 01:18, Richard Henderson wrote: > > In machvirt_init we create a cpu but do not fully initialize it. > Thus the propagation of V7VE to LPAE has not been done, and we > compute the wrong value for some v7 cpus, e.g. cortex-a15. > > Resolves:

Re: [PATCH v6 0/7] cutils: Introduce bundle mechanism

2022-06-24 Thread Akihiko Odaki
On 2022/06/16 18:18, Paolo Bonzini wrote: +def destdir_join(d1: str, d2: str) -> str: +    if not d1: +    return d2 +    if not os.path.isabs(d2): +    return os.path.join(d1, d2) + +    # c:\destdir + c:\prefix must produce c:\destdir\prefix +    if len(d2) > 1 and d2[1] == ':': +  

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-24 Thread Emanuele Giuseppe Esposito
Am 24/06/2022 um 17:28 schrieb Paolo Bonzini: > On 6/24/22 16:29, Kevin Wolf wrote: >> Yes, I think Vladimir is having the same difficulties with reading the >> series as I had. And I believe his suggestion would make the >> intermediate states less impossible to review. The question is how

[PATCH RESEND v2 1/2] target/ppc: Move tlbie[l] to decode tree

2022-06-24 Thread Leandro Lupori
Also decode RIC, PRS and R operands. Signed-off-by: Leandro Lupori --- target/ppc/cpu_init.c| 4 +- target/ppc/insn32.decode | 8 ++ target/ppc/translate.c | 64 +- target/ppc/translate/storage-ctrl-impl.c.inc | 87

[PATCH v2 18/54] pckbd: checkpatch fixes

2022-06-24 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Acked-by: Helge Deller --- hw/input/pckbd.c | 150 ++- 1 file changed, 97 insertions(+), 53 deletions(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index

[PATCH v2 23/54] pckbd: add mask qdev property to I8042_MMIO device

2022-06-24 Thread Mark Cave-Ayland
This allows the KBDState mask value to be set using a qdev property rather than directly in i8042_mm_init(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/pckbd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v2 51/54] pckbd: add i8042_reset() function to I8042 device

2022-06-24 Thread Mark Cave-Ayland
This means that it is no longer necessary to call qemu_register_reset() manually within i8042_realizefn(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell --- hw/input/pckbd.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH v2 49/54] pckbd: switch I8042_MMIO device from update_irq() function to PS2 device gpio

2022-06-24 Thread Mark Cave-Ayland
Define a new qdev input gpio for handling incoming PS2 IRQs, and then wire up the PS2 keyboard and mouse devices to use it. At the same time set update_irq() and update_arg to NULL in ps2_kbd_init() and ps2_mouse_init() to ensure that any accidental attempt to use the legacy update_irq() function

[PATCH v8 1/4] tests/vm: do not specify -bios option

2022-06-24 Thread Akihiko Odaki
From: Paolo Bonzini When running from the build tree, the executable is able to find the BIOS on its own; when running from the source tree, a firmware blob should already be installed and there is no guarantee that the one in the source tree works with the QEMU that is being used for the

Re: [PATCH 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-24 Thread Jonathan Cameron via
On Thu, 23 Jun 2022 16:56:58 +0200 Brice Goglin wrote: > Brice Goglin (4): >hmat acpi: Don't require initiator value in -numa >tests: acpi: add and whitelist *.hmat-noinitiator expected blobs >tests: acpi: q35: add test for hmat nodes without initiators >tests: acpi: q35: update

Re: [PATCH v2 48/54] lasips2: add QEMU interface comment

2022-06-24 Thread Peter Maydell
On Fri, 24 Jun 2022 at 14:44, Mark Cave-Ayland wrote: > > This describes the LASI PS2 device interface implemented within QEMU. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell thanks -- PMM

[PATCH] This fixes a bug in POSIX-compliant environments. Since we had allocated a buffer named 'tcg-jit' with read-write access protections we need a int type to combine these access flags and return

2022-06-24 Thread Shaobo Song
Signed-off-by: Shaobo Song --- tcg/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/region.c b/tcg/region.c index 71ea81d671..88d6bb273f 100644 --- a/tcg/region.c +++ b/tcg/region.c @@ -548,7 +548,7 @@ static int alloc_code_gen_buffer_anon(size_t size, int prot,

Re: [PATCH v8 2/4] cutils: Introduce bundle mechanism

2022-06-24 Thread Thomas Huth
On 24/06/2022 16.50, Akihiko Odaki wrote: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files in the installation tree. The build tree will

Re: [PATCH v8 0/4] cutils: Introduce bundle mechanism

2022-06-24 Thread Paolo Bonzini
On 6/24/22 16:50, Akihiko Odaki wrote: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The

[PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()

2022-06-24 Thread Shaobo Song
This fixes a bug in POSIX-compliant environments. Since we had allocated a buffer named 'tcg-jit' with read-write access protections we need a int type to combine these access flags and return it, whereas we had inexplicably return a bool type. It may cause an unnecessary protection change

Re: [PATCH qemu v2] ppc: Define SETFIELD for the ppc target

2022-06-24 Thread Daniel Henrique Barboza
Alexey, Gitlab does not like what you're doing here. Several cross compile runners fails with errors like these (this is from cross-win64-system): ../hw/intc/pnv_xive.c: In function 'pnv_xive_block_id': 3328/builds/danielhb/qemu/target/ppc/cpu.h:45:33: error: overflow in conversion from 'long

Re: [PULL 00/14] (Mostly) build system changes for 2022-06-24

2022-06-24 Thread Richard Henderson
On 6/24/22 01:27, Paolo Bonzini wrote: The following changes since commit 2b049d2c8dc01de750410f8f1a4eac498c04c723: Merge tag 'pull-aspeed-20220622' of https://github.com/legoater/qemu into staging (2022-06-22 07:27:06 -0700) are available in the Git repository at:

Re: [PATCH v3 2/2] docs/system/devices/canokey: Document limitations on usb-ehci

2022-06-24 Thread Hongren Zheng
On Fri, Jun 24, 2022 at 11:29:40PM +0800, MkfsSion wrote: > > -Another limitation is that this device is not compatible with ``qemu-xhci``, > -in that this device would hang when there are FIDO2 packets (traffic on > -interrupt endpoints). If you do not use FIDO2 then it works as intended, >

Re: [PATCH 12/14] aspeed: Make aspeed_board_init_flashes public

2022-06-24 Thread Cédric Le Goater
On 6/23/22 20:43, Peter Delevoryas wrote: On Jun 23, 2022, at 8:09 AM, Cédric Le Goater wrote: On 6/23/22 12:26, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Let's start simple without flash support. We should be able to load FW blobs in each CPU address space using loader

[PATCH v9 4/4] module: Use bundle mechanism

2022-06-24 Thread Akihiko Odaki
Before this change, the directory of the executable was being added to resolve modules in the build tree. However, get_relocated_path() can now resolve them with the new bundle mechanism. Signed-off-by: Akihiko Odaki --- util/module.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v4] hw: m25p80: add tests for write protect (WP# and SRWD bit)

2022-06-24 Thread Iris Chen
Signed-off-by: Iris Chen --- Adding Signed Off By tag -- sorry I missed that ! tests/qtest/aspeed_smc-test.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c index ec233315e6..7786addfb8 100644

Re: [PATCH v2 1/3] ppc: Check partition and process table alignment

2022-06-24 Thread Fabiano Rosas
Leandro Lupori writes: > Check if partition and process tables are properly aligned, in > their size, according to PowerISA 3.1B, Book III 6.7.6 programming > note. Hardware and KVM also raise an exception in these cases. > > Signed-off-by: Leandro Lupori Reviewed-by: Fabiano Rosas

[PATCH v2 12/54] ps2: don't use vmstate_register() in ps2_kbd_init()

2022-06-24 Thread Mark Cave-Ayland
Since PS2_KBD_DEVICE is a qdev device then vmstate_ps2_keyboard can be registered using the DeviceClass vmsd field instead. There is no need to use qdev_set_legacy_instance_id() to ensure migration compatibility since the first 2 parameters to vmstate_register() are NULL and 0 respectively.

[PATCH v2 17/54] lasips2: rename ps2dev_update_irq() to lasips2_port_set_irq()

2022-06-24 Thread Mark Cave-Ayland
This better reflects that the IRQ input opaque is a LASIPS2Port structure and not a PS2_DEVICE. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Acked-by: Helge Deller --- hw/input/lasips2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 19/54] pckbd: move KBDState from pckbd.c to i8042.h

2022-06-24 Thread Mark Cave-Ayland
This allows the QOM types in pckbd.c to be used elsewhere by simply including i8042.h. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Acked-by: Helge Deller --- hw/input/pckbd.c | 24 include/hw/input/i8042.h | 25 +

[PATCH v2 26/54] pckbd: implement i8042_mmio_init() function

2022-06-24 Thread Mark Cave-Ayland
This enables use to set the required value of extended_state directly during device init rather than in i8042_mm_init(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller --- hw/input/pckbd.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/input/pckbd.c

[PATCH v2 46/54] lasips2: use sysbus IRQ for output IRQ

2022-06-24 Thread Mark Cave-Ayland
This enables the IRQ to be wired up using sysbus_connect_irq() in lasips2_initfn(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller --- hw/input/lasips2.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c index

Re: [PATCH v11 1/2] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2022-06-24 Thread Jonathan Cameron via
On Fri, 24 Jun 2022 13:56:32 +0100 Peter Maydell wrote: > On Fri, 24 Jun 2022 at 13:39, Jonathan Cameron > wrote: > > > > On Fri, 24 Jun 2022 11:48:47 +0100 > > Peter Maydell wrote: > > > > > > This seems to be missing code to advertise the new devices in the > > > device tree. > > > >

Re: [PATCH v2 44/54] lasips2: add base property

2022-06-24 Thread Peter Maydell
On Fri, 24 Jun 2022 at 14:43, Mark Cave-Ayland wrote: > > This is in preparation for handling vmstate_register() within the device. > > Signed-off-by: Mark Cave-Ayland > Acked-by: Helge Deller > --- > hw/input/lasips2.c | 17 - > include/hw/input/lasips2.h | 1 + > 2

[PATCH v3 2/2] docs/system/devices/canokey: Document limitations on usb-ehci

2022-06-24 Thread MkfsSion
Suggested-by: Hongren (Zenithal) Zheng Signed-off-by: YuanYang Meng --- docs/system/devices/canokey.rst | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.rst index 169f99b8eb..650702ad8a 100644 ---

[PULL v2 03/20] block: block_dirty_bitmap_merge(): fix error path

2022-06-24 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy At the end we ignore failure of bdrv_merge_dirty_bitmap() and report success. And still set errp. That's wrong. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin Reviewed-by: Kevin Wolf Message-Id:

[PULL v2 07/20] block/export: Fix incorrect length passed to vu_queue_push()

2022-06-24 Thread Kevin Wolf
From: Xie Yongji Now the req->size is set to the correct value only when handling VIRTIO_BLK_T_GET_ID request. This patch fixes it. Signed-off-by: Xie Yongji Message-Id: <20220523084611.91-3-xieyon...@bytedance.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf ---

[PULL v2 13/20] libvduse: Add support for reconnecting

2022-06-24 Thread Kevin Wolf
From: Xie Yongji To support reconnecting after restart or crash, VDUSE backend might need to resubmit inflight I/Os. This stores the metadata such as the index of inflight I/O's descriptors to a shm file so that VDUSE backend can restore them during reconnecting. Signed-off-by: Xie Yongji

  1   2   3   4   >