Re: stable-8.0.1 re-tagging?

2023-05-30 Thread Thomas Huth
On 30/05/2023 10.15, Michael Tokarev wrote: Hi! Yesterday I pushed v8.0.1 tag for 8.0.1 stable qemu release, but in the process of publishing it, Michael Roth discovered a regression in iotest which we all overlooked when initial patch has been applied to master. The commit in question is this

Re: [PATCH 02/30] q800: introduce Q800MachineState

2023-05-30 Thread Laurent Vivier
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit : This provides an overall container and owner for Machine-related objects such as MemoryRegions. Signed-off-by: Mark Cave-Ayland --- MAINTAINERS| 1 + hw/m68k/q800.c | 2 ++ include/hw/m68k/q800.h | 37

Re: [PATCH 03/30] q800: rename q800_init() to q800_machine_init()

2023-05-30 Thread Laurent Vivier
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit : This will enable us later to distinguish between QOM initialisation and machine initialisation. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/m68k/q800.c

[PATCH 04/10] hw/ppc/spapr: Use memory_devices_init()

2023-05-30 Thread David Hildenbrand
Let's use our new helper and stop always allocating ms->device_memory. There is no difference in common memory-device code anymore between ms->device_memory being NULL or the size being 0. So we only have to teach spapr code that ms->device_memory isn't always around. We can now modify two

Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Paolo Bonzini
On Tue, May 30, 2023 at 1:58 PM Thomas Huth wrote: > The commit cc84d63a42e31c2a that introduce this switch gave a > rationale: > > Some users can't run a bare 'git' command, due to need for a transparent > proxying solution such as 'tsocks'. This adds an argument to configure to >

Re: [PATCH 0/3] arm/Kconfig: Some convenience changes

2023-05-30 Thread Peter Maydell
On Tue, 23 May 2023 at 19:05, Fabiano Rosas wrote: > > Hi, > > These are some changes that people asked for/suggested during the > review of previous Kconfig series that I haven't had an opportunity to > prepare until now. > > CI run: https://gitlab.com/farosas/qemu/-/pipelines/876384304 > >

Re: [PATCH 03/10] hw/arm/virt: Use memory_devices_init()

2023-05-30 Thread Philippe Mathieu-Daudé
On 30/5/23 13:38, David Hildenbrand wrote: Let's use our new helper. We'll add the subregion to system RAM now earlier. That shouldn't matter, because the system RAM memory region should already be alive at that point. Cc: Peter Maydell Signed-off-by: David Hildenbrand --- hw/arm/virt.c | 9

Re: [PATCH 02/10] memory-device: Introduce memory_devices_init()

2023-05-30 Thread Philippe Mathieu-Daudé
On 30/5/23 13:38, David Hildenbrand wrote: Let's intrduce a new helper that we will use to replace existing memory device setup code during machine initialization. We'll enforce that the size has to be > 0. Once all machines were converted, we'll only allocate ms->device_memory if the size > 0.

Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Daniel P . Berrangé
On Sat, May 27, 2023 at 11:28:47AM +0200, Paolo Bonzini wrote: > There is not really any scenario where one would use any other git > binary than "the first git in the PATH" aka $(command -v git). In > fact for example "meson subprojects download" or scripts/checkpatch.pl > do not obey the GIT

[PATCH 06/16] qemu_file: Use a stat64 for qemu_file_transferred

2023-05-30 Thread Juan Quintela
This way we can read it from any thread. I checked that it gives the same value than the current one. We never use to qemu_files at the same time. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/qemu-file.c | 5 +++-- 2 files changed, 7 insertions(+), 2

[PATCH 00/16] Next round of migration atomic counters

2023-05-30 Thread Juan Quintela
. Based-on: Message-Id: <20230530115429.1998-1-quint...@redhat.com> Subject: [PULL 00/21] Migration 20230530 patches Juan Quintela (16): qemu-file: Rename qemu_file_transferred_ fast -> noflush migration: Change qemu_file_transferred to noflush migration: Use qemu_file_transferre

[PATCH 08/16] migration: Use the number of transferred bytes directly

2023-05-30 Thread Juan Quintela
We only use migration_transferred_bytes() to calculate the rate_limit, for that we don't need to flush whatever is on the qemu_file buffer. Remember that the buffer is really small (normal case is 32K if we use iov's can be 64 * TARGET_PAGE_SIZE), so this is not relevant to calculations.

[PATCH 14/16] migration: Use migration_transferred_bytes()

2023-05-30 Thread Juan Quintela
There are only two differnces with the old value: - the amount of QEMUFile that hasn't yet been flushed. It can be discussed what is more exact, the new or the old one. - the amount of transferred bytes that we forgot to account for (the newer is better, i.e. exact). Notice that this two

[PATCH 03/16] migration: Use qemu_file_transferred_noflush() for block migration.

2023-05-30 Thread Juan Quintela
We only care about the amount of bytes transferred. Flushing is done by the system somewhere else. Signed-off-by: Juan Quintela --- migration/block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index b9580a6c7e..b29e80bdc4

Re: [PATCH 01/16] qemu-file: Rename qemu_file_transferred_ fast -> noflush

2023-05-30 Thread Philippe Mathieu-Daudé
On 30/5/23 14:36, Philippe Mathieu-Daudé wrote: On 30/5/23 14:27, Juan Quintela wrote: Fast don't say much.  Noflush indicates more clearly that it is like qemu_file_transferred but without the flush. Signed-off-by: Juan Quintela ---   migration/qemu-file.h | 11 +--  

Re: [PATCH 3/5] meson: subprojects: replace submodules with wrap files

2023-05-30 Thread Paolo Bonzini
On Tue, May 30, 2023 at 2:24 PM Daniel P. Berrangé wrote: > > +if test -e "$source_path/.git"; then > > +echo "--disable-download specified but subprojects were not" > > +echo "checked out. Please download subprojects." > > Building from tarball will be ok as we bundle

Re: [PATCH v2 02/20] target/arm: Add feature test for FEAT_LSE2

2023-05-30 Thread Philippe Mathieu-Daudé
On 26/5/23 01:25, Richard Henderson wrote: Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH] hw/loongarch: Supplement cpu topology arguments

2023-05-30 Thread Tianrui Zhao
Supplement LoongArch cpu topology arguments, including support socket and threads per core. Based-on: <20230518014115.117869-1-gaos...@loongson.cn> Signed-off-by: Tianrui Zhao --- hw/loongarch/acpi-build.c | 4 hw/loongarch/virt.c | 9 - 2 files changed, 12 insertions(+), 1

Re: [PATCH v2 11/20] target/arm: Hoist finalize_memop out of do_fp_{ld, st}

2023-05-30 Thread Philippe Mathieu-Daudé
On 26/5/23 01:25, Richard Henderson wrote: We are going to need the complete memop beforehand, so let's not compute it twice. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 43 ++ 1 file changed, 23

Re: [PATCH v3 04/14] nbd: Prepare for 64-bit request effect lengths

2023-05-30 Thread Vladimir Sementsov-Ogievskiy
On 15.05.23 22:53, Eric Blake wrote: Widen the length field of NBDRequest to 64-bits, although we can assert that all current uses are still under 32 bits. Move the request magic number to nbd.h, to live alongside the reply magic number. Convert 'bool structured_reply' into a tri-state enum

Re: [PATCH v5 6/9] migration: modified migration QAPIs to accept 'channels' argument for migration

2023-05-30 Thread Markus Armbruster
Het Gala writes: > On 30/05/23 12:43 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> On 25/05/23 11:20 pm, Markus Armbruster wrote: Het Gala writes: > MigrateChannelList allows to connect accross multiple interfaces. Added > MigrateChannelList struct as argument to

Re: stable-8.0: block/export: call blk_set_dev_ops and Fix null pointer dereference in error path

2023-05-30 Thread Kevin Wolf
Am 29.05.2023 um 23:24 hat Michael Tokarev geschrieben: > Hi! > > For some reason I picked up this commit: > > commit de79b52604e43fdeba6cee4f5af600b62169f2d2 > Author: Stefan Hajnoczi > Date: Tue May 2 17:11:19 2023 -0400 > > block/export: call blk_set_dev_ops(blk, NULL, NULL) > > for

Re: [PATCH v4 9/9] vfio/migration: Add support for switchover ack capability

2023-05-30 Thread Cédric Le Goater
On 5/28/23 16:06, Avihai Horon wrote: Loading of a VFIO device's data can take a substantial amount of time as the device may need to allocate resources, prepare internal data structures, etc. This can increase migration downtime, especially for VFIO devices with a lot of resources. To solve

[PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI

2023-05-30 Thread Thomas Huth
The PowerMacs have an OHCI controller soldered on the motherboard, so this should always be enabled for the "mac99" machine. This fixes the problem that QEMU aborts when the user tries to run the "mac99" machine with a build that has been compiled with the "--without-default-devices" configure

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 02:26:23PM +0530, Het Gala wrote: > > On 30/05/23 1:26 pm, Markus Armbruster wrote: > > Het Gala writes: > > > > > On 30/05/23 12:28 pm, Markus Armbruster wrote: > > > > Het Gala writes: > > > > > > > > > On 25/05/23 11:04 pm, Markus Armbruster wrote: > > [...] > > >

Re: [PATCH v4 9/9] vfio/migration: Add support for switchover ack capability

2023-05-30 Thread Avihai Horon
On 30/05/2023 12:58, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 5/28/23 16:06, Avihai Horon wrote: Loading of a VFIO device's data can take a substantial amount of time as the device may need to allocate resources, prepare internal data structures,

Re: [PATCH 06/30] q800: move GLUE device to Q800MachineState

2023-05-30 Thread Laurent Vivier
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit : Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 20 ++-- include/hw/m68k/q800.h | 1 + 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index

Re: [PATCH 05/30] q800: move ROM memory region to Q800MachineState

2023-05-30 Thread Laurent Vivier
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit : Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 13 + include/hw/m68k/q800.h | 1 + 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index ee6175ceb4..6a000ceb75 100644

Re: [PATCH 17/30] q800: add easc bool machine class property to switch between ASC and EASC

2023-05-30 Thread Laurent Vivier
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit : This determines whether the Apple Sound Chip (ASC) is set to enhanced mode (default) or to original mode. The real Q800 hardware used an EASC chip however a lot of older software only works with the older ASC chip. Adding this as a machine

Re: [PATCH 18/30] swim: add trace events for IWM and ISM registers

2023-05-30 Thread Laurent Vivier
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit : Signed-off-by: Mark Cave-Ayland --- hw/block/swim.c | 14 ++ hw/block/trace-events | 7 +++ 2 files changed, 21 insertions(+) diff --git a/hw/block/swim.c b/hw/block/swim.c index 333da08ce0..7df36ea139 100644 ---

Re: [PATCH 00/10] memory-device: Some cleanups

2023-05-30 Thread David Hildenbrand
This was supposed to carry the "v2" indicator ;) On 30.05.23 13:38, David Hildenbrand wrote: Working on adding multi-memslot support for virtio-mem (teaching memory device code about memory devices that can consume multiple memslots), I have some preparatory cleanups in my queue that make

[PATCH 05/10] hw/loongarch/virt: Use memory_devices_init()

2023-05-30 Thread David Hildenbrand
Let's use our new helper. Cc: Xiaojuan Yang Cc: Song Gao Signed-off-by: David Hildenbrand --- hw/loongarch/virt.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index ceddec1b23..a6790714fe 100644 ---

[PATCH 07/10] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT

2023-05-30 Thread David Hildenbrand
We're already looking at machine->device_memory when calling build_srat_memory(), so let's simply avoid going via PC_MACHINE_DEVMEM_REGION_SIZE to get the size and rely on machine->device_memory directly. Once machine->device_memory is set, we know that the size > 0. The code now looks much more

[PATCH 09/10] memory-device: Refactor memory_device_pre_plug()

2023-05-30 Thread David Hildenbrand
Let's move memory_device_check_addable() and basic checks out of memory_device_get_free_addr() directly into memory_device_pre_plug(). Separating basic checks from address assignment is cleaner and prepares for further changes. As all memory device users now use memory_devices_init(), and that

[PULL 11/21] migration/rdma: Simplify the function that saves a page

2023-05-30 Thread Juan Quintela
When we sent a page through QEMUFile hooks (RDMA) there are three posiblities: - We are not using RDMA. return RAM_SAVE_CONTROL_DELAYED and control_save_page() returns false to let anything else to proceed. - There is one error but we are using RDMA. Then we return a negative value,

Re: [PATCH v1 1/2] hw/loongarch/virt: Add cpu arch_id support

2023-05-30 Thread Tianrui Zhao
在 2023年05月18日 09:41, Song Gao 写道: With acpi madt table, there is cpu physical coreid, which may be different with logical id in qemu. This patch adds cpu arch_id support, and fill madt table with arch_id. For the present cpu arch_id is still equal to logical id. Signed-off-by: Song Gao ---

[PULL 00/21] Migration 20230530 patches

2023-05-30 Thread Juan Quintela
The following changes since commit aa9bbd865502ed517624ab6fe7d4b5d89ca95e43: Merge tag 'pull-ppc-20230528' of https://gitlab.com/danielhb/qemu into staging (2023-05-29 14:31:52 -0700) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20230530

[PULL 21/21] migration/rdma: Check sooner if we are in postcopy for save_page()

2023-05-30 Thread Juan Quintela
Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-Id: <20230509120700.78359-11-quint...@redhat.com> --- migration/rdma.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index cf0681575d..f912a31b45 100644 ---

[PULL 17/21] migration/rdma: Create rdma_control_save_page()

2023-05-30 Thread Juan Quintela
The only user of ram_control_save_page() and save_page() hook was rdma. Just move the function to rdma.c, rename it to rdma_control_save_page(). Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-Id: <20230509120700.78359-7-quint...@redhat.com> --- migration/qemu-file.h | 12

[PULL 01/21] runstate: add runstate_get()

2023-05-30 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy It's necessary to restore the state after failed/cancelled migration in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Message-Id: <20230517123752.21615-2-vsement...@yandex-team.ru> Signed-off-by: Juan Quintela ---

[PULL 15/21] migration/rdma: Remove all uses of RAM_CONTROL_HOOK

2023-05-30 Thread Juan Quintela
Instead of going trhough ram_control_load_hook(), call qemu_rdma_registration_handle() directly. Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-Id: <20230509120700.78359-5-quint...@redhat.com> --- migration/qemu-file.h | 1 - migration/rdma.h | 2 ++ migration/ram.c | 5

Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Thomas Huth
On 27/05/2023 11.28, Paolo Bonzini wrote: There is not really any scenario where one would use any other git binary than "the first git in the PATH" aka $(command -v git). In fact for example "meson subprojects download" or scripts/checkpatch.pl do not obey the GIT environment variable. Remove

Re: [PATCH] Update copyright dates to 2023

2023-05-30 Thread Peter Maydell
On Thu, 25 May 2023 at 10:24, Peter Maydell wrote: > > On Thu, 25 May 2023 at 07:45, Enze Li wrote: > > > > I noticed that in the latest version, the copyright string is still > > 2022, even though 2023 is halfway through. This patch fixes that and > > fixes the documentation along with it. > >

Re: [PATCH 0/5] meson: replace submodules with wrap files

2023-05-30 Thread Thomas Huth
On 27/05/2023 11.28, Paolo Bonzini wrote: This series replaces git submodules for bundled libraries with .wrap files that can be used directly by meson for subprojects. ... The remaining submodules consist of tests/lcitool/libvirt-ci and the firmware in roms/. We talked about moving the

Re: [PATCH 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE

2023-05-30 Thread Philippe Mathieu-Daudé
On 30/5/23 13:38, David Hildenbrand wrote: There are no remaining users in the tree, so let's remove it. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 19

Re: [PATCH 07/10] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT

2023-05-30 Thread Philippe Mathieu-Daudé
On 30/5/23 13:38, David Hildenbrand wrote: We're already looking at machine->device_memory when calling build_srat_memory(), so let's simply avoid going via PC_MACHINE_DEVMEM_REGION_SIZE to get the size and rely on machine->device_memory directly. Once machine->device_memory is set, we know

Re: [PATCH 05/10] hw/loongarch/virt: Use memory_devices_init()

2023-05-30 Thread Philippe Mathieu-Daudé
On 30/5/23 13:38, David Hildenbrand wrote: Let's use our new helper. Cc: Xiaojuan Yang Cc: Song Gao Signed-off-by: David Hildenbrand --- hw/loongarch/virt.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 12/16] migration: migration_rate_limit_reset() don't need the QEMUFile

2023-05-30 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 2 +- migration/migration.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration-stats.h index e3863bf9bb..68f3939188

[PATCH 11/16] migration: migration_transferred_bytes() don't need the QEMUFile

2023-05-30 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 6 +++--- migration/migration.c | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration-stats.h index

[PATCH 10/16] qemu-file: Remove _noflush from qemu_file_transferred_noflush()

2023-05-30 Thread Juan Quintela
qemu_file_transferred() don't exist anymore, so we can reuse the name. Signed-off-by: Juan Quintela --- migration/qemu-file.h | 4 ++-- migration/block.c | 4 ++-- migration/qemu-file.c | 2 +- migration/savevm.c| 6 +++--- migration/vmstate.c | 4 ++-- 5 files changed, 10

[PATCH 13/16] qemu-file: Simplify qemu_file_get_error()

2023-05-30 Thread Juan Quintela
If we pass a NULL error is the same that returning dirrectly the value. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index a3d0412b5f..7cf457a981 100644 ---

[PATCH 05/16] qemu-file: We only call qemu_file_transferred_* on the sending side

2023-05-30 Thread Juan Quintela
Remove the increase in qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index

Re: [PATCH v2 03/20] target/arm: Introduce finalize_memop_{atom, pair}

2023-05-30 Thread Philippe Mathieu-Daudé
On 26/5/23 01:25, Richard Henderson wrote: Let finalize_memop_atom be the new basic function, with finalize_memop and finalize_memop_pair testing FEAT_LSE2 to apply the appropriate atomicity. Signed-off-by: Richard Henderson --- target/arm/tcg/translate.h | 39

Re: [PATCH 0/5] meson: replace submodules with wrap files

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 02:18:30PM +0200, Thomas Huth wrote: > On 27/05/2023 11.28, Paolo Bonzini wrote: > > This series replaces git submodules for bundled libraries with .wrap > > files that can be used directly by meson for subprojects. > ... > > The remaining submodules consist of

[PATCH v1] target/ppc: Support directed privileged doorbell interrupt (SDOOR)

2023-05-30 Thread Nicholas Piggin
BookS msgsndp instruction to self or DPDES register can cause SDOOR interrupts which crash QEMU with exception not implemented. Linux does not use msgsndp in SMT1, and KVM only uses DPDES to cause doorbells when emulating a SMT guest (which is not the default), so this has gone unnoticed.

[PATCH v4] target/ppc: Fix PMU hflags calculation

2023-05-30 Thread Nicholas Piggin
Some of the PMU hflags bits can go out of synch, for example a store to MMCR0 with PMCjCE=1 fails to update hflags correctly and results in hflags mismatch: qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a003d) This can be reproduced by running perf on a recent machine.

Re: [PATCH 02/10] memory-device: Introduce memory_devices_init()

2023-05-30 Thread David Hildenbrand
On 30.05.23 14:29, Philippe Mathieu-Daudé wrote: Hi David, On 30/5/23 13:38, David Hildenbrand wrote: Let's intrduce a new helper that we will use to replace existing memory device setup code during machine initialization. We'll enforce that the size has to be > 0. Once all machines were

[PATCH v1 1/2] target/ppc: Fix decrementer time underflow and infinite timer loop

2023-05-30 Thread Nicholas Piggin
It is possible to store a very large value to the decrementer that it does not raise the decrementer exception so the timer is scheduled, but the next time value wraps and is treated as in the past. This can occur if (u64)-1 is stored on a zero-triggered exception, or (u64)-1 is stored twice on

[PATCH v1 2/2] target/ppc: Decrementer fix BookE semantics

2023-05-30 Thread Nicholas Piggin
The decrementer store function has logic that short-cuts the timer if a very small value is stored (0, 1, or 2) and raises an interrupt directly. There are two problem with this on BookE. First is that BookE says a decrementer interrupt should not be raised on a store of 0, only of a decrement

[PATCH v5 2/2] qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa

2023-05-30 Thread Stefano Garzarella
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the fd passing through the new 'fd' property. Since now we are using qemu_open() on '@path' if the virtio-blk driver supports the fd passing, let's announce it. In this way, the management layer can pass the file descriptor of an already

[PATCH v5 1/2] block/blkio: use qemu_open() to support fd passing for virtio-blk

2023-05-30 Thread Stefano Garzarella
Some virtio-blk drivers (e.g. virtio-blk-vhost-vdpa) supports the fd passing. Let's expose this to the user, so the management layer can pass the file descriptor of an already opened path. If the libblkio virtio-blk driver supports fd passing, let's always use qemu_open() to open the `path`, so

Re: [PATCH 0/2] Vhost-vdpa Shadow Virtqueue Offloads support

2023-05-30 Thread Hawkins Jiawei
On 2023/5/30 0:55, Eugenio Perez Martin wrote: > On Mon, May 29, 2023 at 3:18 PM Hawkins Jiawei wrote: >> >> This series enables shadowed CVQ to intercept Offloads commands >> through shadowed CVQ, update the virtio NIC device model so qemu >> send it in a migration, and the restore of that

[PATCH v5 0/2] block/blkio: support fd passing for virtio-blk-vhost-vdpa driver

2023-05-30 Thread Stefano Garzarella
v5: - moved `features` to the object level to simplify libvirt code [Jonathon] - wrapped a line too long in the documentation [Markus] - added Stefan R-b tags v4: https://lore.kernel.org/qemu-devel/20230526150304.158206-1-sgarz...@redhat.com/ - added patch 02 to allow libvirt to discover we

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Het Gala
On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:04 pm, Markus Armbruster wrote: Het Gala writes: This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri'

Re: [PATCH v3 1/2] exec/ram_addr: return nr of dirty pages in cpu_physical_memory_set_dirty_lebitmap()

2023-05-30 Thread Joao Martins
On 30/05/2023 09:37, Avihai Horon wrote: > > On 29/05/2023 15:11, Joao Martins wrote: >> External email: Use caution opening links or attachments >> > Nit, s/nr/number in the subject. > Fixed (this was instinctly just trying to fit 80 columns) >> In preparation for including the number of

Re: [PATCH v3 2/2] hw/vfio: Add nr of dirty pages to vfio_get_dirty_bitmap tracepoint

2023-05-30 Thread Joao Martins
On 30/05/2023 09:39, Avihai Horon wrote: > > On 29/05/2023 15:11, Joao Martins wrote: >> External email: Use caution opening links or attachments >> > Just a nit, maybe subject should be "vfio/common: Add number of dirty pages to > vfio_get_dirty_bitmap tracepoint". > Fixed >> Include the

Re: [PATCH v5 6/9] migration: modified migration QAPIs to accept 'channels' argument for migration

2023-05-30 Thread Markus Armbruster
Het Gala writes: > On 25/05/23 11:20 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> MigrateChannelList allows to connect accross multiple interfaces. Added >>> MigrateChannelList struct as argument to migration QAPIs. >>> >>> Future patchset series plans to include multiple

Re: [PATCH v2 0/5] gitlab: improvements to handling of stable staging branches

2023-05-30 Thread Michael Tokarev
26.05.2023 13:19, Daniel P. Berrangé wrote: We just (re)discovered that our gitlab rules don't work nicely with pipelines running from stable staging branches. Every pipeline gets published with the 'latest' tag, whether its the main staging branch or one of the stable staging branches. If

Re: [PATCH 09/30] q800: add djMEMC memory controller

2023-05-30 Thread Mark Cave-Ayland
On 25/05/2023 09:12, Philippe Mathieu-Daudé wrote: On 24/5/23 23:10, Mark Cave-Ayland wrote: The djMEMC controller is used to store information related to the physical memory configuration. Co-developed-by: Laurent Vivier Signed-off-by: Mark Cave-Ayland ---   MAINTAINERS  |   2

[PATCH v14 08/10] Adding info [tb-list|tb] commands to HMP (WIP)

2023-05-30 Thread Fei Wu
From: "Vanderson M. do Rosario" These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host instructions... and examine their guest, host and IR code. The goal of this command is to allow the dynamic exploration of TCG behavior and code

[PATCH v14 10/10] docs: add tb-stats how to

2023-05-30 Thread Fei Wu
Signed-off-by: Fei Wu --- docs/devel/tcg-tbstats.rst | 129 + 1 file changed, 129 insertions(+) create mode 100644 docs/devel/tcg-tbstats.rst diff --git a/docs/devel/tcg-tbstats.rst b/docs/devel/tcg-tbstats.rst new file mode 100644 index

[PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-05-30 Thread Fei Wu
This collects all the statistics for TBStatistics, not only for the whole emulation but for each TB. Signed-off-by: Vanderson M. do Rosario Signed-off-by: Alex Bennée Signed-off-by: Fei Wu --- accel/tcg/monitor.c | 20 - accel/tcg/tb-stats.c | 146

[PATCH v14 09/10] tb-stats: dump hot TBs at the end of the execution

2023-05-30 Thread Fei Wu
From: "Vanderson M. do Rosario" Dump the hottest TBs if -d tb_stats,dump_limit=N is used. Example of output for the 3 hottest TBs: TB id:1 | phys:0x34d54 virt:0x00034d54 flags:0xf0 | exec:4828932/0 guest inst cov:16.38% | trans:1 ints: g:3 op:82 op_opt:34 spills:3

[PATCH v14 07/10] tb-stats: reset the tracked TBs on a tb_flush

2023-05-30 Thread Fei Wu
From: Alex Bennée We keep track of translations but can only do so up until the translation cache is flushed. At that point we really have no idea if we can re-create a translation because all the active tracking information has been reset. Signed-off-by: Alex Bennée Reviewed-by: Richard

[PATCH v14 01/10] accel/tcg: remove CONFIG_PROFILER

2023-05-30 Thread Fei Wu
TBStats will be introduced to replace CONFIG_PROFILER totally, here remove all CONFIG_PROFILER related stuffs first. Signed-off-by: Vanderson M. do Rosario Signed-off-by: Alex Bennée Signed-off-by: Fei Wu Reviewed-by: Richard Henderson --- accel/tcg/monitor.c | 25

[PATCH v14 02/10] accel/tcg: introduce TBStatistics structure

2023-05-30 Thread Fei Wu
From: "Vanderson M. do Rosario" To store statistics for each TB, we created a TBStatistics structure which is linked with the TBs. TBStatistics can stay alive after tb_flush and be relinked to a regenerated TB. So the statistics can be accumulated even through flushes. The goal is to have all

[PATCH v14 06/10] monitor: adding tb_stats hmp command

2023-05-30 Thread Fei Wu
From: "Vanderson M. do Rosario" Adding tb_stats [start|pause|stop|filter] command to hmp. This allows controlling the collection of statistics. It is also possible to set the level of collection: all, jit, or exec. tb_stats filter allow to only collect statistics for the TB in the last_search

[PATCH v14 05/10] debug: add -d tb_stats to control TBStatistics collection:

2023-05-30 Thread Fei Wu
From: "Vanderson M. do Rosario" -d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=]] "dump_limit" is used to limit the number of dumped TBStats in linux-user mode. [all+jit+exec+time] control the profilling level used by the TBStats. Can be used as follow: -d tb_stats -d

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Het Gala
On 30/05/23 2:27 pm, Daniel P. Berrangé wrote: On Tue, May 30, 2023 at 01:02:27PM +0530, Het Gala wrote: On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:04 pm, Markus Armbruster wrote: Het Gala writes: This patch introduces well defined MigrateAddress

[PATCH v2 2/2] qtest/migration-tests.c: use "-incoming defer" for postcopy tests

2023-05-30 Thread Wei Wang
The Postcopy preempt capability requires to be set before incoming starts, so change the postcopy tests to start with deferred incoming and call migrate-incoming after the cap has been set. Signed-off-by: Wei Wang --- tests/qtest/migration-test.c | 10 -- 1 file changed, 8

[PATCH v2 0/2] Enfore multifd and postcopy preempt setting

2023-05-30 Thread Wei Wang
Setting the cap/params of multifd and postcopy preempt is expected to be done before incoming starts, as the number of multifd channels or postcopy ram channels is used by qemu_start_incoming_migration (to listen on the number of pending connections). Enfocre the cap/params of multifd and

RE: [PATCH v1] migration: fix migrate_params_test_apply to set the dest param correctly

2023-05-30 Thread Wang, Wei W
On Monday, May 29, 2023 10:58 PM, Peter Xu wrote: > > > > #1migrate_params_test_apply(params, ); > > > > #2 if (!migrate_params_check(, errp)) { > > /* Invalid parameter */ > > return; > > } > > #3 migrate_params_apply(params, errp); > > > > #2 tries to do params check

[PATCH v2 1/2] migration: enfocre multifd and postcopy preempt to be set before incoming

2023-05-30 Thread Wei Wang
qemu_start_incoming_migration needs to check the number of multifd channels or postcopy ram channels to configure the backlog parameter (i.e. the maximum length to which the queue of pending connections for sockfd may grow) of listen(). So enforce the usage of postcopy-preempt and multifd as

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Markus Armbruster
Het Gala writes: > On 25/05/23 11:04 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> This patch introduces well defined MigrateAddress struct and its related >>> child >>> objects. >>> >>> The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of >>> string type. The

Re: [PATCH v1 0/2] Add LoongArch cpu arch_id support

2023-05-30 Thread Song Gao
ping~ 在 2023/5/18 上午9:41, Song Gao 写道: 1 Add LoongArch cpu arch_id support; 2 Fill Acpi table with arch_id; 3 set physical cpuid route for LoongArch ipi device. Song Gao (2): hw/loongarch/virt: Add cpu arch_id support hw/intc: Set physical cpuid route for LoongArch ipi device

Re: [PATCH v13 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-05-30 Thread Wu, Fei
On 5/30/2023 1:01 PM, Wu, Fei wrote: > On 5/30/2023 12:07 PM, Richard Henderson wrote: >> On 5/29/23 04:49, Fei Wu wrote: >>> +/* >>> + * The TCGProfile structure holds data for analysing the quality of >>> + * the code generation. The data is split between stuff that is valid >>> + * for the

Re: [PATCH v3 2/2] hw/vfio: Add nr of dirty pages to vfio_get_dirty_bitmap tracepoint

2023-05-30 Thread Cédric Le Goater
On 5/29/23 14:11, Joao Martins wrote: Include the number of dirty pages on the vfio_get_dirty_bitmap tracepoint. These are fetched from the newly added return value in cpu_physical_memory_set_lebitmap(). Signed-off-by: Joao Martins Reviewed-by: Cédric Le Goater Thanks, C. ---

Re: [PATCH v5 6/9] migration: modified migration QAPIs to accept 'channels' argument for migration

2023-05-30 Thread Het Gala
On 30/05/23 12:43 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:20 pm, Markus Armbruster wrote: Het Gala writes: MigrateChannelList allows to connect accross multiple interfaces. Added MigrateChannelList struct as argument to migration QAPIs. Future patchset series plans

Re: stable-8.0.1 re-tagging?

2023-05-30 Thread Michael Tokarev
30.05.2023 11:28, Olaf Hering wrote: Tue, 30 May 2023 11:15:31 +0300 Michael Tokarev : I'm for creating new v8.0.1 tag for the new commit. But I'd like to hear opinions of others on this matter, since this is an important process which definitely should be public. The man page of git-tag is

[PATCH v14 00/10] TCG code quality tracking

2023-05-30 Thread Fei Wu
v14 --- * cleanup TCGProfile in patch 04 Alex Bennée (1): tb-stats: reset the tracked TBs on a tb_flush Fei Wu (3): accel/tcg: remove CONFIG_PROFILER accel/tcg: add jit stats and time to TBStatistics docs: add tb-stats how to Vanderson M. do Rosario (6): accel/tcg: introduce

[PATCH v14 03/10] accel: collecting TB execution count

2023-05-30 Thread Fei Wu
From: "Vanderson M. do Rosario" If a TB has a TBS (TBStatistics) with the TB_EXEC_STATS enabled, then we instrument the start code of this TB to atomically count the number of times it is executed. We count both the number of "normal" executions and atomic executions of a TB. The execution

Re: [PATCH v3 1/2] exec/ram_addr: return nr of dirty pages in cpu_physical_memory_set_dirty_lebitmap()

2023-05-30 Thread Avihai Horon
On 29/05/2023 15:11, Joao Martins wrote: External email: Use caution opening links or attachments Nit, s/nr/number in the subject. In preparation for including the number of dirty pages in the vfio_get_dirty_bitmap() tracepoint, return the number of dirty pages in

Re: [PATCH 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE

2023-05-30 Thread David Hildenbrand
On 30.05.23 15:07, Michael S. Tsirkin wrote: On Tue, May 30, 2023 at 01:38:36PM +0200, David Hildenbrand wrote: There are no remaining users in the tree, so let's remove it. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum

[PATCH 4/9] disas/riscv: Make rv_op_illegal a shared enum value

2023-05-30 Thread Christoph Muellner
From: Christoph Müllner The enum value 'rv_op_illegal' does not represent an instruction, but is a catch-all value in case we have no match in the decoder. Let's make the value a shared one, so that other compile units can reuse it. Signed-off-by: Christoph Müllner --- disas/riscv.c | 2 +-

[PATCH 1/9] target/riscv: Use xl instead of mxl for disassemble

2023-05-30 Thread Christoph Muellner
From: LIU Zhiwei Disassemble function(plugin_disas, target_disas, monitor_disas) will always call set_disas_info before disassembling instructions. plugin_disas and target_disas will always be called under a TB, which has the same XLEN. We can't ensure that monitor_disas will always be called

[PATCH 7/9] disas/riscv: Provide infrastructure for vendor extensions

2023-05-30 Thread Christoph Muellner
From: Christoph Müllner A previous patch provides a pointer to the RISCVCPUConfig data. Let's use this to add the necessary code for vendor extensions. This patch does not change the current behaviour, but clearly defines how vendor extension support can be added to the disassembler.

[PATCH 6/9] target/riscv/cpu: Share RISCVCPUConfig with disassembler

2023-05-30 Thread Christoph Muellner
From: Christoph Müllner The disassembler needs the available extensions in order to properly decode instructions in case of overlapping encodings (e.g. for vendor extensions). Let's use the field 'disassemble_info::private_data' to store our RISCVCPUConfig pointer. Signed-off-by: Christoph

Re: [PATCH] Prepare bcm properties for videocore 4

2023-05-30 Thread Peter Maydell
On Tue, 30 May 2023 at 14:00, Kambalin, Sergey wrote: > > Got it! Thanks! > > I'll split this one to three patches: > 1) replace magic numbers with named constants (refactoring) > > 2) add new properties for VC 4 > > 3) Add some unit tests to check the newly added properties via mailbox Are the

Re: [PATCH 02/10] memory-device: Introduce memory_devices_init()

2023-05-30 Thread David Hildenbrand
On 30.05.23 15:04, David Hildenbrand wrote: On 30.05.23 14:29, Philippe Mathieu-Daudé wrote: Hi David, On 30/5/23 13:38, David Hildenbrand wrote: Let's intrduce a new helper that we will use to replace existing memory device setup code during machine initialization. We'll enforce that the

[PATCH 4/7] target/ppc: Remove some unneded line breaks

2023-05-30 Thread BALATON Zoltan
Make lines shorter and fix indentation in some functions prototypes. Signed-off-by: BALATON Zoltan --- target/ppc/cpu.h| 8 +++- target/ppc/mmu_common.c | 8 +++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index

<    1   2   3   4   5   6   7   >