[PULL 34/47] accel: Make accel-blocker.o target agnostic

From: Philippe Mathieu-Daudé accel-blocker.c is not target specific, move it to system_ss[]. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20230914185718.76241-5-phi...@linaro.org> Signed-off-by: Richard Henderson --- accel/meson.build | 4 ++-- 1 file

[PULL 00/47] tcg patch queue

The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20231003 for you

[PATCH qemu 0/1] contrib/elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free

Switch malloc and free calls to new coding standard. g_new is used where structs are defined and g_malloc is used for simpler structures Suraj Shirvankar (1): Switch memory management calls to new coding conventions contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 4 ++--

[PATCH qemu 1/1] Switch memory management calls to new coding conventions

From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 4 ++-- contrib/elf2dmp/pdb.c | 4 ++-- contrib/elf2dmp/qemu_elf.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > Rename the version not burried in the macro to cap_h. > > Signed-off-by: Jonathan Cameron > --- > > I had another instance of this in a series I'll post later today. > Cleaned that up the same way. > >

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

On Fri, Sep 29, 2023 at 09:50:16AM +0200, Markus Armbruster wrote: > Jonathan Cameron writes: > > > On Wed, 27 Sep 2023 19:13:35 + > > Fan Ni wrote: > > > >> On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > >> > >> > Rename the version not burried in the macro to cap_h.

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

26.09.2023 15:05, Niklas Cassel: Hello Marcin, I will have a look at this. Hi Marcin, Hi Niklas! Niklas, I remember asking you if the whole thing is okay for the -stable, and you was a bit unsure about it :) Regardless, I picked the changes up for -stable. I don't think it was anyone's

Re: [PATCH v10 00/11] Add VIRTIO sound card

On Tue, Oct 03, 2023 at 07:09:14PM +0300, Manos Pitsidianakis wrote: > On Tue, 03 Oct 2023 17:10, "Michael S. Tsirkin" wrote: > > I hope you are also fixing the linux driver to fix this in a robust > > way, yes? > > Hello Michael, > > You can find pertinent discussion on the virtio-comment list

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

While I'm poking at IDE today ... any news here? On Tue, Sep 26, 2023, 12:35 PM John Snow wrote: > > > On Tue, Sep 26, 2023, 8:06 AM Niklas Cassel wrote: > >> Hello Marcin, >> >> I will have a look at this. >> >> >> Kind regards, >> Niklas >> > > Thanks. You have my blessing in advance to get

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

On Tue, Oct 3, 2023, 10:07 AM Niklas Cassel wrote: > On Mon, Sep 25, 2023 at 03:53:23PM -0400, John Snow wrote: > > Niklas, I'm sorry to lean on you here a little bit - You've been > > working on the SATA side of this a bit more often, can you let me know > > if you think this patch is safe? > >

Re: [PATCH for-8.1] vfio/display: Fix missing update to set backing fields

22.09.2023 12:38, Cédric Le Goater: On 9/13/23 21:18, Alex Williamson wrote: Hi Gerd, Some consultation would be appreciated on this thread to get this patch out of limbo.  Is there a better solution that what I've proposed? This does fix a regression reproducible on systems with an Intel

Re: [RFC PATCH 1/1] qtest/migration: Support more than one QEMU binary

Daniel P. Berrangé writes: > On Tue, Oct 03, 2023 at 05:24:50PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Fabiano, >> >> [+Alex & Daniel] >> >> On 3/10/23 16:19, Fabiano Rosas wrote: >> > We have strict rules around migration compatibility between different >> > QEMU versions but not a single

Re: [PATCH v10 00/11] Add VIRTIO sound card

On Tue, 03 Oct 2023 17:10, "Michael S. Tsirkin" wrote: I hope you are also fixing the linux driver to fix this in a robust way, yes? Hello Michael, You can find pertinent discussion on the virtio-comment list here:

Re: [PATCH v3 15/15] vfio/common: Move legacy VFIO backend code into separate container.c

On 10/3/23 12:14, Eric Auger wrote: From: Yi Liu Move all the code really dependent on the legacy VFIO container/group into a separate file: container.c. What does remain in common.c is the code related to VFIOAddressSpace, MemoryListeners, migration and all other general operations.

Re: [RFC] Proposal of QEMU PCI Endpoint test environment

hi shunsuke, all, what about vfio-user + qemu? qemu already has libvfio-user as submodule. there is ongoing work to add qemu vfio-user client functionality. adding people involved to loop, not sure if i forgot somebody. regards jiri On Tue, Oct 03, 2023 at 01:56:03PM +0900, Shunsuke Mie wrote:

Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG

On 10/3/23 05:30, Philippe Mathieu-Daudé wrote: Since v1: - Use 'target'/'common' in function names (Claudio) - Added Claudio R-b tags From v1: - Add missing accel_cpu_common_unrealize() - Add AccelClass::cpu_common_[un]realize handlers - Use tcg_exec_[un]realizefn as AccelClass handlers

Re: [PATCH v3 13/15] vfio/common: Store the parent container in VFIODevice

On 10/3/23 12:14, Eric Auger wrote: From: Zhenzhong Duan let's store the parent contaienr within the VFIODevice. This simplifies the logic in vfio_viommu_preset() and brings the benefice to hide the group specificity which is useful for IOMMUFD migration. Signed-off-by: Eric Auger

Re: [PATCH] xlnx-bbram: hw/nvram: Remove deprecated device reset

Hi Philippe, Thanks for the review. The rest is in the pipeline. Regards, Tong Ho From: Philippe Mathieu-Daudé Sent: Monday, October 2, 2023 11:23 PM To: Ho, Tong ; qemu-...@nongnu.org Cc: qemu-devel@nongnu.org ; alist...@alistair23.me ;

Re: [PATCH v3 14/15] vfio/common: Introduce a global VFIODevice list

On 10/3/23 12:14, Eric Auger wrote: From: Zhenzhong Duan Some functions iterate over all the VFIODevices. This is currently achieved by iterating over all groups/devices. Let's introduce a global list of VFIODevices simplifying that scan. Maybe we should move the qemu_register_reset() when

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 10:41, Michael S. Tsirkin wrote: > > On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: > > (1) The virtio-1.0 specification > > writes: > > > > > 3 General Initialization And Device Operation >

Re: [RFC PATCH 1/1] qtest/migration: Support more than one QEMU binary

On Tue, Oct 03, 2023 at 05:24:50PM +0200, Philippe Mathieu-Daudé wrote: > Hi Fabiano, > > [+Alex & Daniel] > > On 3/10/23 16:19, Fabiano Rosas wrote: > > We have strict rules around migration compatibility between different > > QEMU versions but not a single test that validates the migration

Re: [PATCH 1/1] tcg/loongarch64: Fix buid error

On 9/26/23 00:58, Song Gao wrote: From: gaosong Fix: In file included from ../tcg/tcg.c:735: /home1/gaosong/bugfix/qemu/tcg/loongarch64/tcg-target.c.inc: In function ‘tcg_out_vec_op’: /home1/gaosong/bugfix/qemu/tcg/loongarch64/tcg-target.c.inc:1855:9: error: a label can only be

Re: [PATCH v3 12/15] vfio/common: Introduce a per container device list

On 10/3/23 12:14, Eric Auger wrote: From: Zhenzhong Duan Several functions need to iterate over the VFIO devices attached to a given container. This is currently achieved by iterating over the groups attached to the container and then over the devices in the group. Let's introduce a per

Re: [PATCH v2 05/12] virtio-iommu: Introduce per IOMMUDevice reserved regions

Hi Jean, On 9/29/23 17:52, Jean-Philippe Brucker wrote: > Hi Eric, > > On Wed, Sep 13, 2023 at 10:01:40AM +0200, Eric Auger wrote: >> For the time being the per device reserved regions are >> just a duplicate of IOMMU wide reserved regions. Subsequent >> patches will combine those with host

Re: [PATCH v3 11/15] vfio/common: Move VFIO reset handler registration to a group agnostic function

On 10/3/23 12:14, Eric Auger wrote: From: Zhenzhong Duan Move the reset handler registration/unregistration to a place that is not group specific. vfio_[get/put]_address_space are the best places for that purpose. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 10:40, Michael S. Tsirkin wrote: > > On Tue, Oct 03, 2023 at 09:08:15AM -0400, Stefan Hajnoczi wrote: > > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > > > > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > > > One more question: > > > > >

Re: [PATCH v3 10/15] vfio/ccw: Use vfio_[attach/detach]_device

On 10/3/23 12:14, Eric Auger wrote: Let the vfio-ccw device use vfio_attach_device() and vfio_detach_device(), hence hiding the details of the used IOMMU backend. Note that the migration reduces the following trace "vfio: subchannel %s has already been attached" (featuring cssid.ssid.devid)

Re: [PULL 00/24] Audio, build system, misc fixes for 2023-10-03

03.10.2023 11:30, Paolo Bonzini: * fix from optionrom build * fix for KVM on Apple M2 * introduce machine property "audiodev" * ui/vnc: Require audiodev= to enable audio * audio: remove QEMU_AUDIO_* and -audio-help support * audio:

Re: [PATCH v10 01/11] Add virtio-sound device stub

"Michael S. Tsirkin" writes: > On Tue, Oct 03, 2023 at 03:34:44PM +0100, Alex Bennée wrote: >> >> "Michael S. Tsirkin" writes: >> >> > On Fri, Sep 29, 2023 at 05:08:21PM +0300, Emmanouil Pitsidianakis wrote: >> >> Add a new VIRTIO device for the virtio sound device id. Functionality >> >>

Re: [PATCH v3 09/15] vfio/ap: Use vfio_[attach/detach]_device

On 10/3/23 12:14, Eric Auger wrote: Let the vfio-ap device use vfio_attach_device() and vfio_detach_device(), hence hiding the details of the used IOMMU backend. We take the opportunity to use g_path_get_basename() which is prefered, as suggested by 3e015d815b ("use g_path_get_basename instead

Re: [RFC PATCH 1/1] qtest/migration: Support more than one QEMU binary

Hi Fabiano, [+Alex & Daniel] On 3/10/23 16:19, Fabiano Rosas wrote: We have strict rules around migration compatibility between different QEMU versions but not a single test that validates the migration state between different binaries. Add some infrastructure to allow running the migration

Re: [PATCH v3 08/15] vfio/platform: Use vfio_[attach/detach]_device

On 10/3/23 12:14, Eric Auger wrote: Let the vfio-platform device use vfio_attach_device() and vfio_detach_device(), hence hiding the details of the used IOMMU backend. Drop the trace event for vfio-platform as we have similar one in vfio_attach_device. Signed-off-by: Eric Auger Signed-off-by:

Re: [PATCH v3 07/15] vfio/pci: Introduce vfio_[attach/detach]_device

On 10/3/23 12:14, Eric Auger wrote: We want the VFIO devices to be able to use two different IOMMU backends, the legacy VFIO one and the new iommufd one. Introduce vfio_[attach/detach]_device which aim at hiding the underlying IOMMU backend (IOCTLs, datatypes, ...). Once vfio_attach_device

Re: [PATCH] migration: Unify and trace vmstate field_exists() checks

On Thu, Sep 07, 2023 at 08:55:52AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > For both save/load we actually share the logic on deciding whether a field > > should exist. Merge the checks into a helper and use it for both save and > > load. When doing so, add documentations and

Re: [PATCH] migration: Add co-maintainers for migration

On 3/10/23 16:38, Peter Xu wrote: Per the qemu upstream call a few hours ago, proposing Fabiano and myself as the co-maintainer for migration subsystem to help Juan. Cc: Fabiano Rosas Cc: Juan Quintela Signed-off-by: Peter Xu --- Fabiano, would you please ack here publically to acknowledge

Re: [PATCH v3 04/15] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any

On 10/3/23 12:14, Eric Auger wrote: In the VFIO_SPAPR_TCE_v2_IOMMU container case, when KVM_SET_DEVICE_ATTR fails, we currently don't propagate the error as we do on the vfio_spapr_create_window() failure case. Let's align the code. Take the opportunity to reword the error message and make it

Re: [PATCH] migration: Add co-maintainers for migration

Peter Xu wrote: > Per the qemu upstream call a few hours ago, proposing Fabiano and myself as > the co-maintainer for migration subsystem to help Juan. > > Cc: Fabiano Rosas > Cc: Juan Quintela > Signed-off-by: Peter Xu > --- > > Fabiano, would you please ack here publically to acknowledge

Re: [PATCH v10 01/11] Add virtio-sound device stub

On Tue, Oct 03, 2023 at 03:34:44PM +0100, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Fri, Sep 29, 2023 at 05:08:21PM +0300, Emmanouil Pitsidianakis wrote: > >> Add a new VIRTIO device for the virtio sound device id. Functionality > >> will be added in the following commits. >

Re: [PULL 00/24] Audio, build system, misc fixes for 2023-10-03

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] migration: Add co-maintainers for migration

Peter Xu writes: > Per the qemu upstream call a few hours ago, proposing Fabiano and myself as > the co-maintainer for migration subsystem to help Juan. > > Cc: Fabiano Rosas > Cc: Juan Quintela > Signed-off-by: Peter Xu Acked-by: Fabiano Rosas

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: > (1) The virtio-1.0 specification > writes: > > > 3 General Initialization And Device Operation > > 3.1 Device Initialization > > 3.1.1 Driver Requirements: Device

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, Oct 03, 2023 at 09:08:15AM -0400, Stefan Hajnoczi wrote: > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > > One more question: > > > > > > Why is the disabled state not needed by regular (non-vhost)

[PATCH] migration: Add co-maintainers for migration

Per the qemu upstream call a few hours ago, proposing Fabiano and myself as the co-maintainer for migration subsystem to help Juan. Cc: Fabiano Rosas Cc: Juan Quintela Signed-off-by: Peter Xu --- Fabiano, would you please ack here publically to acknowledge that you're fine with it? Thank

Re: [PATCH v10 01/11] Add virtio-sound device stub

"Michael S. Tsirkin" writes: > On Fri, Sep 29, 2023 at 05:08:21PM +0300, Emmanouil Pitsidianakis wrote: >> Add a new VIRTIO device for the virtio sound device id. Functionality >> will be added in the following commits. >> >> Based-on: >>

Re: [PATCH 0/5] accel: Restrict tcg_exec_[un]realizefn() to TCG

On 3/10/23 16:04, Richard Henderson wrote: On 10/2/23 23:44, Philippe Mathieu-Daudé wrote: On 15/9/23 21:00, Philippe Mathieu-Daudé wrote: - Add missing accel_cpu_unrealize() - Add AccelClass::[un]realize_cpu handlers - Use tcg_exec_[un]realizefn as AccelClass handlers Philippe Mathieu-Daudé

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 08:17:07PM -0400, Stefan Hajnoczi wrote: > On Mon, 2 Oct 2023 at 18:36, Michael S. Tsirkin wrote: > > > > On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > > > > > On Wed, Aug 30, 2023 at

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/3/23 16:25, Michael S. Tsirkin wrote: > On Tue, Oct 03, 2023 at 03:23:24PM +0200, Laszlo Ersek wrote: >> On 10/3/23 15:08, Stefan Hajnoczi wrote: >>> On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > One

Re: [PATCH v10 09/11] virtio-sound: implement audio output (TX)

Hi Manos, On 29/9/23 20:59, Manos Pitsidianakis wrote: On Fri, 29 Sep 2023 17:08, Emmanouil Pitsidianakis wrote: Handle output IO messages in the transmit (TX) virtqueue. [..] +    if (!stream->active) { +    /* Stream has stopped, so do not perform AUD_write. */ +   

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, Oct 03, 2023 at 03:23:24PM +0200, Laszlo Ersek wrote: > On 10/3/23 15:08, Stefan Hajnoczi wrote: > > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > >> > >> On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > >>> One more question: > >>> > >>> Why is the disabled

[RFC PATCH 0/1] tests/migration-test: Allow testing older machine types

Hi, I had this WIP patch laying around that seems to fit Juan's vision about testing older machine types. It is a very rough draft for now, but it may be useful for kickstarting the discussion. With this we can give the tests two different QEMU versions. The test picks the older machine type

[RFC PATCH 1/1] qtest/migration: Support more than one QEMU binary

We have strict rules around migration compatibility between different QEMU versions but not a single test that validates the migration state between different binaries. Add some infrastructure to allow running the migration tests with two different QEMU binaries as migration source and

Re: [PATCH v10 01/11] Add virtio-sound device stub

On Fri, Sep 29, 2023 at 05:08:21PM +0300, Emmanouil Pitsidianakis wrote: > Add a new VIRTIO device for the virtio sound device id. Functionality > will be added in the following commits. > > Based-on: > https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 >

Re: [PATCH v10 00/11] Add VIRTIO sound card

On Fri, Sep 29, 2023 at 05:08:20PM +0300, Emmanouil Pitsidianakis wrote: > This patch series adds an audio device implementing the recent virtio > sound spec (1.2) and a corresponding PCI wrapper device. > > v10 can be found online at: > > https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v10 >

Re: [PATCH 0/5] accel: Restrict tcg_exec_[un]realizefn() to TCG

On 10/3/23 16:04, Richard Henderson wrote: > On 10/2/23 23:44, Philippe Mathieu-Daudé wrote: >> On 15/9/23 21:00, Philippe Mathieu-Daudé wrote: >>> - Add missing accel_cpu_unrealize() >>> - Add AccelClass::[un]realize_cpu handlers >>> - Use tcg_exec_[un]realizefn as AccelClass handlers >>> >>>

Re: [PATCH v3 01/15] scripts/update-linux-headers: Add iommufd.h

Hi Cédric, On 10/3/23 15:50, Cédric Le Goater wrote: > On 10/3/23 12:13, Eric Auger wrote: >> Update the script to import iommufd.h >> >> Signed-off-by: Eric Auger >> Signed-off-by: Yi Liu >> Signed-off-by: Zhenzhong Duan > > > Reviewed-by: Cédric Le Goater Sorry I forgot to grab it :-( Eric

Re: [PATCH] tests/avocado: Re-enable MIPS Malta tests (GitLab issue #1884 fixed)

On 10/2/23 23:38, Philippe Mathieu-Daudé wrote: Commit 18a536f1f8 ("accel/tcg: Always require can_do_io") fixed the GitLab issue #1884: we can now re-enable those tests. This reverts commit f959c3d87ccfa585b105de6964a6261e368cc1da. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG

Nice. I build-tested and make checked this as well, Reviewed-by: Claudio Fontana Tested-by: Claudio Fontana On 10/3/23 14:30, Philippe Mathieu-Daudé wrote: > Since v1: > - Use 'target'/'common' in function names (Claudio) > - Added Claudio R-b tags > > From v1: > - Add missing

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

On Mon, Sep 25, 2023 at 03:53:23PM -0400, John Snow wrote: > Niklas, I'm sorry to lean on you here a little bit - You've been > working on the SATA side of this a bit more often, can you let me know > if you think this patch is safe? FWIW, I prefer Fiona's patch series which calls

Re: [PATCH 0/5] accel: Restrict tcg_exec_[un]realizefn() to TCG

On 10/2/23 23:44, Philippe Mathieu-Daudé wrote: On 15/9/23 21:00, Philippe Mathieu-Daudé wrote: - Add missing accel_cpu_unrealize() - Add AccelClass::[un]realize_cpu handlers - Use tcg_exec_[un]realizefn as AccelClass handlers Philippe Mathieu-Daudé (5):    accel: Rename accel_cpu_realizefn()

Re: [PATCH RESEND] osdep: set _FORTIFY_SOURCE=2 when optimization is enabled

On 10/3/23 02:15, Daniel P. Berrangé wrote: Currently we set _FORTIFY_SOURCE=2 as a compiler argument when the meson 'optimization' setting is non-zero, the compiler is GCC and the target is Linux. While the default QEMU optimization level is 2, user could override this by setting CFLAGS="-O0"

[PATCH qemu 0/1] Elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free

Based on this issue https://gitlab.com/qemu-project/qemu/-/issues/1798 g_new is used where I think it is applicable and a struct is well defined. Suraj Shirvankar (1): Switch memory management calls to new coding conventions contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c |

[PATCH qemu 1/1] Switch memory management calls to new coding conventions

From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 4 ++-- contrib/elf2dmp/pdb.c | 4 ++-- contrib/elf2dmp/qemu_elf.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] vhost: Perform memory section dirty scans once per iteration

On Wed, Sep 27, 2023 at 12:14:28PM +0100, Joao Martins wrote: > On setups with one or more virtio-net devices with vhost on, > dirty tracking iteration increases cost the bigger the number > amount of queues are set up e.g. on idle guests migration the > following is observed with virtio-net with

Re: [PATCH 0/2] tests: Drop mentions of SoftMMU

On 10/2/23 07:51, Philippe Mathieu-Daudé wrote: We want to clarify when code depends on a software MMU, or when it depends on TCG system emulation. This series replaces 'softmmu' by TCG when relevant, or simply remove it. Philippe Mathieu-Daudé (2): tests/vm/ubuntu.aarch64: Correct comment

Re: [PATCH v3 01/15] scripts/update-linux-headers: Add iommufd.h

On 10/3/23 12:13, Eric Auger wrote: Update the script to import iommufd.h Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- scripts/update-linux-headers.sh | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v4 00/18] virtio-mem: Expose device memory through multiple memslots

On Tue, Sep 26, 2023 at 08:57:20PM +0200, David Hildenbrand wrote: > Quoting from patch #16: > > Having large virtio-mem devices that only expose little memory to a VM > is currently a problem: we map the whole sparse memory region into the > guest using a single memslot, resulting in

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > Rename the version not burried in the macro to cap_h. > > Signed-off-by: Jonathan Cameron > --- Reviewed-by: Michael S. Tsirkin pls merge with the rest of local shadowing things. > I had another instance of this in a

Re: [PATCH v2 1/2] target/riscv/kvm: improve 'init_multiext_cfg' error msg

On 3/10/23 15:21, Daniel Henrique Barboza wrote: Our error message is returning the value of 'ret', which will be always -1 in case of error, and will not be that useful: qemu-system-riscv64: Unable to read ISA_EXT KVM register ssaia, error -1 Improve the error message by outputting 'errno'

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/3/23 15:08, Stefan Hajnoczi wrote: > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: >> >> On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: >>> One more question: >>> >>> Why is the disabled state not needed by regular (non-vhost) virtio-net >>> devices? >> >> Tap

[PATCH v2 1/2] target/riscv/kvm: improve 'init_multiext_cfg' error msg

Our error message is returning the value of 'ret', which will be always -1 in case of error, and will not be that useful: qemu-system-riscv64: Unable to read ISA_EXT KVM register ssaia, error -1 Improve the error message by outputting 'errno' instead of 'ret'. Use strerrorname_np() to output the

[PATCH v2 2/2] target/riscv/kvm: support KVM_GET_REG_LIST

KVM for RISC-V started supporting KVM_GET_REG_LIST in Linux 6.6. It consists of a KVM ioctl() that retrieves a list of all available regs for get_one_reg/set_one_reg. Regs that aren't present in the list aren't supported in the host. This simplifies our lives when initing the KVM regs since we

[PATCH v2 0/2] riscv, kvm: support KVM_GET_REG_LIST

Hi, In this new version all instances of "error_setg(_fatal, ..." were replaced with error_report() and exit(1), as suggested by Phil in v1. No other changes made. Changes from v1: - patches 1 and 2: - replace 'error_setg(_fatal" with error_report() and exit(1) - v1 link:

Re: [LINUX KERNEL PATCH v5 1/2] virtio_pci: Add freeze_mode for virtio_pci_common_cfg

On Tue, Sep 19, 2023 at 06:46:06PM +0800, Jiqian Chen wrote: > When guest vm does S3, Qemu will reset and clear some things of virtio > devices, but guest can't aware that, so that may cause some problems. > For excample, Qemu calls virtio_reset->virtio_gpu_gl_reset, that will > destroy render

Re: [PATCH] vhost: Add a defensive check in vhost_commit against wrong deallocation

Hi Michael, On 10/3/23 14:43, Michael S. Tsirkin wrote: > On Wed, Sep 13, 2023 at 09:46:57AM +0200, Eric Auger wrote: >> In vhost_commit(), it may happen that dev->mem_sections and >> dev->tmp_sections are equal, > Could you please explain a bit more how this can happen? > I don't see how. > >>

Re: [PATCH v2 0/2] virtio-blk: add iothread-vq-mapping parameter

On Mon, Sep 18, 2023 at 12:16:02PM -0400, Stefan Hajnoczi wrote: > virtio-blk and virtio-scsi devices need a way to specify the mapping between > IOThreads and virtqueues. At the moment all virtqueues are assigned to a > single > IOThread or the main loop. This single thread can be a CPU

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > One more question: > > > > Why is the disabled state not needed by regular (non-vhost) virtio-net > > devices? > > Tap does the same - it purges queued packets: > > int

Re: [PATCH v6 18/19] linux-user/s390x: Add vdso

Hi Richard, On 30/9/23 04:15, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/s390x/vdso-asmoffset.h | 2 + linux-user/elfload.c | 2 + linux-user/s390x/signal.c | 4 +- linux-user/s390x/Makefile.vdso| 11 +

Re: [PATCH v6 19/19] build: Add update-linux-vdso makefile rule

On 30/9/23 04:15, Richard Henderson wrote: This is not ideal, since it requires all cross-compilers to be present rather than a simple subset. But since it is only run manually, should be good enough for now. Signed-off-by: Richard Henderson --- Makefile | 10 ++ 1 file changed, 10

Re: [PATCH v6 08/19] linux-user: Add gen-vdso tool

On 30/9/23 04:15, Richard Henderson wrote: This tool will be used for post-processing the linked vdso image, turning it into something that is easy to include into elfload.c. Signed-off-by: Richard Henderson --- linux-user/gen-vdso.c | 223

Re: [PATCH] MAINTAINERS: Add entry for rdma migration

Peter Xu wrote: > On Mon, Sep 25, 2023 at 03:55:08PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > It's not obvious to many that RDMA migration is in Odd Fixes stage for a >> > long time. Add an explicit sub entry for it (besides migration, which >> > already covers the rdma

Re: [PATCH v4 21/21] i386: Add new property to control L2 cache topo in CPUID.04H

On Fri, Sep 15, 2023 at 03:53:25PM +0800, Zhao Liu wrote: > Hi Philippe, > > On Thu, Sep 14, 2023 at 09:41:30AM +0200, Philippe Mathieu-Daudé wrote: > > Date: Thu, 14 Sep 2023 09:41:30 +0200 > > From: Philippe Mathieu-Daudé > > Subject: Re: [PATCH v4 21/21] i386: Add new property to control L2

Re: [PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

On 25/09/2023 16:17, Hanna Czenczek wrote: On 25.09.23 13:40, Jean-Louis Dupond wrote: On 15/09/2023 13:21, Hanna Czenczek wrote: On 05.09.23 15:08, Jean-Louis Dupond wrote: When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is

[PATCH v3] qcow2: keep reference on zeroize with discard-no-unref enabled

When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image. When committing the snapshot to the backing file, not

[PATCH 3/3] target/riscv: Don't assume PMU counters are continuous

Check the PMU available bitmask when checking if a counter is valid rather than comparing the index against the number of PMUs. Signed-off-by: Rob Bradford --- target/riscv/csr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c

[PATCH 1/3] target/riscv: Propagate error from PMU setup

More closely follow the QEMU style by returning an Error and propagating it there is an error relating to the PMU setup. Further simplify the function by removing the num_counters parameter as this is available from the passed in cpu pointer. Signed-off-by: Rob Bradford --- target/riscv/cpu.c

[PATCH 2/3] target/riscv: Support discontinuous PMU counters

There is no requirement that the enabled counters in the platform are continuously numbered. Add a "pmu-mask" property that, if specified, can be used to specify the enabled PMUs. In order to avoid ambiguity if "pmu-mask" is specified then "pmu-num" must also match the number of bits set in the

[PATCH 0/3] Support discontinuous PMU counters

Currently the available PMU counters start at HPM3 and run through to the number specified by the "pmu-num" property. There is no requirement in the specification that the available counters be continously numbered. This series add suppport for specifying a discountinuous range of counters though

Re: [PATCH v6 07/19] linux-user: Load vdso image if available

On 30/9/23 04:15, Richard Henderson wrote: The vdso image will be pre-processed into a C data array, with a simple list of relocations to perform, and identifying the location of signal trampolines. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 90

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

On Monday, 2 October 2023 John Snow wrote: > Which reset pathway are you testing that causes the problem? The test centres on a VM-initiated bus reset because a DMA write has stalled (I deliberately discard the iSCSI response). > I'm not fully clear on why checking for DRQ is legitimate here.

Re: [PATCH v5 2/2] migration: Update error description outside migration.c

Tejus GK wrote: > A few code paths exist in the source code,where a migration is > marked as failed via MIGRATION_STATUS_FAILED, but the failure happens > outside of migration.c > > In such cases, an error_report() call is made, however the current > MigrationState is never

Re: [PATCH] vhost: Add a defensive check in vhost_commit against wrong deallocation

On Wed, Sep 13, 2023 at 09:46:57AM +0200, Eric Auger wrote: > In vhost_commit(), it may happen that dev->mem_sections and > dev->tmp_sections are equal, Could you please explain a bit more how this can happen? I don't see how. > in which case, unconditionally > freeing old_sections at the end of

Re: [PATCH v5 1/2] migration/vmstate: Introduce vmstate_save_state_with_err

Tejus GK wrote: > Currently, a few code paths exist in the function vmstate_save_state_v, > which ultimately leads to a migration failure. However, an update in the > current MigrationState for the error description is never done. > > vmstate.c somehow doesn't seem to allow the use of

Re: [PATCH v3 5/5] hw/vfio: add ramfb migration support

On 10/3/23 12:47, Marc-André Lureau wrote: > Hi > > On Tue, Oct 3, 2023 at 2:17 PM Cédric Le Goater wrote: >> >> On 10/3/23 10:56, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> Add a "VFIODisplay" subsection whenever "x-ramfb-migrate" is turned on. >>> >>> Turn it off

[PULL 12/13] hw/display/ramfb: plug slight guest-triggerable leak on mode setting

From: Laszlo Ersek The fw_cfg DMA write callback in ramfb prepares a new display surface in QEMU; this new surface is put to use ("swapped in") upon the next display update. At that time, the old surface (if any) is released. If the guest triggers the fw_cfg DMA write callback at least twice

[PULL 03/13] ui/console: only walk QemuGraphicConsoles in qemu_console_is_multihead()

From: Laszlo Ersek qemu_console_is_multihead() declares the console "c" a "multihead" console if there are two different consoles in the system that (a) both reference "c->device", and (b) have different "c->head" numbers. In effect, if at least two consoles exist that are different heads of the

[PULL 13/13] chardev/char-pty: Avoid losing bytes when the other side just (re-)connected

From: Thomas Huth When starting a guest via libvirt with "virsh start --console ...", the first second of the console output is missing. This is especially annoying on s390x that only has a text console by default and no graphical output - if the bios fails to boot here, the information about

[PULL 11/13] hw/pc: remove needless includes

From: Marc-André Lureau The include list is gigantic, make it smaller. Signed-off-by: Marc-André Lureau Acked-by: Laszlo Ersek --- hw/i386/pc.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5d399b6247..ec01d74482

[PULL 09/13] analyze-migration: ignore RAM_SAVE_FLAG_MULTIFD_FLUSH

From: Marc-André Lureau Traceback (most recent call last): File "scripts/analyze-migration.py", line 605, in dump.read(dump_memory = args.memory) File "scripts/analyze-migration.py", line 542, in read section.read() File "scripts/analyze-migration.py", line 214, in read raise

[PULL 06/13] ui: add XBGR8888 and ABGR8888 in drm_format_pixman_map

From: Ken Xue Android uses XBGR and ABGR as default scanout buffer, But qemu does not support them for qemu_pixman_to_drm_format conversion within virtio_gpu_create_dmabuf for virtio gpu. so, add those 2 formats into drm_format_pixman_map. Signed-off-by: Ken Xue Reviewed-by:

[PULL 08/13] ui/gtk: fix UI info precondition

From: Marc-André Lureau dpy_get_ui_info() shouldn't be called if the underlying GPU doesn't support it. Before the assert() was added and the regression introduced, GTK code used to get "zero" UI info, for ex with a simple VGA device. The assert was added to prevent from calling when there are

<    1   2   3   4   5   >