Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread Amit Shah
On (Mon) 04 Apr 2011 [16:09:05], Stefan Hajnoczi wrote: > On Mon, Apr 4, 2011 at 2:49 PM, Avi Kivity wrote: > > On 04/04/2011 04:38 PM, Anthony Liguori wrote: > >> > >> On 04/04/2011 08:22 AM, Avi Kivity wrote: > >>> > >>> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: > > In order for m

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-04 Thread Brad Hards
On Tue, 5 Apr 2011 05:59:27 am Anthony Liguori wrote: > - Trivial patch monkeys^Wteam -- this is an idea Stefan and I have been > kicking around to help some of the trivial patches get more attention on > the mailing list I saw a wiki page (http://wiki.qemu.org/Contribute/TrivialPatches) that I as

[Qemu-devel] [PATCH v3] v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.

2011-04-04 Thread Harsh Prateek Bora
The nwnames field in TWALK message is assumed to be >=0 and <= MAXWELEM which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000 RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk. v3: - Updated if-else conditions to appropriately handle nwnames = 0. v2: - Added c

Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread David Ahern
On 04/04/11 23:33, Stefan Hajnoczi wrote: > On Mon, Apr 4, 2011 at 6:54 PM, David Ahern wrote: >> On 04/04/11 07:38, Anthony Liguori wrote: >>> On 04/04/2011 08:22 AM, Avi Kivity wrote: On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: > In order for media change to work with Linux host CD-R

[Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS

2011-04-04 Thread Stefan Berger
On 04/05/2011 01:17 AM, Kevin O'Connor wrote: On Mon, Apr 04, 2011 at 09:29:39PM -0400, Stefan Berger wrote: The following set of patches add TPM and Trusted Computing support to SeaBIOS. In particular the patches add: Thanks Stefan. In general, it looks okay to me. Since this depends on a qe

Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread Stefan Hajnoczi
On Mon, Apr 4, 2011 at 6:54 PM, David Ahern wrote: > > > On 04/04/11 07:38, Anthony Liguori wrote: >> On 04/04/2011 08:22 AM, Avi Kivity wrote: >>> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: In order for media change to work with Linux host CD-ROM it is necessary to reopen the file (

[Qemu-devel] KVM Forum 2011 - Save the Date

2011-04-04 Thread KVM Forum 2011 Program Committee
KVM Forum 2011 - Save the Date Conference: August 15 - 16, 2011 Location: Hyatt Regency Vancouver - Vancouver, Canada KVM is an industry leading open source hypervisor that provides an ideal platform for datacenter virtualization, virtual desktop infrastructure, and cloud computing. Once again,

[Qemu-devel] [PATCH 2/3] Delay creation of pseries device tree until reset

2011-04-04 Thread David Gibson
At present, the 'pseries' machine creates a flattened device tree in the machine->init function to pass to either the guest kernel or to firmware. However, the machine->init function runs before processing of -device command line options, which means that the device tree so created will be (incorr

[Qemu-devel] [PATCH 1/3] pseries: Abolish envs array

2011-04-04 Thread David Gibson
Currently the pseries machine init code builds up an array, envs, of CPUState pointers for all the cpus in the system. This is kind of pointless, given the generic code already has a perfectly good linked list of the cpus. In addition, there are a number of places which assume that the cpu's cpu_

[Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS

2011-04-04 Thread Kevin O'Connor
On Mon, Apr 04, 2011 at 09:29:39PM -0400, Stefan Berger wrote: > The following set of patches add TPM and Trusted Computing support to SeaBIOS. > In particular the patches add: Thanks Stefan. In general, it looks okay to me. Since this depends on a qemu change, though, I'd like to see a qemu/kvm

[Qemu-devel] [PATCH 3/3] Use existing helper function to implement popcntd instruction

2011-04-04 Thread David Gibson
The recent patches adding partial support for POWER7 cpu emulation included implementing the popcntd instruction. The support for this was open coded, but host-utils.h already included a function implementing an equivalent population count function, which uses a gcc builtin (which can use special

[Qemu-devel] [0/3] pSeries machine improvements

2011-04-04 Thread David Gibson
This patch series makes several small cleanups and improvements to the recently added pSeries machine. This include an optimization of the popcntd implementation, as suggested in replies to the original series, and some cleanups of the cpu initialization handling which will assist later kvm enable

[Qemu-devel] [PATCH] scsi-generic: Remove bogus double complete

2011-04-04 Thread David Gibson
From: Ben Herrenschmidt scsi-generic scsi_read_complete() should not -both- call the client complete callback with SCSI_REASON_DATA -and- call scsi_command_complete(). The former will cause the client to queue a new read or write request, while the later will free the request data structure, thu

[Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable

2011-04-04 Thread Benjamin Herrenschmidt
On Tue, 2011-04-05 at 14:14 +1000, David Gibson wrote: > > >@@ -255,7 +255,7 @@ static int vscsi_srp_direct_data(VSCSIState *s, > vscsi_req *req, > > > { > > > struct srp_direct_buf *md = req->cur_desc; > > > uint32_t llen; > > >-int rc; > > >+int rc = 0; > > > > David, is this

Re: [Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-04 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:24PM +0200, Alexander Graf wrote: > With the s390x target we use the deposit instruction to store 32bit values > into 64bit registers without clobbering the upper 32 bits. > > This specific operation can be optimized slightly by using the ext operation > instead of an

[Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable

2011-04-04 Thread David Gibson
On Mon, Apr 04, 2011 at 05:03:44PM +0200, Alexander Graf wrote: > On 04/03/2011 06:21 PM, Stefan Weil wrote: > >cppcheck reports this error: > > > >hw/spapr_vscsi.c:274: error: Uninitialized variable: rc > > > >If llen == 0, rc was indeed used without being initialized. > > > >Signed-off-by: Stefan

[Qemu-devel] [PATCH 0/2] piix_pci: factor out pam, smram logic

2011-04-04 Thread Isaku Yamahata
Factor out PC pam, smram logic. which will also be used for q35 later. All the magic numbers are replaced with symbolic constants at the same. As by product, pc_piix initalization is simplified a bit. Isaku Yamahata (2): pc/piix_pci: factor out smram/pam logic pc, i440fx: simplify i440fx initi

[Qemu-devel] [PATCH 1/2] pc/piix_pci: factor out smram/pam logic

2011-04-04 Thread Isaku Yamahata
Factor out smram/pam logic for later use. Which will be used by q35 too. Signed-off-by: Isaku Yamahata --- Makefile.target |2 +- hw/pam.c| 128 +++ hw/pam.h| 96 + hw/piix_pci.c

[Qemu-devel] [PATCH 2/2] pc, i440fx: simplify i440fx initialization

2011-04-04 Thread Isaku Yamahata
simplify i440fx initialization by eliminating i440fx_init_memory_mappings(). Signed-off-by: Isaku Yamahata --- hw/pc.h |2 +- hw/pc_piix.c |8 +--- hw/piix_pci.c | 15 ++- 3 files changed, 8 insertions(+), 17 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index feb

Re: [Qemu-devel] [PATCH V2 4/9] Add tpm_tis driver to build process

2011-04-04 Thread Stefan Berger
On 04/03/2011 05:20 AM, Blue Swirl wrote: On Fri, Apr 1, 2011 at 10:57 PM, Stefan Berger wrote: On 04/01/2011 02:14 PM, Blue Swirl wrote: At this point there is no compile test needed since all code is 'there'. It's merely adding the front-end,i.e., the TPM TIS emulation to be compiled. If t

[Qemu-devel] [PATCH] smbus_eeprom: consolidate smbus eeprom creation oc pc_piix, mips_mapta, mips_fulong

2011-04-04 Thread Isaku Yamahata
consolidate smbus initialization for pc_piix, mips_malta and mips_fulong. Cc: Aurelien Jarno Cc: Huacai Chen Signed-off-by: Isaku Yamahata Reviewed-by: Aurelien Jarno --- hw/mips_fulong2e.c |9 + hw/mips_malta.c| 12 ++-- hw/pc_piix.c | 10 ++ hw/smbu

[Qemu-devel] [PATCH V2 6/8] Add measurement code to the BIOS

2011-04-04 Thread Stefan Berger
This patch adds invocactions of functions that measure various parts of the code and data through various parts of the BIOS code. It follows TCG specifications on what needs to be measured. It also adds the implementation of the called functions. Reference for what needs to be measured can be foun

[Qemu-devel] [PATCH V2 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-04-04 Thread Stefan Berger
This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT. Since the logging area in the TCPA table requires 64kb, the memory reserved for ACPI tables

[Qemu-devel] [PATCH V2 8/8] Optional tests for the TIS interface

2011-04-04 Thread Stefan Berger
This patch adds an optional test suite (CONFIG_TIS_TEST) for the TIS interface to SeaBIOS. If compiled into the BIOS, it can be invoked through the TPM-specific menu item 8. 1. Enable TPM 2. Disable TPM 3. Activate TPM 4. Deactivate TPM 5. Clear ownership 6. Allow installation of owner 7. Prevent

[Qemu-devel] [PATCH V2 7/8] Add a menu for TPM control

2011-04-04 Thread Stefan Berger
This patch provides an addtional menu entry that enables the user to control certain aspects of the TPM. If a working TPM has been detected, the top level BIOS menu will look like this: Press F12 for boot menu. Press F11 to TPM menu. Upon pressing F11 the TPM menu will be shown: 1. Enable TPM 2

[Qemu-devel] [PATCH V2 5/8] Support for BIOS interrupt handler

2011-04-04 Thread Stefan Berger
This patch implements the TCG BIOS interrupt handler 1ah. It is for example used by trusted grub. This patch adds an implementation of SHA1 (following NIST specs., IETF RFC 3147 and Wikipedia) for speeding up measurements of code. Trusted Grub for example makes use of this interface and measures (

[Qemu-devel] [PATCH V2 1/8] Add an implementation for a TPM TIS driver

2011-04-04 Thread Stefan Berger
This patch adds an implementation of a TPM TIS driver for the TPM TIS emulation supported by Qemu (patches posted, not in git yet). Usage of the driver is broken up into several functions. The driver is cleanly separated from the rest of the code through an interface holding pointers to the driver'

[Qemu-devel] [PATCH V2 4/8] Implementation of the TCG BIOS extensions

2011-04-04 Thread Stefan Berger
This patch implements the main part of the TCG BIOS extensions. It provides the following functionality: - initialization of the TCPA ACPI table used for logging of measurements - initialization of the TPM by sending a sequence of commands to it - proper setup of the TPM once the BIOS hands over c

[Qemu-devel] [PATCH V2 3/8] Add public get_rsdp function

2011-04-04 Thread Stefan Berger
This patch adds a global get_rsdp() function call and refactors find_resume_vector() to call it. Signed-off-by: Stefan Berger --- src/acpi.c | 12 ++-- src/acpi.h |1 + 2 files changed, 11 insertions(+), 2 deletions(-) Index: seabios/src/acpi.c ===

[Qemu-devel] [PATCH V2 0/8] Add TPM support to SeaBIOS

2011-04-04 Thread Stefan Berger
The following set of patches add TPM and Trusted Computing support to SeaBIOS. In particular the patches add: - a TPM driver for the Qemu's TPM TIS emulation (not yet in Qemu git) - ACPI support for the TPM device (SSDT table) - ACPI support for measurement logging (TCPA table) - Support for initi

[Qemu-devel] [PATCH] Minor spelling mistakes in hw/usb-ccid.c

2011-04-04 Thread Brad Hards
Hi, While looking at David Gibson's build-fix for hw/usb-ccid.c, I noticed a spello in a comment on the following (unchanged) line. This patch fixes that, and a couple of other spellos, in that file. Brad - - From e24a4cfce56799e091ce75aafa20c697ec5fe685 Mon Sep 17 00:00:00 2001 From: Brad H

[Qemu-devel] [PATCH 6/6] trace: enable all events

2011-04-04 Thread Lluís
Given that all events with programmatically-controlled state are disabled by default, we can delete the "disable" property from all events. As of now, the only backend that will generate high ammounts of (possibly) undesired output is "stderr", but it is considered only for debug purposes. Signed

[Qemu-devel] [PATCH 5/6] trace-state: [simple] add "-trace events" argument to control initial state

2011-04-04 Thread Lluís
When using the "simple" tracing backend, all events are in disabled state by default. The "-trace events" argument can be used to provide a file with a list of trace event names that will be enabled prior to starting execution. This saves the user from manually toggling event states through the mo

[Qemu-devel] [PATCH 2/6] trace: generalize the "property" concept in the trace-events file

2011-04-04 Thread Lluís
This adds/modifies the following functions: * get_name: Get _only_ the event name * has_property: Return whether an event has a property (keyword before the event name) Signed-off-by: Lluís Vilanova --- docs/tracing.txt |4 +-- scripts/tracetool | 73 ---

[Qemu-devel] [PATCH 4/6] trace-state: [simple] disable all trace points by default

2011-04-04 Thread Lluís
Note that this refers to the backend-specific state (whether the output must be generated), not the event "disabled" property (which always uses the "nop" backend). Signed-off-by: Lluís Vilanova --- scripts/tracetool |9 ++--- trace-events |3 --- 2 files changed, 2 insertions(+

[Qemu-devel] [PATCH 3/6] trace-state: always use the "nop" backend on events with the "disable" keyword

2011-04-04 Thread Lluís
Any event with the keyword/property "disable" generates an empty trace event using the "nop" backend, regardless of the current backend. Signed-off-by: Lluís Vilanova --- docs/tracing.txt |3 +++ scripts/tracetool | 15 ++- 2 files changed, 5 insertions(+), 13 deletions(-) di

[Qemu-devel] [PATCH 1/6] trace: [ust] fix generation of 'trace.c' on events without args

2011-04-04 Thread Lluís
Signed-off-by: Lluís Vilanova --- scripts/tracetool |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 412f695..d88cb43 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -338,6 +338,7 @@ linetoc_ust() name=$(get_

[Qemu-devel] [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends

2011-04-04 Thread Lluís
This patch defines the "disable" trace event state to always use the "nop" backend. As a side-effect, all events are now enabled (without "disable") by default, as all backends (except "stderr") have programmatic support for dynamically (de)activating each trace event. In order to make this true,

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-04-04 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/lucid-proposed/qemu-kvm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt virtualization API:

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Michael S. Tsirkin
On Tue, Apr 05, 2011 at 12:05:08AM +0300, Blue Swirl wrote: > On Mon, Apr 4, 2011 at 10:44 PM, Michael S. Tsirkin wrote: > > On Mon, Apr 04, 2011 at 08:02:23PM +0300, Blue Swirl wrote: > >> On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity wrote: > >> > On 04/04/2011 07:22 PM, Anthony Liguori wrote: > >

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Blue Swirl
On Mon, Apr 4, 2011 at 10:44 PM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2011 at 08:02:23PM +0300, Blue Swirl wrote: >> On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity wrote: >> > On 04/04/2011 07:22 PM, Anthony Liguori wrote: >> >> >> >> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: >> >>> >>

Re: [Qemu-devel] Help Debugging AIX boot on qemu-system-ppc (it reads bootfile.exe now)

2011-04-04 Thread Brian Wheeler
Booting AIX 5.2 gives me --- Welcome to AIX. boot image timestamp: 70:80 15/C0 The current time and date: 20:40:45 04/04/2011 number

Re: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU

2011-04-04 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 12:09:22PM +0100, Peter Maydell wrote: > CPU_QuadU isn't used on all targets, but there's no harm in defining the > typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because > softfloat-native doesn't have a float128 type. This avoids the need for > every new

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-04 Thread Lucas Meneghel Rodrigues
On Mon, 2011-04-04 at 14:59 -0500, Anthony Liguori wrote: > On 04/04/2011 02:22 PM, Juan Quintela wrote: > > Please, send in any agenda items you are interested in covering. > > - KVM Forum -- do we have an ETA on CFP? > > - Sub-maintainership -- how we can expand and improve upon it > > - Trivi

Re: [Qemu-devel] Help Debugging AIX boot on qemu-system-ppc (it reads bootfile.exe now)

2011-04-04 Thread Kenneth Salerno
--- On Sun, 4/3/11, Kenneth Salerno wrote: > From: Kenneth Salerno > Subject: Re: [Qemu-devel] Help Debugging AIX boot on qemu-system-ppc (it > reads bootfile.exe now) > To: "malc" > Cc: qemu-devel@nongnu.org > Date: Sunday, April 3, 2011, 6:52 PM > --- On Sun, 4/3/11, Kenneth Salerno > > wro

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-04 Thread Anthony Liguori
On 04/04/2011 02:22 PM, Juan Quintela wrote: Please, send in any agenda items you are interested in covering. - KVM Forum -- do we have an ETA on CFP? - Sub-maintainership -- how we can expand and improve upon it - Trivial patch monkeys^Wteam -- this is an idea Stefan and I have been kicking

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Michael S. Tsirkin
On Mon, Apr 04, 2011 at 08:02:23PM +0300, Blue Swirl wrote: > On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity wrote: > > On 04/04/2011 07:22 PM, Anthony Liguori wrote: > >> > >> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: > >>> > >>> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: > >

[Qemu-devel] KVM call agenda for April 05

2011-04-04 Thread Juan Quintela
Please, send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [PATCH 4/5] sparc64: fix mmu context at trap levels above zero

2011-04-04 Thread Igor Kovalenko
On Mon, Apr 4, 2011 at 10:37 PM, Blue Swirl wrote: > On Mon, Apr 4, 2011 at 8:25 PM, Artyom Tarasenko wrote: >> On Sat, May 22, 2010 at 12:52 PM, Igor V. Kovalenko >> wrote: >>> --- a/target-sparc/helper.c >>> +++ b/target-sparc/helper.c >>> @@ -572,6 +572,23 @@ static int get_physical_address(C

[Qemu-devel] GSoC - QCOW2 <-> QED image converter

2011-04-04 Thread Lyu Mitnick
Hello all, Looking at QEMU'w wiki I saw the "QCOW2 <- > QED image converter", that I am also interested to work as student and apply for GSoC 2011. I have study the specifications of the two images and have some idea about implementation. There is someone already working on this project?? I also w

Re: [Qemu-devel] [PATCH 4/5] sparc64: fix mmu context at trap levels above zero

2011-04-04 Thread Blue Swirl
On Mon, Apr 4, 2011 at 8:25 PM, Artyom Tarasenko wrote: > On Sat, May 22, 2010 at 12:52 PM, Igor V. Kovalenko > wrote: >> --- a/target-sparc/helper.c >> +++ b/target-sparc/helper.c >> @@ -572,6 +572,23 @@ static int get_physical_address(CPUState *env, >> target_phys_addr_t *physical, >>     /* ?

[Qemu-devel] Re: [PATCH 0/4] target-arm: Make Neon helpers use correct FP status

2011-04-04 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 11:46:31AM +0100, Peter Maydell wrote: > This is a patchset which takes the approach discussed in the > comments on my earlier patch to fix this bug. We compile *_helper.c > with HELPER_CFLAGS, so targets don't need to put all their helper > routines in op_helper.c. (This on

Re: [Qemu-devel] [PATCH] lan9118: Ignore write to MAC_VLAN1 register

2011-04-04 Thread Aurelien Jarno
On Tue, Mar 29, 2011 at 10:41:12PM +0900, Atsushi Nemoto wrote: > Since kernel 2.6.38, smsc911x driver writes to VLAN1 registger. > > Signed-off-by: Atsushi Nemoto > --- > hw/lan9118.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/lan9118.c b/hw/lan9118.c > i

[Qemu-devel] Re: [regression] configure: add opengl detection

2011-04-04 Thread Michael Walle
Hi Benjamin, > Let me know if you need more info. what happens if you configure with ./configure --target-list=x86_64-softmmu --disable-opengl -- Michael

Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread David Ahern
On 04/04/11 07:38, Anthony Liguori wrote: > On 04/04/2011 08:22 AM, Avi Kivity wrote: >> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: >>> In order for media change to work with Linux host CD-ROM it is >>> necessary to reopen the file (otherwise the inode size will not >>> refresh, this is an is

Re: [Qemu-devel] GSoC: Improved image format compatibility

2011-04-04 Thread Lyu Mitnick
Hello Stefan, 2011/4/3 Stefan Hajnoczi > On Sat, Apr 2, 2011 at 8:03 PM, Lyu Mitnick wrote: > > Hello Stefan, > > I have take a look at block.c. But I am a little confused about the > meaning > > of synchronous/asynchronous i/o. I know the two concept in a operating > > system. However I am no

[Qemu-devel] [PATCH 12/15] s390x: Adjust internal kvm code

2011-04-04 Thread Alexander Graf
We're now finally emulating an s390x CPU, so we can move quite some logic from the kvm code out into generic CPU code. This patch does this and adjusts the interfaces according to what the code around now expects to be able to call. Signed-off-by: Alexander Graf --- target-s390x/kvm.c | 60 ++

Re: [Qemu-devel] [PATCH v3 0/7] Let boards state maximum RAM limits in QEMUMachine struct

2011-04-04 Thread Peter Maydell
On 4 April 2011 15:53, Jes Sorensen wrote: > I understand that what you are proposing seems to work well enough for > your problem at hand. What I am saying is that adding a mechanism like > that, can cause problems for adding a more generic mechanism that > handles more advanced boards in the fut

Re: [Qemu-devel] [PATCH 4/5] sparc64: fix mmu context at trap levels above zero

2011-04-04 Thread Artyom Tarasenko
On Sat, May 22, 2010 at 12:52 PM, Igor V. Kovalenko wrote: > --- a/target-sparc/helper.c > +++ b/target-sparc/helper.c > @@ -572,6 +572,23 @@ static int get_physical_address(CPUState *env, > target_phys_addr_t *physical, >     /* ??? We treat everything as a small page, then explicitly flush >  

Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread Stefan Hajnoczi
On Mon, Apr 4, 2011 at 2:49 PM, Avi Kivity wrote: > On 04/04/2011 04:38 PM, Anthony Liguori wrote: >> >> On 04/04/2011 08:22 AM, Avi Kivity wrote: >>> >>> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: In order for media change to work with Linux host CD-ROM it is necessary to reope

Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread Avi Kivity
On 04/04/2011 06:09 PM, Stefan Hajnoczi wrote: On Mon, Apr 4, 2011 at 2:49 PM, Avi Kivity wrote: > On 04/04/2011 04:38 PM, Anthony Liguori wrote: >> >> On 04/04/2011 08:22 AM, Avi Kivity wrote: >>> >>> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: In order for media change to work

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Blue Swirl
On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity wrote: > On 04/04/2011 07:22 PM, Anthony Liguori wrote: >> >> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: >>> >>> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: Many PCI BARs that use the memory address space map a single MMIO

[Qemu-devel] Re: [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU

2011-04-04 Thread Alexander Graf
On 04/04/2011 01:09 PM, Peter Maydell wrote: CPU_QuadU isn't used on all targets, but there's no harm in defining the typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because softfloat-native doesn't have a float128 type. This avoids the need for every new target which uses CPU_Qu

Re: [Qemu-devel] [PATCH v3 0/7] Let boards state maximum RAM limits in QEMUMachine struct

2011-04-04 Thread Blue Swirl
On Mon, Apr 4, 2011 at 5:53 PM, Jes Sorensen wrote: > On 04/04/11 16:42, Peter Maydell wrote: >> On 4 April 2011 15:29, Jes Sorensen wrote: Yes, I agree, so we shouldn't try to specify some complicated set of static data that still won't be good enough. I'm trying to make it e

Re: [Qemu-devel] [PATCH v3 0/7] Let boards state maximum RAM limits in QEMUMachine struct

2011-04-04 Thread Peter Maydell
On 4 April 2011 15:29, Jes Sorensen wrote: > On 03/30/11 16:07, Peter Maydell wrote: >> On 30 March 2011 14:56, Anthony Liguori wrote: >>> On 03/30/2011 08:22 AM, Peter Maydell wrote: Not really, typically they're just filled up in some particular order (main RAM in one place and expans

Re: [Qemu-devel] [PATCH] ide: consolidate drive_get(IF_IDE)

2011-04-04 Thread Kevin Wolf
Am 03.04.2011 13:32, schrieb Isaku Yamahata: > factor out ide initialization to call drive_get(IF_IDE) > > Signed-off-by: Isaku Yamahata Thanks, applied to the block branch. Kevin

Re: [libvirt] [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread Blue Swirl
On Mon, Apr 4, 2011 at 5:43 PM, Anthony Liguori wrote: > On 04/04/2011 09:26 AM, Daniel P. Berrange wrote: >> >> On Mon, Apr 04, 2011 at 09:19:36AM -0500, Anthony Liguori wrote: >>> >>> On 04/04/2011 08:16 AM, Daniel P. Berrange wrote: That doesn't really have any impact. If a desktop us

[Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Michael S. Tsirkin
On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: > Many PCI BARs that use the memory address space map a single MMIO region into > the entire BAR range. Introduce an API pci_register_bar_simple() for that use > case, and convert all users where this can be done trivially. > > This will

Re: [Qemu-devel] [PATCH V1 6/8] Add measurement code to the BIOS

2011-04-04 Thread Stefan Berger
On 04/04/2011 12:57 AM, Kevin O'Connor wrote: On Wed, Mar 30, 2011 at 01:55:40PM -0400, Stefan Berger wrote: This patch adds invocactions of functions that measure various parts of the code and data through various parts of the BIOS code. It follows TCG specifications on what needs to be measure

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Avi Kivity
On 04/04/2011 07:22 PM, Anthony Liguori wrote: On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: Many PCI BARs that use the memory address space map a single MMIO region into the entire BAR range. Introduce an API pci_register_bar_sim

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Anthony Liguori
On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: Many PCI BARs that use the memory address space map a single MMIO region into the entire BAR range. Introduce an API pci_register_bar_simple() for that use case, and convert all users w

[Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Avi Kivity
On 04/04/2011 06:59 PM, Michael S. Tsirkin wrote: On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: > Many PCI BARs that use the memory address space map a single MMIO region into > the entire BAR range. Introduce an API pci_register_bar_simple() for that use > case, and convert al

Re: [Qemu-devel] [PATCH] docs/specs/fw_cfg.txt: Add fw_cfg documentation

2011-04-04 Thread Blue Swirl
On Mon, Apr 4, 2011 at 9:46 AM, Jordan Justen wrote: > This initial version covers the generic portions of fw_cfg and > the x86/x86-64 architecture specific portions of fw_cfg. > > Signed-off-by: Jordan Justen > --- >  docs/specs/fw_cfg.txt |  168 > ++

[Qemu-devel] [PATCH 07/10] hda-intel: convert to pci_register_bar_simple() (partial)

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/lsi53c895a.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index e4b51a8..be4df58 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -2094,15 +2094,6 @@ static void lsi_ram_mapfunc(PCIDevi

[Qemu-devel] Re: [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU

2011-04-04 Thread Peter Maydell
On 4 April 2011 15:47, Alexander Graf wrote: > On 04/04/2011 01:09 PM, Peter Maydell wrote: >> >> CPU_QuadU isn't used on all targets, but there's no harm in defining the >> typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because >> softfloat-native doesn't have a float128 type. T

[Qemu-devel] [PATCH 10/10] wdt_i6300esb: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/wdt_i6300esb.c | 42 +++--- 1 files changed, 15 insertions(+), 27 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 4a7fba7..0791721 100644 --- a/hw/wdt_i6300esb.c +++ b/hw/wdt_i6300esb.c @@ -355,31 +355,6

[Qemu-devel] [PATCH 06/10] hda-intel: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/intel-hda.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index b0b1d12..7f83745 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -1109,14 +1109,6 @@ static CPUWriteMemoryFunc * const intel_

[Qemu-devel] [PATCH 02/10] rtl8139: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/rtl8139.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index d545933..822038d 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -3341,14 +3341,6 @@ static const VMStateDescription vmstate_rtl8139 = {

[Qemu-devel] [PATCH 01/10] pci: add pci_register_bar_simple() API

2011-04-04 Thread Avi Kivity
This is similar to pci_register_bar(), but automatically registers a single memory region spanning the entire BAR. Signed-off-by: Avi Kivity --- hw/pci.c | 17 + hw/pci.h |3 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6b577

[Qemu-devel] [PATCH 08/10] pcnet-pci: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pcnet-pci.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 339a401..4ac3e32 100644 --- a/hw/pcnet-pci.c +++ b/hw/pcnet-pci.c @@ -214,19 +214,6 @@ static CPUReadMemoryFunc * const pcnet

[Qemu-devel] [PATCH 04/10] eepro100: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/eepro100.c | 43 +-- 1 files changed, 13 insertions(+), 30 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index edf48f6..f2505e4 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -228,7 +228,7 @@ typedef struct {

[Qemu-devel] [PATCH 03/10] cirrus-vga: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 2724f7b..ff78335 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3076,15 +3076,6 @@ static void cirrus_pci_lfb_map(PCI

[Qemu-devel] [PATCH 05/10] ich/ahci: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ide/ahci.c |9 - hw/ide/ahci.h |3 --- hw/ide/ich.c |3 +-- 3 files changed, 1 insertions(+), 14 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 98bdf70..c6e0c77 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1129,15 +1129,6

[Qemu-devel] [PATCH 09/10] usb-ohci: convert to pci_register_bar_simple()

2011-04-04 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/usb-ohci.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index d2b14f7..73d47b8 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -1713,13 +1713,6 @@ typedef struct { OHCIState state; } OHCIPC

[Qemu-devel] [PATCH 00/10] pci: pci_register_bar_simple

2011-04-04 Thread Avi Kivity
Many PCI BARs that use the memory address space map a single MMIO region into the entire BAR range. Introduce an API pci_register_bar_simple() for that use case, and convert all users where this can be done trivially. This will reduce the work required to introduce a PCI memory API; it's also a n

Re: [Qemu-devel] [PATCH v3 0/7] Let boards state maximum RAM limits in QEMUMachine struct

2011-04-04 Thread Jes Sorensen
On 04/04/11 16:42, Peter Maydell wrote: > On 4 April 2011 15:29, Jes Sorensen wrote: >>> Yes, I agree, so we shouldn't try to specify some complicated >>> set of static data that still won't be good enough. >>> >>> I'm trying to make it easy for boards to avoid crashing horribly >>> when the user

Re: [libvirt] [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-04 Thread Anthony Liguori
On 04/04/2011 09:26 AM, Daniel P. Berrange wrote: On Mon, Apr 04, 2011 at 09:19:36AM -0500, Anthony Liguori wrote: On 04/04/2011 08:16 AM, Daniel P. Berrange wrote: That doesn't really have any impact. If a desktop user is logged in, udev may change the ownership to match that user, but if they

[Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable

2011-04-04 Thread Alexander Graf
On 04/03/2011 06:21 PM, Stefan Weil wrote: cppcheck reports this error: hw/spapr_vscsi.c:274: error: Uninitialized variable: rc If llen == 0, rc was indeed used without being initialized. Signed-off-by: Stefan Weil --- hw/spapr_vscsi.c |2 +- 1 files changed, 1 insertions(+), 1 deletion

[Qemu-devel] [PATCH 10/15] s390x: helper functions for system emulation

2011-04-04 Thread Alexander Graf
When running system emulation, we need to transverse through the MMU and deliver interrupts according to the specification. This patch implements those two pieces and in addition adjusts the CPU initialization code to account for the new fields in CPUState. Signed-off-by: Alexander Graf --- v1

Re: [Qemu-devel] [PATCH V1 5/8] Support for BIOS interrupt handler

2011-04-04 Thread Stefan Berger
On 04/04/2011 12:30 AM, Kevin O'Connor wrote: On Wed, Mar 30, 2011 at 01:55:39PM -0400, Stefan Berger wrote: This patch implements the TCG BIOS interrupt handler 1ah. It is for example used by trusted grub. [...] +/*** + Calculat

[Qemu-devel] [PATCH 09/15] s390x: Prepare cpu.h for emulation

2011-04-04 Thread Alexander Graf
We need to add some more logic to the CPU description to leverage emulation of an s390x CPU. This patch adds all the required helpers, fields in CPUState and constant definitions required for user and system emulation. Signed-off-by: Alexander Graf --- v1 -> v2: - remove FPReg definition -

[Qemu-devel] [PATCH 03/15] s390x: s390x-linux-user support

2011-04-04 Thread Alexander Graf
From: Ulrich Hecht This patch adds support for running s390x binaries in the linux-user emulation code. Signed-off-by: Ulrich Hecht Signed-off-by: Alexander Graf --- v1 -> v2: - always set 64bit flag for s390x binaries in elf loader - remove redundant EXECUTE_SVC - advance psw.addr in

Re: [Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-04-04 Thread Stefan Berger
On 04/04/2011 12:17 AM, Kevin O'Connor wrote: On Wed, Mar 30, 2011 at 01:55:36PM -0400, Stefan Berger wrote: This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connect

[Qemu-devel] [PATCH 08/15] s390x: virtio machine storage keys

2011-04-04 Thread Alexander Graf
For emulation (and migration) we need to know about the guest's storage keys. These are separate from actual RAM contents, so we need to allocate them in parallel to RAM. While touching the file, this patch also adjusts the hypercall function to a new syntax that aligns better with tcg emulated co

Re: [Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions

2011-04-04 Thread Stefan Berger
On 04/04/2011 12:14 AM, Kevin O'Connor wrote: Hi Stefan, I haven't had a chance to fully review, but I do have some comments. Thanks. I can post a v2 as a followup to your changes. On Wed, Mar 30, 2011 at 01:55:37PM -0400, Stefan Berger wrote: [...] - a utility function called mssleep is adde

[Qemu-devel] [PATCH 14/15] s390x: build s390x by default

2011-04-04 Thread Alexander Graf
This patch enables building of s390x-softmmu and s390x-linux-user targets by default. Signed-off-by: Alexander Graf --- configure|2 ++ default-configs/s390x-linux-user.mak |1 + 2 files changed, 3 insertions(+), 0 deletions(-) create mode 100644 default-conf

[Qemu-devel] [PATCH 00/15] s390x emulation support v3

2011-04-04 Thread Alexander Graf
We've had support for running s390x guests with KVM for a while now. This patch set also enables support for running s390x guests in system as well as linux-user mode in emulation! Within this scope, I again want to stress that this is _not_ supposed to replace Hercules - the s390 emulator - in an

[Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-04 Thread Alexander Graf
With the s390x target we use the deposit instruction to store 32bit values into 64bit registers without clobbering the upper 32 bits. This specific operation can be optimized slightly by using the ext operation instead of an explicit and in the deposit instruction. This patch adds that special cas

[Qemu-devel] [PATCH 04/15] linux-user: define a couple of syscalls for non-uid16 targets

2011-04-04 Thread Alexander Graf
From: Ulrich Hecht Quite a number of syscalls are only defined on systems with USE_UID16 defined; this patch defines them on other systems as well. Fixes a large number of uid/gid-related testcases on the s390x target (and most likely on other targets as well) Signed-off-by: Ulrich Hecht ---

[Qemu-devel] [PATCH 02/15] s390x: set alignment for long to 8

2011-04-04 Thread Alexander Graf
The alignment for longs on s390x is 8. That's the only place where it differs from the default alignments found in configure already. The example alignment program from Laurent printed the following on a real s390x: alignof(short) 2 alignof(int) 4 alignof(long) 8 alignof(long long) 8 Sign

  1   2   >