Re: [Qemu-devel] [PATCH] ehci: Fix interrupt packet MULT handling

2012-09-24 Thread Gerd Hoffmann
Hi, Missing braces, please use checkpatch.pl. Oops, Gerd since this is already in your tree, can you fix this, or do you want a new fixed version ? I've already fixed it. You can wire checkpatch.pl into the git commit hook to avoid those slip through unnoticed. cheers, Gerd

[Qemu-devel] [Bug 1055090] [NEW] esp error: NetBSD/sparc on qemu-system-sparc

2012-09-24 Thread Ryo ONODERA
Public bug reported: On qemu-1.2.0's qemu-system-sparc, NetBSD/sparc (32bit) 5.1.2 and 6.0_RC2 generates the following NetBSD's errors. esp0: !TC on DATA XFER [intr 18, stat 82, step 4] prevphase 2, resid 0 esp0: !TC on DATA XFER [intr 10, stat 83, step 0] prevphase 2, resid 0 On qemu-0.15.1's

[Qemu-devel] [Bug 1054831] [NEW] qemu-user-static for sparc32plus : bash: fork: Invalid argument

2012-09-24 Thread Erik de Castro Lopo
Public bug reported: On Debian x86-64 host system I setup a sparc chroot using: host $ mkdir sparc host $ sudo debootstrap --arch=sparc --foreign wheezy sparc http://ftp.au.debian.org/debian host $ sudo cp ~/Git/qemu/sparc32plus-linux-user/qemu-sparc32plus

Re: [Qemu-devel] [Qemu-discuss] Qemu snapshot mode

2012-09-24 Thread xuanmao_001
Hi, all I want to change the path of temporary snapshot file. Can you gei me some ideas, or tell me which file will write the temporary snapshot file in qemu source code. thanks. xuanmao_001 From: Dunrong Huang Date: 2012-09-06 18:00 To: xuanmao_001 CC: qemu-discuss; Jakob Bohm Subject:

Re: [Qemu-devel] [PATCH 2/3] qmp: dump-guest-memory: don't spin if non-blocking fd would block

2012-09-24 Thread Wen Congyang
At 09/22/2012 01:07 AM, Luiz Capitulino Wrote: fd_write_vmcore() will indefinitely spin for a non-blocking file-descriptor that would block. However, if the fd is non-blocking, how does it make sense to spin? Change this behavior to return an error instead. Note that this can only happen

Re: [Qemu-devel] [RFC PATCH v3 20/19][SeaBIOS] alternative: Use paravirt interface for pci windows

2012-09-24 Thread Wen Congyang
At 09/21/2012 07:20 PM, Vasilis Liaskovitis Wrote: Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based on initial memory and hotplug-able dimms. This patch can't be applied if

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-24 Thread liu ping fan
On Wed, Sep 19, 2012 at 5:50 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 12:34 PM, Jan Kiszka wrote: What about the following: What we really need to support in practice is MMIO access triggers RAM access of device model. Scenarios where a device access triggers another MMIO access

Re: [Qemu-devel] [RFC PATCH v3 19/19][SeaBIOS] Calculate pcimem_start and pcimem64_start from SRAT entries

2012-09-24 Thread Wen Congyang
At 09/21/2012 07:17 PM, Vasilis Liaskovitis Wrote: pcimem_start and pcimem64_start are adjusted from srat entries. For this reason, paravirt info (NUMA SRAT entries and number of cpus) need to be read before pci_setup. Imho, this is an ugly code change since SRAT bios tables and number of

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-24 Thread Avi Kivity
On 09/24/2012 08:33 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:50 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 12:34 PM, Jan Kiszka wrote: What about the following: What we really need to support in practice is MMIO access triggers RAM access of device model. Scenarios

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-24 Thread Kevin Wolf
Am 22.09.2012 20:53, schrieb Stefan Weil: Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: [snip] offset_end = (offset_end + 511) 9; -bdrv_write(pfl-bs, offset, pfl-storage + (offset 9), -

Re: [Qemu-devel] ARM Cortex-R4 support ?

2012-09-24 Thread Giancarlo ASNAGHI
Hi Andreas, thanks to share the status. I've doubts that some of my collegues may helps here, because we are focusing on the uclinux kernel and user side. Anyway I check and I let you know. Best Regards Giancarlo -Original Message- From: Andreas Färber [mailto:afaer...@suse.de]

Re: [Qemu-devel] [PATCH 0/3] add pc-1.3, fix xhci comat, ivshmem 64bit option

2012-09-24 Thread Gerd Hoffmann
On 09/13/12 11:07, Gerd Hoffmann wrote: Small series with tree patches, the first one adds a new machine type for the upcoming 1.3 release so we can add compat properties as needed, the other two patches actually add compat properties. The xhci one is a pure compat fix which turns off

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-24 Thread liu ping fan
On Mon, Sep 24, 2012 at 3:44 PM, Avi Kivity a...@redhat.com wrote: On 09/24/2012 08:33 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:50 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 12:34 PM, Jan Kiszka wrote: What about the following: What we really need to support in

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-24 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 22.09.2012 20:53, schrieb Stefan Weil: Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: [snip] offset_end = (offset_end + 511) 9; -bdrv_write(pfl-bs, offset, pfl-storage +

[Qemu-devel] [PATCH v8 0/6] GlusterFS support in QEMU - v8

2012-09-24 Thread Bharata B Rao
Hi, This is v8 of the patchset to support GlusterFS backend from QEMU. I will follow up this post by v9 that will use a generic URI parsing code borrowed from libxml2 and libvirt. In case there is no agreement on using that generic URI parsing code in QEMU, I would like v8 to be considered for

[Qemu-devel] [PATCH v8 1/6] sockets: publish dummy_opts

2012-09-24 Thread Bharata B Rao
sockets: publish dummy_opts From: Paolo Bonzini pbonz...@redhat.com This is needed so that we can set up a QemuOpts instance from QMP parameters. The way to go here is to and move qemu-sockets.c away from QemuOpts and use Laszlo's QemuOptsVisitor whenever *_opts functions are called now. This

[Qemu-devel] [PATCH v8 2/6] sockets: Make port specification optional in inet_parse

2012-09-24 Thread Bharata B Rao
sockets: Make port specification optional in inet_parse From: Bharata B Rao bhar...@linux.vnet.ibm.com Change inet_parse() to work without explicit port specification. Add a default_port argument to be used when port isn't specified. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH v8 3/6] sockets: Make inet_parse() non static.

2012-09-24 Thread Bharata B Rao
sockets: Make inet_parse() non static. From: Bharata B Rao bhar...@linux.vnet.ibm.com Make inet_parse() non-static so that other subsystems like gluster can use it to parse inet addresses. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- qemu-sockets.c |2 +- qemu_socket.h |

Re: [Qemu-devel] [PATCH 6/9] mm: compaction: Acquire the zone-lock as late as possible

2012-09-24 Thread Mel Gorman
On Fri, Sep 21, 2012 at 02:35:57PM -0700, Andrew Morton wrote: On Fri, 21 Sep 2012 11:46:20 +0100 Mel Gorman mgor...@suse.de wrote: Compactions free scanner acquires the zone-lock when checking for PageBuddy pages and isolating them. It does this even if there are no PageBuddy pages in

[Qemu-devel] [PATCH v8 4/6] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count

2012-09-24 Thread Bharata B Rao
aio: Fix qemu_aio_wait() to maintain correct walking_handlers count From: Paolo Bonzini pbonz...@redhat.com Fix qemu_aio_wait() to ensure that registered aio handlers don't get deleted when they are still active. This is ensured by maintaning the right count of walking_handlers. Signed-off-by:

[Qemu-devel] [PATCH v8 5/6] configure: Add a config option for GlusterFS as block backend

2012-09-24 Thread Bharata B Rao
configure: Add a config option for GlusterFS as block backend From: Bharata B Rao bhar...@linux.vnet.ibm.com GlusterFS support in QEMU depends on libgfapi, libgfrpc and libgfxdr provided by GlusterFS. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- configure | 35

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-24 Thread Kevin Wolf
Am 24.09.2012 10:41, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 22.09.2012 20:53, schrieb Stefan Weil: Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: [snip] offset_end = (offset_end + 511) 9; -

[Qemu-devel] [PATCH v8 6/6] block: Support GlusterFS as a QEMU block backend.

2012-09-24 Thread Bharata B Rao
block: Support GlusterFS as a QEMU block backend. From: Bharata B Rao bhar...@linux.vnet.ibm.com This patch adds gluster as the new block backend in QEMU. This gives QEMU the ability to boot VM images from gluster volumes. Its already possible to boot from VM images on gluster volumes using FUSE

[Qemu-devel] [PATCH v9 0/4] GlusterFS support in QEMU - v9

2012-09-24 Thread Bharata B Rao
Hi, This is v9 of the patchset to support GlusterFS backend from QEMU. Changes in v9 - - Drop all inet_parse related patches from the patchset. - Include generic URI parsing code from libxml2 and libvirt in QEMU and use that in gluster block backend instead of private URI parsing

[Qemu-devel] [PATCH v9 1/4] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count

2012-09-24 Thread Bharata B Rao
aio: Fix qemu_aio_wait() to maintain correct walking_handlers count From: Paolo Bonzini pbonz...@redhat.com Fix qemu_aio_wait() to ensure that registered aio handlers don't get deleted when they are still active. This is ensured by maintaning the right count of walking_handlers. Signed-off-by:

[Qemu-devel] [PATCH v9 3/4] configure: Add a config option for GlusterFS as block backend

2012-09-24 Thread Bharata B Rao
configure: Add a config option for GlusterFS as block backend From: Bharata B Rao bhar...@linux.vnet.ibm.com GlusterFS support in QEMU depends on libgfapi, libgfrpc and libgfxdr provided by GlusterFS. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- configure | 35

[Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-24 Thread Bharata B Rao
block: Support GlusterFS as a QEMU block backend. From: Bharata B Rao bhar...@linux.vnet.ibm.com This patch adds gluster as the new block backend in QEMU. This gives QEMU the ability to boot VM images from gluster volumes. Its already possible to boot from VM images on gluster volumes using FUSE

[Qemu-devel] [PATCH v7 00/13] Ehnahced SSI bus support + M25P80 SPI flash + Xilinx SPI controller

2012-09-24 Thread Peter A. G. Crosthwaite
This series reworks the SSI bus framework for SPI and add some new SPI controllers and devices: Patches 1-4 reworks SSI to add chip-select support to SPI devices and allow for multiple SPI devices attached to the same bus. Patches 5-6 fix the SPI setup in the stellaris machine model. Patch 7

[Qemu-devel] [PATCH v7 01/13] ssi: Support for multiple attached devices

2012-09-24 Thread Peter A. G. Crosthwaite
Removed assertion that only one device is attached to the SSI bus. When multiple devices are attached, all slaves have their transfer function called for transfers. Each device is responsible for knowing whether or not its CS is active, and if not returning 0. The returned data is the logical or

[Qemu-devel] [PATCH v7 02/13] ssi: Implemented CS behaviour

2012-09-24 Thread Peter A. G. Crosthwaite
Added default CS behaviour for SSI slaves. SSI devices can set a property to enable CS behaviour which will create a GPIO on the device which is the CS. Tristating of the bus on SSI transfers is implemented. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- Changed since

[Qemu-devel] [PATCH v7 03/13] ssi: Added create_slave_no_init()

2012-09-24 Thread Peter A. G. Crosthwaite
Slave creation function that can be used to create an SSI slave without qdev_init() being called. This give machine models a chance to set properties. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- hw/ssi.c |9 +++-- hw/ssi.h |1 + 2 files changed, 8

[Qemu-devel] [PATCH v7 06/13] stellaris: Removed SSI mux

2012-09-24 Thread Peter A. G. Crosthwaite
Removed the explicit SSI mux and wired the CS line directly up to the SSI devices. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- hw/ssd0323.c |1 + hw/ssi-sd.c|1 + hw/stellaris.c | 98 ++-- 3 files

[Qemu-devel] [PATCH v7 09/13] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-09-24 Thread Peter A. G. Crosthwaite
Device model for xilinx XPS SPI controller (v2.0) Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- changed from v4 (Near total rewrite): removed timer delay. This was innacturate anyways removed for simlicity. updated for new SSI interface. factored out txrx fifos using

[Qemu-devel] [PATCH v7 12/13] xilinx_zynq: Added SPI controllers + flashes

2012-09-24 Thread Peter A. G. Crosthwaite
Added the two SPI controllers to the zynq machine model. Attached two SPI flash devices to each controller. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- hw/xilinx_zynq.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-24 Thread Paolo Bonzini
+static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename) +{ +URI *uri; +QueryParams *qp = NULL; +bool is_unix = false; +int ret = 0; +char *unescape_str = NULL; + +uri = uri_parse(filename); +if (!uri) { +return -EINVAL; +} +

Re: [Qemu-devel] [PATCH v7 02/13] ssi: Implemented CS behaviour

2012-09-24 Thread Peter Maydell
On 24 September 2012 10:18, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: @@ -296,10 +297,13 @@ static void ssd0323_save(QEMUFile *f, void *opaque) qemu_put_be32(f, s-remap); qemu_put_be32(f, s-mode); qemu_put_buffer(f, s-framebuffer, sizeof(s-framebuffer)); +

[Qemu-devel] [PATCH v7 11/13] xilinx_spips: Xilinx Zynq SPI cntrlr device model

2012-09-24 Thread Peter A. G. Crosthwaite
Added device model for the Xilinx Zynq SPI controller (SPIPS). Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- Changed from v6: Addressed Blue Swirl review s/interupt/interrupt s/defintion/definition constified TypeInfo hw/arm/Makefile.objs |1 + hw/xilinx_spips.c

Re: [Qemu-devel] [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

2012-09-24 Thread Mel Gorman
On Fri, Sep 21, 2012 at 02:36:56PM -0700, Andrew Morton wrote: On Fri, 21 Sep 2012 11:46:22 +0100 Mel Gorman mgor...@suse.de wrote: When compaction was implemented it was known that scanning could potentially be excessive. The ideal was that a counter be maintained for each pageblock but

[Qemu-devel] [PATCH v7 07/13] hw: Added generic FIFO API.

2012-09-24 Thread Peter A. G. Crosthwaite
Added a FIFO API that can be used to create and operate byte FIFOs. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- hw/Makefile.objs |1 + hw/fifo.c| 78 ++ hw/fifo.h| 47

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-24 Thread Avi Kivity
On 09/24/2012 10:32 AM, liu ping fan wrote: On Mon, Sep 24, 2012 at 3:44 PM, Avi Kivity a...@redhat.com wrote: On 09/24/2012 08:33 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:50 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 12:34 PM, Jan Kiszka wrote: What about the following:

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-24 Thread Bharata B Rao
On Mon, Sep 24, 2012 at 05:26:53AM -0400, Paolo Bonzini wrote: +qp = query_params_parse(unescape_str); query_params_parse already does the unescaping. Hmm it failed to parse the options properly when I had an escape sequence, hence resorted to unescaping the query string manually. Look

Re: [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd

2012-09-24 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 1edeec5..c20a2fe 100644 --- a/migration.c +++ b/migration.c @@ -240,8

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Amos Kong
On 23/09/12 14:34, Orit Wasserman wrote: On 09/20/2012 06:16 PM, Amos Kong wrote: - Original Message - On 09/19/2012 11:31 AM, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that

Re: [Qemu-devel] EHCI USB regression in 1.2.0 - ehci_state_fetchqtd() asserting

2012-09-24 Thread Hans de Goede
Hi, On 09/23/2012 08:20 PM, Shawn Starr wrote: On Sunday, September 23, 2012 02:00:10 PM Shawn Starr wrote: On Sunday, September 23, 2012 12:03:28 PM Hans de Goede wrote: Hi, snip spicec is deprecated you really should be using remote-viewer instead. That will give you an option to select

[Qemu-devel] [PATCH v7 10/13] petalogix-ml605: added SPI controller with n25q128

2012-09-24 Thread Peter A. G. Crosthwaite
Added SPI controller to the reference design, with two n25q128 spi-flashes connected. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- Changed since v5: Removed redundant (char*) cast with qdev_get_prop_string hw/petalogix_ml605_mmu.c | 27 +++

Re: [Qemu-devel] EHCI USB regression in 1.2.0 - ehci_state_fetchqtd() asserting

2012-09-24 Thread Hans de Goede
Hi, On 09/23/2012 08:52 PM, Shawn Starr wrote: I see why there are USB errors, I am seeing corrupt video frames with webcam attached via spice-usbredirection, this is not seen with host-usb attachment. What errors exactly are you talking about I did not notice any error messages in your

[Qemu-devel] [PATCH v7 05/13] hw/stellaris: Removed gpio_out init array.

2012-09-24 Thread Peter A. G. Crosthwaite
stellaris_init() defines arrays of qemu_irq to decides what each of the GPIO pins are connected to. This is ok for inputs (as an input can only have one source) but is flawed for outputs as an output can connect to any number of sinks. Removed the gpio_out array completely and just replaced its

[Qemu-devel] [PATCH v7 13/13] MAINTAINERS: Added maintainerships for SSI

2012-09-24 Thread Peter A. G. Crosthwaite
Added maintainership for SSI, M25P80 and the Xilinx SPI controllers. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 61f8b45..0ebe247 100644 ---

Re: [Qemu-devel] [PATCH v7 04/13] qdev: allow multiple qdev_init_gpio_in() calls

2012-09-24 Thread Peter Maydell
On 24 September 2012 10:18, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: Allow multiple qdev_init_gpio_in() calls for the one device. The first call will define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be handled with different handlers. Needed when

Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-24 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: No need to add non blocking parameters to the blocking inet_connect add block parameter for inet_connect_opts instead of using QemuOpt block. Signed-off-by: Orit Wasserman owass...@redhat.com --- migration-tcp.c |2 +- nbd.c |2

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make

Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup

2012-09-24 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: Changes from v3: - add missing parenthesis QEMU_SOCKET_RC_INPROGRESS macro - remove block from dummy_opts - remove in_progress from external API (inet_connect_opts and inet_nonblocking_connect) - Allocate

Re: [Qemu-devel] directory hierarchy

2012-09-24 Thread Avi Kivity
On 09/23/2012 06:07 PM, Blue Swirl wrote: On Sun, Sep 23, 2012 at 8:25 AM, Avi Kivity a...@redhat.com wrote: On 09/22/2012 04:15 PM, Blue Swirl wrote: This could have nice cleanup effects though and for example enable generic 'info vmtree' to discover VA-PA mappings for any target

Re: [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd

2012-09-24 Thread Orit Wasserman
On 09/24/2012 11:45 AM, Markus Armbruster wrote: Orit Wasserman owass...@redhat.com writes: Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 1edeec5..c20a2fe 100644

[Qemu-devel] [PATCH v7 08/13] m25p80: Initial implementation of SPI flash device

2012-09-24 Thread Peter A. G. Crosthwaite
Added device model for m25p80 style SPI flash family. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- changed from v6: Addressed Blue Swirl review Constified TypeInfo Constified part_name string prop Added missing break s/assert(false)/abort() changed from v4: Added

[Qemu-devel] [PATCH v7 04/13] qdev: allow multiple qdev_init_gpio_in() calls

2012-09-24 Thread Peter A. G. Crosthwaite
Allow multiple qdev_init_gpio_in() calls for the one device. The first call will define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be handled with different handlers. Needed when two levels of the QOM class heirachy both define GPIO functionality, as a single GPIO handler with

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 12:10 PM, Michael S. Tsirkin wrote: On Sun, Sep 23, 2012 at 04:49:06PM +0200, Orit Wasserman wrote: diff --git a/qemu_socket.h b/qemu_socket.h index 3247fb7..da93509 100644 --- a/qemu_socket.h +++ b/qemu_socket.h @@ -38,20 +38,31 @@ void socket_set_block(int fd); void

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 12:05 PM, Amos Kong wrote: On 23/09/12 22:49, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not

Re: [Qemu-devel] [PATCH v7 02/13] ssi: Implemented CS behaviour

2012-09-24 Thread Peter Crosthwaite
On Mon, Sep 24, 2012 at 7:29 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 24 September 2012 10:18, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: @@ -296,10 +297,13 @@ static void ssd0323_save(QEMUFile *f, void *opaque) qemu_put_be32(f, s-remap);

Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

2012-09-24 Thread Richard W.M. Jones
On Mon, Sep 24, 2012 at 02:42:02PM +0530, Bharata B Rao wrote: qemu: URI parsing library From: Paolo Bonzini pbonz...@redhat.com Add a new URI parsing library to QEMU. The code has been borrowed from libxml2 and libvirt. Rather than duplicating the libxml2 code, I think it would be

Re: [Qemu-devel] [PATCH v7 04/13] qdev: allow multiple qdev_init_gpio_in() calls

2012-09-24 Thread Peter Crosthwaite
All changes made. Thanks Peter On Mon, Sep 24, 2012 at 7:53 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 24 September 2012 10:18, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: Allow multiple qdev_init_gpio_in() calls for the one device. The first call will define

Re: [Qemu-devel] RFC: NVRAM for pseries machine

2012-09-24 Thread Alexander Graf
On 21.09.2012, at 05:08, David Gibson wrote: Below is a patch which implements the (PAPR mandated) NVRAM for the pseries machine. It raises a couple of generic questions. First, this adds a new nvram machine option which is used to give a block device id to back the NVRAM so it is

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-24 Thread Alexander Graf
On 24.09.2012, at 02:31, David Gibson wrote: On Sat, Sep 22, 2012 at 01:31:08PM +, Blue Swirl wrote: On Fri, Sep 21, 2012 at 3:08 AM, David Gibson da...@gibson.dropbear.id.au wrote: Below is a patch which implements the (PAPR mandated) NVRAM for the pseries machine. It raises a couple

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 11:48 AM, Amos Kong wrote: On 23/09/12 14:34, Orit Wasserman wrote: On 09/20/2012 06:16 PM, Amos Kong wrote: - Original Message - On 09/19/2012 11:31 AM, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement -dimm command line option

2012-09-24 Thread Vasilis Liaskovitis
On Sat, Sep 22, 2012 at 01:46:57PM +, Blue Swirl wrote: On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: Example: -dimm id=dimm0,size=512M,node=0,populated=off There should not be a need to introduce a new top level option, instead you

Re: [Qemu-devel] [RFC PATCH v3 20/19][SeaBIOS] alternative: Use paravirt interface for pci windows

2012-09-24 Thread Vasilis Liaskovitis
On Mon, Sep 24, 2012 at 02:35:30PM +0800, Wen Congyang wrote: At 09/21/2012 07:20 PM, Vasilis Liaskovitis Wrote: Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based

Re: [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd

2012-09-24 Thread Paolo Bonzini
Il 24/09/2012 11:58, Orit Wasserman ha scritto: if (s-fd != -1) { +qemu_set_fd_handler2(s-fd, NULL, NULL, NULL, NULL); close(s-fd); s-fd = -1; } As far as I can see, qemu_set_fd_handler2() treats invalid file descriptor -1 just like any other.

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Amos Kong
On 23/09/12 22:49, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make

Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-24 Thread Paolo Bonzini
Il 24/09/2012 11:53, Markus Armbruster ha scritto: ongoing + * @errp: set in case of an error + **/ We usually tack function comments to the function definition, not the declaration. Matter of taste. I like it next to the definition, because that improves the comment's chances to get

Re: [Qemu-devel] [PATCH v7 02/13] ssi: Implemented CS behaviour

2012-09-24 Thread Peter Crosthwaite
On Mon, Sep 24, 2012 at 8:19 PM, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: On Mon, Sep 24, 2012 at 7:29 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 24 September 2012 10:18, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: @@ -296,10 +297,13 @@ static

Re: [Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-24 Thread Laurent Desnogues
On Sat, Sep 22, 2012 at 11:37 PM, Stefan Weil s...@weilnetz.de wrote: Am 14.09.2012 19:02, schrieb Stefan Weil: The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN when QEMU was configured with configure'

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-24 Thread Stefano Stabellini
On Fri, 21 Sep 2012, Gerd Hoffmann wrote: Hi, +case FB_ACQ_REQ: +fbdev_switch_acquire(); +redraw_screen++; Rather than introducing redraw_screen, I would just call vga_hw_invalidate instead here. It is always a win if we can avoid to introduce one more state

[Qemu-devel] [PATCH v5 0/4] non-blocking connect address handling cleanup

2012-09-24 Thread Orit Wasserman
Changes from v4: - Rename ConnectHandler to NonBlockingConnectHandler - move function comments to functions definitions - move connect_state allocation to outside of the loop - fix comments text Changes from v3: - add missing parenthesis

[Qemu-devel] [PATCH v5 4/4] Clear handler only for valid fd

2012-09-24 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 1edeec5..22a05c4 100644 --- a/migration.c +++ b/migration.c @@ -240,7 +240,9 @@ static int

Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

2012-09-24 Thread Paolo Bonzini
- Messaggio originale - Da: Richard W.M. Jones rjo...@redhat.com A: Bharata B Rao bhar...@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, Paolo Bonzini pbonz...@redhat.com, Kevin Wolf kw...@redhat.com, Avi Kivity a...@redhat.com, Anthony Liguori aligu...@us.ibm.com, Stefan Hajnoczi

[Qemu-devel] [PATCH v5 1/4] Refactor inet_connect_opts function

2012-09-24 Thread Orit Wasserman
From: Michael S. Tsirkin m...@redhat.com refactor address resolution code to fix nonblocking connect remove getnameinfo call Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com --- qemu-sockets.c | 148

[Qemu-devel] [PATCH v5 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_connect_nonblocking retry connection with a

[Qemu-devel] [PATCH v5 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
No need to add non blocking parameters to the blocking inet_connect add block parameter for inet_connect_opts instead of using QemuOpt block. Signed-off-by: Orit Wasserman owass...@redhat.com --- migration-tcp.c |2 +- nbd.c |2 +- qemu-char.c |2 +- qemu-sockets.c |

[Qemu-devel] [PATCH] linux-user: SIGSEGV protection on host/guest signal masks

2012-09-24 Thread Alex Barcelo
There are some situations where the guest application changes the SIGSEGV and messes with qemu-user way of handling self-modifying code. In case of qemu-system, this happens. Emulation of qemu-system inside qemu-user doesn't work because of this. This patch doesn't aim to do a complete signal

[Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-24 Thread Gerd Hoffmann
Hi, Two patches, first split up serial.c a bit, then actually add the pci-based serial device. cheers, Gerd Gerd Hoffmann (2): serial: split serial.c serial: add pci variant default-configs/pci.mak |2 + docs/pciserial.inf | 96 +++

[Qemu-devel] [PATCH 1/2] serial: split serial.c

2012-09-24 Thread Gerd Hoffmann
Split serial.c into serial.c, serial.h and serial-isa.c. While being at creating a serial.h header file move the serial prototypes from pc.h to the new serial.h. The latter leads to s/pc.h/serial.h/ in tons of boards which just want the serial bits from pc.h Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 2/2] serial: add pci variant

2012-09-24 Thread Gerd Hoffmann
So we get a hot-pluggable 16550 uart. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- default-configs/pci.mak |2 + docs/pciserial.inf | 96 hw/Makefile.objs|1 + hw/pci_ids.h|1 + hw/serial-pci.c |

[Qemu-devel] KVM call agenda for September 25th

2012-09-24 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH] linux-user: SIGSEGV protection on host/guest signal masks

2012-09-24 Thread Alex Barcelo
Not related to this patch submission, but maybe interesting: I have been testing qemu-system inside qemu-user, and (once this patch is applied) the combination works and is capable to run a minimal linux (one that I found on qemu site for testing purposes). Awfully slow, and with lots of clock

[Qemu-devel] linux aio and cache mode

2012-09-24 Thread ching
Hi all, My host is qemu-1.1.1 and x64 kernel 3.5.4. The guest is using aio=native I am trying to use unsafe cache mode to boost i/o performance. After googling a while, there are some old web page telling that linux native aio do not use host cache.

Re: [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd

2012-09-24 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 24/09/2012 11:58, Orit Wasserman ha scritto: if (s-fd != -1) { +qemu_set_fd_handler2(s-fd, NULL, NULL, NULL, NULL); close(s-fd); s-fd = -1; } As far as I can see, qemu_set_fd_handler2() treats invalid

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Amos Kong
- Original Message - On 09/24/2012 11:48 AM, Amos Kong wrote: On 23/09/12 14:34, Orit Wasserman wrote: On 09/20/2012 06:16 PM, Amos Kong wrote: - Original Message - On 09/19/2012 11:31 AM, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give

Re: [Qemu-devel] KVM call agenda for September 25th

2012-09-24 Thread Paolo Bonzini
Il 24/09/2012 13:28, Juan Quintela ha scritto: Hi Please send in any agenda items you are interested in covering. URI parsing library for glusterfs: libxml2 vs. in-tree fork of the same code. Paolo

Re: [Qemu-devel] [PATCH] New syscalls to the seccomp whitelist

2012-09-24 Thread Eduardo Otubo
Anyone interested in taking a look at this piece of code? Thanks! On Fri, Sep 21, 2012 at 09:40:33AM -0300, Eduardo Otubo wrote: Seccomp syscall whitelist updated after tests running qemu under libvirt. Reference to the bug - https://bugzilla.redhat.com/show_bug.cgi?id=855162 Signed-off-by:

Re: [Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-24 Thread Stefan Weil
Am 24.09.2012 12:57, schrieb Laurent Desnogues: On Sat, Sep 22, 2012 at 11:37 PM, Stefan Weils...@weilnetz.de wrote: Am 14.09.2012 19:02, schrieb Stefan Weil: The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN

Re: [Qemu-devel] [PATCH] linux-user: SIGSEGV protection on host/guest signal masks

2012-09-24 Thread Peter Maydell
On 24 September 2012 12:23, Alex Barcelo abarc...@ac.upc.edu wrote: There are some situations where the guest application changes the SIGSEGV and messes with qemu-user way of handling self-modifying code. In case of qemu-system, this happens. Emulation of qemu-system inside qemu-user

Re: [Qemu-devel] linux aio and cache mode

2012-09-24 Thread Kevin Wolf
Am 24.09.2012 13:32, schrieb ching: Hi all, My host is qemu-1.1.1 and x64 kernel 3.5.4. The guest is using aio=native I am trying to use unsafe cache mode to boost i/o performance. aio=native requires the image to be opened with O_DIRECT, i.e. cache=none or cache=directsync. If you specify

Re: [Qemu-devel] RFC: target-ppc savevm fixup, cleanup and conversion to VMState

2012-09-24 Thread Alexander Graf
On 21.09.2012, at 06:03, David Gibson wrote: Hi Alex, Juan, I know Juan has an outstanding patch that converts target-ppc to use the new VMStateDescription approach for savevm at http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg00532.html Before I noticed that patch was out

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-24 Thread Gerd Hoffmann
On 09/24/12 13:06, Stefano Stabellini wrote: On Fri, 21 Sep 2012, Gerd Hoffmann wrote: Hi, +case FB_ACQ_REQ: +fbdev_switch_acquire(); +redraw_screen++; Rather than introducing redraw_screen, I would just call vga_hw_invalidate instead here. It is always a win if we

Re: [Qemu-devel] [PATCH v5 00/17] Allow changing of Hypervisor CPUIDs.

2012-09-24 Thread Don Slutz
On 09/22/12 09:18, Blue Swirl wrote: On Sat, Sep 22, 2012 at 12:13 AM, Don Slutz d...@cloudswitch.com wrote: Also known as Paravirtualization CPUIDs. This is primarily done so that the guest will think it is running under vmware when hypervisor-vendor=vmware is specified as a property of a

Re: [Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-24 Thread Peter Maydell
On 23 September 2012 17:33, Blue Swirl blauwir...@gmail.com wrote: Avoid this warning: CCarm-softmmu/hw/arm/../arm_gic.o /src/qemu/hw/arm/../arm_gic.c:432:17: error: implicit truncation from 'unsigned int' to bitfield changes value from 4294967040 to 0 [-Werror,-Wconstant-conversion]

Re: [Qemu-devel] [PATCH 2/3] qmp: dump-guest-memory: don't spin if non-blocking fd would block

2012-09-24 Thread Luiz Capitulino
On Mon, 24 Sep 2012 14:27:17 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 09/22/2012 01:07 AM, Luiz Capitulino Wrote: fd_write_vmcore() will indefinitely spin for a non-blocking file-descriptor that would block. However, if the fd is non-blocking, how does it make sense to spin?

Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 12:07 PM, Paolo Bonzini wrote: Il 24/09/2012 11:53, Markus Armbruster ha scritto: ongoing + * @errp: set in case of an error + **/ We usually tack function comments to the function definition, not the declaration. Matter of taste. I like it next to the definition, because

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-24 Thread David Gibson
On Mon, Sep 24, 2012 at 12:36:33PM +0200, Alexander Graf wrote: On 21.09.2012, at 05:08, David Gibson wrote: [snip] +void spapr_create_nvram(sPAPREnvironment *spapr) +{ +QemuOpts *machine_opts; +DeviceState *dev; + +dev = qdev_create(spapr-vio_bus-bus, spapr-nvram); +

Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-24 Thread Paolo Bonzini
Il 24/09/2012 15:37, Orit Wasserman ha scritto: We usually tack function comments to the function definition, not the declaration. Matter of taste. I like it next to the definition, because that improves the comment's chances to get updated along with the function. Not necessarily,

  1   2   3   >