Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-03-10 Thread Wen Congyang
On 03/11/2015 02:49 PM, Fam Zheng wrote: > On Wed, 03/11 14:44, Wen Congyang wrote: >> On 03/03/2015 03:59 PM, Fam Zheng wrote: >>> On Tue, 03/03 15:53, Wen Congyang wrote: I test qcow2_make_empty()'s performance. The result shows that it may take about 100ms(normal sata disk). It is not

[Qemu-devel] [PATCH] acpi: specify format for build_append_namestring

2015-03-10 Thread Michael S. Tsirkin
Will catch users if we misused it. Signed-off-by: Michael S. Tsirkin --- hw/acpi/aml-build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index ace180b..6242908 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -141,6 +141,7 @@ build_a

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-10 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 02:47:47PM +0800, Fam Zheng wrote: > On Wed, 03/11 07:19, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2015 at 04:29:30PM +1030, Rusty Russell wrote: > > > The virtio 'used' ring describes descriptors which have been used. It > > > also says how many bytes have been writte

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-03-10 Thread Fam Zheng
On Wed, 03/11 14:44, Wen Congyang wrote: > On 03/03/2015 03:59 PM, Fam Zheng wrote: > > On Tue, 03/03 15:53, Wen Congyang wrote: > >> I test qcow2_make_empty()'s performance. The result shows that it may > >> take about 100ms(normal sata disk). It is not acceptable for COLO. So > >> I think disk bu

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: fix length calculations for write operations.

2015-03-10 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 04:29:32PM +1030, Rusty Russell wrote: > We only fill in the 'req->qiov.size' bytes on a (successful) read, > not on a write. > > Signed-off-by: Rusty Russell > --- > hw/block/virtio-blk.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-10 Thread Fam Zheng
On Wed, 03/11 07:19, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 04:29:30PM +1030, Rusty Russell wrote: > > The virtio 'used' ring describes descriptors which have been used. It > > also says how many bytes have been written to the ring. For some cases, > > this value is ignored by Linux

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-03-10 Thread Wen Congyang
On 03/03/2015 03:59 PM, Fam Zheng wrote: > On Tue, 03/03 15:53, Wen Congyang wrote: >> I test qcow2_make_empty()'s performance. The result shows that it may >> take about 100ms(normal sata disk). It is not acceptable for COLO. So >> I think disk buff is necessary(just use it to replace qcow2). > >

[Qemu-devel] [PATCH 1/3] linux-headers: Sync vfio.h

2015-03-10 Thread Gavin Shan
The patch synchronizes vfio.h with the kernel to support EEH error injection. Signed-off-by: Gavin Shan --- linux-headers/linux/vfio.h | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h in

[Qemu-devel] [PATCH 0/3] Support EEH Error Injection

2015-03-10 Thread Gavin Shan
The patchset depends on the corresponding host kernel changes: https://patchwork.ozlabs.org/patch/448824/ https://patchwork.ozlabs.org/patch/448823/ According to PAPR specification 2.7, there're 3 RTAS calls relevent to error injection: "ibm,open-errinjct", "ibm,close-errinjct", "ibm,errinjct". T

[Qemu-devel] [PATCH 3/3] sPAPR: Support RTAS call ibm,errinjct

2015-03-10 Thread Gavin Shan
The patch supports RTAS call "ibm,errinjct" to allow injecting EEH errors to VFIO PCI devices. The implementation is similiar to EEH support for VFIO PCI devices: The RTAS request is captured by QEMU and routed to sPAPRPHBClass::eeh_error_inject() where the request is translated to VFIO container I

[Qemu-devel] [PATCH 2/3] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-03-10 Thread Gavin Shan
The patch supports RTAS calls "ibm,{open,close}-errinjct" to manupliate the token, which is passed to RTAS call "ibm,errinjct" to indicate the valid context for error injection. Each VM is permitted to have only one token at once and we simply have one random number for that. Signed-off-by: Gavin

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-10 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 04:29:30PM +1030, Rusty Russell wrote: > The virtio 'used' ring describes descriptors which have been used. It > also says how many bytes have been written to the ring. For some cases, > this value is ignored by Linux guests, thus errors have not been noticed. > I was work

Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-03-10 Thread Xiaodong Gong
2015年3月8日 18:53于 "Philipp Hahn" 写道: > > Hello, > > On 08.03.2015 02:53, Xiaodong Gong wrote: > > the encoding type of parent location is must be utf 8,utf16e,according > > to the draft > > Yes, the SPEC for VPC/VHD specifies the character encoding to use, which > is good for being portable. > > > a

[Qemu-devel] [PATCH 3/3] sPAPR: Reenable EEH functionality on reboot

2015-03-10 Thread Gavin Shan
When rebooting the guest, some PEs might be in frozen state. The contained PCI devices won't work properly if their frozen states aren't cleared in time. One case running into this situation would be maximal EEH error times encountered in the guest. The patch reenables the EEH functinality on PEs

[Qemu-devel] [PATCH 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-10 Thread Gavin Shan
The PCI device MSIx table is cleaned out in hardware after EEH PE reset. However, we still hold the stale MSIx entries in QEMU, which should be cleared accordingly. Otherwise, we will run into another (recursive) EEH error and the PCI devices contained in the PE have to be offlined exceptionally.

[Qemu-devel] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-10 Thread Gavin Shan
When Linux guest recovers from EEH error on the following Emulex adapter, the MSIx interrupts are disabled and the INTx emulation is enabled. One INTx interrupt is injected to the guest by host because of detected pending INTx interrupts on the adapter. QEMU disables mmap'ed BAR regions and starts

[Qemu-devel] [PATCH 2/2] virtio-blk: fix length calculations for write operations.

2015-03-10 Thread Rusty Russell
We only fill in the 'req->qiov.size' bytes on a (successful) read, not on a write. Signed-off-by: Rusty Russell --- hw/block/virtio-blk.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 258bb4c..98d87a9 100644 ---

[Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-10 Thread Rusty Russell
The virtio 'used' ring describes descriptors which have been used. It also says how many bytes have been written to the ring. For some cases, this value is ignored by Linux guests, thus errors have not been noticed. I was working on increasing the checking in Linux when I noticed this behaviour.

[Qemu-devel] [PATCH 1/2] virtio: make it clear that "len" for a used descriptor is len written.

2015-03-10 Thread Rusty Russell
And enforce this with a check that it's <= the writable length. Signed-off-by: Rusty Russell --- hw/virtio/virtio.c | 19 --- include/hw/virtio/virtio.h | 4 ++-- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c inde

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-10 Thread Michael Tokarev
10.03.2015 20:41, Aneesh Kumar K.V пишет: > Michael Tokarev writes: > >> 08.03.2015 19:27, Aneesh Kumar K.V wrote: >>> Michael Tokarev writes: >> [] Actually, after reading almost whole 9pfs and fsdev code, I can say with great confidence this code is nearly hopeless. >>> >>> Is that a

[Qemu-devel] [PATCH v3] block/null: Latency simulation by adding new option "latency-ns"

2015-03-10 Thread Fam Zheng
Aio context switch should just work because the requests will be drained, so the scheduled timer(s) on the old context will be freed. Signed-off-by: Fam Zheng --- v3: latency_ns -> latency-ns; Add documentation in qapi json. [Eric] v2: Check for negative value; add sleep in null-co://. [Kevin] -

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-10 Thread David Gibson
On Wed, 4 Mar 2015 20:12:31 +0100 "Michael S. Tsirkin" wrote: > On Wed, Mar 04, 2015 at 05:33:42PM +0100, Igor Mammedov wrote: > > On Wed, 4 Mar 2015 16:31:39 +0100 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Mar 04, 2015 at 04:14:44PM +0100, Igor Mammedov wrote: > > > > On Wed, 4 Mar 201

Re: [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new option "latency_ns"

2015-03-10 Thread Fam Zheng
On Fri, 03/06 10:14, Eric Blake wrote: > On 03/04/2015 06:32 PM, Fam Zheng wrote: > > Aio context switch should just work because the requests will be > > drained, so the scheduled timer(s) on the old context will be freed. > > > > Signed-off-by: Fam Zheng > > > > --- > > v2: Check for negative

Re: [Qemu-devel] [PATCH 1/2] exec: Convert bounce buffer to a set

2015-03-10 Thread Fam Zheng
On Tue, 03/10 12:14, Paolo Bonzini wrote: > > > On 10/03/2015 08:50, Fam Zheng wrote: > > +QLIST_ENTRY(BounceBuffer) next; > > Where is this used? Unused, I will remove this. > > > -if (buffer != bounce.buffer) { > > +BounceBuffer *bounce; > > + > > +bounce = bounce_buffer_fin

Re: [Qemu-devel] [RFC v4 6/9] vfio: add 'x-aer' option to disable aer capability

2015-03-10 Thread Chen Fan
On 03/10/2015 04:29 AM, Alex Williamson wrote: On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: add 'x-aer' option to disable aer capability if user want. I'm generally one to favor using the x- flag, but we need to figure out if we need to make this be a supported option or not. We also ne

Re: [Qemu-devel] [RFC 0/1] Rolling stats on colo

2015-03-10 Thread zhanghailiang
Hi Dave, Sorry for the late reply :) On 2015/3/7 2:30, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Hi Dave, Hi, I'm getting COLO running on a couple of our

Re: [Qemu-devel] [RFC v4 8/9] vfio-pci: pass the aer error to guest

2015-03-10 Thread Chen Fan
On 03/10/2015 04:29 AM, Alex Williamson wrote: On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked.

[Qemu-devel] [PATCH] qcow2: fix the macro QCOW_MAX_L1_SIZE's use

2015-03-10 Thread Wen Congyang
QCOW_MAX_L1_SIZE's unit is byte, and l1_size's unit is l1 table entry size(8 bytes). Signed-off-by: Wen Congyang --- block/qcow2-snapshot.c | 2 +- block/qcow2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index

Re: [Qemu-devel] [RFC v4 3/9] vfio: add pcie extanded capability support

2015-03-10 Thread Chen Fan
On 03/10/2015 04:28 AM, Alex Williamson wrote: On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: For vfio pcie device, we could expose the extanded capability on s/extanded/extended/ PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and r

Re: [Qemu-devel] [RFC v4 4/9] aer: impove pcie_aer_init to support vfio device

2015-03-10 Thread Chen Fan
On 03/10/2015 04:29 AM, Alex Williamson wrote: On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: extend pcie_aer_init arguments to adjust vfio device. Some discussion of why vfio wants this would be useful. qemu treats vfio device as an emulated device. and these attributes of aer can be emu

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Bandan Das
"Dr. David Alan Gilbert" writes: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 10/03/2015 19:21, Bandan Das wrote: >> > Paolo Bonzini writes: >> > >> >> On 10/03/2015 17:57, Dr. David Alan Gilbert wrote: >> >>> I'm seeing something similar; it's very intermittent and generally >>

Re: [Qemu-devel] [PATCH 3/3] vnc: switch to inet_listen_opts

2015-03-10 Thread Gonglei
On 2015/3/10 19:18, Gerd Hoffmann wrote: > Use inet_listen_opts instead of inet_listen. Allows us to drop some > pointless indirection: Format strings just to parse them again later on. > Nice improvement. :) > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 75 >

Re: [Qemu-devel] [PATCH 2/3] vnc: remove dead code

2015-03-10 Thread Gonglei
On 2015/3/10 19:18, Gerd Hoffmann wrote: > If vs->ws_enabled is set ws_display is non-NULL. > > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > Reviewed-by: Gonglei > diff --git a/ui/vnc.c b/ui/vnc.c > index 65ba1c0..bac44ce 100

Re: [Qemu-devel] [PATCH 1/3] vnc: drop display+ws_display from VncDisplay

2015-03-10 Thread Gonglei
On 2015/3/10 19:18, Gerd Hoffmann wrote: > Nobody cares about those strings, they are only used to check whenever > the vnc server / websocket support is enabled or not. Add bools for > this and drop the strings. > > Signed-off-by: Gerd Hoffmann > --- > ui/vnc-auth-sasl.c | 2 +- > ui/vnc.c

Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source

2015-03-10 Thread David Gibson
On Tue, Mar 10, 2015 at 02:34:03PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Wed, Feb 25, 2015 at 04:51:34PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Add migrate_send_rp_message to send

Re: [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Block even on non-blocking fd's

2015-03-10 Thread David Gibson
On Tue, Mar 10, 2015 at 01:35:58PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Wed, Feb 25, 2015 at 04:51:31PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The return path uses a non-blocking

Re: [Qemu-devel] [PATCH] ui: fix regression in x509verify parameter for VNC server

2015-03-10 Thread Gonglei
On 2015/3/11 0:27, Daniel P. Berrange wrote: > The 'x509verify' parameter is documented as taking a path to the > x509 certificates, ie the same syntax as the 'x509' parameter. > > commit 4db14629c38611061fc19ec6927405923de84f08 > Author: Gerd Hoffmann > Date: Tue Sep 16 12:33:03 2014 +02

Re: [Qemu-devel] [PATCH v5 for-2.3 02/28] acpi: add aml_or() term

2015-03-10 Thread Shannon Zhao
On 2015/3/10 23:31, Marcel Apfelbaum wrote: > Add encoding for ACPI DefOr Opcode. > > Reviewed-by: Shannon Zhao > Reviewed-by: Igor Mammedov > Signed-off-by: Marcel Apfelbaum > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insert

Re: [Qemu-devel] [PATCH v4 for-2.3 11/25] hw/apci: add _PRT method for extra PCI root busses

2015-03-10 Thread Shannon Zhao
On 2015/3/11 1:40, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2015 at 07:26:13PM +0200, Marcel Apfelbaum wrote: >> > On 03/10/2015 07:07 PM, Michael S. Tsirkin wrote: >>> > >On Sun, Mar 08, 2015 at 01:16:13PM +0200, Marcel Apfelbaum wrote: > >>Signed-off-by: Marcel Apfelbaum > >>--- >>>

Re: [Qemu-devel] [PATCH] queue: fix QSLIST_INSERT_HEAD_ATOMIC race

2015-03-10 Thread Christian Borntraeger
Am 10.03.2015 um 16:45 schrieb Paolo Bonzini: [...] > > Moral of the story: I should refrain from writing more clever stuff. > At least it looks like it is not too clever to be undebuggable. > > Reported-by: Christian Borntraeger > Fixes: c740ad92d0d958fa785e5d7aa1b67ecaf30a6a54 > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 22:57 schrieb Eduardo Habkost: > Instead of passing icc_bridge from the PC initialization code to > cpu_x86_create(), make the PC initialization code attach the CPU to > icc_bridge. > > The only difference here is that icc_bridge attachment will now be done > after x86_cpu_parse_f

Re: [Qemu-devel] [PULL 00/20] s390x/kvm: Features and fixes for 2.3

2015-03-10 Thread Christian Borntraeger
t; are available in the git repository at: >> >> git://github.com/borntraeger/qemu.git tags/s390x-20150310 >> >> for you to fetch changes up to 6342cb1443b37d249a0e2005128ade07a80a97f5: >> >> s390-ccw: rebuild BIOS (2015-03-10 09:26:33 +0100) > > Unfo

Re: [Qemu-devel] [PATCH v11 0/5] Netduino 2 Machine Model

2015-03-10 Thread Alistair Francis
On Tue, Mar 10, 2015 at 10:04 PM, Peter Maydell wrote: > On 17 February 2015 at 12:38, Alistair Francis wrote: >> This patch series adds the Netduino 2 Machine to QEMU >> >> Information on the board is avalible at: >> http://www.netduino.com/netduino2/specs.htm >> >> The git tree can be found at:

[Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Eduardo Habkost
Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is that icc_bridge attachment will now be done after x86_cpu_parse_featurestr() is called. But this shouldn't make any differenc

[Qemu-devel] [PATCH v2 0/1] target-i386: Move icc_bridge code to PC

2015-03-10 Thread Eduardo Habkost
This removes yet another chunk of PC-specific code from target-i386/cpu.c and moves it to PC code. WIth this we get closer to being able to change target-i386 to use cpu_generic_init(). This series is based on my x86 tree, located at: https://github.com/ehabkost/qemu.git x86 Changes v1 -> v2:

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: >> Hi, >> >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >>> Fixes a QEMU crash when passing dump_guest_core parameter in command line. >> >> Explain that, please? > > Pls note

[Qemu-devel] [PATCH 2/2] AHCI: Protect cmd register

2015-03-10 Thread John Snow
Many bits in the CMD register are supposed to be strictly read-only. We should not be deleting them on every write. As a side-effect: pay explicit attention to when a guest marks off the FIS Receive or Start bits, and disable the status bits ourselves, instead of letting them implicitly fall off.

[Qemu-devel] [PATCH 1/2] AHCI: Do not (re)map FB/CLB buffers while not running

2015-03-10 Thread John Snow
The FIS Receive Buffer and Command List Buffer pointers should not be edited while the FIS receive engine or Command Receive engines are running. Currently, we attempt to re-map the buffers every time they are adjusted, but while the AHCI engines are off, these registers may contain stale values,

[Qemu-devel] [PATCH 0/2] AHCI: avoid mapping stale guest memory

2015-03-10 Thread John Snow
Currently, the AHCI device tries to re-map guest memory every time the low or high address registers are written to, whether or not the AHCI device is currently active. If the other register has stale information in it, this may lead to runtime failures. Reconfigure the AHCI device to ignore write

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: > Hi, > > Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > > Fixes a QEMU crash when passing dump_guest_core parameter in command line. > > Explain that, please? Pls note the submission date. It's 1 month late to ask for basic cl

Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 06:04:20PM +, Peter Maydell wrote: > On 10 March 2015 at 17:53, Andreas Färber wrote: > > Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin: > >> On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote: > >>> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: > >

[Qemu-devel] [PATCH v2 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-10 Thread Andrew Jones
This patch makes the following changes to the determination of whether an address is executable, when translating addresses using LPAE. 1. No longer assumes that PL0 can't execute when it can't read. It can in AArch64, a difference from AArch32. 2. Use va_size == 64 to determine we're in AArch6

[Qemu-devel] [PATCH v2 2/3] target-arm: fix get_phys_addr_v6/SCTLR_AFE access check

2015-03-10 Thread Andrew Jones
Introduce simple_ap_to_rw_prot(), which has the same behavior as ap_to_rw_prot(), but takes the 2-bit simple AP[2:1] instead of the 3-bit AP[2:0]. Use this in get_phys_addr_v6 when SCTLR_AFE is set, as that bit indicates we should be using the simple AP format. It's unlikely this path is getting u

[Qemu-devel] [PATCH v2 1/3] target-arm: convert check_ap to ap_to_rw_prot

2015-03-10 Thread Andrew Jones
Instead of mixing access permission checking with access permissions to page protection flags translation, just do the translation, and leave it to the caller to check the protection flags against the access type. Also rename to ap_to_rw_prot to better describe the new behavior. Signed-off-by: And

[Qemu-devel] [PATCH v2 0/3] tcg-arm: LPAE: fix and extend xn control

2015-03-10 Thread Andrew Jones
This series fixes and extends the determination of whether or not an address is executable for LPAE translations. The main patch is 3/3, and describes the details in its commit message. Patch 1/3 prepares for patch 2/3, which is prep for 3/3, and also fixes a potential problem with checking access

Re: [Qemu-devel] [PATCH] libqos: Solve bug in interrupt checking when using MSIX in virtio-pci.c

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 21:50 schrieb John Snow: > On 02/24/2015 01:09 PM, John Snow wrote: >> On 02/24/2015 11:34 AM, Marc Marí wrote: >>> The MSIX interrupt was always acked without checking its value, which >>> caused a >>> race condition. If the ISR was raised between the read and the acking, >>> the

Re: [Qemu-devel] [PATCH] libqos: Solve bug in interrupt checking when using MSIX in virtio-pci.c

2015-03-10 Thread Marc Marí
El Tue, 10 Mar 2015 16:50:48 -0400 John Snow escribió: > > > On 02/24/2015 01:09 PM, John Snow wrote: > > > > > > On 02/24/2015 11:34 AM, Marc Marí wrote: > >> The MSIX interrupt was always acked without checking its value, > >> which caused a > >> race condition. If the ISR was raised between t

Re: [Qemu-devel] [PATCH] libqos: Solve bug in interrupt checking when using MSIX in virtio-pci.c

2015-03-10 Thread John Snow
On 02/24/2015 01:09 PM, John Snow wrote: On 02/24/2015 11:34 AM, Marc Marí wrote: The MSIX interrupt was always acked without checking its value, which caused a race condition. If the ISR was raised between the read and the acking, the ISR was never detected and it timed out. Signed-off-by:

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 10/03/2015 19:21, Bandan Das wrote: > > Paolo Bonzini writes: > > > >> On 10/03/2015 17:57, Dr. David Alan Gilbert wrote: > >>> I'm seeing something similar; it's very intermittent and generally > >>> happening right at boot of the guest;

[Qemu-devel] [PATCH v2 3/6] libqtest: add qmp_eventwait

2015-03-10 Thread John Snow
Allow the user to poll until a desired interrupt occurs. Signed-off-by: John Snow --- tests/ide-test.c | 11 +-- tests/libqtest.c | 16 tests/libqtest.h | 20 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/tests/ide-test.c b/tests/i

[Qemu-devel] [PATCH v2 4/6] libqtest: add qmp_async

2015-03-10 Thread John Snow
Add qmp_async, which lets us send QMP commands asynchronously. This is useful when we want to send commands that will trigger event responses, but we don't know in what order to expect them. Sometimes the event responses may arrive even before the command confirmation will show up, so it is conven

[Qemu-devel] [PATCH v2 1/6] qtest/ahci: Add simple flush test

2015-03-10 Thread John Snow
Signed-off-by: John Snow --- tests/ahci-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index fb4739f..b344121 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -774,6 +774,29 @@ static void ahci_test_io_

[Qemu-devel] [PATCH v2 2/6] qtest/ahci: Allow override of default CLI options

2015-03-10 Thread John Snow
Signed-off-by: John Snow --- tests/ahci-test.c| 67 tests/libqos/libqos-pc.c | 5 tests/libqos/libqos-pc.h | 1 + 3 files changed, 51 insertions(+), 22 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index b344121..6

[Qemu-devel] [ANNOUNCE] QEMU 2.2.1 Stable released

2015-03-10 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v2.2.1 stable release is now available at: http://wiki.qemu.org/download/qemu-2.2.1.tar.bz2 v2.2.1 is now tagged in the official qemu.git repository, and the stable-2.2 branch has been created/updated accordingly: http://git.qemu.org/?p=qe

[Qemu-devel] [PATCH v2 5/6] libqos: add blkdebug_prepare_script

2015-03-10 Thread John Snow
Pull this helper out of ide-test and into libqos, to be shared with ahci-test. Signed-off-by: John Snow --- tests/ide-test.c | 23 +-- tests/libqos/libqos.c | 22 ++ tests/libqos/libqos.h | 1 + 3 files changed, 24 insertions(+), 22 deletions(-) dif

[Qemu-devel] [PATCH v2 6/6] qtest/ahci: add flush retry test

2015-03-10 Thread John Snow
Signed-off-by: John Snow --- tests/ahci-test.c | 44 1 file changed, 44 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 6c99f19..64dff8d 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -46,6 +46,7 @@ /*** Globals **

[Qemu-devel] [PATCH v2 0/6] ahci: rerror/werror=stop resume tests

2015-03-10 Thread John Snow
This series is based on: "[Qemu-devel] [PATCH 0/2] ahci: test varying sector offsets" There appear to be some upstream issues for iotests 051 and 061, but this series does not appear to alter the existing bad behavior of those tests. This patchset brings us up to feature parity with the ide-test

Re: [Qemu-devel] [PULL 0/7] X86 patches

2015-03-10 Thread Eduardo Habkost
On Tue, Mar 10, 2015 at 02:19:09PM +, Peter Maydell wrote: > On 10 March 2015 at 14:16, Eduardo Habkost wrote: > > On Tue, Mar 10, 2015 at 11:44:22AM +, Peter Maydell wrote: > >> 'make check' fails for the i386 targets, apparently because > >> qemu-system-i386 > >> segfaults on startup: >

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 10/03/2015 19:21, Bandan Das wrote: > > Paolo Bonzini writes: > > > >> On 10/03/2015 17:57, Dr. David Alan Gilbert wrote: > >>> I'm seeing something similar; it's very intermittent and generally > >>> happening right at boot of the guest;

Re: [Qemu-devel] [PULL 00/11] scsi, RCU, KVM, x86 changes for 2015-03-10

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 10:37, Paolo Bonzini wrote: > The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2015-03-09 14:04:14 +) > > are available in the git repository at: > >

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 19:21, Bandan Das wrote: > Paolo Bonzini writes: > >> On 10/03/2015 17:57, Dr. David Alan Gilbert wrote: >>> I'm seeing something similar; it's very intermittent and generally >>> happening right at boot of the guest; I'm running this on qemu >>> head+my postcopy world (but it's

[Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15 in register list

2015-03-10 Thread Peter Maydell
The A32 encoding of LDM distinguishes LDM (user) from LDM (exception return) based on whether r15 is in the register list. However for STM (user) there is no equivalent distinction. We were incorrectly treating "r15 in list" as indicating exception return for both LDM and STM, with the result that

Re: [Qemu-devel] [PATCH] target-arm: modifying pc in tcg code for load/store multiple

2015-03-10 Thread Peter Maydell
On 19 February 2015 at 16:04, Ildar Isaev wrote: > A bit clumsy, but something like that. Qemu never gets to the code past stmda. > > -bash-4.1$ cat add.s > > > .text > mov r0, #5 > mov r1, #4 > add r2, r1, r0 > stmda sp, {r1, r2, r5, sp, lr, pc}^ >

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Bandan Das
Paolo Bonzini writes: > On 10/03/2015 17:57, Dr. David Alan Gilbert wrote: >> I'm seeing something similar; it's very intermittent and generally >> happening right at boot of the guest; I'm running this on qemu >> head+my postcopy world (but it's happening right at boot before postcopy >> gets

[Qemu-devel] [PATCH v5 for-2.3 25/28] hw/pxb: add numa_node parameter

2015-03-10 Thread Marcel Apfelbaum
The pxb can be attach to and existing numa node by specifying numa_node option that equals the desired numa nodeid. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c| 12 hw/pci-bridge/pci_expander_bridge.c | 17 + 2 files changed, 29 insertion

[Qemu-devel] [PATCH v5 for-2.3 28/28] docs: Add PXB documentation

2015-03-10 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- docs/pci_expander_bridge.txt | 52 1 file changed, 52 insertions(+) create mode 100644 docs/pci_expander_bridge.txt diff --git a/docs/pci_expander_bridge.txt b/docs/pci_expander_bridge.txt new file mode 100644 inde

[Qemu-devel] [PATCH v5 for-2.3 23/28] hw/pxb: add map_irq func

2015-03-10 Thread Marcel Apfelbaum
The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation. Synchronize between bios and Qemu by canceling pxb's effect. Signed-off-by: Marcel A

Re: [Qemu-devel] [PATCH] target-arm: always use user mode registers as operands for load/store multiple

2015-03-10 Thread Peter Maydell
On 19 February 2015 at 12:55, Ildar Isaev wrote: > Pseudocode fragment for STM instruction in ARMv8 spec: > > if registers == '1' then // Store User mode register > MemA[address,4] = Rmode[i, M32_User]; This pseudocode is specifically for the "user mode" variant of STM. The code you're changi

[Qemu-devel] [PULL 3/6] target-unicore32: Make uc32_cpu_init() return UniCore32CPU

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost This way, the cpu_init() function in target-unicore32 will follow the same pattern used on all other architectures. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-unicore32/cpu.h| 14 -- target-unicore32/helper.c | 10 ++

Re: [Qemu-devel] [PATCH RFC 2/2] block: Drop code supporting encryption outside qemu-img

2015-03-10 Thread Eric Blake
On 03/10/2015 11:26 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block.c | 30 > blockdev.c| 43 +--- > hmp-commands.hx | 14 - > hmp.c | 41

[Qemu-devel] [PULL 5/6] unicore32: Use uc32_cpu_init()

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost Instead of using the legacy cpu_init() function, use uc32_cpu_init() to create a UniCore32CPU object. Signed-off-by: Eduardo Habkost Cc: Guan Xuetao Signed-off-by: Andreas Färber --- hw/unicore32/puv3.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -

[Qemu-devel] [PULL 2/6] target-i386: Clean up misuse of qdev_init() in realize method

2015-03-10 Thread Andreas Färber
From: Markus Armbruster x86_cpu_apic_realize() calls qdev_init() to realize the APIC. qdev_init()'s error handling has unwanted side effects: it unparents the device, and it calls qerror_report_err(). qerror_report_err() is always inappropriate in realize methods, because it doesn't return the E

[Qemu-devel] [PULL 4/6] m68k: Use cpu_m68k_init()

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost Instead of using the legacy cpu_init() function, use cpu_m68k_init() directly to create a M68kCPU object. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/m68k/dummy_m68k.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/m6

[Qemu-devel] [PULL 1/6] cpu: Add missing documentation for some CPUClass methods

2015-03-10 Thread Andreas Färber
From: Peter Maydell The CPUClass QOM methods virtio_is_big_endian, write_elf{32,64}_note and write_elf{32,64}_qemunote were added without any description being added to the doc comment. Correct this omission. Signed-off-by: Peter Maydell Acked-by: Greg Kurz Signed-off-by: Andreas Färber ---

[Qemu-devel] [PULL 6/6] cpu: Make cpu_init() return QOM CPUState object

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost Instead of making cpu_init() return CPUArchState, return CPUState. Changes were made using the Coccinelle semantic patch below. @@ typedef CPUState; identifier e; expression args; type CPUArchState; @@ - e = + cpu = cpu_init(args); - if (!

[Qemu-devel] [PULL 0/6] QOM CPUState patch queue 2015-03-10

2015-03-10 Thread Andreas Färber
Hello Peter, This is my QOM CPU patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Eduardo Habkost The following changes since commit 1976058109890892db8ec88bfd3273f79c459f6b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-03-10 14:01:22 +

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Andrey Korolyov
On Tue, Mar 10, 2015 at 9:16 PM, Dr. David Alan Gilbert wrote: > * Andrey Korolyov (and...@xdel.ru) wrote: >> On Tue, Mar 10, 2015 at 7:57 PM, Dr. David Alan Gilbert >> wrote: >> > * Andrey Korolyov (and...@xdel.ru) wrote: >> >> On Sat, Mar 7, 2015 at 3:00 AM, Andrey Korolyov wrote: >> >> > On F

Re: [Qemu-devel] [PATCH RFC 1/2] block: Limit opening of encrypted images to qemu-img

2015-03-10 Thread Eric Blake
On 03/10/2015 11:26 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/qcow.c | 5 + > block/qcow2.c | 5 + > include/block/block.h | 3 +-- > qemu-img.c| 1 + > 4 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/blo

Re: [Qemu-devel] [PATCH 02/11] target-arm: Extend NZCF to 64 bits

2015-03-10 Thread Richard Henderson
On 03/10/2015 09:08 AM, Peter Maydell wrote: > On 19 February 2015 at 21:14, Richard Henderson wrote: >> The resulting aarch64 translation is a bit cleaner. >> Sign-extending from 32-bits is simpler than having >> to use setcond to narrow from 64-bits. >> >> Signed-off-by: Richard Henderson > >

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Dr. David Alan Gilbert
* Andrey Korolyov (and...@xdel.ru) wrote: > On Tue, Mar 10, 2015 at 7:57 PM, Dr. David Alan Gilbert > wrote: > > * Andrey Korolyov (and...@xdel.ru) wrote: > >> On Sat, Mar 7, 2015 at 3:00 AM, Andrey Korolyov wrote: > >> > On Fri, Mar 6, 2015 at 7:57 PM, Bandan Das wrote: > >> >> Andrey Korolyov

Re: [Qemu-devel] [PATCH v4 0/2] integrator/cp: Working SD card support

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 16:27, Jan Kiszka wrote: > Changes in v4: > - fixed up type name as Peter suggested > Jan Kiszka (2): > integrator/cp: Model CP control registers as sysbus device > integrator/cp: Implement CARDIN and WPROT signals > > hw/arm/integratorcp.c | 95 > ++

Re: [Qemu-devel] [PATCH RFC 1/2] block: Limit opening of encrypted images to qemu-img

2015-03-10 Thread Daniel P. Berrange
On Tue, Mar 10, 2015 at 06:26:39PM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/qcow.c | 5 + > block/qcow2.c | 5 + > include/block/block.h | 3 +-- > qemu-img.c| 1 + > 4 files changed, 12 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH RFC 0/2] Limit support for encrypted images to qemu-img

2015-03-10 Thread Daniel P. Berrange
On Tue, Mar 10, 2015 at 06:26:38PM +0100, Markus Armbruster wrote: > RFC because the series only covers open [PATCH 1], but not create. > Also missing: make qemu-img print a warning when it creates an > encrypted image. Finally, some of the material in the cover letter > should be worked into the

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 17:57, Dr. David Alan Gilbert wrote: > I'm seeing something similar; it's very intermittent and generally > happening right at boot of the guest; I'm running this on qemu > head+my postcopy world (but it's happening right at boot before postcopy > gets a chance), and I'm using a 3

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-10 Thread Andrey Korolyov
On Tue, Mar 10, 2015 at 7:57 PM, Dr. David Alan Gilbert wrote: > * Andrey Korolyov (and...@xdel.ru) wrote: >> On Sat, Mar 7, 2015 at 3:00 AM, Andrey Korolyov wrote: >> > On Fri, Mar 6, 2015 at 7:57 PM, Bandan Das wrote: >> >> Andrey Korolyov writes: >> >> >> >>> On Fri, Mar 6, 2015 at 1:14 AM,

Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 17:53, Andreas Färber wrote: > Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin: >> On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote: >>> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: Make it safe to include hw/boards.h in exec.c for linux-user con

Re: [Qemu-devel] [PULL 00/20] s390x/kvm: Features and fixes for 2.3

2015-03-10 Thread Peter Maydell
changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2015-03-09 14:04:14 +) > > are available in the git repository at: > > git://github.com/borntraeger/qemu.git ta

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-10 Thread Andreas Färber
Hi, Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > Fixes a QEMU crash when passing dump_guest_core parameter in command line. Explain that, please? > > Signed-off-by: Marcel Apfelbaum > --- > exec.c | 4 ++-- > hw/core/machine.c | 6 ++ > include/hw/boards.h | 1 + > 3

Re: [Qemu-devel] [PATCH v5 for-2.3 28/28] docs: Add PXB documentation

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 06:21:14PM +0200, Marcel Apfelbaum wrote: > On 03/10/2015 05:47 PM, Michael S. Tsirkin wrote: > >On Tue, Mar 10, 2015 at 05:32:14PM +0200, Marcel Apfelbaum wrote: > >>Signed-off-by: Marcel Apfelbaum > >>--- > >> docs/pci_expander_bridge.txt | 52 > >> +

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

2015-03-10 Thread John Snow
On 03/10/2015 01:41 PM, Peter Maydell wrote: On 10 March 2015 at 17:37, John Snow mailto:js...@redhat.com>> wrote: Our qtest suite relies on many functions available only in glib 2.16+. Even though our base QEMU binary may only require 2.12+, it is confusing to have two separate

  1   2   3   4   5   >