Re: [Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-11 Thread Dongli Zhang
On 11/12/2018 03:13 PM, Marc Olson via Qemu-devel wrote: > On 11/3/18 10:24 AM, Dongli Zhang wrote: >> Hi all, >> >> I tried with the patch at: >> >> https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00394.html >> >> The patch is applied to qemu-3.0.0. >> >> >> Below configuration is

Re: [Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-11 Thread Marc Olson via Qemu-devel
On 11/3/18 10:24 AM, Dongli Zhang wrote: Hi all, I tried with the patch at: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00394.html The patch is applied to qemu-3.0.0. Below configuration is used to test the feature for guest VM nvme. # qemu-system-x86_64 \ -smp 4 -m 2000M

[Qemu-devel] [PATCH v3 3/3] blkdebug: Add latency injection rule type

2018-11-11 Thread Marc Olson via Qemu-devel
Add a new rule type for blkdebug that instead of returning an error, can inject latency to an IO. Signed-off-by: Marc Olson --- block/blkdebug.c | 79 +++--- docs/devel/blkdebug.txt| 35 ++-- qapi/block-core.json | 31

[Qemu-devel] [PATCH v3 2/3] blkdebug: Extend rule check for additional types

2018-11-11 Thread Marc Olson via Qemu-devel
Break out the more common parts of the BlkdebugRule struct, and make rule_check() more explicit about operating only on error injection types so that additional rule types can be added in the future. Signed-off-by: Marc Olson --- block/blkdebug.c | 59

[Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

2018-11-11 Thread Marc Olson via Qemu-devel
If 'once' is specified, the rule should execute just once, regardless if it is supposed to return an error or not. Take the example where you want the first IO to an LBA to succeed, but subsequent IOs to fail. You could either use state transitions, or create two rules, one with error = 0 and once

[Qemu-devel] [PATCH 1/3] unify len and addr type for memory/address APIs

2018-11-11 Thread Li Zhijian
Some address/memory APIs have different type between 'hwaddr addr' and 'int len'. It is very unsafety, espcially some APIs will be passed a non-int len by caller which might cause overflow quietly. Below is an potential overflow case: dma_memory_read(uint32_t len) ->

[Qemu-devel] [PATCH 2/3] change load_image() reture type to ssize_t

2018-11-11 Thread Li Zhijian
This patch allow load_iamge to load >=2G file Signed-off-by: Li Zhijian --- hw/core/loader.c| 5 +++-- include/hw/loader.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index aa0b3fc..0d53229 100644 --- a/hw/core/loader.c +++

[Qemu-devel] [PATCH 3/3] x86: allow load initrd below 4G for recent linux

2018-11-11 Thread Li Zhijian
a new field xloadflags was added to recent x86 linux, and BIT 1: XLF_CAN_BE_LOADED_ABOVE_4G is used to tell bootload that where initrd can be loaded saftly. Current QEMU always load initrd below below_4g_mem_size which always less than 4G, so here limit initrd_max to 4G - 1 simply is enough if

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-11 Thread H. Peter Anvin
On 11/11/18 10:19 PM, Ingo Molnar wrote: > > I might be a bit dense early in the morning, but could you elaborate? > What do you mean by mapping all data areas? > Heh. I need to pack for LPC and get some sleep before my flight lest I'll be denser than depleted uranium; I'll write an

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-11 Thread Ingo Molnar
* H. Peter Anvin wrote: > > Such an extended header could use a more modern (self-extending) ABI as > > well. > > Yes, although I don't really think it is as much of an issue as it seems at > this point. > > The limit comes from having used a one-byte jump instruction at the beginning; >

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-11 Thread H. Peter Anvin
On 11/11/18 8:56 PM, Ingo Molnar wrote: > >> Also note that the ext_ramdisk_image and ext_ramdisk_size are part of >> struct boot_params as opposed to struct setup_header, which means that >> they are not supported when entering via the 16-bit BIOS entry point, >> and I am willing to bet that

Re: [Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub

2018-11-11 Thread Aleksandar Markovic
> Subject: [RFC PATCH 08/11] target/mips: Add a decodetree stub There is no plan to use decodetree for MIPS target. MIPS decoding engine is mostly stable mature code that was well tested over many years, and there is no point in introducing such drastic change to the code that works. Thanks,

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-11 Thread Ingo Molnar
* H. Peter Anvin wrote: > On 11/9/18 5:40 AM, Li Zhijian wrote: > > Just noticed that there is a field xloadflags at recent protocol > >   60 Protocol 2.12:  (Kernel 3.8) Added the xloadflags field and > > extension fields > >   61 to struct boot_params for loading bzImage and

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-11 Thread Fei Li
Hi Juan, Kindly ping, as this multifd migration topic needs your suggestions. :) Have a nice day, thanks Fei On 11/03/2018 12:33 AM, Dr. David Alan Gilbert wrote: * Peter Xu (pet...@redhat.com) wrote: On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote: On 11/02/2018 10:37 AM, Peter Xu

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] ppc/spapr: Receive and store device tree blob from SLOF

2018-11-11 Thread Alexey Kardashevskiy
On 12/11/2018 05:10, Greg Kurz wrote: > Hi Alexey, > > Just a few remarks. See below. > > On Thu, 8 Nov 2018 12:44:06 +1100 > Alexey Kardashevskiy wrote: > >> SLOF receives a device tree and updates it with various properties >> before switching to the guest kernel and QEMU is not aware of

[Qemu-devel] [PATCH V6 6/6] pvpanic : update pvpanic document

2018-11-11 Thread Peng Hao
Add mmio support info in docs/specs/pvpanic.txt. Signed-off-by: Peng Hao --- docs/specs/pvpanic.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt index c7bbacc..5d8e9dc 100644 --- a/docs/specs/pvpanic.txt +++

[Qemu-devel] [PATCH V6 4/6] hw/arm/virt: Use the pvpanic device

2018-11-11 Thread Peng Hao
Add pvpanic device in arm virt machine. Signed-off-by: Peng Hao Signed-off-by: Philippe Mathieu-Daudé --- default-configs/arm-softmmu.mak | 1 + hw/arm/virt.c | 21 + include/hw/arm/virt.h | 1 + 3 files changed, 23 insertions(+) diff --git

[Qemu-devel] [PATCH V6 5/6] hw/arm/virt: add pvpanic device in virt acpi table

2018-11-11 Thread Peng Hao
add pvpanic device in virt acpi table, so when kenrel command line uses acpi=force, kernel can get info from acpi table in aarch64. Signed-off-by: Peng Hao --- hw/arm/virt-acpi-build.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/arm/virt-acpi-build.c

[Qemu-devel] [PATCH V6 0/5] add pvpanic mmio support

2018-11-11 Thread Peng Hao
The first patches are simple cleanups: - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile it once for the x86/arm/aarch64 archs, - patch 2 simply renames ISA fields/definitions to generic ones. Then instead of add/use the MMIO pvpanic device in the virt machine in an

[Qemu-devel] [PATCH V6 1/6] hw/misc/pvpanic: Build the pvpanic device in $(common-obj)

2018-11-11 Thread Peng Hao
From: Philippe Mathieu-Daudé The 'pvpanic' ISA device can be use by any machine with an ISA bus. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index

[Qemu-devel] [PATCH V6 3/6] hw/misc/pvpanic: Add the MMIO interface

2018-11-11 Thread Peng Hao
Add pvpanic new type "TYPE_PVPANIC_MMIO" Signed-off-by: Peng Hao Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/pvpanic.c | 81 +-- include/hw/misc/pvpanic.h | 1 + 2 files changed, 65 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] [PATCH V6 2/6] hw/misc/pvpanic: Cosmetic renaming

2018-11-11 Thread Peng Hao
From: Philippe Mathieu-Daudé To ease the MMIO device addition in the next patch, rename: - ISA_PVPANIC_DEVICE -> PVPANIC (this just returns a generic Object), - ISADevice parent_obj -> isadev, - MemoryRegion io -> mr. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/pvpanic.c | 16

Re: [Qemu-devel] [PATCH v2 0/5] migration: improve multithreads

2018-11-11 Thread Xiao Guangrong
Hi, Ping... On 11/6/18 8:20 PM, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Changelog in v2: These changes are based on Paolo's suggestion: 1) rename the lockless multithreads model to threaded workqueue 2) hugely improve the internal design, that make all the request be a

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Michael S. Tsirkin
On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > @@ -66,12 +143,16 @@ typedef struct VirtIONet { > >      VirtIONetQueue *vqs; > >      VirtQueue *ctrl_vq; > >      NICState *nic; > > +    QTAILQ_HEAD(, NetRscChain) rsc_chains; > > what exactly happens

Re: [Qemu-devel] [PATCH] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-11-11 Thread Max Filippov
On Sun, Nov 11, 2018 at 3:53 PM Philippe Mathieu-Daudé wrote: > > Hi Max, > > On Thu, Nov 1, 2018 at 12:02 AM Richard Henderson > wrote: > > > > On 10/31/18 9:35 PM, Max Filippov wrote: > > > gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b > > > and dc233c

[Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-11 Thread xiezhide
These patches provide the qmp interface, to set/query the io throttle status of the all fsdev devices that are present in a vm. Some of the patches also remove the duplicate code that was present in block and fsdev files. Zhide Xie (2): fsdev-qmp: qmp interface for set/query io throttle for

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

2018-11-11 Thread xiezhide
fix two coding style issue Signed-off-by: x00390961 mailto:xiezh...@huawei.com>> --- fsdev/qemu-fsdev-throttle.c | 2 +- include/qemu/throttle-options.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/fsdev/qemu-fsdev-throttle.c b/fsdev/qemu-fsdev-throttle.c index

[Qemu-devel] [PATCH 1/2] virtio-9p: qmp interface to set/query io throttle for fsdev devices

2018-11-11 Thread xiezhide
This patch provide qmp interface to set/query io throttle for fsdev devices. This patch include following work: 1. port Pradeep Jagadeesh's patches, details please review http://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00173.html 2. fix two issue: (1). qmp set io throttle code dump when

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] Fix the last Hyp mode bug and turn it on for A7, A15

2018-11-11 Thread Philippe Mathieu-Daudé
Hi Peter, On Fri, Nov 9, 2018 at 6:36 PM Peter Maydell wrote: > > This patchset fixes the last serious bug in our implementation > of Hyp mode (aka EL2 for AArch32), and turns the feature bit > on for the Cortex-A7 and Cortex-A15 CPUs. > > The bug is that Hyp mode is an exception to the previous

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/2] target/arm/cpu: Give Cortex-A15 and -A7 the EL2 feature

2018-11-11 Thread Philippe Mathieu-Daudé
On Fri, Nov 9, 2018 at 6:42 PM Peter Maydell wrote: > > The Cortex-A15 and Cortex-A7 both have EL2; now we've implemented still PL2 there :) > it properly we can enable the feature bit. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 2 ++ >

Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Remove antique TODO comment

2018-11-11 Thread Philippe Mathieu-Daudé
On Tue, Nov 6, 2018 at 5:41 PM Peter Maydell wrote: > > Remove a TODO comment about implementing the vectored interrupt > controller. We have had an implementation of that for a decade; > it's in hw/intc/pl190.c. > > Signed-off-by: Peter Maydell On Fri, Nov 9, 2018 at 2:49 PM Peter Maydell

Re: [Qemu-devel] [Qemu-arm] [PATCH for-v3.1 1/3] Revert "target/arm: Implement HCR.VI and VF"

2018-11-11 Thread Philippe Mathieu-Daudé
On Fri, Nov 9, 2018 at 2:48 PM Peter Maydell wrote: > > This reverts commit 8a0fc3a29fc2315325400c738f807d0d4ae0ab7f. > > The implementation of HCR.VI and VF in that commit is not > correct -- they do not track the overall "is there a pending > VIRQ or VFIQ" status, but whether there is a pending

Re: [Qemu-devel] [Qemu-arm] [PATCH for-v3.1 3/3] target/arm: Correctly implement handling of HCR_EL2.{VI, VF}

2018-11-11 Thread Philippe Mathieu-Daudé
On Fri, Nov 9, 2018 at 2:48 PM Peter Maydell wrote: > > In commit 8a0fc3a29fc2315325400 we tried to implement HCR_EL2.{VI,VF}, > but we got it wrong and had to revert it. > > In that commit we implemented them as simply tracking whether there > is a pending virtual IRQ or virtual FIQ. This is not

Re: [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file

2018-11-11 Thread Philippe Mathieu-Daudé
On Fri, Nov 9, 2018 at 5:16 PM Michael Roth wrote: > > This is needed to build skiboot from tarball-distributed sources > since the git data the make_release.sh script relies on to generate > it is not available. > > Cc: qemu-sta...@nongnu.org > Reported-by: Michael Tokarev > Signed-off-by:

Re: [Qemu-devel] [PATCH] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-11-11 Thread Philippe Mathieu-Daudé
Hi Max, On Thu, Nov 1, 2018 at 12:02 AM Richard Henderson wrote: > > On 10/31/18 9:35 PM, Max Filippov wrote: > > gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b > > and dc233c configurations. As a result the following message is > > displayed when attaching to an xtensa

Re: [Qemu-devel] [PATCH] hw: virtio-pci: drop DO_UPCAST

2018-11-11 Thread Philippe Mathieu-Daudé
On Sat, Nov 3, 2018 at 4:42 PM Li Qiang wrote: > > Use VIRTIO_PCI MACRO instead. > > Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé > --- > hw/virtio/virtio-pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio/virtio-pci.c

[Qemu-devel] [RFC PATCH 03/11] target/mips: Move the !ISA_MIPS32R6 check out of decode_opc_special2_legacy

2018-11-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 60320cbe69..f5e8d0b4d2 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25649,8

Re: [Qemu-devel] [PATCH for-3.2 v3 05/14] qdev: move qdev_prop_register_global_list() to tests

2018-11-11 Thread Philippe Mathieu-Daudé
On Wed, Nov 7, 2018 at 1:40 PM Marc-André Lureau wrote: > > The function is only used by a test, move it there. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/qdev-properties.h | 1 - > hw/core/qdev-properties.c

[Qemu-devel] [RFC PATCH 00/11] decodetree: Add tokens to ease checking ISA flags

2018-11-11 Thread Philippe Mathieu-Daudé
Hi Richard, I have been wondering how we can simplify when dealing with multiple ISAs. I used the MIPS arch because it aims to be simple, but handling the multiple ISAs/ASEs as once is a mess, with the particular case of the MIPS32R6. First I wanted to split the translate.c in various

Re: [Qemu-devel] [Qemu-arm] [PATCH for-v3.1 2/3] target/arm: Track the state of our irq lines from the GIC explicitly

2018-11-11 Thread Philippe Mathieu-Daudé
On Fri, Nov 9, 2018 at 2:49 PM Peter Maydell wrote: > > Currently we track the state of the four irq lines from the GIC > only via the cs->interrupt_request or KVM irq state. That means > that we assume that an interrupt is asserted if and only if the > external line is set. This assumption is

[Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub

2018-11-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/mips/Makefile.objs | 8 target/mips/insns.decode| 2 ++ target/mips/translate.c | 7 +++ target/mips/translate.inc.c | 13 + 4 files changed, 30 insertions(+) create mode 100644 target/mips/insns.decode

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 5/5] target/arm: Convert t32ee from feature bit to isar3 test

2018-11-11 Thread Philippe Mathieu-Daudé
On Thu, Nov 8, 2018 at 7:02 PM Richard Henderson wrote: > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.h | 6 +- > linux-user/elfload.c | 2 +- > target/arm/cpu.c | 4 > target/arm/helper.c | 2

[Qemu-devel] [RFC PATCH 02/11] decodetree: Add multiple include guard

2018-11-11 Thread Philippe Mathieu-Daudé
It is necessary when splitting an ISA, or when using multiple ISAs. Signed-off-by: Philippe Mathieu-Daudé --- TODO: explain why, use case TODO: escape full path? --- scripts/decodetree.py | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/decodetree.py b/scripts/decodetree.py

[Qemu-devel] [RFC PATCH 06/11] scripts/decodetree: Allow empty specifications

2018-11-11 Thread Philippe Mathieu-Daudé
Starting with empty specifications allow to write stubs/templates, useful when testing/rebasing. This fixes: decode.inc.c: In function ‘decode’: decode.inc.c:9:7: error: unused variable ‘u’ [-Werror=unused-variable] } u; ^ Signed-off-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [Qemu-block] KVM Forum block no[td]es

2018-11-11 Thread Nir Soffer
On Mon, Nov 12, 2018 at 12:25 AM Max Reitz wrote: > This is what I’ve taken from two or three BoF-like get-togethers on > blocky things. Amendments are more than welcome, of course. ... > Bitmaps > === > > (Got this section from sneaking into a BoF I wasn’t invited to. Oh > well. Won’t

[Qemu-devel] [RFC PATCH 07/11] scripts/decodetree: Add add_func_check()

2018-11-11 Thread Philippe Mathieu-Daudé
The '>' token allow to call a check(arg) function. This is useful to assert an instruction is supported by an ISA. Signed-off-by: Philippe Mathieu-Daudé --- scripts/decodetree.py | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/scripts/decodetree.py

[Qemu-devel] [RFC PATCH 09/11] target/mips: Port SYNCI to decodetree

2018-11-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/mips/insns.decode| 8 target/mips/translate.c | 6 -- target/mips/translate.inc.c | 7 +++ 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/target/mips/insns.decode b/target/mips/insns.decode index

[Qemu-devel] [RFC PATCH 04/11] target/mips: Avoid access to CPUMIPSState from decode* functions

2018-11-11 Thread Philippe Mathieu-Daudé
The DisasContext is already initialized from the CPUMIPSState in mips_tr_init_disas_context(). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/translate.c

[Qemu-devel] [RFC PATCH 01/11] MAINTAINERS: Add scripts/decodetree.py to the TCG section

2018-11-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 126fe0be7e..45e4bfcd87 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -112,6 +112,7 @@ S: Maintained F: cpus.c F: exec.c F: accel/tcg/ +F:

[Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree

2018-11-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/mips/insns.decode| 12 target/mips/translate.inc.c | 12 2 files changed, 24 insertions(+) diff --git a/target/mips/insns.decode b/target/mips/insns.decode index 8a1a7acf3a..e256220211 100644 ---

[Qemu-devel] [RFC PATCH 10/11] scripts/decodetree: Add add_cond_check()

2018-11-11 Thread Philippe Mathieu-Daudé
The '?' token allow to check for a condition. This is useful to take the translate the instruction only if the condition is valid. Signed-off-by: Philippe Mathieu-Daudé --- scripts/decodetree.py | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-11 Thread Philippe Mathieu-Daudé
Python internal representation is signed, so unsigned values bigger than 31-bit are interpreted as signed (and printed with a '-' signed). Mask out to force unsigned values. Signed-off-by: Philippe Mathieu-Daudé --- TODO: display error encountered: case 0x-1: ---

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

2018-11-11 Thread Brad Smith
ping. On 10/30/2018 10:57 PM, Fam Zheng wrote: Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1, include SDL2. Also do the build in $HOME since both /var/tmp and /tmp are tmpfs with limited capacities. Signed-off-by: Fam Zheng --- v4: Use 6.4. [Brad] ---

Re: [Qemu-devel] [PATCH] decodetree: Force Python to print unsigned values

2018-11-11 Thread Philippe Mathieu-Daudé
Hi Richard, On Sun, Nov 11, 2018 at 12:27 PM Richard Henderson wrote: > On 11/11/18 1:02 AM, Philippe Mathieu-Daudé wrote: > > Python internal representation is signed, so unsigned values > > bigger than 31-bit are interpreted as signed (and printed with > > a '-' signed). > > Mask out to force

[Qemu-devel] KVM Forum block no[td]es

2018-11-11 Thread Max Reitz
This is what I’ve taken from two or three BoF-like get-togethers on blocky things. Amendments are more than welcome, of course. Permission system = GRAPH_MOD - We need some way for the commit job to prevent graph changes on its chain while it is running. Our current

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread inactive
Changes reviewable in a decent web-ui here - https://github.com/qemu/qemu/compare/master...berkus:mojave-cocoa- fix?expand=1 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802684 Title: QEMU gui

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread inactive
Patches emailed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802684 Title: QEMU gui crashes on macOS Mojave Status in QEMU: New Bug description: QEMU release 3.0.0 as well as a recent

[Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-11 Thread Berkus Decker
It seems that Cocoa checks are stricter on Mojave and some callbacks that worked from non-GUI thread on High Sierra are no longer working. The fixes included here are: * Deferring qemu_main() to another thread so that the actual main thread is reserved for the Cocoa UI; it also removes

Re: [Qemu-devel] [PATCH v4 15/15] block: Assert that flags are up-to-date in bdrv_reopen_prepare()

2018-11-11 Thread Max Reitz
On 07.11.18 13:59, Alberto Garcia wrote: > Towards the end of bdrv_reopen_queue_child(), before starting to > process the children, the update_flags_from_options() function is > called in order to have BDRVReopenState.flags in sync with the options > from the QDict. > > This is necessary because

Re: [Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options()

2018-11-11 Thread Max Reitz
On 07.11.18 13:59, Alberto Garcia wrote: > This function takes three options (cache.direct, cache.no-flush and > read-only) from a QemuOpts object and updates the flags accordingly. and auto-read-only now > > If any of those options is not set (because it was missing from the > original QDict

Re: [Qemu-devel] [PATCH v4 13/15] block: Stop passing flags to bdrv_reopen_queue_child()

2018-11-11 Thread Max Reitz
On 07.11.18 13:59, Alberto Garcia wrote: > Now that all callers are passing the new options using the QDict we no > longer need the 'flags' parameter. > > This patch makes the following changes: > >1) The update_options_from_flags() call is no longer necessary > so it can be removed. >

Re: [Qemu-devel] [PATCH v4 11/15] block: Clean up reopen_backing_file() in block/replication.c

2018-11-11 Thread Max Reitz
On 07.11.18 13:59, Alberto Garcia wrote: > This function is used to put the hidden and secondary disks in > read-write mode before launching the backup job, and back in read-only > mode afterwards. > > This patch does the following changes: > > - Use an options QDict with the "read-only"

Re: [Qemu-devel] [PATCH v4 10/15] qemu-io: Put flag changes in the options QDict in reopen_f()

2018-11-11 Thread Max Reitz
On 07.11.18 13:59, Alberto Garcia wrote: > When reopen_f() puts a block device in the reopen queue, some of the > new options are passed using a QDict, but others ("read-only" and the > cache options) are passed as flags. > > This patch puts those flags in the QDict. This way the flags parameter

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread inactive
Ok I think I found places where code was invalid in Cocoa and fixed it. I can see qemu running my kernel and all interface is responsive. I also believe it should be working on as old as macOS 10.6 machines as well - do you have some CI machines with these versions to test? I don't. For SDL i

Re: [Qemu-devel] [PATCH v5 0/5] off-by-one and NULL pointer accesses detected by static analysis

2018-11-11 Thread Max Reitz
On 05.11.18 22:38, Liam Merwick wrote: > Below are a number of fixes to some off-by-one, read outside array bounds, and > NULL pointer accesses detected by an internal Oracle static analysis tool > (Parfait). > https://labs.oracle.com/pls/apex/f?p=labs:49:P49_PROJECT_ID:13 I decided to just

Re: [Qemu-devel] [PATCH v5 4/5] block: Fix potential Null pointer dereferences in vvfat.c

2018-11-11 Thread Max Reitz
On 05.11.18 22:38, Liam Merwick wrote: > The calls to find_mapping_for_cluster() may return NULL but it > isn't always checked for before dereferencing the value returned. > Additionally, add some asserts to cover cases where NULL can't > be returned but which might not be obvious at first glance.

Re: [Qemu-devel] [PATCH v5 2/5] block: Null pointer dereference in blk_root_get_parent_desc()

2018-11-11 Thread Max Reitz
On 05.11.18 22:38, Liam Merwick wrote: > The dev_id returned by the call to blk_get_attached_dev_id() in > blk_root_get_parent_desc() can be NULL (an internal call to > object_get_canonical_path may have returned NULL). > > Instead of just checking this case before before dereferencing, > adjust

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] ppc/spapr: Receive and store device tree blob from SLOF

2018-11-11 Thread Greg Kurz
Hi Alexey, Just a few remarks. See below. On Thu, 8 Nov 2018 12:44:06 +1100 Alexey Kardashevskiy wrote: > SLOF receives a device tree and updates it with various properties > before switching to the guest kernel and QEMU is not aware of any changes > made by SLOF. Since there is no real RTAS

Re: [Qemu-devel] [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-11 Thread Nir Soffer
On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote: > On Wed, Nov 7, 2018 at 7:27 PM Kevin Wolf wrote: > >> Am 07.11.2018 um 15:56 hat Nir Soffer geschrieben: >> > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones >> wrote: >> > >> > > Another thing I tried was to change the NBD server (nbdkit) so

[Qemu-devel] [PATCH v2 1/1] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Yuri Benditovich
This commit adds implementation of RX packets coalescing, compatible with requirements of Windows Hardware compatibility kit. The device enables feature VIRTIO_NET_F_RSC_EXT in host features if it supports extended RSC functionality as defined in the specification. This feature requires at least

[Qemu-devel] [PATCH v2 0/1] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Yuri Benditovich
Changes from v1: * Changes in standard header moved to virtio_net.c * added inline procedures for header fields access * Removed unused define * Removed unrelated changes * Renamed RSC timeout define * Removed unnecessary check for VHOST * RSC struct names prefixed by Virtio * Added note about

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-11 Thread Nir Soffer
On Wed, Nov 7, 2018 at 6:42 PM Eric Blake wrote: > On 11/7/18 6:13 AM, Richard W.M. Jones wrote: > > (I'm not going to claim this is a bug, but it causes a large, easily > > measurable performance regression in virt-v2v). > > I haven't closely looked at at this email thread yet, but a quick

Re: [Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread Programmingkid
> On Nov 11, 2018, at 6:55 AM, qemu-devel-requ...@nongnu.org wrote: > > The code for the cocoa stuff is in ui/cocoa.m. Quick notes on structure: > > * there is a weird thing where cocoa.m provides its own main(), and arranges > that the function which is main() for every other UI is renamed

Re: [Qemu-devel] [PATCH v3 7/7] arm: fix aa64_generate_debug_exceptions to work with EL2

2018-11-11 Thread Peter Maydell
On 9 November 2018 at 15:21, Alex Bennée wrote: > The test was incomplete and incorrectly caused debug exceptions to be > generated when returning to EL2 after a failed attempt to single-step > an EL1 instruction. Fix this while cleaning up the function a little. > @@ -2833,9 +2845,6 @@ static

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread Programmingkid
> On Nov 11, 2018, at 2:39 AM, qemu-devel-requ...@nongnu.org wrote: > > Thanks for the bug report. It looks like Mojave is pickier about apps > not calling various GUI update functions from the "wrong" thread. We > probably need to figure out how to dispatch those to the main thread > instead

Re: [Qemu-devel] [PATCH v3 7/7] arm: fix aa64_generate_debug_exceptions to work with EL2

2018-11-11 Thread Richard Henderson
On 11/9/18 4:21 PM, Alex Bennée wrote: > The test was incomplete and incorrectly caused debug exceptions to be > generated when returning to EL2 after a failed attempt to single-step > an EL1 instruction. Fix this while cleaning up the function a little. > > Signed-off-by: Alex Bennée > > --- >

Re: [Qemu-devel] [PATCH v3 5/7] tests/guest-debug: don't use symbol resolution for PC checks

2018-11-11 Thread Richard Henderson
On 11/9/18 4:21 PM, Alex Bennée wrote: > It turns out symbol resolution isn't enough as modern kernels are > often padded with check code at the start of functions. GDB seems to > put the breakpoint at the first non-check instruction which causes > comparisons with the symbol resolution to fail.

Re: [Qemu-devel] [PATCH v3 1/7] target/arm64: properly handle DBGVR RESS bits

2018-11-11 Thread Richard Henderson
On 11/9/18 4:21 PM, Alex Bennée wrote: > This only fails with some (broken) versions of gdb but we should > treat the top bits of DBGBVR as RESS. Properly sign extend QEMU's > reference copy of dbgbvr and also update the register descriptions in > the comment. > > Signed-off-by: Alex Bennée

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread Peter Maydell
Thanks for having a look at this. The cocoa UI does work for me on High Sierra, for what that's worth. https://wiki.qemu.org/Contribute/SubmitAPatch has our patch submission process. My feeling on SDL is that this would be a bug to fix in upstream SDL, assuming we're not breaking any "which

Re: [Qemu-devel] proper-dev dependencies..

2018-11-11 Thread Peter Maydell
On 11 November 2018 at 12:07, watk...@hungry.com wrote: > I've been following the list for awhile does anyone have a proper list of > all the ubuntu dependencies? > So, one can compile the whole ball of wax properly? If you're running on Ubuntu and have your apt sources set up to include source

[Qemu-devel] proper-dev dependencies..

2018-11-11 Thread watk...@hungry.com
I've been following the list for awhile does anyone have a proper list of all the ubuntu dependencies? So, one can compile the whole ball of wax properly?

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread inactive
I made DisplayChangeListener callbacks dispatch updates to the main thread and it stopped crashing. However, pure Cocoa UI seems non- functional - I can't focus the window, I don't see any application menus, and the fb does not update. I'm looking at making SDL code thread-safe the same way -

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-11 Thread Peter Maydell
The code for the cocoa stuff is in ui/cocoa.m. Quick notes on structure: * there is a weird thing where cocoa.m provides its own main(), and arranges that the function which is main() for every other UI is renamed qemu_main() and called later (I'd like to get rid of that one day if we could,

Re: [Qemu-devel] [RFC] [PATCH] kvm: arm: Introduce error code KVM_EINVARIANT

2018-11-11 Thread Marc Zyngier
On Sat, 10 Nov 2018 22:18:47 +, Manish Jaggi wrote: > > > CCing a larger audience. > Please review. > > On 10/23/2018 03:51 PM, Jaggi, Manish wrote: > > From: Manish Jaggi > > > > This patch introduces an error code KVM_EINVARIANT which is returned > > by KVM when userland tries to set an

Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Add scripts/decodetree.py to the TCG section

2018-11-11 Thread Richard Henderson
On 11/10/18 10:13 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Queued, thanks. r~

Re: [Qemu-devel] [PATCH] decodetree: Force Python to print unsigned values

2018-11-11 Thread Richard Henderson
On 11/11/18 1:02 AM, Philippe Mathieu-Daudé wrote: > Python internal representation is signed, so unsigned values > bigger than 31-bit are interpreted as signed (and printed with > a '-' signed). > Mask out to force unsigned values. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH 2/2] decodetree: Add multiple include guard

2018-11-11 Thread Richard Henderson
On 11/10/18 10:13 PM, Philippe Mathieu-Daudé wrote: > It is necessary when splitting an ISA, or when using multiple ISAs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/decodetree.py | 5 + > 1 file changed, 5 insertions(+) I guess I have no problems with this, but can you

Re: [Qemu-devel] [PATCH v2 05/22] hw/rdma: Add support for MAD packets

2018-11-11 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 08:15:27PM +0200, Marcel Apfelbaum wrote: > Hi Yuval > > On 11/8/18 6:08 PM, Yuval Shaia wrote: > > MAD (Management Datagram) packets are widely used by various modules > > both in kernel and in user space for example the rdma_* API which is > > used to create and maintain

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Yuri Benditovich
On Fri, Nov 9, 2018 at 8:11 PM Michael S. Tsirkin wrote: > Looks good to me. Some comments below > > On Fri, Nov 09, 2018 at 04:58:27PM +0200, Yuri Benditovich wrote: > > This commit adds implementation of RX packets > > coalescing, compatible with requirements of Windows > > Hardware

Re: [Qemu-devel] [PATCH for-3.1] fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled

2018-11-11 Thread Philippe Mathieu-Daudé
On Sun, Nov 11, 2018 at 10:41 AM Mark Cave-Ayland wrote: > Commit c8a35f1cf0f "fdc: use IsaDma interface instead of global DMA_* > functions" accidentally introduced a segfault in fdctrl_stop_transfer() for > non-DMA transfers. > > If fdctrl->dma_chann has not been configured then the fdctrl->dma

[Qemu-devel] [PATCH for-3.1] fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled

2018-11-11 Thread Mark Cave-Ayland
Commit c8a35f1cf0f "fdc: use IsaDma interface instead of global DMA_* functions" accidentally introduced a segfault in fdctrl_stop_transfer() for non-DMA transfers. If fdctrl->dma_chann has not been configured then the fdctrl->dma interface reference isn't initialised during isabus_fdc_realize().

Re: [Qemu-devel] [PATCH v2 03/22] hw/rdma: Return qpn 1 if ibqp is NULL

2018-11-11 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 07:59:00PM +0200, Marcel Apfelbaum wrote: > Hi Yuval, > > On 11/8/18 6:07 PM, Yuval Shaia wrote: > > Device is not supporting QP0, only QP1. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma_backend.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v2 08/22] hw/pvrdma: Set the correct opcode for recv completion

2018-11-11 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 08:18:58PM +0200, Marcel Apfelbaum wrote: > > > On 11/8/18 6:08 PM, Yuval Shaia wrote: > > The function pvrdma_post_cqe populates CQE entry with opcode from the > > given completion element. For receive operation value was not set. Fix > > it by setting it to IBV_WC_RECV.

Re: [Qemu-devel] [PATCH v2 09/22] hw/pvrdma: Set the correct opcode for send completion

2018-11-11 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 08:21:51PM +0200, Marcel Apfelbaum wrote: > > > On 11/8/18 6:08 PM, Yuval Shaia wrote: > > opcode for WC should be set by the device and not taken from work > > element. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- > > 1 file