[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1513234
Title:
Cannot
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1800786
Title:
USB
On Tue, Dec 11, 2018 at 04:48:23PM +0100, Igor Mammedov wrote:
> On Tue, 11 Dec 2018 13:29:19 +0300
> Ilya Maximets wrote:
>
> CCing libvirt folk for an opinion
>
> > On 10.12.2018 19:18, Igor Mammedov wrote:
> > > On Tue, 27 Nov 2018 16:50:27 +0300
> > > Ilya Maximets wrote:
> > >
> > >
Make them more QOMConventional.
Cc:qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
hw/i386/kvm/ioapic.c | 2 +-
hw/i386/pc.c | 4 ++--
hw/intc/ioapic.c | 2 +-
include/hw/i386/ioapic.h | 3 +++
4 files changed, 7 insertions(+), 4 deletions(-)
diff --git
On Wed, Jan 02, 2019 at 01:30:28AM +, Kang, Luwei wrote:
> > > On 25/12/18 09:23, Kang, Luwei wrote:
> > > >> From: Qemu-devel
> > > >> [mailto:qemu-devel-bounces+luwei.kang=intel@nongnu.org] On
> > > >> Behalf Of Paolo Bonzini
> > > >> Sent: Friday, December 21, 2018 8:44 PM
> > > >> To:
Hi,
I have a similar patch in my queue[1]
On 2019-01-04 16:39, Eric Blake wrote:
> Use the __auto_type keyword to make sure our min/max macros only
> evaluate their arguments once.
>
> Signed-off-by: Eric Blake
> ---
>
> RFC because __auto_type didn't exist until gcc 4.9, and I don't know
>
On 12/18/18 9:11 AM, Vladimir Sementsov-Ogievskiy wrote:
> 15.12.2018 16:53, Eric Blake wrote:
>> Our copy-and-pasted open-coding of strtol handling forgot to
>> handle overflow conditions. Use qemu_strto*() instead.
>>
>> In the case of --partition, since we insist on a user-supplied
>>
On 12/17/18 9:19 AM, Eric Blake wrote:
>>
>>> +@c man begin EXAMPLES
>>> +Start a server listening on port 10809 that exposes only the
>>> +guest-visible contents of a qcow2 file, with no TLS encryption, and
>>> +with the default export name (an empty string). The command will block
>>> +until
On 12/18/18 7:46 AM, Vladimir Sementsov-Ogievskiy wrote:
> 15.12.2018 16:53, Eric Blake wrote:
>> The next commit will add an EXAMPLES section to qemu-nbd.8;
>> for that to work, we need to recognize EXAMPLES in texi2pod,
>> and we need to make all man pages be regenerated since the
>> output of
Right, that makes sense, thanks for the explanations. As someone with
very little x86 experience (zero experience from this perspective)
it's kind of daunting that I'd have to refactor all this stuff. All
these helpers via macros to get around C's 'minimalism' also seem like
something I'd have to
On Fri, Jan 04, 2019 at 04:13:15PM -0500, Michael S. Tsirkin wrote:
> On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote:
> > On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote:
> > > On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote:
> > > > On Fri, Jan
From: Michael Clark
CSR predicate functions are added to the CSR table.
mstatus.FS and counter enable checks are moved
to predicate functions and two new predicates are
added to check misa.S for s* CSRs and a new PMP
CPU feature for pmp* CSRs.
Processors that don't implement S-mode will trap
on
From: Michael Clark
Use the new CSR read/modify/write interface to implement
atomic updates to mip/sip.
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Cc: Palmer Dabbelt
Cc: Alistair Francis
Signed-off-by: Michael Clark
Signed-off-by: Alistair Francis
---
target/riscv/csr.c | 56
From: Michael Clark
Previous CSR code uses csr_read_helper and csr_write_helper
to update CSR registers however this interface prevents
atomic read/modify/write CSR operations; in addition
there is no trap-free method to access to CSRs due
to the monolithic CSR functions call longjmp.
The
This is one of the big patches that the RISC-V fork has that we don't.
After this it should be straight forward to upstream the remaining
patches.
Michael Clark (3):
RISC-V: Implement modular CSR helper interface
RISC-V: Implement atomic mip/sip CSR updates
RISC-V: Implement existential
On 1/5/19 8:09 AM, Nick Renieris wrote:
> Στις Παρ, 4 Ιαν 2019 στις 11:51 μ.μ., ο/η Richard Henderson
> έγραψε:
>> As an integer it is always passed by value. As a structure some host abis
>> pass
>> it by reference, and the TCG compiler doesn't know about that.
>
> Ah so they modify it? If so
On Fri, Jan 4, 2019 at 6:28 AM Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> Add MicroBlaze CPU properties to enable exceptions on failed
> bus accesses.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> target/microblaze/cpu.c | 12
This routine was becoming too large.
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.inc.c | 459 +++---
1 file changed, 232 insertions(+), 227 deletions(-)
diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
index c21c3272f2..ad97386d06
Signed-off-by: Richard Henderson
---
accel/tcg/tcg-runtime.h | 20
tcg/aarch64/tcg-target.h | 1 +
tcg/i386/tcg-target.h| 1 +
tcg/tcg-op-gvec.h| 10 ++
tcg/tcg-op.h | 4 +
tcg/tcg-opc.h| 4 +
tcg/tcg.h
I've split this out from the target/ppc patch set in which
it was developed.
r~
Richard Henderson (10):
tcg: Add logical simplifications during gvec expand
tcg: Add gvec expanders for nand, nor, eqv
tcg: Add write_aofs to GVecGen4
tcg: Add opcodes for vector saturated arithmetic
tcg:
On 1/5/19 7:43 AM, Nick Renieris wrote:
> Just curious, why is gvec-desc a bitfield instead of a normal struct?
> Surely it'd be more readable that way. Also this is C, so it's not
> even a typed bitfield, just a uint32. I'm guessing there's a reason
> behind this?
As an integer it is always
This allows writing 2 output, 3 input operations.
Signed-off-by: Richard Henderson
---
tcg/tcg-op-gvec.h | 2 ++
tcg/tcg-op-gvec.c | 27 +++
2 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/tcg/tcg-op-gvec.h b/tcg/tcg-op-gvec.h
index
Only MO_8 and MO_16 are implemented, since that's all the
instruction set provides.
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.h | 2 +-
tcg/i386/tcg-target.inc.c | 42 +++
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git
Στις Σάβ, 5 Ιαν 2019 στις 12:14 π.μ., ο/η Richard Henderson
έγραψε:
> No, it's just calling conventions. And it could be worked around, but I think
> what we have is convenient enough.
>
> Especially since the sizes are encoded as (n+1)*8, which also shows the
> compiler that the size is
Ohh got it, thanks.
Στις Σάβ, 5 Ιαν 2019 στις 12:38 π.μ., ο/η Richard Henderson
έγραψε:
>
> On 1/5/19 8:33 AM, Nick Renieris wrote:
> > I know host ABI's can differ like that, but I don't understand why
> > that should matter. Everything (TCG compiler included) is compiled
> > with the same way,
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.h | 1 +
tcg/i386/tcg-target.h| 1 +
tcg/tcg-op.h | 4 ++
tcg/tcg-opc.h| 4 ++
tcg/tcg.h| 1 +
tcg/tcg-op-gvec.c| 84 ++--
tcg/tcg-op-vec.c
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.h | 2 +-
tcg/aarch64/tcg-target.inc.c | 24
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h
index a1884543d0..2d93cf404e 100644
---
Patchew URL: https://patchew.org/QEMU/20190104153951.32306-1-ebl...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 1/5/19 8:33 AM, Nick Renieris wrote:
> I know host ABI's can differ like that, but I don't understand why
> that should matter. Everything (TCG compiler included) is compiled
> with the same way, right? For the host arch.
No, not all of the pieces are compiled the same way. TCG generates
On 1/4/19 4:31 AM, Mark Cave-Ayland wrote:
> Fixing the vsplt instruction now gives a readable display in my MacOS tests,
> but I'm
> still seeing "shadows" such as
> https://www.ilande.co.uk/tmp/qemu/badapple4.png which
> I've bisected down to:
>
>
> commit
Reviewed-by: David Gibson
Signed-off-by: Richard Henderson
---
accel/tcg/tcg-runtime.h | 3 +++
tcg/tcg-op-gvec.h| 6 +
tcg/tcg-op.h | 3 +++
accel/tcg/tcg-runtime-gvec.c | 33 +++
tcg/tcg-op-gvec.c| 51
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.h | 2 +-
tcg/aarch64/tcg-target.inc.c | 24
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h
index 545a6eec75..a1884543d0 100644
---
The avx instruction set does not directly provide MO_64.
We can still implement 64-bit with comparison and vpblendvb.
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.h | 2 +-
tcg/i386/tcg-target.inc.c | 81 +++
2 files changed, 82
We handle many of these during integer expansion, and the
rest of them during integer optimization.
Reviewed-by: David Gibson
Signed-off-by: Richard Henderson
---
tcg/tcg-op-gvec.c | 35 ++-
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git
On Fri, 4 Jan 2019, Philippe Mathieu-Daudé wrote:
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 4a8686f0f5..2122291308 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -32,7 +32,6 @@
#include "hw/hw.h"
#include "hw/char/serial.h"
#include "ui/console.h"
-#include
On 7/31/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote:
> Reconnect will be implemented in the following commit, so for now,
> in semantics below, disconnect itself is a "serious error".
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/block-core.json | 12 +++-
>
Στις Παρ, 4 Ιαν 2019 στις 11:51 μ.μ., ο/η Richard Henderson
έγραψε:
> As an integer it is always passed by value. As a structure some host abis
> pass
> it by reference, and the TCG compiler doesn't know about that.
Ah so they modify it? If so it could surely be worked around with
explicit
On 2019-01-01 17:17, Programmingkid wrote:
>
>> On Jan 1, 2019, at 7:27 AM, Zoltán Kővágó wrote:
>>
>> On 2019-01-01 05:24, Programmingkid wrote:
On 2018-12-29 01:49, Programmingkid wrote:
>> [snip]
>
> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic
>
On 1/4/19 12:31 PM, Alberto Garcia wrote:
> On Thu 03 Jan 2019 10:42:30 PM CET, Eric Blake wrote:
>
>> In my view, code generators make sense when used on code that is
>> expected to change over time (a good example is QAPI because we add
>> new commands every release; other places might be a
On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote:
> On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote:
> > On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote:
> > > On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote:
> > > > On Fri, Jan 04,
On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote:
> On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote:
> > On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote:
> > > On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote:
> > > > *
Most likely some bits are initialized differently in the FPCR.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1701835
Title:
floating-point operation bugs in qemu-alpha
Status in QEMU:
New
Bug
On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote:
> On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote:
> > On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote:
> > > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > > On Fri, Jan 04, 2019 at
> You should try building with -mieee.
When I build with
../configure CFLAGS="-mieee -O2 -g" CPPFLAGS=-Wall LDFLAGS="-static -lieee"
I observe the exact same behaviour: Only 4 tests fail in a VM executed with
qemu-system-alpha, whereas the same test failures (from test-cbrt to
test-truncf1) are
On Fri, 4 Jan 2019 14:30:50 +0100
Cédric Le Goater wrote:
> The error value can be squashed by the section handling radix migration.
> Simply bail out if an error occurs when the RTC offset is imported.
>
> This fixes the Coverity issue CID 1398591.
>
> Fixes: d39c90f5f3ae ("spapr: Fix
Hi,
I was wondering why one virtio-pci device has two different
DeviceState? - one directly from VirtIOPCIProxy and the other from
VirtIO such as VirtIONet. As an example, they are denoted as
qdev and vdev respectively in virtio_net_pci_realize().
I thought that just one DeviceState is enough
On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote:
> Many functions have documentation before the implementation in
> cutils.c. Since we expect documentation around the prototype
> declaration in headers, move the comments in cutils.h.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote:
> Introduced in cd390083ad1, these macros don't need to be in
> a generic header.
> Add documentation to justify their use.
>
> Reviewed-by: Stefano Garzarella
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> +++ b/include/qemu/cutils.h
> @@
On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote:
> On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote:
> > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote:
> > > > The virtio-pci entries in
These will be used to let GDB know about PPC's Special Purpose
Registers (SPR).
They take an index based on the order the registers appear in the XML
file sent by QEMU to GDB. This index does not match the actual
location of the registers in the env->spr array so the
gdb_find_spr_idx function
On 2018-12-27 07:34, Yang Zhong wrote:
> Only keep same boards definitions as i386-softmmu.mak in
> x86_64-softmmu.mak.
>
> Signed-off-by: Yang Zhong
> ---
> default-configs/x86_64-softmmu.mak | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git
This series implements the reading and writing of Special Purpose
Registers in PPC's gdbstub.
* How it works generally [1]:
GDB asks for the target.xml file which contains the target description
along with the list of available feature XMLs. GDB then asks for each
of the XML files in sequence.
This allows reading and writing of SPRs via GDB:
(gdb) p/x $srr1
$1 = 0x82803033
(gdb) p/x $pvr
$2 = 0x4b0201
(gdb) set $pvr=0x4b
(gdb) p/x $pvr
$3 = 0x4b
They can also be shown as a group:
(gdb) info reg spr
Signed-off-by: Fabiano Rosas
---
target/ppc/translate_init.inc.c |
A following patch will add support for handling the Special Purpose
Registers (SPR) in GDB via gdbstub. For that purpose, GDB needs to be
provided with an XML description of the registers (see gdb-xml
directory).
This patch adds the code that generates the XML dynamically based on
the SPRs
On 04/01/19 15:50, Peter Maydell wrote:
> The hexloader test invokes QEMU with the -nographic argument. This
> is unnecessary, because the qtest_initf() function will pass it
> -display none, which suffices to disable the graphical window.
> It also means that the QEMU process will make the
On 2018-12-27 07:34, Yang Zhong wrote:
> Signed-off-by: Yang Zhong
> ---
> default-configs/i386-softmmu.mak | 1 -
> hw/9pfs/Kconfig | 2 ++
> hw/block/Kconfig | 2 ++
> hw/char/Kconfig | 2 ++
> hw/display/Kconfig | 5 +
>
On 04/01/19 16:38, Thomas Huth wrote:
> On 2018-12-27 07:34, Yang Zhong wrote:
>> remove default-configs/hyperv.mak and make dependencies
>> with Kconfig.
>>
>> Signed-off-by: Yang Zhong
>> ---
>> default-configs/hyperv.mak | 2 --
>> default-configs/i386-softmmu.mak | 1 -
>>
On Fri, Jan 4, 2019 at 10:31 AM Philippe Mathieu-Daudé
wrote:
>
> On 1/4/19 7:20 PM, Philippe Mathieu-Daudé wrote:
> > When the device is disable, the internal circuitry keep the data
>
> "keep" -> "keeps"
>
> > register loaded and doesn't update it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé
On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote:
> The size_to_str() function doesn't need to be in a generic header.
>
> It makes also sens to find this function in the same header than
s/sens/sense/ s/than/as/
> the opposite string to size functions: qemu_strtosz*().
> Note than this
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/aspeed.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 5158985482..817f9e1400 100644
> ---
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> As init helper in "hw/char/pl011.h"
> ---
> hw/net/smc91c111.c | 17 -
> include/hw/net/smc91c111.h | 25 -
> 2 files changed, 24 insertions(+), 18
Hmm, qemu-system-alpha ? The guest kernel should be doing the same thing
it would on real hardware -- I guess we're getting the value of the
exception address wrong when we deliver the exception to it.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
00)
>
> are available in the Git repository at:
>
> https://github.com/philmd/qemu.git tags/fw_cfg-20190104-pull-request
>
> for you to fetch changes up to 19bcc4bc3213e78c303ad480a7a578f62258252d:
>
> fw_cfg: Make qemu_extra
On Fri, 14 Dec 2018 at 05:24, Richard Henderson
wrote:
>
> While we could expose stage_1_mmu_idx, the combination is
> probably going to be more useful.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
On Fri, 14 Dec 2018 at 05:24, Richard Henderson
wrote:
>
> Not that there are any stores involved, but why argue with ARM's
> naming convention.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate-a64.c | 62 ++
> 1 file changed, 62
On 1/4/19 7:20 PM, Philippe Mathieu-Daudé wrote:
> When the device is disable, the internal circuitry keep the data
"keep" -> "keeps"
> register loaded and doesn't update it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/char/stm32f2xx_usart.c | 3 +--
> 1 file changed, 1 insertion(+),
Public bug reported:
For some reason the SIGILL handler receives a different address under
qemu than it used to on real hardware. I don't know specifics about the
hardware used back then – it was some sort of 21264a somewhere between
600-800 MHz –, and I cannot say anything about the kernel as
On Fri, 4 Jan 2019 at 17:41, Aleksandar Markovic wrote:
>
> > Applied, thanks.
> >
> > Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
> > for any user-visible changes.
>
> I updated the change log with a single item, as I mentioned in the pull
> request cover letter:
>
>
The size_to_str() function doesn't need to be in a generic header.
It makes also sens to find this function in the same header than
the opposite string to size functions: qemu_strtosz*().
Note than this function is already implemented in util/cutils.c.
Since we introduce a new function in a
When the device is disable, the internal circuitry keep the data
register loaded and doesn't update it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/char/stm32f2xx_usart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c
Signed-off-by: Philippe Mathieu-Daudé
---
As init helper in "hw/char/pl011.h"
---
hw/net/smc91c111.c | 17 -
include/hw/net/smc91c111.h | 25 -
2 files changed, 24 insertions(+), 18 deletions(-)
diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c
This commit finally deletes "hw/devices.h".
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/gumstix.c | 2 +-
hw/arm/integratorcp.c | 2 +-
hw/arm/mainstone.c | 2 +-
hw/arm/realview.c | 2 +-
hw/arm/versatilepb.c | 2 +-
hw/net/smc91c111.c |
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/net/ne2000-isa.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/hw/net/ne2000-isa.h b/include/hw/net/ne2000-isa.h
index ff2bed9c95..527337c454 100644
--- a/include/hw/net/ne2000-isa.h
+++ b/include/hw/net/ne2000-isa.h
@@
Many functions have documentation before the implementation in
cutils.c. Since we expect documentation around the prototype
declaration in headers, move the comments in cutils.h.
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/cutils.h | 224 ++
Introduced in cd390083ad1, these macros don't need to be in
a generic header.
Add documentation to justify their use.
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
v2: Fixed checkpatch warnings (tabs)
---
hw/core/bus.c | 2 +-
hw/core/qdev-properties.c
This series is a fairly trivial cleanup of "cutils.h"
(size_to_str() and ctype macros moved into it), and
some documentation improvements.
Since v1:
- Fixed checkpatch errors (patchew)
- Added Stefano R-b
There are still checkpatch warnings (due to 8c06fbdf36b) for using the
Doxygen '/**'
MouseTransformInfo is only used in "ui/console.h", there is no
need to expose it via "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/typedefs.h | 1 -
include/ui/console.h| 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/kzm.c | 2 +-
hw/arm/mps2.c| 2 +-
hw/arm/realview.c| 1 +
hw/arm/vexpress.c| 2 +-
hw/net/lan9118.c | 2 +-
include/hw/devices.h | 3 ---
include/hw/net/lan9118.h | 21
Since uWireSlave is only used in this new header, there is no
need to expose it via "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 ++
hw/arm/nseries.c| 2 +-
hw/arm/palm.c | 2 +-
hw/input/tsc2005.c
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4_boards.c | 3 ++-
hw/arm/mps2-tz.c | 3 ++-
hw/net/lan9118.c | 1 -
include/hw/net/lan9118.h | 2 ++
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
index
PS2State is only used in "hw/input/ps2.h", there is no
need to expose it via "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/input/ps2.h | 2 ++
include/qemu/typedefs.h | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/input/ps2.h
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
hw/arm/nseries.c | 1 +
hw/display/blizzard.c | 2 +-
include/hw/devices.h | 7 ---
include/hw/display/blizzard.h | 21 +
5 files changed, 24 insertions(+), 8
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 1 +
hw/arm/stellaris.c | 2 +-
hw/input/stellaris_input.c | 2 +-
include/hw/devices.h | 3 ---
include/hw/input/gamepad.h | 11 +++
5 files changed, 14 insertions(+), 5 deletions(-)
create mode
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
hw/arm/tosa.c | 2 +-
hw/display/tc6393xb.c | 2 +-
include/hw/devices.h | 9 -
include/hw/display/tc6393xb.h | 25 +
5 files changed, 28
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 1 +
hw/arm/nseries.c | 1 +
hw/misc/cbus.c | 2 +-
include/hw/devices.h | 14 --
include/hw/misc/cbus.h | 31 +++
5 files changed, 34 insertions(+), 15 deletions(-)
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f571b29077..03872552ee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -640,6 +640,7 @@ M: Peter Maydell
L: qemu-...@nongnu.org
S: Odd Fixes
F:
Introduced in 64b40bc54a9, this definition is no more used since
a0b753dfd39. Remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/devices.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/devices.h b/include/hw/devices.h
index 0e27feb0c2..4019b3be17 100644
---
Signed-off-by: Philippe Mathieu-Daudé
---
hw/alpha/typhoon.c | 1 -
hw/arm/allwinner-a10.c | 1 -
hw/arm/collie.c | 1 -
hw/arm/cubieboard.c | 1 -
hw/arm/highbank.c| 1 -
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 5158985482..817f9e1400 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -19,6 +19,8 @@
#include
Hi,
As the first comment describes, the "hw/devices.h" contains declarations
for "Devices that have nowhere better to go."
This series remove it, creating new headers for devices covered there.
MAINTAINERS is updated.
I also included 2 cleanups while working on this, in "qemu/typedefs.h"
and
It's now possible to use the common function.
Teach object_apply_global_props() to warn if Error argument is NULL.
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
Reviewed-by: Cornelia Huck
Acked-by: Eduardo Habkost
---
hw/core/qdev-properties.c | 24 ++--
On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote:
> > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit
> > > assumption: that all virtio-pci
Use static arrays instead. I decided to rename the conflicting
pc_compat_2_2() function with pc_compat_2_2_fn().
Suggested-by: Eduardo Habkost
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
Reviewed-by: Cornelia Huck
Acked-by: Eduardo Habkost
---
include/hw/boards.h | 3 ++
> Applied, thanks.
>
> Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
> for any user-visible changes.
I updated the change log with a single item, as I mentioned in the pull
request cover letter:
https://wiki.qemu.org/ChangeLog/4.0#MIPS
Thanks,
Aleksandar
> -- PMM
All qdev_prop_register_global() set _fatal for errp, except
'-rtc driftfix=slew', which arguably should also use _fatal, as
otherwise failing to apply the property would only report a warning.
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
Reviewed-by: Cornelia Huck
Acked-by:
hostmem-file and hostmem-memfd use the whole object path for the
memory region name, and hostname-ram uses only the path component (the
object id, or canonical path basename):
qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa
node,memdev=mem -monitor stdio
(qemu)
The header is now empty.
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
Reviewed-by: Cornelia Huck
Acked-by: Eduardo Habkost
---
include/hw/compat.h| 4
include/hw/i386/pc.h | 1 -
hw/arm/virt.c | 1 -
hw/ppc/spapr.c | 1 -
Use static arrays instead.
Suggested-by: Eduardo Habkost
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
Reviewed-by: Cornelia Huck
Acked-by: Eduardo Habkost
---
include/hw/boards.h| 3 ++
include/hw/compat.h| 27 --
include/hw/i386/pc.h | 74
Replace arm_cpu_post_init() instance callback by calling it from leaf
classes, to avoid potential ordering issue with other post_init callbacks.
Signed-off-by: Marc-André Lureau
Suggested-by: Igor Mammedov
Reviewed-by: Igor Mammedov
Acked-by: Eduardo Habkost
---
target/arm/cpu-qom.h | 3 +++
Use static arrays instead. I decided to rename the conflicting
pc_compat_2_1() function with pc_compat_2_1_fn().
Suggested-by: Eduardo Habkost
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
Reviewed-by: Cornelia Huck
Acked-by: Eduardo Habkost
---
include/hw/boards.h | 3 +++
1 - 100 of 252 matches
Mail list logo
