Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 7 Feb 2020 at 14:43, Markus Armbruster wrote: > > >> Here's a style I'd dislike less: [...] >> # @file: >> # Node to create the image format on >> # >> # @size: >> # Size of the virtual disk in bytes >> # >> # @log-size: >> # Log

Re: [PATCH 02/29] configure: Check that sphinx-build is using Python 3

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 7 Feb 2020 at 16:18, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > Currently configure's has_sphinx_build() check simply runs a dummy >> > sphinx-build and either passes or fails. This means that "no >> > sphinx-build at all" and "sphinx-build

Re: [PATCH rc4 06/29] target/avr: Add defintions of AVR core types

2020-02-07 Thread Aleksandar Markovic
On Sunday, February 2, 2020, Joaquin de Andres wrote: > On 1/31/20 1:02 AM, Aleksandar Markovic wrote: > >> From: Michael Rolnik >> >> AVR core types are: >> >>- avr1 >>- avr2 >>- avr25 >>- avr3 >>- avr31 >>- avr35 >>- avr4 >>- avr5 >>- avr51 >>- avr6 >>

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread Markus Armbruster
Eric Blake writes: > On 2/6/20 12:18 PM, Dr. David Alan Gilbert wrote: > >>> >>> Pain points of JSON include having to count parenthesises and having to >>> quote so bloody much. Additional QMP pain points include long names and >>> excessive nesting. >> >> Some other pet hates: >>a) Number

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread Markus Armbruster
John Snow writes: > On 2/6/20 9:21 AM, Kevin Wolf wrote: [...] >> 2. Rewriting qmp-shell to use a better syntax for nested data >>structures. This would have to be defined before the project starts. >> > > ... Can't start until we define the proper interface, because then we > have to

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread Markus Armbruster
John Snow writes: > A note: > > qmp-shell could offer some sugared versions of things like "query-block" > that do some work understanding the reply from QEMU and printing it in a > nice human format. This is exactly how HMP commands should work. By moving them to qmp-shell, we get to code

Re: [PATCH] !fixup "target/avr: Add defintions of AVR core types"

2020-02-07 Thread Aleksandar Markovic
On Friday, February 7, 2020, Philippe Mathieu-Daudé wrote: > These cores have unresolved review comment: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg674105.html > https://www.mail-archive.com/qemu-devel@nongnu.org/msg674259.html > and: >

[qemu-web PATCH] Force background color

2020-02-07 Thread athurh
Browsers can have a different default background color defined. Setting the background image overwrites other background definitions. --- assets/css/style-desktop.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/assets/css/style-desktop.css b/assets/css/style-desktop.css index

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-07 Thread BALATON Zoltan
Hello, On Fri, 7 Feb 2020, jasper.low...@bt.com wrote: I haven't figured out where that is coming from. The error doesn't look like it's in the OpenSolaris source code so I don't have any context behind it. The error does show up here:

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200207174548.9087-1-li...@roeck-us.net/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200207174548.9087-1-li...@roeck-us.net/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Peter Xu
On Fri, Feb 07, 2020 at 05:24:54AM -0500, Michael S. Tsirkin wrote: > On Fri, Feb 07, 2020 at 11:05:40AM +0100, Jean-Philippe Brucker wrote: > > Hi Eric, > > > > On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: > > > At the moment, the kernel only supports device tree > > > integration

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Guenter Roeck
On Fri, Feb 07, 2020 at 02:04:09PM -0800, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200207174548.9087-1-li...@roeck-us.net/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you

Re: [PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-07 Thread Robert Foley
On Fri, 7 Feb 2020 at 12:12, Alex Bennée wrote: > Robert Foley writes: > > > This adds logging of the char device used by the console > > to a file. The basevm.py then uses this file to read > > chars from the console. > > One reason to add this is to aid with debugging. > > I can certainly see

Re: [PATCH v2 01/30] hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels

2020-02-07 Thread BALATON Zoltan
On Fri, 7 Feb 2020, Philippe Mathieu-Daudé wrote: On 2/6/20 1:21 PM, BALATON Zoltan wrote: On Thu, 6 Feb 2020, Philippe Mathieu-Daudé wrote: When booting without device tree, the Linux kernels uses the $R1 register to determine the machine type. The list of values is registered at [1]. There

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Niek Linnenbank
On Fri, Feb 7, 2020, 22:34 Guenter Roeck wrote: > On Fri, Feb 07, 2020 at 10:25:01PM +0100, Niek Linnenbank wrote: > > Hi Guenter, > > > > On Fri, Feb 7, 2020 at 6:46 PM Guenter Roeck wrote: > > > > > Initialize EHCI controllers on AST2600 using the existing > > > TYPE_PLATFORM_EHCI. After this

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200207174548.9087-1-li...@roeck-us.net/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread John Snow
On 2/6/20 1:18 PM, Dr. David Alan Gilbert wrote: > But, for machine representations, I'm not sure moving away from JSON is > a requirement. This is not really on the table. --js

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-02-07 Thread Eduardo Habkost
On Sat, Jan 18, 2020 at 07:54:18AM +0100, Markus Armbruster wrote: > John Snow writes: > > On 1/17/20 2:07 AM, Markus Armbruster wrote: > >> John Snow writes: [...] > >>> This problem has bitten me *many* times. I'm wondering if there's a > >>> prescription that isn't just "Wait until we can

Re: Getting whole-tree patches reviewed and merged

2020-02-07 Thread Eric Blake
On 1/21/20 11:16 PM, Markus Armbruster wrote: Peter Maydell writes: On Tue, 21 Jan 2020 at 15:11, Marc-André Lureau wrote: There are plenty of refactoring to do. The problem when touching the whole code-base, imho, is review time. It may take a couple of hours/days to come up with a

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Guenter Roeck
On Fri, Feb 07, 2020 at 10:25:01PM +0100, Niek Linnenbank wrote: > Hi Guenter, > > On Fri, Feb 7, 2020 at 6:46 PM Guenter Roeck wrote: > > > Initialize EHCI controllers on AST2600 using the existing > > TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb > > into Linux successfully

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread Eric Blake
On 2/6/20 12:18 PM, Dr. David Alan Gilbert wrote: Pain points of JSON include having to count parenthesises and having to quote so bloody much. Additional QMP pain points include long names and excessive nesting. Some other pet hates: a) Number formats are awful for our uses b) Lack

Re: [PATCH v1 0/5] plugins/next

2020-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200207150118.23007-1-alex.ben...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Niek Linnenbank
Hi Guenter, On Fri, Feb 7, 2020 at 6:46 PM Guenter Roeck wrote: > Initialize EHCI controllers on AST2600 using the existing > TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb > into Linux successfully instantiates a USB interface after > the necessary changes are made to its

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread John Snow
On 2/6/20 9:21 AM, Kevin Wolf wrote: > Am 06.02.2020 um 10:40 hat Markus Armbruster geschrieben: On 2/5/20 8:09 AM, Kevin Wolf wrote: > Am 28.01.2020 um 11:59 hat Kevin Wolf geschrieben: The other part that it needs to solve is how to be available by default without

Re: [PATCH v4 08/20] hw/arm/allwinner: add SD/MMC host controller

2020-02-07 Thread Niek Linnenbank
Hi Philippe, FYI, and in case someone also wants to do a similar configuration test on some other machine. I managed to re-produce the same error by temporarily modifying default-configs/arm-softmmu.mak, such that it only enables the orangepi machine. That way, if any configuration item is

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread John Snow
On 2/6/20 7:11 AM, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Thu, Feb 06, 2020 at 10:40:37AM +0100, Markus Armbruster wrote: If the user screwsup, it should give an error that prompts the user to the parameter they got wrong. Output from commands should

[PATCH 0/1] Travis: Fix YAML warnings

2020-02-07 Thread Wainer dos Santos Moschetta
My Travis configuration for QEMU [1] is debug-enabled, and in the Web UI it shows some warnings for the YAML file (e.g. see [2]). Copy/paste the .travis.yml file into [3] to see the warnings. This series get rid of those warnings. [1] https://travis-ci.org/wainersm/qemu [2]

[PATCH 1/1] travis.yml: Fix Travis YAML configuration warnings

2020-02-07 Thread Wainer dos Santos Moschetta
This fixes the following warnings Travis has detected on the YAML configuration: - 'on root: missing os, using the default "linux"' - 'on root: the key matrix is an alias for jobs, using jobs' - 'on jobs.include.python: unexpected sequence, using the first value (3.5)' - 'on jobs.include.python:

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread John Snow
On 2/6/20 4:40 AM, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > >> * John Snow (js...@redhat.com) wrote: >>> I'm forking the subject as I believe Markus wanted to focus on the >>> machine interface aspect. >>> >>> I feel that a new human interface is *related* to that goal:

Re: [PATCH v1 0/5] plugins/next

2020-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200207150118.23007-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v1 0/5] plugins/next Message-id: 20200207150118.23007-1-alex.ben...@linaro.org Type: series

Re: [RFC] QEMU Gating CI

2020-02-07 Thread Cleber Rosa
On Fri, Feb 07, 2020 at 04:42:10PM +, Peter Maydell wrote: > > This all sounds like the right thing and great progress. So yes, > I agree that the next step would be to get to a point where you > can give me some instructions on how to say "OK, here's my staging > branch" and run it through

Re: [PATCH v14 03/11] virtio-iommu: Implement attach/detach command

2020-02-07 Thread Peter Xu
On Fri, Feb 07, 2020 at 10:31:55AM +0100, Eric Auger wrote: [...] > v13 -> v14: > - in virtio_iommu_put_endpoint, if the EP is attached to a > domain, call virtio_iommu_detach_endpoint_from_domain() > - remove domain ref counting and simply delete the mappings > gtree when the last EP is

[PATCH v12 Kernel 7/7] vfio: Selective dirty page tracking if IOMMU backed device pins pages

2020-02-07 Thread Kirti Wankhede
Added a check such that only singleton IOMMU groups can pin pages. >From the point when vendor driver pins any pages, consider IOMMU group dirty page scope to be limited to pinned pages. To optimize to avoid walking list often, added flag pinned_page_dirty_scope to indicate if all of the

[PATCH v12 Kernel 1/7] vfio: KABI for migration interface for device state

2020-02-07 Thread Kirti Wankhede
- Defined MIGRATION region type and sub-type. - Defined vfio_device_migration_info structure which will be placed at 0th offset of migration region to get/set VFIO device related information. Defined members of structure and usage on read/write access. - Defined device states and state

[PATCH v12 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-02-07 Thread Kirti Wankhede
VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start pinned and unpinned pages tracking while migration is active - Stop pinned and unpinned dirty pages tracking. This is also used to stop dirty pages tracking if migration failed or cancelled. - Get dirty pages bitmap. This ioctl

[PATCH v12 Kernel 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-02-07 Thread Kirti Wankhede
Pages, pinned by external interface for requested IO virtual address range, might get unpinned and unmapped while migration is active and device is still running, that is, in pre-copy phase while guest driver still could access those pages. Host device can write to these pages while those were

[PATCH v12 Kernel 6/7] vfio iommu: Adds flag to indicate dirty pages tracking capability support

2020-02-07 Thread Kirti Wankhede
Flag VFIO_IOMMU_INFO_DIRTY_PGS in VFIO_IOMMU_GET_INFO indicates that driver support dirty pages tracking. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- drivers/vfio/vfio_iommu_type1.c | 3 ++- include/uapi/linux/vfio.h | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-)

[PATCH v12 Kernel 3/7] vfio iommu: Add ioctl definition for dirty pages tracking.

2020-02-07 Thread Kirti Wankhede
IOMMU container maintains a list of all pages pinned by vfio_pin_pages API. All pages pinned by vendor driver through this API should be considered as dirty during migration. When container consists of IOMMU capable device and all pages are pinned and mapped, then all pages are marked dirty. Added

[PATCH v12 Kernel 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

2020-02-07 Thread Kirti Wankhede
vfio_pfn.ref_count is always updated by holding iommu->lock, using atomic variable is overkill. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- drivers/vfio/vfio_iommu_type1.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c

[PATCH v12 Kernel 0/7] KABIs to support migration for VFIO devices

2020-02-07 Thread Kirti Wankhede
Hi, This patch set adds: * New IOCTL VFIO_IOMMU_DIRTY_PAGES to get dirty pages bitmap with respect to IOMMU container rather than per device. All pages pinned by vendor driver through vfio_pin_pages external API has to be marked as dirty during migration. When IOMMU capable device is

[Bug 1862415] Re: -nic user cannot receive TFTP response from outside on windows 10 host

2020-02-07 Thread yw662
** Attachment added: "host.pcap" https://bugs.launchpad.net/qemu/+bug/1862415/+attachment/5326376/+files/host.pcap -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1862415 Title: -nic user cannot

[Bug 1862415] [NEW] -nic user cannot receive TFTP response from outside on windows 10 host

2020-02-07 Thread yw662
Public bug reported: Configuration: qemu is on a windows 10 host, address 192.168.1.24 A tftp server, which is atftpd, is at address 192.168.1.31 a guest is started by: ``` .\qemu-system-x86_64.exe -accel hax \ -nic

[Bug 1862415] Re: -nic user cannot receive TFTP response from outside on windows 10 host

2020-02-07 Thread yw662
** Attachment added: "dump.dat" https://bugs.launchpad.net/qemu/+bug/1862415/+attachment/5326375/+files/dump.dat -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1862415 Title: -nic user cannot

Re: [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs

2020-02-07 Thread Cleber Rosa
On Mon, Feb 03, 2020 at 05:08:58PM +0100, Thomas Huth wrote: > On 03/02/2020 04.23, Cleber Rosa wrote: > > At this point it seems that all jobs depend on those steps, with > > maybe the EDK2 jobs as exceptions. > > > > The jobs that will be added will not want those scripts to be > > run, so

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Cleber Rosa
On Fri, Feb 07, 2020 at 11:08:15AM +, Alex Bennée wrote: > > Thomas Huth writes: > > > On 03/02/2020 04.23, Cleber Rosa wrote: > >> This is a crude and straightforward mapping of Peter's > >> "remake-merge-builds" and "pull-buildtest" scripts. > > > > > Thanks for doing this! The patch

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Cleber Rosa
On Fri, Feb 07, 2020 at 09:37:16AM +0100, Thomas Huth wrote: > On 03/02/2020 04.23, Cleber Rosa wrote: > > This is a crude and straightforward mapping of Peter's > > "remake-merge-builds" and "pull-buildtest" scripts. > > > > Some characteristics were removed for simplicity sake (but eventually >

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Cleber Rosa
On Mon, Feb 03, 2020 at 03:36:28PM -0200, Wainer dos Santos Moschetta wrote: > Hi Cleber, > > On 2/3/20 1:23 AM, Cleber Rosa wrote: > > This is a crude and straightforward mapping of Peter's > > "remake-merge-builds" and "pull-buildtest" scripts. > > > > Some characteristics were removed for

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Cleber Rosa
On Fri, Feb 07, 2020 at 04:26:53PM +, Peter Maydell wrote: > On Fri, 7 Feb 2020 at 08:37, Thomas Huth wrote: > > Question to Peter/Alex/Stefan/Howevermergespullreqsinthefuture: > > > > Should the above jobs really be skipped for pull requests, or would it > > be ok to include them there, too?

Re: [PATCH v5 3/8] multifd: Make no compression operations into its own structure

2020-02-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It will be used later. > > Signed-off-by: Juan Quintela > diff --git a/migration/multifd.h b/migration/multifd.h > index d8b0205977..c7fea4914c 100644 > --- a/migration/multifd.h > +++ b/migration/multifd.h > @@ -25,6 +25,10 @@ int

Re: [PATCH v4 00/11] RFC: [for 5.0]: HMP monitor handlers refactoring

2020-02-07 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > On Mon, 2020-02-03 at 19:57 +, Dr. David Alan Gilbert wrote: > > * Maxim Levitsky (mlevi...@redhat.com) wrote: > > > This patch series is bunch of cleanups to the hmp monitor code. > > > It mostly moves the blockdev related hmp handlers to its

Re: [PATCH] net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'

2020-02-07 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 05/12/2019 11.41, Thomas Huth wrote: > > It's been deprecated since QEMU v3.1.0. Time to finally remove it now. > > > > Signed-off-by: Thomas Huth For hmp: Acked-by: Dr. David Alan Gilbert would want an ack from Samuel (or maybe Marc-André) Dave

Re: [PATCH v4 3/3] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 17:19, Philippe Mathieu-Daudé a écrit : > It would be confusing to have multiple default machines. > Abort if this ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Use assert() instead of human friendly message (Marc-André) > v3: Move the check to find_machine()

Re: [PATCH v2 for-5.0 0/7] block-copy improvements: part I

2020-02-07 Thread Max Reitz
On 20.01.20 10:09, Vladimir Sementsov-Ogievskiy wrote: > ping Sorry, I only got to patch 5 so far (without major complaints). I’ll have to pack things up for the weekend now and I’ll be on PTO next week, so I won’t get to review the final two patches before Feb 17, I’m afraid... Max

Re: [PATCH v2 5/7] block/block-copy: rename start to offset in interfaces

2020-02-07 Thread Max Reitz
On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: > offset/bytes pair is more usual naming in block layer, let's use it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block-copy.h | 2 +- > block/block-copy.c | 80 +++--- > 2

Re: [PATCH v4 0/3] Make MachineClass::is_default boolean, refuse multiple default machines

2020-02-07 Thread Eduardo Habkost
On Fri, Feb 07, 2020 at 05:19:45PM +0100, Philippe Mathieu-Daudé wrote: > Cleanup after reviewing "ppc: function to setup latest class options": > https://www.mail-archive.com/qemu-devel@nongnu.org/msg677709.html > > Since v3: > - addressed Laurent & Michael comments Queued, thanks! -- Eduardo

Re: [PULL 0/3] Misc patches

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 12:25, Daniel P. Berrangé wrote: > > The following changes since commit 5b7686f3fa2092d2b3be92df67b5966ee1b0142a: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-02-06' into > staging (2020-02-06 18:59:12 +) > > are available in the Git repository

Re: [PATCH v2 4/7] block/block-copy: refactor interfaces to use bytes instead of end

2020-02-07 Thread Max Reitz
On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: > We have a lot of "chunk_end - start" invocations, let's switch to > bytes/cur_bytes scheme instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block-copy.h | 4 +-- > block/block-copy.c | 68

Re: [PATCH v3 14/20] target/arm: Set PAN bit as required on exception entry

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > The PAN bit is preserved, or set as per SCTLR_ELx.SPAN, > plus several other conditions listed in the ARM ARM. > > Signed-off-by: Richard Henderson > --- > v2: Tidy preservation of CPSR_PAN in take_aarch32_exception (pmm). > --- >

Re: [PATCH v3 18/20] target/arm: Update MSR access to UAO

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Move reginfo to file scope; avoid setting uao from spsr > when the feature is not enabled (pmm). > v3: Update for aarch64_pstate_valid_mask > --- > target/arm/cpu.h | 6 ++ >

Re: [PATCH v2 3/7] block/block-copy: factor out block_copy_find_inflight_req

2020-02-07 Thread Max Reitz
On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: > Split block_copy_find_inflight_req to be used in seprate. *separate, but separate what? > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/block-copy.c | 31 +++ > 1 file changed, 19 insertions(+), 12

Re: [PATCH v4 2/3] hw: Make MachineClass::is_default a boolean type

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 17:19, Philippe Mathieu-Daudé a écrit : > There's no good reason for it to be type int, change it to bool. > > Suggested-by: Richard Henderson > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Philippe Mathieu-Daudé > --- > v4: > - fixed incorrect changes to max_cpus (Laurent)

Re: [PATCH v3 11/20] target/arm: Update MSR access for PAN

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > For aarch64, there's a dedicated msr (imm, reg) insn. > For aarch32, this is done via msr to cpsr; and writes > from el0 are ignored. > > Since v8.0, the CPSR_RESERVED bits have been allocated. > We are not yet implementing ARMv8.0-SSBS or

Re: [PATCH v4 1/3] hw: Do not initialize MachineClass::is_default to 0

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 17:19, Philippe Mathieu-Daudé a écrit : > The MachineClass is already zeroed on creation. > > Note: The code setting is_default=0 in hw/i386/pc_piix.c is > different (related to compat options). When adding a > new versioned machine, we want it to be the new default, >

Re: [PATCH v2 2/7] block/block-copy: use block_status

2020-02-07 Thread Max Reitz
On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: > Use bdrv_block_status_above to chose effective chunk size and to handle > zeroes effectively. > > This substitutes checking for just being allocated or not, and drops > old code path for it. Assistance by backup job is dropped too, as >

[PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Guenter Roeck
Initialize EHCI controllers on AST2600 using the existing TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb into Linux successfully instantiates a USB interface after the necessary changes are made to its devicetree files. ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver

Re: [PATCH v3 10/20] target/arm: Introduce aarch64_pstate_valid_mask

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > Use this along the exception return path, where we previously > accepted any values. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 09/20] target/arm: Tidy msr_mask

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > The CPSR_USER mask for IS_USER already avoids all of the RES0 > bits as per aarch32_cpsr_valid_mask. Fix up the formatting. CPSR_USER includes CPSR_Q and CPSR_GE, which might be RES0 depending on feature bit settings. Diff made a bit of

Re: [PATCH] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Cédric Le Goater
On 2/7/20 6:07 PM, Guenter Roeck wrote: > On Fri, Feb 07, 2020 at 04:47:09PM +0100, Cédric Le Goater wrote: >> On 2/7/20 3:49 PM, Guenter Roeck wrote: >>> Initialize EHCI controllers on AST2600 using the existing >>> TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb >>> into Linux

Re: [PATCH v3 08/20] target/arm: Remove CPSR_RESERVED

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > The only remaining use was in op_helper.c. Use PSTATE_SS > directly, and move the commentary so that it is more obvious > what is going on. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 6 -- >

Re: [PATCH v3 07/20] target/arm: Use aarch32_cpsr_valid_mask in helper_exception_return

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > Using ~0 as the mask on the aarch64->aarch32 exception return > was not even as correct as the CPSR_ERET_MASK that we had used > on the aarch32->aarch32 exception return. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell

Re: [PATCH v3 06/20] target/arm: Replace CPSR_ERET_MASK with aarch32_cpsr_valid_mask

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > CPSR_ERET_MASK was a useless renaming of CPSR_RESERVED. > The function also takes into account bits that the cpu > does not support. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 2 -- > target/arm/op_helper.c | 5

Re: [PATCH v2 1/7] block/block-copy: specialcase first copy_range request

2020-02-07 Thread Max Reitz
On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: > In block_copy_do_copy we fallback to read+write if copy_range failed. > In this case copy_size is larger than defined for buffered IO, and > there is corresponding commit. Still, backup copies data cluster by > cluster, and most of requests

Re: [PATCH v3 05/20] target/arm: Split out aarch32_cpsr_valid_mask

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > Split this helper out of msr_mask in translate.c. At the same time, > transform the negative reductive logic to positive accumulative logic. > It will be usable along the exception paths. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-07 Thread Alex Bennée
Robert Foley writes: > This adds logging of the char device used by the console > to a file. The basevm.py then uses this file to read > chars from the console. > One reason to add this is to aid with debugging. I can certainly see an argument for saving the install log. > But another is

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 17:00, Markus Armbruster wrote: > > Peter Maydell writes: > > > This series switches all our QAPI doc comments over from > > texinfo format to rST. > > > > The basic approach is somewhat similar to how we deal with kerneldoc > > and hxtool: we have a custom Sphinx extension

Re: [PATCH] hw/arm: ast2600: Wire up EHCI controllers

2020-02-07 Thread Guenter Roeck
On Fri, Feb 07, 2020 at 04:47:09PM +0100, Cédric Le Goater wrote: > On 2/7/20 3:49 PM, Guenter Roeck wrote: > > Initialize EHCI controllers on AST2600 using the existing > > TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb > > into Linux successfully instantiates a USB interface after >

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > This series switches all our QAPI doc comments over from > texinfo format to rST. > > The basic approach is somewhat similar to how we deal with kerneldoc > and hxtool: we have a custom Sphinx extension which is passed a > filename which is the json file it should run the

Re: [PATCH 18/29] qapi/migration.json: Replace _this_ with *this*

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 16:54, Markus Armbruster wrote: > > Peter Maydell writes: > > > The MigrationInfo::setup-time documentation is the only place where > > we use _this_ inline markup to mean italics. > > Nitpick: _this_ does not mean italics, it means emphasis. See > qapi-code-gen.txt

Re: [PATCH 18/29] qapi/migration.json: Replace _this_ with *this*

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > The MigrationInfo::setup-time documentation is the only place where > we use _this_ inline markup to mean italics. Nitpick: _this_ does not mean italics, it means emphasis. See qapi-code-gen.txt section "Documentation markup". doc.py maps it to @emph{this}, which

Re: [PULL v2 00/46] Python queue 2020-02-07

2020-02-07 Thread Eduardo Habkost
ng branch 'remotes/maxreitz/tags/pull-block-2020-02-06' > into staging (2020-02-06 16:22:05 +) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/python-next-20200207 > > for you to fetch changes up to 66e7dde18cc4085ca47124be4ca08fa8e6bcdd3a: &g

Re: [PATCH] block: fix crash on zero-length unaligned write and read

2020-02-07 Thread Vladimir Sementsov-Ogievskiy
07.02.2020 19:47, Stefan Hajnoczi wrote: On Thu, Feb 06, 2020 at 07:42:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: Commit 7a3f542fbd "block/io: refactor padding" occasionally dropped aligning for zero-length request: bdrv_init_padding() blindly return false if bytes == 0, like there is

Re: [PATCH v1 00/14] tests/vm: Add support for aarch64 VMs

2020-02-07 Thread Alex Bennée
Robert Foley writes: > This is version 1 of the patch series to > add support for 2 aarch64 VMs. > - Ubuntu 18.04 aarch64 VM > - CentOS 8 aarch64 VM Testing under TCG with: make vm-build-ubuntu.aarch64 V=1 QEMU=aarch64-softmmu/qemu-system-aarch64 I'm seeing it hang:

Re: [PATCH v2] hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host

2020-02-07 Thread Stefan Hajnoczi
On Fri, Feb 07, 2020 at 01:14:04AM +0100, Philippe Mathieu-Daudé wrote: > Commit ed65fd1a2750 ("virtio-blk: switch off scsi-passthrough by > default") changed the default value of the 'scsi' property of > virtio-blk, which is only available on Linux hosts. It also added > an unconditional compat

Re: [PATCH v1 4/5] target/riscv: progressively load the instruction during decode

2020-02-07 Thread Alex Bennée
Robert Foley writes: > Hi, > On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote: >> -static void decode_RV32_64C0(DisasContext *ctx) >> +static void decode_RV32_64C0(DisasContext *ctx, uint16_t opcode) >> { >> -uint8_t funct3 = extract32(ctx->opcode, 13, 3); >> -uint8_t rd_rs2 =

Re: [PATCH] block: fix crash on zero-length unaligned write and read

2020-02-07 Thread Stefan Hajnoczi
On Thu, Feb 06, 2020 at 07:42:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Commit 7a3f542fbd "block/io: refactor padding" occasionally dropped > aligning for zero-length request: bdrv_init_padding() blindly return > false if bytes == 0, like there is nothing to align. > > This leads the

Re: [PATCH v3] block/backup-top: fix flags handling

2020-02-07 Thread Vladimir Sementsov-Ogievskiy
07.02.2020 19:30, Max Reitz wrote: On 07.02.20 17:12, Vladimir Sementsov-Ogievskiy wrote: backup-top "supports" write-unchanged, by skipping CBW operation in backup_top_co_pwritev. But it forgets to do the same in backup_top_co_pwrite_zeroes, as well as declare support for

Re: [PATCH v3] docs: add virtiofsd(1) man page

2020-02-07 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > Document the virtiofsd(1) program and its command-line options. This > man page is a rST conversion of the original texi documentation that I > wrote. > > Reviewed-by: Liam Merwick > Signed-off-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan

Re: [RFC] QEMU Gating CI

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 03:28, Cleber Rosa wrote >>>> Testing process: >>>> >>>> * I get an email which is a pull request, and I run the >>>>"apply-pullreq" script, which takes the GIT URL and tag/branch name >>>>to test. >>>> * apply-pullreq performs the merge

Re: [PATCH v1 1/5] docs/devel: document query handle lifetimes

2020-02-07 Thread Robert Foley
On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote: > > I forgot to document the lifetime of handles in the developer > documentation. Do so now. > > Signed-off-by: Alex Bennée Reviewed-by: Robert Foley Regards, -Rob > --- > docs/devel/tcg-plugins.rst | 13 +++-- > 1 file changed, 11

Re: [RFC 0/9] Add an interVM memory sharing device

2020-02-07 Thread Stefan Hajnoczi
On Fri, Feb 07, 2020 at 11:04:03AM +0100, Igor Mammedov wrote: > On Fri, 7 Feb 2020 10:00:50 +0100 > Igor Kotrasiński wrote: > > > On 2/5/20 3:49 PM, Jan Kiszka wrote: > > > On 05.02.20 15:39, Stefan Hajnoczi wrote: > > >> On Tue, Feb 04, 2020 at 12:30:42PM +0100, > > >>

Re: [PATCH v4 2/3] hw: Make MachineClass::is_default a boolean type

2020-02-07 Thread Marc-André Lureau
On Fri, Feb 7, 2020 at 5:21 PM Philippe Mathieu-Daudé wrote: > > There's no good reason for it to be type int, change it to bool. > > Suggested-by: Richard Henderson > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau > --- > v4: > -

Re: [PATCH v1 4/5] target/riscv: progressively load the instruction during decode

2020-02-07 Thread Robert Foley
Hi, On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote: > -static void decode_RV32_64C0(DisasContext *ctx) > +static void decode_RV32_64C0(DisasContext *ctx, uint16_t opcode) > { > -uint8_t funct3 = extract32(ctx->opcode, 13, 3); > -uint8_t rd_rs2 = GET_C_RS2S(ctx->opcode); > -uint8_t

Re: [PATCH v4 3/3] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Marc-André Lureau
On Fri, Feb 7, 2020 at 5:21 PM Philippe Mathieu-Daudé wrote: > > It would be confusing to have multiple default machines. > Abort if this ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Use assert() instead of human friendly message (Marc-André) > v3: Move the check to

Re: [PATCH 02/29] configure: Check that sphinx-build is using Python 3

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 16:18, Markus Armbruster wrote: > > Peter Maydell writes: > > > Currently configure's has_sphinx_build() check simply runs a dummy > > sphinx-build and either passes or fails. This means that "no > > sphinx-build at all" and "sphinx-build exists but is too old" are > >

Re: [PATCH v2] docs: add virtiofsd(1) man page

2020-02-07 Thread Stefan Hajnoczi
On Thu, Feb 06, 2020 at 11:39:43AM +, Dr. David Alan Gilbert wrote: > > + * vhost_user_socket=PATH - > > +Listen on vhost-user UNIX domain socket at PATH. > > Isn't that the old one? Thanks, will fix in v3. Stefan signature.asc Description: PGP signature

Re: [PATCH v3] block/backup-top: fix flags handling

2020-02-07 Thread Max Reitz
On 07.02.20 17:12, Vladimir Sementsov-Ogievskiy wrote: > backup-top "supports" write-unchanged, by skipping CBW operation in > backup_top_co_pwritev. But it forgets to do the same in > backup_top_co_pwrite_zeroes, as well as declare support for > BDRV_REQ_WRITE_UNCHANGED. > > Fix this, and, while

[PATCH v3] docs: add virtiofsd(1) man page

2020-02-07 Thread Stefan Hajnoczi
Document the virtiofsd(1) program and its command-line options. This man page is a rST conversion of the original texi documentation that I wrote. Reviewed-by: Liam Merwick Signed-off-by: Stefan Hajnoczi --- v3: * Dropped old -o vhost_user_socket=PATH option [dgilbert] v2: * Fix mount -t

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

2020-02-07 Thread Philippe Mathieu-Daudé
On 2/7/20 5:07 PM, Markus Armbruster wrote: Kevin Wolf writes: Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben: Philippe Mathieu-Daudé writes: List this file in the proper section, so maintainers get notified when it is modified. Signed-off-by: Philippe Mathieu-Daudé --- Cc:

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 08:37, Thomas Huth wrote: > Question to Peter/Alex/Stefan/Howevermergespullreqsinthefuture: > > Should the above jobs really be skipped for pull requests, or would it > be ok to include them there, too? (in the latter case, the above changes > could just be dropped) I don't

  1   2   3   4   >