Re: [PATCH 1/3] target/riscv: Set the CPU resetvec directly

2022-09-16 Thread Wilfred Mallawa
On Wed, 2022-09-14 at 12:11 +0200, Alistair Francis via wrote: > Instead of using our properties to set a config value which then > might > be used to set the resetvec (depending on your timing), let's instead > just set the resetvec directly in the env struct. > > This allows us to set the reset

Re: [PATCH v3 2/2] target/i386: Raise #GP on unaligned m128 accesses when required.

2022-09-16 Thread Ricky Zhou
Checking back on the status of patch, I noticed that there are some exciting patches out for AVX support that may conflict with this, though I see that they are still in the RFC phase: https://patchew.org/QEMU/20220911230418.340941-1-pbonz...@redhat.com/ I'm not sure how far away AVX support is

Re: [RFC] hw/registerfields: add `FIELDx_1CLEAR()` macro

2022-09-16 Thread Wilfred Mallawa
Ping! https://lore.kernel.org/qemu-devel/20220901010220.495112-1-wilfred.mall...@opensource.wdc.com/ Wilfred On Fri, 2022-09-02 at 01:18 +0200, Philippe Mathieu-Daudé wrote: > On 1/9/22 07:32, Richard Henderson wrote: > > On 9/1/22 02:02, Wilfred Mallawa wrote: > > > From: Wilfred Mallawa > > >

Re: [PATCH 3/3] hw/riscv: opentitan: Expose the resetvec as a SoC property

2022-09-16 Thread Wilfred Mallawa
On Wed, 2022-09-14 at 12:11 +0200, Alistair Francis via wrote: > On the OpenTitan hardware the resetvec is fixed at the start of ROM. > In > QEMU we don't run the ROM code and instead just jump to the next > stage. > This means we need to be a little more flexible about what the > resetvec > is. >

Re: [PATCH 2/3] hw/riscv: opentitan: Fixup resetvec

2022-09-16 Thread Wilfred Mallawa
On Wed, 2022-09-14 at 12:11 +0200, Alistair Francis via wrote: > The resetvec for the OpenTitan machine ended up being set to an out > of > date value, so let's fix that and bump it to the correct start > address > (after the boot ROM) > > Fixes: bf8803c64d75 "hw/riscv: opentitan: bump opentitan

[PATCH v1 3/3] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2022-09-16 Thread Vivek Kasireddy
The new parameter named "connector" can be used to assign physical monitors/connectors to individual GFX VCs such that when the monitor is connected or hotplugged, the associated GTK window would be fullscreened on it. If the monitor is disconnected or unplugged, the associated GTK window would be

[PATCH v1 0/3] ui/gtk: Add a new parameter to assign connectors/monitors to Guests' windows

2022-09-16 Thread Vivek Kasireddy
There is a need (expressed by several customers/users) to assign ownership of one or more physical monitors/connectors to individual Guests such that there is a clear notion of which Guest's contents are being displayed on any given monitor. Given that there is always a Display Server/Compositor

[PATCH v1 1/3] ui/gtk: Disable the scanout when a detached tab is closed

2022-09-16 Thread Vivek Kasireddy
When a detached tab window is closed, the underlying (EGL) context is destroyed; therefore, disable the scanout which also destroys the underlying framebuffer (id) and other objects. Also add calls to make the context current in disable scanout and other missing places. Cc: Gerd Hoffmann Cc:

[PATCH v1 2/3] ui/gtk: Factor out tab window creation into a separate function

2022-09-16 Thread Vivek Kasireddy
Pull the code that creates a new window associated with a notebook tab into a separate function. This new function can be useful not just when user wants to detach a tab but also in the future when a new window creation is needed in other scenarios. Cc: Gerd Hoffmann Cc: Dongwon Kim

[PATCH 09/10] hw/ppc/mac.h: Move PROM and KERNEL defines to board code

2022-09-16 Thread BALATON Zoltan
The PROM_FILENAME and KERNEL_* defines are used by mac_oldworld and mac_newworld but they don't have to be identical so these could be moved to the individual boards. The NVRAM_SIZE define is not used so it can be dropped. This further reduces the mac.h header. Signed-off-by: BALATON Zoltan ---

[PATCH 08/10] hw/ppc/mac.h: Move grackle-pcihost declaration out from shared header

2022-09-16 Thread BALATON Zoltan
It is only used by mac_oldworld anyway and it already instantiates a few devices by name so this allows reducing the shared header further. Signed-off-by: BALATON Zoltan --- hw/pci-host/grackle.c | 1 + hw/ppc/mac.h | 3 --- hw/ppc/mac_oldworld.c | 2 +- 3 files changed, 2

[PATCH 06/10] hw/ppc/mac.h: Move newworld specific atuff out from shared header

2022-09-16 Thread BALATON Zoltan
Move the parts specific to and only used by mac99 out from the shared mac.h into mac_newworld.c where they better belong. Signed-off-by: BALATON Zoltan --- hw/ppc/mac.h | 24 hw/ppc/mac_newworld.c | 19 +++ hw/ppc/mac_oldworld.c | 1 + 3 files

[PATCH 10/10] hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h

2022-09-16 Thread BALATON Zoltan
All that is left in mac.h now belongs to the nvram emulation so rename it accordingly and only include it where it is really used. Signed-off-by: BALATON Zoltan --- MAINTAINERS | 1 + hw/ide/macio.c | 1 - hw/intc/heathrow_pic.c

[PATCH 01/10] mac_newworld: Drop some variables

2022-09-16 Thread BALATON Zoltan
Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few such variables. This is the same clean up that

[PATCH 07/10] hw/ppc/mac.h: Move macio specific atuff out from shared header

2022-09-16 Thread BALATON Zoltan
Move the parts specific to and only used by macio out from the shared mac.h into macio.c where they better belong. Signed-off-by: BALATON Zoltan --- hw/misc/macio/macio.c | 26 -- hw/ppc/mac.h | 23 --- 2 files changed, 24 insertions(+), 25

[PATCH 03/10] mac_{old|new}world: Set default values for some local variables

2022-09-16 Thread BALATON Zoltan
Some lines can be dropped making the code flow simpler and easier to follow by setting default values at variable declaration for some variables in both mac_oldworld.c and mac_newworld.c. Signed-off-by: BALATON Zoltan --- hw/ppc/mac_newworld.c | 28 +---

[PATCH 05/10] mac_{old|new}world: Reduce number of QOM casts

2022-09-16 Thread BALATON Zoltan
By storing the device pointers in a variable with the right type the number of QOM casts can be reduced which also makes the code more readable. Signed-off-by: BALATON Zoltan --- hw/ppc/mac_newworld.c | 60 --- hw/ppc/mac_oldworld.c | 26

[PATCH 02/10] mac_oldworld: Drop some more variables

2022-09-16 Thread BALATON Zoltan
Drop some more local variables additionally to commit b8df32555ce5 to match clean ups done to mac_newwold in previous patch. Signed-off-by: BALATON Zoltan --- hw/ppc/mac_oldworld.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git

[PATCH 00/10] Misc ppc/mac machines clean up

2022-09-16 Thread BALATON Zoltan
This series includes some clean ups to mac_newworld and mac_oldworld to make them a bit simpler and more readable, It also removes the shared mac.h file that turns out was more of a random collection of unrelated things. Getting rid of this mac.h improves the locality of device models and reduces

[PATCH 04/10] mac_newworld: Simplify creation of Uninorth devices

2022-09-16 Thread BALATON Zoltan
Avoid open coding sysbus_create_simple where not necessary and reorganise code a bit to avoid some casts to make the code more readable. Signed-off-by: BALATON Zoltan --- hw/ppc/mac_newworld.c | 50 --- 1 file changed, 19 insertions(+), 31 deletions(-)

Re: [PATCH v6 2/2] i386: Add notify VM exit support

2022-09-16 Thread Peter Xu
On Thu, Sep 15, 2022 at 05:28:39PM +0800, Chenyi Qiang wrote: > There are cases that malicious virtual machine can cause CPU stuck (due > to event windows don't open up), e.g., infinite loop in microcode when > nested #AC (CVE-2015-5307). No event window means no event (NMI, SMI and > IRQ) can be

Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 14:36:05 UTC schrieb "Philippe Mathieu-Daudé" : >On 12/9/22 21:50, Bernhard Beschow wrote: >> Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow >> : > >>> Testing done: >>> >>> * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device >>>

Re: [PATCH 10/11] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 15:15:03 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow wrote: >> >> Will allow e500 boards to access SD cards using just their own devices. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/sd/sdhci.c | 147

Re: [PATCH 04/11] hw/ppc/mpc8544ds: Add platform bus

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 06:15:53 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:29 PM Bernhard Beschow wrote: >> >> Models the real device more closely. > >Please describe the source (e.g.: I assume it's MPC8544DS board manual >or something like that?) that describe such memory map for the

Re: [PATCH 09/11] hw/sd/sdhci: Rename ESDHC_* defines to USDHC_*

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 10:07:28 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:42 PM Bernhard Beschow wrote: >> >> The device model's functions start with "usdhc_", so rename the defines >> accordingly for consistency. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/sd/sdhci.c | 68

Re: [PATCH 07/11] hw/ppc/e500: Implement pflash handling

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 15:00:06 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:36 PM Bernhard Beschow wrote: >> >> Allows e500 boards to have their root file system reside on flash using >> only builtin devices. >> >> Note that the flash memory area is only created when a -pflash argument is

Re: [PATCH 11/11] hw/ppc/e500: Add Freescale eSDHC to e500 boards

2022-09-16 Thread Bernhard Beschow
On Fri, Sep 16, 2022 at 5:26 PM Bin Meng wrote: > On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow > wrote: > > > > Adds missing functionality to emulated e500 SOCs which increases the > > chance of given "real" firmware images to access SD cards. > > By "firmware" do you mean U-Boot? > No, I

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-16 Thread Ani Sinha
On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > On Mon, 25 Jul 2022, Ani Sinha wrote: > > > > > > > On Sat, 16 Jul 2022, Michael S. Tsirkin wrote: > > > > > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Fri, Jul 15, 2022 at 11:20 Michael S.

Re: [PATCH 00/11] ppc/e500: Add support for two types of flash, cleanup

2022-09-16 Thread Bernhard Beschow
On Fri, Sep 16, 2022 at 5:27 PM Bin Meng wrote: > Hi Bernhard, > Hi Bin, > On Thu, Sep 15, 2022 at 11:25 PM Bernhard Beschow > wrote: > > > > This series adds support for -pflash and direct SD card access to the > > PPC e500 boards. The idea is to increase compatibility with "real" >

Re: Maximum QMP reply size

2022-09-16 Thread Daniel P . Berrangé
On Fri, Sep 16, 2022 at 04:12:00PM +0100, Peter Maydell wrote: > On Thu, 15 Sept 2022 at 16:21, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Tue, 6 Sept 2022 at 20:41, John Snow wrote: > > > > Hi, I suspect I have asked this before, but I

Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 15/9/22 10:16, Richard Henderson wrote: >> On 9/14/22 17:09, Alex Bennée wrote: >>> Now that MxTxAttrs encodes a CPU we should use that to figure it out. >>> This solves edge cases like accessing via gdbstub or qtest. >>> >>> Signed-off-by: Alex Bennée >>>

Re: [PATCH 00/11] ppc/e500: Add support for two types of flash, cleanup

2022-09-16 Thread Bin Meng
Hi Bernhard, On Thu, Sep 15, 2022 at 11:25 PM Bernhard Beschow wrote: > > This series adds support for -pflash and direct SD card access to the > PPC e500 boards. The idea is to increase compatibility with "real" firmware > images where only the bare minimum of drivers is compiled in. > > The

Re: [PATCH 11/11] hw/ppc/e500: Add Freescale eSDHC to e500 boards

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow wrote: > > Adds missing functionality to emulated e500 SOCs which increases the > chance of given "real" firmware images to access SD cards. By "firmware" do you mean U-Boot? > > Signed-off-by: Bernhard Beschow > --- >

Re: [RFC PATCH 1/4] hw: encode accessing CPU index in MemTxAttrs

2022-09-16 Thread Peter Maydell
On Wed, 14 Sept 2022 at 17:50, Alex Bennée wrote: > > We currently have hacks across the hw/ to reference current_cpu to > work out what the current accessing CPU is. This breaks in some cases > including using gdbstub to access HW state. As we have MemTxAttrs to > describe details about the

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-16 Thread Philippe Mathieu-Daudé via
On 16/9/22 12:22, Daniel P. Berrangé wrote: On Fri, Sep 16, 2022 at 12:10:30PM +0200, Pierre Muller wrote: Le 16/09/2022 à 10:38, Richard Henderson a écrit : We are not intending to *remove* support for big-endian mips, as 99% of the code paths are shared with little-endian mips, which we

Re: [PATCH 10/11] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow wrote: > > Will allow e500 boards to access SD cards using just their own devices. > > Signed-off-by: Bernhard Beschow > --- > hw/sd/sdhci.c | 147 +- > include/hw/sd/sdhci.h | 3 + > 2 files

Re: Maximum QMP reply size

2022-09-16 Thread Peter Maydell
On Thu, 15 Sept 2022 at 16:21, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Tue, 6 Sept 2022 at 20:41, John Snow wrote: > > > Hi, I suspect I have asked this before, but I didn't write it down in > > > a comment, so I forget my justification... > > >

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-16 Thread Claudio Fontana
On 9/16/22 16:26, Markus Armbruster wrote: > Claudio Fontana writes: > >> On 9/16/22 11:27, Markus Armbruster wrote: >>> Claudio Fontana writes: >>> improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void

[PATCH] Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero

2022-09-16 Thread Matheus Tavares Bernardino
Signed-off-by: Matheus Tavares Bernardino --- tests/tcg/hexagon/usr.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/tcg/hexagon/usr.c b/tests/tcg/hexagon/usr.c index a531511cec..fb4514989c 100644 --- a/tests/tcg/hexagon/usr.c +++ b/tests/tcg/hexagon/usr.c @@ -86,6 +86,7

Re: [PATCH 07/11] hw/ppc/e500: Implement pflash handling

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:36 PM Bernhard Beschow wrote: > > Allows e500 boards to have their root file system reside on flash using > only builtin devices. > > Note that the flash memory area is only created when a -pflash argument is > given, and that the size is determined by the given file.

Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-16 Thread Philippe Mathieu-Daudé via
On 15/9/22 10:16, Richard Henderson wrote: On 9/14/22 17:09, Alex Bennée wrote: Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. Signed-off-by: Alex Bennée Resolves:

Re: [PATCH] mem/cxl_type3: fix GPF DVSEC

2022-09-16 Thread Jonathan Cameron via
On Thu, 15 Sep 2022 17:59:04 + Tong Zhang wrote: > The structure is for device dvsec not port dvsec. Change type to fix > this issue. > > Signed-off-by: Tong Zhang Acked-by: Jonathan Cameron > --- > hw/mem/cxl_type3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] .gitignore: add .cache/ to .gitignore

2022-09-16 Thread Philippe Mathieu-Daudé via
On 7/9/22 17:00, Wang, Lei wrote: $PROJECT/.cache/clangd/index is the intended location for project index data when using clangd as the language server. Ignore this directory to keep the git status clean. Signed-off-by: Wang, Lei --- .gitignore | 1 + 1 file changed, 1 insertion(+)

Re: [RFC PATCH 2/4] qtest: make read/write operation appear to be from CPU

2022-09-16 Thread Philippe Mathieu-Daudé via
On 15/9/22 10:08, Richard Henderson wrote: On 9/14/22 17:09, Alex Bennée wrote: The point of qtest is to simulate how running code might interact with the system. However because it's not a real system we have places in the code which especially handle check qtest_enabled() before referencing

Re: [PATCH 22/27] qapi stats: Elide redundant has_FOO in generated C

2022-09-16 Thread Mark Kanda
On 9/15/2022 3:43 PM, Markus Armbruster wrote: The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for

Re: [PATCH v5 13/13] hw/isa/vt82c686: Create rtc-time alias in boards instead

2022-09-16 Thread Philippe Mathieu-Daudé via
On 1/9/22 13:41, Bernhard Beschow wrote: According to good QOM practice, an object should only deal with objects of its own sub tree. Having devices create an alias on the machine object doesn't respect this good practice. To resolve this, create the alias in the machine's code. Signed-off-by:

Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-16 Thread Philippe Mathieu-Daudé via
On 12/9/22 21:50, Bernhard Beschow wrote: Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow : Testing done: * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel morphos-3.17/boot.img` Boots

Re: [PATCH v5 11/13] hw/mips/fuloong2e: Inline vt82c686b_southbridge_init() and remove it

2022-09-16 Thread Philippe Mathieu-Daudé via
On 1/9/22 13:41, Bernhard Beschow wrote: The previous patches moved most of this function into the via-isa device model such that it has become fairly trivial. So inline it for simplicity. Suggested-by: BALATON Zoltan Signed-off-by: Bernhard Beschow --- hw/mips/fuloong2e.c | 28

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-16 Thread Markus Armbruster
Claudio Fontana writes: > On 9/16/22 11:27, Markus Armbruster wrote: >> Claudio Fontana writes: >> >>> improve error handling during module load, by changing: >>> >>> bool module_load_one(const char *prefix, const char *lib_name); >>> void module_load_qom_one(const char *type); >>> >>> to: >>>

Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

2022-09-16 Thread Paul Durrant
On 14/09/2022 03:07, Ji, Ruili wrote: [AMD Official Use Only - General] Hi Paul, Thank you! But how could we merge this patch ? AFAIK Anthony (anthony.per...@citrix.com) still deals with this. Cheers, Paul

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-16 Thread Eugenio Perez Martin
On Wed, Sep 14, 2022 at 5:44 PM Si-Wei Liu wrote: > > > > On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: > > On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: > >> > >> > >> On 9/14/2022 3:20 AM, Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > >>> wrote: >

[PATCH qboot] Place setup_data at location specified by host

2022-09-16 Thread Jason A. Donenfeld
QEMU places setup_data at a particular location, which cannot be relocated due to it containing self references in absolute address terms. For this reason, it supplies the intended location in FW_CFG_SETUP_ADDR, which is what SeaBIOS uses. So use this too in qboot. This also has the effect of

Re: [PATCH v8 3/8] KVM: Add KVM_EXIT_MEMORY_FAULT exit

2022-09-16 Thread Bagas Sanjaya
On Thu, Sep 15, 2022 at 10:29:08PM +0800, Chao Peng wrote: > + - KVM_MEMORY_EXIT_FLAG_PRIVATE - indicates the memory error is caused by > + private memory access when the bit is set otherwise the memory error is > + caused by shared memory access when the bit is clear. s/set otherwise/set.

Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory

2022-09-16 Thread Bagas Sanjaya
On Thu, Sep 15, 2022 at 10:29:07PM +0800, Chao Peng wrote: > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index abd7c32126ce..c1fac1e9f820 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -1319,7 +1319,7 @@ yet and must be

Re: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

2022-09-16 Thread Alex Bennée
Brian Cain writes: >> -Original Message- >> From: Qemu-devel >> On Behalf Of Matheus Tavares Bernardino > ... >> On Wed, 24 Aug 2022 at 14:51, Matheus Tavares Bernardino >> wrote: >> > >> > Instead, let's change gdb_set_stop_cpu() to send stop messages only as a >> > response to a

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-16 Thread Robert Hoo
On Fri, 2022-09-16 at 09:37 +0200, Igor Mammedov wrote: > > Fine, get your point now. > > In ASL it will look like this: > > Local1 = Package (0x3) {STTS, SLSA, MAXT} > > Return (Local1) > > > > > > But as for > > CreateDWordField

Re: [PATCH] RISC-V: Add support for Ztso

2022-09-16 Thread Palmer Dabbelt
On Sat, 03 Sep 2022 17:47:54 PDT (-0700), richard.hender...@linaro.org wrote: On 9/2/22 04:44, Palmer Dabbelt wrote: -#define TCG_GUEST_DEFAULT_MO 0 +/* + * RISC-V has two memory models: TSO is a bit weaker than Intel (MMIO and + * fetch), and WMO is approximately equivilant to Arm MCA. Rather

Re: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

2022-09-16 Thread Alex Bennée
Matheus Tavares Bernardino writes: > GDB's remote serial protocol allows stop-reply messages to be sent by > the stub either as a notification packet or as a reply to a GDB command > (provided that the cmd accepts such a response). QEMU currently does not > implement notification packets, so

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-16 Thread Claudio Fontana
On 9/16/22 12:43, Markus Armbruster wrote: > Has this fallen through the cracks? > I think it hasn't, Paolo responded with "queued, thanks", so from that comment I assume it has been picked up by Paolo in one of his queues. Thanks, Claudio

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-16 Thread Claudio Fontana
On 9/16/22 11:27, Markus Armbruster wrote: > Claudio Fontana writes: > >> improve error handling during module load, by changing: >> >> bool module_load_one(const char *prefix, const char *lib_name); >> void module_load_qom_one(const char *type); >> >> to: >> >> bool module_load_one(const char

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-16 Thread Markus Armbruster
Has this fallen through the cracks?

Re: [PATCH 05/27] qapi tests: Elide redundant has_FOO in generated C

2022-09-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Sep 15, 2022 at 10:42:55PM +0200, Markus Armbruster wrote: >> The has_FOO for pointer-valued FOO are redundant, except for arrays. >> They are also a nuisance to work with. Recent commit "qapi: Start to >> elide redundant has_FOO in generated C" provided the

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-16 Thread Daniel P . Berrangé
On Fri, Sep 16, 2022 at 12:10:30PM +0200, Pierre Muller wrote: > > > Le 16/09/2022 à 10:38, Richard Henderson a écrit : > > On 9/16/22 10:08, Pierre Muller wrote: > > > > > >   I am using gcc230 machine for the gcc compile farm. > > > > > >   This is a big endian mips64 machine runnig

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-16 Thread Alex Bennée
Pierre Muller writes: > I am using gcc230 machine for the gcc compile farm. > > This is a big endian mips64 machine runnig Debian Buster. That's still oldstable, the current release of Debian doesn't support BE mips in either 32 or 64 bit. As bullseye was released last year buster will

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-16 Thread Pierre Muller
Le 16/09/2022 à 10:38, Richard Henderson a écrit : On 9/16/22 10:08, Pierre Muller wrote:   I am using gcc230 machine for the gcc compile farm.   This is a big endian mips64 machine runnig Debian Buster. When compiling the qemu 7.1.0 release source, the generated binaries are 32-bit

Re: [PATCH 09/11] hw/sd/sdhci: Rename ESDHC_* defines to USDHC_*

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:42 PM Bernhard Beschow wrote: > > The device model's functions start with "usdhc_", so rename the defines > accordingly for consistency. > > Signed-off-by: Bernhard Beschow > --- > hw/sd/sdhci.c | 68 +-- > 1 file

Re: [PATCH 08/11] hw/sd/sdhci-internal: Unexport ESDHC defines

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:39 PM Bernhard Beschow wrote: > > These defines aren't used outside of sdhci.c, so can be defined there. > > Signed-off-by: Bernhard Beschow > --- > hw/sd/sdhci-internal.h | 20 > hw/sd/sdhci.c | 19 +++ > 2 files changed,

Re: [PATCH v8 3/8] KVM: Add KVM_EXIT_MEMORY_FAULT exit

2022-09-16 Thread Chao Peng
On Fri, Sep 16, 2022 at 04:17:48PM +0700, Bagas Sanjaya wrote: > On Thu, Sep 15, 2022 at 10:29:08PM +0800, Chao Peng wrote: > > + - KVM_MEMORY_EXIT_FLAG_PRIVATE - indicates the memory error is caused by > > + private memory access when the bit is set otherwise the memory error is > > + caused

Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory

2022-09-16 Thread Chao Peng
On Fri, Sep 16, 2022 at 04:14:29PM +0700, Bagas Sanjaya wrote: > On Thu, Sep 15, 2022 at 10:29:07PM +0800, Chao Peng wrote: > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > > index abd7c32126ce..c1fac1e9f820 100644 > > --- a/Documentation/virt/kvm/api.rst > > +++

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Markus Armbruster
Ani Sinha writes: > On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrangé > wrote: > >> On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: >> > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster >> > wrote: >> > > >> > > Ani Sinha writes: >> > > >> > > > On Fri, Sep 16, 2022 at 2:13 AM

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Ani Sinha
On Fri, Sep 16, 2022 at 14:15 Ani Sinha wrote: > > > On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrangé > wrote: > >> On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: >> > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster >> wrote: >> > > >> > > Ani Sinha writes: >> > > >> > > > On

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-16 Thread Markus Armbruster
Claudio Fontana writes: > improve error handling during module load, by changing: > > bool module_load_one(const char *prefix, const char *lib_name); > void module_load_qom_one(const char *type); > > to: > > bool module_load_one(const char *prefix, const char *name, Error **errp); > bool

Re: [PATCH 07/27] qapi audio: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:57PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by

Re: [PATCH 09/27] qapi char: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:59PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by

Re: [PATCH 04/11] RISC-V: Adding T-Head Bitmanip instructions

2022-09-16 Thread LIU Zhiwei
On 2022/9/6 20:22, Christoph Muellner wrote: From: Christoph Müllner This patch adds support for the T-Head Bitmanip instructions. The patch uses the T-Head specific decoder and translation. As the instructions are similar to those of Zb*, we can reuse a lot of existing infrastructure code.

Re: [PATCH 27/27] qapi: Drop temporary logic to support conversion step by step

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:43:17PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi/schema.py | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH 10/27] qapi crypto: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:43:00PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by

Re: [PATCH 25/27] qapi ui: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:43:15PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by

Re: [PATCH 05/27] qapi tests: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:55PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:56PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by

Re: [PATCH 02/27] qapi: Tidy up whitespace in generated code

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:52PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/devel/qapi-code-gen.rst | 1 - > scripts/qapi/commands.py | 7 +++ > scripts/qapi/events.py | 1 - > 3 files changed, 3 insertions(+), 6 deletions(-) Reviewed-by:

Re: [PATCH 03/27] docs/devel/qapi-code-gen: Extend example for next commit's change

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:53PM +0200, Markus Armbruster wrote: > The next commit will change the code generated for some optional > members. The example schema contains an optional member affected by > the change. Add one that is not affected. > > Signed-off-by: Markus Armbruster > --- >

Re: [PATCH 04/27] qapi: Start to elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:54PM +0200, Markus Armbruster wrote: > In QAPI, absent optional members are distinct from any present value. > We thus represent an optional schema member FOO as two C members: a > FOO with the member's type, and a bool has_FOO. Likewise for function > arguments. >

Re: [PATCH 12/27] qapi job: Elide redundant has_FOO in generated C

2022-09-16 Thread Vladimir Sementsov-Ogievskiy
On 9/15/22 23:43, Markus Armbruster wrote: The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Ani Sinha
On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrangé wrote: > On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: > > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster > wrote: > > > > > > Ani Sinha writes: > > > > > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster > wrote: > > > >> >

[PATCH] migration/ram: Fix memory leak when using x-ignore-shared

2022-09-16 Thread Nikolay Borisov
During ram initialization for migration dirty/clear bitmaps are allocated for all migratable blocks, irrespective of their shared status. However, during ram migration cleanup those bitmaps are freed only for those blocks which aren't shared, in case x-ignore-shared capability is used. This leads

Re: [PATCH 00/27] qapi: Elide redundant has_FOO in generated C

2022-09-16 Thread Vladimir Sementsov-Ogievskiy
On 9/15/22 23:42, Markus Armbruster wrote: In QAPI, absent optional members are distinct from any present value. We thus represent an optional schema member FOO as two C members: a FOO with the member's type, and a bool has_FOO. Likewise for function arguments. However, the has_FOO is actually

Re: [PATCH 01/27] docs/devel/qapi-code-gen: Update example to match current code

2022-09-16 Thread Daniel P . Berrangé
On Thu, Sep 15, 2022 at 10:42:51PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/devel/qapi-code-gen.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-16 Thread Richard Henderson
On 9/16/22 10:08, Pierre Muller wrote:   I am using gcc230 machine for the gcc compile farm.   This is a big endian mips64 machine runnig Debian Buster. When compiling the qemu 7.1.0 release source, the generated binaries are 32-bit mips binaries, and I did not find out how to generate a

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Daniel P . Berrangé
On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster wrote: > > > > Ani Sinha writes: > > > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster > > > wrote: > > >> > > >> The has_FOO for pointer-valued FOO are redundant, except for

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Ani Sinha
On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster wrote: > > Ani Sinha writes: > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster wrote: > >> > >> The has_FOO for pointer-valued FOO are redundant, except for arrays. > >> They are also a nuisance to work with. Recent commit "qapi: Start to

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Markus Armbruster
Ani Sinha writes: > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster wrote: >> >> The has_FOO for pointer-valued FOO are redundant, except for arrays. >> They are also a nuisance to work with. Recent commit "qapi: Start to >> elide redundant has_FOO in generated C" > > Commit is referenced

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-16 Thread Claudio Fontana
On 9/16/22 10:13, Richard Henderson wrote: > On 9/8/22 20:30, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load_one(const char *prefix, const char *lib_name); >> void module_load_qom_one(const char *type); >> >> to: >> >> bool

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-16 Thread Richard Henderson
On 9/8/22 20:30, Claudio Fontana wrote: improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-16 Thread Pierre Muller
I am using gcc230 machine for the gcc compile farm. This is a big endian mips64 machine runnig Debian Buster. When compiling the qemu 7.1.0 release source, the generated binaries are 32-bit mips binaries, and I did not find out how to generate a 64-bit versions of the executables. As

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Ani Sinha
On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster wrote: > > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" Commit is referenced using ("commit header")

Re: [PATCH 02/11] RISC-V: Adding T-Head CMO instructions

2022-09-16 Thread Richard Henderson
On 9/16/22 08:43, LIU Zhiwei wrote: On 2022/9/6 20:22, Christoph Muellner wrote: From: Christoph Müllner This patch adds support for the T-Head CMO instructions. To avoid interfering with standard extensions, decoder and translation are in its own T-Head specific files. Future patches should

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-16 Thread Igor Mammedov
On Thu, 15 Sep 2022 22:42:56 +0200 Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step.

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-16 Thread Igor Mammedov
On Fri, 16 Sep 2022 10:27:08 +0800 Robert Hoo wrote: > On Fri, 2022-09-09 at 15:39 +0200, Igor Mammedov wrote: > ... > > looks more or less fine except of excessive use of named variables > > which creates global scope variables. > > > > I'd suggest to store temporary buffers/packages in LocalX

Re: [PATCH v4 1/2] x86: return modified setup_data only if read as memory, not as file

2022-09-16 Thread Ard Biesheuvel
On Wed, 14 Sept 2022 at 01:42, Jason A. Donenfeld wrote: > > If setup_data is being read into a specific memory location, then > generally the setup_data address parameter is read first, so that the > caller knows where to read it into. In that case, we should return > setup_data containing the

  1   2   >