[Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Anthony Liguori
tools need to be notified about something that they did? Regards, Anthony Liguori BLOCK_MEDIA_EJECT - This event is only emitted when a CDROM or a floppy disk is ejected. The event contains one info one: - device name Example: { event: BLOCK_MEDIA_EJECT, data

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:06 AM, Alexander Graf wrote: On 11.01.2011, at 15:00, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:18 AM, Avi Kivity wrote: On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:22 AM, Avi Kivity wrote: On 01/11/2011 04:09 PM, Anthony Liguori wrote: Disadvantages: 1) you lose migration / savevm between KVM and non-KVM VMs This doesn't work today and it's never worked. KVM exposes things that TCG cannot emulate (like pvclock). If you run kvm

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-11 Thread Anthony Liguori
to insult, you need to be root to be able to issue that ioctl (technically have CAP_SYS_ADMIN). Why isn't fsync() enough for a block device? Regards, Anthony Liguori O_DIRECT fixes this problem altogether, because there is no buffering, and if there are not buffers, they can't be invalid O

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:56 AM, Avi Kivity wrote: On 01/11/2011 04:36 PM, Anthony Liguori wrote: They need to use the same device id then. And if they share code, that indicates that they need to be the same device even more. No, it really doesn't :-) Cirrus VGA and std VGA share a lot of code

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
getting a sosreport that includes a dump of the device tree. You really want to see something in there that tells you it's an in-kernel PIT and not the userspace one. Regards, Anthony Liguori

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
, it can show whatever we want it to show. Regards, Anthony Liguori

Re: [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
uses an established RPC protocol (XML-RPC). I'm not tied to using any particular protocol, but I think it's very important to use a standardized, well specified protocol. Regards, Anthony Liguori Let the Flam^WDiscussions begin, Gerd

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
On 01/12/2011 12:59 PM, Hans de Goede wrote: Hi, On 01/12/2011 06:40 PM, Anthony Liguori wrote: On 01/12/2011 10:12 AM, Gerd Hoffmann wrote: Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
/spice.proto Of course there are many implementations of this outside of spice, like protocol buffers). I also don't think a one-off is necessarily a bad thing. Yeah, it might be worthwhile to look at protocol buffers. Regards, Anthony Liguori Note while on the subject of design, I think

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
, /* qemu_pvtable_ack */ Regards, Anthony Liguori }; typedef struct qemu_pvtablet_message { uint32_t size;/* whole message size */ uint32_t type;/* qemu_pvtablet_type */ uint64_t tv_secs; uint64_t tv_usecs; union { qemu_pvtablet_position

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
to cover pressure sensitive touchpads. Not worth designing now but a feature negotiation gives us the option later. Regards, Anthony Liguori cheers, Gerd

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 10:14 AM, Avi Kivity wrote: On 01/13/2011 05:52 PM, Anthony Liguori wrote: /* host-guest, sent before any other events */ typedef struct qemu_pvtablet_init { uint32_t res_x; /* x axis resolution */ uint32_t res_y; /* y axis resolution */ uint32_t features

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
{ struct qemu_pvtablet_hdr hdr; uint32_t x; uint32_t y; }; union qemu_pvtablet_message { struct qemu_pvtablet_hdr hdr; struct qemu_pvtablet_position position; ... }; Regards, Anthony Liguori

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-13 Thread Anthony Liguori
loops because it's completely unusual. Regards, Anthony Liguori The older function, qemu_set_fd_handler2(), is now a wrapper to assign_fd_handlers() and can be deprecated by converting the existing usage to assign_fd_handlers(). v2: Address comments from Gerd: - add comments to new interfaces

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 11:09 AM, Paolo Bonzini wrote: On 01/13/2011 05:39 PM, Anthony Liguori wrote: On 01/13/2011 10:14 AM, Avi Kivity wrote: On 01/13/2011 05:52 PM, Anthony Liguori wrote: /* host-guest, sent before any other events */ typedef struct qemu_pvtablet_init { uint32_t res_x; /* x axis

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 11:08 AM, Gerd Hoffmann wrote: On 01/13/11 16:55, Anthony Liguori wrote: On 01/13/2011 05:51 AM, Gerd Hoffmann wrote: On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
the beginning too. Features negotiation takes care of this. Regards, Anthony Liguori Alex

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-14 Thread Anthony Liguori
-Pointer_X Yeah, that's exactly what I had in mind and why I suggested an offscreen coordinate. Regards, Anthony Liguori Regards, Daniel

Re: [Qemu-devel] paravirtual tablet v2

2011-01-14 Thread Anthony Liguori
; qemu_pvtablet_button button; }; typedef struct qemu_pvtablet_message { qemu_pvtablet_header hdr; qemu_pvtablet_payload data; } qemu_pvtablet_message; Regards, Anthony Liguori #endif /* __QEMU_PVTABLET__ */

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-14 Thread Anthony Liguori
just do what it does instead of inventing something that none of us can validate actually works. Or better yet, delay implementing it until someone actually knows how to support it. Regards, Anthony Liguori This would even be useful for single-point tablets which usually also have

Re: [Qemu-devel] paravirtual tablet v3

2011-01-14 Thread Anthony Liguori
. There are a lot of non-multitouch aware guests out there and I don't think we want the driver to be the one deciding how to map a multitouch device to something that doesn't support mulitouch. Regards, Anthony Liguori

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-17 Thread Anthony Liguori
On 01/17/2011 04:18 AM, Amit Shah wrote: On (Thu) Jan 13 2011 [13:17:22], Anthony Liguori wrote: On 01/13/2011 09:00 AM, Amit Shah wrote: Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque

Re: [Qemu-devel] paravirtual tablet v3

2011-01-17 Thread Anthony Liguori
On 01/17/2011 02:19 AM, Gerd Hoffmann wrote: On 01/14/11 21:48, Anthony Liguori wrote: On 01/14/2011 10:35 AM, Gerd Hoffmann wrote: Hi, Now v3 featuring multitouch ;) cheers, Gerd I really think multitouch needs to be a feature such that the guest can nack it and the host can adjust

Re: [Qemu-devel] RFC: mass comment conversion from C99 to C89

2011-01-17 Thread Anthony Liguori
an extra parameter). Regards, Anthony Liguori This particular changeset doesn't touch target-arm so it doesn't affect me personally, though. -- PMM

Re: [Qemu-devel] [PULL] rtl8139, pci, ioeventfd

2011-01-17 Thread Anthony Liguori
for_anthony Pulled. Thanks. Regards, Anthony Liguori Alex Williamson (2): qdev: Track runtime machine modifications rtl8139: Use subsection to restrict migration after hotplug Gerd Hoffmann (4): pci: allow devices being tagged as not hotpluggable. piix: tag

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-18 Thread Anthony Liguori
of the standard for encoding binary data. It also supports UTF-8 encoded strings. Regards, Anthony Liguori cheers, Gerd

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-18 Thread Anthony Liguori
On 01/18/2011 05:56 AM, Amit Shah wrote: On (Mon) Jan 17 2011 [08:57:16], Anthony Liguori wrote: Also -- this patchset was prompted by a bug in qemu chardevs that freezes guests if they write faster than the chardevs can consume. What should the strategy on fixing that bug be? Fix

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote: Right, we should introduce a KVMBus that KVM devices are created on. The devices can get at KVMState through

Re: [Qemu-devel] paravirtual tablet v3

2011-01-18 Thread Anthony Liguori
mouse in absolute mode, PV mouse in multitouch mode, etc. VirtualBox has an interface like this FWIW (although not multitouch aware). Regards, Anthony Liguori cheers, Gerd

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:01 AM, Jan Kiszka wrote: On 2011-01-18 16:50, Anthony Liguori wrote: On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:17 AM, Jan Kiszka wrote: On 2011-01-18 17:04, Anthony Liguori wrote: A KVM device should sit on a KVM specific bus that hangs off of sysbus. It can get to kvm_state through that bus. That bus doesn't get instantiated through qdev so requiring a pointer argument should

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
, the STRTOSZ_DEFSUFFIX_TB are useless chaff. Chacun à son goût. Yeah, I have to agree. I'm not of the literals are evil camp. BTW, a useful change would be to accept both upper and lower case letters. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
as part of the CPUs or as part of the chipset. How to enable/disable kvm assistance is a property of the CPU and/or chipset. Regards, Anthony Liguori Jan

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
the kvm system buses. Which is fine in the short term. This is exactly why we don't want the device model to be an ABI. It gives us the ability to make changes as they make sense instead of trying to be perfect from the start (which we never will be). Regards, Anthony Liguori Jan

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 02:36 PM, Jes Sorensen wrote: On 01/18/11 21:30, Anthony Liguori wrote: On 01/18/2011 10:53 AM, Eric Blake wrote: On 01/18/2011 09:50 AM, Anthony Liguori wrote: @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char

Re: [Qemu-devel] unknown keycodes

2011-01-18 Thread Anthony Liguori
On 01/18/2011 07:22 PM, Henry Grebler wrote: qemu -cdrom /dev/acd1 -hda kwinxp.img -m 512 -boot d -localtime unknown keycodes `sun(type6_usb)_aliases(qwerty)', please report to qemu-devel@nongnu.org Thanks, you can work around this by using -k en-us. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
to introduce a -pci-device option that is specifically for creating PCI devices that doesn't require a parent bus argument but provides a way to specify stable addressing (for instancing, using a linear index). Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 07:11 AM, Markus Armbruster wrote: Gerd Hoffmannkra...@redhat.com writes: On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true for the sysbus, it is obviously not the case for PCI and similarly discoverable

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 11:35 AM, Daniel P. Berrange wrote: On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote: On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
differently to support forwards compatibility. Regards, Anthony Liguori Daniel

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
simpler like a linear index that QEMU maps to a static location in the topology is probably the best future proof interface. Regards, Anthony Liguori Regards, Daniel

[Qemu-devel] Re: libcacard as a git submodule

2011-01-19 Thread Anthony Liguori
On 01/19/2011 12:11 PM, Alon Levy wrote: Any objections? My primary concern is that it is easy to make changes to QEMU that impact the interface between QEMU and libcacard so I'd actually prefer it not be a submodule. Regards, Anthony Liguori Alon

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 12:52 PM, Daniel P. Berrange wrote: On Wed, Jan 19, 2011 at 11:51:58AM -0600, Anthony Liguori wrote: On 01/19/2011 11:01 AM, Daniel P. Berrange wrote: The reason we specify 'bus' is that we wanted to be flexible wrt upgrades of libvirt, without needing restarts of QEMU

Re: [Qemu-devel] [PULL] virtio, pci, migration, hotplug

2011-01-20 Thread Anthony Liguori
. Thanks. Regards, Anthony Liguori are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Alex Williamson (1): savevm: Fix no_migrate Amit Shah (1): virtio-serial-bus: bump up control vq size to 32 Isaku Yamahata (4

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Anthony Liguori
the user that they should expect bad performance. Silently doing something that the user has explicitly asked us not to do is not a good behavior. Regards, Anthony Liguori --- I need to report some error from virtio-pci that would be handled specially (disable but don't report an error) so

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-20 Thread Anthony Liguori
with KVM. Is there some type of overhead in doing that? Regards, Anthony Liguori HACK ALERT: Works by hacking the main loop so it never executes any guest code. Not implemented for KVM's main loop at this time, thus -fake-machine needs to force KVM off. It also replaces guest RAM by a token

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Anthony Liguori
On 01/20/2011 03:33 AM, Jan Kiszka wrote: On 2011-01-19 20:32, Blue Swirl wrote: On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Anthony Liguori
really mean the default machine. At some point, qemu-system-x86_64 -device virtio-net-pci,addr=2.0 Is not going to be a reliable way to invoke qemu because there's no way we can guarantee that slot 2 isn't occupied by a chipset device or some other default device. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Anthony Liguori
there's anything we could do to future proof us to that kind of change. I assume that libvirt today assumes that it can use a set of PCI slots in bus 0, correct? Probably in the range 3-31? Such assumptions are very likely to break. Regards, Anthony Liguori Regards, Daniel

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-20 Thread Anthony Liguori
, Anthony Liguori

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Anthony Liguori
On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote: When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Anthony Liguori
On 01/21/2011 03:48 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 06:23:36PM -0600, Anthony Liguori wrote: On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: On 01/20/2011 09:35 AM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Anthony Liguori
On 01/21/2011 03:55 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 06:35:46PM -0700, Alex Williamson wrote: On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote: On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Anthony Liguori
On 01/21/2011 04:43 AM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:50:33PM -0600, Anthony Liguori wrote: On 01/20/2011 11:12 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 01/18/2011 02:16 PM, Markus Armbruster wrote

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Anthony Liguori
to do anything useful, panic! reboot loops. Because that's 1000s of guests competing for CPU. Hrm, that's not the behavior I see. With no bootable drive, the BIOS will spin in a HLT loop as part of int18. Regards, Anthony Liguori If you think we can achieve my goals (stated in my

Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

2011-01-21 Thread Anthony Liguori
be deleted like this. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver

2011-01-21 Thread Anthony Liguori
. + **/ + +#ifndef __block_sim_h__ +#define __block_sim_h__ Coding style. In general, I like the idea of the simulator but the coding style is off quite a bit. Regards, Anthony Liguori +void init_blksim (int print, int64_t _rand_time); +int using_blksim (void); +int blksim_has_task (void

Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

2011-01-23 Thread Anthony Liguori
to be able to be applied one at a time such that at each point, the build doesn't break and functionality doesn't break. Otherwise, tools like git bisect don't work. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC][PATCH 00/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-23 Thread Anthony Liguori
as a way to introduce threading into QEMU without requiring that all of QEMU's core infrastructure be re-entrant to start out with (because of property (1)). Regards, Anthony Liguori Stefan

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-23 Thread Anthony Liguori
asynchronous in the image formats. The good bit about this is that we can probably dramatically simplify the block layer API but eliminating the sync/async versions of everything. Regards, Anthony Liguori --- block/qcow2.c | 160 ++--- 1 files

[Qemu-devel] [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-01-24 Thread Anthony Liguori
Leave the disable options for now to help with testing but these will be removed once we're confident in the thread implementations. Disabled code bit rots. These have been in tree long enough that we need to either commit to making them work or just remove them entirely. Signed-off-by: Anthony

[Qemu-devel] [PATCH 3/7] Add support for glib based threading and convert qemu thread to use it

2011-01-24 Thread Anthony Liguori
implementation that we could leverage in something like virtio-9p. Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/Makefile b/Makefile index 6d601ee..bf24d1b 100644 --- a/Makefile +++ b/Makefile @@ -104,6 +104,8 @@ audio/audio.o audio/fmodaudio.o: QEMU_CFLAGS += $(FMOD_CFLAGS

[Qemu-devel] [PATCH 6/7] Teach vnc server to use GThread directly

2011-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/qemu-thread.c b/qemu-thread.c index 748da5e..6d0c51e 100644 --- a/qemu-thread.c +++ b/qemu-thread.c @@ -14,6 +14,31 @@ #include qemu-common.h #include qemu-thread.h +#ifdef _WIN32 +GThread *q_thread_create_nosignal(GThreadFunc

[Qemu-devel] [PATCH 7/7] Rename QemuThread to QemuSThread to indicate that it is not a generic thread

2011-01-24 Thread Anthony Liguori
This is an abstraction to support signalable threads. Signaling is inheritedly non-portable so this type of thread should only be used when absolutely necessary. I think the current users are the only users that should ever need to exist so strongly discourage future use. Signed-off-by: Anthony

[Qemu-devel] [PATCH 1/7] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond

2011-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/cpus.c b/cpus.c index 0309189..9cf7e6e 100644 --- a/cpus.c +++ b/cpus.c @@ -412,8 +412,10 @@ int qemu_init_main_loop(void) if (ret) return ret; -qemu_cond_init(qemu_pause_cond); +qemu_cond_init(qemu_cpu_cond

[Qemu-devel] [PATCH 4/7] Get rid of QemuMutex and teach its callers about GStaticMutex

2011-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/cpus.c b/cpus.c index 9cf7e6e..0f8e33b 100644 --- a/cpus.c +++ b/cpus.c @@ -321,8 +321,8 @@ void vm_stop(int reason) #include qemu-thread.h -QemuMutex qemu_global_mutex; -static QemuMutex qemu_fair_mutex; +GStaticMutex

[Qemu-devel] [PATCH 5/7] threads: get rid of QemuCond and teach callers about GCond

2011-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/cpu-defs.h b/cpu-defs.h index 8d4bf86..9343824 100644 --- a/cpu-defs.h +++ b/cpu-defs.h @@ -204,7 +204,7 @@ typedef struct CPUWatchpoint { uint32_t stop; /* Stop request */ \ uint32_t

[Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-24 Thread Anthony Liguori
Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us borrow more code from existing projects instead of reinventing everything through trial and error. This series

[Qemu-devel] Re: [PULL 00/23] Block patches

2011-01-24 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori Aurelien Jarno (1): qcow2: fix unaligned access Christoph Hellwig (3): ide: factor dma handling helpers ide: also reset io_buffer_index for writes ide: kill ide_dma_submit_check Jes Sorensen (2): do_snapshot_blkdev

Re: [Qemu-devel] Re: [RFC 0/7] Introduce hard dependency on glib

2011-01-24 Thread Anthony Liguori
On 01/24/2011 03:28 PM, Paolo Bonzini wrote: On 01/24/2011 10:00 PM, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us borrow more code from

[Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-24 Thread Anthony Liguori
On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block layer - glib everywhere Regards, Anthony Liguori thanks, -chris -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Anthony Liguori
something as sophisticated as guestfs but that's not it's point. It's point is to let you do simple things like execute a command in the guest or peek at /proc/meminfo. You don't need 500k LOCs for that. Regards, Anthony Liguori Rich.

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-01-24 Thread Anthony Liguori
On 01/24/2011 03:00 PM, Anthony Liguori wrote: Leave the disable options for now to help with testing but these will be removed once we're confident in the thread implementations. Disabled code bit rots. These have been in tree long enough that we need to either commit to making them work

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Anthony Liguori
On 01/24/2011 04:48 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 04:26:09PM -0600, Anthony Liguori wrote: On 01/24/2011 04:20 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 10:08:09PM +, Richard W.M. Jones wrote: You might as well reuse the libguestfs API

Re: [Qemu-devel] Re: [PATCH 4/7] Get rid of QemuMutex and teach its callers about GStaticMutex

2011-01-24 Thread Anthony Liguori
On 01/24/2011 04:24 PM, Jan Kiszka wrote: On 2011-01-24 22:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguorialigu...@us.ibm.com diff --git a/cpus.c b/cpus.c index 9cf7e6e..0f8e33b 100644 --- a/cpus.c +++ b/cpus.c @@ -321,8 +321,8 @@ void vm_stop(int reason) #include qemu

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-24 Thread Anthony Liguori
On 01/24/2011 03:00 PM, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us borrow more code from existing projects instead of reinventing

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Anthony Liguori
. I really just want getfile. I think designing a partial read API at this stage isn't a good idea. Wait until there's a concrete use case before adding an interface. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Anthony Liguori
. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-25 Thread Anthony Liguori
, Anthony Liguori

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Anthony Liguori
; + +/* VSCMsgReconnect Host - Client + * */ +typedef struct VSCMsgReconnect { +uint32_t ip; This is not ipv6 friendly. Two strings would be a better choice. Regards, Anthony Liguori +uint16_t port; +} VSCMsgReconnect; + +#endif

Re: [Qemu-devel] [PATCH 3/7] libcacard: initial commit after coding style fixes

2011-01-25 Thread Anthony Liguori
Levyal...@redhat.com I think importing the code like this is a reasonable place to start. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 4/7] ccid: add ccid-card-emulated device (v2)

2011-01-25 Thread Anthony Liguori
(thread_id, NULL, event_thread, card); +if (rv 0) { +printf(%s: error creating event thread\n, EMULATED_DEV_NAME); +return -1; +} Why can't this be implemented with qemu_set_fd_handler? The event thread si just spinning on read. Regards, Anthony Liguori +rv

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Anthony Liguori
On 01/25/2011 05:06 AM, Avi Kivity wrote: On 01/19/2011 06:57 PM, Anthony Liguori wrote: On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state), and they interact with the emulated PCI bus. Could you elaborate on the fundamental difference between the two

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Anthony Liguori
phase than in a bug fix phase before a release. Yeah, lesson learned is releasing before a holiday is probably a bad idea. What would be a reasonable window to get us in bug fixing mode to do a release? How would a 2/1 stable-0.14 branch sound? Regards, Anthony Liguori

Re: [Qemu-devel] git rm Changelog?

2011-01-25 Thread Anthony Liguori
in the release notes. Regards, Anthony Liguori Kevin

[Qemu-devel] 0.14.0 release schedule

2011-01-25 Thread Anthony Liguori
Here's my proposal: Stable branch - 2/1 1 or 2 -rcs in between Stable release - 2/15 Regards, Anthony Liguori

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-25 Thread Anthony Liguori
On 01/25/2011 03:21 AM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 05:40:05PM -0600, Anthony Liguori wrote: BTW, how dependent is guestfsd on the guest that libguestfs uses? I wasn't even aware that it could be used outside of that context. The daemon is compiled separately

Re: [Qemu-devel] [PATCH 3/7] Add support for glib based threading and convert qemu thread to use it

2011-01-25 Thread Anthony Liguori
On 01/25/2011 08:24 AM, Aurelien Jarno wrote: On Mon, Jan 24, 2011 at 03:00:41PM -0600, Anthony Liguori wrote: GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Anthony Liguori
On 01/25/2011 08:23 AM, Aurelien Jarno wrote: On Mon, Jan 24, 2011 at 03:00:38PM -0600, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Anthony Liguori
On 01/25/2011 10:21 AM, Alon Levy wrote: On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: On 01/11/2011 02:42 AM, Alon Levy wrote: diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h new file mode 100644 index 000..9ff1295 --- /dev/null +++ b

Re: [Qemu-devel] [PATCH 4/7] ccid: add ccid-card-emulated device (v2)

2011-01-25 Thread Anthony Liguori
On 01/25/2011 10:24 AM, Alon Levy wrote: On Tue, Jan 25, 2011 at 08:21:13AM -0600, Anthony Liguori wrote: On 01/11/2011 02:42 AM, Alon Levy wrote: This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Anthony Liguori
it with GObject yet but before we even get there, there's a lot of good we can do with glib. Regards, Anthony Liguori I am asking because I have always found the glib GObject stuff a little ugly compared to well written C++ code (of course you can write ugly code in any language if you want to).

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Anthony Liguori
(no pending disk I/O and no periodic timer) then the main loop is starved. This is a fundamental flaw in TCG. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Anthony Liguori
On 01/25/2011 01:45 PM, Stefan Hajnoczi wrote: On Tue, Jan 25, 2011 at 7:18 PM, Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 01/25/2011 03:49 AM, Stefan Hajnoczi wrote: On Tue, Jan 25, 2011 at 7:12 AM, Stefan Hajnoczistefa...@gmail.com wrote: On Mon, Jan 24

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Anthony Liguori
a signal based alarm timer. Doesn't work for !CONFIG_IOTHREAD. Yeah, we need to get rid of !CONFIG_IOTHREAD. We need to run select() in parallel with TCG/KVM and interrupt the VCPUs appropriately when select() returns. Regards, Anthony Liguori Stefan

<    8   9   10   11   12   13   14   15   16   17   >