Re: [Qemu-devel] [PATCH] Modify net/socket.c to use socket_* functions from include/qemu/sockets.h

On Tuesday 31 May 2016 08:31 PM, Paolo Bonzini wrote: On 31/05/2016 11:27, Ashijeet Acharya wrote: Changed the listen(),connect(),parse_host_port() in net/socket.c with the socket_*()functions in include/qemu/sockets.h. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> ---

[Qemu-devel] [PATCH] Modify net/socket.c to use socket_* functions from include/qemu/sockets.h

Changed the listen(),connect(),parse_host_port() in net/socket.c with the socket_*()functions in include/qemu/sockets.h. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- net/socket.c | 38 +++--- 1 file changed, 19 insertions(+), 19 del

[Qemu-devel] [PATCH] Change net/socket.c to use socket_*() functions

socket_address_to_string() in util/qemu-sockets.c which returns the string representation of socket address. The task was listed on http://wiki.qemu.org/BiteSizedTasks page. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- include/qemu/sockets.h | 16 ++

[Qemu-devel] [PATCH v2] Change net/socket.c to use socket_*() functions

socket_address_to_string() in util/qemu-sockets.c which returns the string representation of socket address. Thetask was listed on http://wiki.qemu.org/BiteSizedTasks page. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- include/qemu/sockets.h | 16 ++

Re: [Qemu-devel] [PATCH v2] Change net/socket.c to use socket_*() functions

On Tue, Jun 21, 2016 at 7:19 AM, Jason Wang <jasow...@redhat.com> wrote: > > > On 2016年06月20日 23:09, Peter Maydell wrote: >> >> On 20 June 2016 at 15:55, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> >>> >>> On 18/06/2016 09:54, Ash

[Qemu-devel] Postcopy Migration: Recovery from a broken network connection (GSOC 2016)

the links posted on the ideas page and the source code on github. I also had some ideas related to it and wanted to discuss those with you. Please let me know how you are planning to proceed with it and the technical skills required for the same. Thanks! Ashijeet Acharya

[Qemu-devel] [PATCH] Modify net/socket.c to use socket_* functions from include/qemu/sockets.h

Changed the listen(),connect(),parse_host_port() in net/socket.c with the socket_*()functions in include/qemu/sockets.h. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- net/socket.c | 38 +++--- 1 file changed, 19 insertions(+), 19 del

[Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h

From: Ashijeet <ashijeetacha...@gmail.com> Replaced connect()/listen()/parse_host_port() in net/socket.c with inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- net/socket.c | 19 +++ 1

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

On Thu, Aug 11, 2016 at 1:50 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > On Wed, Aug 10, 2016 at 11:12 AM, Ashijeet Acharya > <ashijeetacha...@gmail.com> wrote: >> On Tue, Aug 9, 2016 at 11:48 PM, John Snow <js...@redhat.com> wrote: >>> &

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

On Thu, Aug 11, 2016 at 10:04 PM, Paolo Bonzini wrote: > >> I think we should do >> >> s->vmstate = qemu_add_vm_change_state_handler(ide_restart_cb, bus); >> instead of >> qemu_add_vm_change_state_handler(ide_restart_cb, bus); >> >> in ide_register_restart_cb() in

[Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Introduce VMChangeStateEntry parameter in ide_register_restart_cb() to handle possible memory leak from qemu_add_vm_change_state_handler(). Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hw/ide/ahci.c | 2 +- hw/ide/cmd646.c | 2 +- hw/ide/

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

=none,if=none,id=disk2,format=qcow2 OK 3. (qemu) device_add ide-hd,bus=ahci.0,id=ahci-disk,drive=disk2 Bus 'ahci.0' does not support hotplugging What am I doing wrong? Thanks Ashijeet On Sat, Aug 6, 2016 at 11:21 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > Hi, > >

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

On Tue, Aug 9, 2016 at 11:48 PM, John Snow <js...@redhat.com> wrote: > > > On 08/09/2016 01:16 PM, Ashijeet Acharya wrote: >> >> Hi again, >> I am still waiting for some guidance...Can I please get some help with >> this? >> >> Also.. I tried hotp

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

On Wed, Aug 10, 2016 at 11:12 AM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > On Tue, Aug 9, 2016 at 11:48 PM, John Snow <js...@redhat.com> wrote: >> >> >> On 08/09/2016 01:16 PM, Ashijeet Acharya wrote: >>> >>> Hi again, >>>

[Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

Hi, I was working on a patch regarding a device lifecycle bitesize task and I wanted to clear my queries about what the task is exactly. Do I need to create a new function ahci_unrealize() in the hw/ide/ahci.c file which calls for qemu_del_vm_change_state_handler() to free the handler at the

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

On Fri, Feb 3, 2017 at 10:44 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 03/02/2017 02:36, Ashijeet Acharya wrote: >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead place zero RAM ch

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

On Tue, Jan 31, 2017 at 2:18 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 29/01/2017 08:19, Ashijeet Acharya wrote: >> Also, Paolo has a similar opinion to yours that we should fix it >> instead of blocking it. He suggests to migrate only the device sta

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

On Wed, Feb 8, 2017 at 5:19 PM, Thomas Huth <th...@redhat.com> wrote: > On 03.02.2017 11:36, Ashijeet Acharya wrote: >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead place zero RAM checks at >>

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

On Wed, Feb 8, 2017 at 4:55 PM, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead place zero RAM

[Qemu-devel] [PATCH v3] migrate: Introduce zero RAM checks to skip RAM migration

Migration of a "none" machine with no RAM crashes abruptly as bitmap_new() fails and thus aborts. Instead place zero RAM checks at appropriate places to skip migration of RAM in this case and complete migration successfully for devices only. Signed-off-by: Ashijeet Acharya <

[Qemu-devel] [PATCH v3] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

ce constructuon is right. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- Changes is v3: - move only_migratable check inside device_set_realized() to avoid code - duplication - I have dropped Juan's R-b tag for this one Changes in v2: - place dc->vmsd check in hw/usb/bus.c as

Re: [Qemu-devel] [PATCH] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

On Mon, Jan 30, 2017 at 10:08 PM, Juan Quintela <quint...@redhat.com> wrote: > Peter Maydell <peter.mayd...@linaro.org> wrote: >> On 30 January 2017 at 14:41, Ashijeet Acharya <ashijeetacha...@gmail.com> >> wrote: >>> Commit a3a3d8c7 introduced a seg

[Qemu-devel] [PATCH v2] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

vices. NOTE: This doesn't compromise the functioning of --only-migratable option as all the unmigratable devices do set their 'dc->vmsd'. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> Reviewed-by: Juan Quintela <quint...@redhat.com> --- Changes in v2: - place dc->vmsd check i

[Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

Migration of a "none" machine with no RAM crashes abruptly as bitmap_new() fails and thus aborts. Instead place zero RAM checks at appropriate places to skip migration of RAM in this case and complete migration successfully for devices only. Signed-off-by: Ashijeet Acharya <

[Qemu-devel] migration: QEMU aborts migration of "none" machine

Hi Thomas, I was able to reproduce the bug you encountered while trying to migrate a "none" machine. After digging deep and debugging the problem with gdb, I found that bitmap_new() is the function that crashes qemu as it always has zero bits being passed to it. I had a discussion with Dave on

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

Okay On Friday, 27 January 2017, Daniel P. Berrange <berra...@redhat.com> wrote: > On Thu, Jan 26, 2017 at 02:46:52PM +0530, Ashijeet Acharya wrote: > > Migration of a "none" machine with no RAM crashes abruptly as > > bitmap_new() fails and thus

[Qemu-devel] [PATCH] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

vices. NOTE: This doesn't compromise the functioning of --only-migratable option as all the unmigratable devices do set their 'dc->vmsd'. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qdev-monit

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

On Sun, Jan 29, 2017 at 12:11 AM, Greg Kurz <gr...@kaod.org> wrote: > On Thu, 26 Jan 2017 14:46:52 +0530 > Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fa

Re: [Qemu-devel] migration: QEMU aborts migration of "none" machine

On Wed, Jan 25, 2017 at 4:46 PM, Juan Quintela <quint...@redhat.com> wrote: > "Daniel P. Berrange" <berra...@redhat.com> wrote: >> On Wed, Jan 25, 2017 at 11:53:06AM +0100, Thomas Huth wrote: >>> On 25.01.2017 11:01, Ashijeet Acharya wrote: >>>

Re: [Qemu-devel] migration: QEMU aborts migration of "none" machine

On Wed, Jan 25, 2017 at 9:40 PM, Thomas Huth <th...@redhat.com> wrote: > On 25.01.2017 13:58, Ashijeet Acharya wrote: >> On Wed, Jan 25, 2017 at 4:46 PM, Juan Quintela <quint...@redhat.com> wrote: >>> "Daniel P. Berrange" <berra...@redhat.com> wrote:

[Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

Migration of a "none" machine with no RAM crashes abruptly as bitmap_new() fails and thus aborts. Instead, place a check for last_ram_offset() being '0' at the start of ram_save_setup() and error out with a meaningful error message. Signed-off-by: Ashijeet Acharya <ashijeetacha

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

On Sun, Jan 29, 2017 at 6:33 PM, Greg Kurz <gr...@kaod.org> wrote: > On Sun, 29 Jan 2017 01:06:47 +0530 > Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > >> On Sun, Jan 29, 2017 at 12:11 AM, Greg Kurz <gr...@kaod.org> wrote: >> > On Thu, 26 Jan

Re: [Qemu-devel] [PATCH v4] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

On Mon, Feb 13, 2017 at 11:34 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > Commit a3a3d8c7 introduced a segfault bug while checking for > 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add > devices which do no set their 'dc->vmsd' yet while

[Qemu-devel] [PATCH v4] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

vices. NOTE: This doesn't compromise the functioning of --only-migratable option as all the unmigratable devices do set their 'dc->vmsd'. Introduce a new function check_migratable() and move the only_migratable check inside it, also use stubs to avoid user-mode qemu build failures. Signed-off-by: A

Re: [Qemu-devel] [PATCH v5 3/4] migration: disallow migrate_add_blocker during migration

On Mon, Jan 16, 2017 at 1:17 AM, Greg Kurz <gr...@kaod.org> wrote: > On Thu, 12 Jan 2017 21:22:33 +0530 > Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > >> If a migration is already in progress and somebody attempts >> to add a migration blocker, this shoul

[Qemu-devel] [PATCH v6 0/5] Introduce a new --only-migratable option

patch 3 and 4 - use error_append_hint - return -EACCES for only-migratable - fix the error messages Ashijeet Acharya (5): block/vvfat: Remove the undesirable comment migration: Add a new option to enable only-migratable migration: Allow "device add" options to only add migratable

[Qemu-devel] [PATCH v6 1/5] block/vvfat: Remove the undesirable comment

Remove the "// assert(is_consistent(s))" comment in block/vvfat.c Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- block/vvfat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index ded2109..7b706dc 100644 --- a/block/vvfat.c +++

[Qemu-devel] [PATCH v6 4/5] migration: disallow migrate_add_blocker during migration

If a migration is already in progress and somebody attempts to add a migration blocker, this should rightly fail. Add an errp parameter and a retcode return value to migrate_add_blocker. Signed-off-by: John Snow <js...@redhat.com> Signed-off-by: Ashijeet Acharya <ashijeetacha...@

[Qemu-devel] [PATCH v6 5/5] migration: Fail migration blocker for --only-migratable

migrate_add_blocker should rightly fail if the '--only-migratable' option was specified and the device in use should not be able to perform the action which results in an unmigratable VM. Make migrate_add_blocker return -EACCES in this case. Signed-off-by: Ashijeet Acharya <ashijeeta

[Qemu-devel] [PATCH v6 2/5] migration: Add a new option to enable only-migratable

Add a new option "--only-migratable" in qemu which will allow to add only those devices which will not fail qemu after migration. Devices set with the flag 'unmigratable' cannot be added when this option will be used. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com&

[Qemu-devel] [PATCH v6 3/5] migration: Allow "device add" options to only add migratable devices

uot; and "-usbdevice" command line options and covers their hmp and qmp counterparts as well. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hw/usb/bus.c | 19 +++ qdev-monitor.c | 9 + 2 files changed, 28 insertions(+) diff --git a/hw/us

[Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet

[Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 05/09/2016 13:37, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters for setting maximum migration speed and expec

[Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

Include migrate_set_speed and migrate_set_downtime inside migrate_set_parameters for setting maximum migration speed and expected downtime parameters respectively. Also update the query part for both in qmp and hmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeeta

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 5:31 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 05/09/2016 13:59, Ashijeet Acharya wrote: >>>> >> +if (has_migrate_set_speed) { >>>> >> +qmp_migrate_set_speed(migrate_set_speed, NULL); >&

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 05/09/2016 13:37, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters for setting maximum migration speed and expec

[Qemu-devel] [PATCH] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hmp-commands.hx | 8 +-- hmp.c | 29 +- include/migration/migration.h | 1 - migration/migration.c | 122 +++---

Re: [Qemu-devel] [PATCH] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Mon, Sep 5, 2016 at 11:26 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Sep 05, 2016 at 11:20:11PM +0530, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-para

[Qemu-devel] [PATCH v3] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

Include migrate_set_speed and migrate_set_downtime inside migrate_set_parameters for setting maximum migration speed and expected downtime parameters respectively. Also update the query part for both in qmp and hmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeeta

Re: [Qemu-devel] [PATCH v3] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 9:09 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Sep 05, 2016 at 08:44:26PM +0530, Ashijeet Acharya wrote: >> On Mon, Sep 5, 2016 at 8:06 PM, Daniel P. Berrange <berra...@redhat.com> >> wrote: >> > On Mon, Sep 05, 2016 a

Re: [Qemu-devel] [PATCH v3] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 8:06 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Sep 05, 2016 at 07:56:26PM +0530, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters for setting maximum migration speed and

[Qemu-devel] [PATCH v3] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter (reversed logic)

() and qmp_migrate_set_downtime() as wrappers on qmp_migrate_set_parameters(). Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hmp.c | 33 include/migration/migration.h | 1 - migration/migration.c | 116 --

Re: [Qemu-devel] [PATCH] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Mon, Sep 5, 2016 at 11:37 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > On Mon, Sep 5, 2016 at 11:26 PM, Daniel P. Berrange <berra...@redhat.com> > wrote: >> On Mon, Sep 05, 2016 at 11:20:11PM +0530, Ashijeet Acharya wrote: >>> Mark old-commands for

[Qemu-devel] [PATCH v2] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

in both hmp and qmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hmp.c | 27 ++ include/migration/migration.h | 1 - migration/migration.c | 120 -- qapi-schem

[Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

Include migrate_set_speed and migrate_set_downtime inside migrate_set_parameters respectively for setting maximum migration speed and expected downtime parameters. Also add the query part for both in qmp and hmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeeta

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 1:31 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 05/09/2016 09:45, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters respectively for setting maximum migration >> speed

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

On Mon, Sep 5, 2016 at 1:46 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 05/09/2016 10:11, Ashijeet Acharya wrote: >> > > Include migrate_set_speed and migrate_set_downtime inside >> > > migrate_set_parameters respectively for setting maximum migra

Re: [Qemu-devel] [PATCH v2] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Tue, Sep 6, 2016 at 6:52 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > On Tue, Sep 6, 2016 at 4:32 PM, Dr. David Alan Gilbert > <dgilb...@redhat.com> wrote: >> * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >>> Mark old-commands for speed and

Re: [Qemu-devel] [PATCH v2] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Tue, Sep 6, 2016 at 4:32 PM, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters f

[Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

in both hmp and qmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hmp.c | 26 ++ include/migration/migration.h | 1 - migration/migration.c | 116 -- qapi-schem

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

I am still waiting for review on this one. On Tue, Aug 16, 2016 at 10:40 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add > idebus_unrealize() in hw/ide/qdev.c to have calls to > qemu_del_vm_chang

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

On Thu, Sep 1, 2016 at 9:13 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 01/09/2016 07:31, Ashijeet Acharya wrote: >> I am still waiting for review on this one. > > Hi, > > QEMU is in hard freeze now so it's normal to have some delay in patch > review. M

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Wed, Sep 7, 2016 at 2:11 PM, Juan Quintela <quint...@redhat.com> wrote: > Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >>

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Thu, Sep 8, 2016 at 3:33 AM, Eric Blake <ebl...@redhat.com> wrote: > On 09/06/2016 08:39 AM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> sett

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Thu, Sep 8, 2016 at 8:11 PM, Juan Quintela wrote: > Eric Blake wrote: > >>> +if (has_max_bandwidth) { >>> +s->parameters.max_bandwidth = max_bandwidth; >>> +if (s->to_dst_file) { >>> +

[Qemu-devel] [PATCH v4] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

in both hmp and qmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- hmp.c | 26 ++ include/migration/migration.h | 1 - migration/migration.c | 116 -- qapi-schem

Re: [Qemu-devel] [PATCH v4] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Fri, Sep 9, 2016 at 8:41 AM, Eric Blake <ebl...@redhat.com> wrote: > On 09/08/2016 10:59 AM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> sett

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

>> +++ b/migration/migration.c >> @@ -44,6 +44,10 @@ >> #define BUFFER_DELAY 100 >> #define XFER_LIMIT_RATIO (1000 / BUFFER_DELAY) >> >> +/* Time in nanoseconds we are allowed to stop the source, >> + * for sending the last part */ >> +#define DEFAULT_MIGRATE_SET_DOWNTIME 3 >> + > >

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

On Wed, Sep 14, 2016 at 7:28 PM, Eric Blake <ebl...@redhat.com> wrote: > On 09/14/2016 03:05 AM, Ashijeet Acharya wrote: > >>>> +if (params->has_max_bandwidth && >>>> +(params->max_bandwidth < 0 || params->ma

[Qemu-devel] [PATCH v6] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

) and set its upper bound limit to 2000 seconds. Update the query part in both hmp and qmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- Changes in v6 -Improve the commit message -Mention new upper limit of downtime in commit message -Drop the use o

[Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

in both hmp and qmp qemu control interfaces. NOTE: This patch is solely based on Eric's new boxed parameters from QAPI patch series. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- Changes in v5: - Include units in the output of 'info migrte_parameters' - Change 'old-co

[Qemu-devel] [PATCH] migrate: Fix bounds check for migration parameters in migration.c

. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 9b4aa55..cd8334c 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -805,6 +805,7 @

Re: [Qemu-devel] [PATCH v4] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

On Fri, Sep 9, 2016 at 12:02 AM, Eric Blake <ebl...@redhat.com> wrote: > On 09/08/2016 10:59 AM, Ashijeet Acharya wrote: > > Long subject line; we strive to stay below 70 bytes so that you can > prepend commit ids and still stay in an 80-column window. Also, you can > look

[Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c

, parameters were getting set to out-of-bounds values despite the error. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- Changes in v4: -Fix the typo in commit message -Include the commit id which caused the regression --

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

On Wed, Sep 14, 2016 at 12:52 AM, Eric Blake <ebl...@redhat.com> wrote: > On 09/09/2016 02:02 PM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. > > Maybe s/old-commands for speed and downtime/the old commands > 'migrate_set_speed' a

Re: [Qemu-devel] [PATCH v6] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

On Thu, Sep 15, 2016 at 9:18 PM, Eric Blake <ebl...@redhat.com> wrote: > On 09/14/2016 12:40 PM, Ashijeet Acharya wrote: >> Mark the old commands 'migrate_set_speed' and 'migrate_set_downtime' as >> deprecated. >> Move max-bandwidth and downtime-limit into migrate-se

[Qemu-devel] [PATCH v7] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

) and set its upper bound limit to 2000 seconds. Update the query part in both hmp and qmp qemu control interfaces. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- Changes in v7 - Fix the error message for bounds check of m

[Qemu-devel] [PATCH v3] migrate: Fix bounds check for migration parameters in migration.c

, parameters were getting set to out-of-bounds values despite the error. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 9b4aa55..cd8334c

[Qemu-devel] [PATCH v2] migrate: Fix bounds check for migration parameters in migration.c

, parameters were getting set to out-of-bounds values despite the error. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 9b4aa55..cd8334c

Re: [Qemu-devel] [PATCH v2] migrate: Fix bounds check for migration parameters in migration.c

On Sat, Sep 10, 2016 at 2:03 AM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > This patch fixes the out-of-bounds check of migration parameters in > qmp_migrate_set_parameters() for cpu-throttle-initial and > cpu-throttle-increment by adding a return statement for both

Re: [Qemu-devel] [Qemu-block] block/ssh:Allow blockdev-add for ssh

On Thu, Sep 29, 2016 at 5:29 PM, Richard W.M. Jones wrote: > On Thu, Sep 29, 2016 at 01:36:35PM +0200, Kevin Wolf wrote: >> But the ssh client doesn't seem to support connection to that Unix domain >> socket, even if it would be possible to support in theory. And probably >>

Re: [Qemu-devel] [Qemu-block] block/ssh:Allow blockdev-add for ssh

On Thu, Sep 29, 2016 at 8:32 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 29.09.2016 um 16:07 hat Ashijeet Acharya geschrieben: >> Other than that I also asked if I have accidentally missed any other >> important field regarding the structure 'BlockdevOptionsSsh' I >>

[Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to support blockdev-add for SSH network protocol driver. Use only 'struct InetSocketAddress' since SSH only supports connection over TCP. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- qapi/block-core.jso

Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

On Sat, Oct 8, 2016 at 4:24 PM, Richard W.M. Jones <rjo...@redhat.com> wrote: > On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote: >> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to >> support blockdev-add for SSH network protocol dri

Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

On Mon, Oct 10, 2016 at 5:01 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 10.10.2016 um 12:48 hat Ashijeet Acharya geschrieben: >> On Mon, Oct 10, 2016 at 2:45 PM, Kevin Wolf <kw...@redhat.com> wrote: >> > Am 08.10.2016 um 12:44 hat Ashijeet Acharya

Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

On Mon, Oct 10, 2016 at 6:23 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 10.10.2016 um 13:54 hat Ashijeet Acharya geschrieben: >> On Mon, Oct 10, 2016 at 5:01 PM, Kevin Wolf <kw...@redhat.com> wrote: >> > Your .bdrv_open() callback in ssh gets these options as keys

[Qemu-devel] [PATCH v2] ide: Fix memory leak in ide_register_restart_cb()

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet

Re: [Qemu-devel] [PATCH v2] ide: Fix memory leak in ide_register_restart_cb()

On Thu, Sep 22, 2016 at 1:08 AM, John Snow <js...@redhat.com> wrote: > > > On 09/21/2016 01:53 PM, Ashijeet Acharya wrote: >> >> Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add >> idebus_unrealize() in hw/ide/qdev.c to have calls to &g

[Qemu-devel] block/ssh:Allow blockdev-add for ssh

Hi all, I was trying to convert SSH driver to support 'blockdev-add' and so far I have tried to figure out what the struct 'BlockdevOptionsSsh' in block-core.json should look like, { 'struct': 'BlockdevOptionsSsh', 'data': { 'tcp': 'InetSocketAddress', 'path': 'str' } } Naive

Re: [Qemu-devel] [PATCH v3] ide: Fix memory leak in ide_register_restart_cb()

On Wed, Sep 28, 2016 at 3:58 AM, John Snow <js...@redhat.com> wrote: > > > On 09/27/2016 12:53 PM, Ashijeet Acharya wrote: >> >> Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add >> idebus_unrealize() in hw/ide/qdev.c to have calls to &g

Re: [Qemu-devel] [PATCH v2] ide: Fix memory leak in ide_register_restart_cb()

On Tue, Sep 27, 2016 at 10:08 PM, John Snow <js...@redhat.com> wrote: > > > On 09/22/2016 01:47 AM, Ashijeet Acharya wrote: >> >> On Thu, Sep 22, 2016 at 1:08 AM, John Snow <js...@redhat.com> wrote: >>> >>> >>> >>> On 09/21/20

[Qemu-devel] [PATCH v3] ide: Fix memory leak in ide_register_restart_cb()

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet

[Qemu-devel] block/nfs: Fine grained runtime options in nfs

Hi all, I was working on trying to add blockdev-add compatibility for the nfs block driver but before that runtime options need to be separated into various options rather than just a simple "filename" option. I have added the following until now: a) host b) port (not sure about this one, do we

Re: [Qemu-devel] [PATCH v2 2/2] qapi: allow blockdev-add for NFS

On Wed, Oct 26, 2016 at 3:19 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 25.10.2016 um 23:16 hat Eric Blake geschrieben: >> On 10/24/2016 02:27 PM, Ashijeet Acharya wrote: >> > Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to >> > support bloc

[Qemu-devel] [PATCH v3 1/2] block/nfs: Introduce runtime_opts in NFS

Make NFS block driver use various fine grained runtime_opts. Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two new functions nfs_parse_filename() and nfs_parse_uri() to help parsing the URI. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- block/nfs.c

[Qemu-devel] [PATCH v3 0/2] block: allow blockdev-add for NFS

the names of query parameters in JSON Changes in v2: - drop strcmp() condition check for host and path in nfs_parse_uri() - drop "export" completely - initialize client->context bedore setting query parameters - fix the QDict options being passed to nfs_client_open() and make use of

[Qemu-devel] [PATCH v3 2/2] qapi: allow blockdev-add for NFS

Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to support blockdev-add for NFS network protocol driver. Also make a new struct NFSServer to support tcp connection. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- qapi/block-core.jso

[Qemu-devel] [PATCH v5 2/2] qapi: allow blockdev-add for NFS

Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to support blockdev-add for NFS network protocol driver. Also make a new struct NFSServer to support tcp connection. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> --- qapi/block-core.jso

[Qemu-devel] [PATCH v5 0/2] allow blockdev-add for NFS

nt->context bedore setting query parameters - fix the QDict options being passed to nfs_client_open() and make use of url Ashijeet Acharya (2): block/nfs: Introduce runtime_opts in NFS qapi: allow blockdev-add for NFS block/nfs.c | 430

  1   2   3   4   >