[Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute()

2013-11-28 Thread Gerd Hoffmann
Same as kbd_mouse_is_absolute(), but using new input core. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 1 + ui/input.c | 8 2 files changed, 9 insertions(+) diff --git a/include/ui/input.h b/include/ui/input.h index 0d79342..43b9afc 100644

Re: [Qemu-devel] [PATCH] trace-events: Clean up after removal of old usb-host code

2013-11-28 Thread Gerd Hoffmann
On Mo, 2013-11-25 at 13:08 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Commit b5613fd neglected to drop the trace events along with the code. Added to usb patch queue. thanks, Gerd

[Qemu-devel] [RFC PATCH 04/15] input: add core bits of the new input layer

2013-11-28 Thread Gerd Hoffmann
Register and unregister handlers. Event dispatcher code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 32 + ui/Makefile.objs | 2 +- ui/input.c | 83 ++ 3 files changed, 116 insertions

[Qemu-devel] [RFC PATCH 06/15] input: keyboard: switch legacy handlers to new core

2013-11-28 Thread Gerd Hoffmann
is fully functional for keyboard events. New + legacy interfaces can be mixed in any way. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input-legacy.c | 54 -- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/ui/input-legacy.c

Re: [Qemu-devel] [PATCH 0/3] usb-host-libusb: streams support

2013-11-28 Thread Gerd Hoffmann
On Do, 2013-11-21 at 17:20 +0100, Hans de Goede wrote: Hi Gerd, Here is a new version of the 3 patches to add streams support to usb-host-libusb, with the error when building with an older libusbx fixed. Added to usb patch queue. thanks, Gerd

[Qemu-devel] [RFC PATCH 15/15] input: mouse: switch sdl ui to new core

2013-11-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl.c | 65 +--- 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 1b1224a..13076e3 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -357,7 +357,7

Re: [Qemu-devel] usb: a problem of using libusb for usb pass through

2013-07-22 Thread Gerd Hoffmann
On 07/16/13 10:45, Gonglei (Arei) wrote: Hi, Gerd My Qemu version is 1.5.1, and use libusb for usb pass through. I pass through a host usb device to the guest by bus number and physical port, when I unplug the usb device from the host, and plug in on the same physical port

[Qemu-devel] [PATCH] spice: fix display initialization

2013-07-22 Thread Gerd Hoffmann
-vga goes unnoticed. Fix that by adding a check in the spice interface registration so we'll notice the qxl card no matter how it is created. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/qemu-spice.h |2 ++ ui/spice-core.c |5 + vl.c|2

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Gerd Hoffmann
Hi, Note: due to QAPI not generating async commands yet I had to remove the schema screendump definition. Hmm, that will break libvirt I suspect. Guess this one has to wait until QAPI gained proper async command support. cheers, Gerd

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-14 Thread Gerd Hoffmann
Hi, Hmm. Speaking of the splitting. Does the current bios include the the tables which were split into separate files? Yes, they are in out/ too after building seabios. Use qemu -L /path/to/seabios/out to make sure qemu picks up matching bios.bin and dsdt. cheers, Gerd

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Gerd Hoffmann
Hi, Why is QXL unable to do a synchronous screendump? Lazy rendering. By default spice-server doesn't render anything, it just sends over all drawing ops to the client who does the actual rendering for the user. qemu can kick spice-server and ask it to render stuff locally if needed.

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-17 Thread Gerd Hoffmann
Hi, Can I use current seabios with old qemu which does not provide the separate ACPI tables? For example, does current bios contain these tables too, so they're both separate and embedded? Yes. The i440fx acpi tables are compiled in and will be used as fallback in case qemu doesn't

Re: [Qemu-devel] [PATCH RFC 1/8] ui/input: Clean up QEMUPutMouseEntry struct

2013-06-17 Thread Gerd Hoffmann
On 06/16/13 05:39, Andreas Färber wrote: Shorten field names to not duplicate struct name. Nice. Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] [PATCH RFC 0/8] monitor: Fix mouse_button and improve mouse_move commands

2013-06-17 Thread Gerd Hoffmann
Hi, My solution is to obtain position and buttons state from where the VMState is: I clean up the mouse event handler registration code a bit and extend it: * one mandatory callback to obtain mouse button state and * one optional callback to obtain absolute position state from backends.

Re: [Qemu-devel] [PATCH RFC 2/8] ui/input: Simplify kbd_mouse_event()

2013-06-17 Thread Gerd Hoffmann
On 06/16/13 05:39, Andreas Färber wrote: Now that the field names are bearable, there's no compelling reason to use local variables for the fields. Unify the four callback invokations through variables for the rotated coordinates instead. Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers

Re: [Qemu-devel] [PATCH RFC 4/8] ui/input: Introduce MouseOps for qemu_add_mouse_event_handler()

2013-06-17 Thread Gerd Hoffmann
On 06/16/13 05:40, Andreas Färber wrote: This allows to add callbacks to mouse event handlers without constantly touching all callers of qemu_add_mouse_event_handler() or qemu_add_mouse_event_handler() itself. I think you can stick other static information into the Ops too: name + absolute.

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 10:10, Peter Lieven wrote: Hi Gerd, just looking at your patch. It works fine so far, but I am curious how to handle the lock keys? I have the problem that if I press caps lock and then create a new vnc session with exclusive access (from another terminal), the caps lock is

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 13:05, Peter Lieven wrote: Am 17.06.2013 10:49, schrieb Gerd Hoffmann: On 06/17/13 10:10, Peter Lieven wrote: Hi Gerd, just looking at your patch. It works fine so far, but I am curious how to handle the lock keys? I have the problem that if I press caps lock and then create

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
Hi, I guess reset_keys() should skip capslock+numlock to not disturb the sync logic, can you try that? mhh, i might be wrong, but where could the vs-modifiers_state be not zero on a new connection. I only find a g_malloc0 initializing the VNCState. Ah, right, it is in the per-connection

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 11:30, Alon Levy wrote: But on the other hand if this is something that would be acceptable now and having proper Async error handling is not forthcoming (why btw? is anyone working on it) . But it would become baggage later on.. Don't think it is too bad, RfC patches will go out

[Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Gerd Hoffmann
/show_bug.cgi?id=903910 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qapi-schema.json | 15 +++ qmp-commands.hx | 25 + ui/console.c | 52 3 files changed, 92 insertions(+) diff --git a/qapi-schema.json

[Qemu-devel] [RfC PATCH 0/2] new screendump qmp command

2013-06-17 Thread Gerd Hoffmann
). It also adds a graphics_hw_update() variant with completion notification (by calling a bottom half). qxl then could stick the pointer to the notification BH into the QXLCookie struct and schedule the BH when spice server finished updating the screen. Gerd Hoffmann (2): display update

[Qemu-devel] [RfC PATCH 1/2] display update with notification

2013-06-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h |2 ++ ui/console.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 092b9be..4860687 100644 --- a/include/ui/console.h +++ b/include/ui

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Fix QXLRam initialisation.

2013-06-17 Thread Gerd Hoffmann
as critical as it initially looks like. Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Gerd Hoffmann
). If you wanna some more context: screendump on top of that is here: https://www.kraxel.org/cgit/qemu/log/?h=rebase/pixman [ not tested yet ] cheers, Gerd From bf1f7ec8a2baacc497e188ac38b24e5b0387b143 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann kra...@redhat.com Date: Tue, 18 Jun 2013 09:21:03

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Gerd Hoffmann
Hi, Something like the attached patch? Which is just the bare minimum I'll need for screendump. Basically a one-off bottom half with some monitor infrastructure (job id, error handling). So it isn't for big jobs, but for small jobs which have to wait for something before they execute

Re: [Qemu-devel] [PATCH 02/12] char: add qemu_chr_fe_event()

2013-06-21 Thread Gerd Hoffmann
Hi, +static void spice_chr_fe_event(struct CharDriverState *chr, int event) +{ +#if SPICE_SERVER_VERSION = 0x000c02 +SpiceCharDriver *s = chr-opaque; + +spice_server_port_event(s-sin, event); +#endif +} No way. You are passing an qemu-internal value (event) to an external

[Qemu-devel] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index fdd8dc4..364bd8c 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -855,7 +855,7

[Qemu-devel] [PATCH 00/13] A bunch of little socket + chardev fixes

2013-06-21 Thread Gerd Hoffmann
Hi, Here is a colletion of little bugfixes and minor improvements for the chardev and socket code. cheers, Gerd Gerd Hoffmann (13): qemu-socket: zero-initialize SocketAddress qemu-socket: drop pointless allocation qemu-socket: catch monitor_get_fd failures qemu-char: check optional

[Qemu-devel] [PATCH 04/13] qemu-char: check optional fields using has_*

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 2c3cfe6..ee7c70e 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3500,7 +3500,7 @@ static CharDriverState *qmp_chardev_open_file

[Qemu-devel] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index d73c112..7776016 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -908,6 +908,9 @@ int socket_connect

[Qemu-devel] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 5751391..1c0903f 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3127,7 +3127,7 @@ typedef struct CharDriver { /* old, pre qapi

[Qemu-devel] [PATCH 13/13] qemu-socket: don't leak opts on error

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 7776016..29a3564 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -971,7 +971,7 @@ int

[Qemu-devel] [PATCH 06/13] qemu-char: print notification to stderr

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index cfc68cd..3e0044b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2666,8 +2666,8 @@ static CharDriverState

[Qemu-devel] [PATCH 12/13] qemu-char: report udb backend errors

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index c83ff21..6b4daf3 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts

[Qemu-devel] [PATCH 11/13] qemu-char: add -chardev mux support

2013-06-21 Thread Gerd Hoffmann
Allow to explicitly create mux chardevs on the command line, like you can using QMP. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index 65c0c48..c83ff21 100644 --- a/qemu-char.c

[Qemu-devel] [PATCH 05/13] qemu-char: use more specific error_setg_* variants

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index ee7c70e..cfc68cd 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2604,7 +2604,7 @@ static CharDriverState

[Qemu-devel] [PATCH 10/13] qemu-char: minor mux chardev fixes

2013-06-21 Thread Gerd Hoffmann
mux failure path has a memory leak. creating a mux chardev can't fail though, so just assert() that instead of fixing an error path which never ever runs anyway ... Also fix bid being leaked while being at it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |7 +++ 1

[Qemu-devel] [PATCH 07/13] qemu-char: fix documentation for telnet+wait socket flags

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qapi-schema.json |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..a29ce57 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3185,10 +3185,11 @@ # @addr

[Qemu-devel] [PATCH 02/13] qemu-socket: drop pointless allocation

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |1 - 1 file changed, 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 364bd8c..d73c112 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -876,7 +876,6 @@ SocketAddress *socket_parse

[Qemu-devel] [PATCH 08/13] qemu-char: don't leak opts on error

2013-06-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 3e0044b..5751391 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3185,7 +3185,7 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts

Re: [Qemu-devel] [Qemu-trivial] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress

2013-06-24 Thread Gerd Hoffmann
On 06/21/13 20:15, Michael Tokarev wrote: 21.06.2013 14:38, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index fdd8dc4..364bd8c

[Qemu-devel] [PATCH v2 04/13] qemu-char: check optional fields using has_*

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 2c3cfe6..ee7c70e 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3500,7 +3500,7 @@ static CharDriverState *qmp_chardev_open_file

[Qemu-devel] [PATCH v2 01/13] qemu-socket: zero-initialize SocketAddress

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 96eca2a..86fb09c 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -848,9 +848,9 @@ int

[Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-24 Thread Gerd Hoffmann
Hi, Here is v2 of the series, addressing Michaels review comments. cheers, Gerd Gerd Hoffmann (13): qemu-socket: zero-initialize SocketAddress qemu-socket: drop pointless allocation qemu-socket: catch monitor_get_fd failures qemu-char: check optional fields using has_* qemu-char

[Qemu-devel] [PATCH v2 07/13] qemu-char: fix documentation for telnet+wait socket flags

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qapi-schema.json |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..a29ce57 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3185,10 +3185,11 @@ # @addr

[Qemu-devel] [PATCH v2 03/13] qemu-socket: catch monitor_get_fd failures

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 35023a8..126cbb6 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -903,7 +903,7 @@ int

[Qemu-devel] [PATCH v2 06/13] qemu-char: print notification to stderr

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index cfc68cd..3e0044b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2666,8 +2666,8 @@ static CharDriverState

[Qemu-devel] [PATCH v2 05/13] qemu-char: use more specific error_setg_* variants

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index ee7c70e..cfc68cd 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2604,7 +2604,7 @@ static CharDriverState

[Qemu-devel] [PATCH v2 13/13] qemu-socket: don't leak opts on error

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 126cbb6..095716e 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -963,7 +963,7 @@ int

[Qemu-devel] [PATCH v2 11/13] qemu-char: add -chardev mux support

2013-06-24 Thread Gerd Hoffmann
Allow to explicitly create mux chardevs on the command line, like you can using QMP. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index e6c3157..7d072a8 100644 --- a/qemu-char.c

[Qemu-devel] [PATCH v2 09/13] qemu-char: use ChardevBackendKind in in CharDriver

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/sysemu/char.h |2 +- qemu-char.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/sysemu/char.h b/include/sysemu/char.h index 066c216..e65e4a4 100644 --- a/include/sysemu/char.h +++ b

[Qemu-devel] [PATCH v2 08/13] qemu-char: don't leak opts on error

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 3e0044b..5751391 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3185,7 +3185,7 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts

[Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index 7d072a8..dcc91bb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts

[Qemu-devel] [PATCH v2 10/13] qemu-char: minor mux chardev fixes

2013-06-24 Thread Gerd Hoffmann
mux failure path has a memory leak. creating a mux chardev can't fail though, so just assert() that instead of fixing an error path which never ever runs anyway ... Also fix bid being leaked while being at it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |7 +++ 1

[Qemu-devel] [PATCH v2 02/13] qemu-socket: drop pointless allocation

2013-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- util/qemu-sockets.c |1 - 1 file changed, 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 86fb09c..35023a8 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -871,7 +871,6 @@ SocketAddress *socket_parse

[Qemu-devel] [PULL 0/9] usb patch queue

2013-06-24 Thread Gerd Hoffmann
) Andreas Färber (3): usb/hcd-ehci-sysbus: Convert to QOM realize usb/hcd-ehci: Split off instance_init from realize usb/hcd-ehci: Add Tegra2 SysBus EHCI device Gerd Hoffmann (3): usb-host-libusb: set USB_DEV_FLAG_IS_HOST usb: add serial

[Qemu-devel] [PATCH 6/9] usb/host-libusb: Fix building with libusb git master code

2013-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com The next libusb release will deprecate libusb_get_port_path, and since we compile with -Werror, this breaks the build. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-libusb.c |4 1

[Qemu-devel] [PATCH 3/9] usb/hcd-ehci: Add Tegra2 SysBus EHCI device

2013-06-24 Thread Gerd Hoffmann
From: Andreas Färber andreas.faer...@web.de This prepares an EHCI device for the Nvidia Tegra2 SoC family. Values based on patch by Vincent Palatin and verified against TRM v01p. Cc: Vincent Palatin vpala...@chromium.org Signed-off-by: Andreas Färber andreas.faer...@web.de Signed-off-by: Gerd

[Qemu-devel] [PATCH 1/9] usb/hcd-ehci-sysbus: Convert to QOM realize

2013-06-24 Thread Gerd Hoffmann
() to allow to return Errors from common initialization code as well. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci-pci.c|2 +- hw/usb/hcd-ehci-sysbus.c | 13 ++--- hw/usb/hcd-ehci.c|2 +- hw/usb/hcd

[Qemu-devel] [PATCH 7/9] usb-host-libusb: set USB_DEV_FLAG_IS_HOST

2013-06-24 Thread Gerd Hoffmann
... like host-{linux,bsd}.c do. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-libusb.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0c12b0f..e2f3cc8 100644 --- a/hw/usb/host-libusb.c +++ b/hw

[Qemu-devel] [PATCH 8/9] usb: add serial bus property

2013-06-24 Thread Gerd Hoffmann
This patch adds a serial property for all usb devices, which can be used to set the serial number of a usb device (as listed by lsusb -v) to a specific value. Applies to emulated devices only. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/bus.c |1 + hw/usb/desc.c

[Qemu-devel] [PATCH 9/9] usb: fix serial number for hid devices

2013-06-24 Thread Gerd Hoffmann
commit 7b074a22dab4bdda9864b933f1bc811a3db42845 changed the serial number of hid devices. Add compat properties to keep the old serial number for qemu 0.12 and older. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/i386/pc_piix.c | 12 1 file changed, 12 insertions(+) diff

[Qemu-devel] [PATCH 5/9] usb/hcd-ehci: Add Faraday FUSBH200 support

2013-06-24 Thread Gerd Hoffmann
From: Kuo-Jung Su dant...@faraday-tech.com Add Faraday FUSBH200 support, which is slightly different from EHCI spec. (Or maybe simply a bad/wrong implementation...) Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Gerd Hoffmann kra

[Qemu-devel] [PATCH 2/9] usb/hcd-ehci: Split off instance_init from realize

2013-06-24 Thread Gerd Hoffmann
From: Andreas Färber afaer...@suse.de This makes the mem MemoryRegion available to derived instance_inits. Keep the bus in realize for now since naming breaks in instance_init. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci

[Qemu-devel] [PATCH 4/9] usb/hcd-ehci: Replace PORTSC macros with variables

2013-06-24 Thread Gerd Hoffmann
From: Kuo-Jung Su dant...@faraday-tech.com Replace PORTSC macros with variables which could then be configured in ehci__class_init(...) Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw

[Qemu-devel] [PATCH 1/2] qxl: fix Coverity scan SIGN_EXTENSION error

2013-06-24 Thread Gerd Hoffmann
Cc: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl-render.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index f511a62..269b1a7 100644 --- a/hw/display/qxl-render.c

[Qemu-devel] [PULL 0/2] spice patch queue

2013-06-24 Thread Gerd Hoffmann
) Gerd Hoffmann (1): qxl: fix Coverity scan SIGN_EXTENSION error Hans de Goede (1): spice: Add -spice disable-agent-file-transfer cmdline option (rhbz#961850) hw/display/qxl-render.c |2 +- qemu-options.hx |7 +-- ui

[Qemu-devel] [PATCH 2/2] spice: Add -spice disable-agent-file-transfer cmdline option (rhbz#961850)

2013-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-options.hx |7 +-- ui/spice-core.c | 13 + 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu

[Qemu-devel] [PATCH] console: Hook QemuConsoles into qom tree

2013-06-25 Thread Gerd Hoffmann
Put them named console[$index] below /backend, so you can list inspect them via QMP. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/console.c b/ui/console.c index 28bba6d..e3e8297 100644 --- a/ui/console.c

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-25 Thread Gerd Hoffmann
Hi, Maybe we really should do a proper QMP jobs API. Using a BH makes sense for the screenshot case but is orthogonal to the QMP job API. I'll drop that from my todo list for now. No way I can finish this off before my family summer vacation. I'm also hoping that someone who knows qapi +

[Qemu-devel] [PATCH] gtk: add support for surface conversion

2013-06-25 Thread Gerd Hoffmann
* never been properly implemented in cairo and should not be used * by applications. (since 1.2) /quote Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 63 +++--- 1 file changed, 40 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-26 Thread Gerd Hoffmann
This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: framebuffer-display enable=on|off scale=on|off device=/dev/fbn hmp: framebuffer-display on|off There is also a query-framebuffer command for qmp. Signed-off-by: Gerd Hoffmann kra

[Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-26 Thread Gerd Hoffmann
to it (usually requires root privileges to open /dev/ttynr). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure | 12 + include/sysemu/sysemu.h |1 + include/ui/console.h|4 + qemu-options.hx |4 +- trace-events| 14 + ui

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-27 Thread Gerd Hoffmann
Hi, +/* open framebuffer */ +if (device == NULL) { +device = getenv(FRAMEBUFFER); +} +if (device == NULL) { +device = /dev/fb0; +} Maybe this is a matter of taste, but I think that having this logic at this layer makes the API harder to use. What

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-27 Thread Gerd Hoffmann
Hi, --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3608,3 +3608,46 @@ '*cpuid-input-ecx': 'int', 'cpuid-register': 'X86CPURegister32', 'features': 'int' } } + +## +# @framebuffer-display: Let me bike-shed: we're trying to make command's

Re: [Qemu-devel] [PATCH] Avoid use of QOM type name macros in VMStateDescriptions

2013-06-27 Thread Gerd Hoffmann
On 06/27/13 13:03, Peter Maydell wrote: The one I didn't touch was hw/usb/host-linux.c, since that changes the QOM typename and the VMStateDescription name depending on whether QEMU was built with CONFIG_USB_LIBUSB defined or not. That seems a bit fishy to me but I've left it alone. vmstate

Re: [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remove for qapi-based init

2013-06-27 Thread Gerd Hoffmann
the device is gone, its options linger, and any attempt to create another one with the same ID fails. Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

[Qemu-devel] [PATCH 12/17] xhci: Call usb_device_alloc/free_streams

2013-11-29 Thread Gerd Hoffmann
support the same amount of streams), but lets stick to the kernel API. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 117 ++ 1 file changed, 117 insertions(+) diff --git a/hw

[Qemu-devel] [PATCH 13/17] ehci: implement port wakeup

2013-11-29 Thread Gerd Hoffmann
Update portsc register and raise irq in case a suspended port is woken up, so remote wakeup works on our ehci ports. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci.c | 18 -- trace-events | 3 +++ 2 files changed, 19 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 14/17] Revert usb-tablet: Don't claim wakeup capability for USB-2 version

2013-11-29 Thread Gerd Hoffmann
This reverts commit aa1c9e971e80d25b92908dce3dec7c38b49480ea. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 5956720..5e667f0 100644 --- a/hw/usb/dev-hid.c +++ b/hw

[Qemu-devel] [PATCH 02/17] xhci: add support for suspend/resume

2013-11-29 Thread Gerd Hoffmann
to signal an error on restore. The guest OS should do a full reinitialization after resume then. This is the minimal patch which gets S3 going with xhci. Implementing full save/restore support is TBD. https://bugzilla.redhat.com/show_bug.cgi?id=1012365 Signed-off-by: Gerd Hoffmann kra

[Qemu-devel] [PATCH 01/17] xhci: Add a few missing checks for disconnected devices

2013-11-29 Thread Gerd Hoffmann
...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 835f65e..c3377ee 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1495,7 +1495,8

[Qemu-devel] [PATCH 08/17] uas: Fix response iu struct definition

2013-11-29 Thread Gerd Hoffmann
code for an invalid iu, which confirms that the response code is being reported in byte 7 of the response iu rather then in byte 6. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 18 -- 1 file changed, 8

[Qemu-devel] [PATCH 17/17] usb: move usb_{hi, lo} helpers to header file.

2013-11-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/desc.c | 10 -- hw/usb/desc.h | 11 +++ 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c index 5dbe754..f18a043 100644 --- a/hw/usb/desc.c +++ b/hw/usb/desc.c @@ -6,16 +6,6

[Qemu-devel] [PATCH 09/17] uas: s/ui/iu/

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com The various uas data structures are called IU-s, which is short for Information Unit, rather then UI-s. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 76

[Qemu-devel] [PATCH 04/17] uas: Only use report iu-s for task_mgmt status reporting

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Regular scsi cmds should always report their status using a sense-iu, using the sense code to report any errors. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 30

[Qemu-devel] [PATCH 11/17] usb: Add usb_device_alloc/free_streams

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/bus.c | 18 ++ include/hw/usb.h | 12 2 files changed, 30 insertions(+) diff --git a/hw/usb/bus.c b/hw/usb/bus.c

[Qemu-devel] [PATCH 06/17] uas: Streams are numbered 1-y, rather then 0-x

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com It is easier to simply make the arrays one larger, rather then substracting one everywhere. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PATCH 07/17] uas: Bounds check tags when using streams

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Disallow the guest to cause us to address the data3 and status3 arrays out of bounds. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 14 ++ 1 file changed, 14 insertions

[Qemu-devel] [PATCH 15/17] trace-events: Clean up after removal of old usb-host code

2013-11-29 Thread Gerd Hoffmann
From: Markus Armbruster arm...@redhat.com Commit b5613fd neglected to drop the trace events along with the code. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- trace-events | 13 - 1 file changed, 13 deletions(-) diff --git

[Qemu-devel] [PATCH 10/17] usb: Add max_streams attribute to endpoint info

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/core.c| 22 ++ hw/usb/desc.c| 2 ++ include/hw/usb.h | 3 +++ 3 files changed, 27 insertions(+) diff --git a/hw/usb

[Qemu-devel] [PATCH 05/17] uas: Fix / cleanup usb_uas_task error handling

2013-11-29 Thread Gerd Hoffmann
by lun, so this will never trigger Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 36a75b2..12d79ef

[Qemu-devel] [PULL 00/17] usb patch queue

2013-11-29 Thread Gerd Hoffmann
. Gerd Hoffmann (5): xhci: add support for suspend/resume ehci: implement port wakeup Revert usb-tablet: Don't claim wakeup capability for USB-2 version usb: add vendor request defines usb: move usb_{hi,lo} helpers to header file. Hans de Goede (11): xhci: Add a few

[Qemu-devel] [PATCH 16/17] usb: add vendor request defines

2013-11-29 Thread Gerd Hoffmann
Add defines for vendor specific usb control requests. Group defines by Device / Interface / Endpoint while being at it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/hw/usb.h | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/include/hw/usb.h b

[Qemu-devel] [PATCH 03/17] scsi: Add 2 new sense codes needed by uas

2013-11-29 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/scsi/scsi-bus.c | 10 ++ include/hw/scsi/scsi.h | 4 2 files changed, 14 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi

Re: [Qemu-devel] [PATCH 00/21] RFCv2: add Spice block device

2013-11-29 Thread Gerd Hoffmann
On Fr, 2013-11-22 at 14:28 +0100, Marc-André Lureau wrote: Hi there, Even though there is no rush to review this series, it would be nice to get the first ~10 patches. It would make the next rebase easier, and the review smaller. Can you send the ready-to-go spice bits as separate patch

[Qemu-devel] seabios release planning

2013-11-29 Thread Gerd Hoffmann
Hi, qemu 1.7 is almost out of the door. I want update seabios early in the 1.8 devel cycle. Time to do resume the release planning since we've scratched the idea to do a last-minute bios update for 1.7. I'd like to see a seabios release from the master branch in december. Ideally we'll put a

Re: [Qemu-devel] seavgabios resolutions, win8

2013-11-29 Thread Gerd Hoffmann
Hi, +{ 0x18d, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, +{ 0x18e, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, +{ 0x18f, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } }, I'm not sure I understand how list of modes is maintained/used in seavgabios. The above

[Qemu-devel] [PATCH] intel-hda: fix position buffer

2013-12-02 Thread Gerd Hoffmann
to glitches when recording and playing at the same time: https://bugzilla.redhat.com/show_bug.cgi?id=947785 Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/audio/intel-hda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel

<    1   2   3   4   5   6   7   8   9   10   >