From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-config.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index 3abe655..1efdbec 100644
--- a/qemu-config.c
+++ b/qemu-config.c
On 08/30/10 17:48, Anthony Liguori wrote:
On 08/30/2010 10:43 AM, Jes Sorensen wrote:
Yes it's technically legal. However it's painful when you try to apply
more aggressive warning flags looking for real bugs.
No, this is GCC being stupid.
I would suggest we modify the coding style
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
ui/vnc-enc-tight.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index c4c9c3b..df975af 100644
--- a/ui/vnc-enc-tight.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
block/raw.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/raw.c b/block/raw.c
index 61e6748..fc057d0 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -12,7 +12,7
On 08/30/10 17:43, Anthony Liguori wrote:
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensenjes.soren...@redhat.com
Signed-off-by: Jes Sorensenjes.soren...@redhat.com
---
linux-aio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
json-parser.c | 39 +++
1 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index 70b9b6f..68ff9c1 100644
--- a/json
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
slirp/bootp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/bootp.c b/slirp/bootp.c
index 3e4e881..41460ff 100644
--- a/slirp/bootp.c
+++ b/slirp/bootp.c
@@ -33,7
From: Jes Sorensen jes.soren...@redhat.com
This keeps the compiler happy when building with -Wextra while
effectively generating the same code.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qjson.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qjson.c b
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
block/sheepdog.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 81aa564..2ef8655 100644
--- a/block
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
nbd.c |4 ++--
nbd.h |2 +-
qemu-nbd.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/nbd.c b/nbd.c
index a9f295f..7049998 100644
--- a/nbd.c
+++ b
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
ui/vnc-enc-tight.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index c4c9c3b..c942bb7 100644
--- a/ui/vnc-enc-tight.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
block/vmdk.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 2d4ba42..54ad66f 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -437,7
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
block/qcow.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 816103d..c4d8cb3 100644
--- a/block/qcow.c
+++ b/block/qcow.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
linux-aio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..3240996 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -118,7 +118,7
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
block/qcow2-cluster.c | 17 -
block/qcow2.c | 10 +-
block/qcow2.h |7 +++
3 files changed, 16 insertions(+), 18 deletions(-)
diff --git a/block
On 08/30/10 18:56, malc wrote:
On Mon, 30 Aug 2010, Anthony Liguori wrote:
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensenjes.soren...@redhat.com
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..3240996 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -118,7
On 08/30/10 18:29, Anthony Liguori wrote:
On 08/30/2010 11:18 AM, Paolo Bonzini wrote:
It falls under the missing fields in initializer warning. Arguably,
an empty initializer should be special cased, but it isn't.
So the warning is for old style initializer lists? I disagree that it's
a
From: Jes Sorensen jes.soren...@redhat.com
Hi,
I started building QEMU with some more aggressive error flags to see
what dropped out. I started fixing up some of the cases, removing
unused arguments to functions, comparisons of unsigned types against
negative values etc. and a few other minor
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-nbd.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 9cc8f47..67ce50b 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -417,7 +417,10
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-config.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index 3abe655..1efdbec 100644
--- a/qemu-config.c
+++ b/qemu-config.c
From: Jes Sorensen jes.soren...@redhat.com
Do not store return of get_image_size() in a uint32_t as it makes it
impossible to detect error returns from get_image_size.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/multiboot.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
On 08/30/10 18:40, Paolo Bonzini wrote:
On 08/30/2010 06:16 PM, Anthony Liguori wrote:
This is why this type of warning sucks. Passing BlockDriverState is a
matter of readability because these are roughly methods. Just because
'this' isn't used right now, doesn't mean that it should not be a
On 08/30/10 18:55, Nathan Froyd wrote:
On Mon, Aug 30, 2010 at 10:48:55AM -0500, Anthony Liguori wrote:
No, this is GCC being stupid.
How else do you terminate a list? IOW:
MyDeviceInfo device_infos[] = {
{foo, 0, 2},
{bar, 0, 1},
{} /* or { 0 } */
};
This is such a pervasive
On 08/22/10 20:35, malc wrote:
On Sun, 22 Aug 2010, Blue Swirl wrote:
What's the ultimate editor? I'd love to drop Emacs, which is annoying
but does its job better than the others that I've tried.
ed
ed is for sissies, real developers use cat, echo, and sed.
Jes
On 08/22/10 20:13, Blue Swirl wrote:
Well, consider for example mass braces conversion to the One Style,
whichever that is. Would it be better to do it in one commit or
multiple commits? If the latter, push all commits back-to-back or just
one at a time now and then?
At the extreme end, we
On 08/22/10 20:39, malc wrote:
Disregarding my own stance on the braces, braces around single statement
is actually helpful w.r.t. debugging imaging trying to set a break point
on said singlesttement, plain impossible in following case:
if (a) b;
Oh there is no talk about suggesting we
On 08/22/10 20:42, Anthony Liguori wrote:
On 08/22/2010 01:36 PM, malc wrote:
But how would you do that? Drop the CODING_STYLE (and accept
anything)? Switch to a new CODING_STYLE that is widely appreciated and
so all bikeshedding will cease? Enforce current style?
I would suggest
On 08/22/10 22:39, Avi Kivity wrote:
On 08/22/2010 10:44 PM, malc wrote:
There is the problem that some patch submitters are reminded of
CODING_STYLE while others aren't. Some don't need to be reminded but
they are not part of the problem.
And to this i fully subscribe.
I agree.
From
On 08/23/10 16:03, Avi Kivity wrote:
On 08/23/2010 04:55 PM, Jes Sorensen wrote:
Well with the inconsistency we have now, what is the right iron fist to
apply? Demand the code is consistent with the file you edit or that it's
consistent with whats in CODING_STYLE, even if it means that what
On 08/21/10 12:47, Blue Swirl wrote:
On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster arm...@redhat.com wrote:
Unless you mass-convert existing code to your style, tools working on
source files won't cut it, because reports of the patch's style
violations are prone to drown in a sea of
On 08/21/10 16:03, Blue Swirl wrote:
On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster arm...@redhat.com wrote:
Could be fun for developers using Windows. If they exist.
At least OCaml site offers binary download for Windows. I didn't
compile Coccinelle myself, so I don't know how much
On 08/22/10 22:15, Avi Kivity wrote:
On 08/19/2010 09:29 PM, Blue Swirl wrote:
Just to be sure I follow, are you suggesting we relax all of the bracing
rule, or just the part about braces around single line statements? I'd
be happy to write up a patch for the latter.
I'd rather not relax
On 08/18/10 18:46, Avi Kivity wrote:
On 08/17/2010 10:15 PM, Jes Sorensen wrote:
I strongly disagree. The use of bool, even if you ignore stdbool.h
and do typedef int bool, is valuable documentation in the code.
I guess we have to agree to disagree then. IMHO it just masks the real
type
On 08/19/10 10:10, Avi Kivity wrote:
On 08/19/2010 10:58 AM, Jes Sorensen wrote:
In C99, bool is a real type.
Kinda real, I would qualify it more as a pseudo type. It doesn't map to
any register size or even instruction actions.
Neither do int, short, long, long long, or signed short long
On 08/18/10 10:35, Paolo Bonzini wrote:
On 08/17/2010 08:39 PM, Richard Henderson wrote:
I'd strongly discourage the use of bool in any code.
I strongly disagree. The use of bool, even if you ignore stdbool.h
and do typedef int bool, is valuable documentation in the code.
I think bool is
On 08/13/10 20:02, Blue Swirl wrote:
On Fri, Aug 13, 2010 at 3:22 PM, Miguel Di Ciurcio Filho
miguel.fi...@gmail.com wrote:
The existing code that I have touched don't follow the current coding
style guidance, much less all the new recommendations being suggested.
Although, I do believe that
On 08/12/10 19:50, Blue Swirl wrote:
+While using bool is good for readability, it comes with minor caveats:
+ - Don't use bool in places where the type size must be constant across
+ all systems, like public interfaces and on-the-wire protocols.
+ - Don't compare a bool variable against the
On 08/12/10 11:17, Stefan Weil wrote:
Am 12.08.2010 00:12, schrieb Paolo Bonzini:
Jes has an opinion how thinks should be done, and I have a different one.
If you read the complete history, you can see that I suggested a
compromise (*)
which would give the same result as Jes' suggestions.
Your bug report is incomplete, you are using which display method? SDL,
VNC, or something else?
Second, for what is it worth, asking to just have it implemented is
unlikely to result in anything happening. With an open source project
someone who wants it needs to write the code.
--
implement
On 08/17/10 15:21, Anthony Liguori wrote:
On 08/17/2010 03:04 AM, Jes Sorensen wrote:
On 08/13/10 20:02, Blue Swirl wrote:
I fully agree on the need of change and support your excellent idea.
There are other ways to solve the problem, but I believe we need more
order than more chaos
On 08/17/10 20:39, Richard Henderson wrote:
On 08/17/2010 01:09 AM, Jes Sorensen wrote:
On 08/12/10 19:50, Blue Swirl wrote:
+While using bool is good for readability, it comes with minor caveats:
+ - Don't use bool in places where the type size must be constant across
+ all systems, like
On 08/17/10 20:55, malc wrote:
On Tue, 17 Aug 2010, Blue Swirl wrote:
The other thing that might be worth mentioning in the int/long section
is that long is complicated in broken development environments such as
Windows where it is only 32 bit :(
There's absolutely nothing broken about
On 08/17/10 21:24, malc wrote:
On Tue, 17 Aug 2010, Jes Sorensen wrote:
On 08/17/10 20:55, malc wrote:
On Tue, 17 Aug 2010, Blue Swirl wrote:
The other thing that might be worth mentioning in the int/long section
is that long is complicated in broken development environments
On 07/30/10 23:08, Aurelien Jarno wrote:
On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup
at init time, it is not possible to load an option ROM
On 07/31/10 16:19, Aurelien Jarno wrote:
On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote:
On 07/30/10 23:08, Aurelien Jarno wrote:
Missing braces around the return 0 line.
Half the QEMU code base doesn't have braces around single line if
statements, including in hw/pci.c
On 07/31/10 17:13, Aurelien Jarno wrote:
On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote:
If you want that, please do it in a separate patch for the entire file,
otherwise it will never become consistent. However it doesn't change the
issue either that putting braces around
From: Jes Sorensen jes.soren...@redhat.com
KVM has a minimum CPU requirement in order to run, so there is no
reason to default to the very basic family 6, model 2 (or model 3 for
qemu32) CPU since the additional features are going to be available on
the host CPU.
Signed-off-by: Jes Sorensen
On 07/28/10 12:51, Avi Kivity wrote:
On 07/28/2010 01:05 PM, jes.soren...@redhat.com wrote:
From: Jes Sorensenjes.soren...@redhat.com
KVM has a minimum CPU requirement in order to run, so there is no
reason to default to the very basic family 6, model 2 (or model 3 for
qemu32) CPU since the
From: Jes Sorensen jes.soren...@redhat.com
This allows for changing the default CPU type on the current PC
definition without breaking legacy mode.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/boards.h |1 +
hw/pc_piix.c | 15 +++
vl.c |2 ++
3 files
From: Jes Sorensen jes.soren...@redhat.com
KVM has a minimum CPU requirement in order to run, so there is no
reason to default to the very basic family 6, model 2 (or model 3 for
qemu32) CPU since the additional features are going to be available on
the host CPU.
Signed-off-by: Jes Sorensen
From: Jes Sorensen jes.soren...@redhat.com
This set of patches adds default CPU types to the PC compat
definitions, and patch #2 sets the CPU type to kvm64/kvm32 when
running under KVM.
Long term we might want to qdev'ify the CPUs but I think it is better
to keep it simple for 0.13.
Jes
On 07/27/10 10:11, Markus Armbruster wrote:
Anthony Liguori anth...@codemonkey.ws writes:
On 07/26/2010 02:19 PM, Avi Kivity wrote:
We should try to support all users, prioritized by the number of end
users they represent. If this patch broke some other large user
we'd be in a bind. But
On 07/27/10 02:13, Alex Williamson wrote:
On Mon, 2010-07-26 at 18:28 -0500, Anthony Liguori wrote:
On 07/26/2010 05:28 PM, Anthony Liguori wrote:
On 07/26/2010 04:28 PM, Chris Wright wrote:
Please send in any agenda items you are interested in covering.
- 0.13 update
I'll pre-empt the
On 07/24/10 21:03, Michael S. Tsirkin wrote:
On Fri, Jul 23, 2010 at 05:16:42PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
diff --git a/hw/vhost.c b/hw/vhost.c
index d37a66e..f30cf91 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -119,7 +119,6 @@ static
Looks like the SCSI driver is causing problems. QEMU's SCSI emulation is known
to be broken, please use IDE
or virtio-blk.
Jes
--
qemu-kvm 0.12.4+dfsg-1 from debian squeeze crashes BUG: unable to handle
kernel NULL pointer (sym53c8xx)
https://bugs.launchpad.net/bugs/587993
You received this
On 07/25/10 21:39, Avi Kivity wrote:
On 07/25/2010 04:08 PM, DG UX wrote:
Currently, these DGUX machines only support Qlogic and Adaptec, no IDE
whatsoever and no LSI.
Any way Qemu will support anything like that?
I got to know these DGUX machines very well, and know all the logs
From: Jes Sorensen jes.soren...@redhat.com
pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup
at init time, it is not possible to load an option ROM for a hotplug
device when running in compat mode.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/pci.c | 14
From: Jes Sorensen jes.soren...@redhat.com
If removing an entry from the list which is fully included in the
region and this is the first entry in the list. In this case 'to' can
go to -1, which is perfectly valid. Don't assert() on this case.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
From: Jes Sorensen jes.soren...@redhat.com
pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup
at init time, it is not possible to load an option ROM for a hotplug
device when running in compat mode.
v2: Alex Williamson pointed out that one can get to qdev directly from
Hi,
There has been some confusion around the format of the tracks at Linux
Plumbers: Presentations vs Micro Conference, so the program committee
has extended the deadline by one week. If you didn't get your submission
in earlier, or you were confused, this is your final chance.
Please see
From: Jes Sorensen jes.soren...@redhat.com
O_DIRECT (cache=none) requires sector alignment, however the physical
sector size of CDROM/DVD drives is 2048, as opposed to most disk
devices which use 512. QEMU is hard coding 512 all over the place, so
allowing O_DIRECT for CDROM/DVD devices does
On 07/20/10 19:19, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
On 07/20/10 18:35, David S. Ahern wrote:
On 07/20/10 10:09, jes.soren...@redhat.com wrote:
If a cdrom is added via the monitor this would abruptly terminate the VM
- which is not good.
True
On 07/20/10 17:40, Anthony Liguori wrote:
On 07/20/2010 10:17 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensenjes.soren...@redhat.com
O_DIRECT (cache=none) requires sector alignment, however the physical
sector size of CDROM/DVD drives is 2048, as opposed to most disk
devices which use
On 07/20/10 18:09, Kevin Wolf wrote:
Am 20.07.2010 17:40, schrieb Anthony Liguori:
Wouldn't a better solution be to have a cdrom_read/cdrom_write hook that
did the appropriate bouncing?
We already have code that does some bouncing, we'd just need to teach it
to use different sizes than
From: Jes Sorensen jes.soren...@redhat.com
O_DIRECT (cache=none) requires sector alignment, however the physical
sector size of CDROM/DVD drives is 2048, as opposed to most disk
devices which use 512. QEMU is hard coding 512 all over the place, so
allowing O_DIRECT for CDROM/DVD devices does
On 07/20/10 18:03, Anthony Liguori wrote:
On 07/20/2010 11:02 AM, Jes Sorensen wrote:
On 07/20/10 17:40, Anthony Liguori wrote:
Wouldn't a better solution be to have a cdrom_read/cdrom_write hook that
did the appropriate bouncing?
Silently disabling something a user explicitly asked
On 07/20/10 18:16, David S. Ahern wrote:
What about setting the logical and physical block size properties? Is
the intent of these to handle varying sizes amongst block devices?
David
Well the problem is that we need to know the sector size of the host
device, and then start using that
On 07/20/10 18:35, David S. Ahern wrote:
On 07/20/10 10:09, jes.soren...@redhat.com wrote:
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 291699f..1b840c4 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1139,6 +1139,11 @@ static int cdrom_open(BlockDriverState *bs, const
On 07/20/10 18:12, Kevin Wolf wrote:
Am 20.07.2010 18:04, schrieb Jes Sorensen:
On 07/20/10 17:40, Kevin Wolf wrote:
Thats effectively what my patch does. cdrom_open() calls
raw_open_common() which has this part:
/* Use O_DSYNC for write-through caching, no flags for write-back
caching
On 07/20/10 18:45, Natalia Portillo wrote:
El 20/07/2010, a las 16:17, jes.soren...@redhat.com escribió:
From: Jes Sorensen jes.soren...@redhat.com
O_DIRECT (cache=none) requires sector alignment, however the physical
sector size of CDROM/DVD drives is 2048, as opposed to most disk
devices
re-submit it. I apologize for this confusion!
Hope to see plenty of proposals showing up before the deadling on the 19th!
Best regards,
Jes
On 06/18/10 14:00, Jes Sorensen wrote:
Hi,
I would like to remind people about the Virtualization track at Linux
Plumbers Conference 2010, held
From: Jes Sorensen jes.soren...@redhat.com
The result of parsing qemu-options.def depends on whehter or not
MAP_POPULATE is defined, so make sure to include sys/mman.h before
including qemu-options.h.
Reported by Frank Arnold.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c
From: Jes Sorensen jes.soren...@redhat.com
Hi,
I think this one got lost in the noise last week. It's needed to
resolve the issue where the qemu-options enum gets skewed when
MAP_POPULATE isn't defined.
Please apply, having our cmdline option parsing go wrong isn't good.
Cheers,
Jes
Jes
Per rth's reply to qemu-devel, fix has been pushed into upstream as of
July 1st, commit 7418027ea4fec276455abd4291558bc58a0a7ba7
If problem reappears, please reopen or open a new bug.
Closing
** Changed in: qemu
Status: New = Fix Committed
--
xchg r8,rax treated as nop
Hi,
The problem is that it is more than just the compression that is the
problem, with modern cpus disk speed is a problem, and compression is
often stream based. For now there isn't enough valid data that this
qualifies as a bug/rfe.
If you decide to try and implement it, and provide data
On 07/01/10 19:53, Stefan Weil wrote:
Two patches are needed anyway.
For reasons of economy, I won't send a new patch.
Feel free do send one which meets your criteria.
Regards,
Stefan
Well if you are not interested in working the way the community works,
please don't expect us to fix
Could you try and run this in GDB and get the backtrace when it crashes?
Just do:
gdb /usr/bin/kvm
(gdb) set args -M pc-0.12 -enable-kvm -m 256 -smp 1 -name spamsender -uuid
b9cacd5e-08f7-41fd-78c8-89cec59af881 -chardev
On 07/01/10 09:04, Jan Kiszka wrote:
As I wrote in this bug I had problems with a kernel 2.6.28-11 and the
_latest_ version of kvm-kmod. It works only with the right (not the
latest) version of kvm-kmod.
Once you properly installed the kernel headers that kvm-kmod delivers,
qemu should
On 07/01/10 12:47, Stefan Weil wrote:
Mingw32 does not provide a declaration and implementation of function
setenv (which is used in sdl.c), so this patch adds both.
Signed-off-by: Stefan Weil w...@mail.berlios.de
[snip]
diff --git a/osdep.h b/osdep.h
index 75b5816..1cdc7e2 100644
---
On 07/01/10 15:22, Stefan Weil wrote:
It won't fail for two reasons:
* It is not redefined (at least for linux systems) because I used the
POSIX declaration.
This still fails with strict compiler flags.
* It is compiled only for _WIN32 (see line 95).
True, but we need to move stuff out of
On 07/01/10 17:51, Stefan Weil wrote:
Am 01.07.2010 15:24, schrieb Jes Sorensen:
On 07/01/10 15:22, Stefan Weil wrote:
It won't fail for two reasons:
* It is not redefined (at least for linux systems) because I used the
POSIX declaration.
This still fails with strict compiler flags
As pointed out repeatedly, this is _not_ a bug in QEMU
Stop reopening the bug!
** Changed in: qemu
Status: New = Invalid
--
QEMU 0.12.0 does not support KVM with Kernel 2.6.29, bug in ./configure and
kvm-all.c
https://bugs.launchpad.net/bugs/494500
You received this bug notification
On 06/25/10 19:34, Frank Arnold wrote:
We are doing KVM testing, so it is Linux.
What I did is putting lines like this somewhere into vl.c and
os-posix.c:
fprintf(stderr, os: QEMU_OPTION_daemonize: %i, QEMU_OPTION_daemonize);
fprintf(stderr, vl: QEMU_OPTION_daemonize: %i,
From: Jes Sorensen jes.soren...@redhat.com
The result of parsing qemu-options.def depends on whehter or not
MAP_POPULATE is defined, so make sure to include sys/mman.h before
including qemu-options.h.
Reported by Frank Arnold.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c
On 06/25/10 19:34, Frank Arnold wrote:
We are doing KVM testing, so it is Linux.
What I did is putting lines like this somewhere into vl.c and
os-posix.c:
fprintf(stderr, os: QEMU_OPTION_daemonize: %i, QEMU_OPTION_daemonize);
fprintf(stderr, vl: QEMU_OPTION_daemonize: %i,
On 06/28/10 18:20, Blue Swirl wrote:
On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen jes.soren...@redhat.com wrote:
Yeah, the problem with tying it to CONFIG_LINUX is that older version of
Linux may not support it. Looking through the list, MAP_POPULATE is
really an oddball in there though, so
On 06/25/10 18:41, Frank Arnold wrote:
On Thu, 2010-06-10 at 05:42 -0400, jes.soren...@redhat.com wrote:
diff --git a/os-posix.c b/os-posix.c
index 6417d16..1672e06 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -160,6 +162,9 @@ void os_parse_cmd_args(int index, const char *optarg)
case
I can reproduce this in qemu-kvm 0.12.50.
Most likely a problem with the e1000 driver in QEMU. Funny thing is the
guest seems to be able to obtain it's IP address via DHCP, then stops
communicating.
--
nic e1000 network interface does not work with 32-bit windows 2003r2 with sp2
On 06/23/10 16:44, Amit Shah wrote:
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-config.c |2 --
From: Jes Sorensen jes.soren...@redhat.com
Hi,
This set of patches fixes building qemu-kvm for non KVM targets, as
reported in
http://sourceforge.net/tracker/?func=detailatid=893831aid=2984626group_id=180599
One of the main problem is that we have a tendency to move things from
Makefile.objs
From: Jes Sorensen jes.soren...@redhat.com
time_drift_fix is only present on x86, not just on !ia64. This allows
the code to build for other archs, like MIPS.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/i8259.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
From: Jes Sorensen jes.soren...@redhat.com
This avoids breaking the build for non KVM targets where
kvm_set_irqfd() is not defined.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/virtio-pci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-pci.c
From: Jes Sorensen jes.soren...@redhat.com
pcspk.o i8254.o acpi.o acpi_piix4.o are all required for MIPS as well,
add them to Makefile.target accordingly.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile.target |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff
From: Jes Sorensen jes.soren...@redhat.com
We need to declare 'int no_hpet' for all targets to avoid build
failure on no x86 builds.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
vl.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 79f91d5
From: Jes Sorensen jes.soren...@redhat.com
Avoid build conflicts and move prototype out of CONFIG_KVM to make the
stub in kvm-stub.c visible.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-kvm.h | 29 -
1 files changed, 12 insertions(+), 17 deletions
From: Jes Sorensen jes.soren...@redhat.com
This fixes build breakage for target MIPS etc.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 0ee963c..79f91d5 100644
--- a/vl.c
+++ b/vl.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-kvm.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu-kvm.h b/qemu-kvm.h
index c9b93dc..6dd3a01 100644
--- a/qemu-kvm.h
+++ b/qemu-kvm.h
@@ -835,6 +835,7 @@ void
On 06/22/10 15:23, Alexander Graf wrote:
Alex Williamson wrote:
Could we send the agenda note out a little bit earlier?
The note arrived at 12:55am CST and we decided we had no agenda at
7:04am CST. That's a pretty short window and I imagine a lot of people
in the US are not
Hi,
I would like to remind people about the Virtualization track at Linux
Plumbers Conference 2010, held in Cambridge, MA, November 3-5, 2010.
Please note the deadline for submissions is July 19, 2010.
LPC is particular well suited for technical presentations, work in
progress and subjects that
On 06/17/10 04:42, Kevin O'Connor wrote:
On Mon, Jun 14, 2010 at 02:04:31PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Fix bvprintf to respect space padding when printing hex numbers
and the caller specifies alignment without zero padding, eg. %2x
601 - 700 of 894 matches
Mail list logo
