Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-30 Thread Luiz Capitulino
On Fri, 26 Jul 2013 20:14:06 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: Overall, I like where this is headed, but I'm not quite sure it is ready for commit as-is; looking forward to v2. Given my positive review on the rest of the series, I

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-07-30 Thread Luiz Capitulino
On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek ler...@redhat.com wrote: (Apologies for the long To: list, I'm including everyone who participated in https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02607.html). Conceptually, the dump-guest-memory command works as follows: (a)

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Luiz Capitulino
: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-31 Thread Luiz Capitulino
On Wed, 31 Jul 2013 14:23:08 +0200 Laszlo Ersek ler...@redhat.com wrote: Hi Qiao, On 07/31/13 11:26, Qiao Nuohan wrote: Hello Luiz and Amos, My patches are waiting for introspection. But now I cannot quite catch the situation of introspection, so I hope to get some information about

[Qemu-devel] [PULL 1/2] migration: send total time in QMP at completed stage

2013-08-01 Thread Luiz Capitulino
owass...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration.c b/migration.c index 9fc7294..3f682cd 100644 --- a/migration.c +++ b/migration.c @@ -231,6 +231,7 @@ MigrationInfo *qmp_query_migrate(Error **errp

[Qemu-devel] [PULL for-1.6 0/2] QMP queue

2013-08-01 Thread Luiz Capitulino
The following changes since commit 1197cbb9eda1dc82e2fa1815ca62bc3de158353e: qdev: Use clz in print_size (2013-07-31 07:54:21 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to

[Qemu-devel] [PULL 2/2] migration: don't use uninitialized variables

2013-08-01 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 3f682cd..1402fa7 100644 --- a/migration.c +++ b/migration.c @@ -400,8 +400,8 @@ void qmp_migrate(const char *uri, bool

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-08-01 Thread Luiz Capitulino
On Thu, 1 Aug 2013 09:41:07 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: Applied to the qmp branch, thanks. Hmm, it brakes the build. Dropping it from the queue for now: /home/lcapitulino/work/src/upstream/qmp-unstable/target-s390x/arch_dump.c:179:5: error: conflicting types

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Luiz Capitulino
What are your thoughts on this? Looks good: Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Thanks, Andreas --- hmp-commands.hx | 13 + hmp.c | 10 ++ hmp.h |1 + 3 files changed, 24 insertions(+) diff --git a/hmp

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-08-01 Thread Luiz Capitulino
On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek ler...@redhat.com wrote: (Apologies for the long To: list, I'm including everyone who participated in https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02607.html). Conceptually, the dump-guest-memory command works as follows: (a)

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Luiz Capitulino
On Thu, 01 Aug 2013 07:52:17 -0600 Eric Blake ebl...@redhat.com wrote: On 08/01/2013 12:31 AM, Fam Zheng wrote: Fix it by calling strtoll instead, which will report ERANGE as expected. (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 (HMP) block_set_io_throttle

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc1 is now available

2013-08-05 Thread Luiz Capitulino
On Mon, 05 Aug 2013 14:01:10 +0200 Laszlo Ersek ler...@redhat.com wrote: Please do consider it for 1.6, it addresses a serious bug (= vmcores saved with dump-guest-memory/paging=false are broken for 3.5G x86(_64) guests). No worries, it is going to be included (unless someone has a serious

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Luiz Capitulino
On Tue, 6 Aug 2013 12:37:07 +0200 Laszlo Ersek ler...@redhat.com wrote: v2-v3 [Paolo]: - The memory API guarantees an increasing traversal. Drop the hash tables and build the final list directly in the region_add callback, merging any adjacent region only with the last element on the

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Luiz Capitulino
On Thu, 8 Aug 2013 11:46:14 +0300 Orit Wasserman owass...@redhat.com wrote: ram is present also when migration completes. total-time and downtime are no longer part of ram data. expected-downtime has to be moved too, looks good otherwise. Signed-off-by: Orit Wasserman owass...@redhat.com

[Qemu-devel] [PULL 1/4] dump: clamp guest-provided mapping lengths to ramblock sizes

2013-08-08 Thread Luiz Capitulino
refuse even the valid portion of the PT_LOAD entry. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- dump.c | 65 - 1

[Qemu-devel] [PULL for-1.6 0/4] QMP queue

2013-08-08 Thread Luiz Capitulino
The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to

[Qemu-devel] [PULL 3/4] dump: populate guest_phys_blocks

2013-08-08 Thread Luiz Capitulino
that the dump will be based on. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- dump.c | 2 +- include/sysemu/memory_mapping.h | 1 + memory_mapping.c

[Qemu-devel] [PULL 4/4] dump: rebase from host-private RAMBlock offsets to guest-physical addresses

2013-08-08 Thread Luiz Capitulino
+ 512 MB Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- dump.c | 77

[Qemu-devel] [PULL 2/4] dump: introduce GuestPhysBlockList

2013-08-08 Thread Luiz Capitulino
://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- dump.c | 31 +++ include/sysemu/memory_mapping.h | 22 ++ memory_mapping.c

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Luiz Capitulino
On Thu, 08 Aug 2013 19:47:50 +0300 Orit Wasserman owass...@redhat.com wrote: On 08/08/2013 05:50 PM, Luiz Capitulino wrote: On Thu, 8 Aug 2013 11:46:14 +0300 Orit Wasserman owass...@redhat.com wrote: ram is present also when migration completes. total-time and downtime are no longer

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-04 Thread Luiz Capitulino
On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/1 22:02, Luiz Capitulino 写道: On Mon, 21 Oct 2013 10:16:01 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block.c

Re: [Qemu-devel] How to introduce bs-node_name ?

2013-11-04 Thread Luiz Capitulino
On Mon, 4 Nov 2013 12:13:59 +0100 Kevin Wolf kw...@redhat.com wrote: Am 01.11.2013 um 16:12 hat Luiz Capitulino geschrieben: On Fri, 01 Nov 2013 08:59:20 -0600 Eric Blake ebl...@redhat.com wrote: On 11/01/2013 08:51 AM, Luiz Capitulino wrote: On Wed, 30 Oct 2013 13:25:35 -0600

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-04 Thread Luiz Capitulino
On Tue, 05 Nov 2013 10:17:28 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/4 21:33, Luiz Capitulino 写道: On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/1 22:02, Luiz Capitulino 写道: On Mon, 21 Oct 2013 10:16:01 +0800 Wenchao

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-05 Thread Luiz Capitulino
On Tue, 05 Nov 2013 13:31:09 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/5 10:51, Luiz Capitulino 写道: On Tue, 05 Nov 2013 10:17:28 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/4 21:33, Luiz Capitulino 写道: On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao

[Qemu-devel] [PATCH] MAINTAINERS: add git tree info for HMP, QMP and QAPI

2013-11-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..02b85ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -699,6 +699,7 @@ S: Supported F: monitor.c F: hmp.c F: hmp-commands.hx

[Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected)

2013-11-06 Thread Luiz Capitulino
1. Run qemu with gdb server support # qemu [...] -s -S 2. Connect gdb and try to set a breakpoint $ gdb /path/to/vmlinux (gdb) target remote:1234 (gdb) b secondary_startup_64 3. On qemu terminal qemu-qmp: /home/lcapitulino/work/src/upstream/qmp-unstable/include/qemu/int128.h:22:

Re: [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected)

2013-11-06 Thread Luiz Capitulino
On Wed, 06 Nov 2013 17:26:32 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 06/11/2013 17:22, Luiz Capitulino ha scritto: 1. Run qemu with gdb server support # qemu [...] -s -S 2. Connect gdb and try to set a breakpoint $ gdb /path/to/vmlinux (gdb) target remote

Re: [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected)

2013-11-06 Thread Luiz Capitulino
On Wed, 06 Nov 2013 18:39:42 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 06/11/2013 17:22, Luiz Capitulino ha scritto: 1. Run qemu with gdb server support # qemu [...] -s -S 2. Connect gdb and try to set a breakpoint $ gdb /path/to/vmlinux (gdb) target remote

[Qemu-devel] [PULL for-1.7 0/2] QMP queue

2013-11-12 Thread Luiz Capitulino
to dce07e0b2b172ccce43955fdee2149ab2413251b: MAINTAINERS: add git tree info for HMP, QMP and QAPI (2013-11-11 10:02:21 -0500) Luiz Capitulino (1): MAINTAINERS: add git tree info for HMP, QMP and QAPI Richard Henderson (1): Adjust qapi-visit

[Qemu-devel] [PULL 2/2] MAINTAINERS: add git tree info for HMP, QMP and QAPI

2013-11-12 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..02b85ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -699,6 +699,7 @@ S: Supported F: monitor.c F: hmp.c F: hmp-commands.hx +T

[Qemu-devel] [PULL 1/2] Adjust qapi-visit for python-2.4.3

2013-11-12 Thread Luiz Capitulino
mdr...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-visit.py | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index c39e628..65f1a54 100644 --- a/scripts/qapi-visit.py

Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n

2013-11-14 Thread Luiz Capitulino
On Thu, 14 Nov 2013 15:34:06 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: SMTP does not preserve newlines. This is normally not a problem if the email body uses DOS or UNIX newlines consistently. In 051.out we mix UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n).

Re: [Qemu-devel] [PATCH RFC 0/3] add direct support of event in qapi schema

2013-11-22 Thread Luiz Capitulino
On Fri, 22 Nov 2013 10:03:44 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/13 9:44, Wenchao Xia 写道: This series add support for tag/keyword 'event' in qapi-schema. The implemention doesn't generate a struture and visit function in the background for every event, so it

Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name

2013-11-25 Thread Luiz Capitulino
On Wed, 13 Nov 2013 06:25:00 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This series is respined from RFC series at: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00363.html Patch 1-6 add support for enum as discriminator. Patch 7 improve enum name generation, now

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2013-11-27 Thread Luiz Capitulino
On Wed, 13 Nov 2013 09:44:52 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Nested structure is not supported now, so following define is not valid: { 'event': 'EVENT_C', 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' } I think your general approach is reasonable, but there

Re: [Qemu-devel] [PATCH 0/5] qemu-io: readline command completion

2013-11-27 Thread Luiz Capitulino
reviewed the HMP parts in detail, and took a glance at the qemu-io parts: Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Stefan Hajnoczi (5): readline: decouple readline from the monitor readline: move readline to a generic location osdep: add qemu_set_tty_echo() qemu-io: use

Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name

2013-11-28 Thread Luiz Capitulino
On Thu, 28 Nov 2013 14:19:48 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/26 0:47, Luiz Capitulino 写道: On Wed, 13 Nov 2013 06:25:00 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This series is respined from RFC series at: http://lists.nongnu.org/archive/html/qemu

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2013-11-28 Thread Luiz Capitulino
On Thu, 28 Nov 2013 15:16:08 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/11/28 8:48, Luiz Capitulino 写道: On Wed, 13 Nov 2013 09:44:52 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Nested structure is not supported now, so following define is not valid: { 'event

Re: [Qemu-devel] [PATCH v4 08/10] qemu-ga: call Windows VSS requester in fsfreeze command handler

2013-07-02 Thread Luiz Capitulino
On Tue, 02 Jul 2013 08:36:11 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/01/13 19:59, Tomoki Sekiyama wrote: On 7/1/13 9:29 , Laszlo Ersek ler...@redhat.com wrote: +error: +qmp_guest_fsfreeze_thaw(NULL); Passing NULL here as errp concerns me slightly. I've been assuming

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-02 Thread Luiz Capitulino
On Tue, 2 Jul 2013 16:37:29 +0800 Amos Kong ak...@redhat.com wrote: Btw, I find your approach interesting but I'm wondering if it's going to be a good thing to keep all the schema in memory. Do you have an idea on its size? The size of qmp_schema_table[] is 1528 bytes. method 2rd:

Re: [Qemu-devel] [PATCH v4 08/10] qemu-ga: call Windows VSS requester in fsfreeze command handler

2013-07-02 Thread Luiz Capitulino
On Tue, 02 Jul 2013 16:44:55 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/02/13 16:09, Luiz Capitulino wrote: On Tue, 02 Jul 2013 08:36:11 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/01/13 19:59, Tomoki Sekiyama wrote: On 7/1/13 9:29 , Laszlo Ersek ler...@redhat.com wrote

Re: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size

2013-07-03 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:22:07 +0200 Markus Armbruster arm...@redhat.com wrote: Any attempt to use it trips an opt-desc-type == QEMU_OPT_NUMBER assertion. Broken in commit 1da48c65. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com Applied to the qmp branch,

Re: [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes

2013-07-03 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:22:06 +0200 Markus Armbruster arm...@redhat.com wrote: The first patch is a straightforward bug fix. The rest fix code to match documentation. The patches take pains to preserve command-line, HMP and QMP bug-compatibility. I'm not sure that's actually needed,

Re: [Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name ringbuf

2013-07-03 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:22:09 +0200 Markus Armbruster arm...@redhat.com wrote: The driver is new in 1.4, with the documented name ringbuf. However, it's actual name is the completely undocumented memory. Screwed up in commit 3949e59. Fix code to match documentation. Keep the undocumented

Re: [Qemu-devel] [PATCH V5 0/7] monitor: support sub command group in auto completion and help

2013-07-08 Thread Luiz Capitulino
On Mon, 08 Jul 2013 06:39:52 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Any comments for it? I should review it shortly.

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:55 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Parameter *mon is added to replace *cur_mon, and readline_completion() pass rs-mon as value, which should be initialized in readline_init() called by monitor_init(). In short, structure ReadLineState controls

Re: [Qemu-devel] [PATCH V5 3/7] monitor: code move for parse_cmdline()

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:57 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: get_str() is called by parse_cmdline() so it is moved also. Some code style error reported by check script, is also fixed. Please, explain why you're doing this move. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH V5 4/7] monitor: avoid direct use of global *info_cmds in help functions

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:58 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: In help functions info_cmds is treated as sub command group now, not as a special case any more. Still help can't show message for single command under info, since command parser reject additional parameter, which

Re: [Qemu-devel] [PATCH V5 2/7] monitor: avoid direct use of global variable *mon_cmds

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:56 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: New member *cmd_table is added in structure Monitor to avoid direct usage of *mon_cmds. Now monitor have an associated command table, when global variable *info_cmds is also discarded, structure Monitor would gain

Re: [Qemu-devel] [PATCH V5 6/7] monitor: improve help in auto completion for sub command

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:53:00 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Now special case help * in auto completion can work with sub commands, such as help info a*. The auto-completion works, but the command is still refused: (qemu) help info u usb usbhost usernet uuid

Re: [Qemu-devel] [PATCH V5 7/7] monitor: improve help to allow show details of single command in sub group

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:53:01 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: A new parameter type 'S' is introduced to allow user input any string. help info block do not tip extra parameter error now. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- hmp-commands.hx |2 +-

Re: [Qemu-devel] [PATCH v3 0/3] qapi: Top-level type reference for command definitions

2013-07-08 Thread Luiz Capitulino
On Mon, 1 Jul 2013 16:31:49 +0200 Kevin Wolf kw...@redhat.com wrote: v2: - Updated documentation in patch 3 v3: - Refactored differently (introduced get_expr()) as suggested by Michael Kevin Wolf (3): qapi.py: Avoid code duplication qapi.py: Allow top-level type reference for

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-08 Thread Luiz Capitulino
On Wed, 03 Jul 2013 23:02:46 -0400 Seiji Aguchi seiji.agu...@hds.com wrote: [Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:15 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: The QMP command let it be able to set node's memory policy through the QMP protocol. The qmp-shell command is like: set-mpol nodeid=0 mem-policy=membind mem-hostnode=0-1 Signed-off-by: Wanlong Gao

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Mon, 8 Jul 2013 14:25:14 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 4 Jul 2013 17:53:15 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: The QMP command let it be able to set node's memory policy through the QMP protocol. The qmp-shell command is like: set-mpol

Re: [Qemu-devel] [PATCH V4 10/10] NUMA: show host memory policy info in info numa command

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:17 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: Show host memory policy of nodes in the info numa monitor command. After this patch, the monitor command info numa will show the information like following if the host numa support is enabled: As you're adding a

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-08 Thread Luiz Capitulino
On Mon, 8 Jul 2013 18:47:24 + Seiji Aguchi seiji.agu...@hds.com wrote: +DEF(msg, HAS_ARG, QEMU_OPTION_msg, +-msg timestamp[=on|off]\n +change the format of messages\n +on|off controls leading timestamps (default:on)\n, Did you

Re: [Qemu-devel] [PATCH V4 09/10] NUMA: add hmp command set-mpol

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:16 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: Add hmp command set-mpol to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mpol 0 mem-policy=membind,mem-hostnode=0-1

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Mon, 08 Jul 2013 20:50:46 +0200 Andreas Färber afaer...@suse.de wrote: Am 08.07.2013 20:34, schrieb Luiz Capitulino: I forgot to bike-shed on the naming. I'd suggest the following: - s/set-mpol/set-numa-policy - s/mem-policy/policy - s/mem-hostnode/host-nodes I had suggested

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Luiz Capitulino
On Tue, 9 Jul 2013 10:05:35 +0200 Kevin Wolf kw...@redhat.com wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com Applied to the qmp branch, thanks. --- To be applied on top of '[PATCH v3 0/3] qapi:

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-09 Thread Luiz Capitulino
On Tue, 09 Jul 2013 22:03:42 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: You could pass cur_mon to readline_completion() in readline_handle_byte() to avoid all this, but it would be preferable to clarify the matter. This is also another benefit of having readline_completion() in

[Qemu-devel] [PULL 2/6] qapi.py: Avoid code duplication

2013-07-10 Thread Luiz Capitulino
...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 02ad668..3139994 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py

[Qemu-devel] [PULL 0/6] QMP queue

2013-07-10 Thread Luiz Capitulino
The following changes since commit 51455c59ddc370612f6e070d8eb0e594aaa7ef24: Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging (2013-07-10 10:54:16 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch

[Qemu-devel] [PULL 1/6] qemu-char: Fix ringbuf option size

2013-07-10 Thread Luiz Capitulino
From: Markus Armbruster arm...@redhat.com Any attempt to use it trips an opt-desc-type == QEMU_OPT_NUMBER assertion. Broken in commit 1da48c65. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Luiz Capitulino

[Qemu-devel] [PULL 5/6] qapi-schema: Use existing type for drive-backup arguments

2013-07-10 Thread Luiz Capitulino
From: Kevin Wolf kw...@redhat.com This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qapi-schema.json | 32

[Qemu-devel] [PULL 6/6] add timestamp to error_report()

2013-07-10 Thread Luiz Capitulino
seiji.agu...@hds.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- include/qemu/error-report.h | 2 ++ qemu-options.hx | 11 +++ util/qemu-error.c | 10 ++ vl.c| 26

[Qemu-devel] [PULL 4/6] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

2013-07-10 Thread Luiz Capitulino
From: Kevin Wolf kw...@redhat.com We don't have to duplicate the definition any more now that we may refer to a type instead. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qapi-schema.json

[Qemu-devel] [PULL 3/6] qapi.py: Allow top-level type reference for command definitions

2013-07-10 Thread Luiz Capitulino
the transaction action and the arguments of the standalone command. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi.py | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-11 Thread Luiz Capitulino
= qapi_dealloc_get_visitor(md); visit_type_str(v, device, device, NULL); visit_type_str(v, password, password, NULL); qapi_dealloc_visitor_cleanup(md); Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-commands.py | 17 ++--- 1 file changed, 10 insertions(+), 7

Re: [Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-11 Thread Luiz Capitulino
On Thu, 11 Jul 2013 13:14:21 -0600 Eric Blake ebl...@redhat.com wrote: On 07/11/2013 12:50 PM, Luiz Capitulino wrote: I'm sending this as an RFC because this is untested, and also because I'm wondering if I'm seeing things after a long patch review session. I can't say that I tested

Re: [Qemu-devel] [PULL 6/6] add timestamp to error_report()

2013-07-12 Thread Luiz Capitulino
On Fri, 12 Jul 2013 08:58:03 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 10/07/2013 19:52, Luiz Capitulino ha scritto: From: Seiji Aguchi seiji.agu...@hds.com [Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand

[Qemu-devel] [PATCH] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-12 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- o rfc - Fixed missing spaces after ',' - Reworded commitlog a bit scripts/qapi-commands.py | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/scripts/qapi-commands.py

Re: [Qemu-devel] ARRAYS :QMP Declaration

2013-07-16 Thread Luiz Capitulino
On Tue, 16 Jul 2013 09:27:27 +0800 Saptarshi Sen saptarshi@gmail.com wrote: Hi, Is it possible to use fixed array data structures for use through the qmp-interface. My aim is to monitor IDE level activity in terms of sectors being accessed. So I plan to have a fixed size

Re: [Qemu-devel] [PATCH V6 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-17 Thread Luiz Capitulino
On Thu, 11 Jul 2013 11:13:41 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Now all completion functions do not use *cur_mon any more, instead they use rs-mon. In short, structure ReadLineState decide where the complete action would be taken now. Tested with the case that qemu have two

Re: [Qemu-devel] [PATCH V6 08/13] monitor: refine parse_cmdline()

2013-07-17 Thread Luiz Capitulino
On Thu, 11 Jul 2013 11:13:44 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Since this function will be used by help_cmd() later, so improve it to make it more generic and easier to use. free_cmdline_args() is added to as paired function to free the result. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH] qmp: update send-key document

2013-07-17 Thread Luiz Capitulino
On Tue, 16 Jul 2013 19:52:14 +0800 Amos Kong ak...@redhat.com wrote: commit 9f328977 changes qmp_send_key() to accept key codes in hex, but the document wasn't updated. The items of keys list is union now, not enum. Signed-off-by: Amos Kong ak...@redhat.com Applied to the qmp branch,

Re: [Qemu-devel] [PATCH v2 1/2] qapi: change qapi to convert schema json

2013-07-17 Thread Luiz Capitulino
On Tue, 16 Jul 2013 18:37:41 +0800 Amos Kong ak...@redhat.com wrote: QMP schema is defined in a json file, it will be parsed by qapi scripts and generate C files. We want to return the schema information to management, this patch converts the json file to a string table in a C head file,

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-17 Thread Luiz Capitulino
On Tue, 16 Jul 2013 18:37:42 +0800 Amos Kong ak...@redhat.com wrote: Introduces new monitor command to query QMP schema information, the return data is a dynamical and nested dict/list, it contains the useful metadata to help management to check feature support, QMP commands detail, etc. I

[Qemu-devel] [PULL 0/2] QMP queue

2013-07-17 Thread Luiz Capitulino
up to f9b1d9b20f5d25b95f67a498e312f625d168fc51: qmp: update send-key document (2013-07-17 16:00:26 -0400) Amos Kong (1): qmp: update send-key document Luiz Capitulino (1): qapi: qapi-commands: fix possible leaks

[Qemu-devel] [PULL 2/2] qmp: update send-key document

2013-07-17 Thread Luiz Capitulino
From: Amos Kong ak...@redhat.com commit 9f328977 changes qmp_send_key() to accept key codes in hex, but the document wasn't updated. The items of keys list is union now, not enum. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Luiz Capitulino

[Qemu-devel] [PULL 1/2] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-17 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/qapi-commands.py | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi

Re: [Qemu-devel] [PATCH V6 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-18 Thread Luiz Capitulino
On Thu, 18 Jul 2013 09:55:51 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-7-18 3:34, Luiz Capitulino 写道: On Thu, 11 Jul 2013 11:13:41 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Now all completion functions do not use *cur_mon any more, instead they use rs-mon

[Qemu-devel] Commit 23326164ae (exec: Support 64-bit op...) triggers assertion

2013-07-19 Thread Luiz Capitulino
Hi, Reproducer: # ./qemu-qmp -drive file=disks/test.img,if=virtio,cache=none,aio=native \ -enable-kvm -m 1G -monitor stdio -usb -usbdevice host:1.43 QEMU 1.5.50 monitor - type 'help' for more information (qemu) qemu-qmp: /home/lcapitulino/work/src/upstream/qmp-unstable/exec.c:1927:

Re: [Qemu-devel] Commit 23326164ae (exec: Support 64-bit op...) triggers assertion

2013-07-19 Thread Luiz Capitulino
On Fri, 19 Jul 2013 13:28:52 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: Hi, Reproducer: # ./qemu-qmp -drive file=disks/test.img,if=virtio,cache=none,aio=native \ -enable-kvm -m 1G -monitor stdio -usb -usbdevice host:1.43 QEMU 1.5.50 monitor - type 'help' for more information

Re: [Qemu-devel] Commit 23326164ae (exec: Support 64-bit op...) triggers assertion

2013-07-19 Thread Luiz Capitulino
On Fri, 19 Jul 2013 12:06:42 -0700 Richard Henderson r...@twiddle.net wrote: On 07/19/2013 10:28 AM, Luiz Capitulino wrote: Hi, Reproducer: # ./qemu-qmp -drive file=disks/test.img,if=virtio,cache=none,aio=native \ -enable-kvm -m 1G -monitor stdio -usb -usbdevice host:1.43 QEMU

Re: [Qemu-devel] [PATCH 4/4] exec: fix incorrect assumptions in memory_access_size

2013-07-19 Thread Luiz Capitulino
break accesses bigger than mr-ops-impl.max_access_size. Reported-by: Markus Armbruster arm...@redhat.com Tested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Yeah, works for me now: Tested-by: Luiz Capitulino lcapitul...@redhat.com --- exec.c | 9

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-13 Thread Luiz Capitulino
On Tue, 11 Jun 2013 09:48:40 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: introspection. I just want these patches reviewed first, then I may get these patches ready for merging soon after introspection support. I've started reviewing this, but I'm out of cycles for this week. Can

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 13:46:41 +0800 Amos Kong ak...@redhat.com wrote: On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 15:45:52 +0800 Amos Kong ak...@redhat.com wrote: Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance. Design: QEMU notifies Libvirt when rx-filter config is

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: On 5.6.2013 15:23, Stefan Hajnoczi wrote: On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: @@ -1071,14 +1072,18 @@ static void

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 16:21:31 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote: On Fri, 14 Jun 2013 15:45:52 +0800 Amos Kong ak...@redhat.com wrote: Currently macvtap based macvlan device is working in promiscuous mode

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:25:24 +0200 Pavel Hrdina phrd...@redhat.com wrote: On 17.6.2013 15:22, Luiz Capitulino wrote: On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: On 5.6.2013 15:23, Stefan

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 19:55:21 -0400 Alon Levy al...@redhat.com wrote: On Fri, 2013-06-14 at 13:21 -0500, Anthony Liguori wrote: Alon Levy al...@redhat.com writes: This fixes the broken screendump behavior for qxl devices in native mode since 81fb6f1504fb9ef71f2382f44af34756668296e8.

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:38:23 +0200 Pavel Hrdina phrd...@redhat.com wrote: On 17.6.2013 15:32, Luiz Capitulino wrote: On Mon, 17 Jun 2013 15:25:24 +0200 Pavel Hrdina phrd...@redhat.com wrote: On 17.6.2013 15:22, Luiz Capitulino wrote: On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:46:52 +0200 Kevin Wolf kw...@redhat.com wrote: Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: It's just a warning, that you used a password for a block device that doesn't require it. The device is opened successfully and should be handled correctly (call the

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 08:06:58 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hmm, while thinking about it: There is another screendump change in the pipeline: allow screen dumps from *any* device. So, I think this is actually a very good reason to implement a new screendump command as I think

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 17:20:13 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jun 17, 2013 at 09:30:42AM -0400, Luiz Capitulino wrote: On Mon, 17 Jun 2013 16:21:31 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 17:42:50 +0300 Michael S. Tsirkin m...@redhat.com wrote: The 1000ms I talked about is *not* what the guest will see. If there are events pending, the throttle API just queues the event and returns right away. I'd even _guess_ that this is faster then emitting the event.

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 09:43:07 -0500 Anthony Liguori aligu...@us.ibm.com wrote: Gerd Hoffmann kra...@redhat.com writes: Adds a screendump-device qmp command, which has an additional 'device' parameter. This way it is possible to specify the device you want a screendump from. For the

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 18:10:23 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jun 17, 2013 at 10:54:39AM -0400, Luiz Capitulino wrote: On Mon, 17 Jun 2013 17:42:50 +0300 Michael S. Tsirkin m...@redhat.com wrote: The 1000ms I talked about is *not* what the guest will see

<    1   2   3   4   5   6   7   8   9   10   >