[Qemu-devel] [PULL v2 20/37] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header.

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com In preparation for VHDX log support, move these structures to the header. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 52 block/vhdx.h | 48

[Qemu-devel] [PULL v2 29/37] block: vhdx - remove BAT file offset bit shifting

2013-11-08 Thread Stefan Hajnoczi
to the left by 20 bits, to convert to a true uint64_t file offset. This replaces those steps with just a bit mask, to get rid of the lower 20 bits instead. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 6 ++ block/vhdx.h | 1 - 2

[Qemu-devel] [PULL v2 21/37] block: vhdx - log support struct and defines

2013-11-08 Thread Stefan Hajnoczi
. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.h | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/block/vhdx.h b/block/vhdx.h index 2f7461d..154c55a 100644 --- a/block/vhdx.h

[Qemu-devel] [PULL v2 03/37] block/raw-posix: fix FreeBSD compilation

2013-11-08 Thread Stefan Hajnoczi
From: Andreas Tobler andre...@freebsd.org The below patch is needed to compile qemu trunk on FreeBSD with gcc48, clang will fail ;). Host x84_64-freebsd. Signed-off-by: Andreas Tobler andre...@freebsd.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/raw-posix.c | 3 ++- 1

[Qemu-devel] [PULL v2 08/37] block: qemu-iotests, removes duplicate double quotes in 039

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate. Signed-off-by: Jeff Cody jc...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1

[Qemu-devel] [PULL v2 27/37] block: vhdx - add log write support

2013-11-08 Thread Stefan Hajnoczi
is 0, a new GUID is generated and updated in the header. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx-log.c | 282 +++ block/vhdx.h | 3 + 2 files changed, 285 insertions(+) diff

[Qemu-devel] [PULL v2 37/37] block: Round up total_sectors

2013-11-08 Thread Stefan Hajnoczi
aligned. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 0e96a22..6d5c804 100644 --- a/block.c +++ b

[Qemu-devel] [PULL v2 31/37] block: vhdx - break out code operations to functions

2013-11-08 Thread Stefan Hajnoczi
-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 121 +++ 1 file changed, 80 insertions(+), 41 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index 7da149a..7bf7cd6 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -248,6 +248,14

[Qemu-devel] [PULL v2 07/37] block: qemu-iotests, add quotes to $TEST_IMG usage in 019

2013-11-08 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/019 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019 index cd3582c..5bb18d0 100755 --- a/tests/qemu-iotests/019 +++ b/tests/qemu-iotests/019 @@ -90,12

[Qemu-devel] [PULL v2 15/37] qdev-monitor-test: add device_add leak test cases

2013-11-08 Thread Stefan Hajnoczi
Ensure that the device_add error code path deletes device objects. Failure to do so not only leaks the objects but can also keep other objects (like drive or netdev) alive due to qdev properties holding references. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl

[Qemu-devel] [PULL v2 36/37] block: vhdx qemu-iotest - log replay of data sector

2013-11-08 Thread Stefan Hajnoczi
QEMU and Hyper-V that the image file, post log replay, matched. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/070 | 67 + tests/qemu-iotests/070.out | 8

[Qemu-devel] [PULL v2 33/37] block: vhdx - add .bdrv_create() support

2013-11-08 Thread Stefan Hajnoczi
...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 558 +++ block/vhdx.h | 15 +- 2 files changed, 572 insertions(+), 1 deletion(-) diff --git a/block/vhdx.c b/block/vhdx.c index 7bf7cd6..7d1af96 100644

[Qemu-devel] [PULL v2 22/37] block: vhdx - break endian translation functions out

2013-11-08 Thread Stefan Hajnoczi
...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/Makefile.objs | 2 +- block/vhdx-endian.c | 141 block/vhdx.c| 43 block/vhdx.h| 8 +++ 4 files changed, 150 insertions(+), 44 deletions

[Qemu-devel] [PULL v2 34/37] block: vhdx - update _make_test_img() to filter out vhdx options

2013-11-08 Thread Stefan Hajnoczi
-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/common.rc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index d24de2c..7f62457 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests

[Qemu-devel] [PULL v2 26/37] block: vhdx - add region overlap detection for image files

2013-11-08 Thread Stefan Hajnoczi
...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 82 block/vhdx.h | 9 +++ 2 files changed, 91 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index 8fbfbd6..574ac4c 100644 --- a/block/vhdx.c +++ b

[Qemu-devel] [PULL v2 10/37] block: qemu-iotests, add quotes to $TEST_IMG usage in 061

2013-11-08 Thread Stefan Hajnoczi
quoted. Signed-off-by: Jeff Cody jc...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/061 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/061 b/tests/qemu-iotests/061 index

[Qemu-devel] [PULL v2 23/37] block: vhdx - update log guid in header, and first write tracker

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com Allow tracking of first file write in the VHDX image, as well as the ability to update the GUID in the header. This is in preparation for log support. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c

[Qemu-devel] [PULL v2 28/37] block: vhdx write support

2013-11-08 Thread Stefan Hajnoczi
...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 212 +-- block/vhdx.h | 2 +- 2 files changed, 209 insertions(+), 5 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index 574ac4c..050f071 100644 --- a/block

[Qemu-devel] [PULL v2 35/37] block: qemu-iotests for vhdx, add write test support

2013-11-08 Thread Stefan Hajnoczi
it as well. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/064 | 11 +++ tests/qemu-iotests/064.out | 14 ++ tests/qemu-iotests/common | 1 - 3 files changed, 25 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL v2 24/37] block: vhdx code movement - move vhdx_close() above vhdx_open()

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index 241703a..3f06ce3 100644

[Qemu-devel] [PULL v2 32/37] block: vhdx - fix comment typos in header, fix incorrect struct fields

2013-11-08 Thread Stefan Hajnoczi
a couple of typos and incorrect wording in comments, and those have been fixed up as well. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/vhdx.h b/block

[Qemu-devel] [PULL v2 02/37] qemu-iotests: Filter out actual image size in 067

2013-11-08 Thread Stefan Hajnoczi
-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/067 | 2 +- tests/qemu-iotests/067.out | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/067 b/tests/qemu-iotests/067 index 79dc38b..d025192 100755 --- a/tests/qemu-iotests/067

[Qemu-devel] [PULL v2 17/37] block/vpc: fix virtual size for images created with disk2vhd

2013-11-08 Thread Stefan Hajnoczi
From: Peter Lieven p...@kamp.de Signed-off-by: Peter Lieven p...@kamp.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vpc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 627d11c..577cc45 100644 --- a/block/vpc.c +++ b/block/vpc.c

[Qemu-devel] [PULL v2 19/37] block: vhdx - add header update capability.

2013-11-08 Thread Stefan Hajnoczi
is to have VHDX enabled. To enable/disable VHDX: --enable-vhdx, --disable-vhdx Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/Makefile.objs | 2 +- block/vhdx.c| 161 +++- block/vhdx.h

[Qemu-devel] [PULL v2 11/37] blockdev: fix drive_init() opts and bs_opts leaks

2013-11-08 Thread Stefan Hajnoczi
These memory leaks also make drive_add if=none,id=drive0 without a file= option leak the options list. This keeps ID drive0 around forever. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- blockdev.c | 27 +++ 1 file

[Qemu-devel] [PULL v2 14/37] blockdev-test: add test case for drive_add duplicate IDs

2013-11-08 Thread Stefan Hajnoczi
The following should work: (qemu) drive_add if=none,id=drive0 (qemu) drive_del drive0 (qemu) drive_add if=none,id=drive0 Previous versions of QEMU produced a duplicate ID error because drive_add leaked the options. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [PULL v2 12/37] libqtest: rename qmp() to qmp_discard_response()

2013-11-08 Thread Stefan Hajnoczi
it. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 4 ++-- tests/fdc-test.c| 15 +-- tests/ide-test.c| 10 ++ tests/libqtest.c| 10

Re: [Qemu-devel] [PATCH v2] e1000: initial link negotiation on mac osx

2013-11-08 Thread Stefan Hajnoczi
On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote: Am 07.11.2013 um 21:28 schrieb Gabriel L. Somlo gso...@gmail.com: Some guest operating systems' drivers (particularly Mac OS X) expect the link state to be pre-initialized by an earlier component such as a proprietary BIOS.

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add netmap maintainers

2013-11-08 Thread Stefan Hajnoczi
On Wed, Nov 06, 2013 at 06:34:55PM +0100, Vincenzo Maffione wrote: Signed-off-by: Vincenzo Maffione v.maffi...@gmail.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) Thanks, applied to my net-next tree: https://github.com/stefanha/qemu/commits/net-next Stefan

Re: [Qemu-devel] [PATCH] util/error: Save errno from clobbering

2013-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2013 at 08:10:29PM +0100, Max Reitz wrote: There may be calls to error_setg() and especially error_setg_errno() which blindly (and until now wrongly) assume these functions not to clobber errno (e.g., they pass errno to error_setg_errno() and return -errno afterwards). Instead

Re: [Qemu-devel] [PATCH] 82571 emulation

2013-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2013 at 11:06:06AM -0800, akepner wrote: First cut at emulating 82571. I'm sure there are lots of rough edges, but it's working for me. Pretty obviously I started with a copy of the e1000 code, and modified just what was necessary to get it working. I'd like to also do a

[Qemu-devel] [PULL 2/3] net: fix qemu_flush_queued_packets() in presence of a hub

2013-11-08 Thread Stefan Hajnoczi
From: Sergey Fedorov s.fedo...@samsung.com Do not return after net_hub_flush(). Always flush callee network client incoming queue. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- net/net.c | 1 - 1 file changed, 1 deletion(-) diff

[Qemu-devel] [PULL 3/3] virtio-net: broken RX filtering logic fixed

2013-11-08 Thread Stefan Hajnoczi
From: Dmitry Fleytman dfley...@redhat.com Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command multicast list overwrites unicast list in mac_table. This leads to broken logic for both unicast and multicast RX filtering. Signed-off-by: Dmitry Fleytman dfley...@redhat.com Signed-off-by: Stefan

[Qemu-devel] [PULL for-1.7 0/3] Net patches

2013-11-08 Thread Stefan Hajnoczi
Bug fixes for QEMU 1.7. The following changes since commit 964668b03d26f0b5baa5e5aff0c966f4fcb76e9e: Update version for 1.7.0-rc0 release (2013-11-06 21:49:39 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to

[Qemu-devel] [PULL 1/3] net: disallow to specify multicast MAC address

2013-11-08 Thread Stefan Hajnoczi
] Signed-off-by: Dmitry V. Krivenok krivenok.dmi...@gmail.com Reviewed-by: Amos Kong kongjian...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/net/eth.h | 6 +++--- net/net.c | 6 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/net

Re: [Qemu-devel] Buildbot failures (XEN)

2013-11-11 Thread Stefan Hajnoczi
On Sun, Nov 10, 2013 at 05:07:03PM +0100, Stefan Weil wrote: could you please have a look at these buildbots (maybe others, too): xen_i386_debian_6_0 xen_x86_64_debian_6_0 Both fail during the configuration: ERROR: unknown option --disable-debug-info fetching branch xen-next from

Re: [Qemu-devel] [PATCH v2] e1000: initial link negotiation on mac osx

2013-11-11 Thread Stefan Hajnoczi
On Fri, Nov 08, 2013 at 10:52:09AM -0500, Gabriel L. Somlo wrote: On Fri, Nov 08, 2013 at 02:39:25PM +0100, Stefan Hajnoczi wrote: On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote: We can easily modify SeaBIOS to just loop through all PCI devices, look for an e1000

Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed

2013-11-11 Thread Stefan Hajnoczi
| 1 - block/raw-win32.c | 1 - tests/qemu-iotests/051.out | 2 +- tests/qemu-iotests/069.out | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 04, 2013 at 11:55:47AM +0100, Paolo Bonzini wrote: Il 04/11/2013 11:47, Fam Zheng ha scritto: -void bdrv_set_dirty_tracking(BlockDriverState *bs, int granularity); -int bdrv_get_dirty(BlockDriverState *bs, int64_t sector); +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 04, 2013 at 05:30:10PM +0800, Fam Zheng wrote: @@ -2785,9 +2792,7 @@ static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs, ret = bdrv_co_flush(bs); } -if (bs-dirty_bitmap) { bdrv_set_dirty(bs, sector_num, nb_sectors); -} Forgot to

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-11 Thread Stefan Hajnoczi
/block.h | 11 --- include/block/block_int.h | 2 +- 6 files changed, 85 insertions(+), 62 deletions(-) Happy with this modulo the indentation fixup I commented on. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 11:00:45AM +0100, Matthias Brugger wrote: 2013/11/5 Stefan Hajnoczi stefa...@gmail.com: I'd also like to see the thread pool implementation you wish to add before we add a layer of indirection which has no users yet. Fair enough, I will evaluate if it will make more

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block tree repo URLs

2013-11-13 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 05:10:23PM +0100, Kevin Wolf wrote: Am 06.11.2013 um 16:06 hat Stefan Hajnoczi geschrieben: Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf

[Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

2013-11-13 Thread Stefan Hajnoczi
-by: Anthony Liguori aligu...@amazon.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- MAINTAINERS | 40 1 file changed, 40 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..c02988e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [Qemu-devel] [Bug 1250360] [NEW] qcow2 image logical corruption after host crash

2013-11-13 Thread Stefan Hajnoczi
On Tue, Nov 12, 2013 at 09:17:34AM -, Blue wrote: Please post the qemu command-line (ps aux | grep qemu) for the affected VM. What kind of workload is accessing the disk? Guest OS and version? Please also confirm that nothing else is accessing the image file while the VM is running. It is

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

2013-11-14 Thread Stefan Hajnoczi
On Wed, Nov 13, 2013 at 11:17:12AM -0500, Jeff Cody wrote: On Wed, Nov 13, 2013 at 10:33:10AM +0100, Stefan Hajnoczi wrote: +VHDX +M: Jeff Cody jc...@redhat.com +S: Supported +F: block/vhdx.* This should be block/vhdx* instead, to pick up vhdx-endian.c and vhdx-log.c as well. Oops

[Qemu-devel] [PATCH 0/5] qemu-io: readline command completion

2013-11-14 Thread Stefan Hajnoczi
This series decouples readline.c from the QEMU monitor and then reuses it in qemu-io. This adds history and command completion to the qemu-io interactive prompt. Stefan Hajnoczi (5): readline: decouple readline from the monitor readline: move readline to a generic location osdep: add

[Qemu-devel] [PATCH 2/5] readline: move readline to a generic location

2013-11-14 Thread Stefan Hajnoczi
Now that the monitor and readline are decoupled, readline.h no longer belongs in include/monitor/. Put the header into include/qemu/. Move the source file into util/ so it can be linked as part of libqemuutil.a. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- Makefile.objs

[Qemu-devel] [PATCH 1/5] readline: decouple readline from the monitor

2013-11-14 Thread Stefan Hajnoczi
) directly. We no longer need this protection. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hmp.c | 6 +++--- include/monitor/readline.h | 20 +--- monitor.c | 39 --- readline.c | 44

[Qemu-devel] [PATCH 5/5] qemu-io: add command completion

2013-11-14 Thread Stefan Hajnoczi
Autocomplete qemu-io commands at the interactive prompt. Note this only completes command names and not their options. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/qemu-io.h | 3 +++ qemu-io-cmds.c| 15 +++ qemu-io.c | 8 +++- 3 files changed, 25

[Qemu-devel] [PATCH 3/5] osdep: add qemu_set_tty_echo()

2013-11-14 Thread Stefan Hajnoczi
Using stdin with readline.c requires disabling echo and line buffering. Add a portable wrapper to set the terminal attributes under Linux and Windows. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/qemu/osdep.h | 2 ++ util/oslib-posix.c | 18 ++ util/oslib

[Qemu-devel] [PATCH 4/5] qemu-io: use readline.c

2013-11-14 Thread Stefan Hajnoczi
Use readline.c for command-line history. There was support for GNU Readline and BSD Editline but it was never compiled in. Since QEMU has its own readline.c, just use that when qemu-io runs with stdin attached to a terminal. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-io.c

Re: [Qemu-devel] [PATCH] block: Fail if requested driver is not available

2013-11-14 Thread Stefan Hajnoczi
/qemu-iotests/051 | 7 +++ tests/qemu-iotests/051.out | 9 + 3 files changed, 21 insertions(+) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-14 Thread Stefan Hajnoczi
On Tue, Nov 12, 2013 at 01:10:24PM +0200, Avi Kivity wrote: Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since it doesn't have the required capabilities. Fix by adding them. Up until now, downstreams had to make the bridge helper executable setuid, add the

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-14 Thread Stefan Hajnoczi
On Wed, Nov 13, 2013 at 08:37:58PM +0100, Max Reitz wrote: If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector (since it does not exist) and then finishing

[Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n

2013-11-14 Thread Stefan Hajnoczi
newlines exclusively. The result is that patches touching 051.out will apply cleanly without mangling newlines after this commit. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- If you have trouble applying this patch, you can use by git repo: git://github.com/stefanha/qemu.git fix-qemu-io-cr

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc files by default (python -B)

2013-11-14 Thread Stefan Hajnoczi
On Tue, Aug 27, 2013 at 3:12 PM, Stefan Weil s...@weilnetz.de wrote: When a Python script is run, Python normally writes bytecode into a .pyc file. QEMU's build process uses several Python scripts which are called from configure or make. The generated .pyc files take disk space without being

[Qemu-devel] [PATCH for-1.7] tests: add missing -display none to qtests

2013-11-14 Thread Stefan Hajnoczi
to use graphics (GTK or SDL). Since graphics are not used by the test and inappropriate for headless make check runs, add the missing -display none. This fixes make check in the QEMU buildbot. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/blockdev-test.c | 2 +- tests/qdev

Re: [Qemu-devel] [PATCH v5 0/8] Add metadata overlap checks

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 07:37:54PM +0100, Max Reitz wrote: On 05.11.2013 09:51, Stefan Hajnoczi wrote: On Sat, Oct 26, 2013 at 03:03:09PM +0200, Max Reitz wrote: Am 20.09.2013 12:32, schrieb Stefan Hajnoczi: On Thu, Sep 19, 2013 at 05:07:56PM +0200, Max Reitz wrote: As far as I understand

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 03:07:09PM +0100, Paolo Bonzini wrote: Il 14/11/2013 14:41, Stefan Hajnoczi ha scritto: But such a no-op streaming is valid, just like it is valid to enable copy-on-read without a backing file. Think of a system that starts streaming a disk as soon as the VM starts

Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 07:58:00AM -0700, Eric Blake wrote: On 11/14/2013 07:34 AM, Stefan Hajnoczi wrote: SMTP does not preserve newlines. This is normally not a problem if the email body uses DOS or UNIX newlines consistently. In 051.out we mix UNIX newlines with DOS newlines (since

Re: [Qemu-devel] [PATCH (1.7?)] configure: Use -B switch only for Python versions which support it

2013-11-15 Thread Stefan Hajnoczi
fix! Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc files by default (python -B)

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 06:43:48PM +0100, Stefan Weil wrote: Am 14.11.2013 15:45, schrieb Stefan Hajnoczi: On Tue, Aug 27, 2013 at 3:12 PM, Stefan Weil s...@weilnetz.de wrote: When a Python script is run, Python normally writes bytecode into a .pyc file. QEMU's build process uses several

Re: [Qemu-devel] [PATCH] qemu-iotests: Test qcow2 count_contiguous_clusters()

2013-11-15 Thread Stefan Hajnoczi
-iotests/073.out | 118 tests/qemu-iotests/group | 1 + 3 files changed, 285 insertions(+) create mode 100755 tests/qemu-iotests/073 create mode 100644 tests/qemu-iotests/073.out Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this

Re: [Qemu-devel] Git Master does not allow ./configure = python error

2013-11-15 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 11:16:17AM +0100, Erik Rull wrote: Hi all, the current git master of qemu fails on configure: (I did a fresh clone to prevent any side effects) erik@debian:~/tmp/qemu-test/qemu$ ./configure --prefix= --target-list=x86_64-softmmu --disable-vnc-png --disable-vnc-jpeg

Re: [Qemu-devel] [PATCH] smc91c111: Fix receive starvation

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 02:53:46PM +0100, Sebastian Huber wrote: In case the smc91c111 interface signals that it cannot receive more packets the packets are queued and further reception will be disabled. In case the interface is again ready to receive packets notify the upper layer.

Re: [Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

2013-11-15 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 07:00:48PM +0800, Amos Kong wrote: @@ -545,7 +523,7 @@ static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd, return VIRTIO_NET_ERR; } -rxfilter_notify(nc); +rxfilter_notify(nc, object_get_canonical_path(OBJECT(n-qdev)));

Re: [Qemu-devel] [migration] questions about removing the old block-migration code

2013-11-15 Thread Stefan Hajnoczi
On Fri, Nov 08, 2013 at 01:17:17AM +, Zhanghaoyu (A) wrote: I read below words on the report of KVM Live Migration: Weather forecast (May 29, 2013), We were going to remove the old block-migration code Then people fixed it Good: it works now Bad: We have to maintain both It uses

[Qemu-devel] [PULL for-1.7 0/1] Net patches

2013-11-15 Thread Stefan Hajnoczi
A fix for the smc91c111 NIC. The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to

[Qemu-devel] [PULL 1/1] smc91c111: Fix receive starvation

2013-11-15 Thread Stefan Hajnoczi
-by: Sebastian Huber sebastian.hu...@embedded-brains.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/net/smc91c111.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index f5963e2..a8e29b3 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: 2013/11/15 Stefan Hajnoczi stefa...@gmail.com On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when

Re: [Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:20:12PM +0800, Amos Kong wrote: @@ -967,6 +968,27 @@ void print_net_client(Monitor *mon, NetClientState *nc) nc-info_str); } +void rxfilter_notify(NetClientState *nc, Object *obj) +{ +QObject *event_data; +gchar *path =

Re: [Qemu-devel] [PATCH] HMP: snapshot_blkdev can not consider //root/sn1 and /root/sn1 as the same file

2013-11-18 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 10:21:40AM -0700, Eric Blake wrote: On 11/15/2013 09:42 AM, Max Reitz wrote: Actually, the same problem can occur anyway if you have a path with a couple of “.” and “..” in it – or even just a hardlink. Thus, to be completely safe, we'd have to check whether the

Re: [Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 09:39:26PM +0800, Amos Kong wrote: On Mon, Nov 18, 2013 at 02:25:40PM +0100, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 04:20:12PM +0800, Amos Kong wrote: @@ -967,6 +968,27 @@ void print_net_client(Monitor *mon, NetClientState *nc) nc

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 02:52:53PM +1000, Dave Airlie wrote: So after talking to a few people at kvm forum I think the GPU code should probably use the dataplane stuff from the outset, The main advantages I think this gives me is being able to dequeue objects from the vq from a thread and

[Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak

2013-11-18 Thread Stefan Hajnoczi
object_get_canonical_path() returns a string that the caller is responsible for freeing. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index b617f26..fc19cf6 100644

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to

Re: [Qemu-devel] [PATCH for-1.7] tests: add missing -display none to qtests

2013-11-18 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 04:14:11PM +0100, Stefan Hajnoczi wrote: Commit 7ceeedd016facf8d58e14a0d1417fa7225d71072 (blockdev-test: add test case for drive_add duplicate IDs) and commit 43cd209803d6cffb1e1a028c9ff2fd0ff4fce954 (qdev-monitor-test: add device_add leak test cases) added qtest tests

Re: [Qemu-devel] [PATCH] qtest: Adding -display none to new tests

2013-11-18 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 08:54:06PM +0100, Kevin Wolf wrote: Without it, you either get a window for a short time, or worse, test failures when 'make check' isn't run in an X session. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/blockdev-test.c | 2 +- tests/qdev-monitor-test.c

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Please make the default writeback so that ./check completes more quickly. Also, please also indicate in the commit description

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/common | 13 -

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 2 +- tests/endianness-test.c | 6 +++--- tests/fw_cfg-test.c | 3 +--

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:40:39PM +0100, Kevin Wolf wrote: Am 18.11.2013 um 16:32 hat Stefan Hajnoczi geschrieben: On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:20:41PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed

Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 11:32:17PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- v2: put gchar *path inside rxfilter_notify_enabled block --- hw/net/virtio-net.c | 8 1 file

Re: [Qemu-devel] [PATCH v2 for-1.7] qom: Fix memory leak in object_property_set_link()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:52:02PM +0100, Andreas Färber wrote: Am 15.11.2013 18:09, schrieb Vlad Yasevich: Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas

Re: [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:11:43PM +0100, Andreas Färber wrote: Am 18.11.2013 16:10, schrieb Stefan Hajnoczi: object_get_canonical_path() returns a string that the caller is responsible for freeing. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com What's the difference to Vlad's v2

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:54:33PM +0100, Andreas Färber wrote: Am 18.11.2013 17:48, schrieb Stefan Hajnoczi: On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 2 +- tests/endianness-test.c | 6 +++--- tests/fw_cfg-test.c | 3 +--

Re: [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 03:55:45PM -, Varad wrote: Incomplete patch. Usecase: `qemu-img convert` with -p now shows the write speed. 1. I'm calculating the speed using the time taken to run the for(;;) at qemu-img.c:1477. I figured that every time this loop runs, n1 sectors are

Re: [Qemu-devel] [PATCH 0/2] COW: Speed up writes

2013-11-19 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 07:47:00PM +0100, Charlie Shepherd wrote: v4: - Rebase onto master - Fix compilation error v3: - Refix cow_update_bitmap and squash patches 1 3 together to ensuring that we only flush if necessary, patch 1 on its own would change this causing a

[Qemu-devel] [PULL for-1.7 0/1] Block patches

2013-11-19 Thread Stefan Hajnoczi
Fix for block qtest buildbot failure from Andreas. The following changes since commit 06d22aa36706a3d6051b74c8a183ab554a0cb808: block: Fail if requested driver is not available (2013-11-15 13:37:48 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git block

[Qemu-devel] [PULL for-1.7 1/1] qtest: Use -display none by default

2013-11-19 Thread Stefan Hajnoczi
buildbot. -- Stefan] Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/boot-order-test.c | 2 +- tests/endianness-test.c | 6 +++--- tests/fw_cfg-test.c | 3 +-- tests/hd-geo-test.c | 2 +- tests/i440fx-test.c | 2 +- tests

[Qemu-devel] [PULL for-1.7 0/2] Net patches

2013-11-19 Thread Stefan Hajnoczi
Bug fixes for QEMU 1.7. The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch

[Qemu-devel] [PULL for-1.7 2/2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 613f144..b75c753 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -200,16 +200,16

[Qemu-devel] [PULL for-1.7 1/2] smc91c111: Fix receive starvation

2013-11-19 Thread Stefan Hajnoczi
-by: Sebastian Huber sebastian.hu...@embedded-brains.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/net/smc91c111.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index f5963e2..a8e29b3 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c

Re: [Qemu-devel] [PATCH/RFC] qemu-img: show image conversion speed

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 07:25:09PM +0530, Varad Gautam wrote: Calculate and display write speed when converting image with the -p parameter. qemu-progress:qemu_progress_print() now takes speed parameter to print. How well does this approach work in your testing? Calculating a new speed for

Re: [Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 11:48:36AM +0800, Amos Kong wrote: mac_table was always cleaned up first in handling VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover mac_table content in error state, it's not correct. This patch makes all the changes in temporal variables, only update

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 08:18:47AM -0800, Anthony Liguori wrote: On Nov 18, 2013 7:05 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Nov 18, 2013 at 02:52:53PM +1000, Dave Airlie wrote: So after talking to a few people at kvm forum I think the GPU code should probably use

<    5   6   7   8   9   10   11   12   13   14   >